Skip to contentSkip to conversation

Staging: ramster: zcache-main: Fixed Bracing Issues

PATCH In review Jake Champlin 2 participants 2 messages Jan 19, 2013 – Jan 20, 2013 Staging

lore
Share & tools
lore

Jake Champlin

author
#0 lore raw

PATCH 1/1 Staging: ramster: zcache-main: Fixed Bracing Issues

Fixed Coding Style Bracing Issues

Signed-off-by Jake Champlin <[email protected]>
---
 drivers/staging/ramster/zcache-main.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/ramster/zcache-main.c +3 -3
index a09dd5c..2613889 100644
@@ -478,6 +478,7 @@ static void zcache_free_page(struct page *page)
 #ifdef ZCACHE_DEBUG
 	if (curr_pageframes > 2L || curr_pageframes < -2L) {
 		/* pr_info here */
+		/* unnecessary comment */
 	}
 #endif
 }

@@ -1017,11 +1018,10 @@ static int zcache_frontswap_unuse(void)
 		unuse_ret = frontswap_unuse(type, offset,
 				newpage2 != NULL ? newpage2 : evictpage2,
 				ZCACHE_GFP_MASK);
-		if (unuse_ret != 0) {
+		if (unuse_ret != 0)
 			goto free_and_out;
-		} else if (evictpage2 != NULL) {
+		else if (evictpage2 != NULL)
 			zcache_unacct_page();
-		}
 	}
 	ret = 0;
 	goto out;
Signature · 8 lines
1.8.1.1


-- 
Jake Champlin
[email protected]
8123742937
<MuttClient>
maintainer
#1 lore raw
Quoted 12 lines · Jake Champlin

Fixed Coding Style Bracing Issues

Signed-off-by Jake Champlin <[email protected]>
---
 drivers/staging/ramster/zcache-main.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/ramster/zcache-main.c +0 -0
index a09dd5c..2613889 100644

drivers/staging/ramster/zcache-main.c static void zcache_free_page(struct page *page) · line 484

Quoted 7 lines
drivers/staging/ramster/zcache-main.c +1 -0
@@ -478,6 +478,7 @@ static void zcache_free_page(struct page *page)
 #ifdef ZCACHE_DEBUG
 	if (curr_pageframes > 2L || curr_pageframes < -2L) {
 		/* pr_info here */
+		/* unnecessary comment */
 	}
 #endif
 }

That doesn't look like it is fixing any coding style issues, you just added a comment for no reason?

I understand it will shut checkpatch.pl up, but be reasonable here please, it's a tool to be used as a guideline, use your judgement please.

greg k-h