NFSv4 cannot unmount ESTALE directories (in some cases).
Subsystems (2)
If you use NFSv4 to "mount server:/foo/bar /mnt", then "rm -r" /foo/bar on the server, then accesses to /mnt will naturally return ESTALE.
Unfortunately "umount /mnt" will also return ESTALE and leave the stale directory mounted. Adding "-l" or "-f" to "umount" doesn't help.
The problem is that nfs_lookup_revalidate fails. As the mountpoint is never not accessed by a lookup (after the initial mount) it seems a bit pointless calling d_revalidate in this case ... by maybe not.
I can make the problem go away by testing for LOOKUP_JUMP and having nfs_lookup_revalidate never fail if that flag it set (for a directory).
The resulting patch is:
--- fs/nfs/dir.c | 7 +++++++ 1 file changed, 7 insertions(+)
fs/nfs/dir.c +7 -0
@@ -1183,6 +1183,13 @@ out_zap_parent: goto out_valid;if (dentry->d_flags &DCACHE_DISCONNECTED ) goto out_valid; +if (flags &LOOKUP_JUMPED ) +/* Didn't use a name to get here, so saying +* the name is invalid is pointless. +* This allows "umount" to succeed on a +* STALE mountpoint. +*/ + goto out_valid;shrink_dcache_parent (dentry); }d_drop (dentry);
However I cannot easily tell if this is an elegant solution of an ugly hack, and am hoping that someone who understands revalidation and LOOKUP_JUMPED better than I (who only discovered the latter today) could provide advice.
Al? Trond? Should I make this into a formal patch submission, or is there a better way?
Thanks,
NeilBrown
Quoted 7 lines · NeilBrown
If you use NFSv4 to "mount server:/foo/bar /mnt", then "rm -r" /foo/bar on the server, then accesses to /mnt will naturally return ESTALE.
Unfortunately "umount /mnt" will also return ESTALE and leave the stale directory mounted. Adding "-l" or "-f" to "umount" doesn't help.
Quoted 8 lines
The problem is that
nfs_lookup_revalidatefails. As the mountpoint is never not accessed by a lookup (after the initial mount) it seems a bit pointless callingd_revalidatein this case ... by maybe not.I can make the problem go away by testing for
LOOKUP_JUMPand havingnfs_lookup_revalidatenever fail if that flag it set (for a directory).However I cannot easily tell if this is an elegant solution of an ugly hack,
The latter. Definitely.
Quoted 5 lines
and am hoping that someone who understands revalidation and
LOOKUP_JUMPEDbetter than I (who only discovered the latter today) could provide advice.Al? Trond? Should I make this into a formal patch submission, or is there a better way?
I really suspect that mountpoint crossing on umount ought to be done differently. I'll need to play with possible variants a bit before I can offer any replacement though...
Quoted 21 lines · Al Viro
Quoted 6 lines · NeilBrown
If you use NFSv4 to "mount server:/foo/bar /mnt", then "rm -r" /foo/bar on the server, then accesses to /mnt will naturally return ESTALE.
Unfortunately "umount /mnt" will also return ESTALE and leave the stale directory mounted. Adding "-l" or "-f" to "umount" doesn't help.
Quoted 7 lines
The problem is that
nfs_lookup_revalidatefails. As the mountpoint is never not accessed by a lookup (after the initial mount) it seems a bit pointless callingd_revalidatein this case ... by maybe not.I can make the problem go away by testing for
LOOKUP_JUMPand havingnfs_lookup_revalidatenever fail if that flag it set (for a directory). However I cannot easily tell if this is an elegant solution of an ugly hack,The latter. Definitely.
Quoted 5 lines
and am hoping that someone who understands revalidation and
LOOKUP_JUMPEDbetter than I (who only discovered the latter today) could provide advice.Al? Trond? Should I make this into a formal patch submission, or is there a better way?
Quoted 7 lines
I really suspect that mountpoint crossing on umount ought to be done differently. I'll need to play with possible variants a bit before I can offer any replacement though...
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
I'm affected. I've to do exportfs -f to fix the issue. This problem only persists with loop mounts.