Skip to contentSkip to conversation

at91: add bootstrap support

PATCH Superseded Jean-Christophe PLAGNIOL-VILLARD 3 participants 17 messages Jan 21, 2013

Subsystems (5)

v5 of 7 Superseded Latest is v7 →

lore
Share & tools
lore
#0 lore raw

v5 cover at91: add bootstrap support

Hi,

v5:
rebase on Sacha SHELL_NONE patch

v4:
make the code arm & mips supported for barebox head detection

v3:

send correct patch series and pull

can we have it on master the v2 does not cange much since v1

v2:
fix whitesapce
fix comment
fix command default

This patch serie introduce a common bootstrap code aka xloder for TI and at91bootstrap for Atmel to barebox

As I do not have with me right now a TI platform I did not switch it to the new generic bootstrap code.

On at91 add it on the calao usb-a9263 test on nand and spi This patch serie depends on the previous Sacha patch for SHELL_NONE

The following changes since commit a0a9331ba745418f1e7871f5bd707e3cc7e89902:

startup: call a barebox_main function pointer at the end of the startup (2013-01-17 11:56:24 +0800)

are available in the git repository at:

git://git.jcrosoft.org/barebox.git delivery/at91_bootstrap

for you to fetch changes up to 1e59aa94dad142e105baa4059c271353322d98fc:

at91: usb_a9263: add bootstrap version (2013-01-17 12:53:23 +0800)

----------------------------------------------------------------
Jean-Christophe PLAGNIOL-VILLARD (10):
filetype: add is_barebox_mips_head support
filetype: add is_barebox_head
at91: dump mux command: make it depends on COMMAND_SUPPORT
at91: add test commamd to emulate bootrom boot
at91sam926x: lowlevel add external boot support
at91: sam926x: switch lowlevel param to c code
at91: usb-a9263 add lowlevel init
introduce common bootstrap code
at91: add bootstrap version
at91: usb_a9263: add bootstrap version

 arch/arm/boards/at91sam9263ek/Makefile                |    5 ++++
 arch/arm/boards/at91sam9263ek/config.h                |   87 ---------------------------------------------------------------------
 arch/arm/boards/at91sam9263ek/lowlevel_init.c         |  104 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 arch/arm/boards/mmccpu/Makefile                       |    5 ++++
 arch/arm/boards/mmccpu/config.h                       |  118 ----------------------------------------------------------------------------------------------
 arch/arm/boards/mmccpu/lowlevel_init.c                |  135 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 arch/arm/boards/pm9261/Makefile                       |    5 ++++
 arch/arm/boards/pm9261/config.h                       |   87 ---------------------------------------------------------------------
 arch/arm/boards/pm9261/lowlevel_init.c                |  102 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 arch/arm/boards/pm9263/Makefile                       |    5 ++++
 arch/arm/boards/pm9263/config.h                       |  103 ----------------------------------------------------------------------------------
 arch/arm/boards/pm9263/lowlevel_init.c                |  121 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 arch/arm/boards/usb-a926x/Makefile                    |    9 ++++++++
 arch/arm/boards/usb-a926x/usb_a9263_bootstrap.c       |   16 +++++++++++++
 arch/arm/boards/usb-a926x/usb_a9263_lowlevel_init.c   |  111 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 arch/arm/configs/usb_a9263_128mib_bootstrap_defconfig |   27 ++++++++++++++++++++++
 arch/arm/configs/usb_a9263_bootstrap_defconfig        |   26 +++++++++++++++++++++
 arch/arm/mach-at91/Kconfig                            |   16 +++++++++++++
 arch/arm/mach-at91/Makefile                           |    2 ++
 arch/arm/mach-at91/at91sam926x_lowlevel_init.c        |   84 +++++++++++++++++++++++++++++++++++++++++++++++--------------------
 arch/arm/mach-at91/boot_test_cmd.c                    |   95 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 arch/arm/mach-at91/bootstrap.c                        |   95 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 arch/arm/mach-at91/include/mach/at91_lowlevel_init.h  |   33 +++++++++++++++++++++++++++
 arch/arm/mach-at91/include/mach/bootstrap.h           |   28 +++++++++++++++++++++++
 common/filetype.c                                     |    2 +-
 include/bootstrap.h                                   |   34 +++++++++++++++++++++++++++
 include/filetype.h                                    |   21 +++++++++++++++++
 lib/Kconfig                                           |    2 ++
 lib/Makefile                                          |    1 +
 lib/bootstrap/Kconfig                                 |   13 +++++++++++
 lib/bootstrap/Makefile                                |    3 +++
 lib/bootstrap/common.c                                |   21 +++++++++++++++++
 lib/bootstrap/devfs.c                                 |  118 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 lib/bootstrap/disk.c                                  |   37 ++++++++++++++++++++++++++++++
 34 files changed, 1250 insertions(+), 421 deletions(-)
 create mode 100644 arch/arm/boards/at91sam9263ek/lowlevel_init.c
 create mode 100644 arch/arm/boards/mmccpu/lowlevel_init.c
 create mode 100644 arch/arm/boards/pm9261/lowlevel_init.c
 create mode 100644 arch/arm/boards/pm9263/lowlevel_init.c
 create mode 100644 arch/arm/boards/usb-a926x/usb_a9263_bootstrap.c
 create mode 100644 arch/arm/boards/usb-a926x/usb_a9263_lowlevel_init.c
 create mode 100644 arch/arm/configs/usb_a9263_128mib_bootstrap_defconfig
 create mode 100644 arch/arm/configs/usb_a9263_bootstrap_defconfig
 create mode 100644 arch/arm/mach-at91/boot_test_cmd.c
 create mode 100644 arch/arm/mach-at91/bootstrap.c
 create mode 100644 arch/arm/mach-at91/include/mach/at91_lowlevel_init.h
 create mode 100644 arch/arm/mach-at91/include/mach/bootstrap.h
 create mode 100644 include/bootstrap.h
 create mode 100644 lib/bootstrap/Kconfig
 create mode 100644 lib/bootstrap/Makefile
 create mode 100644 lib/bootstrap/common.c
 create mode 100644 lib/bootstrap/devfs.c
 create mode 100644 lib/bootstrap/disk.c

Best Regards,
J.

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

#1 lore raw

PATCH v5 1/10 filetype: add is_barebox_mips_head support

---
 common/filetype.c  |    2 +-
 include/filetype.h |   16 ++++++++++++++++
 2 files changed, 17 insertions(+), 1 deletion(-)
common/filetype.c +1 -1
index 748e364..bafdc31 100644
@@ -145,7 +145,7 @@ enum filetype file_detect_type(void *_buf, size_t bufsize)
 		return filetype_aimage;
 	if (buf64[0] == le64_to_cpu(0x0a1a0a0d474e5089ull))
 		return filetype_png;
-	if (strncmp(buf8 + 0x10, "barebox", 7) == 0)
+	if (is_barebox_mips_head(_buf))
 		return filetype_mips_barebox;
 
 	if (bufsize < 64)
include/filetype.h +16 -0
index 91139db..c2af917 100644
@@ -50,4 +50,20 @@ static inline int is_barebox_arm_head(const char *head)
 }
 #endif
 
+#define MIPS_HEAD_SIZE			0x20
+#define MIPS_HEAD_MAGICWORD_OFFSET	0x10
+#define MIPS_HEAD_SIZE_OFFSET		0x1C
+
+#ifdef CONFIG_MIPS
+static inline int is_barebox_mips_head(const char *head)
+{
+	return !strcmp(head + MIPS_HEAD_MAGICWORD_OFFSET, "barebox");
+}
+#else
+static inline int is_barebox_mips_head(const char *head)
+{
+	return 0;
+}
+#endif
+
 #endif /* __FILE_TYPE_H */
Signature · 7 lines
1.7.10.4


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#2 lore raw

PATCH v5 2/10 filetype: add is_barebox_head

to detect if it's a barebox for the current running arch

---
 include/filetype.h |    5 +++++
 1 file changed, 5 insertions(+)
include/filetype.h +5 -0
index c2af917..a5de4f7 100644
@@ -66,4 +66,9 @@ static inline int is_barebox_mips_head(const char *head)
 }
 #endif
 
+static inline int is_barebox_head(const char *head)
+{
+	return is_barebox_arm_head(head) || is_barebox_mips_head(head);
+}
+
 #endif /* __FILE_TYPE_H */
Signature · 7 lines
1.7.10.4


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#3 lore raw

PATCH v5 3/10 at91: dump mux command: make it depends on COMMAND_SUPPORT

In reply to Jean-Christophe PLAGNIOL-VILLARD

so in bootstrap we do not compile it

---
 arch/arm/mach-at91/Kconfig |    4 ++++
 1 file changed, 4 insertions(+)
arch/arm/mach-at91/Kconfig +4 -0
index fcba7fb..0fd9122 100644
@@ -479,8 +479,12 @@ config CALAO_MB_QIL_A9260
 	bool "MB-QIL A9260 Motherboard Board support"
 	depends on MACH_QIL_A9260
 
+if COMMAND_SUPPORT
+
 config CMD_AT91MUX
 	bool "at91mux dump command"
 	default y
 
 endif
+
+endif
Signature · 7 lines
1.7.10.4


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#4 lore raw

PATCH v5 4/10 at91: add test commamd to emulate bootrom boot

In reply to Jean-Christophe PLAGNIOL-VILLARD
---
 arch/arm/mach-at91/Kconfig         |    6 +++
 arch/arm/mach-at91/Makefile        |    1 +
 arch/arm/mach-at91/boot_test_cmd.c |   95 ++++++++++++++++++++++++++++++++++++
 3 files changed, 102 insertions(+)
 create mode 100644 arch/arm/mach-at91/boot_test_cmd.c
arch/arm/mach-at91/Kconfig +6 -0
index 0fd9122..2815d5f 100644
@@ -485,6 +485,12 @@ config CMD_AT91MUX
 	bool "at91mux dump command"
 	default y
 
+config CMD_AT91_BOOT_TEST
+	bool "at91_boot_test"
+	help
+	  allow to upload a boot binary to sram and execute it
+	  usefull to test bootstrap or barebox lowlevel init
+
 endif
 
 endif
arch/arm/mach-at91/Makefile +1 -0
index 53b4dd8..4404d23 100644
@@ -1,4 +1,5 @@
 obj-y += setup.o clock.o gpio.o
+obj-$(CONFIG_CMD_AT91_BOOT_TEST) += boot_test_cmd.o
 
 lowlevel_init-y = at91sam926x_lowlevel_init.o
 lowlevel_init-$(CONFIG_ARCH_AT91RM9200) = at91rm9200_lowlevel_init.o
arch/arm/mach-at91/boot_test_cmd.c new file +95 -0

95 lines not on this page · raw message

Signature · 7 lines
1.7.10.4


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#5 lore raw

Re: [PATCH 04/10] at91: add test commamd to emulate bootrom boot

hi

2013/1/21 Jean-Christophe PLAGNIOL-VILLARD <[email protected]>

Quoted 101 lines
---
 arch/arm/mach-at91/Kconfig         |    6 +++
 arch/arm/mach-at91/Makefile        |    1 +
 arch/arm/mach-at91/boot_test_cmd.c |   95
++++++++++++++++++++++++++++++++++++
 3 files changed, 102 insertions(+)
 create mode 100644 arch/arm/mach-at91/boot_test_cmd.c
arch/arm/mach-at91/Kconfig +6 -0
index 0fd9122..2815d5f 100644
@@ -485,6 +485,12 @@ config CMD_AT91MUX
        bool "at91mux dump command"
        default y
 
+config CMD_AT91_BOOT_TEST
+       bool "at91_boot_test"
+       help
+         allow to upload a boot binary to sram and execute it
+         usefull to test bootstrap or barebox lowlevel init
+
 endif
 
 endif
arch/arm/mach-at91/Makefile +1 -0
index 53b4dd8..4404d23 100644
@@ -1,4 +1,5 @@
 obj-y += setup.o clock.o gpio.o
+obj-$(CONFIG_CMD_AT91_BOOT_TEST) += boot_test_cmd.o
 
 lowlevel_init-y = at91sam926x_lowlevel_init.o
 lowlevel_init-$(CONFIG_ARCH_AT91RM9200) = at91rm9200_lowlevel_init.o
arch/arm/mach-at91/boot_test_cmd.c new file +2 -0
new file mode 100644
index 0000000..90093d8
@@ -0,0 +1,95 @@
+/*
+ * Copyright (c) 2012 Jean-Christophe PLAGNIOL-VILLARD <

[email protected]>
+ *
+ * Under GPLv2 only
+ */

arch/arm/mach-at91/boot_test_cmd.c new file +49 -0
+
+#include <common.h>
+#include <command.h>
+#include <libbb.h>
+#include <getopt.h>
+#include <fs.h>
+#include <fcntl.h>
+#include <malloc.h>
+#include <errno.h>
+
+static int do_at91_boot_test(int argc, char *argv[])
+{
+       int opt;
+       u32 *buf32;
+       void *buf;
+       void (*jump)(void) = NULL;
+       int fd;
+       int ret = 1;
+       char *sram = "/dev/sram0";
+       u32 read_size, write_size;
+       u32 tmp = 0;
+
+       while ((opt = getopt(argc, argv, "j:s:")) > 0) {
+               switch (opt) {
+               case 'j':
+                       jump = (void*)simple_strtoul(optarg, NULL, 0);
+                       break;
+               case 's':
+                       sram = optarg;
+                       break;
+               default:
+                       return COMMAND_ERROR_USAGE;
+               }
+       }
+
+       if (argc < optind + 1)
+               return COMMAND_ERROR_USAGE;
+
+       buf32 = buf = read_file(argv[optind], &read_size);
+       if (!buf)
+               return -EINVAL;
+
+       write_size = buf32[5];
+
+       printf("size of the size %d\n", read_size);
+       printf("size to load in sram %d\n", write_size);
+
+       if (write_size > read_size) {
+               printf("file smaller than requested sram loading size (%d

< %d)\n", write_size, read_size);

arch/arm/mach-at91/boot_test_cmd.c new file +1 -0
+               goto err;

arch/arm/mach-at91/boot_test_cmd.c line 65

Quoted 10 lines
arch/arm/mach-at91/boot_test_cmd.c new file +10 -0
+       }
+
+       fd = open(sram, O_WRONLY);
+       if (fd < 0) {
+               printf("could not open %s: %s\n", sram, errno_str());
+               ret = fd;
+               goto err;
+       }
+
+       while(write_size) {

while (foo)

Quoted 37 lines
arch/arm/mach-at91/boot_test_cmd.c new file +22 -0
+               tmp = write(fd, buf, write_size);
+               if (tmp < 0) {
+                       perror("write");
+                       goto err_open;
+               }
+               buf += tmp;
+               write_size -= tmp;
+       }
+
+       shutdown_barebox();
+
+       jump();
+
+err_open:
+       close(fd);
+err:
+       free(buf);
+       return ret;
+}
+
+BAREBOX_CMD_HELP_START(at91_boot_test)
+BAREBOX_CMD_HELP_USAGE("at91_boot_test [-j <jump addr>] [-s <sram>]

file\n")
+BAREBOX_CMD_HELP_SHORT("upload the binary to sram and jump as will do the romcode\n")

arch/arm/mach-at91/boot_test_cmd.c new file +5 -0
+BAREBOX_CMD_HELP_END
+
+BAREBOX_CMD_START(at91_boot_test)
+       .cmd            = do_at91_boot_test,
+       .usage          = "upload the binary to sram and jump as will do

the romcode",

arch/arm/mach-at91/boot_test_cmd.c new file +2 -1
+       BAREBOX_CMD_HELP(cmd_at91_boot_test_help)
+BAREBOX_CMD_END
--

1.7.10.4

Quoted 5 lines

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

#6 lore raw

PATCH v5 5/10 at91sam926x: lowlevel add external boot support

In reply to Jean-Christophe PLAGNIOL-VILLARD
---
 arch/arm/mach-at91/at91sam926x_lowlevel_init.c |   20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)
arch/arm/mach-at91/at91sam926x_lowlevel_init.c +18 -2
index cfae982..4dec275 100644
@@ -36,10 +36,19 @@ static void inline pmc_check_mckrdy(void)
 	} while (!(r & AT91_PMC_MCKRDY));
 }
 
+static int inline running_in_sram(void)
+{
+	u32 addr = get_pc();
+
+	addr >>= 28;
+	return addr == 0;
+}
+
 void __naked __bare_init reset(void)
 {
 	u32 r;
 	int i;
+	int in_sram = running_in_sram();
 
 	common_reset();
 
@@ -74,7 +83,7 @@ void __naked __bare_init reset(void)
 	 * PMC Check if the PLL is already initialized
 	 */
 	r = at91_pmc_read(AT91_PMC_MCKR);
-	if (r & AT91_PMC_CSS)
+	if (r & AT91_PMC_CSS && !in_sram)
 		goto end;
 
 	/*
@@ -117,7 +126,7 @@ void __naked __bare_init reset(void)
 	 * SDRAMC Check if Refresh Timer Counter is already initialized
 	 */
 	r = at91_sys_read(AT91_SDRAMC_TR);
-	if (r)
+	if (r && !in_sram)
 		goto end;
 
 	/* SDRAMC_MR : Normal Mode */
@@ -170,6 +179,13 @@ void __naked __bare_init reset(void)
 	/* MATRIX_MCFG - REMAP all masters */
 	at91_sys_write(AT91_MATRIX_MCFG0, 0x1FF);
 #endif
+	/*
+	 * When boot from external boot
+	 * we need to enable mck and ohter clock
+	 * so enable all of them
+	 * We will shutdown what we don't need later
+	 */
+	at91_pmc_write(AT91_PMC_PCER, 0xffffffff);
 
 end:
 	board_init_lowlevel_return();
Signature · 7 lines
1.7.10.4


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#7 lore raw

PATCH v5 6/10 at91: sam926x: switch lowlevel param to c code

In reply to Jean-Christophe PLAGNIOL-VILLARD

Instead of hardcode define use a struct that the board fill

---
 arch/arm/boards/at91sam9263ek/Makefile             |    5 +
 arch/arm/boards/at91sam9263ek/config.h             |   99 +-------------
 arch/arm/boards/at91sam9263ek/lowlevel_init.c      |  104 +++++++++++++++
 arch/arm/boards/mmccpu/Makefile                    |    5 +
 arch/arm/boards/mmccpu/config.h                    |  130 +------------------
 arch/arm/boards/mmccpu/lowlevel_init.c             |  135 ++++++++++++++++++++
 arch/arm/boards/pm9261/Makefile                    |    5 +
 arch/arm/boards/pm9261/config.h                    |   99 +-------------
 arch/arm/boards/pm9261/lowlevel_init.c             |  102 +++++++++++++++
 arch/arm/boards/pm9263/Makefile                    |    5 +
 arch/arm/boards/pm9263/config.h                    |  115 +----------------
 arch/arm/boards/pm9263/lowlevel_init.c             |  121 ++++++++++++++++++
 arch/arm/mach-at91/at91sam926x_lowlevel_init.c     |   64 ++++++----
 .../mach-at91/include/mach/at91_lowlevel_init.h    |   33 +++++
 14 files changed, 580 insertions(+), 442 deletions(-)
 rewrite arch/arm/boards/at91sam9263ek/config.h (95%)
 create mode 100644 arch/arm/boards/at91sam9263ek/lowlevel_init.c
 rewrite arch/arm/boards/mmccpu/config.h (97%)
 create mode 100644 arch/arm/boards/mmccpu/lowlevel_init.c
 rewrite arch/arm/boards/pm9261/config.h (95%)
 create mode 100644 arch/arm/boards/pm9261/lowlevel_init.c
 rewrite arch/arm/boards/pm9263/config.h (97%)
 create mode 100644 arch/arm/boards/pm9263/lowlevel_init.c
 create mode 100644 arch/arm/mach-at91/include/mach/at91_lowlevel_init.h
arch/arm/boards/at91sam9263ek/Makefile +5 -0
index eb072c0..aecbc5a 100644
@@ -1 +1,6 @@
 obj-y += init.o
+
+lowlevel_init-y = lowlevel_init.o
+obj-$(CONFIG_MACH_DO_LOWLEVEL_INIT) += $(lowlevel_init-y)
+
+pbl-$(CONFIG_MACH_DO_LOWLEVEL_INIT) += $(lowlevel_init-y)
arch/arm/boards/at91sam9263ek/config.h +6 -93

99 lines not on this page · raw message

arch/arm/boards/at91sam9263ek/lowlevel_init.c new file +104 -0

104 lines not on this page · raw message

arch/arm/boards/mmccpu/Makefile +5 -0
index eb072c0..aecbc5a 100644
@@ -1 +1,6 @@
 obj-y += init.o
+
+lowlevel_init-y = lowlevel_init.o
+obj-$(CONFIG_MACH_DO_LOWLEVEL_INIT) += $(lowlevel_init-y)
+
+pbl-$(CONFIG_MACH_DO_LOWLEVEL_INIT) += $(lowlevel_init-y)
arch/arm/boards/mmccpu/config.h +6 -124

130 lines not on this page · raw message

arch/arm/boards/mmccpu/lowlevel_init.c new file +135 -0

135 lines not on this page · raw message

arch/arm/boards/pm9261/Makefile +5 -0
index eb072c0..aecbc5a 100644
@@ -1 +1,6 @@
 obj-y += init.o
+
+lowlevel_init-y = lowlevel_init.o
+obj-$(CONFIG_MACH_DO_LOWLEVEL_INIT) += $(lowlevel_init-y)
+
+pbl-$(CONFIG_MACH_DO_LOWLEVEL_INIT) += $(lowlevel_init-y)
arch/arm/boards/pm9261/config.h +6 -93

99 lines not on this page · raw message

arch/arm/boards/pm9261/lowlevel_init.c new file +102 -0

102 lines not on this page · raw message

arch/arm/boards/pm9263/Makefile +5 -0
index eb072c0..aecbc5a 100644
@@ -1 +1,6 @@
 obj-y += init.o
+
+lowlevel_init-y = lowlevel_init.o
+obj-$(CONFIG_MACH_DO_LOWLEVEL_INIT) += $(lowlevel_init-y)
+
+pbl-$(CONFIG_MACH_DO_LOWLEVEL_INIT) += $(lowlevel_init-y)
arch/arm/boards/pm9263/config.h +6 -109

115 lines not on this page · raw message

arch/arm/boards/pm9263/lowlevel_init.c new file +121 -0

121 lines not on this page · raw message

arch/arm/mach-at91/at91sam926x_lowlevel_init.c +41 -23

146 lines not on this page · raw message

arch/arm/mach-at91/include/mach/at91_lowlevel_init.h new file +33 -0
new file mode 100644
index 0000000..29d9628
@@ -0,0 +1,33 @@
+/*
+ * Copyright (C) 2009-2011 Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
+ *
+ * Under GPLv2
+ */
+
+#ifndef __AT91_LOWLEVEL_INIT_H__
+#define __AT91_LOWLEVEL_INIT_H__
+
+struct at91sam926x_lowlevel_cfg {
+	u32 wdt_mr;
+	u32 ebi_pio_pdr;
+	u32 ebi_pio_ppudr;
+	u32 ebi_csa;
+	u32 smc_cs;
+	u32 smc_mode;
+	u32 smc_cycle;
+	u32 smc_pulse;
+	u32 smc_setup;
+	u32 pmc_mor;
+	u32 pmc_pllar;
+	u32 pmc_mckr1;
+	u32 pmc_mckr2;
+	u32 sdrc_cr;
+	u32 sdrc_tr1;
+	u32 sdrc_mdr;
+	u32 sdrc_tr2;
+	u32 rstc_rmr;
+};
+
+void at91sam926x_lowlevel_board_config(struct at91sam926x_lowlevel_cfg *cfg);
+
+#endif /* __AT91_LOWLEVEL_INIT_H__ */
Signature · 7 lines
1.7.10.4


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#8 lore raw

PATCH v5 7/10 at91: usb-a9263 add lowlevel init

In reply to Jean-Christophe PLAGNIOL-VILLARD
---
 arch/arm/boards/usb-a926x/Makefile                 |    6 ++
 .../arm/boards/usb-a926x/usb_a9263_lowlevel_init.c |  111 ++++++++++++++++++++
 arch/arm/mach-at91/Kconfig                         |    1 +
 3 files changed, 118 insertions(+)
 create mode 100644 arch/arm/boards/usb-a926x/usb_a9263_lowlevel_init.c
arch/arm/boards/usb-a926x/Makefile +6 -0
index eb072c0..9511a76 100644
@@ -1 +1,7 @@
 obj-y += init.o
+
+lowlevel_init-$(CONFIG_MACH_USB_A9263) = usb_a9263_lowlevel_init.o
+
+obj-$(CONFIG_MACH_DO_LOWLEVEL_INIT) += $(lowlevel_init-y)
+
+pbl-$(CONFIG_MACH_DO_LOWLEVEL_INIT) += $(lowlevel_init-y)
arch/arm/boards/usb-a926x/usb_a9263_lowlevel_init.c new file +111 -0

111 lines not on this page · raw message

arch/arm/mach-at91/Kconfig +1 -0
index 2815d5f..101b2b7 100644
@@ -357,6 +357,7 @@ config MACH_TNY_A9263
 
 config MACH_USB_A9263
 	bool "CALAO USB-A9263"
+	select MACH_HAS_LOWLEVEL_INIT
 	help
 	  Select this if you are using a Calao Systems USB-A9263.
 	  <http://www.calao-systems.com>
Signature · 7 lines
1.7.10.4


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#9 lore raw

PATCH v5 8/10 introduce common bootstrap code

In reply to Jean-Christophe PLAGNIOL-VILLARD

This will allow to have a generic code to create different bootstrap

As example
Barebox as TI Xloader
Barebox as AT91 Bootstrap

---
 include/bootstrap.h    |   34 ++++++++++++++
 lib/Kconfig            |    2 +
 lib/Makefile           |    1 +
 lib/bootstrap/Kconfig  |   13 ++++++
 lib/bootstrap/Makefile |    3 ++
 lib/bootstrap/common.c |   21 +++++++++
 lib/bootstrap/devfs.c  |  118 ++++++++++++++++++++++++++++++++++++++++++++++++
 lib/bootstrap/disk.c   |   37 +++++++++++++++
 8 files changed, 229 insertions(+)
 create mode 100644 include/bootstrap.h
 create mode 100644 lib/bootstrap/Kconfig
 create mode 100644 lib/bootstrap/Makefile
 create mode 100644 lib/bootstrap/common.c
 create mode 100644 lib/bootstrap/devfs.c
 create mode 100644 lib/bootstrap/disk.c
include/bootstrap.h new file +34 -0
new file mode 100644
index 0000000..26e9dbc
@@ -0,0 +1,34 @@
+/*
+ * Copyright (C) 2012 Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
+ *
+ * Under GPLv2
+ */
+
+#ifndef __BOOSTRAP_H__
+#define __BOOSTRAP_H__
+
+#define bootstrap_err(fmt, arg...) printf(fmt, ##arg)
+
+void bootstrap_boot(int (*func)(void), bool barebox);
+
+#ifdef CONFIG_BOOTSTRAP_DEVFS
+void* bootstrap_read_devfs(char *devname, bool use_bb, int offset,
+			   int default_size, int max_size);
+#else
+static inline void* bootstrap_read_devfs(char *devname, bool use_bb, int offset,
+			   int default_size, int max_size)
+{
+	return NULL;
+}
+#endif
+
+#ifdef CONFIG_BOOTSTRAP_DISK
+void* bootstrap_read_disk(char *devname);
+#else
+static inline void* bootstrap_read_disk(char *devname)
+{
+	return NULL;
+}
+#endif
+
+#endif /* __BOOSTRAP_H__ */
lib/Kconfig +2 -0
index db8a6ad..4578353 100644
@@ -52,4 +52,6 @@ config LIBMTD
 
 source lib/gui/Kconfig
 
+source lib/bootstrap/Kconfig
+
 endmenu
lib/Makefile +1 -0
index 85f4ec9..43f6ea3 100644
@@ -1,3 +1,4 @@
+obj-$(CONFIG_BOOTSTRAP)	+= bootstrap/
 obj-y			+= ctype.o
 obj-y			+= rbtree.o
 obj-y			+= display_options.o
lib/bootstrap/Kconfig new file +13 -0
new file mode 100644
index 0000000..558da00
@@ -0,0 +1,13 @@
+menuconfig BOOTSTRAP
+	bool "Library bootstrap routines           "
+	depends on SHELL_NONE
+
+if BOOTSTRAP
+
+config BOOTSTRAP_DEVFS
+	bool "devfs support"
+
+config BOOTSTRAP_DISK
+	bool "disk support"
+
+endif
lib/bootstrap/Makefile new file +3 -0
new file mode 100644
index 0000000..cbaa49f
@@ -0,0 +1,3 @@
+obj-y				+= common.o
+obj-$(CONFIG_BOOTSTRAP_DEVFS)	+= devfs.o
+obj-$(CONFIG_BOOTSTRAP_DISK)	+= disk.o
lib/bootstrap/common.c new file +21 -0
new file mode 100644
index 0000000..3652698
@@ -0,0 +1,21 @@
+/*
+ * Copyright (C) 2011 Sascha Hauer, Pengutronix
+ * Copyright (C) 2012 Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
+ *
+ * Under GPLv2
+ */
+
+#include <common.h>
+#include <bootstrap.h>
+#include <filetype.h>
+
+void bootstrap_boot(int (*func)(void), bool barebox)
+{
+	if (barebox && !is_barebox_head((void*)func))
+		return;
+
+	shutdown_barebox();
+	func();
+
+	while (1);
+}
lib/bootstrap/devfs.c new file +118 -0

118 lines not on this page · raw message

lib/bootstrap/disk.c new file +37 -0
new file mode 100644
index 0000000..fad8990
@@ -0,0 +1,37 @@
+/*
+ * Copyright (C) 2011 Sascha Hauer, Pengutronix
+ * Copyright (C) 2012 Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
+ *
+ * Under GPLv2
+ */
+
+#include <common.h>
+#include <fs.h>
+#include <fcntl.h>
+#include <sizes.h>
+#include <errno.h>
+#include <malloc.h>
+#include <bootstrap.h>
+
+void* bootstrap_read_disk(char *dev)
+{
+	int ret;
+	void *buf;
+	int len;
+	char *path = "/";
+
+	ret = mount(dev, "fat", path);
+	if (ret) {
+		bootstrap_err("mounting %s failed with %d\n", dev, ret);
+		return NULL;
+	}
+
+	buf = read_file("/barebox.bin", &len);
+	if (!buf) {
+		bootstrap_err("could not read barebox.bin from %s\n", dev);
+		umount(path);
+		return NULL;
+	}
+
+	return buf;
+}
Signature · 7 lines
1.7.10.4


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#10 lore raw

Re: [PATCH 08/10] introduce common bootstrap code

hi,

found a little 'things'. Maybe it's matter.

2013/1/21 Jean-Christophe PLAGNIOL-VILLARD <[email protected]>

Quoted 182 lines

This will allow to have a generic code to create different bootstrap

As example
Barebox as TI Xloader
Barebox as AT91 Bootstrap

---
 include/bootstrap.h    |   34 ++++++++++++++
 lib/Kconfig            |    2 +
 lib/Makefile           |    1 +
 lib/bootstrap/Kconfig  |   13 ++++++
 lib/bootstrap/Makefile |    3 ++
 lib/bootstrap/common.c |   21 +++++++++
 lib/bootstrap/devfs.c  |  118
++++++++++++++++++++++++++++++++++++++++++++++++
 lib/bootstrap/disk.c   |   37 +++++++++++++++
 8 files changed, 229 insertions(+)
 create mode 100644 include/bootstrap.h
 create mode 100644 lib/bootstrap/Kconfig
 create mode 100644 lib/bootstrap/Makefile
 create mode 100644 lib/bootstrap/common.c
 create mode 100644 lib/bootstrap/devfs.c
 create mode 100644 lib/bootstrap/disk.c
include/bootstrap.h new file +2 -0
new file mode 100644
index 0000000..26e9dbc
@@ -0,0 +1,34 @@
+/*
+ * Copyright (C) 2012 Jean-Christophe PLAGNIOL-VILLARD <

[email protected]>
+ *
+ * Under GPLv2
+ */

include/bootstrap.h new file +13 -0
+
+#ifndef __BOOSTRAP_H__
+#define __BOOSTRAP_H__
+
+#define bootstrap_err(fmt, arg...) printf(fmt, ##arg)
+
+void bootstrap_boot(int (*func)(void), bool barebox);
+
+#ifdef CONFIG_BOOTSTRAP_DEVFS
+void* bootstrap_read_devfs(char *devname, bool use_bb, int offset,
+                          int default_size, int max_size);
+#else
+static inline void* bootstrap_read_devfs(char *devname, bool use_bb, int

offset,

include/bootstrap.h new file +16 -0
+                          int default_size, int max_size)
+{
+       return NULL;
+}
+#endif
+
+#ifdef CONFIG_BOOTSTRAP_DISK
+void* bootstrap_read_disk(char *devname);
+#else
+static inline void* bootstrap_read_disk(char *devname)
+{
+       return NULL;
+}
+#endif
+
+#endif /* __BOOSTRAP_H__ */
lib/Kconfig +2 -0
index db8a6ad..4578353 100644
@@ -52,4 +52,6 @@ config LIBMTD
 
 source lib/gui/Kconfig
 
+source lib/bootstrap/Kconfig
+
 endmenu
lib/Makefile +1 -0
index 85f4ec9..43f6ea3 100644
@@ -1,3 +1,4 @@
+obj-$(CONFIG_BOOTSTRAP)        += bootstrap/
 obj-y                  += ctype.o
 obj-y                  += rbtree.o
 obj-y                  += display_options.o
lib/bootstrap/Kconfig new file +13 -0
new file mode 100644
index 0000000..558da00
@@ -0,0 +1,13 @@
+menuconfig BOOTSTRAP
+       bool "Library bootstrap routines           "
+       depends on SHELL_NONE
+
+if BOOTSTRAP
+
+config BOOTSTRAP_DEVFS
+       bool "devfs support"
+
+config BOOTSTRAP_DISK
+       bool "disk support"
+
+endif
lib/bootstrap/Makefile new file +3 -0
new file mode 100644
index 0000000..cbaa49f
@@ -0,0 +1,3 @@
+obj-y                          += common.o
+obj-$(CONFIG_BOOTSTRAP_DEVFS)  += devfs.o
+obj-$(CONFIG_BOOTSTRAP_DISK)   += disk.o
lib/bootstrap/common.c new file +3 -0
new file mode 100644
index 0000000..3652698
@@ -0,0 +1,21 @@
+/*
+ * Copyright (C) 2011 Sascha Hauer, Pengutronix
+ * Copyright (C) 2012 Jean-Christophe PLAGNIOL-VILLARD <

[email protected]>
+ *
+ * Under GPLv2
+ */

lib/bootstrap/common.c new file +15 -0
+
+#include <common.h>
+#include <bootstrap.h>
+#include <filetype.h>
+
+void bootstrap_boot(int (*func)(void), bool barebox)
+{
+       if (barebox && !is_barebox_head((void*)func))
+               return;
+
+       shutdown_barebox();
+       func();
+
+       while (1);
+}
lib/bootstrap/devfs.c new file +3 -0
new file mode 100644
index 0000000..25d07c7
@@ -0,0 +1,118 @@
+/*
+ * Copyright (C) 2011 Sascha Hauer, Pengutronix
+ * Copyright (C) 2012 Jean-Christophe PLAGNIOL-VILLARD <

[email protected]>
+ *
+ * Under GPLv2
+ */

lib/bootstrap/devfs.c new file +25 -0
+
+#include <common.h>
+#include <partition.h>
+#include <nand.h>
+#include <driver.h>
+#include <linux/mtd/mtd.h>
+#include <fcntl.h>
+#include <filetype.h>
+#include <sizes.h>
+#include <errno.h>
+#include <malloc.h>
+#include <bootstrap.h>
+
+#if defined(CONFIG_ARM) || defined(CONFIG_MIPS)
+#if defined(CONFIG_ARM)
+#define BAREBOX_HEAD_SIZE              ARM_HEAD_SIZE
+#define BAREBOX_HEAD_SIZE_OFFSET       ARM_HEAD_SIZE_OFFSET
+#elif defined(CONFIG_MIPS)
+#define BAREBOX_HEAD_SIZE              MIPS_HEAD_SIZE
+#define BAREBOX_HEAD_SIZE_OFFSET       MIPS_HEAD_SIZE_OFFSET
+#endif
+
+static void *read_image_head(const char *name)
+{
+       void *header = xmalloc(BAREBOX_HEAD_SIZE);

lib/bootstrap/devfs.c line 41

Quoted 10 lines
lib/bootstrap/devfs.c new file +10 -0
+       struct cdev *cdev;
+       int ret;
+
+       cdev = cdev_open(name, O_RDONLY);
+       if (!cdev) {
+               bootstrap_err("failed to open partition\n");
+               return NULL;
+       }
+
+       ret = cdev_read(cdev, header, BAREBOX_HEAD_SIZE, 0, 0);

check on error here?

Quoted 62 lines
lib/bootstrap/devfs.c new file +43 -0
+       cdev_close(cdev);
+
+       if (ret != BAREBOX_HEAD_SIZE) {
+               bootstrap_err("failed to read from partition\n");
+               return NULL;
+       }
+
+       return header;
+}
+
+static unsigned int get_image_size(void *head)
+{
+       unsigned int ret = 0;
+       unsigned int *psize = head + BAREBOX_HEAD_SIZE_OFFSET;
+
+       if (is_barebox_head(head))
+               ret = *psize;
+       debug("Detected barebox image size %u\n", ret);
+
+       return ret;
+}
+#else
+static void *read_image_head(const char *name)
+{
+       return NULL;
+}
+
+static unsigned int get_image_size(void *head)
+{
+       return 0;
+}
+#endif
+
+void* bootstrap_read_devfs(char *devname, bool use_bb, int offset,
+                          int default_size, int max_size)
+{
+       int ret;
+       int size = 0;
+       void *to, *header;
+       struct cdev *cdev;
+       char *partname = "x";
+
+       devfs_add_partition(devname, offset, max_size,

DEVFS_PARTITION_FIXED, partname);

lib/bootstrap/devfs.c new file +10 -0
+       if (use_bb) {
+               dev_add_bb_dev(partname, "bbx");
+               partname = "bbx";
+       }
+
+       header = read_image_head(partname);
+       if (header) {
+               size = get_image_size(header);
+               if (!size)
+                       bootstrap_err("%s: failed to get image size\n",

devname);

lib/bootstrap/devfs.c new file +5 -0
+       }
+
+       if (!size) {
+               size = default_size;
+               bootstrap_err("%s: failed to detect barebox and it's image

size so use %d\n",

lib/bootstrap/devfs.c line 103

Quoted 4 lines
lib/bootstrap/devfs.c new file +4 -0
+                        devname, size);
+       }
+
+       to = xmalloc(size);

check on null here?

Quoted 44 lines
lib/bootstrap/devfs.c new file +4 -0
+
+       cdev = cdev_open(partname, O_RDONLY);
+       if (!cdev) {
+               bootstrap_err("%s: failed to open %s\n", devname,

partname);

lib/bootstrap/devfs.c new file +6 -0
+               return NULL;
+       }
+
+       ret = cdev_read(cdev, to, size, 0, 0);
+       if (ret != size) {
+               bootstrap_err("%s: failed to read from %s\n", devname,

partname);

lib/bootstrap/devfs.c new file +5 -0
+               return NULL;
+       }
+
+       return to;
+}
lib/bootstrap/disk.c new file +3 -0
new file mode 100644
index 0000000..fad8990
@@ -0,0 +1,37 @@
+/*
+ * Copyright (C) 2011 Sascha Hauer, Pengutronix
+ * Copyright (C) 2012 Jean-Christophe PLAGNIOL-VILLARD <

[email protected]>
+ *
+ * Under GPLv2
+ */

lib/bootstrap/disk.c new file +13 -0
+
+#include <common.h>
+#include <fs.h>
+#include <fcntl.h>
+#include <sizes.h>
+#include <errno.h>
+#include <malloc.h>
+#include <bootstrap.h>
+
+void* bootstrap_read_disk(char *dev)
+{
+       int ret;
+       void *buf;

lib/bootstrap/disk.c line 29

Quoted 10 lines
lib/bootstrap/disk.c new file +10 -0
+       int len;
+       char *path = "/";
+
+       ret = mount(dev, "fat", path);
+       if (ret) {
+               bootstrap_err("mounting %s failed with %d\n", dev, ret);
+               return NULL;
+       }
+
+       buf = read_file("/barebox.bin", &len);

Can be set to read_file("/barebox.bin", null);

Quoted 12 lines
lib/bootstrap/disk.c new file +8 -1
+       if (!buf) {
+               bootstrap_err("could not read barebox.bin from %s\n", dev);
+               umount(path);
+               return NULL;
+       }
+
+       return buf;
+}
--

1.7.10.4

Quoted 5 lines

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

#11 lore raw

Re: [PATCH 08/10] introduce common bootstrap code

Quoted 4 lines · Alexander Aring

hi,

found a little 'things'. Maybe it's matter.

Quoted 11 lines

lib/bootstrap/devfs.c line 41

Quoted 9 lines
lib/bootstrap/devfs.c new file +8 -0
+
+       cdev = cdev_open(name, O_RDONLY);
+       if (!cdev) {
+               bootstrap_err("failed to open partition\n");
+               return NULL;
+       }
+
+       ret = cdev_read(cdev, header, BAREBOX_HEAD_SIZE, 0, 0);

check on error here?

This is done, see below.

Quoted 14 lines
Quoted 14 lines
lib/bootstrap/devfs.c new file +13 -0
+       cdev_close(cdev);
+
+       if (ret != BAREBOX_HEAD_SIZE) {
+               bootstrap_err("failed to read from partition\n");
+               return NULL;
+       }
+
+       return header;
+}
+
+
+       if (!size) {
+               size = default_size;
Quoted 8 lines

lib/bootstrap/devfs.c line 103

Quoted 7 lines

+ bootstrap_err("%s: failed to detect barebox and it's image
size so use %d\n",

lib/bootstrap/devfs.c new file +4 -0
+                        devname, size);
+       }
+
+       to = xmalloc(size);

check on null here?

The x versions always return memory or else they panic.

Sascha

Signature · 9 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#12 lore raw

Re: [PATCH 08/10] introduce common bootstrap code

Hi,

ok, thanks for this information.

Regards
Alex

2013/1/21 Sascha Hauer <[email protected]>

Quoted 45 lines · Alexander Aring
Quoted 4 lines

hi,

found a little 'things'. Maybe it's matter.

Quoted 11 lines

lib/bootstrap/devfs.c line 41

Quoted 9 lines
lib/bootstrap/devfs.c new file +8 -0
+
+       cdev = cdev_open(name, O_RDONLY);
+       if (!cdev) {
+               bootstrap_err("failed to open partition\n");
+               return NULL;
+       }
+
+       ret = cdev_read(cdev, header, BAREBOX_HEAD_SIZE, 0, 0);

check on error here?

This is done, see below.

Quoted 15 lines
Quoted 5 lines
lib/bootstrap/devfs.c new file +4 -0
+       cdev_close(cdev);
+
+       if (ret != BAREBOX_HEAD_SIZE) {
+               bootstrap_err("failed to read from partition\n");

lib/bootstrap/devfs.c

Quoted 10 lines
lib/bootstrap/devfs.c new file +10 -0
+               return NULL;
+       }
+
+       return header;
+}
+
+
+       if (!size) {
+               size = default_size;
+               bootstrap_err("%s: failed to detect barebox and it's

image

Quoted 7 lines

lib/bootstrap/devfs.c line 103

Quoted 6 lines

size so use %d\n",

lib/bootstrap/devfs.c new file +4 -0
+                        devname, size);
+       }
+
+       to = xmalloc(size);

check on null here?

The x versions always return memory or else they panic.

Quoted 9 lines

Sascha

--

Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

#13 lore raw

Re: [PATCH 08/10] introduce common bootstrap code

In reply to Sascha Hauer
Quoted 42 lines · Sascha Hauer
Quoted 4 lines · Alexander Aring

hi,

found a little 'things'. Maybe it's matter.

Quoted 11 lines

lib/bootstrap/devfs.c line 41

Quoted 9 lines
lib/bootstrap/devfs.c new file +8 -0
+
+       cdev = cdev_open(name, O_RDONLY);
+       if (!cdev) {
+               bootstrap_err("failed to open partition\n");
+               return NULL;
+       }
+
+       ret = cdev_read(cdev, header, BAREBOX_HEAD_SIZE, 0, 0);

check on error here?

This is done, see below.

Quoted 14 lines
Quoted 14 lines
lib/bootstrap/devfs.c new file +13 -0
+       cdev_close(cdev);
+
+       if (ret != BAREBOX_HEAD_SIZE) {
+               bootstrap_err("failed to read from partition\n");
+               return NULL;
+       }
+
+       return header;
+}
+
+
+       if (!size) {
+               size = default_size;
Quoted 8 lines

lib/bootstrap/devfs.c line 103

Quoted 7 lines

+ bootstrap_err("%s: failed to detect barebox and it's image
size so use %d\n",

lib/bootstrap/devfs.c new file +4 -0
+                        devname, size);
+       }
+
+       to = xmalloc(size);

check on null here?

Quoted 1 line

The x versions always return memory or else they panic.

can we have this version merged

Best Regards,
J.

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

#14 lore raw

Re: [PATCH 08/10] introduce common bootstrap code

Quoted 43 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 42 lines · Sascha Hauer
Quoted 4 lines · Alexander Aring

hi,

found a little 'things'. Maybe it's matter.

Quoted 11 lines

lib/bootstrap/devfs.c line 41

Quoted 9 lines
lib/bootstrap/devfs.c new file +8 -0
+
+       cdev = cdev_open(name, O_RDONLY);
+       if (!cdev) {
+               bootstrap_err("failed to open partition\n");
+               return NULL;
+       }
+
+       ret = cdev_read(cdev, header, BAREBOX_HEAD_SIZE, 0, 0);

check on error here?

This is done, see below.

Quoted 22 lines
Quoted 17 lines
lib/bootstrap/devfs.c new file +14 -0
+       cdev_close(cdev);
+
+       if (ret != BAREBOX_HEAD_SIZE) {
+               bootstrap_err("failed to read from partition\n");
+               return NULL;
+       }
+
+       return header;
+}
+
+
+       if (!size) {
+               size = default_size;
+               bootstrap_err("%s: failed to detect barebox and it's image

size so use %d\n",

lib/bootstrap/devfs.c line 103

Quoted 4 lines
lib/bootstrap/devfs.c new file +4 -0
+                        devname, size);
+       }
+
+       to = xmalloc(size);

check on null here?

Quoted 3 lines
Quoted 1 line

The x versions always return memory or else they panic.

can we have this version merged

I send a v6

I switch the omal xlaod to the new generic code and see that we need to be able to pass the fstype

Best Regards,
J.

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

#15 lore raw

PATCH v5 9/10 at91: add bootstrap version

In reply to Jean-Christophe PLAGNIOL-VILLARD

This will allow to boot from NAND/MMC and others.
This version of bootstrap is a non shell version of barebox compressed by the pbl.

---
 arch/arm/mach-at91/Kconfig                  |    5 ++
 arch/arm/mach-at91/Makefile                 |    1 +
 arch/arm/mach-at91/bootstrap.c              |   95 +++++++++++++++++++++++++++
 arch/arm/mach-at91/include/mach/bootstrap.h |   28 ++++++++
 4 files changed, 129 insertions(+)
 create mode 100644 arch/arm/mach-at91/bootstrap.c
 create mode 100644 arch/arm/mach-at91/include/mach/bootstrap.h
arch/arm/mach-at91/Kconfig +5 -0
index 101b2b7..f2d434b 100644
@@ -494,4 +494,9 @@ config CMD_AT91_BOOT_TEST
 
 endif
 
+config AT91_BOOTSTRAP
+	bool "at91 bootstrap"
+	depends on MACH_HAS_LOWLEVEL_INIT
+	select BOOTSTRAP
+
 endif
arch/arm/mach-at91/Makefile +1 -0
index 4404d23..634b160 100644
@@ -1,6 +1,7 @@
 obj-y += setup.o clock.o gpio.o
 obj-$(CONFIG_CMD_AT91_BOOT_TEST) += boot_test_cmd.o
 
+obj-$(CONFIG_AT91_BOOTSTRAP) += bootstrap.o
 lowlevel_init-y = at91sam926x_lowlevel_init.o
 lowlevel_init-$(CONFIG_ARCH_AT91RM9200) = at91rm9200_lowlevel_init.o
 obj-$(CONFIG_MACH_DO_LOWLEVEL_INIT) += $(lowlevel_init-y)
arch/arm/mach-at91/bootstrap.c new file +95 -0

95 lines not on this page · raw message

arch/arm/mach-at91/include/mach/bootstrap.h new file +28 -0
new file mode 100644
index 0000000..a3d19dd
@@ -0,0 +1,28 @@
+/*
+ * Copyright (C) 2012 Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
+ *
+ * Under GPLv2
+ */
+
+#ifndef __MACH_BOOTSTRAP_H__
+#define __MACH_BOOTSTRAP_H__
+
+#ifdef CONFIG_MTD_M25P80
+void * bootstrap_board_read_m25p80(void);
+#else
+static inline void * bootstrap_board_read_m25p80(void)
+{
+	return NULL;
+}
+#endif
+
+#ifdef CONFIG_MTD_DATAFLASH
+void * bootstrap_board_read_dataflash(void);
+#else
+static inline void * bootstrap_board_read_dataflash(void)
+{
+	return NULL;
+}
+#endif
+
+#endif /* __MACH_BOOTSTRAP_H__ */
Signature · 7 lines
1.7.10.4


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#16 lore raw

PATCH v5 10/10 at91: usb_a9263: add bootstrap version

In reply to Jean-Christophe PLAGNIOL-VILLARD
---
 arch/arm/boards/usb-a926x/Makefile                 |    3 +++
 arch/arm/boards/usb-a926x/usb_a9263_bootstrap.c    |   16 ++++++++++++
 .../configs/usb_a9263_128mib_bootstrap_defconfig   |   27 ++++++++++++++++++++
 arch/arm/configs/usb_a9263_bootstrap_defconfig     |   26 +++++++++++++++++++
 4 files changed, 72 insertions(+)
 create mode 100644 arch/arm/boards/usb-a926x/usb_a9263_bootstrap.c
 create mode 100644 arch/arm/configs/usb_a9263_128mib_bootstrap_defconfig
 create mode 100644 arch/arm/configs/usb_a9263_bootstrap_defconfig
arch/arm/boards/usb-a926x/Makefile +3 -0
index 9511a76..e314dd5 100644
@@ -1,5 +1,8 @@
 obj-y += init.o
 
+bootstrap-$(CONFIG_MACH_USB_A9263) = usb_a9263_bootstrap.o
+obj-$(CONFIG_AT91_BOOTSTRAP) += $(bootstrap-y)
+
 lowlevel_init-$(CONFIG_MACH_USB_A9263) = usb_a9263_lowlevel_init.o
 
 obj-$(CONFIG_MACH_DO_LOWLEVEL_INIT) += $(lowlevel_init-y)
arch/arm/boards/usb-a926x/usb_a9263_bootstrap.c new file +16 -0
new file mode 100644
index 0000000..368c677
@@ -0,0 +1,16 @@
+/*
+ * Copyright (C) 2012 Jean-Christophe PLAGNIOL-VILLARD <[email protected]>
+ *
+ * Under GPLv2
+ */
+
+#include <common.h>
+#include <bootstrap.h>
+#include <mach/bootstrap.h>
+
+#ifdef CONFIG_MTD_DATAFLASH
+void * bootstrap_board_read_dataflash(void)
+{
+	return bootstrap_read_devfs("dataflash0", false, 0xffc0, 204864, 204864);
+}
+#endif
arch/arm/configs/usb_a9263_128mib_bootstrap_defconfig new file +27 -0
new file mode 100644
index 0000000..0411bd8
@@ -0,0 +1,27 @@
+CONFIG_ARCH_AT91SAM9263=y
+CONFIG_MACH_USB_A9263=y
+CONFIG_AT91_HAVE_SRAM_128M=y
+CONFIG_AT91_BOOTSTRAP=y
+CONFIG_BAREBOX_MAX_IMAGE_SIZE=0x12000
+CONFIG_AEABI=y
+# CONFIG_CMD_ARM_CPUINFO is not set
+CONFIG_ARM_OPTIMZED_STRING_FUNCTIONS=y
+CONFIG_ENVIRONMENT_VARIABLES=y
+CONFIG_PBL_IMAGE=y
+CONFIG_MMU=y
+CONFIG_MALLOC_DUMMY=y
+CONFIG_PROMPT="USB-9263:"
+CONFIG_SHELL_NONE=y
+# CONFIG_CONSOLE_FULL is not set
+# CONFIG_DEFAULT_ENVIRONMENT is not set
+# CONFIG_SPI is not set
+CONFIG_MTD=y
+# CONFIG_MTD_WRITE is not set
+# CONFIG_MTD_OOB_DEVICE is not set
+CONFIG_NAND=y
+# CONFIG_NAND_ECC_HW is not set
+# CONFIG_NAND_ECC_HW_SYNDROME is not set
+# CONFIG_NAND_ECC_HW_NONE is not set
+CONFIG_NAND_ATMEL=y
+# CONFIG_FS_RAMFS is not set
+CONFIG_BOOTSTRAP_DEVFS=y
arch/arm/configs/usb_a9263_bootstrap_defconfig new file +26 -0
new file mode 100644
index 0000000..78c1c8f
@@ -0,0 +1,26 @@
+CONFIG_ARCH_AT91SAM9263=y
+CONFIG_MACH_USB_A9263=y
+CONFIG_AT91_BOOTSTRAP=y
+CONFIG_BAREBOX_MAX_IMAGE_SIZE=0x12000
+CONFIG_AEABI=y
+# CONFIG_CMD_ARM_CPUINFO is not set
+CONFIG_ARM_OPTIMZED_STRING_FUNCTIONS=y
+CONFIG_ENVIRONMENT_VARIABLES=y
+CONFIG_PBL_IMAGE=y
+CONFIG_MMU=y
+CONFIG_MALLOC_DUMMY=y
+CONFIG_PROMPT="USB-9263:"
+CONFIG_SHELL_NONE=y
+# CONFIG_CONSOLE_FULL is not set
+# CONFIG_DEFAULT_ENVIRONMENT is not set
+# CONFIG_SPI is not set
+CONFIG_MTD=y
+# CONFIG_MTD_WRITE is not set
+# CONFIG_MTD_OOB_DEVICE is not set
+CONFIG_NAND=y
+# CONFIG_NAND_ECC_HW is not set
+# CONFIG_NAND_ECC_HW_SYNDROME is not set
+# CONFIG_NAND_ECC_HW_NONE is not set
+CONFIG_NAND_ATMEL=y
+# CONFIG_FS_RAMFS is not set
+CONFIG_BOOTSTRAP_DEVFS=y
Signature · 7 lines
1.7.10.4


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox