mxs: Boost the memory power supply

PATCH Superseded Marek Vasut 4 participants 8 messages Jan 21, 2013 – Jan 28, 2013

Subsystems (2)

Arm (32-bit) Arm i.MX and Layerscape

lore

Share & tools

lore

Marek Vasut

author

2013-01-21 22:51 UTC #0 lore raw

PATCH 1/1 mxs: Boost the memory power supply

The memory power supply on MX23 didn't pump out enough juice into the DRAM chip, thus caused occasional memory corruption. Fix this.

Signed-off-by Marek Vasut <[email protected]>

Cc Otavio Salvador <[email protected]>

Cc Fabio Estevam <[email protected]>

Cc Stefano Babic <[email protected]>

---
 arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c |    4 ++--
 board/olimex/mx23_olinuxino/spl_boot.c    |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c +2 -2

index 5944dd2..836e636 100644
@@ -230,7 +230,7 @@ static void mx23_mem_setup_vddmem(void)
 	struct mxs_power_regs *power_regs =
 		(struct mxs_power_regs *)MXS_POWER_BASE;
 
-	writel((0x10 << POWER_VDDMEMCTRL_TRG_OFFSET) |
+	writel((0x12 << POWER_VDDMEMCTRL_TRG_OFFSET) |
 		POWER_VDDMEMCTRL_ENABLE_ILIMIT |
 		POWER_VDDMEMCTRL_ENABLE_LINREG |
 		POWER_VDDMEMCTRL_PULLDOWN_ACTIVE,

@@ -238,7 +238,7 @@ static void mx23_mem_setup_vddmem(void)
 
 	early_delay(10000);
 
-	writel((0x10 << POWER_VDDMEMCTRL_TRG_OFFSET) |
+	writel((0x12 << POWER_VDDMEMCTRL_TRG_OFFSET) |
 		POWER_VDDMEMCTRL_ENABLE_LINREG,
 		&power_regs->hw_power_vddmemctrl);
 }

board/olimex/mx23_olinuxino/spl_boot.c +1 -1

index 3cc40cd..d42bb14 100644
@@ -29,7 +29,7 @@
 #include <asm/arch/imx-regs.h>
 #include <asm/arch/sys_proto.h>
 
-#define	MUX_CONFIG_EMI	(MXS_PAD_3V3 | MXS_PAD_12MA | MXS_PAD_NOPULL)
+#define	MUX_CONFIG_EMI	(MXS_PAD_3V3 | MXS_PAD_16MA | MXS_PAD_PULLUP)
 #define	MUX_CONFIG_SSP	(MXS_PAD_3V3 | MXS_PAD_8MA | MXS_PAD_PULLUP)
 
 const iomux_cfg_t iomux_setup[] = {

Signature · 1 line

1.7.10.4

Otavio Salvador

2013-01-22 00:44 UTC #1 lore raw

PATCH 1/1 mxs: Boost the memory power supply

Quoted 7 lines · Marek Vasut

The memory power supply on MX23 didn't pump out enough juice into the DRAM chip, thus caused occasional memory corruption. Fix this.
Signed-off-by Marek Vasut <[email protected]>
Cc Otavio Salvador <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Stefano Babic <[email protected]>

Acked-by Otavio Salvador <[email protected]>

I did try it in mx23evk and mtest works fine there. However this patch needs to wait for other MMC changes as it does not apply in current form.

I will post them soon.

--
Otavio Salvador O.S. Systems
E-mail: otavio at ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br

Marek Vasut

author

2013-01-22 00:58 UTC #2 lore raw

PATCH 1/1 mxs: Boost the memory power supply

Dear Otavio Salvador,

Quoted 9 lines · Marek Vasut

Quoted 7 lines
The memory power supply on MX23 didn't pump out enough juice into the DRAM chip, thus caused occasional memory corruption. Fix this.
Signed-off-by Marek Vasut <[email protected]>
Cc Otavio Salvador <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Stefano Babic <[email protected]>

Quoted 5 lines

Acked-by Otavio Salvador <[email protected]>
I did try it in mx23evk and mtest works fine there. However this patch needs to wait for other MMC changes as it does not apply in current form.

Ah right, I rebased it on top of -imx/master. V2 out. Obviously you can not stall important fixes because of other less important patchset, that makes no sense. Thus, V2.

Good catch, thanks.

Quoted 6 lines

I will post them soon.
--
Otavio Salvador O.S. Systems
E-mail: otavio at ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br

Best regards,
Marek Vasut

Fabio Estevam

reviewer

2013-01-22 00:59 UTC #3 lore raw

PATCH 1/1 mxs: Boost the memory power supply

In reply to Otavio Salvador

Hi Otavio,

Quoted 1 line · Otavio Salvador

I did try it in mx23evk and mtest works fine there. However this patch

That's good news. Do you plan to submit mx23evk support?

Thanks,

Fabio Estevam

Otavio Salvador

2013-01-22 01:00 UTC #4 lore raw

PATCH 1/1 mxs: Boost the memory power supply

Quoted 8 lines · Fabio Estevam

Hi Otavio,
Quoted 1 line · Otavio Salvador
I did try it in mx23evk and mtest works fine there. However this patch
That's good news. Do you plan to submit mx23evk support?

Yes; finishing MMC timeout fix to send it.

--
Otavio Salvador O.S. Systems
E-mail: otavio at ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br

Marek Vasut

author

2013-01-22 00:57 UTC #5 lore raw

PATCH v2 1/1 mxs: Boost the memory power supply

In reply to Marek Vasut

The memory power supply on MX23 didn't pump out enough juice into the DRAM chip, thus caused occasional memory corruption. Fix this.

Signed-off-by Marek Vasut <[email protected]>

Cc Otavio Salvador <[email protected]>

Cc Fabio Estevam <[email protected]>

Cc Stefano Babic <[email protected]>

---
 arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c |    4 ++--
 board/olimex/mx23_olinuxino/spl_boot.c    |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

V2: Base this on top of u-boot-imx/master

arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c +2 -2

index 5944dd2..836e636 100644
@@ -230,7 +230,7 @@ static void mx23_mem_setup_vddmem(void)
 	struct mxs_power_regs *power_regs =
 		(struct mxs_power_regs *)MXS_POWER_BASE;
 
-	writel((0x10 << POWER_VDDMEMCTRL_TRG_OFFSET) |
+	writel((0x12 << POWER_VDDMEMCTRL_TRG_OFFSET) |
 		POWER_VDDMEMCTRL_ENABLE_ILIMIT |
 		POWER_VDDMEMCTRL_ENABLE_LINREG |
 		POWER_VDDMEMCTRL_PULLDOWN_ACTIVE,

@@ -238,7 +238,7 @@ static void mx23_mem_setup_vddmem(void)
 
 	early_delay(10000);
 
-	writel((0x10 << POWER_VDDMEMCTRL_TRG_OFFSET) |
+	writel((0x12 << POWER_VDDMEMCTRL_TRG_OFFSET) |
 		POWER_VDDMEMCTRL_ENABLE_LINREG,
 		&power_regs->hw_power_vddmemctrl);
 }

board/olimex/mx23_olinuxino/spl_boot.c +1 -1

index aaebe6c..6cf669f 100644
@@ -29,7 +29,7 @@
 #include <asm/arch/imx-regs.h>
 #include <asm/arch/sys_proto.h>
 
-#define	MUX_CONFIG_EMI	(MXS_PAD_3V3 | MXS_PAD_12MA | MXS_PAD_NOPULL)
+#define	MUX_CONFIG_EMI	(MXS_PAD_3V3 | MXS_PAD_16MA | MXS_PAD_PULLUP)
 
 const iomux_cfg_t iomux_setup[] = {
 	/* DUART */

Signature · 1 line

1.7.10.4

Otavio Salvador

2013-01-22 01:01 UTC #6 lore raw

PATCH v2 1/1 mxs: Boost the memory power supply

Quoted 7 lines · Marek Vasut

The memory power supply on MX23 didn't pump out enough juice into the DRAM chip, thus caused occasional memory corruption. Fix this.
Signed-off-by Marek Vasut <[email protected]>
Cc Otavio Salvador <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Stefano Babic <[email protected]>

Acked-by Otavio Salvador <[email protected]>

--
Otavio Salvador O.S. Systems
E-mail: otavio at ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br

Stefano Babic

2013-01-28 05:41 UTC #7 lore raw

PATCH v2 1/1 mxs: Boost the memory power supply

In reply to Marek Vasut

Quoted 7 lines · Marek Vasut

The memory power supply on MX23 didn't pump out enough juice into the DRAM chip, thus caused occasional memory corruption. Fix this.
Signed-off-by Marek Vasut <[email protected]>
Cc Otavio Salvador <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Stefano Babic <[email protected]>

Quoted 7 lines

---
 arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c |    4 ++--
 board/olimex/mx23_olinuxino/spl_boot.c    |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

V2: Base this on top of u-boot-imx/master

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================