Skip to contentSkip to conversation

ARM: ux500: de-globalize <mach/id.h>

PATCH New Linus Walleij 2 participants 2 messages Jan 7, 2013 – Jan 22, 2013

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: ux500: de-globalize <mach/id.h>

From: Linus Walleij <[email protected]>

This removes the file <mach/id.h> from the global kernel include scope, making it a pure mach-ux500 detail. All ASIC specifics needed by drivers shall henceforth be passed from either platform data or the device tree.

Cc Samuel Ortiz <[email protected]>
Cc Rafael J. Wysocki <[email protected]>

---
I'm sending this as a preview, collecting ACKs for the next merge window.

Sam, Rafael, could you ACK this?

Linus Walleij

---
 arch/arm/mach-ux500/board-mop500-uib.c      |   1 +
 arch/arm/mach-ux500/cache-l2x0.c            |   3 +-
 arch/arm/mach-ux500/cpu-db8500.c            |   2 +
 arch/arm/mach-ux500/cpu.c                   |   1 +
 arch/arm/mach-ux500/id.c                    |   2 +
 arch/arm/mach-ux500/id.h                    | 144 ++++++++++++++++++++++++++++
 arch/arm/mach-ux500/include/mach/hardware.h |   1 -
 arch/arm/mach-ux500/include/mach/id.h       | 144 ----------------------------
 arch/arm/mach-ux500/platsmp.c               |   3 +
 arch/arm/mach-ux500/timer.c                 |   2 +
 drivers/cpufreq/db8500-cpufreq.c            |   3 -
 drivers/mfd/db8500-prcmu.c                  |  17 ++--
 include/linux/mfd/dbx500-prcmu.h            |   2 -
 13 files changed, 163 insertions(+), 162 deletions(-)
 create mode 100644 arch/arm/mach-ux500/id.h
 delete mode 100644 arch/arm/mach-ux500/include/mach/id.h
arch/arm/mach-ux500/board-mop500-uib.c +1 -0
index 1f47d96..7037d36 100644
@@ -13,6 +13,7 @@
 
 #include <mach/hardware.h>
 #include "board-mop500.h"
+#include "id.h"
 
 enum mop500_uib {
 	STUIB,
arch/arm/mach-ux500/cache-l2x0.c +2 -1
index 75d5b51..1c1609d 100644
@@ -10,7 +10,8 @@
 #include <asm/cacheflush.h>
 #include <asm/hardware/cache-l2x0.h>
 #include <mach/hardware.h>
-#include <mach/id.h>
+
+#include "id.h"
 
 static void __iomem *l2x0_base;
 
arch/arm/mach-ux500/cpu-db8500.c +2 -0
index db0bb75..09c3fee 100644
@@ -37,7 +37,9 @@
 
 #include "devices-db8500.h"
 #include "ste-dma40-db8500.h"
+
 #include "board-mop500.h"
+#include "id.h"
 
 /* minimum static i/o mapping required to boot U8500 platforms */
 static struct map_desc u8500_uart_io_desc[] __initdata = {
arch/arm/mach-ux500/cpu.c +1 -0
index 721e7b4..14b7d68 100644
@@ -27,6 +27,7 @@
 #include <mach/devices.h>
 
 #include "board-mop500.h"
+#include "id.h"
 
 void __iomem *_PRCMU_BASE;
 
arch/arm/mach-ux500/id.c +2 -0
index d157992..9f95184 100644
@@ -17,6 +17,8 @@
 #include <mach/hardware.h>
 #include <mach/setup.h>
 
+#include "id.h"
+
 struct dbx500_asic_id dbx500_id;
 
 static unsigned int ux500_read_asicid(phys_addr_t addr)
arch/arm/mach-ux500/id.h new file +144 -0

144 lines not on this page · raw message

arch/arm/mach-ux500/include/mach/hardware.h +0 -1
index 28d16e7..5201dda 100644
@@ -39,7 +39,6 @@
 
 #ifndef __ASSEMBLY__
 
-#include <mach/id.h>
 extern void __iomem *_PRCMU_BASE;
 
 #define ARRAY_AND_SIZE(x)	(x), ARRAY_SIZE(x)
arch/arm/mach-ux500/include/mach/id.h deleted +0 -144

144 lines not on this page · raw message

arch/arm/mach-ux500/platsmp.c +3 -0
index 3db7782..1a92e07 100644
@@ -21,9 +21,12 @@
 #include <asm/hardware/gic.h>
 #include <asm/smp_plat.h>
 #include <asm/smp_scu.h>
+
 #include <mach/hardware.h>
 #include <mach/setup.h>
 
+#include "id.h"
+
 /* This is called from headsmp.S to wakeup the secondary core */
 extern void u8500_secondary_startup(void);
 
arch/arm/mach-ux500/timer.c +2 -0
index 875309a..c685ad1 100644
@@ -17,6 +17,8 @@
 #include <mach/hardware.h>
 #include <mach/irqs.h>
 
+#include "id.h"
+
 #ifdef CONFIG_HAVE_ARM_TWD
 static DEFINE_TWD_LOCAL_TIMER(u8500_twd_local_timer,
 			      U8500_TWD_BASE, IRQ_LOCALTIMER);
drivers/cpufreq/db8500-cpufreq.c +0 -3
index 4f154bc..523c940 100644
@@ -167,9 +167,6 @@ static struct platform_driver db8500_cpufreq_plat_driver = {
 
 static int __init db8500_cpufreq_register(void)
 {
-	if (!cpu_is_u8500_family())
-		return -ENODEV;
-
 	pr_info("cpufreq for DB8500 started\n");
 	return platform_driver_register(&db8500_cpufreq_plat_driver);
 }
drivers/mfd/db8500-prcmu.c +6 -11
index dc8826d..67d8b25 100644
@@ -36,7 +36,6 @@
 #include <mach/hardware.h>
 #include <mach/irqs.h>
 #include <mach/db8500-regs.h>
-#include <mach/id.h>
 #include "dbx500-prcmu-regs.h"
 
 /* Offset for the firmware version within the TCPM */
@@ -216,10 +215,8 @@
 #define PRCM_REQ_MB5_I2C_HW_BITS	(PRCM_REQ_MB5 + 0x1)
 #define PRCM_REQ_MB5_I2C_REG		(PRCM_REQ_MB5 + 0x2)
 #define PRCM_REQ_MB5_I2C_VAL		(PRCM_REQ_MB5 + 0x3)
-#define PRCMU_I2C_WRITE(slave) \
-	(((slave) << 1) | (cpu_is_u8500v2() ? BIT(6) : 0))
-#define PRCMU_I2C_READ(slave) \
-	(((slave) << 1) | BIT(0) | (cpu_is_u8500v2() ? BIT(6) : 0))
+#define PRCMU_I2C_WRITE(slave) (((slave) << 1) | BIT(6))
+#define PRCMU_I2C_READ(slave) (((slave) << 1) | BIT(0) | BIT(6))
 #define PRCMU_I2C_STOP_EN		BIT(3)
 
 /* Mailbox 5 ACKs */
@@ -1049,12 +1046,13 @@ int db8500_prcmu_get_ddr_opp(void)
  *
  * This function sets the operating point of the DDR.
  */
+static bool enable_set_ddr_opp;
 int db8500_prcmu_set_ddr_opp(u8 opp)
 {
 	if (opp < DDR_100_OPP || opp > DDR_25_OPP)
 		return -EINVAL;
 	/* Changing the DDR OPP can hang the hardware pre-v21 */
-	if (cpu_is_u8500v20_or_later() && !cpu_is_u8500v20())
+	if (enable_set_ddr_opp)
 		writeb(opp, PRCM_DDR_SUBSYS_APE_MINBW);
 
 	return 0;
@@ -2790,6 +2788,7 @@ void __init db8500_prcmu_early_init(void)
 		pr_err("prcmu: Unsupported chip version\n");
 		BUG();
 	}
+	tcdm_base = __io_address(U8500_PRCMU_TCDM_BASE);
 
 	spin_lock_init(&mb0_transfer.lock);
 	spin_lock_init(&mb0_transfer.dbb_irqs_lock);
@@ -3104,9 +3103,6 @@ static int db8500_prcmu_probe(struct platform_device *pdev)
 	struct device_node *np = pdev->dev.of_node;
 	int irq = 0, err = 0, i;
 
-	if (ux500_is_svp())
-		return -ENODEV;
-
 	init_prcm_registers();
 
 	/* Clean up the mailbox interrupts after pre-kernel code. */
@@ -3135,8 +3131,7 @@ static int db8500_prcmu_probe(struct platform_device *pdev)
 		}
 	}
 
-	if (cpu_is_u8500v20_or_later())
-		prcmu_config_esram0_deep_sleep(ESRAM0_DEEP_SLEEP_STATE_RET);
+	prcmu_config_esram0_deep_sleep(ESRAM0_DEEP_SLEEP_STATE_RET);
 
 	db8500_prcmu_update_cpufreq();
 
include/linux/mfd/dbx500-prcmu.h +0 -2
index ac60147..1552806 100644
@@ -218,8 +218,6 @@ enum ddr_pwrst {
 
 #if defined(CONFIG_UX500_SOC_DB8500)
 
-#include <mach/id.h>
-
 static inline void __init prcmu_early_init(void)
 {
 	return db8500_prcmu_early_init();
Signature · 1 line
1.7.11.3
#1 lore raw

PATCH 1/1 ARM: ux500: de-globalize <mach/id.h>

Hi Linus,

Quoted 17 lines · Linus Walleij

From: Linus Walleij <[email protected]>

This removes the file <mach/id.h> from the global kernel include scope, making it a pure mach-ux500 detail. All ASIC specifics needed by drivers shall henceforth be passed from either platform data or the device tree.

Cc Samuel Ortiz <[email protected]>
Cc Rafael J. Wysocki <[email protected]>

---
I'm sending this as a preview, collecting ACKs for the next merge window.

Sam, Rafael, could you ACK this?

Linus Walleij

Quoted 14 lines
---
 arch/arm/mach-ux500/board-mop500-uib.c      |   1 +
 arch/arm/mach-ux500/cache-l2x0.c            |   3 +-
 arch/arm/mach-ux500/cpu-db8500.c            |   2 +
 arch/arm/mach-ux500/cpu.c                   |   1 +
 arch/arm/mach-ux500/id.c                    |   2 +
 arch/arm/mach-ux500/id.h                    | 144 ++++++++++++++++++++++++++++
 arch/arm/mach-ux500/include/mach/hardware.h |   1 -
 arch/arm/mach-ux500/include/mach/id.h       | 144 ----------------------------
 arch/arm/mach-ux500/platsmp.c               |   3 +
 arch/arm/mach-ux500/timer.c                 |   2 +
 drivers/cpufreq/db8500-cpufreq.c            |   3 -
 drivers/mfd/db8500-prcmu.c                  |  17 ++--
 include/linux/mfd/dbx500-prcmu.h            |   2 -

For the MFD bits:

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/