Skip to contentSkip to conversation

drm/i915: acer inverted brightness quirks

PATCH Applied Jani Nikula 2 participants 5 messages Jan 22, 2013

Subsystems (2)
DRM drivers Intel i915
lore
Share & tools
lore

Jani Nikula

author
#0 lore raw

cover drm/i915: acer inverted brightness quirks

Some long standing brightness fixes for a few Acer machines under eMachines and Packard Bell brands. These should remove the need to use i915.invert_brightness=1 on affected machines.

BR,
Jani.

Jani Nikula (3):
drm/i915: add quirk to invert brightness on eMachines G725 drm/i915: add quirk to invert brightness on eMachines e725 drm/i915: add quirk to invert brightness on Packard Bell NCL20

 drivers/gpu/drm/i915/intel_display.c |    9 +++++++++
 1 file changed, 9 insertions(+)
Signature · 1 line
1.7.9.5
author
#1 lore raw

PATCH 1/3 drm/i915: add quirk to invert brightness on eMachines G725

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59628

Reported-by Roland Gruber <[email protected]>
Signed-off-by Jani Nikula <[email protected]>
---
 drivers/gpu/drm/i915/intel_display.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/gpu/drm/i915/intel_display.c +3 -0
index 7725446..44f9d8f 100644
@@ -8599,6 +8599,9 @@ static struct intel_quirk intel_quirks[] = {
 
 	/* Acer Aspire 5734Z must invert backlight brightness */
 	{ 0x2a42, 0x1025, 0x0459, quirk_invert_brightness },
+
+	/* Acer/eMachines G725 */
+	{ 0x2a42, 0x1025, 0x0210, quirk_invert_brightness },
 };
 
 static void intel_init_quirks(struct drm_device *dev)
Signature · 1 line
1.7.9.5
author
#2 lore raw

PATCH 2/3 drm/i915: add quirk to invert brightness on eMachines e725

In reply to Jani Nikula

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=31522#c35

[Note: There are more than one broken setups in the bug. This fixes one.]
Reported-by Martins <[email protected]>
Signed-off-by Jani Nikula <[email protected]>
---
 drivers/gpu/drm/i915/intel_display.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/gpu/drm/i915/intel_display.c +3 -0
index 44f9d8f..8575a62 100644
@@ -8602,6 +8602,9 @@ static struct intel_quirk intel_quirks[] = {
 
 	/* Acer/eMachines G725 */
 	{ 0x2a42, 0x1025, 0x0210, quirk_invert_brightness },
+
+	/* Acer/eMachines e725 */
+	{ 0x2a42, 0x1025, 0x0212, quirk_invert_brightness },
 };
 
 static void intel_init_quirks(struct drm_device *dev)
Signature · 1 line
1.7.9.5
author
#3 lore raw

PATCH 3/3 drm/i915: add quirk to invert brightness on Packard Bell NCL20

In reply to Jani Nikula

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=44156

Reported-by Alan Zimmerman <[email protected]>
Signed-off-by Jani Nikula <[email protected]>
---
 drivers/gpu/drm/i915/intel_display.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/gpu/drm/i915/intel_display.c +3 -0
index 8575a62..7262786 100644
@@ -8605,6 +8605,9 @@ static struct intel_quirk intel_quirks[] = {
 
 	/* Acer/eMachines e725 */
 	{ 0x2a42, 0x1025, 0x0212, quirk_invert_brightness },
+
+	/* Acer/Packard Bell NCL20 */
+	{ 0x2a42, 0x1025, 0x034b, quirk_invert_brightness },
 };
 
 static void intel_init_quirks(struct drm_device *dev)
Signature · 1 line
1.7.9.5
Applied
#4 lore raw
In reply to Jani Nikula
Quoted 3 lines · Jani Nikula

Some long standing brightness fixes for a few Acer machines under eMachines and Packard Bell brands. These should remove the need to use i915.invert_brightness=1 on affected machines.

Queued up all three patches for -next, thanks.
-Daniel

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch