Skip to contentSkip to conversation

CONFIG_PANIC_ON_OOPS should be shown if DEBUG_KERNEL

PATCH In review Kyle McMartin 3 participants 4 messages Jan 22, 2013 – Jan 24, 2013 Library code

lore
Share & tools
lore

Kyle McMartin

author
#0 lore raw

PATCH 1/1 CONFIG_PANIC_ON_OOPS should be shown if DEBUG_KERNEL

CONFIG_EXPERT is a bit silly a place for this, and hides it unnecessarily. CONFIG_DEBUG_KERNEL makes much more sense.

Signed-off-by Kyle McMartin <[email protected]>
lib/Kconfig.debug +1 -1
@@ -243,7 +243,7 @@ config BOOTPARAM_SOFTLOCKUP_PANIC_VALUE
 	default 1 if BOOTPARAM_SOFTLOCKUP_PANIC
 
 config PANIC_ON_OOPS
-	bool "Panic on Oops" if EXPERT
+	bool "Panic on Oops" if DEBUG_KERNEL
 	default n
 	help
 	  Say Y here to enable the kernel to panic when it oopses. This
maintainer
#1 lore raw
Quoted 8 lines · On Tue, 22 Jan 2013 14:21:03 -0500 Kyle McMartin <[email protected]> wrote:

CONFIG_EXPERT is a bit silly a place for this, and hides it unnecessarily. CONFIG_DEBUG_KERNEL makes much more sense.

Signed-off-by Kyle McMartin <[email protected]>

lib/Kconfig.debug config BOOTPARAM_SOFTLOCKUP_PANIC_VALUE · line 249

Quoted 8 lines
lib/Kconfig.debug +1 -1
@@ -243,7 +243,7 @@ config BOOTPARAM_SOFTLOCKUP_PANIC_VALUE
 	default 1 if BOOTPARAM_SOFTLOCKUP_PANIC
 
 config PANIC_ON_OOPS
-	bool "Panic on Oops" if EXPERT
+	bool "Panic on Oops" if DEBUG_KERNEL
 	default n
 	help
 	  Say Y here to enable the kernel to panic when it oopses. This

hm, I'm not sure that it should depend on anything. Where's the benefit?

#2 lore raw
Quoted 13 lines · Andrew Morton
Quoted 10 lines · On Tue, 22 Jan 2013 14:21:03 -0500 Kyle McMartin <[email protected]> wrote:

CONFIG_EXPERT is a bit silly a place for this, and hides it unnecessarily. CONFIG_DEBUG_KERNEL makes much more sense.

Signed-off-by Kyle McMartin <[email protected]>
lib/Kconfig.debug +0 -0
@@ -243,7 +243,7 @@ config BOOTPARAM_SOFTLOCKUP_PANIC_VALUE
 	default 1 if BOOTPARAM_SOFTLOCKUP_PANIC
Quoted 8 lines

lib/Kconfig.debug config BOOTPARAM_SOFTLOCKUP_PANIC_VALUE · line 249

Quoted 6 lines
lib/Kconfig.debug +1 -1
 config PANIC_ON_OOPS
-	bool "Panic on Oops" if EXPERT
+	bool "Panic on Oops" if DEBUG_KERNEL
 	default n
 	help
 	  Say Y here to enable the kernel to panic when it oopses. This

hm, I'm not sure that it should depend on anything. Where's the benefit?

Agreed.

(The 'default n' is superfuous as well, while at it.)

Thanks,

Ingo

author
#3 lore raw

PATCH 1/1 unhide CONFIG_PANIC_ON_OOPS

CONFIG_EXPERT doesn't really make sense, and hides it unintentionally. Remove superfluous "default n" pointed out by Ingo as well.

Signed-off-by Kyle McMartin <[email protected]>
lib/Kconfig.debug +1 -2
@@ -243,8 +243,7 @@ config BOOTPARAM_SOFTLOCKUP_PANIC_VALUE
 	default 1 if BOOTPARAM_SOFTLOCKUP_PANIC
 
 config PANIC_ON_OOPS
-	bool "Panic on Oops" if EXPERT
-	default n
+	bool "Panic on Oops"
 	help
 	  Say Y here to enable the kernel to panic when it oopses. This
 	  has the same effect as setting oops=panic on the kernel command