sandbox: fix compiler warning
PATCH 1/1 sandbox: fix compiler warning
Fix compiler warning about control flow reaching end of non void function.
--- arch/sandbox/cpu/start.c | 3 +++ 1 file changed, 3 insertions(+)
arch/sandbox/cpu/start.c +3 -0
@@ -122,4 +122,7 @@ int main(int argc, char *argv[])* never return. */ board_init_f (0 ); + +/* NOTREACHED - board_init_f() does not return */ +return 0 ; }
Signature · 1 line
1.7.10.4
PATCH 1/1 sandbox: fix compiler warning
Quoted 4 lines · Allen Martin
Fix compiler warning about control flow reaching end of non void function.
Signed-off-by Allen Martin <[email protected]>
Should perhaps mention the commit that adding this warning (e05e5de7 I think)
Quoted 19 lines
--- arch/sandbox/cpu/start.c | 3 +++ 1 file changed, 3 insertions(+)arch/sandbox/cpu/start.c +3
-1@@ -122,4 +122,7 @@ int main(int argc, char *argv[])* never return. */ board_init_f (0 ); + +/* NOTREACHED - board_init_f() does not return */ +return 0 ; } --1.7.10.4
PATCH 1/1 sandbox: fix compiler warning
Quoted 10 lines · Simon Glass
Quoted 4 lines · Allen Martin
Fix compiler warning about control flow reaching end of non void function.
Signed-off-by Allen Martin <[email protected]>Should perhaps mention the commit that adding this warning (
e05e5de7I think)Acked-by Simon Glass <[email protected]>
It was this commit:
commit fec79acc864bed049b6beae719ccbf2bbec5403a
Author: Mike Frysinger <[email protected]> Date: Wed Oct 26 00:22:14 2011 +0000
sandbox: drop unused return
I'll change the commit messagen and repost and cc Mike as well.
-Allen
Signature · 1 line
nvpublic
PATCH 1/1 sandbox: fix compiler warning
Hi Allen,
Quoted 18 lines · Allen Martin
Quoted 10 lines · Simon Glass
Quoted 4 lines · Allen Martin
Fix compiler warning about control flow reaching end of non void function.
Signed-off-by Allen Martin <[email protected]>Should perhaps mention the commit that adding this warning (
e05e5de7I think)Acked-by Simon Glass <[email protected]>It was this commit:
commit
fec79acc864bed049b6beae719ccbf2bbec5403aAuthor: Mike Frysinger <[email protected]> Date: Wed Oct 26 00:22:14 2011 +0000
Quoted 7 lines
sandbox: drop unused return
Signed-off-by Mike Frysinger <[email protected]>Acked-by Simon Glass <[email protected]>I'll change the commit messagen and repost and cc Mike as well.
Actually I think that Mike's commit was correct at the time, and it was Albert's which changed the no-return behaviour of the function signature in common.h?
Quoted 5 lines
-Allen
--
nvpublic
Regards,
Simon
PATCH 1/1 sandbox: fix compiler warning
Quoted 27 lines · Simon Glass
Hi Allen,
Quoted 24 lines · Allen Martin
Quoted 10 lines · Simon Glass
Quoted 4 lines · Allen Martin
Fix compiler warning about control flow reaching end of non void function.
Signed-off-by Allen Martin <[email protected]>Should perhaps mention the commit that adding this warning (
e05e5de7I think)Acked-by Simon Glass <[email protected]>It was this commit:
commit
fec79acc864bed049b6beae719ccbf2bbec5403aAuthor: Mike Frysinger <[email protected]> Date: Wed Oct 26 00:22:14 2011 +0000sandbox: drop unused return
Signed-off-by Mike Frysinger <[email protected]>Acked-by Simon Glass <[email protected]>
Quoted 5 lines
Quoted 1 line
I'll change the commit messagen and repost and cc Mike as well.
Actually I think that Mike's commit was correct at the time, and it was Albert's which changed the no-return behaviour of the function signature in
common.h?
Oh I see, you're right. I'll resend.
-Allen
Signature · 1 line
nvpublic