make u-boot/drivers/net/designware cache supportive
cover make u-boot/drivers/net/designware cache supportive
Hello Vipin,
As discussed, see included the patches to make your u-boot/drivers/net/designware Ethernet device driver cache support aware. First patch is about: do an explicit memory access instead of implicit, I re-written assignments to use readl() and writel().
Second patch is about: making the driver able to work in a cached environment (do I$/D$ flush/invalidate where necessary).
Frank Dols (2):
drivers/net/designware, do an explicit memory access instead of
implicit, re-written assignments to use readl() and writel(),
all of this as preperation for making the driver able to work in
a cached environment (I$D$ support).
u-boot/drivers/net/designware with cache support.
drivers/net/designware.c | 128 ++++++++++++++++++++++++++++++---------------- drivers/net/designware.h | 4 +- 2 files changed, 86 insertions(+), 46 deletions(-)
PATCH 1/2 drivers/net/designware, do an explicit memory access instead of implicit, re-written assignments to use readl() and writel(), all of this as preperation for making the driver able to work in a cached environment (I$D$ support).
--- drivers/net/designware.c | 108 +++++++++++++++++++++++++++------------------- drivers/net/designware.h | 4 +- 2 files changed, 66 insertions(+), 46 deletions(-)
drivers/net/designware.c +64 -44
@@ -44,29 +44,36 @@ static void tx_descs_init(struct eth_device *dev)struct dmamacdescr *desc_p;u32 idx; + txbuffs = (char *) ((((unsigned long ) txbuffs) + +CONFIG_SYS_CACHELINE_SIZE ) & + (~(CONFIG_SYS_CACHELINE_SIZE -1 ))); +for (idx =0 ; idx <CONFIG_TX_DESCR_NUM ; idx++) { desc_p = &desc_table_p[idx]; - desc_p->dmamac_addr = &txbuffs[idx *CONFIG_ETH_BUFSIZE ]; - desc_p->dmamac_next = &desc_table_p[idx +1 ]; + +writel ((ulong)&txbuffs[(idx *CONFIG_ETH_BUFSIZE )], + &desc_p->dmamac_addr); +writel ((ulong)&desc_table_p[idx +1 ], &desc_p->dmamac_next);#if defined(CONFIG_DW_ALTDESCRIPTOR ) - desc_p->txrx_status &= ~(DESC_TXSTS_TXINT |DESC_TXSTS_TXLAST | -DESC_TXSTS_TXFIRST |DESC_TXSTS_TXCRCDIS | \ -DESC_TXSTS_TXCHECKINSCTRL | \ -DESC_TXSTS_TXRINGEND |DESC_TXSTS_TXPADDIS ); - - desc_p->txrx_status |=DESC_TXSTS_TXCHAIN ; - desc_p->dmamac_cntl =0 ; - desc_p->txrx_status &= ~(DESC_TXSTS_MSK |DESC_TXSTS_OWNBYDMA ); +writel (readl (&desc_p->txrx_status) & ~(DESC_TXSTS_TXINT | +DESC_TXSTS_TXLAST |DESC_TXSTS_TXFIRST | +DESC_TXSTS_TXCRCDIS |DESC_TXSTS_TXCHECKINSCTRL | +DESC_TXSTS_TXRINGEND |DESC_TXSTS_TXPADDIS ), + &desc_p->txrx_status); +writel (readl (&desc_p->txrx_status) |DESC_TXSTS_TXCHAIN , + &desc_p->txrx_status); +writel (0 , &desc_p->dmamac_cntl); +writel (readl (&desc_p->txrx_status) & ~(DESC_TXSTS_MSK | +DESC_TXSTS_OWNBYDMA ), &desc_p->txrx_status);#else - desc_p->dmamac_cntl =DESC_TXCTRL_TXCHAIN ; - desc_p->txrx_status =0 ; +writel (DESC_TXCTRL_TXCHAIN , &desc_p->dmamac_cntl); +writel (0 , &desc_p->txrx_status);#endif }/* Correcting the last pointer of the chain */ - desc_p->dmamac_next = &desc_table_p[0 ]; - +writel ((ulong)&desc_table_p[0 ], &desc_p->dmamac_next);writel ((ulong)&desc_table_p[0 ], &dma_p->txdesclistaddr); }
@@ -79,21 +86,23 @@ static void rx_descs_init(struct eth_device *dev)struct dmamacdescr *desc_p;u32 idx; + rxbuffs = (char *) ((((unsigned long ) rxbuffs) + +CONFIG_SYS_CACHELINE_SIZE ) & + (~(CONFIG_SYS_CACHELINE_SIZE -1 ))); +for (idx =0 ; idx <CONFIG_RX_DESCR_NUM ; idx++) { desc_p = &desc_table_p[idx]; - desc_p->dmamac_addr = &rxbuffs[idx *CONFIG_ETH_BUFSIZE ]; - desc_p->dmamac_next = &desc_table_p[idx +1 ]; - desc_p->dmamac_cntl = - (MAC_MAX_FRAME_SZ &DESC_RXCTRL_SIZE1MASK ) | \ -DESC_RXCTRL_RXCHAIN ; - - desc_p->txrx_status =DESC_RXSTS_OWNBYDMA ; +writel ((ulong)&rxbuffs[idx *CONFIG_ETH_BUFSIZE ], + &desc_p->dmamac_addr); +writel ((ulong)&desc_table_p[idx +1 ], &desc_p->dmamac_next); +writel ((MAC_MAX_FRAME_SZ &DESC_RXCTRL_SIZE1MASK ) | +DESC_RXCTRL_RXCHAIN , &desc_p->dmamac_cntl); +writel (DESC_RXSTS_OWNBYDMA , &desc_p->txrx_status); }/* Correcting the last pointer of the chain */ - desc_p->dmamac_next = &desc_table_p[0 ]; - +writel ((ulong)&desc_table_p[0 ], &desc_p->dmamac_next);writel ((ulong)&desc_table_p[0 ], &dma_p->rxdesclistaddr); }
@@ -134,7 +143,7 @@ static int dw_write_hwaddr(struct eth_device *dev)u32 macid_lo, macid_hi;u8 *mac_id = &dev->enetaddr[0 ]; - macid_lo = mac_id[0 ] + (mac_id[1 ] <<8 ) + \ + macid_lo = mac_id[0 ] + (mac_id[1 ] <<8 ) + (mac_id[2 ] <<16 ) + (mac_id[3 ] <<24 ); macid_hi = mac_id[4 ] + (mac_id[5 ] <<8 );
@@ -198,7 +207,6 @@ static int dw_eth_init(struct eth_device *dev, bd_t *bis)*/ writel (readl (&dma_p->opmode) |RXSTART , &dma_p->opmode);writel (readl (&dma_p->opmode) |TXSTART , &dma_p->opmode); -writel (readl (&mac_p->conf) |RXENABLE |TXENABLE , &mac_p->conf);return 0 ;
@@ -212,26 +220,27 @@ static int dw_eth_send(struct eth_device *dev, void *packet, int length)struct dmamacdescr *desc_p = &priv->tx_mac_descrtable[desc_num];/* Check if the descriptor is owned by CPU */ -if (desc_p->txrx_status &DESC_TXSTS_OWNBYDMA ) { +if (readl (&desc_p->txrx_status) &DESC_TXSTS_OWNBYDMA ) {printf ("CPU not owner of tx frame\n" );return -1 ; } -memcpy ((void *)desc_p->dmamac_addr, packet, length); +memcpy ((void *)readl (&desc_p->dmamac_addr), packet, length);#if defined(CONFIG_DW_ALTDESCRIPTOR ) - desc_p->txrx_status |=DESC_TXSTS_TXFIRST |DESC_TXSTS_TXLAST ; - desc_p->dmamac_cntl |= (length <<DESC_TXCTRL_SIZE1SHFT ) & \ -DESC_TXCTRL_SIZE1MASK ; - - desc_p->txrx_status &= ~(DESC_TXSTS_MSK ); - desc_p->txrx_status |=DESC_TXSTS_OWNBYDMA ; +writel (readl (&desc_p->txrx_status) |DESC_TXSTS_TXFIRST | +DESC_TXSTS_TXLAST , &desc_p->txrx_status); +writel (readl (&desc_p->dmamac_cntl) | (length <<DESC_TXCTRL_SIZE1SHFT ) + &DESC_TXCTRL_SIZE1MASK , &desc_p->dmamac_cntl); +writel (readl (&desc_p->txrx_status) & ~(DESC_TXSTS_MSK ), + &desc_p->txrx_status); +writel (readl (&desc_p->txrx_status) |DESC_TXSTS_OWNBYDMA , + &desc_p->txrx_status);#else - desc_p->dmamac_cntl |= ((length <<DESC_TXCTRL_SIZE1SHFT ) & \ -DESC_TXCTRL_SIZE1MASK ) |DESC_TXCTRL_TXLAST | \ -DESC_TXCTRL_TXFIRST ; - - desc_p->txrx_status =DESC_TXSTS_OWNBYDMA ; +writel (readl (&desc_p->dmamac_cntl) | ((length <<DESC_TXCTRL_SIZE1SHFT ) + &DESC_TXCTRL_SIZE1MASK ) |DESC_TXCTRL_TXLAST | +DESC_TXCTRL_TXFIRST , &desc_p->dmamac_cntl); +writel (DESC_TXSTS_OWNBYDMA , &desc_p->txrx_status);#endif /* Test the wrap-around condition. */
@@ -240,6 +249,8 @@ static int dw_eth_send(struct eth_device *dev, void *packet, int length) priv->tx_currdescnum = desc_num; +wmb ();/* write memory barrier */ +/* Start the transmission */ writel (POLL_DATA , &dma_p->txpolldemand);
@@ -252,22 +263,28 @@ static int dw_eth_recv(struct eth_device *dev)u32 desc_num = priv->rx_currdescnum;struct dmamacdescr *desc_p = &priv->rx_mac_descrtable[desc_num]; -u32 status = desc_p->txrx_status; +u32 status;int length =0 ; +int timeout =30 ; + +do { + status =readl (&desc_p->txrx_status); + }while ((status &DESC_RXSTS_OWNBYDMA ) && (timeout-- >0 ));/* Check if the owner is the CPU */ if (!(status &DESC_RXSTS_OWNBYDMA )) { - length = (status &DESC_RXSTS_FRMLENMSK ) >> \ + length = (status &DESC_RXSTS_FRMLENMSK ) >>DESC_RXSTS_FRMLENSHFT ; -NetReceive (desc_p->dmamac_addr, length); +NetReceive (readl (&desc_p->dmamac_addr), length);/* * Make the current descriptor valid again and go to * the next one */ - desc_p->txrx_status |=DESC_RXSTS_OWNBYDMA ; +writel (readl (&desc_p->txrx_status) |DESC_RXSTS_OWNBYDMA , + &desc_p->txrx_status);/* Test the wrap-around condition. */ if (++desc_num >=CONFIG_RX_DESCR_NUM )
@@ -295,12 +312,13 @@ static int eth_mdio_read(struct eth_device *dev, u8 addr, u8 reg, u16 *val)u32 miiaddr;int timeout =CONFIG_MDIO_TIMEOUT ; - miiaddr = ((addr <<MIIADDRSHIFT ) &MII_ADDRMSK ) | \ + miiaddr = ((addr <<MIIADDRSHIFT ) &MII_ADDRMSK ) | ((reg <<MIIREGSHIFT ) &MII_REGMSK );writel (miiaddr |MII_CLKRANGE_150_250M |MII_BUSY , &mac_p->miiaddr); start =get_timer (0 ); +while (get_timer (start) < timeout) {if (!(readl (&mac_p->miiaddr) &MII_BUSY )) { *val =readl (&mac_p->miidata);
@@ -324,7 +342,7 @@ static int eth_mdio_write(struct eth_device *dev, u8 addr, u8 reg, u16 val)u16 value;writel (val, &mac_p->miidata); - miiaddr = ((addr <<MIIADDRSHIFT ) &MII_ADDRMSK ) | \ + miiaddr = ((addr <<MIIADDRSHIFT ) &MII_ADDRMSK ) | ((reg <<MIIREGSHIFT ) &MII_REGMSK ) |MII_WRITE ;writel (miiaddr |MII_CLKRANGE_150_250M |MII_BUSY , &mac_p->miiaddr);
@@ -469,6 +487,7 @@ static int configure_phy(struct eth_device *dev)#if defined(CONFIG_DW_AUTONEG ) timeout =CONFIG_AUTONEG_TIMEOUT ; start =get_timer (0 ); +puts ("Waiting for PHY auto negotiation to complete" );while (get_timer (start) < timeout) {eth_mdio_read (dev, phy_addr,MII_BMSR , &bmsr);
@@ -570,5 +589,6 @@ int designware_initialize(u32 id, ulong base_addr, u32 phy_addr, u32 interface)#if defined(CONFIG_MII )miiphy_register (dev->name, dw_mii_read, dw_mii_write);#endif +return 1 ; }
drivers/net/designware.h +2 -2
@@ -246,8 +246,8 @@ struct dw_eth_dev {struct dmamacdescr tx_mac_descrtable[CONFIG_TX_DESCR_NUM ];struct dmamacdescr rx_mac_descrtable[CONFIG_RX_DESCR_NUM ]; -char txbuffs[TX_TOTAL_BUFSIZE ]; -char rxbuffs[RX_TOTAL_BUFSIZE ]; +char txbuffs[TX_TOTAL_BUFSIZE +CONFIG_SYS_CACHELINE_SIZE ]; +char rxbuffs[RX_TOTAL_BUFSIZE +CONFIG_SYS_CACHELINE_SIZE ];struct eth_mac_regs *mac_regs_p;struct eth_dma_regs *dma_regs_p;
Signature · 1 line
1.7.0.4
PATCH 1/2 drivers/net/designware, do an explicit memory access instead of implicit, re-written assignments to use readl() and writel(), all of this as preperation for making the driver able to work in a cached environment (I$D$ support).
Provide a short patch title and a longer description in the patch itself. that would be much more readable
Quoted 17 lines · Frank Dols
Signed-off-by Frank Dols<[email protected]>--- drivers/net/designware.c | 108 +++++++++++++++++++++++++++------------------- drivers/net/designware.h | 4 +- 2 files changed, 66 insertions(+), 46 deletions(-)drivers/net/designware.c +3
-0@@ -44,29 +44,36 @@ static void tx_descs_init(struct eth_device *dev)struct dmamacdescr *desc_p;u32 idx; + txbuffs = (char *) ((((unsigned long ) txbuffs) + +CONFIG_SYS_CACHELINE_SIZE )& + (~(CONFIG_SYS_CACHELINE_SIZE -1 )));
drivers/net/designware.c static void tx_descs_init(struct eth_device *dev) · line 57
Quoted 10 lines
drivers/net/designware.c +5
-2+for (idx =0 ; idx<CONFIG_TX_DESCR_NUM ; idx++) { desc_p =&desc_table_p[idx]; - desc_p->dmamac_addr =&txbuffs[idx *CONFIG_ETH_BUFSIZE ]; - desc_p->dmamac_next =&desc_table_p[idx +1 ]; + +writel ((ulong)&txbuffs[(idx *CONFIG_ETH_BUFSIZE )], + &desc_p->dmamac_addr); +writel ((ulong)&desc_table_p[idx +1 ],&desc_p->dmamac_next);
My first feeling is that the descriptors are allocated as Normal Cachabale memory and it would not help to access them using readl/writel
Should the desciptors be allocated as non-cachable memory. If yes then how to do that in u-boot
I suppose the rest of the code would be better reviewed if we know about this
Vipin
Quoted 221 lines
drivers/net/designware.c +56
-42#if defined(CONFIG_DW_ALTDESCRIPTOR ) - desc_p->txrx_status&= ~(DESC_TXSTS_TXINT |DESC_TXSTS_TXLAST | -DESC_TXSTS_TXFIRST |DESC_TXSTS_TXCRCDIS | \ -DESC_TXSTS_TXCHECKINSCTRL | \ -DESC_TXSTS_TXRINGEND |DESC_TXSTS_TXPADDIS ); - - desc_p->txrx_status |=DESC_TXSTS_TXCHAIN ; - desc_p->dmamac_cntl =0 ; - desc_p->txrx_status&= ~(DESC_TXSTS_MSK |DESC_TXSTS_OWNBYDMA ); +writel (readl (&desc_p->txrx_status)& ~(DESC_TXSTS_TXINT | +DESC_TXSTS_TXLAST |DESC_TXSTS_TXFIRST | +DESC_TXSTS_TXCRCDIS |DESC_TXSTS_TXCHECKINSCTRL | +DESC_TXSTS_TXRINGEND |DESC_TXSTS_TXPADDIS ), + &desc_p->txrx_status); +writel (readl (&desc_p->txrx_status) |DESC_TXSTS_TXCHAIN , + &desc_p->txrx_status); +writel (0 ,&desc_p->dmamac_cntl); +writel (readl (&desc_p->txrx_status)& ~(DESC_TXSTS_MSK | +DESC_TXSTS_OWNBYDMA ),&desc_p->txrx_status);#else - desc_p->dmamac_cntl =DESC_TXCTRL_TXCHAIN ; - desc_p->txrx_status =0 ; +writel (DESC_TXCTRL_TXCHAIN ,&desc_p->dmamac_cntl); +writel (0 ,&desc_p->txrx_status);#endif }/* Correcting the last pointer of the chain */ - desc_p->dmamac_next =&desc_table_p[0 ]; - +writel ((ulong)&desc_table_p[0 ],&desc_p->dmamac_next);writel ((ulong)&desc_table_p[0 ],&dma_p->txdesclistaddr); }@@ -79,21 +86,23 @@ static void rx_descs_init(struct eth_device *dev)struct dmamacdescr *desc_p;u32 idx; + rxbuffs = (char *) ((((unsigned long ) rxbuffs) + +CONFIG_SYS_CACHELINE_SIZE )& + (~(CONFIG_SYS_CACHELINE_SIZE -1 ))); +for (idx =0 ; idx<CONFIG_RX_DESCR_NUM ; idx++) { desc_p =&desc_table_p[idx]; - desc_p->dmamac_addr =&rxbuffs[idx *CONFIG_ETH_BUFSIZE ]; - desc_p->dmamac_next =&desc_table_p[idx +1 ]; - desc_p->dmamac_cntl = - (MAC_MAX_FRAME_SZ &DESC_RXCTRL_SIZE1MASK ) | \ -DESC_RXCTRL_RXCHAIN ; - - desc_p->txrx_status =DESC_RXSTS_OWNBYDMA ; +writel ((ulong)&rxbuffs[idx *CONFIG_ETH_BUFSIZE ], + &desc_p->dmamac_addr); +writel ((ulong)&desc_table_p[idx +1 ],&desc_p->dmamac_next); +writel ((MAC_MAX_FRAME_SZ &DESC_RXCTRL_SIZE1MASK ) | +DESC_RXCTRL_RXCHAIN ,&desc_p->dmamac_cntl); +writel (DESC_RXSTS_OWNBYDMA ,&desc_p->txrx_status); }/* Correcting the last pointer of the chain */ - desc_p->dmamac_next =&desc_table_p[0 ]; - +writel ((ulong)&desc_table_p[0 ],&desc_p->dmamac_next);writel ((ulong)&desc_table_p[0 ],&dma_p->rxdesclistaddr); }@@ -134,7 +143,7 @@ static int dw_write_hwaddr(struct eth_device *dev)u32 macid_lo, macid_hi;u8 *mac_id =&dev->enetaddr[0 ]; - macid_lo = mac_id[0 ] + (mac_id[1 ]<<8 ) + \ + macid_lo = mac_id[0 ] + (mac_id[1 ]<<8 ) + (mac_id[2 ]<<16 ) + (mac_id[3 ]<<24 ); macid_hi = mac_id[4 ] + (mac_id[5 ]<<8 );@@ -198,7 +207,6 @@ static int dw_eth_init(struct eth_device *dev, bd_t *bis)*/ writel (readl (&dma_p->opmode) |RXSTART ,&dma_p->opmode);writel (readl (&dma_p->opmode) |TXSTART ,&dma_p->opmode); -writel (readl (&mac_p->conf) |RXENABLE |TXENABLE ,&mac_p->conf);return 0 ;@@ -212,26 +220,27 @@ static int dw_eth_send(struct eth_device *dev, void *packet, int length)struct dmamacdescr *desc_p =&priv->tx_mac_descrtable[desc_num];/* Check if the descriptor is owned by CPU */ -if (desc_p->txrx_status&DESC_TXSTS_OWNBYDMA ) { +if (readl (&desc_p->txrx_status)&DESC_TXSTS_OWNBYDMA ) {printf ("CPU not owner of tx frame\n" );return -1 ; } -memcpy ((void *)desc_p->dmamac_addr, packet, length); +memcpy ((void *)readl (&desc_p->dmamac_addr), packet, length);#if defined(CONFIG_DW_ALTDESCRIPTOR ) - desc_p->txrx_status |=DESC_TXSTS_TXFIRST |DESC_TXSTS_TXLAST ; - desc_p->dmamac_cntl |= (length<<DESC_TXCTRL_SIZE1SHFT )& \ -DESC_TXCTRL_SIZE1MASK ; - - desc_p->txrx_status&= ~(DESC_TXSTS_MSK ); - desc_p->txrx_status |=DESC_TXSTS_OWNBYDMA ; +writel (readl (&desc_p->txrx_status) |DESC_TXSTS_TXFIRST | +DESC_TXSTS_TXLAST ,&desc_p->txrx_status); +writel (readl (&desc_p->dmamac_cntl) | (length<<DESC_TXCTRL_SIZE1SHFT ) + &DESC_TXCTRL_SIZE1MASK ,&desc_p->dmamac_cntl); +writel (readl (&desc_p->txrx_status)& ~(DESC_TXSTS_MSK ), + &desc_p->txrx_status); +writel (readl (&desc_p->txrx_status) |DESC_TXSTS_OWNBYDMA , + &desc_p->txrx_status);#else - desc_p->dmamac_cntl |= ((length<<DESC_TXCTRL_SIZE1SHFT )& \ -DESC_TXCTRL_SIZE1MASK ) |DESC_TXCTRL_TXLAST | \ -DESC_TXCTRL_TXFIRST ; - - desc_p->txrx_status =DESC_TXSTS_OWNBYDMA ; +writel (readl (&desc_p->dmamac_cntl) | ((length<<DESC_TXCTRL_SIZE1SHFT ) + &DESC_TXCTRL_SIZE1MASK ) |DESC_TXCTRL_TXLAST | +DESC_TXCTRL_TXFIRST ,&desc_p->dmamac_cntl); +writel (DESC_TXSTS_OWNBYDMA ,&desc_p->txrx_status);#endif /* Test the wrap-around condition. */ @@ -240,6 +249,8 @@ static int dw_eth_send(struct eth_device *dev, void *packet, int length) priv->tx_currdescnum = desc_num; +wmb ();/* write memory barrier */ +/* Start the transmission */ writel (POLL_DATA ,&dma_p->txpolldemand);@@ -252,22 +263,28 @@ static int dw_eth_recv(struct eth_device *dev)u32 desc_num = priv->rx_currdescnum;struct dmamacdescr *desc_p =&priv->rx_mac_descrtable[desc_num]; -u32 status = desc_p->txrx_status; +u32 status;int length =0 ; +int timeout =30 ; + +do { + status =readl (&desc_p->txrx_status); + }while ((status&DESC_RXSTS_OWNBYDMA )&& (timeout-->0 ));/* Check if the owner is the CPU */ if (!(status&DESC_RXSTS_OWNBYDMA )) { - length = (status&DESC_RXSTS_FRMLENMSK )>> \ + length = (status&DESC_RXSTS_FRMLENMSK )>>DESC_RXSTS_FRMLENSHFT ; -NetReceive (desc_p->dmamac_addr, length); +NetReceive (readl (&desc_p->dmamac_addr), length);/* * Make the current descriptor valid again and go to * the next one */ - desc_p->txrx_status |=DESC_RXSTS_OWNBYDMA ; +writel (readl (&desc_p->txrx_status) |DESC_RXSTS_OWNBYDMA , + &desc_p->txrx_status);/* Test the wrap-around condition. */ if (++desc_num>=CONFIG_RX_DESCR_NUM )@@ -295,12 +312,13 @@ static int eth_mdio_read(struct eth_device *dev, u8 addr, u8 reg, u16 *val)u32 miiaddr;int timeout =CONFIG_MDIO_TIMEOUT ; - miiaddr = ((addr<<MIIADDRSHIFT )&MII_ADDRMSK ) | \ + miiaddr = ((addr<<MIIADDRSHIFT )&MII_ADDRMSK ) | ((reg<<MIIREGSHIFT )&MII_REGMSK );writel (miiaddr |MII_CLKRANGE_150_250M |MII_BUSY ,&mac_p->miiaddr); start =get_timer (0 ); +while (get_timer (start)< timeout) {if (!(readl (&mac_p->miiaddr)&MII_BUSY )) { *val =readl (&mac_p->miidata);@@ -324,7 +342,7 @@ static int eth_mdio_write(struct eth_device *dev, u8 addr, u8 reg, u16 val)u16 value;writel (val,&mac_p->miidata); - miiaddr = ((addr<<MIIADDRSHIFT )&MII_ADDRMSK ) | \ + miiaddr = ((addr<<MIIADDRSHIFT )&MII_ADDRMSK ) | ((reg<<MIIREGSHIFT )&MII_REGMSK ) |MII_WRITE ;writel (miiaddr |MII_CLKRANGE_150_250M |MII_BUSY ,&mac_p->miiaddr);@@ -469,6 +487,7 @@ static int configure_phy(struct eth_device *dev)#if defined(CONFIG_DW_AUTONEG ) timeout =CONFIG_AUTONEG_TIMEOUT ; start =get_timer (0 ); +puts ("Waiting for PHY auto negotiation to complete" );while (get_timer (start)< timeout) {eth_mdio_read (dev, phy_addr,MII_BMSR ,&bmsr);@@ -570,5 +589,6 @@ int designware_initialize(u32 id, ulong base_addr, u32 phy_addr, u32 interface)#if defined(CONFIG_MII )miiphy_register (dev->name, dw_mii_read, dw_mii_write);#endif +return 1 ; }drivers/net/designware.h +2
-2@@ -246,8 +246,8 @@ struct dw_eth_dev {struct dmamacdescr tx_mac_descrtable[CONFIG_TX_DESCR_NUM ];struct dmamacdescr rx_mac_descrtable[CONFIG_RX_DESCR_NUM ]; -char txbuffs[TX_TOTAL_BUFSIZE ]; -char rxbuffs[RX_TOTAL_BUFSIZE ]; +char txbuffs[TX_TOTAL_BUFSIZE +CONFIG_SYS_CACHELINE_SIZE ]; +char rxbuffs[RX_TOTAL_BUFSIZE +CONFIG_SYS_CACHELINE_SIZE ];struct eth_mac_regs *mac_regs_p;struct eth_dma_regs *dma_regs_p;
PATCH 1/2 drivers/net/designware, do an explicit memory access instead of implicit, re-written assignments to use readl() and writel(), all of this as preperation for making the driver able to work in a cached environment (I$D$ support).
Hi Vipin,
Quoted 10 lines
My first feeling is that the descriptors are allocated as Normal Cachabale memory and it would not help to access them using readl/writel
Should the desciptors be allocated as non-cachable memory. If yes then how to do that in u-boot
I suppose the rest of the code would be better reviewed if we know about this
Vipin
I would say that yes, descriptors are allocated in DRAM, so they are cacheable.
And no, we don't need to allocate them non-cacheable, although in this case we need to use cache flush and invalidate calls. I would suggest doing so rather than allocating the descriptors non cacheable, because using non-cacheable memory makes the dependency between the driver and cache codes implicit (and thus more prone to improperly thought out changes in either code) and the memory usage more complex, while explicit cache operations make the relationship explicit.
One can always not cache descriptors if you one wants to, without this decision breaking driver functionality.
Amicalement,
Signature · 1 line
Albert.
PATCH 1/2 drivers/net/designware, do an explicit memory access instead of implicit, re-written assignments to use readl() and writel(), all of this as preperation for making the driver able to work in a cached environment (I$D$ support).
Quoted 16 lines · Albert ARIBAUD
Hi Vipin,
Quoted 10 lines
My first feeling is that the descriptors are allocated as Normal Cachabale memory and it would not help to access them using readl/writel
Should the desciptors be allocated as non-cachable memory. If yes then how to do that in u-boot
I suppose the rest of the code would be better reviewed if we know about this
Vipin
I would say that yes, descriptors are allocated in DRAM, so they are cacheable.
Quoted 8 lines
And no, we don't need to allocate them non-cacheable, although in this case we need to use cache flush and invalidate calls. I would suggest doing so rather than allocating the descriptors non cacheable, because using non-cacheable memory makes the dependency between the driver and cache codes implicit (and thus more prone to improperly thought out changes in either code) and the memory usage more complex, while explicit cache operations make the relationship explicit.
Yes, got it. Thanks Albert
Frank, so in that case rather changing the code to use readl/writel, cache flush and invalidate operations need to be performed at appropriate places
Regards
Vipin
Quoted 4 lines
One can always not cache descriptors if you one wants to, without this decision breaking driver functionality.
Amicalement,
PATCH 1/2 drivers/net/designware, do an explicit memory access instead of implicit, re-written assignments to use readl() and writel(), all of this as preperation for making the driver able to work in a cached environment (I$D$ support).
Hi Vipin,
Quoted 26 lines · Vipin Kumar
Quoted 16 lines · Albert ARIBAUD
Hi Vipin,
Quoted 10 lines
My first feeling is that the descriptors are allocated as Normal Cachabale memory and it would not help to access them using readl/writel
Should the desciptors be allocated as non-cachable memory. If yes then how to do that in u-boot
I suppose the rest of the code would be better reviewed if we know about this
Vipin
I would say that yes, descriptors are allocated in DRAM, so they are cacheable.
Quoted 8 lines
And no, we don't need to allocate them non-cacheable, although in this case we need to use cache flush and invalidate calls. I would suggest doing so rather than allocating the descriptors non cacheable, because using non-cacheable memory makes the dependency between the driver and cache codes implicit (and thus more prone to improperly thought out changes in either code) and the memory usage more complex, while explicit cache operations make the relationship explicit.
Quoted 5 lines
Yes, got it. Thanks Albert
Frank, so in that case rather changing the code to use readl/writel, cache flush and invalidate operations need to be performed at appropriate places
I believe patch 2/2 adds explicit cache ops, though I haven't read it in detail and thus don't know if everything needed is present and ok.
Amicalement,
Signature · 1 line
Albert.
PATCH 1/2 drivers/net/designware, do an explicit memory access instead of implicit, re-written assignments to use readl() and writel(), all of this as preperation for making the driver able to work in a cached environment (I$D$ support).
Quoted 5 lines
Hi Vipin,
Quoted 2 lines · Vipin Kumar
Quoted 2 lines
My first feeling is that the descriptors are allocated as Normal Cachabale memory and it would not help to access them using readl/writel
...
Quoted 9 lines
Quoted 4 lines
And no, we don't need to allocate them non-cacheable, although in this case we need to use cache flush and invalidate calls. I would suggest doing so rather than allocating the descriptors none cacheable, because using non-cacheable memory makes the dependency between the driver and cache codes implicit (and thus more prone to improperly thought out changes in either code) and the memory usage more complex, while explicit cache operations make the relationship explicit.
Yes, got it. Thanks Albert
Frank, so in that case rather changing the code to use readl/writel, cache flush and invalidate operations need to be performed at appropriate places VipinQuoted 2 lines
I believe patch 2/2 adds explicit cache ops, though I haven't read it in detail and thus don't know if everything needed is present and ok. Amicalement, Albert.
Hi Vipin and Albert,
Sorry, I have to clarify here a bit more.
The descriptors are 16 bytes in length and a cache line is in most architectures more than 16 bytes in length (in our case either 32 or 64).
This means that cached accesses is not an option for these descriptors. Background, two adjacent descriptors as be on one cache line may be owned by different entities (host cpu / network ip). Explicit cache calls that we are added in patch 2/2 are meant for payload of the package. And these are made cache line aligned with patch 1/2.
Unfortunately we can't align the descriptors on cache line boundaries due to hardware limitations (for architectures with cache line longer than 16 bytes) ! With kind regards, greetings, Frank.
A message that is not in the archive (sent off-list or not yet received): 1869199372336F41A75F0B381AC8B48A028B6B@DE02WEMBX1.internal.synopsys.com
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/2 drivers/net/designware, do an explicit memory access instead of implicit, re-written assignments to use readl() and writel(), all of this as preperation for making the driver able to work in a cached environment (I$D$ support).
[[ ... to get attention again ... see below ...]]
Quoted 5 lines · Frank Dols
Good afternoon Vipin and Albert,
I where wondering, is there any review/update news on the patches I submitted a short while ago? Regards, Frank.
Sorry, first excluded " u-boot at lists.denx.de" from this email to prevent from noice on mailing list.
There is no reason to remove the list. This is not noise I believe.
Infact by including the list, you are intimating other developers that such work would be available soon
Albert, do you think any different.
Quoted 3 lines
Sorry, I have to clarify here a bit more.
The descriptors are 16 bytes in length and a cache line is in most architectures more than 16 bytes in length (in our case either 32 or 64).
This means that cached accesses is not an option for these descriptors. Background, two adjacent descriptors as be on one cache line may be owned by different entities (host cpu / network ip).
Yes, this is a problem and I can't think of a clean solution. Specially because u-boot (as of today) does not support non-cached memory
Albert?
Quoted 1 line
Explicit cache calls that we are added in patch 2/2 are meant for payload of the package. And these are made cache line aligned with patch 1/2.
Yes, that is what I thought
Quoted 1 line
Unfortunately we can't align the descriptors on cache line boundaries due to hardware limitations (for architectures with cache line longer than 16 bytes) !
Yes, I know that. The descriptors are 16 bytes and they need to be contiguous in memory
PS: I have not added the list but I strongly feel that this mail should also go to the uboot list
-Vipin
Quoted 3 lines
With kind regards, greetings, Frank.
PATCH 1/2 drivers/net/designware, do an explicit memory access instead of implicit, re-written assignments to use readl() and writel(), all of this as preperation for making the driver able to work in a cached environment (I$D$ support).
Hi Frank,
Quoted 8 lines · Frank Dols
[[ ... to get attention again ... see below ...]]
Quoted 5 lines · Frank Dols
Good afternoon Vipin and Albert,
I where wondering, is there any review/update news on the patches I submitted a short while ago? Regards, Frank.
Sorry, first excluded " u-boot at lists.denx.de" from this email to prevent from noice on mailing list.
Quoted 4 lines
There is no reason to remove the list. This is not noise I believe.
Infact by including the list, you are intimating other developers that such work would be available soonAlbert, do you think any different.
Yes, this is appropriate for the list.
Quoted 12 lines
Quoted 3 lines
Sorry, I have to clarify here a bit more.
The descriptors are 16 bytes in length and a cache line is in most architectures more than 16 bytes in length (in our case either 32 or 64).
This means that cached accesses is not an option for these descriptors. Background, two adjacent descriptors as be on one cache line may be owned by different entities (host cpu / network ip).Yes, this is a problem and I can't think of a clean solution. Specially because u-boot (as of today) does not support non-cached memory
Albert?
Quoted 1 line
Explicit cache calls that we are added in patch 2/2 are meant for payload of the package. And these are made cache line aligned with patch 1/2.
Yes, that is what I thought
Quoted 9 lines
Quoted 1 line
Unfortunately we can't align the descriptors on cache line boundaries due to hardware limitations (for architectures with cache line longer than 16 bytes) !
Yes, I know that. The descriptors are 16 bytes and they need to be contiguous in memory
PS: I have not added the list but I strongly feel that this mail should also go to the uboot list
-Vipin
Quoted 1 line
With kind regards, greetings, Frank.
I attempted to apply these 2 patches (and fix your improper commit message... please see http://www.denx.de/wiki/U-Boot/Patches ), but your change causes build errors and warnings even then.
Please address these issues and resubmit.
Thanks,
-Joe
Configuring for spear300 - Board: spear3xx_evb, Options: spear300 arm-none-linux-gnueabi-size: '/tmp/u-boot-build//x600/u-boot': No such file In file included from designware.c:18:0:
designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function)designware.c: In function 'tx_descs_init':
designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'rx_descs_init':
designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'dw_eth_send':
designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration]designware.c: In function 'dw_eth_recv':
designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32'
make[1]: *** [/tmp/u-boot-build/x600/drivers/net/designware.o] Error 1
make: *** [/tmp/u-boot-build/x600/drivers/net/built-in.o] Error 2
make: *** Waiting for unfinished jobs....
Configuring for spear300_nand - Board: spear3xx_evb, Options: spear300,nand arm-none-linux-gnueabi-size: '/tmp/u-boot-build//spear300/u-boot': No such file In file included from designware.c:18:0:
designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function)designware.c: In function 'tx_descs_init':
designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'rx_descs_init':
designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'dw_eth_send':
designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:226:2: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration]designware.c: In function 'dw_eth_recv':
designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32'
make[1]: *** [/tmp/u-boot-build/spear300/drivers/net/designware.o] Error 1
make: *** [/tmp/u-boot-build/spear300/drivers/net/built-in.o] Error 2
make: *** Waiting for unfinished jobs....
Configuring for spear300_usbtty - Board: spear3xx_evb, Options: spear300,usbtty arm-none-linux-gnueabi-size:
'/tmp/u-boot-build//spear300_nand/u-boot': No such file
In file included from designware.c:18:0:
designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function)designware.c: In function 'tx_descs_init':
designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'rx_descs_init':
designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'dw_eth_send':
designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:226:2: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration]designware.c: In function 'dw_eth_recv':
designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32'
make[1]: *** [/tmp/u-boot-build/spear300_nand/drivers/net/designware.o] Error 1
make: *** [/tmp/u-boot-build/spear300_nand/drivers/net/built-in.o] Error 2
make: *** Waiting for unfinished jobs....
Configuring for spear300_usbtty_nand - Board: spear3xx_evb, Options:
spear300,usbtty,nand
arm-none-linux-gnueabi-size:
'/tmp/u-boot-build//spear300_usbtty/u-boot': No such file
In file included from designware.c:18:0:
designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function)designware.c: In function 'tx_descs_init':
designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'rx_descs_init':
designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'dw_eth_send':
designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:226:2: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration]designware.c: In function 'dw_eth_recv':
designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32'
make[1]: *** [/tmp/u-boot-build/spear300_usbtty/drivers/net/designware.o] Error 1
make: *** [/tmp/u-boot-build/spear300_usbtty/drivers/net/built-in.o] Error 2
make: *** Waiting for unfinished jobs....
Configuring for spear310 - Board: spear3xx_evb, Options: spear310 arm-none-linux-gnueabi-size:
'/tmp/u-boot-build//spear300_usbtty_nand/u-boot': No such file
In file included from designware.c:18:0:
designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function)designware.c: In function 'tx_descs_init':
designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'rx_descs_init':
designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'dw_eth_send':
designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:226:2: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration]designware.c: In function 'dw_eth_recv':
designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32'
make[1]: *** [/tmp/u-boot-build/spear300_usbtty_nand/drivers/net/designware.o] Error 1
make: *** [/tmp/u-boot-build/spear300_usbtty_nand/drivers/net/built-in.o] Error 2
make: *** Waiting for unfinished jobs....
Configuring for spear310_nand - Board: spear3xx_evb, Options: spear310,nand arm-none-linux-gnueabi-size: '/tmp/u-boot-build//spear310/u-boot': No such file In file included from designware.c:18:0:
designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function)designware.c: In function 'tx_descs_init':
designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'rx_descs_init':
designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'dw_eth_send':
designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:226:2: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration]designware.c: In function 'dw_eth_recv':
designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32'
make[1]: *** [/tmp/u-boot-build/spear310/drivers/net/designware.o] Error 1
make: *** [/tmp/u-boot-build/spear310/drivers/net/built-in.o] Error 2
make: *** Waiting for unfinished jobs....
Configuring for spear310_pnor - Board: spear3xx_evb, Options:
spear310,FLASH_PNOR
arm-none-linux-gnueabi-size:
'/tmp/u-boot-build//spear310_nand/u-boot': No such file
In file included from designware.c:18:0:
designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function)designware.c: In function 'tx_descs_init':
designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'rx_descs_init':
designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'dw_eth_send':
designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:226:2: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration]designware.c: In function 'dw_eth_recv':
designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32'
make[1]: *** [/tmp/u-boot-build/spear310_nand/drivers/net/designware.o] Error 1
make: *** [/tmp/u-boot-build/spear310_nand/drivers/net/built-in.o] Error 2
make: *** Waiting for unfinished jobs....
Configuring for spear310_usbtty - Board: spear3xx_evb, Options: spear310,usbtty arm-none-linux-gnueabi-size:
'/tmp/u-boot-build//spear310_pnor/u-boot': No such file
In file included from designware.c:18:0:
designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function)designware.c: In function 'tx_descs_init':
designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'rx_descs_init':
designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'dw_eth_send':
designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:226:2: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration]designware.c: In function 'dw_eth_recv':
designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32'
make[1]: *** [/tmp/u-boot-build/spear310_pnor/drivers/net/designware.o] Error 1
make: *** [/tmp/u-boot-build/spear310_pnor/drivers/net/built-in.o] Error 2
make: *** Waiting for unfinished jobs....
Configuring for spear310_usbtty_nand - Board: spear3xx_evb, Options:
spear310,usbtty,nand
arm-none-linux-gnueabi-size:
'/tmp/u-boot-build//spear310_usbtty/u-boot': No such file
In file included from designware.c:18:0:
designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function)designware.c: In function 'tx_descs_init':
designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'rx_descs_init':
designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'dw_eth_send':
designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:226:2: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration]designware.c: In function 'dw_eth_recv':
designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32'
make[1]: *** [/tmp/u-boot-build/spear310_usbtty/drivers/net/designware.o] Error 1
make: *** [/tmp/u-boot-build/spear310_usbtty/drivers/net/built-in.o] Error 2
make: *** Waiting for unfinished jobs....
Configuring for spear310_usbtty_pnor - Board: spear3xx_evb, Options:
spear310,usbtty,FLASH_PNOR
arm-none-linux-gnueabi-size:
'/tmp/u-boot-build//spear310_usbtty_nand/u-boot': No such file
In file included from designware.c:18:0:
designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function)designware.c: In function 'tx_descs_init':
designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'rx_descs_init':
designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'dw_eth_send':
designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:226:2: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration]designware.c: In function 'dw_eth_recv':
designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32'
make[1]: *** [/tmp/u-boot-build/spear310_usbtty_nand/drivers/net/designware.o] Error 1
make: *** [/tmp/u-boot-build/spear310_usbtty_nand/drivers/net/built-in.o] Error 2
make: *** Waiting for unfinished jobs....
Configuring for spear320 - Board: spear3xx_evb, Options: spear320 arm-none-linux-gnueabi-size:
'/tmp/u-boot-build//spear310_usbtty_pnor/u-boot': No such file
In file included from designware.c:18:0:
designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function)designware.c: In function 'tx_descs_init':
designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'rx_descs_init':
designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'dw_eth_send':
designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:226:2: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration]designware.c: In function 'dw_eth_recv':
designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32'
make[1]: *** [/tmp/u-boot-build/spear310_usbtty_pnor/drivers/net/designware.o] Error 1
make: *** [/tmp/u-boot-build/spear310_usbtty_pnor/drivers/net/built-in.o] Error 2
make: *** Waiting for unfinished jobs....
Configuring for spear320_nand - Board: spear3xx_evb, Options: spear320,nand arm-none-linux-gnueabi-size: '/tmp/u-boot-build//spear320/u-boot': No such file In file included from designware.c:18:0:
designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function)designware.c: In function 'tx_descs_init':
designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'rx_descs_init':
designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'dw_eth_send':
designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:226:2: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration]designware.c: In function 'dw_eth_recv':
designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32'
make[1]: *** [/tmp/u-boot-build/spear320/drivers/net/designware.o] Error 1
make: *** [/tmp/u-boot-build/spear320/drivers/net/built-in.o] Error 2
make: *** Waiting for unfinished jobs....
Configuring for spear320_pnor - Board: spear3xx_evb, Options:
spear320,FLASH_PNOR
arm-none-linux-gnueabi-size:
'/tmp/u-boot-build//spear320_nand/u-boot': No such file
In file included from designware.c:18:0:
designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function)designware.c: In function 'tx_descs_init':
designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'rx_descs_init':
designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'dw_eth_send':
designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:226:2: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration]designware.c: In function 'dw_eth_recv':
designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32'
make[1]: *** [/tmp/u-boot-build/spear320_nand/drivers/net/designware.o] Error 1
make: *** [/tmp/u-boot-build/spear320_nand/drivers/net/built-in.o] Error 2
make: *** Waiting for unfinished jobs....
Configuring for spear320_usbtty - Board: spear3xx_evb, Options: spear320,usbtty arm-none-linux-gnueabi-size:
'/tmp/u-boot-build//spear320_pnor/u-boot': No such file
In file included from designware.c:18:0:
designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function)designware.c: In function 'tx_descs_init':
designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'rx_descs_init':
designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'dw_eth_send':
designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:226:2: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration]designware.c: In function 'dw_eth_recv':
designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32'
make[1]: *** [/tmp/u-boot-build/spear320_pnor/drivers/net/designware.o] Error 1
make: *** [/tmp/u-boot-build/spear320_pnor/drivers/net/built-in.o] Error 2
make: *** Waiting for unfinished jobs....
Configuring for spear320_usbtty_nand - Board: spear3xx_evb, Options:
spear320,usbtty,nand
arm-none-linux-gnueabi-size:
'/tmp/u-boot-build//spear320_usbtty/u-boot': No such file
In file included from designware.c:18:0:
designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function)designware.c: In function 'tx_descs_init':
designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'rx_descs_init':
designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'dw_eth_send':
designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:226:2: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration]designware.c: In function 'dw_eth_recv':
designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32'
make[1]: *** [/tmp/u-boot-build/spear320_usbtty/drivers/net/designware.o] Error 1
make: *** [/tmp/u-boot-build/spear320_usbtty/drivers/net/built-in.o] Error 2
make: *** Waiting for unfinished jobs....
Configuring for spear320_usbtty_pnor - Board: spear3xx_evb, Options:
spear320,usbtty,FLASH_PNOR
arm-none-linux-gnueabi-size:
'/tmp/u-boot-build//spear320_usbtty_nand/u-boot': No such file
In file included from designware.c:18:0:
designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function)designware.c: In function 'tx_descs_init':
designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'rx_descs_init':
designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'dw_eth_send':
designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:226:2: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration]designware.c: In function 'dw_eth_recv':
designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32'
make[1]: *** [/tmp/u-boot-build/spear320_usbtty_nand/drivers/net/designware.o] Error 1
make: *** [/tmp/u-boot-build/spear320_usbtty_nand/drivers/net/built-in.o] Error 2
make: *** Waiting for unfinished jobs....
Configuring for spear600 - Board: spear6xx_evb, Options: spear600 arm-none-linux-gnueabi-size:
'/tmp/u-boot-build//spear320_usbtty_pnor/u-boot': No such file
In file included from designware.c:18:0:
designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function)designware.c: In function 'tx_descs_init':
designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'rx_descs_init':
designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'dw_eth_send':
designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:226:2: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration]designware.c: In function 'dw_eth_recv':
designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32'
make[1]: *** [/tmp/u-boot-build/spear320_usbtty_pnor/drivers/net/designware.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [/tmp/u-boot-build/spear320_usbtty_pnor/drivers/net/built-in.o] Error 2
make: *** Waiting for unfinished jobs....
Configuring for spear600_nand - Board: spear6xx_evb, Options: spear600,nand arm-none-linux-gnueabi-size: '/tmp/u-boot-build//spear600/u-boot': No such file In file included from designware.c:18:0:
designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function)designware.c: In function 'tx_descs_init':
designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'rx_descs_init':
designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'dw_eth_send':
designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration]designware.c: In function 'dw_eth_recv':
designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32'
make[1]: *** [/tmp/u-boot-build/spear600/drivers/net/designware.o] Error 1
make: *** [/tmp/u-boot-build/spear600/drivers/net/built-in.o] Error 2
make: *** Waiting for unfinished jobs....
Configuring for spear600_usbtty - Board: spear6xx_evb, Options: spear600,usbtty arm-none-linux-gnueabi-size:
'/tmp/u-boot-build//spear600_nand/u-boot': No such file
In file included from designware.c:18:0:
designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function)designware.c: In function 'tx_descs_init':
designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'rx_descs_init':
designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'dw_eth_send':
designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration]designware.c: In function 'dw_eth_recv':
designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32'
make[1]: *** [/tmp/u-boot-build/spear600_nand/drivers/net/designware.o] Error 1
make: *** [/tmp/u-boot-build/spear600_nand/drivers/net/built-in.o] Error 2
make: *** Waiting for unfinished jobs....
Configuring for spear600_usbtty_nand - Board: spear6xx_evb, Options:
spear600,usbtty,nand
arm-none-linux-gnueabi-size:
'/tmp/u-boot-build//spear600_usbtty/u-boot': No such file
In file included from designware.c:18:0:
designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function)designware.c: In function 'tx_descs_init':
designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'rx_descs_init':
designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'dw_eth_send':
designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration]designware.c: In function 'dw_eth_recv':
designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32'
make[1]: *** [/tmp/u-boot-build/spear600_usbtty/drivers/net/designware.o] Error 1
make: *** [/tmp/u-boot-build/spear600_usbtty/drivers/net/built-in.o] Error 2
make: *** Waiting for unfinished jobs....
Configuring for versatileab - Board: versatile, Options: ARCH_VERSATILE_AB arm-none-linux-gnueabi-size:
'/tmp/u-boot-build//spear600_usbtty_nand/u-boot': No such file
In file included from designware.c:18:0:
designware.h:232:34: error: 'CONFIG_SYS_CACHELINE_SIZE' undeclared here (not in a function)designware.c: In function 'tx_descs_init':
designware.c:41:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:43:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:63:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'rx_descs_init':
designware.c:83:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:85:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
designware.c:92:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]designware.c: In function 'dw_eth_send':
designware.c:217:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:245:2: warning: implicit declaration of function 'wmb' [-Wimplicit-function-declaration]designware.c: In function 'dw_eth_recv':
designware.c:278:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] designware.c:278:3: warning: passing argument 1 of 'NetReceive' makes pointer from integer without a cast [enabled by default] /home/joe/u-boot/include/net.h:549:13: note: expected 'uchar *' but argument is of type 'u32'
make[1]: *** [/tmp/u-boot-build/spear600_usbtty_nand/drivers/net/designware.o] Error 1
make: *** [/tmp/u-boot-build/spear600_usbtty_nand/drivers/net/built-in.o] Error 2
make: *** Waiting for unfinished jobs....
PATCH 2/2 u-boot/drivers/net/designware with cache support.
In reply to Frank Dols--- drivers/net/designware.c | 20 ++++++++++++++++++++ 1 files changed, 20 insertions(+), 0 deletions(-)
drivers/net/designware.c +20 -0
@@ -32,6 +32,9 @@#include <linux/err.h> #include <asm/io.h> #include "designware.h" +#ifdef CONFIG_SYS_DCACHE_ON +#include <asm/cache.h> +#endif static int configure_phy (struct eth_device *dev);
@@ -227,6 +230,10 @@ static int dw_eth_send(struct eth_device *dev, void *packet, int length)memcpy ((void *)readl (&desc_p->dmamac_addr), packet, length); +#ifdef CONFIG_SYS_DCACHE_ON +flush_dcache_range ((void *)readl (&desc_p->dmamac_addr), length); +#endif +#if defined(CONFIG_DW_ALTDESCRIPTOR )writel (readl (&desc_p->txrx_status) |DESC_TXSTS_TXFIRST |DESC_TXSTS_TXLAST , &desc_p->txrx_status);
@@ -277,8 +284,17 @@ static int dw_eth_recv(struct eth_device *dev) length = (status &DESC_RXSTS_FRMLENMSK ) >>DESC_RXSTS_FRMLENSHFT ; +#ifdef CONFIG_SYS_DCACHE_ON +invalidate_dcache_range ((void *)readl (&desc_p->dmamac_addr), + length); +#endif +NetReceive (readl (&desc_p->dmamac_addr), length); +#ifdef CONFIG_SYS_DCACHE_ON +flush_dcache_range ((void *)readl (&desc_p->dmamac_addr), length); +#endif +/* * Make the current descriptor valid again and go to * the next one
@@ -584,6 +600,10 @@ int designware_initialize(u32 id, ulong base_addr, u32 phy_addr, u32 interface) dev->halt = dw_eth_halt; dev->write_hwaddr = dw_write_hwaddr; +#ifdef CONFIG_SYS_DCACHE_ON +flush_dcache_range (priv,sizeof (struct dw_eth_dev )); +#endif +eth_register (dev);#if defined(CONFIG_MII )
Signature · 1 line
1.7.0.4
cover make u-boot/drivers/net/designware cache supportive
In reply to Frank DolsQuoted 3 lines · Frank Dols
Hello Vipin,
As discussed, see included the patches to make your u-boot/drivers/net/designware Ethernet device driver cache support aware.
You dont need to write u-boot/drivers in the patch subject. It is anyway implicit :)
Vipin
Quoted 17 lines
First patch is about: do an explicit memory access instead of implicit, I re-written assignments to use
readl()andwritel().
Second patch is about: making the driver able to work in a cached environment (do I$/D$ flush/invalidate where necessary).Frank Dols (2):
drivers/net/designware, do an explicit memory access instead of
implicit, re-written assignments to usereadl()andwritel(),
all of this as preperation for making the driver able to work in
a cached environment (I$D$ support).
u-boot/drivers/net/designware with cache support.drivers/net/designware.c | 128 ++++++++++++++++++++++++++++++---------------- drivers/net/designware.h | 4 +- 2 files changed, 86 insertions(+), 46 deletions(-)
cover make u-boot/drivers/net/designware cache supportive
Hi Frank,
Quoted 7 lines · Vipin Kumar
Quoted 4 lines · Frank Dols
Hello Vipin,
As discussed, see included the patches to make your u-boot/drivers/net/designware Ethernet device driver cache support aware.
Quoted 23 lines
You dont need to write u-boot/drivers in the patch subject. It is anyway implicit :)
Vipin
Quoted 17 lines
First patch is about: do an explicit memory access instead of implicit, I re-written assignments to use
readl()andwritel().
Second patch is about: making the driver able to work in a cached environment
(do I$/D$ flush/invalidate where necessary).Frank Dols (2):
drivers/net/designware, do an explicit memory access instead of
implicit, re-written assignments to usereadl()andwritel(),
all of this as preperation for making the driver able to work in
a cached environment (I$D$ support).
u-boot/drivers/net/designware with cache support.drivers/net/designware.c | 128 ++++++++++++++++++++++++++++++---------------- drivers/net/designware.h | 4 +- 2 files changed, 86 insertions(+), 46 deletions(-)
Do you plan to re submit with the subject of patch 1 fixed and the other applicable comments?
Thanks,
-Joe