board: add support for amcore board
PATCH v4 2/2 board: add support for amcore board
Add support for Sysam AMCORE mcf5307 (coldfire) based board.
---
Changes for v2:
- None
Changes for v3:
- Fix code format issues
Changes for v4:
- Added MAINTAINERS file entry
- Removed all unnecessary blank lines
- Added get_ram_size in sdram init
- Reused already existing sdram test routine
- Removed custom flash.c, used std mtd/CFI driver
--- MAINTAINERS | 4 + board/sysam/amcore/Makefile | 43 ++++++ board/sysam/amcore/amcore.c | 160 +++++++++++++++++++++ board/sysam/amcore/config.mk | 23 +++ board/sysam/amcore/u-boot.lds | 101 ++++++++++++++ boards.cfg | 1 + include/configs/amcore.h | 220 +++++++++++++++++++++++++++++ 7 files changed, 552 insertions(+), 0 deletions(-)
MAINTAINERS +4 -0
@@ -1137,6 +1137,10 @@ Wolfgang Wegner <[email protected]> astro_mcf5373l MCF5373L +Angelo Dureghello <[email protected]> + + amcore mcf5307 + ######################################################################### # AVR32 Systems: # # #
board/sysam/amcore/Makefile new file +43 -0
43 lines not on this page · raw message
board/sysam/amcore/amcore.c new file +159 -0
159 lines not on this page · raw message
board/sysam/amcore/config.mk new file +23 -0
@@ -0,0 +1,23 @@ +# +# Copyright (c) 2011 Angelo Dureghello <[email protected]> +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + +CONFIG_SYS_TEXT_BASE = 0xffc00000
board/sysam/amcore/u-boot.lds new file +101 -0
101 lines not on this page · raw message
boards.cfg +1 -0
@@ -388,6 +388,7 @@ M5271EVB m68k mcf52x2 m5271evb freesca M5272C3 m68k mcf52x2 m5272c3 freescale M5275EVB m68k mcf52x2 m5275evb freescale M5282EVB m68k mcf52x2 m5282evb freescale +amcore m68k mcf530x amcore sysam astro_mcf5373l m68k mcf532x mcf5373l astro M53017EVB m68k mcf532x m53017evb freescale M5329AFEE m68k mcf532x m5329evb freescale - M5329EVB:NANDFLASH_SIZE=0
include/configs/amcore.h new file +220 -0
220 lines not on this page · raw message
PATCH v4 2/2 board: add support for amcore board
Dear Angelo Dureghello,
Quoted 4 lines · In message <[email protected]> you wrote:
Add support for Sysam AMCORE mcf5307 (coldfire) based board.
Signed-off-by Angelo Dureghello <[email protected]>Cc Jason Jin <[email protected]>
...
MAINTAINERS Wolfgang Wegner <[email protected]> · line 1142
Quoted 12 lines
MAINTAINERS +3
-0@@ -1137,6 +1137,10 @@ Wolfgang Wegner <[email protected]> astro_mcf5373l MCF5373L +Angelo Dureghello <[email protected]> + + amcore mcf5307
Please keep the list sorted...
MAINTAINERS Wolfgang Wegner <[email protected]>
Quoted 6 lines
MAINTAINERS +6
-0+ + for (p = pstart; p < pend; p++) { + if (*p != 0x55555555) { + printf("SDRAM test fails at: %08x\n", (uint) p); + return 1; + }
Incorrect indentation.
MAINTAINERS
Quoted 7 lines
MAINTAINERS +7
-0+/* + * BOOTP options + */ +#undef CONFIG_BOOTP_BOOTFILESIZE +#undef CONFIG_BOOTP_BOOTPATH +#undef CONFIG_BOOTP_GATEWAY +#undef CONFIG_BOOTP_HOSTNAME
Please don't undef what is not defined anyway. Please fix globally.
MAINTAINERS
Quoted 2 lines
MAINTAINERS +2
-0+#define CONFIG_SYS_SDRAM_BASE 0x00000000 +#define CONFIG_SYS_SDRAM_SIZE 16 /* in MB */
NAK. CONFIG_SYS_SDRAM_SIZE is always and everywhere in bytes...
MAINTAINERS
Quoted 3 lines
MAINTAINERS +3
-0+/* reserve 128-4KB */ +#define CONFIG_SYS_MONITOR_BASE (CONFIG_SYS_FLASH_BASE + 0x400) +#define CONFIG_SYS_MONITOR_LEN ((128-4)*1024)
Are you sure this is sufficient?
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There's a way out of any cage.
-- Captain Christopher Pike, "The Menagerie" ("The Cage"),
stardate unknown.PATCH v4 2/2 board: add support for amcore board
Dear Wolfgang,
thanks for the review, will fix all points.
Quoted 6 lines
include/configs/amcore.h line 167
Quoted 4 lines
include/configs/amcore.h new file +3
-0+/* reserve 128-4KB */ +#define CONFIG_SYS_MONITOR_BASE (CONFIG_SYS_FLASH_BASE + 0x400) +#define CONFIG_SYS_MONITOR_LEN ((128-4)*1024)Are you sure this is sufficient?
For my board/case actually seems to be more than enough. I can still change this in the future.
Best Regards,
Angelo Dureghello
PATCH v4 2/2 board: add support for amcore board
Dear Angelo Dureghello,
Quoted 9 lines · In message <[email protected]> you wrote:
Quoted 6 lines
include/configs/amcore.h line 167
Quoted 4 lines
include/configs/amcore.h new file +3
-0+/* reserve 128-4KB */ +#define CONFIG_SYS_MONITOR_BASE (CONFIG_SYS_FLASH_BASE + 0x400) +#define CONFIG_SYS_MONITOR_LEN ((128-4)*1024)Are you sure this is sufficient?
For my board/case actually seems to be more than enough. I can still change this in the future.
How big is your U-Boot image, then? I think it's a pretty long time since I haven't seen any image smaller than 128 kB...
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de There's nothing disgusting about it [the Companion]. It's just another life form, that's all. You get used to those things. -- McCoy, "Metamorphosis", stardate 3219.8
PATCH v4 2/2 board: add support for amcore board
Dear Wolfgang,
Quoted 10 lines · Wolfgang Denk
Dear Angelo Dureghello,
Quoted 7 lines · In message <[email protected]> you wrote:
Quoted 6 lines
include/configs/amcore.h line 167
Quoted 4 lines
include/configs/amcore.h new file +3
-0+/* reserve 128-4KB */ +#define CONFIG_SYS_MONITOR_BASE (CONFIG_SYS_FLASH_BASE + 0x400) +#define CONFIG_SYS_MONITOR_LEN ((128-4)*1024)Are you sure this is sufficient?
Quoted 6 lines
Quoted 2 lines
For my board/case actually seems to be more than enough. I can still change this in the future.
How big is your U-Boot image, then? I think it's a pretty long time since I haven't seen any image smaller than 128 kB...
-rwxr-xr-x 1 angelo angelo 88556 gen 22 22:31 u-boot.bin
Best regards,
Angelo Dureghello
PATCH v4 2/2 board: add support for amcore board
Dear Angelo Dureghello,
Quoted 5 lines · In message <[email protected]> you wrote:
Quoted 3 lines
How big is your U-Boot image, then? I think it's a pretty long time since I haven't seen any image smaller than 128 kB...
-rwxr-xr-x 1 angelo angelo 88556 gen 22 22:31 u-boot.bin
Wow, that's just great :-) Thanks.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Living on Earth may be expensive, but it includes an annual free trip around the Sun.