perf tools, powerpc: Fix compile warnings in tests/attr.c
PATCH v2 1/1 perf tools, powerpc: Fix compile warnings in tests/attr.c
[PATCH][v2] perf tools, powerpc: Fix compile warnings in tests/attr.c
We print several '__u64' quantities using '%llu'. On powerpc, we by default include '<asm-generic/int-l64.h> which results in __u64 being an unsigned long. This causes compile warnings which are treated as errors due to '-Werror'.
By defining __SANE_USERSPACE_TYPES__ we include <asm-generic/int-ll64.h> and define __u64 as unsigned long long.
Changelog[v2]:
[Michael Ellerman] Use __SANE_USERSPACE_TYPES__ and avoid PRIu64 format specifier - which as Jiri Olsa pointed out, breaks on x86-64.
--- tools/perf/tests/attr.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)
tools/perf/tests/attr.c +5 -0
@@ -19,6 +19,11 @@* permissions. All the event text files are stored there. */ +/* +* Powerpc needs __SANE_USERSPACE_TYPES__ before <linux/types.h> to select +* 'int-ll64.h' and avoid compile warnings when printing __u64 with %llu. +*/ +#define __SANE_USERSPACE_TYPES__#include <stdlib.h> #include <stdio.h> #include <inttypes.h>
Signature · 1 line
1.7.1
Commit-ID: e3541ec75219819d3235f80125a1a75d798ff6e1 Gitweb: http://git.kernel.org/tip/e3541ec75219819d3235f80125a1a75d798ff6e1 Author: Sukadev Bhattiprolu <[email protected]> AuthorDate: Wed, 23 Jan 2013 21:44:39 -0800 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Wed, 30 Jan 2013 10:37:14 -0300
perf tools, powerpc: Fix compile warnings in tests/attr.c
We print several '__u64' quantities using '%llu'. On powerpc, we by default include '<asm-generic/int-l64.h> which results in __u64 being an unsigned long. This causes compile warnings which are treated as errors due to '-Werror'.
By defining __SANE_USERSPACE_TYPES__ we include <asm-generic/int-ll64.h> and define __u64 as unsigned long long.
Changelog[v2]:
[Michael Ellerman] Use __SANE_USERSPACE_TYPES__ and avoid PRIu64 format specifier - which as Jiri Olsa pointed out, breaks on x86-64.
--- tools/perf/tests/attr.c | 5 +++++ 1 file changed, 5 insertions(+)
tools/perf/tests/attr.c +5 -0
@@ -19,6 +19,11 @@* permissions. All the event text files are stored there. */ +/* +* Powerpc needs __SANE_USERSPACE_TYPES__ before <linux/types.h> to select +* 'int-ll64.h' and avoid compile warnings when printing __u64 with %llu. +*/ +#define __SANE_USERSPACE_TYPES__#include <stdlib.h> #include <stdio.h> #include <inttypes.h>