i2c: at91: add of_device_id entry for at91rm9200
Subsystems (2)
PATCH 1/1 i2c: at91: add of_device_id entry for at91rm9200
---
Hi,
AT91RM9200 is gaining DT support now so let's add an id to the i2c driver.
Tested on custom RM9200 board. Since the driver doesn't support pinctrl muxing yet I had to add pinctrl hogs for the i2c pins in my dts for it to work.
regards
Joachim Eastwood
drivers/i2c/busses/i2c-at91.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/i2c/busses/i2c-at91.c +3 -0
@@ -584,6 +584,9 @@ static const struct platform_device_id at91_twi_devtypes[] = { #if defined(CONFIG_OF) static const struct of_device_id atmel_twi_dt_ids[] = { { + .compatible = "atmel,at91rm9200-i2c", + .data = &at91rm9200_config, + } , { .compatible = "atmel,at91sam9260-i2c", .data = &at91sam9260_config, } , {
Signature · 1 line
1.8.0
PATCH 1/1 i2c: at91: add of_device_id entry for at91rm9200
Quoted 9 lines · Joachim Eastwood
Signed-off-by Joachim Eastwood <[email protected]>---
Hi,AT91RM9200 is gaining DT support now so let's add an id to the i2c driver.
Tested on custom RM9200 board. Since the driver doesn't support pinctrl muxing yet I had to add pinctrl hogs for the i2c pins in my dts for it to work.
IIRC the i2c IP have quite a lots of issue on rm9200 and until sam9g45
it not recommended to use it instead use i2c-gpio
Best Regards,
J.
Quoted 24 lines
regards
Joachim Eastwooddrivers/i2c/busses/i2c-at91.c | 3 +++ 1 file changed, 3 insertions(+)drivers/i2c/busses/i2c-at91.c +3
-0@@ -584,6 +584,9 @@ static const struct platform_device_id at91_twi_devtypes[] = { #if defined(CONFIG_OF) static const struct of_device_id atmel_twi_dt_ids[] = { { + .compatible = "atmel,at91rm9200-i2c", + .data = &at91rm9200_config, + } , { .compatible = "atmel,at91sam9260-i2c", .data = &at91sam9260_config, } , {Signature · 1 line
1.8.0
PATCH 1/1 i2c: at91: add of_device_id entry for at91rm9200
Quoted 7 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 6 lines · Joachim Eastwood
Signed-off-by Joachim Eastwood <[email protected]>---
Hi,AT91RM9200 is gaining DT support now so let's add an id to the i2c driver.
Quoted 7 lines
Quoted 3 lines
Tested on custom RM9200 board. Since the driver doesn't support pinctrl muxing yet I had to add pinctrl hogs for the i2c pins in my dts for it to work.
IIRC the i2c IP have quite a lots of issue on rm9200 and until sam9g45
it not recommended to use it instead use i2c-gpio
Ludovic, you know the driver best. Does it make sense to add this?
Quoted 31 lines
Best Regards,
J.Quoted 24 lines
regards
Joachim Eastwooddrivers/i2c/busses/i2c-at91.c | 3 +++ 1 file changed, 3 insertions(+)drivers/i2c/busses/i2c-at91.c +3
-0@@ -584,6 +584,9 @@ static const struct platform_device_id at91_twi_devtypes[] = { #if defined(CONFIG_OF) static const struct of_device_id atmel_twi_dt_ids[] = { { + .compatible = "atmel,at91rm9200-i2c", + .data = &at91rm9200_config, + } , { .compatible = "atmel,at91sam9260-i2c", .data = &at91sam9260_config, } , {Signature · 1 line
1.8.0--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 1/1 i2c: at91: add of_device_id entry for at91rm9200
Hi,
Quoted 12 lines · Wolfram Sang
Quoted 11 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 9 lines · Joachim Eastwood
Signed-off-by Joachim Eastwood <[email protected]>---
Hi,AT91RM9200 is gaining DT support now so let's add an id to the i2c driver.
Tested on custom RM9200 board. Since the driver doesn't support pinctrl muxing yet I had to add pinctrl hogs for the i2c pins in my dts for it to work.
Quoted 5 lines
Quoted 3 lines
IIRC the i2c IP have quite a lots of issue on rm9200 and until sam9g45
it not recommended to use it instead use i2c-gpio
Ludovic, you know the driver best. Does it make sense to add this?
I didn't add this when I did the rework because there was no DT tree support for RM9200. The configuration for RM9200 IP is already in the driver and used for non DT platform so I think it makes sense to add this.
But as Jean-Christophe said, it's recommended to use the i2c-gpio driver since we know the first versions of the IP have several issues. However if it fits user usage, it is not forbidden to use it.
Regards
Ludovic
Quoted 34 lines
Quoted 32 lines
Best Regards,
J.Quoted 22 lines
regards
Joachim Eastwooddrivers/i2c/busses/i2c-at91.c | 3 +++ 1 file changed, 3 insertions(+)drivers/i2c/busses/i2c-at91.c +3
-1@@ -584,6 +584,9 @@ static const struct platform_device_id at91_twi_devtypes[] = { #if defined(CONFIG_OF) static const struct of_device_id atmel_twi_dt_ids[] = { { + .compatible = "atmel,at91rm9200-i2c", + .data = &at91rm9200_config, + } , { .compatible = "atmel,at91sam9260-i2c", .data = &at91sam9260_config, } , { --Quoted 2 lines
1.8.0
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 1/1 i2c: at91: add of_device_id entry for at91rm9200
Quoted 30 lines · ludovic.desroches
Hi,
Quoted 18 lines · Wolfram Sang
Quoted 15 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 11 lines · Joachim Eastwood
Signed-off-by Joachim Eastwood <[email protected]>---
Hi,AT91RM9200 is gaining DT support now so let's add an id to the i2c driver.
Tested on custom RM9200 board. Since the driver doesn't support pinctrl muxing yet I had to add pinctrl hogs for the i2c pins in my dts for it to work.
Quoted 6 lines
Quoted 3 lines
IIRC the i2c IP have quite a lots of issue on rm9200 and until sam9g45
it not recommended to use it instead use i2c-gpio
Ludovic, you know the driver best. Does it make sense to add this?
Quoted 7 lines
I didn't add this when I did the rework because there was no DT tree support for RM9200. The configuration for RM9200 IP is already in the driver and used for non DT platform so I think it makes sense to add this.
But as Jean-Christophe said, it's recommended to use the i2c-gpio driver since we know the first versions of the IP have several issues. However if it fits user usage, it is not forbidden to use it.
I assumed the new driver handles the HW quirks better than the old atmel-twi driver(?). So the RM9200 i2c HW is at least usable with this driver.
I didn't encounter any problems during my short testing using a couple of different i2c devices. As far as I can remember the old driver didn't even handle the devices I tested with the new driver.
regards
Joachim Eastwood
PATCH 1/1 i2c: at91: add of_device_id entry for at91rm9200
Quoted 35 lines · Joachim Eastwood
Quoted 34 lines · ludovic.desroches
Hi,
Quoted 18 lines · Wolfram Sang
Quoted 15 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 11 lines · Joachim Eastwood
Signed-off-by Joachim Eastwood <[email protected]>---
Hi,AT91RM9200 is gaining DT support now so let's add an id to the i2c driver.
Tested on custom RM9200 board. Since the driver doesn't support pinctrl muxing yet I had to add pinctrl hogs for the i2c pins in my dts for it to work.
Quoted 6 lines
Quoted 3 lines
IIRC the i2c IP have quite a lots of issue on rm9200 and until sam9g45
it not recommended to use it instead use i2c-gpio
Ludovic, you know the driver best. Does it make sense to add this?
I didn't add this when I did the rework because there was no DT tree support for RM9200. The configuration for RM9200 IP is already in the driver and used for non DT platform so I think it makes sense to add this.
Quoted 7 lines
Quoted 3 lines
But as Jean-Christophe said, it's recommended to use the i2c-gpio driver since we know the first versions of the IP have several issues. However if it fits user usage, it is not forbidden to use it.
I assumed the new driver handles the HW quirks better than the old atmel-twi driver(?). So the RM9200 i2c HW is at least usable with this driver.
No it doesn't handle HW quirks (clock stretching, stop command, etc.) better for old IP versions than the old atmel-twi. Since we have no workarounds for these quirks, it was recommended to use i2c-gpio.
Quoted 3 lines
I didn't encounter any problems during my short testing using a couple of different i2c devices. As far as I can remember the old driver didn't even handle the devices I tested with the new driver.
I also did some tests on RM9200 with basic i2c devices and everything go well so yes it is usable that's why I think this patch can be applied.
Regards
Ludovic
PATCH 1/1 i2c: at91: add of_device_id entry for at91rm9200
In reply to ludovic.desrochesHi,
Quoted 4 lines
I didn't add this when I did the rework because there was no DT tree support for RM9200. The configuration for RM9200 IP is already in the driver and used for non DT platform so I think it makes sense to add this.
I agree. If it is usable for non-dt, it should be usable for dt. If it makes sense is left to the user.
Interpreted Ludovic's comment as ack and applied to -next, thanks!
Signature · 9 lines
Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130124/d5e790cb/attachment.sig>
PATCH 1/1 i2c: at91: add of_device_id entry for at91rm9200
Quoted 7 lines · Wolfram Sang
Hi,
Quoted 4 lines
I didn't add this when I did the rework because there was no DT tree support for RM9200. The configuration for RM9200 IP is already in the driver and used for non DT platform so I think it makes sense to add this.
Quoted 5 lines
I agree. If it is usable for non-dt, it should be usable for dt. If it makes sense is left to the user.
Interpreted Ludovic's comment as ack and applied to -next, thanks!
Yes it is, thanks.
Regards
Ludovic