Skip to contentSkip to conversation

goldfish: framebuffer

PATCH In review Alan Cox 2 participants 4 messages Jan 25, 2013 – Jan 26, 2013 Framebuffer layer

lore
Share & tools
lore

Alan Cox

author
#0 lore raw

PATCH 1/1 goldfish: framebuffer

From: Arve Hjønnevåg <[email protected]>

Framebuffer support for the Goldfish emulator. This takes the Google emulator and applies the x86 cleanups as well as moving the blank methods to the usual Linux place and dropping the Android early suspend logic (for now at least, that can be looked at as Android and upstream converge). Dropped various oddities like setting MTRRs on a virtual frame buffer emulation...

With the drivers so far you can now boot a Linux initrd and have fun.

[cleaned up to handle x86]
[ported to 3.4]
[cleaned up for style and 3.7, moved blank methods]

---

 drivers/video/Kconfig      |    9 +
 drivers/video/Makefile     |    1 
 drivers/video/goldfishfb.c |  316 ++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 326 insertions(+)
 create mode 100644 drivers/video/goldfishfb.c
drivers/video/Kconfig +9 -0
index e4e1765..59889fc 100644
@@ -2183,6 +2183,15 @@ config FB_XILINX
 	  framebuffer. ML300 carries a 640*480 LCD display on the board,
 	  ML403 uses a standard DB15 VGA connector.
 
+config FB_GOLDFISH
+	tristate "Goldfish Framebuffer"
+	depends on FB
+	select FB_CFB_FILLRECT
+	select FB_CFB_COPYAREA
+	select FB_CFB_IMAGEBLIT
+	---help---
+	  Framebuffer driver for Goldfish Virtual Platform
+
 config FB_COBALT
 	tristate "Cobalt server LCD frame buffer support"
 	depends on FB && (MIPS_COBALT || MIPS_SEAD3)
drivers/video/Makefile +1 -0
index 768a137..3363f67 100644
@@ -98,6 +98,7 @@ obj-$(CONFIG_FB_ATMEL)		  += atmel_lcdfb.o
 obj-$(CONFIG_FB_PVR2)             += pvr2fb.o
 obj-$(CONFIG_FB_VOODOO1)          += sstfb.o
 obj-$(CONFIG_FB_ARMCLCD)	  += amba-clcd.o
+obj-$(CONFIG_FB_GOLDFISH)         += goldfishfb.o
 obj-$(CONFIG_FB_68328)            += 68328fb.o
 obj-$(CONFIG_FB_GBE)              += gbefb.o
 obj-$(CONFIG_FB_CIRRUS)		  += cirrusfb.o
drivers/video/goldfishfb.c new file +316 -0

316 lines not on this page · raw message

#1 lore raw
Quoted 7 lines · On Fri, 25 Jan 2013 15:31:17 +0000 Alan Cox <[email protected]> wrote:

Framebuffer support for the Goldfish emulator. This takes the Google emulator and applies the x86 cleanups as well as moving the blank methods to the usual Linux place and dropping the Android early suspend logic (for now at least, that can be looked at as Android and upstream converge). Dropped various oddities like setting MTRRs on a virtual frame buffer emulation...

With the drivers so far you can now boot a Linux initrd and have fun.

That looks nice and clean. I'll grab it; hopefully for Florian to take off my hands when he returns.

Quoted 4 lines
[cleaned up to handle x86]
Quoted 8 lines
[ported to 3.4]
[cleaned up for style and 3.7, moved blank methods]

hm, it's unclear whether the [] comments apply to the line above or to the line below. I converted it to my usual form. I hope I got it right!

[[email protected]: cleaned up to handle x86]
[[email protected]: ported to 3.4]
[[email protected]: cleaned up for style and 3.7, moved blank methods]
Cc Florian Tobias Schandinat <[email protected]>
Cc Tomi Valkeinen <[email protected]>
#2 lore raw
In reply to Alan Cox
Quoted 6 lines · On Sat, 26 Jan 2013 00:27:45 +0000 Alan Cox <[email protected]> wrote:
Quoted 3 lines

hm, it's unclear whether the [] comments apply to the line above or to the line below. I converted it to my usual form. I hope I got it right!

Below so you got them all one out 8)

o dwat.

[[email protected]: cleaned up to handle x86]
[[email protected]: ported to 3.4]
[[email protected]: cleaned up for style and 3.7, moved blank methods]
Cc Florian Tobias Schandinat <[email protected]>
Cc Tomi Valkeinen <[email protected]>
author
#3 lore raw
In reply to Alan Cox
Quoted 3 lines

hm, it's unclear whether the [] comments apply to the line above or to the line below. I converted it to my usual form. I hope I got it right!

Below so you got them all one out 8)

Alan