Skip to contentSkip to conversation

block: IBM RamSan 70/80 device driver.

PATCH Philip J. Kelleher 1 participant 1 message Jan 25, 2013

lore
Share & tools
lore
#0 lore raw

Hi,

Quoted 12 lines
Quoted 6 lines

From: Joshua H Morris <[email protected]>
Philip J Kelleher <[email protected]>

This patch includes the device driver for the IBM RamSan family of PCI SSD flash storage cards. This driver will inlcude support for the RamSan 70 and 80. The driver presents a block device for device I/O.

Hi,

Your driver does not handle REQ_FLUSH. Does that mean that the supported cards do not have a volatile write-back cache?

We do not have a volatile write-back cache.

Quoted 13 lines

Review

Quoted 9 lines
(quoted diff) +9 -0
+	blk_size = rsxx_get_logical_block_size(card);
+
+	blk_queue_make_request(card->queue, rsxx_make_request);
+	blk_queue_bounce_limit(card->queue, BLK_BOUNCE_ANY);
+	blk_queue_dma_alignment(card->queue, blk_size - 1);
+	blk_queue_max_hw_sectors(card->queue, blkdev_max_hw_sectors);
+	blk_queue_logical_block_size(card->queue, blk_size);
+	blk_queue_physical_block_size(card->queue, RSXX_HW_BLK_SIZE);
+	blk_queue_max_discard_sectors(card->queue, RSXX_HW_BLK_SIZE >> 9);

Did you mean to set max_discard_sectors inside the below for loop? Either way, do you really only support a single hardware sector discard?

Quoted 7 lines

Review

Quoted 7 lines
(quoted diff) +7 -0
+	queue_flag_set_unlocked(QUEUE_FLAG_NONROT, card->queue);
+	if (rsxx_discard_supported(card)) {
+		queue_flag_set_unlocked(QUEUE_FLAG_DISCARD, card->queue);
+		card->queue->limits.discard_granularity = RSXX_HW_BLK_SIZE;
+		card->queue->limits.discard_alignment   = RSXX_HW_BLK_SIZE;
+		card->queue->limits.discard_zeroes_data = 1;
+	}

Yes, we only do discards in 4k chunks. It does look as though the max_discard_sectors can/should be moved inside the if statement.

Thanks,
Philip