Skip to contentSkip to conversation

tegra: fdt: add back missing host1x node

PATCH New Allen Martin 3 participants 6 messages Jan 25, 2013 – Jan 28, 2013 Tegra architecture support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tegra: fdt: add back missing host1x node

Add back host1x node to seaboard dts file. This got dropped during the tegra fdt sort.

---
 board/nvidia/dts/tegra20-seaboard.dts |   11 +++++++++++
 1 file changed, 11 insertions(+)
board/nvidia/dts/tegra20-seaboard.dts +11 -0
index 9cb9b5b..527a296 100644
@@ -27,6 +27,17 @@
 		reg = < 0x00000000 0x40000000 >;
 	};
 
+	host1x {
+		status = "okay";
+		dc at 54200000 {
+			status = "okay";
+			rgb {
+				status = "okay";
+				nvidia,panel = <&lcd_panel>;
+			};
+		};
+	};
+
 	/* This is not used in U-Boot, but is expected to be in kernel .dts */
 	i2c at 7000d000 {
 		clock-frequency = <100000>;
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 tegra: fdt: add back missing host1x node

Quoted 5 lines · Allen Martin

Add back host1x node to seaboard dts file. This got dropped during the tegra fdt sort.

---

Hi Albert, would it be possible for you to apply this directly to your u-boot-arm repository? It fixes a regression introduced by my previous patch:

b7723f3 tegra: fdt: sort dts files

So I wanted to make sure it gets applied before that previous patch makes it to u-boot/master, and Tom's not ready to do another tegra pull request yet.

-Allen

Quoted 28 lines
 board/nvidia/dts/tegra20-seaboard.dts |   11 +++++++++++
 1 file changed, 11 insertions(+)
board/nvidia/dts/tegra20-seaboard.dts +11 -0
index 9cb9b5b..527a296 100644
@@ -27,6 +27,17 @@
 		reg = < 0x00000000 0x40000000 >;
 	};
 
+	host1x {
+		status = "okay";
+		dc at 54200000 {
+			status = "okay";
+			rgb {
+				status = "okay";
+				nvidia,panel = <&lcd_panel>;
+			};
+		};
+	};
+
 	/* This is not used in U-Boot, but is expected to be in kernel .dts */
 	i2c at 7000d000 {
 		clock-frequency = <100000>;
Signature · 1 line
1.7.10.4
Signature · 1 line
nvpublic
#2 lore raw

PATCH 1/1 tegra: fdt: add back missing host1x node

Hi Allen,

Quoted 11 lines · Allen Martin

Hi Albert, would it be possible for you to apply this directly to your u-boot-arm repository? It fixes a regression introduced by my previous patch:

b7723f3 tegra: fdt: sort dts files

So I wanted to make sure it gets applied before that previous patch makes it to u-boot/master, and Tom's not ready to do another tegra pull request yet.

-Allen

Actually, I did not take Tom's PR as it caused some warnings. Maybe your fix can get in the TI tree before a fixed PR is sent out?

Amicalement,

Signature · 1 line
Albert.
#3 lore raw

PATCH 1/1 tegra: fdt: add back missing host1x node

Albert,

Quoted 18 lines

-----Original Message-----
From: Albert ARIBAUD [mailto:albert.u.boot at aribaud.net]
Sent: Saturday, January 26, 2013 3:57 AM
To: Allen Martin
Cc: Tom Warren; swarren at wwwdotorg.org; u-boot at lists.denx.de
Subject: Re: [PATCH] tegra: fdt: add back missing host1x node

Hi Allen,

Quoted 6 lines · Allen Martin

Hi Albert, would it be possible for you to apply this directly to your u-boot-arm repository? It fixes a regression introduced by my previous patch:

b7723f3 tegra: fdt: sort dts files

Quoted 8 lines
Quoted 5 lines

So I wanted to make sure it gets applied before that previous patch makes it to u-boot/master, and Tom's not ready to do another tegra pull request yet.

-Allen

Actually, I did not take Tom's PR as it caused some warnings. Maybe your fix can get in the TI tree before a fixed PR is sent out?

Have you got the right Tom? This is for the Tegra tree (u-boot-tegra), not TI, Tom Warren, not Tom Rini.

My PR *has* been taken into the ARM/master branch, AFAICT, and I never release PRs with warnings or errors that aren't already pre-existing in other ARM builds (VCMA9 and smdk2410, for instance).

Allen's fix is for a Tegra DT file, not for any TI board/SoC/etc.

Thanks,

Tom

Quoted 4 lines

Amicalement,
--
Albert.

--
Nvpublic

#4 lore raw

PATCH 1/1 tegra: fdt: add back missing host1x node

Hi Tom,

Quoted 26 lines · Tom Warren

Albert,

Quoted 24 lines

-----Original Message-----
From: Albert ARIBAUD [mailto:albert.u.boot at aribaud.net]
Sent: Saturday, January 26, 2013 3:57 AM
To: Allen Martin
Cc: Tom Warren; swarren at wwwdotorg.org; u-boot at lists.denx.de
Subject: Re: [PATCH] tegra: fdt: add back missing host1x node

Hi Allen,

Quoted 11 lines · Allen Martin

Hi Albert, would it be possible for you to apply this directly to your u-boot-arm repository? It fixes a regression introduced by my previous patch:

b7723f3 tegra: fdt: sort dts files

So I wanted to make sure it gets applied before that previous patch makes it to u-boot/master, and Tom's not ready to do another tegra pull request yet.

-Allen

Quoted 8 lines
Quoted 2 lines

Actually, I did not take Tom's PR as it caused some warnings. Maybe your fix can get in the TI tree before a fixed PR is sent out?

Have you got the right Tom? This is for the Tegra tree (u-boot-tegra), not TI, Tom Warren, not Tom Rini.

My PR *has* been taken into the ARM/master branch, AFAICT, and I never release PRs with warnings or errors that aren't already pre-existing in other ARM builds (VCMA9 and smdk2410, for instance).

Allen's fix is for a Tegra DT file, not for any TI board/SoC/etc.

My bad -- I've indeed mixed up Toms here.

Quoted 3 lines

Thanks,

Tom

Amicalement,

Signature · 1 line
Albert.
#5 lore raw

PATCH 1/1 tegra: fdt: add back missing host1x node

Quoted 8 lines
Quoted 5 lines

Have you got the right Tom? This is for the Tegra tree (u-boot-tegra), not TI, Tom Warren, not Tom Rini.

My PR *has* been taken into the ARM/master branch, AFAICT, and I never release PRs with warnings or errors that aren't already pre-existing in other ARM builds (VCMA9 and smdk2410, for instance).

Allen's fix is for a Tegra DT file, not for any TI board/SoC/etc.

My bad -- I've indeed mixed up Toms here.

No worries, so would it be ok to take this patch in through the arm tree so the regression doesn't make it up into Wolfgang's tree?

-Allen

Signature · 1 line
nvpublic