Skip to contentSkip to conversation

mx23evk: Remove unneeded 'undef's

PATCH New Fabio Estevam 5 participants 12 messages Jan 28, 2013 – Feb 12, 2013

lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH 1/3 mx23evk: Remove unneeded 'undef's

Rather than 'undef'ing some symbols, just remove them instead.

Signed-off-by Fabio Estevam <[email protected]>
---
 include/configs/mx23evk.h |    2 --
 1 file changed, 2 deletions(-)
include/configs/mx23evk.h +0 -2
index c44a8b8..51aa9c4 100644
@@ -49,8 +49,6 @@
 
 /* U-Boot Commands */
 #include <config_cmd_default.h>
-#undef CONFIG_CMD_NET
-#undef CONFIG_CMD_NFS
 
 #define CONFIG_DISPLAY_CPUINFO
 #define CONFIG_DOS_PARTITION
Signature · 1 line
1.7.9.5
author
#1 lore raw

PATCH 2/3 mx23evk: Remove CONFIG_SYS_BAUDRATE_TABLE

The baudrate is already defined by CONFIG_BAUDRATE and there is no need to keep CONFIG_SYS_BAUDRATE_TABLE.

Signed-off-by Fabio Estevam <[email protected]>
---
 include/configs/mx23evk.h |    1 -
 1 file changed, 1 deletion(-)
include/configs/mx23evk.h +0 -1
index 51aa9c4..e43b93f 100644
@@ -110,7 +110,6 @@
 #define CONFIG_PL01x_PORTS		{ (void *)MXS_UARTDBG_BASE }
 #define CONFIG_CONS_INDEX		0
 #define CONFIG_BAUDRATE			115200	/* Default baud rate */
-#define CONFIG_SYS_BAUDRATE_TABLE	{ 9600, 19200, 38400, 57600, 115200 }
 
 /* DMA */
 #define CONFIG_APBH_DMA
Signature · 1 line
1.7.9.5
#3 lore raw

PATCH 2/3 mx23evk: Remove CONFIG_SYS_BAUDRATE_TABLE

In reply to Fabio Estevam

Dear Fabio Estevam,

Quoted 13 lines

The baudrate is already defined by CONFIG_BAUDRATE and there is no need to keep CONFIG_SYS_BAUDRATE_TABLE.

Signed-off-by Fabio Estevam <[email protected]>
---
 include/configs/mx23evk.h |    1 -
 1 file changed, 1 deletion(-)
include/configs/mx23evk.h +0 -0
index 51aa9c4..e43b93f 100644

include/configs/mx23evk.h line 113

Quoted 4 lines
include/configs/mx23evk.h +0 -1
@@ -110,7 +110,6 @@
 #define CONFIG_PL01x_PORTS		{ (void *)MXS_UARTDBG_BASE }
 #define CONFIG_CONS_INDEX		0
 #define CONFIG_BAUDRATE			115200	/* Default baud rate */
-#define CONFIG_SYS_BAUDRATE_TABLE	{ 9600, 19200, 38400, 57600, 115200 }

This will not allow different baudrates now, will it?

Best regards,
Marek Vasut

#4 lore raw

PATCH 2/3 mx23evk: Remove CONFIG_SYS_BAUDRATE_TABLE

Quoted 1 line · Marek Vasut

This will not allow different baudrates now, will it?

You still may change the baudrate if you need to.

CONFIG_SYS_BAUDRATE_TABLE has been placed to a common place after the commit below:

commit 26750c8aee2383a026e0cf89e9310628d3a5a6a0

Author: Tom Rini <[email protected]>
Date:   Tue Jun 19 12:54:34 2012 +0000

CONFIG_SYS_BAUDRATE_TABLE: Add <config_fallbacks.h>, place there

We provide a default table of { 9600, 19200, 38400, 57600, 115200 } in <config_fallbacks.h> which mkconfig places after <configs/...h> in the generated config file. This is used when a board has not set its own table.

Signed-off-by Tom Rini <[email protected]>
#5 lore raw

PATCH 2/3 mx23evk: Remove CONFIG_SYS_BAUDRATE_TABLE

Dear Fabio Estevam,

Quoted 12 lines · Marek Vasut
Quoted 1 line

This will not allow different baudrates now, will it?

You still may change the baudrate if you need to.

CONFIG_SYS_BAUDRATE_TABLE has been placed to a common place after the commit below:

commit 26750c8aee2383a026e0cf89e9310628d3a5a6a0

Author: Tom Rini <[email protected]>
Date:   Tue Jun 19 12:54:34 2012 +0000
Quoted 8 lines

CONFIG_SYS_BAUDRATE_TABLE: Add <config_fallbacks.h>, place there

We provide a default table of { 9600, 19200, 38400, 57600, 115200 } in <config_fallbacks.h> which mkconfig places after <configs/...h> in the generated config file. This is used when a board has not set its own table.

Signed-off-by Tom Rini <[email protected]>

Ok then I'd say -- kill 'em all!!

Best regards,
Marek Vasut

#6 lore raw

PATCH 2/3 mx23evk: Remove CONFIG_SYS_BAUDRATE_TABLE

In reply to Fabio Estevam
Quoted 5 lines · Fabio Estevam

The baudrate is already defined by CONFIG_BAUDRATE and there is no need to keep CONFIG_SYS_BAUDRATE_TABLE.

Signed-off-by Fabio Estevam <[email protected]>

---

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
author
#7 lore raw

PATCH 3/3 mx23evk: Turn on caches

In reply to Fabio Estevam

It is safe to turn on data and instruction caches for mx23.

Signed-off-by Fabio Estevam <[email protected]>
---
 include/configs/mx23evk.h |    2 --
 1 file changed, 2 deletions(-)
include/configs/mx23evk.h +0 -2
index e43b93f..ae8cf6c 100644
@@ -33,8 +33,6 @@
 #define CONFIG_MACH_TYPE	MACH_TYPE_MX23EVK
 
 #define CONFIG_SYS_NO_FLASH
-#define CONFIG_SYS_ICACHE_OFF
-#define CONFIG_SYS_DCACHE_OFF
 #define CONFIG_BOARD_EARLY_INIT_F
 #define CONFIG_ARCH_MISC_INIT
Signature · 1 line
1.7.9.5
#8 lore raw

PATCH 3/3 mx23evk: Turn on caches

Dear Fabio Estevam,

Quoted 12 lines

It is safe to turn on data and instruction caches for mx23.

Signed-off-by Fabio Estevam <[email protected]>
---
 include/configs/mx23evk.h |    2 --
 1 file changed, 2 deletions(-)
include/configs/mx23evk.h +0 -0
index e43b93f..ae8cf6c 100644

include/configs/mx23evk.h line 37

Quoted 7 lines
include/configs/mx23evk.h +0 -2
@@ -33,8 +33,6 @@
 #define CONFIG_MACH_TYPE	MACH_TYPE_MX23EVK
 
 #define CONFIG_SYS_NO_FLASH
-#define CONFIG_SYS_ICACHE_OFF
-#define CONFIG_SYS_DCACHE_OFF
 #define CONFIG_BOARD_EARLY_INIT_F
 #define CONFIG_ARCH_MISC_INIT

Can you fix this for olinuxino (if not done already) too please?

Best regards,
Marek Vasut

#9 lore raw

PATCH 3/3 mx23evk: Turn on caches

Quoted 1 line · Marek Vasut

Can you fix this for olinuxino (if not done already) too please?

mx23olinuxino has the caches turned on already.

#10 lore raw

PATCH 3/3 mx23evk: Turn on caches

In reply to Fabio Estevam
Quoted 4 lines · Fabio Estevam

It is safe to turn on data and instruction caches for mx23.

Signed-off-by Fabio Estevam <[email protected]>

---

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#11 lore raw

PATCH 1/3 mx23evk: Remove unneeded 'undef's

In reply to Fabio Estevam
Quoted 12 lines · Fabio Estevam

Rather than 'undef'ing some symbols, just remove them instead.

Signed-off-by Fabio Estevam <[email protected]>
---
 include/configs/mx23evk.h |    2 --
 1 file changed, 2 deletions(-)
include/configs/mx23evk.h +0 -0
index c44a8b8..51aa9c4 100644

include/configs/mx23evk.h line 54

Quoted 8 lines
include/configs/mx23evk.h +0 -2
@@ -49,8 +49,6 @@
 
 /* U-Boot Commands */
 #include <config_cmd_default.h>
-#undef CONFIG_CMD_NET
-#undef CONFIG_CMD_NFS
 
 #define CONFIG_DISPLAY_CPUINFO
 #define CONFIG_DOS_PARTITION

The problem is that the default cmd set include them; that's why I had the undef.

--
Otavio Salvador O.S. Systems
E-mail: otavio at ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br