Skip to contentSkip to conversation

usb: mxs: Disable USB Port 1 for i.MX23

PATCH Superseded Otavio Salvador 3 participants 14 messages Jan 28, 2013

Subsystems (3)
USB Arm i.MX and Layerscape USB ehci driver

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Otavio Salvador

author
#0 lore raw

PATCH 1/4 usb: mxs: Disable USB Port 1 for i.MX23

The i.MX23 just one USB port so disable the second controller probe when building for i.MX23.

Signed-off-by Otavio Salvador <[email protected]>
---
 drivers/usb/host/ehci-mxs.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/usb/host/ehci-mxs.c +2 -0
index 5062af5..28c8cde 100644
@@ -50,10 +50,12 @@ int mxs_ehci_get_port(struct ehci_mxs *mxs_usb, int port)
 		usb_base = MXS_USBCTRL0_BASE;
 		phy_base = MXS_USBPHY0_BASE;
 		break;
+#ifdef CONFIG_MX28
 	case 1:
 		usb_base = MXS_USBCTRL1_BASE;
 		phy_base = MXS_USBPHY1_BASE;
 		break;
+#endif
 	default:
 		printf("CONFIG_EHCI_MXS_PORT (port = %d)\n", port);
 		return -1;
Signature · 1 line
1.8.1
author
#1 lore raw

PATCH 2/4 mx23evk: Enable USB support

Signed-off-by Otavio Salvador <[email protected]>
---
 include/configs/mx23evk.h | 10 ++++++++++
 1 file changed, 10 insertions(+)
include/configs/mx23evk.h +10 -0
index d206c95..99dfb8f 100644
@@ -58,6 +58,7 @@
 #define CONFIG_CMD_FAT
 #define CONFIG_CMD_GPIO
 #define CONFIG_CMD_MMC
+#define CONFIG_CMD_USB
 #define CONFIG_CMD_BOOTZ
 
 /* Memory configurations */

@@ -122,6 +123,15 @@
 #define CONFIG_MXS_MMC
 #endif
 
+/* USB */
+#ifdef	CONFIG_CMD_USB
+#define	CONFIG_USB_EHCI
+#define	CONFIG_USB_EHCI_MXS
+#define	CONFIG_EHCI_MXS_PORT 0
+#define	CONFIG_EHCI_IS_TDI
+#define	CONFIG_USB_STORAGE
+#endif
+
 /* Boot Linux */
 #define CONFIG_CMDLINE_TAG
 #define CONFIG_SETUP_MEMORY_TAGS
Signature · 1 line
1.8.1
author
#2 lore raw

PATCH 3/4 mx23_olinuxino: Enable USB support

In reply to Otavio Salvador
Signed-off-by Otavio Salvador <[email protected]>
---
 include/configs/mx23_olinuxino.h | 10 ++++++++++
 1 file changed, 10 insertions(+)
include/configs/mx23_olinuxino.h +10 -0
index d019944..e081c49 100644
@@ -60,6 +60,7 @@
 #define	CONFIG_CMD_GPIO
 #define	CONFIG_CMD_LED
 #define	CONFIG_CMD_MMC
+#define	CONFIG_CMD_USB
 
 /*
  * Memory configurations

@@ -140,6 +141,15 @@
  */
 #define CONFIG_APBH_DMA
 
+/* USB */
+#ifdef	CONFIG_CMD_USB
+#define	CONFIG_USB_EHCI
+#define	CONFIG_USB_EHCI_MXS
+#define	CONFIG_EHCI_MXS_PORT 0
+#define	CONFIG_EHCI_IS_TDI
+#define	CONFIG_USB_STORAGE
+#endif
+
 /*
  * Boot Linux
  */
Signature · 1 line
1.8.1
#3 lore raw

PATCH 3/4 mx23_olinuxino: Enable USB support

Dear Otavio Salvador,

Missing commit message ... _AGAIN_ ... how many times do I have to repeat myself? Write it down or something already :/

Quoted 23 lines
Signed-off-by Otavio Salvador <[email protected]>
---
 include/configs/mx23_olinuxino.h | 10 ++++++++++
 1 file changed, 10 insertions(+)
(quoted diff) +0 -0

b/include/configs/mx23_olinuxino.h index d019944..e081c49 100644

include/configs/mx23_olinuxino.h +3 -0
@@ -60,6 +60,7 @@
 #define	CONFIG_CMD_GPIO
 #define	CONFIG_CMD_LED
 #define	CONFIG_CMD_MMC
+#define	CONFIG_CMD_USB
 
 /*
  * Memory configurations

@@ -140,6 +141,15 @@
  */
 #define CONFIG_APBH_DMA
 
+/* USB */
+#ifdef	CONFIG_CMD_USB

include/configs/mx23_olinuxino.h line 155

Quoted 10 lines
include/configs/mx23_olinuxino.h +7 -0
+#define	CONFIG_USB_EHCI
+#define	CONFIG_USB_EHCI_MXS
+#define	CONFIG_EHCI_MXS_PORT 0
+#define	CONFIG_EHCI_IS_TDI
+#define	CONFIG_USB_STORAGE
+#endif
+
 /*
  * Boot Linux
  */

Best regards,
Marek Vasut

author
#4 lore raw

PATCH 3/4 mx23_olinuxino: Enable USB support

Quoted 4 lines · Marek Vasut

Dear Otavio Salvador,

Missing commit message ... _AGAIN_ ... how many times do I have to repeat myself? Write it down or something already :/

What I need to put to make it more clear than "Enable USB support"? It seems clear; it does only it!

--
Otavio Salvador O.S. Systems
E-mail: otavio at ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br

author
#5 lore raw

PATCH 4/4 mx23_olinuxino: Add ethernet support

In reply to Otavio Salvador
Signed-off-by Otavio Salvador <[email protected]>
---
 board/olimex/mx23_olinuxino/mx23_olinuxino.c |  8 ++++++
 board/olimex/mx23_olinuxino/spl_boot.c       |  4 +++
 include/configs/mx23_olinuxino.h             | 41 ++++++++++++++++++++++++++--
 3 files changed, 50 insertions(+), 3 deletions(-)
board/olimex/mx23_olinuxino/mx23_olinuxino.c +8 -0
index 2501417..6077d70 100644
@@ -53,6 +53,14 @@ int dram_init(void)
 	return mxs_dram_init();
 }
 
+#ifdef CONFIG_CMD_NET
+int board_eth_init(bd_t *bis)
+{
+	/* Power-on Ethernet */
+	gpio_direction_output(MX23_PAD_GPMI_ALE__GPIO_0_17, 1);
+}
+#endif
+
 #ifdef	CONFIG_CMD_MMC
 static int mx23_olx_mmc_cd(int id)
 {
board/olimex/mx23_olinuxino/spl_boot.c +4 -0
index 3bbf5ad..8f7ba0b 100644
@@ -95,6 +95,10 @@ const iomux_cfg_t iomux_setup[] = {
 	MX23_PAD_SSP1_DATA2__SSP1_DATA2 | MUX_CONFIG_SSP,
 	MX23_PAD_SSP1_DATA3__SSP1_DATA3 | MUX_CONFIG_SSP,
 	MX23_PAD_SSP1_SCK__SSP1_SCK | MUX_CONFIG_SSP,
+
+	/* Ethernet */
+	MX23_PAD_GPMI_ALE__GPIO_0_17 |
+		(MXS_PAD_12MA | MXS_PAD_3V3),
 };
 
 void board_init_ll(void)
include/configs/mx23_olinuxino.h +38 -3

83 lines not on this page · raw message

Signature · 1 line
1.8.1
reviewer
#6 lore raw

PATCH 4/4 mx23_olinuxino: Add ethernet support

include/configs/mx23_olinuxino.h line 204

Quoted 2 lines · Otavio Salvador
include/configs/mx23_olinuxino.h +2 -0
+       "ip_dyn=yes\0" \
+       "usbethaddr=00:11:22:33:44:55\0" \

You should not hardcode a MAC address.

author
#7 lore raw

PATCH 4/4 mx23_olinuxino: Add ethernet support

Quoted 7 lines · Fabio Estevam

include/configs/mx23_olinuxino.h line 204

Quoted 2 lines · Otavio Salvador
include/configs/mx23_olinuxino.h +2 -0
+       "ip_dyn=yes\0" \
+       "usbethaddr=00:11:22:33:44:55\0" \

You should not hardcode a MAC address.

It does not provide one.

--
Otavio Salvador O.S. Systems
E-mail: otavio at ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br

#8 lore raw

PATCH 4/4 mx23_olinuxino: Add ethernet support

Dear Otavio Salvador,

Quoted 10 lines · Fabio Estevam
Quoted 7 lines

On Mon, Jan 28, 2013 at 5:14 PM, Otavio Salvador

include/configs/mx23_olinuxino.h line 204

Quoted 2 lines · <[email protected]> wrote:
include/configs/mx23_olinuxino.h +2 -0
+       "ip_dyn=yes\0" \
+       "usbethaddr=00:11:22:33:44:55\0" \

You should not hardcode a MAC address.

It does not provide one.

Your dongle? Then leave that up to user. Besides, there's a tool in tools/ for generating a random MAC.

Best regards,
Marek Vasut

reviewer
#9 lore raw

PATCH 4/4 mx23_olinuxino: Add ethernet support

In reply to Otavio Salvador
Quoted 3 lines · Otavio Salvador
Quoted 1 line

You should not hardcode a MAC address.

It does not provide one.

Right, but you can not force all olinuxino boards to have the same MAC address, so just remove the MAC setting and each one can set its own.

Also, please read:
http://www.denx.de/wiki/view/DULG/WhereCanIGetAValidMACAddresshttp://www.denx.de/wiki/view/DULG/WhereCanIGetAValidMACAddress

#10 lore raw

PATCH 4/4 mx23_olinuxino: Add ethernet support

In reply to Otavio Salvador

Dear Otavio Salvador,

And again ... NAK

Anyway, will the hub function properly if you toggle the GPIO in board_eth_init? I dont think so.

[..]

Best regards,
Marek Vasut

reviewer
#11 lore raw

PATCH 4/4 mx23_olinuxino: Add ethernet support

In reply to Otavio Salvador

board/olimex/mx23_olinuxino/mx23_olinuxino.c int dram_init(void) · line 62

Quoted 7 lines · Otavio Salvador
board/olimex/mx23_olinuxino/mx23_olinuxino.c +7 -0
+#ifdef CONFIG_CMD_NET
+int board_eth_init(bd_t *bis)
+{
+       /* Power-on Ethernet */
+       gpio_direction_output(MX23_PAD_GPMI_ALE__GPIO_0_17, 1);
+}
+#endif

This function expects to return an integer, and there is no return value here.

Also, maybe you could set the GPIO inside board_early_init_f() like we do on mx28.

#12 lore raw

PATCH 4/4 mx23_olinuxino: Add ethernet support

Dear Fabio Estevam,

Quoted 14 lines

On Mon, Jan 28, 2013 at 5:14 PM, Otavio Salvador

board/olimex/mx23_olinuxino/mx23_olinuxino.c int dram_init(void) · line 62

Quoted 7 lines · <[email protected]> wrote:
board/olimex/mx23_olinuxino/mx23_olinuxino.c +7 -0
+#ifdef CONFIG_CMD_NET
+int board_eth_init(bd_t *bis)
+{
+       /* Power-on Ethernet */
+       gpio_direction_output(MX23_PAD_GPMI_ALE__GPIO_0_17, 1);
+}
+#endif

This function expects to return an integer, and there is no return value here.

Quoted 2 lines

Also, maybe you could set the GPIO inside board_early_init_f() like we do on mx28.

How come it didn't emit an error?

Best regards,
Marek Vasut

author
#13 lore raw

PATCH 4/4 mx23_olinuxino: Add ethernet support

Quoted 16 lines · Marek Vasut

Dear Fabio Estevam,

Quoted 14 lines

On Mon, Jan 28, 2013 at 5:14 PM, Otavio Salvador

board/olimex/mx23_olinuxino/mx23_olinuxino.c int dram_init(void) · line 62

Quoted 7 lines · <[email protected]> wrote:
board/olimex/mx23_olinuxino/mx23_olinuxino.c +7 -0
+#ifdef CONFIG_CMD_NET
+int board_eth_init(bd_t *bis)
+{
+       /* Power-on Ethernet */
+       gpio_direction_output(MX23_PAD_GPMI_ALE__GPIO_0_17, 1);
+}
+#endif

This function expects to return an integer, and there is no return value here.

Quoted 4 lines
Quoted 2 lines

Also, maybe you could set the GPIO inside board_early_init_f() like we do on mx28.

How come it didn't emit an error?

It works; I tested it and sent the new patch version with it.

--
Otavio Salvador O.S. Systems
E-mail: otavio at ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br