perf/x86: nhm_events_attrs and snb_events_attrs can be static

PATCH In review Fengguang Wu 2 participants 3 messages Jan 28, 2013 – Jan 29, 2013 3 messages not in the archive

Subsystems (2)

Share & tools

A message that is not in the archive (sent off-list or not yet received): 510441ca.jKKGS3DOYyOC3gnk%[email protected]

A message that is not in the archive (sent off-list or not yet received): 20130127010632.GF12329@localhost

A message that is not in the archive (sent off-list or not yet received): CABPqkBR4VCOpBH25yQOnhkOs6c52xEnNe=P4qifDXzr7WBERxw@mail.gmail.com

Fengguang Wu

author

2013-01-28 23:46 UTC #3 lore raw

PATCH 1/1 perf/x86: nhm_events_attrs and snb_events_attrs can be static

Signed-off-by Fengguang Wu <[email protected]>

---
 arch/x86/kernel/cpu/perf_event_intel.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

arch/x86/kernel/cpu/perf_event_intel.c +2 -2

@@ -139,12 +139,12 @@ static struct extra_reg intel_snb_extra_
 EVENT_ATTR_STR(mem-loads, mem_ld_nhm, "event=0x0b,umask=0x10,ldlat=3");
 EVENT_ATTR_STR(mem-loads, mem_ld_snb, "event=0xcd,umask=0x1,ldlat=3");
 
-struct attribute *nhm_events_attrs[] = {
+static struct attribute *nhm_events_attrs[] = {
 	EVENT_PTR(mem_ld_nhm),
 	NULL,
 };
 
-struct attribute *snb_events_attrs[] = {
+static struct attribute *snb_events_attrs[] = {
 	EVENT_PTR(mem_ld_snb),
 	NULL,
 };

Stephane Eranian

Acked-by on v1 1/1

2013-01-29 00:31 UTC #4 lore raw

Quoted 1 line · Fengguang Wu

Signed-off-by Fengguang Wu <[email protected]>

Acked-by Stephane Eranian <[email protected]>

Quoted 21 lines

---
 arch/x86/kernel/cpu/perf_event_intel.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

arch/x86/kernel/cpu/perf_event_intel.c 2013-01-29 07:43:47.678597226 +0800 renamed from arch/x86/kernel/cpu/perf_event_intel.c 2013-01-29 07:42:16.238595053 +0800 +2 -2

@@ -139,12 +139,12 @@ static struct extra_reg intel_snb_extra_
 EVENT_ATTR_STR(mem-loads, mem_ld_nhm, "event=0x0b,umask=0x10,ldlat=3");
 EVENT_ATTR_STR(mem-loads, mem_ld_snb, "event=0xcd,umask=0x1,ldlat=3");
 
-struct attribute *nhm_events_attrs[] = {
+static struct attribute *nhm_events_attrs[] = {
        EVENT_PTR(mem_ld_nhm),
        NULL,
 };
 
-struct attribute *snb_events_attrs[] = {
+static struct attribute *snb_events_attrs[] = {
        EVENT_PTR(mem_ld_snb),
        NULL,
 };

tip-bot for Fengguang Wu

author

2013-01-29 09:42 UTC #5 lore raw

[tip:perf/x86] perf/x86: Mark nhm_events_attrsas static

In reply to Fengguang Wu

Commit-ID:  a4a607086d86d1315c4e2d9496bbe502e645bdd1
Gitweb:     http://git.kernel.org/tip/a4a607086d86d1315c4e2d9496bbe502e645bdd1
Author:     Fengguang Wu <[email protected]>
AuthorDate: Tue, 29 Jan 2013 07:46:20 +0800
Committer:  Ingo Molnar <[email protected]>
CommitDate: Tue, 29 Jan 2013 08:51:46 +0100

perf/x86: Mark nhm_events_attrsas static

Signed-off-by Fengguang Wu <[email protected]>

Acked-by Stephane Eranian <[email protected]>

Link http://lkml.kernel.org/r/20130128234620.GA8524@localhost open here

Signed-off-by Ingo Molnar <[email protected]>

---
 arch/x86/kernel/cpu/perf_event_intel.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

arch/x86/kernel/cpu/perf_event_intel.c +2 -2

index 9d0d036..bb910bd 100644
@@ -140,12 +140,12 @@ EVENT_ATTR_STR(mem-loads, mem_ld_nhm, "event=0x0b,umask=0x10,ldlat=3");
 EVENT_ATTR_STR(mem-loads, mem_ld_snb, "event=0xcd,umask=0x1,ldlat=3");
 EVENT_ATTR_STR(mem-stores, mem_st_snb, "event=0xcd,umask=0x2");
 
-struct attribute *nhm_events_attrs[] = {
+static struct attribute *nhm_events_attrs[] = {
 	EVENT_PTR(mem_ld_nhm),
 	NULL,
 };
 
-struct attribute *snb_events_attrs[] = {
+static struct attribute *snb_events_attrs[] = {
 	EVENT_PTR(mem_ld_snb),
 	EVENT_PTR(mem_st_snb),
 	NULL,