mxs: Rename CONFIG_SPL_MX28_PSWITCH_WAIT to CONFIG_SPL_MXS_PSWITCH_WAIT
Subsystems (2)
PATCH v3 1/3 mxs: Rename CONFIG_SPL_MX28_PSWITCH_WAIT to CONFIG_SPL_MXS_PSWITCH_WAIT
The power switch option is compatible with i.MX23 and i.MX28 so the configration option needs to reflect it. We choose 'CONFIG_SPL_MXS_PSWITCH_WAIT' for the option name.
---
Changes in v3: None
Changes in v2:
- Rewrite short description as per Marek's request
arch/arm/cpu/arm926ejs/mxs/mxs_init.h | 2 +- arch/arm/cpu/arm926ejs/mxs/spl_power_init.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/cpu/arm926ejs/mxs/mxs_init.h +1 -1
@@ -30,7 +30,7 @@ void early_delay(int delay);void mxs_power_init (void ); -#ifdef CONFIG_SPL_MX28_PSWITCH_WAIT +#ifdef CONFIG_SPL_MXS_PSWITCH_WAIT void mxs_power_wait_pswitch (void );#else static inline void mxs_power_wait_pswitch (void ) { }
arch/arm/cpu/arm926ejs/mxs/spl_power_init.c +1 -1
@@ -921,7 +921,7 @@ void mxs_power_init(void)early_delay (1000 ); } -#ifdef CONFIG_SPL_MX28_PSWITCH_WAIT +#ifdef CONFIG_SPL_MXS_PSWITCH_WAIT void mxs_power_wait_pswitch (void ) { struct mxs_power_regs *power_regs =
Signature · 1 line
1.8.1
PATCH v3 2/3 mx23: Document the tRAS lockout setting in memory initialization
Add a comment about the tRAS lockout setting of HW_DRAM_CTL08 to enable the 'Fast Auto Pre-Charge' found in the memory chip. The setting is applied after memory initialization and it is worth document it.
---
Changes in v3:
- Revert initialization change and comment the code
Changes in v2:
- Improve commit message
arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c | 1 + 1 file changed, 1 insertion(+)
arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c +1 -0
@@ -119,6 +119,7 @@ static void initialize_dram_values(void)writel (dram_vals[i],MXS_DRAM_BASE + (4 * i));#ifdef CONFIG_MX23 +/* Enable tRAS lockout in HW_DRAM_CTL08 */ writel ((1 <<24 ),MXS_DRAM_BASE + (4 *8 ));#endif }
Signature · 1 line
1.8.1
PATCH v3 3/3 mx23evk: Adjust DRAM control register to use full 128MB of RAM
In reply to Otavio Salvador---
Changes in v3: None
Changes in v2: None
board/freescale/mx23evk/spl_boot.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
board/freescale/mx23evk/spl_boot.c +10 -0
@@ -98,6 +98,16 @@ const iomux_cfg_t iomux_setup[] = { (MXS_PAD_4MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), }; +#define HW_DRAM_CTL14 (0x38 >> 2) +#define CS_MAP 0x3 +#define INTAREF 0x2 +#define HW_DRAM_CTL14_CONFIG (INTAREF << 8 | CS_MAP) + +void mxs_adjust_memory_params (uint32_t *dram_vals) +{ + dram_vals[HW_DRAM_CTL14 ] =HW_DRAM_CTL14_CONFIG ; +} +void board_init_ll (void ) {mxs_common_spl_init (iomux_setup,ARRAY_SIZE (iomux_setup));
Signature · 1 line
1.8.1
PATCH v3 1/3 mxs: Rename CONFIG_SPL_MX28_PSWITCH_WAIT to CONFIG_SPL_MXS_PSWITCH_WAIT
In reply to Otavio SalvadorDear Otavio Salvador,
Quoted 5 lines
The power switch option is compatible with i.MX23 and i.MX28 so the configration option needs to reflect it. We choose '
CONFIG_SPL_MXS_PSWITCH_WAIT' for the option name.Signed-off-by Otavio Salvador <[email protected]>
Please read [1] too, I'm completely lost in the flurry of patches. I just can't figure out anymore what's going on. I don't know what patches to review, in what order and what patches are obsolete and what are not.
Moreover, it's generally better to use "Cc:" in the patches. Also, if you want my threading to work well so I want be lost, Cc me on the whole series.
http://www.denx.de/wiki/U-Boot/Patches#General_Patch_Submission_Rules
Quoted 28 lines
---
Changes in v3: None
Changes in v2:
- Rewrite short description as per Marek's requestarch/arm/cpu/arm926ejs/mxs/mxs_init.h | 2 +- arch/arm/cpu/arm926ejs/mxs/spl_power_init.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)(quoted diff) +0
-0
b/arch/arm/cpu/arm926ejs/mxs/mxs_init.hindex 2ddc5bc..084def5 100644arch/arm/cpu/arm926ejs/mxs/mxs_init.h +1
-1@@ -30,7 +30,7 @@ void early_delay(int delay);void mxs_power_init (void ); -#ifdef CONFIG_SPL_MX28_PSWITCH_WAIT +#ifdef CONFIG_SPL_MXS_PSWITCH_WAIT void mxs_power_wait_pswitch (void );#else static inline void mxs_power_wait_pswitch (void ) { }(quoted diff) +0
-0
b/arch/arm/cpu/arm926ejs/mxs/spl_power_init.cindex e9d6302..287c698 100644
arch/arm/cpu/arm926ejs/mxs/spl_power_init.c void mxs_power_init(void) · line 927
Quoted 8 lines
arch/arm/cpu/arm926ejs/mxs/spl_power_init.c +1
-1@@ -921,7 +921,7 @@ void mxs_power_init(void)early_delay (1000 ); } -#ifdef CONFIG_SPL_MX28_PSWITCH_WAIT +#ifdef CONFIG_SPL_MXS_PSWITCH_WAIT void mxs_power_wait_pswitch (void ) { struct mxs_power_regs *power_regs =
Best regards,
Marek Vasut