mmc:sdhci:fix: Change default interrupts enabled at SDHCI initialization

PATCH New Lukasz Majewski 4 participants 13 messages Jan 11, 2013 – Mar 12, 2013 MMC, SD and SDIO

Share & tools

Lukasz Majewski

author

2013-01-11 15:08 UTC #0 lore raw

PATCH 1/1 mmc:sdhci:fix: Change default interrupts enabled at SDHCI initialization

This patch changes sdhci_init()'s behavior to NOT enable all interrupt sources by default. Moreover interrupt signaling has been disabled.

This patch do not enable interrupts which aren't served in u-boot (they are defined at sdhci.h but NOT used elsewhere):
- SDHCI_INT_CARD_INSERT, SDHCI_INT_CARD_REMOVE, SDHCI_BUS_POWER, SDHCI_INT_CARD_REMOVE, SDHCI_INT_CARD_INT

Special care shall be put on SDHCI_INT_CARD_INT, which indicates interrupt generated by SD card.
According to "SD Host Controller Simplified Spec. ver 3.00" when bit 8 (Card Interrupt Status Enable) at "Normal Interrupt Status Enable Register" (offset 0x34) is set, the card interrupt detection is started. Then eMMC card may cause the SD controller to set this bit and then this interrupt is passed to booted OS and might cause kernel crash.

To sum up:
- Only enable interrupts, which are served at u-boot
- This cleanup as a side effect fixes SDHCI's CARD INTERRUPT problem at Linux kernel (versions 3.6+, sdhci controller)
- Keep masked bits at "Normal Interrupt Signal Enable Register" (0x38h)

Signed-off-by Lukasz Majewski <[email protected]>

Signed-off-by Kyungmin Park <[email protected]>

Cc Lei Wen <[email protected]>

Cc Andy Fleming <[email protected]>

---
 drivers/mmc/sdhci.c |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

drivers/mmc/sdhci.c +5 -3

index 0fd1337..76c14fb 100644
@@ -412,9 +412,11 @@ int sdhci_init(struct mmc *mmc)
 			status = sdhci_readl(host, SDHCI_PRESENT_STATE);
 	}
 
-	/* Eable all state */
-	sdhci_writel(host, SDHCI_INT_ALL_MASK, SDHCI_INT_ENABLE);
-	sdhci_writel(host, SDHCI_INT_ALL_MASK, SDHCI_SIGNAL_ENABLE);
+	/* Enable only interrupts served by the SD controller */
+	sdhci_writel(host, SDHCI_INT_DATA_MASK | SDHCI_INT_CMD_MASK
+		     , SDHCI_INT_ENABLE);
+	/* Mask all sdhci interrupt sources */
+	sdhci_writel(host, 0x0, SDHCI_SIGNAL_ENABLE);
 
 	return 0;
 }

Signature · 1 line

1.7.2.3

Lukasz Majewski

author

2013-01-29 14:47 UTC #1 lore raw

PATCH 1/1 mmc:sdhci:fix: Change default interrupts enabled at SDHCI initialization

Dear All,

Any feedback about this patch?

Quoted 52 lines

This patch changes sdhci_init()'s behavior to NOT enable all interrupt sources by default. Moreover interrupt signaling has been disabled.
This patch do not enable interrupts which aren't served in u-boot (they are defined at sdhci.h but NOT used elsewhere):
- SDHCI_INT_CARD_INSERT, SDHCI_INT_CARD_REMOVE, SDHCI_BUS_POWER, SDHCI_INT_CARD_REMOVE, SDHCI_INT_CARD_INT
Special care shall be put on SDHCI_INT_CARD_INT, which indicates interrupt generated by SD card.
According to "SD Host Controller Simplified Spec. ver 3.00" when bit 8 (Card Interrupt Status Enable) at "Normal Interrupt Status Enable Register" (offset 0x34) is set, the card interrupt detection is started. Then eMMC card may cause the SD controller to set this bit and then this interrupt is passed to booted OS and might cause kernel crash.
To sum up:
- Only enable interrupts, which are served at u-boot
- This cleanup as a side effect fixes SDHCI's CARD INTERRUPT problem at Linux kernel (versions 3.6+, sdhci controller)
- Keep masked bits at "Normal Interrupt Signal Enable Register" (0x38h)
Signed-off-by Lukasz Majewski <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
Cc Lei Wen <[email protected]>
Cc Andy Fleming <[email protected]>
---
 drivers/mmc/sdhci.c |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)
drivers/mmc/sdhci.c +5 -3
index 0fd1337..76c14fb 100644
@@ -412,9 +412,11 @@ int sdhci_init(struct mmc *mmc)
 			status = sdhci_readl(host,
 SDHCI_PRESENT_STATE); }
 
-	/* Eable all state */
-	sdhci_writel(host, SDHCI_INT_ALL_MASK, SDHCI_INT_ENABLE);
-	sdhci_writel(host, SDHCI_INT_ALL_MASK, SDHCI_SIGNAL_ENABLE);
+	/* Enable only interrupts served by the SD controller */
+	sdhci_writel(host, SDHCI_INT_DATA_MASK | SDHCI_INT_CMD_MASK
+		     , SDHCI_INT_ENABLE);
+	/* Mask all sdhci interrupt sources */
+	sdhci_writel(host, 0x0, SDHCI_SIGNAL_ENABLE);
 
 	return 0;
 }

Signature · 5 lines

Best regards,

Lukasz Majewski

Samsung R&D Poland (SRPOL) | Linux Platform Group

Jaehoon Chung

2013-01-30 04:52 UTC #2 lore raw

PATCH 1/1 mmc:sdhci:fix: Change default interrupts enabled at SDHCI initialization

It looks good to me.

Acked-by Jaehoon Chung <[email protected]>

Quoted 59 lines · Lukasz Majewski

Dear All,
Any feedback about this patch?
Quoted 52 lines
This patch changes sdhci_init()'s behavior to NOT enable all interrupt sources by default. Moreover interrupt signaling has been disabled.
This patch do not enable interrupts which aren't served in u-boot (they are defined at sdhci.h but NOT used elsewhere):
- SDHCI_INT_CARD_INSERT, SDHCI_INT_CARD_REMOVE, SDHCI_BUS_POWER, SDHCI_INT_CARD_REMOVE, SDHCI_INT_CARD_INT
Special care shall be put on SDHCI_INT_CARD_INT, which indicates interrupt generated by SD card.
According to "SD Host Controller Simplified Spec. ver 3.00" when bit 8 (Card Interrupt Status Enable) at "Normal Interrupt Status Enable Register" (offset 0x34) is set, the card interrupt detection is started. Then eMMC card may cause the SD controller to set this bit and then this interrupt is passed to booted OS and might cause kernel crash.
To sum up:
- Only enable interrupts, which are served at u-boot
- This cleanup as a side effect fixes SDHCI's CARD INTERRUPT problem at Linux kernel (versions 3.6+, sdhci controller)
- Keep masked bits at "Normal Interrupt Signal Enable Register" (0x38h)
Signed-off-by Lukasz Majewski <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
Cc Lei Wen <[email protected]>
Cc Andy Fleming <[email protected]>
---
 drivers/mmc/sdhci.c |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)
drivers/mmc/sdhci.c +5 -3
index 0fd1337..76c14fb 100644
@@ -412,9 +412,11 @@ int sdhci_init(struct mmc *mmc)
 			status = sdhci_readl(host,
 SDHCI_PRESENT_STATE); }
 
-	/* Eable all state */
-	sdhci_writel(host, SDHCI_INT_ALL_MASK, SDHCI_INT_ENABLE);
-	sdhci_writel(host, SDHCI_INT_ALL_MASK, SDHCI_SIGNAL_ENABLE);
+	/* Enable only interrupts served by the SD controller */
+	sdhci_writel(host, SDHCI_INT_DATA_MASK | SDHCI_INT_CMD_MASK
+		     , SDHCI_INT_ENABLE);
+	/* Mask all sdhci interrupt sources */
+	sdhci_writel(host, 0x0, SDHCI_SIGNAL_ENABLE);
 
 	return 0;
 }

Lukasz Majewski

author

2013-02-11 08:50 UTC #3 lore raw

PATCH 1/1 mmc:sdhci:fix: Change default interrupts enabled at SDHCI initialization

In reply to Lukasz Majewski

Dear All,

Any feedback about this patch?

It has been on the list for quite long time.....

Quoted 61 lines

Dear All,
Any feedback about this patch?
Quoted 54 lines
This patch changes sdhci_init()'s behavior to NOT enable all interrupt sources by default. Moreover interrupt signaling has been disabled.
This patch do not enable interrupts which aren't served in u-boot (they are defined at sdhci.h but NOT used elsewhere):
- SDHCI_INT_CARD_INSERT, SDHCI_INT_CARD_REMOVE, SDHCI_BUS_POWER, SDHCI_INT_CARD_REMOVE, SDHCI_INT_CARD_INT
Special care shall be put on SDHCI_INT_CARD_INT, which indicates interrupt generated by SD card.
According to "SD Host Controller Simplified Spec. ver 3.00" when bit 8 (Card Interrupt Status Enable) at "Normal Interrupt Status Enable Register" (offset 0x34) is set, the card interrupt detection is started. Then eMMC card may cause the SD controller to set this bit and then this interrupt is passed to booted OS and might cause kernel crash.
To sum up:
- Only enable interrupts, which are served at u-boot
- This cleanup as a side effect fixes SDHCI's CARD INTERRUPT problem at Linux kernel (versions 3.6+, sdhci controller)
- Keep masked bits at "Normal Interrupt Signal Enable Register" (0x38h)
Signed-off-by Lukasz Majewski <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
Cc Lei Wen <[email protected]>
Cc Andy Fleming <[email protected]>
---
 drivers/mmc/sdhci.c |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)
drivers/mmc/sdhci.c +5 -3
index 0fd1337..76c14fb 100644
@@ -412,9 +412,11 @@ int sdhci_init(struct mmc *mmc)
 			status = sdhci_readl(host,
 SDHCI_PRESENT_STATE); }
 
-	/* Eable all state */
-	sdhci_writel(host, SDHCI_INT_ALL_MASK, SDHCI_INT_ENABLE);
-	sdhci_writel(host, SDHCI_INT_ALL_MASK,
 SDHCI_SIGNAL_ENABLE);
+	/* Enable only interrupts served by the SD controller */
+	sdhci_writel(host, SDHCI_INT_DATA_MASK | SDHCI_INT_CMD_MASK
+		     , SDHCI_INT_ENABLE);
+	/* Mask all sdhci interrupt sources */
+	sdhci_writel(host, 0x0, SDHCI_SIGNAL_ENABLE);
 
 	return 0;
}

Signature · 5 lines

Best regards,

Lukasz Majewski

Samsung R&D Poland (SRPOL) | Linux Platform Group

Tom Rini

2013-02-11 13:58 UTC #4 lore raw

PATCH 1/1 mmc:sdhci:fix: Change default interrupts enabled at SDHCI initialization

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 5 lines · Lukasz Majewski

Dear All,
Any feedback about this patch?
It has been on the list for quite long time.....

This is one of the patches that I really want Andy to chime in on.

- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJRGPj/AAoJENk4IS6UOR1WTmsP/3Qa4YAmLosshxWbjZNxqc3F a9MfL8XLzPF9qs1qp1p4VmeviVEHTmEXLgZP61+gdvxhayRKAPV5xuEd4LstWO5d rKHVvN1pwm+rQPNWfuIkptySXsGfe+JBZUoiQ934psRxDy+2Ji6DExG+Vl3ThfCD bmWd5kfktHCMNwgYFCuU7v8RbR/dbUIiSGtIw0t6LKI8b+csE9QCF8LVjhSDFKb5 dpFvxKjjDu1NWXMz0mrGvccLb7q8WNrZOGjhV3RSaTWB7UCUI2aJ9i+Fz3e7w4lZ OA+cI/IwgqJA8R3+iikITw3qseLVEz35WqyYhdrdW9HZV1h3Eqn/UO8Z+/9YsCh0 dhlDtDd7lFBvgB35WzFtLE13RpiHbowWvux06qfohXfzC2M42O+EvYeqvKnkKKtD bzZWLhUhe+e7JA5JJudyOtz/4Lk3j9Xt1hjZamFyiIlqtoOWHQihyhp0w7BfasUt 3HZrbud+KIM/Odv045Mvhi//V8Fsu/RziNGw9OAbO4nsNkCXh/qU9zQ1qUjbFzQx DC/RpSMxEpFc7pAfiTpSwUTSpNNkFDbBKaIA7jOXdC8xpW2UmvSjARlpGWKOKj1z 3OMoR/CYpFaG0gvlkl16RsebmZf7mEKECLdOO4SUrw5W8PwFeRwDhoZx1Qqvg5sh ZgFdVkDk2nu85cUcsmJq
=xiNx
-----END PGP SIGNATURE-----

Lukasz Majewski

author

2013-02-21 17:21 UTC #5 lore raw

PATCH 1/1 mmc:sdhci:fix: Change default interrupts enabled at SDHCI initialization

In reply to Lukasz Majewski

Dear All,

I'd like to kindly ask for any feedback on this patch.

It is now more than month on the u-boot mailing list...

Quoted 72 lines

Dear All,
Any feedback about this patch?
It has been on the list for quite long time.....
Quoted 62 lines
Dear All,
Any feedback about this patch?
Quoted 55 lines
This patch changes sdhci_init()'s behavior to NOT enable all interrupt sources by default. Moreover interrupt signaling has been disabled.
This patch do not enable interrupts which aren't served in u-boot (they are defined at sdhci.h but NOT used elsewhere):
- SDHCI_INT_CARD_INSERT, SDHCI_INT_CARD_REMOVE, SDHCI_BUS_POWER, SDHCI_INT_CARD_REMOVE, SDHCI_INT_CARD_INT
Special care shall be put on SDHCI_INT_CARD_INT, which indicates interrupt generated by SD card.
According to "SD Host Controller Simplified Spec. ver 3.00" when bit 8 (Card Interrupt Status Enable) at "Normal Interrupt Status Enable Register" (offset 0x34) is set, the card interrupt detection is started. Then eMMC card may cause the SD controller to set this bit and then this interrupt is passed to booted OS and might cause kernel crash.
To sum up:
- Only enable interrupts, which are served at u-boot
- This cleanup as a side effect fixes SDHCI's CARD INTERRUPT problem at Linux kernel (versions 3.6+, sdhci controller)
- Keep masked bits at "Normal Interrupt Signal Enable Register" (0x38h)
Signed-off-by Lukasz Majewski <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
Cc Lei Wen <[email protected]>
Cc Andy Fleming <[email protected]>
---
 drivers/mmc/sdhci.c |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)
drivers/mmc/sdhci.c +2 -3
index 0fd1337..76c14fb 100644
@@ -412,9 +412,11 @@ int sdhci_init(struct mmc *mmc)
 			status = sdhci_readl(host,
 SDHCI_PRESENT_STATE); }
 
-	/* Eable all state */
-	sdhci_writel(host, SDHCI_INT_ALL_MASK, SDHCI_INT_ENABLE);
-	sdhci_writel(host, SDHCI_INT_ALL_MASK,
 SDHCI_SIGNAL_ENABLE);
+	/* Enable only interrupts served by the SD controller */
+	sdhci_writel(host, SDHCI_INT_DATA_MASK |
SDHCI_INT_CMD_MASK
drivers/mmc/sdhci.c +3 -0
+		     , SDHCI_INT_ENABLE);
+	/* Mask all sdhci interrupt sources */
+	sdhci_writel(host, 0x0, SDHCI_SIGNAL_ENABLE);
 
 	return 0;
 }

Signature · 5 lines

Best regards,

Lukasz Majewski

Samsung R&D Poland (SRPOL) | Linux Platform Group

Tom Rini

2013-02-21 17:45 UTC #6 lore raw

PATCH 1/1 mmc:sdhci:fix: Change default interrupts enabled at SDHCI initialization

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 5 lines · Lukasz Majewski

Dear All,
I'd like to kindly ask for any feedback on this patch.
It is now more than month on the u-boot mailing list...

OK, sorry, the generic name of the driver threw me for a minute. I'm fine with this change going up u-boot-samsung -> u-boot-arm -> master since it's a samsung-only driver right now. Does this work for you?

Quoted 58 lines

Quoted 58 lines
Dear All,
Any feedback about this patch?
It has been on the list for quite long time.....
Quoted 49 lines
Dear All,
Any feedback about this patch?
Quoted 45 lines
This patch changes sdhci_init()'s behavior to NOT enable all interrupt sources by default. Moreover interrupt signaling has been disabled.
This patch do not enable interrupts which aren't served in u-boot (they are defined at sdhci.h but NOT used elsewhere):
- SDHCI_INT_CARD_INSERT, SDHCI_INT_CARD_REMOVE, SDHCI_BUS_POWER, SDHCI_INT_CARD_REMOVE, SDHCI_INT_CARD_INT
Special care shall be put on SDHCI_INT_CARD_INT, which indicates interrupt generated by SD card. According to "SD Host Controller Simplified Spec. ver 3.00" when bit 8 (Card Interrupt Status Enable) at "Normal Interrupt Status Enable Register" (offset 0x34) is set, the card interrupt detection is started. Then eMMC card may cause the SD controller to set this bit and then this interrupt is passed to booted OS and might cause kernel crash.
To sum up: - Only enable interrupts, which are served at u-boot - This cleanup as a side effect fixes SDHCI's CARD INTERRUPT problem at Linux kernel (versions 3.6+, sdhci controller) - Keep masked bits at "Normal Interrupt Signal Enable Register" (0x38h)
Signed-off-by Lukasz Majewski <[email protected]>
Signed-off-by Kyungmin Park <[email protected]> Cc:
Lei Wen <[email protected]> Cc: Andy Fleming
<[email protected]> --- drivers/mmc/sdhci.c | 8
+++++--- 1 files changed, 5 insertions(+), 3 deletions(-)
drivers/mmc/sdhci.c index renamed from drivers/mmc/sdhci.c +0 -0
0fd1337..76c14fb 100644 --- a/drivers/mmc/sdhci.c +++ b/drivers/mmc/sdhci.c @@ -412,9 +412,11 @@ int sdhci_init(struct mmc *mmc) status = sdhci_readl(host, SDHCI_PRESENT_STATE); }
drivers/mmc/sdhci.c index renamed from drivers/mmc/sdhci.c +0 -1
-	/* Eable all state */ -	sdhci_writel(host,
SDHCI_INT_ALL_MASK, SDHCI_INT_ENABLE); - sdhci_writel(host,
SDHCI_INT_ALL_MASK, SDHCI_SIGNAL_ENABLE); + /* Enable only
interrupts served by the SD controller */ + sdhci_writel(host, SDHCI_INT_DATA_MASK | SDHCI_INT_CMD_MASK +
, SDHCI_INT_ENABLE); + /* Mask all sdhci interrupt sources
*/ + sdhci_writel(host, 0x0, SDHCI_SIGNAL_ENABLE);

Quoted 8 lines

Quoted 7 lines
Quoted 4 lines
Quoted 1 line
return 0; }

- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJRJl0zAAoJENk4IS6UOR1WU68P/RTyQMDciU5rlgA0NfcSt2/y T55Q+R43eaRABLqEdLu5rQXJgKcLIQZEr4Czfu3LqWDfUylJiXkUc+ngSQ/uJR9p v1IN+rrIOs3ZQcFy9d3oDROtkz16Mc0T+32WI8g/NfL7X9IKYqSEeBUGmc0O54Ro kdmH9fqzCX3wbaY//+vG1uMA3s61Ekx+3Gbf5BcyoVMHrf1fNz4L1kZ7ZB/MBzdp HOQIoButM7/BGteF5o5LPHCNw7LtnAz5basRwaGQmrGVzeA2GCKFOrYEx3oa/ghC mK/PNTW6RCzRFBckbA2No9C1Tj1i7EMy8K/B8sub9FmJWF9XfDf4YhbacXOse5RA +mSwZiWuJP7K/0YaDUh7itQE2Wec2iA2LNlgb0Ujwnm4DsxnP805Cbz/JJuT9mCu 8LYw7crg4DwU9X0g0MEojKXupQ2mHMBHHrYRuUdIaYxHkkkf7j4mSIzPR75FzAjF 8l54TL4bEKHyUd7HmTaEkafyhziC8Kit4SEQqjTJW9S720nVOaM/pMmrji3mxUXH wHUpTTVS0TIAzhdAtxxpPxbRsMnnEgobOFGDbF8wzjGMQWWudZGLXqCm0kv+5B2K 3o6IlxPQ/TlokPe+A63NHTbJTJ0z/ylLX0UyNifzPzsoTiskO4qqSdHdrGTcA3f+ Tqq0rAM0CXj2oMMkkOFb
=nGWo
-----END PGP SIGNATURE-----

Jaehoon Chung

2013-02-21 23:33 UTC #7 lore raw

PATCH 1/1 mmc:sdhci:fix: Change default interrupts enabled at SDHCI initialization

Hi Tom,

Quoted 6 lines · Tom Rini

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 2 lines · Lukasz Majewski
Dear All,

Quoted 7 lines

Quoted 3 lines
I'd like to kindly ask for any feedback on this patch.
It is now more than month on the u-boot mailing list...
OK, sorry, the generic name of the driver threw me for a minute. I'm fine with this change going up u-boot-samsung -> u-boot-arm -> master since it's a samsung-only driver right now. Does this work for you?

I think that this driver didn't use samsung-only.
going up u-boot-samsung? I'm not sure that.

Best Regards,
Jaehoon Chung

Quoted 94 lines

Quoted 59 lines
Quoted 59 lines
Dear All,
Any feedback about this patch?
It has been on the list for quite long time.....
Quoted 49 lines
Dear All,
Any feedback about this patch?
Quoted 45 lines
This patch changes sdhci_init()'s behavior to NOT enable all interrupt sources by default. Moreover interrupt signaling has been disabled.
This patch do not enable interrupts which aren't served in u-boot (they are defined at sdhci.h but NOT used elsewhere):
- SDHCI_INT_CARD_INSERT, SDHCI_INT_CARD_REMOVE, SDHCI_BUS_POWER, SDHCI_INT_CARD_REMOVE, SDHCI_INT_CARD_INT
Special care shall be put on SDHCI_INT_CARD_INT, which indicates interrupt generated by SD card. According to "SD Host Controller Simplified Spec. ver 3.00" when bit 8 (Card Interrupt Status Enable) at "Normal Interrupt Status Enable Register" (offset 0x34) is set, the card interrupt detection is started. Then eMMC card may cause the SD controller to set this bit and then this interrupt is passed to booted OS and might cause kernel crash.
To sum up: - Only enable interrupts, which are served at u-boot - This cleanup as a side effect fixes SDHCI's CARD INTERRUPT problem at Linux kernel (versions 3.6+, sdhci controller) - Keep masked bits at "Normal Interrupt Signal Enable Register" (0x38h)
Signed-off-by Lukasz Majewski <[email protected]>
Signed-off-by Kyungmin Park <[email protected]> Cc:
Lei Wen <[email protected]> Cc: Andy Fleming
<[email protected]> --- drivers/mmc/sdhci.c | 8
+++++--- 1 files changed, 5 insertions(+), 3 deletions(-)
drivers/mmc/sdhci.c index renamed from drivers/mmc/sdhci.c +0 -0
0fd1337..76c14fb 100644 --- a/drivers/mmc/sdhci.c +++ b/drivers/mmc/sdhci.c @@ -412,9 +412,11 @@ int sdhci_init(struct mmc *mmc) status = sdhci_readl(host, SDHCI_PRESENT_STATE); }
drivers/mmc/sdhci.c index renamed from drivers/mmc/sdhci.c +0 -1
-	/* Eable all state */ -	sdhci_writel(host,
SDHCI_INT_ALL_MASK, SDHCI_INT_ENABLE); - sdhci_writel(host,
SDHCI_INT_ALL_MASK, SDHCI_SIGNAL_ENABLE); + /* Enable only
interrupts served by the SD controller */ + sdhci_writel(host, SDHCI_INT_DATA_MASK | SDHCI_INT_CMD_MASK +
, SDHCI_INT_ENABLE); + /* Mask all sdhci interrupt sources
*/ + sdhci_writel(host, 0x0, SDHCI_SIGNAL_ENABLE);
Quoted 8 lines
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
return 0; }
- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJRJl0zAAoJENk4IS6UOR1WU68P/RTyQMDciU5rlgA0NfcSt2/y T55Q+R43eaRABLqEdLu5rQXJgKcLIQZEr4Czfu3LqWDfUylJiXkUc+ngSQ/uJR9p v1IN+rrIOs3ZQcFy9d3oDROtkz16Mc0T+32WI8g/NfL7X9IKYqSEeBUGmc0O54Ro kdmH9fqzCX3wbaY//+vG1uMA3s61Ekx+3Gbf5BcyoVMHrf1fNz4L1kZ7ZB/MBzdp HOQIoButM7/BGteF5o5LPHCNw7LtnAz5basRwaGQmrGVzeA2GCKFOrYEx3oa/ghC mK/PNTW6RCzRFBckbA2No9C1Tj1i7EMy8K/B8sub9FmJWF9XfDf4YhbacXOse5RA +mSwZiWuJP7K/0YaDUh7itQE2Wec2iA2LNlgb0Ujwnm4DsxnP805Cbz/JJuT9mCu 8LYw7crg4DwU9X0g0MEojKXupQ2mHMBHHrYRuUdIaYxHkkkf7j4mSIzPR75FzAjF 8l54TL4bEKHyUd7HmTaEkafyhziC8Kit4SEQqjTJW9S720nVOaM/pMmrji3mxUXH wHUpTTVS0TIAzhdAtxxpPxbRsMnnEgobOFGDbF8wzjGMQWWudZGLXqCm0kv+5B2K 3o6IlxPQ/TlokPe+A63NHTbJTJ0z/ylLX0UyNifzPzsoTiskO4qqSdHdrGTcA3f+ Tqq0rAM0CXj2oMMkkOFb
=nGWo
-----END PGP SIGNATURE-----
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Tom Rini

2013-02-21 23:43 UTC #8 lore raw

PATCH 1/1 mmc:sdhci:fix: Change default interrupts enabled at SDHCI initialization

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 6 lines · Jaehoon Chung

Hi Tom,
Quoted 2 lines · Lukasz Majewski
Quoted 2 lines
Quoted 2 lines
Dear All,

Quoted 10 lines

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
I'd like to kindly ask for any feedback on this patch.
It is now more than month on the u-boot mailing list...
OK, sorry, the generic name of the driver threw me for a minute. I'm fine with this change going up u-boot-samsung -> u-boot-arm -> master since it's a samsung-only driver right now. Does this work for you?
Quoted 2 lines
I think that this driver didn't use samsung-only. going up u-boot-samsung? I'm not sure that.

Unless the context got very wrong, it touches drivers/mmc/sdhci.c which is controlled by CONFIG_SDHCI which is only turned on in what look like samsung platforms to me.

- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJRJrESAAoJENk4IS6UOR1WKeYP/2FBhDgWjyf5Sh8m0Q1bdhRm EvNMWLuexHUbxOu0AMsKyurPAGHnkfsWtNBnQXe804XXY29chFTsLlJUh4EGUBHm KiSJPU9LAlDt/aMmv6ncFcgJ9I7jyu8bETBLbJszDSleO0DqpUBu+R7isVv0N7n3 Uozo89zHpCvGrN2VLlQetMrTTJKquThn4CT9SIm02Z2OM5l3vBLUg+QMk1MCjDUd znIsFtUG5F+8T0uqzFN698RYACagPl5Y10HMylWHZgpgV2wGxQWrXspx78wHRSvy cwDPd2SVQbO3o3s9ixlppxeO2kpva8NouzsCJn4nH5ivrHumFCm8SI2ka4YE6du5 2b6Hol1Ie9jxq8B6cCNdEsHeHru3r+r19GzTNE0VfbrArpM8jO7FHcLruyzRjlaC QyzDgdLXzV21113U+UlyAk5yWZ4he4xVHV4oFoN+QhIbQdNZP3gWkzLUQLLr9ry6 iIgeLx8GDONVxv7hGfNvAaxhQMgvANUOEtPP0CV+K0b60IDXyrFyP1xt5NRN77iR v1rfcqitudFUyF6zqbDDLC2a5EW45UVyQR0WdZK999TWHS/U+5pTcDHhls1F16VD wGZ+k+RmJQVWVdLImOsyWewPeZtzt02qlNom9LF8sKq8T4Uyf8uLhKksOyfxMCR7 AvZ53JHQoAAvhgPVn4KF
=7Oz4
-----END PGP SIGNATURE-----

Lukasz Majewski

author

2013-02-22 07:11 UTC #9 lore raw

PATCH 1/1 mmc:sdhci:fix: Change default interrupts enabled at SDHCI initialization

Hi Tom,

Quoted 18 lines

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 14 lines · Jaehoon Chung
Hi Tom,
Quoted 5 lines · Lukasz Majewski
Quoted 5 lines
Quoted 5 lines
Dear All,
I'd like to kindly ask for any feedback on this patch.
It is now more than month on the u-boot mailing list...
OK, sorry, the generic name of the driver threw me for a minute. I'm fine with this change going up u-boot-samsung -> u-boot-arm -> master since it's a samsung-only driver right now. Does this work for you?

Quoted 7 lines

Quoted 2 lines
Quoted 2 lines
I think that this driver didn't use samsung-only. going up u-boot-samsung? I'm not sure that.
Unless the context got very wrong, it touches drivers/mmc/sdhci.c which is controlled by CONFIG_SDHCI which is only turned on in what look like samsung platforms to me.

There is a /asm/arch-pantheon/config.h file which sets the CONFIG_SDHCI flag. It was added by Lei Wen (who is CC'ed to this thread) and looks like ARM926EJS (Marwell Semiconductor) processor based system.

Other systems are indeed samsung based processors.

I don't mind if this patch would go via u-boot-samsung tree.

Moreover, since this change "touches" Lei system, I think that he should have expressed his opinion. Sadly this didn't happened....

Quoted 21 lines

- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJRJrESAAoJENk4IS6UOR1WKeYP/2FBhDgWjyf5Sh8m0Q1bdhRm EvNMWLuexHUbxOu0AMsKyurPAGHnkfsWtNBnQXe804XXY29chFTsLlJUh4EGUBHm KiSJPU9LAlDt/aMmv6ncFcgJ9I7jyu8bETBLbJszDSleO0DqpUBu+R7isVv0N7n3 Uozo89zHpCvGrN2VLlQetMrTTJKquThn4CT9SIm02Z2OM5l3vBLUg+QMk1MCjDUd znIsFtUG5F+8T0uqzFN698RYACagPl5Y10HMylWHZgpgV2wGxQWrXspx78wHRSvy cwDPd2SVQbO3o3s9ixlppxeO2kpva8NouzsCJn4nH5ivrHumFCm8SI2ka4YE6du5 2b6Hol1Ie9jxq8B6cCNdEsHeHru3r+r19GzTNE0VfbrArpM8jO7FHcLruyzRjlaC QyzDgdLXzV21113U+UlyAk5yWZ4he4xVHV4oFoN+QhIbQdNZP3gWkzLUQLLr9ry6 iIgeLx8GDONVxv7hGfNvAaxhQMgvANUOEtPP0CV+K0b60IDXyrFyP1xt5NRN77iR v1rfcqitudFUyF6zqbDDLC2a5EW45UVyQR0WdZK999TWHS/U+5pTcDHhls1F16VD wGZ+k+RmJQVWVdLImOsyWewPeZtzt02qlNom9LF8sKq8T4Uyf8uLhKksOyfxMCR7 AvZ53JHQoAAvhgPVn4KF
=7Oz4
-----END PGP SIGNATURE-----

Signature · 5 lines

Best regards,

Lukasz Majewski

Samsung R&D Poland (SRPOL) | Linux Platform Group

Jaehoon Chung

2013-02-22 07:41 UTC #10 lore raw

PATCH 1/1 mmc:sdhci:fix: Change default interrupts enabled at SDHCI initialization

Hi All,

Quoted 28 lines · Lukasz Majewski

Hi Tom,
Quoted 18 lines
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 14 lines · Jaehoon Chung
Hi Tom,
Quoted 5 lines · Lukasz Majewski
Quoted 5 lines
Quoted 5 lines
Dear All,
I'd like to kindly ask for any feedback on this patch.
It is now more than month on the u-boot mailing list...
OK, sorry, the generic name of the driver threw me for a minute. I'm fine with this change going up u-boot-samsung -> u-boot-arm -> master since it's a samsung-only driver right now. Does this work for you?
Quoted 7 lines
Quoted 2 lines
Quoted 2 lines
I think that this driver didn't use samsung-only. going up u-boot-samsung? I'm not sure that.
Unless the context got very wrong, it touches drivers/mmc/sdhci.c which is controlled by CONFIG_SDHCI which is only turned on in what look like samsung platforms to me.

Quoted 7 lines

There is a /asm/arch-pantheon/config.h file which sets the CONFIG_SDHCI flag. It was added by Lei Wen (who is CC'ed to this thread) and looks like ARM926EJS (Marwell Semiconductor) processor based system.
Other systems are indeed samsung based processors.
I don't mind if this patch would go via u-boot-samsung tree.

I don't mind, too. I think this patch would not affect the other SoC. But I think that need to accept or review by somebody.
I was already posted "acked-by" for this patch.

Best Regards,
Jaehoon Chung

Quoted 28 lines

Moreover, since this change "touches" Lei system, I think that he should have expressed his opinion. Sadly this didn't happened....
Quoted 21 lines
- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJRJrESAAoJENk4IS6UOR1WKeYP/2FBhDgWjyf5Sh8m0Q1bdhRm EvNMWLuexHUbxOu0AMsKyurPAGHnkfsWtNBnQXe804XXY29chFTsLlJUh4EGUBHm KiSJPU9LAlDt/aMmv6ncFcgJ9I7jyu8bETBLbJszDSleO0DqpUBu+R7isVv0N7n3 Uozo89zHpCvGrN2VLlQetMrTTJKquThn4CT9SIm02Z2OM5l3vBLUg+QMk1MCjDUd znIsFtUG5F+8T0uqzFN698RYACagPl5Y10HMylWHZgpgV2wGxQWrXspx78wHRSvy cwDPd2SVQbO3o3s9ixlppxeO2kpva8NouzsCJn4nH5ivrHumFCm8SI2ka4YE6du5 2b6Hol1Ie9jxq8B6cCNdEsHeHru3r+r19GzTNE0VfbrArpM8jO7FHcLruyzRjlaC QyzDgdLXzV21113U+UlyAk5yWZ4he4xVHV4oFoN+QhIbQdNZP3gWkzLUQLLr9ry6 iIgeLx8GDONVxv7hGfNvAaxhQMgvANUOEtPP0CV+K0b60IDXyrFyP1xt5NRN77iR v1rfcqitudFUyF6zqbDDLC2a5EW45UVyQR0WdZK999TWHS/U+5pTcDHhls1F16VD wGZ+k+RmJQVWVdLImOsyWewPeZtzt02qlNom9LF8sKq8T4Uyf8uLhKksOyfxMCR7 AvZ53JHQoAAvhgPVn4KF
=7Oz4
-----END PGP SIGNATURE-----

Lukasz Majewski

author

2013-03-11 08:22 UTC #11 lore raw

PATCH 1/1 mmc:sdhci:fix: Change default interrupts enabled at SDHCI initialization

In reply to Lukasz Majewski

Dear All,

Quoted 33 lines

Hi Tom,
Quoted 18 lines
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 14 lines · Jaehoon Chung
Hi Tom,
Quoted 5 lines · Lukasz Majewski
Quoted 5 lines
Quoted 5 lines
Dear All,
I'd like to kindly ask for any feedback on this patch.
It is now more than month on the u-boot mailing list...
OK, sorry, the generic name of the driver threw me for a minute. I'm fine with this change going up u-boot-samsung -> u-boot-arm -> master since it's a samsung-only driver right now. Does this work for you?
Quoted 7 lines
Quoted 2 lines
Quoted 2 lines
I think that this driver didn't use samsung-only. going up u-boot-samsung? I'm not sure that.
Unless the context got very wrong, it touches drivers/mmc/sdhci.c which is controlled by CONFIG_SDHCI which is only turned on in what look like samsung platforms to me.
There is a /asm/arch-pantheon/config.h file which sets the CONFIG_SDHCI flag. It was added by Lei Wen (who is CC'ed to this thread) and looks like ARM926EJS (Marwell Semiconductor) processor based system.

Quoted 6 lines

Other systems are indeed samsung based processors.
I don't mind if this patch would go via u-boot-samsung tree.
Moreover, since this change "touches" Lei system, I think that he should have expressed his opinion. Sadly this didn't happened....

Any feedback? If not, please pull this patch to u-boot mainline.

Today it is 2 months since this patch has been posted on ML. No reply from interested people.

Signature · 5 lines

Best regards,

Lukasz Majewski

Samsung R&D Poland (SRPOL) | Linux Platform Group

Minkyu Kang

2013-03-12 10:54 UTC #12 lore raw

PATCH 1/1 mmc:sdhci:fix: Change default interrupts enabled at SDHCI initialization

Dear Lukasz,

Quoted 39 lines · Lukasz Majewski

Dear All,
Quoted 37 lines
Hi Tom,
Quoted 18 lines
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Quoted 14 lines · Jaehoon Chung
Hi Tom,
Quoted 5 lines · Lukasz Majewski
Quoted 5 lines
Quoted 5 lines
Dear All,
I'd like to kindly ask for any feedback on this patch.
It is now more than month on the u-boot mailing list...
OK, sorry, the generic name of the driver threw me for a minute. I'm fine with this change going up u-boot-samsung -> u-boot-arm -> master since it's a samsung-only driver right now. Does this work for you?
Quoted 7 lines
Quoted 2 lines
Quoted 2 lines
I think that this driver didn't use samsung-only. going up u-boot-samsung? I'm not sure that.
Unless the context got very wrong, it touches drivers/mmc/sdhci.c which is controlled by CONFIG_SDHCI which is only turned on in what look like samsung platforms to me.
There is a /asm/arch-pantheon/config.h file which sets the CONFIG_SDHCI flag. It was added by Lei Wen (who is CC'ed to this thread) and looks like ARM926EJS (Marwell Semiconductor) processor based system.
Other systems are indeed samsung based processors.
I don't mind if this patch would go via u-boot-samsung tree.

Quoted 8 lines

Quoted 2 lines
Moreover, since this change "touches" Lei system, I think that he should have expressed his opinion. Sadly this didn't happened....
Any feedback? If not, please pull this patch to u-boot mainline.
Today it is 2 months since this patch has been posted on ML. No reply from interested people.

Since Andy seems absent, applied to u-boot-samsung.

Thanks,
Minkyu Kang.