Skip to contentSkip to conversation

PME and dependency on ACPI

DISCUSSION Andrew Murray 2 participants 2 messages Jan 31, 2013 PCI

lore
Share & tools
lore
#0 lore raw

I think that PME may place an unnecessary dependency on ACPI...

in drivers/pci/pcie/Kconfig:

config PCIE_PME

	def_bool y
	depends on PCIEPORTBUS && PM_RUNTIME && ACPI

and drivers/pci/pcie/pme.c:

#include <linux/acpi.h>
#include <linux/pci-acpi.h>

On an ARM platform I can remove the #include's and remove the Kconfig dependency on ACPI and PME springs into life.

Is there any other reason why ACPI may be needed here?

Andrew Murray

#1 lore raw
Quoted 11 lines · Andrew Murray

I think that PME may place an unnecessary dependency on ACPI...

in drivers/pci/pcie/Kconfig:

config PCIE_PME

	def_bool y
	depends on PCIEPORTBUS && PM_RUNTIME && ACPI

and drivers/pci/pcie/pme.c:

Quoted 7 lines

#include <linux/acpi.h>
#include <linux/pci-acpi.h>

On an ARM platform I can remove the #include's and remove the Kconfig dependency on ACPI and PME springs into life.

Is there any other reason why ACPI may be needed here?

On x86 (PC) we need ACPI to determine whether or not we're allowed to use the PME interrupt. In turn, without that iterrupt PME is rather useless.

That said I don't think we need to make the PME *code* depend on ACPI, so it should be OK to remove the dependency from Kconfig.

Thanks,
Rafael

Signature · 2 lines
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.