Skip to contentSkip to conversation

rtc: da9055 change irq state to default

PATCH In review Ashish Jangam 3 participants 3 messages Jan 18, 2013 – Jan 31, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 4/5 rtc: da9055 change irq state to default

This patch changes the irq state from high to the now default low state.

This patch is dependent on the DA9055 MFD.

This patch is tested on smdk6410 board.

---
 drivers/rtc/rtc-da9055.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/rtc/rtc-da9055.c +1 -1
index 8f0dcfe..918b16b 100644
@@ -305,7 +305,7 @@ static int da9055_rtc_probe(struct platform_device *pdev)
 	alm_irq = regmap_irq_get_virq(rtc->da9055->irq_data, alm_irq);
 	ret = devm_request_threaded_irq(&pdev->dev, alm_irq, NULL,
 					da9055_rtc_alm_irq,
-					IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
+					IRQF_TRIGGER_LOW | IRQF_ONESHOT,
 					"ALM", rtc);
 	if (ret != 0)
 		dev_err(rtc->da9055->dev, "irq registration failed: %d\n", ret);
Signature · 1 line
1.7.0.4
#1 lore raw
Quoted 3 lines · Ashish Jangam

This patch changes the irq state from high to the now default low state.

will you please provide more info on why do we need to set it to low state?

Quoted 31 lines

This patch is dependent on the DA9055 MFD.

This patch is tested on smdk6410 board.

---
 drivers/rtc/rtc-da9055.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/rtc/rtc-da9055.c +1 -2
index 8f0dcfe..918b16b 100644
@@ -305,7 +305,7 @@ static int da9055_rtc_probe(struct platform_device *pdev)
        alm_irq = regmap_irq_get_virq(rtc->da9055->irq_data, alm_irq);
        ret = devm_request_threaded_irq(&pdev->dev, alm_irq, NULL,
                                        da9055_rtc_alm_irq,
-                                       IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
+                                       IRQF_TRIGGER_LOW | IRQF_ONESHOT,
                                        "ALM", rtc);
        if (ret != 0)
                dev_err(rtc->da9055->dev, "irq registration failed: %d\n", ret);
--

1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#2 lore raw
Quoted 7 lines · On Fri, 18 Jan 2013 01:10:40 -0500 "devendra.aaru" <[email protected]>…
Quoted 3 lines · Ashish Jangam

This patch changes the irq state from high to the now default low state.

will you please provide more info on why do we need to set it to low state?

Yes, I would also like more details about this patch, please.