Skip to contentSkip to conversation

Adding support for the new Armada XP evaluation board from Marvell

PATCH Superseded Gregory CLEMENT 7 participants 21 messages Jan 30, 2013 – Jan 31, 2013

Subsystems (2)

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Adding support for the new Armada XP evaluation board from Marvell

Hello,

This single patch add the dts support for new Armada XP evaluation board from Marvell called DB-MV784MP-GP. I am a little annoyed because on my board the Ethernet don't work under Linux (it works with U-Boot). However Florian Fainelli had more chance with the same board and managed to have a fully working Ethernet for the 4 ports. I would not miss the 3.9 kernel just because of a hardware problem on my side.

As Simon Guinot have also the same board and is interested by running a mainline Linux kernel on it, I hope he will be able to test it, soon. If I get the tested-by from Florian and Simon, we can consider that the support is OK, and it is my board which have a hardware problem.

Thanks,

Gregory CLEMENT (1):
arm: mvebu: support for the new Armada XP evaluation

    board(DB-MV784MP-GP)
 arch/arm/boot/dts/Makefile         |    1 +
 arch/arm/boot/dts/armada-xp-gp.dts |   94 ++++++++++++++++++++++++++++++++++++
 2 files changed, 95 insertions(+)
 create mode 100644 arch/arm/boot/dts/armada-xp-gp.dts
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 arm: mvebu: support for the new Armada XP evaluation board(DB-MV784MP-GP)

This is the new Armada XP evaluation board from Marvell. It comes with a RS232 port over USB, a SATA link, an internal SSD, 4 Ethernet Gigabit links.

Support for USB (Host and device), SDIO, PCIe will be added as drivers when they become available for Armada XP in mainline.

---
 arch/arm/boot/dts/Makefile         |    1 +
 arch/arm/boot/dts/armada-xp-gp.dts |   94 ++++++++++++++++++++++++++++++++++++
 2 files changed, 95 insertions(+)
 create mode 100644 arch/arm/boot/dts/armada-xp-gp.dts
arch/arm/boot/dts/Makefile +1 -0
index 5ebb44f..51aab4b 100644
@@ -78,6 +78,7 @@ dtb-$(CONFIG_ARCH_MSM) += msm8660-surf.dtb \
 dtb-$(CONFIG_ARCH_MVEBU) += armada-370-db.dtb \
 	armada-370-mirabox.dtb \
 	armada-xp-db.dtb \
+	armada-xp-gp.dtb \
 	armada-xp-openblocks-ax3-4.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx51-babbage.dtb \
 	imx53-ard.dtb \
arch/arm/boot/dts/armada-xp-gp.dts new file +94 -0

94 lines not on this page · raw message

Signature · 1 line
1.7.9.5
#2 lore raw

PATCH 1/1 arm: mvebu: support for the new Armada XP evaluation board(DB-MV784MP-GP)

Hello Gregory,

Quoted 32 lines · Gregory CLEMENT

This is the new Armada XP evaluation board from Marvell. It comes with a RS232 port over USB, a SATA link, an internal SSD, 4 Ethernet Gigabit links.

Support for USB (Host and device), SDIO, PCIe will be added as drivers when they become available for Armada XP in mainline.

---
  arch/arm/boot/dts/Makefile         |    1 +
  arch/arm/boot/dts/armada-xp-gp.dts |   94 ++++++++++++++++++++++++++++++++++++
  2 files changed, 95 insertions(+)

create mode 100644 arch/arm/boot/dts/armada-xp-gp.dts

arch/arm/boot/dts/Makefile +1 -0
index 5ebb44f..51aab4b 100644
@@ -78,6 +78,7 @@ dtb-$(CONFIG_ARCH_MSM) += msm8660-surf.dtb \
  dtb-$(CONFIG_ARCH_MVEBU) += armada-370-db.dtb \
  	armada-370-mirabox.dtb \
  	armada-xp-db.dtb \
+	armada-xp-gp.dtb \
  	armada-xp-openblocks-ax3-4.dtb
  dtb-$(CONFIG_ARCH_MXC) += imx51-babbage.dtb \
  	imx53-ard.dtb \
arch/arm/boot/dts/armada-xp-gp.dts new file +0 -0
new file mode 100644
index 0000000..85ba642

arch/arm/boot/dts/armada-xp-gp.dts line 3

Quoted 3 lines
arch/arm/boot/dts/armada-xp-gp.dts new file +3 -0
@@ -0,0 +1,94 @@
+/*
+ * Device Tree file for Marvell Armada XP evaluation board
+ * (RD-MV784MP-GP)

Marvell refers to this as a Reference Design (which it is because it is boxed).

Quoted 7 lines
arch/arm/boot/dts/armada-xp-gp.dts new file +7 -0
+ *
+ * Copyright (C) 2013 Marvell
+ *
+ * Lior Amsalem <[email protected]>
+ * Gregory CLEMENT <[email protected]>
+ * Thomas Petazzoni <[email protected]>
+ *

arch/arm/boot/dts/armada-xp-gp.dts line 20

Quoted 10 lines
arch/arm/boot/dts/armada-xp-gp.dts new file +10 -0
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2.  This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+/dts-v1/;
+/include/ "armada-xp-mv78460.dtsi"
+
+/ {
+	model = "Marvell Armada XP Evaluation Board: RD-MV784MP-GP";

Ditto, should be "Marvell Armada XP Reference Design Board".

Quoted 41 lines
arch/arm/boot/dts/armada-xp-gp.dts new file +41 -0
+	compatible = "marvell,axp-db", "marvell,armadaxp-mv78460", "marvell,armadaxp", "marvell,armada-370-xp";
+
+	chosen {
+		bootargs = "console=ttyS0,115200 earlyprintk";
+	};
+
+	memory {
+		device_type = "memory";
+		reg = <0x00000000 0xC0000000>; /* 3 GB */
+	};
+
+	soc {
+		serial at d0012000 {
+			clock-frequency = <250000000>;
+			status = "okay";
+		};
+		serial at d0012100 {
+			clock-frequency = <250000000>;
+			status = "okay";
+		};
+		serial at d0012200 {
+			clock-frequency = <250000000>;
+			status = "okay";
+		};
+		serial at d0012300 {
+			clock-frequency = <250000000>;
+			status = "okay";
+		};
+
+		sata at d00a0000 {
+			nr-ports = <2>;
+			status = "okay";
+		};
+
+		mdio {
+			phy0: ethernet-phy at 0 {
+				reg = <16>;
+			};
+
+			phy1: ethernet-phy at 1 {
+				reg = <17>;

arch/arm/boot/dts/armada-xp-gp.dts line 71

Quoted 10 lines
arch/arm/boot/dts/armada-xp-gp.dts new file +10 -0
+			};
+
+			phy2: ethernet-phy at 2 {
+				reg = <18>;
+			};
+
+			phy3: ethernet-phy at 3 {
+				reg = <19>;
+			};
+		};

It seemed to me like the PHY addresses were 0 to 3, but I will test that within the next few minutes.
--
Florian

#3 lore raw

PATCH 1/1 arm: mvebu: support for the new Armada XP evaluation board(DB-MV784MP-GP)

Quoted 1 line · Florian Fainelli

Hello Gregory,

Hi Floran,

thanks for your quick feedback

Quoted 32 lines · Gregory CLEMENT
Quoted 30 lines

This is the new Armada XP evaluation board from Marvell. It comes with a RS232 port over USB, a SATA link, an internal SSD, 4 Ethernet Gigabit links.

Support for USB (Host and device), SDIO, PCIe will be added as drivers when they become available for Armada XP in mainline.

---
  arch/arm/boot/dts/Makefile         |    1 +
  arch/arm/boot/dts/armada-xp-gp.dts |   94 ++++++++++++++++++++++++++++++++++++
  2 files changed, 95 insertions(+)

create mode 100644 arch/arm/boot/dts/armada-xp-gp.dts

arch/arm/boot/dts/Makefile +1 -0
index 5ebb44f..51aab4b 100644
@@ -78,6 +78,7 @@ dtb-$(CONFIG_ARCH_MSM) += msm8660-surf.dtb \
  dtb-$(CONFIG_ARCH_MVEBU) += armada-370-db.dtb \
  	armada-370-mirabox.dtb \
  	armada-xp-db.dtb \
+	armada-xp-gp.dtb \
  	armada-xp-openblocks-ax3-4.dtb
  dtb-$(CONFIG_ARCH_MXC) += imx51-babbage.dtb \
  	imx53-ard.dtb \
arch/arm/boot/dts/armada-xp-gp.dts new file +0 -1
new file mode 100644
index 0000000..85ba642
--- /dev/null
Quoted 8 lines

arch/arm/boot/dts/armada-xp-gp.dts line 3

Quoted 5 lines

+++ b/arch/arm/boot/dts/armada-xp-gp.dts

arch/arm/boot/dts/armada-xp-gp.dts new file +3 -0
@@ -0,0 +1,94 @@
+/*
+ * Device Tree file for Marvell Armada XP evaluation board
+ * (RD-MV784MP-GP)

Marvell refers to this as a Reference Design (which it is because it is boxed).

OK I will change this

Quoted 12 lines
Quoted 12 lines
arch/arm/boot/dts/armada-xp-gp.dts new file +11 -0
+ *
+ * Copyright (C) 2013 Marvell
+ *
+ * Lior Amsalem <[email protected]>
+ * Gregory CLEMENT <[email protected]>
+ * Thomas Petazzoni <[email protected]>
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2.  This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
Quoted 8 lines

arch/arm/boot/dts/armada-xp-gp.dts line 20

Quoted 6 lines
arch/arm/boot/dts/armada-xp-gp.dts new file +6 -0
+
+/dts-v1/;
+/include/ "armada-xp-mv78460.dtsi"
+
+/ {
+	model = "Marvell Armada XP Evaluation Board: RD-MV784MP-GP";

Ditto, should be "Marvell Armada XP Reference Design Board".

I will change this too

Quoted 46 lines
Quoted 46 lines
arch/arm/boot/dts/armada-xp-gp.dts new file +46 -0
+	compatible = "marvell,axp-db", "marvell,armadaxp-mv78460", "marvell,armadaxp", "marvell,armada-370-xp";
+
+	chosen {
+		bootargs = "console=ttyS0,115200 earlyprintk";
+	};
+
+	memory {
+		device_type = "memory";
+		reg = <0x00000000 0xC0000000>; /* 3 GB */
+	};
+
+	soc {
+		serial at d0012000 {
+			clock-frequency = <250000000>;
+			status = "okay";
+		};
+		serial at d0012100 {
+			clock-frequency = <250000000>;
+			status = "okay";
+		};
+		serial at d0012200 {
+			clock-frequency = <250000000>;
+			status = "okay";
+		};
+		serial at d0012300 {
+			clock-frequency = <250000000>;
+			status = "okay";
+		};
+
+		sata at d00a0000 {
+			nr-ports = <2>;
+			status = "okay";
+		};
+
+		mdio {
+			phy0: ethernet-phy at 0 {
+				reg = <16>;
+			};
+
+			phy1: ethernet-phy at 1 {
+				reg = <17>;
+			};
+
+			phy2: ethernet-phy at 2 {
+				reg = <18>;
+			};
Quoted 8 lines

arch/arm/boot/dts/armada-xp-gp.dts line 71

Quoted 5 lines
arch/arm/boot/dts/armada-xp-gp.dts new file +5 -0
+
+			phy3: ethernet-phy at 3 {
+				reg = <19>;
+			};
+		};

It seemed to me like the PHY addresses were 0 to 3, but I will test that within the next few minutes.

I wait for your results

Quoted 3 lines

--
Florian

Signature · 4 lines
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#4 lore raw

PATCH 1/1 arm: mvebu: support for the new Armada XP evaluation board(DB-MV784MP-GP)

In reply to Gregory CLEMENT
Quoted 51 lines · Gregory CLEMENT

This is the new Armada XP evaluation board from Marvell. It comes with a RS232 port over USB, a SATA link, an internal SSD, 4 Ethernet Gigabit links.

Support for USB (Host and device), SDIO, PCIe will be added as drivers when they become available for Armada XP in mainline.

---
 arch/arm/boot/dts/Makefile         |    1 +
 arch/arm/boot/dts/armada-xp-gp.dts |   94 ++++++++++++++++++++++++++++++++++++
 2 files changed, 95 insertions(+)
 create mode 100644 arch/arm/boot/dts/armada-xp-gp.dts
arch/arm/boot/dts/Makefile +1 -0
index 5ebb44f..51aab4b 100644
@@ -78,6 +78,7 @@ dtb-$(CONFIG_ARCH_MSM) += msm8660-surf.dtb \
 dtb-$(CONFIG_ARCH_MVEBU) += armada-370-db.dtb \
 	armada-370-mirabox.dtb \
 	armada-xp-db.dtb \
+	armada-xp-gp.dtb \
 	armada-xp-openblocks-ax3-4.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx51-babbage.dtb \
 	imx53-ard.dtb \
arch/arm/boot/dts/armada-xp-gp.dts new file +19 -0
new file mode 100644
index 0000000..85ba642
@@ -0,0 +1,94 @@
+/*
+ * Device Tree file for Marvell Armada XP evaluation board
+ * (RD-MV784MP-GP)
+ *
+ * Copyright (C) 2013 Marvell
+ *
+ * Lior Amsalem <[email protected]>
+ * Gregory CLEMENT <[email protected]>
+ * Thomas Petazzoni <[email protected]>
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2.  This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+/dts-v1/;
+/include/ "armada-xp-mv78460.dtsi"
+
+/ {

arch/arm/boot/dts/armada-xp-gp.dts line 29

Quoted 10 lines
arch/arm/boot/dts/armada-xp-gp.dts new file +10 -0
+	model = "Marvell Armada XP Evaluation Board: RD-MV784MP-GP";
+	compatible = "marvell,axp-db", "marvell,armadaxp-mv78460", "marvell,armadaxp", "marvell,armada-370-xp";
+
+	chosen {
+		bootargs = "console=ttyS0,115200 earlyprintk";
+	};
+
+	memory {
+		device_type = "memory";
+		reg = <0x00000000 0xC0000000>; /* 3 GB */

Is this the soldered on the board amount, or the amount with an expandable slot filled?

thx,

Jason.

#5 lore raw

PATCH 1/1 arm: mvebu: support for the new Armada XP evaluation board(DB-MV784MP-GP)

Quoted 57 lines · Jason Cooper
Quoted 56 lines · Gregory CLEMENT

This is the new Armada XP evaluation board from Marvell. It comes with a RS232 port over USB, a SATA link, an internal SSD, 4 Ethernet Gigabit links.

Support for USB (Host and device), SDIO, PCIe will be added as drivers when they become available for Armada XP in mainline.

---
 arch/arm/boot/dts/Makefile         |    1 +
 arch/arm/boot/dts/armada-xp-gp.dts |   94 ++++++++++++++++++++++++++++++++++++
 2 files changed, 95 insertions(+)
 create mode 100644 arch/arm/boot/dts/armada-xp-gp.dts
arch/arm/boot/dts/Makefile +1 -0
index 5ebb44f..51aab4b 100644
@@ -78,6 +78,7 @@ dtb-$(CONFIG_ARCH_MSM) += msm8660-surf.dtb \
 dtb-$(CONFIG_ARCH_MVEBU) += armada-370-db.dtb \
 	armada-370-mirabox.dtb \
 	armada-xp-db.dtb \
+	armada-xp-gp.dtb \
 	armada-xp-openblocks-ax3-4.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx51-babbage.dtb \
 	imx53-ard.dtb \
arch/arm/boot/dts/armada-xp-gp.dts new file +24 -0
new file mode 100644
index 0000000..85ba642
@@ -0,0 +1,94 @@
+/*
+ * Device Tree file for Marvell Armada XP evaluation board
+ * (RD-MV784MP-GP)
+ *
+ * Copyright (C) 2013 Marvell
+ *
+ * Lior Amsalem <[email protected]>
+ * Gregory CLEMENT <[email protected]>
+ * Thomas Petazzoni <[email protected]>
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2.  This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+/dts-v1/;
+/include/ "armada-xp-mv78460.dtsi"
+
+/ {
+	model = "Marvell Armada XP Evaluation Board: RD-MV784MP-GP";
+	compatible = "marvell,axp-db", "marvell,armadaxp-mv78460", "marvell,armadaxp", "marvell,armada-370-xp";
+
+	chosen {
+		bootargs = "console=ttyS0,115200 earlyprintk";
Quoted 8 lines

arch/arm/boot/dts/armada-xp-gp.dts line 29

Quoted 5 lines
arch/arm/boot/dts/armada-xp-gp.dts new file +5 -0
+	};
+
+	memory {
+		device_type = "memory";
+		reg = <0x00000000 0xC0000000>; /* 3 GB */

Is this the soldered on the board amount, or the amount with an expandable slot filled?

It is not soldered, so you can change the amount of memory

Quoted 5 lines

thx,

Jason.

Signature · 4 lines
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#6 lore raw

PATCH 1/1 arm: mvebu: support for the new Armada XP evaluation board(DB-MV784MP-GP)

Gregory,

Adding devicetree-discuss.

Guys, how do you prefer to handle plug-in RAM modules? describe the soldered-in amount, or?

Quoted 16 lines · Gregory CLEMENT
Quoted 15 lines · Jason Cooper
Quoted 14 lines · Gregory CLEMENT

This is the new Armada XP evaluation board from Marvell. It comes with a RS232 port over USB, a SATA link, an internal SSD, 4 Ethernet Gigabit links.

Support for USB (Host and device), SDIO, PCIe will be added as drivers when they become available for Armada XP in mainline.

---
 arch/arm/boot/dts/Makefile         |    1 +
 arch/arm/boot/dts/armada-xp-gp.dts |   94 ++++++++++++++++++++++++++++++++++++
 2 files changed, 95 insertions(+)
 create mode 100644 arch/arm/boot/dts/armada-xp-gp.dts

...

Quoted 8 lines
Quoted 6 lines

arch/arm/boot/dts/armada-xp-gp.dts line 29

Quoted 3 lines
arch/arm/boot/dts/armada-xp-gp.dts new file +3 -0
+	memory {
+		device_type = "memory";
+		reg = <0x00000000 0xC0000000>; /* 3 GB */

Is this the soldered on the board amount, or the amount with an expandable slot filled?

It is not soldered, so you can change the amount of memory

Well, there's something we don't encounter too much in the embedded world. ;-) I'm inclined to think the entry here should be the soldered on amount, and the bootloader would (hypothetically) change the DT to the probed amount. But I haven't seen a precedent set yet...

thx,

Jason.

#7 lore raw

PATCH 1/1 arm: mvebu: support for the new Armada XP evaluation board(DB-MV784MP-GP)

Quoted 33 lines · Jason Cooper

Gregory,

Adding devicetree-discuss.

Guys, how do you prefer to handle plug-in RAM modules? describe the soldered-in amount, or?

Quoted 16 lines · Gregory CLEMENT
Quoted 15 lines · Jason Cooper
Quoted 14 lines · Gregory CLEMENT

This is the new Armada XP evaluation board from Marvell. It comes with a RS232 port over USB, a SATA link, an internal SSD, 4 Ethernet Gigabit links.

Support for USB (Host and device), SDIO, PCIe will be added as drivers when they become available for Armada XP in mainline.

---
 arch/arm/boot/dts/Makefile         |    1 +
 arch/arm/boot/dts/armada-xp-gp.dts |   94 ++++++++++++++++++++++++++++++++++++
 2 files changed, 95 insertions(+)
 create mode 100644 arch/arm/boot/dts/armada-xp-gp.dts

...

Quoted 7 lines
Quoted 6 lines

arch/arm/boot/dts/armada-xp-gp.dts line 29

Quoted 3 lines
arch/arm/boot/dts/armada-xp-gp.dts new file +3 -0
+	memory {
+		device_type = "memory";
+		reg = <0x00000000 0xC0000000>; /* 3 GB */

Is this the soldered on the board amount, or the amount with an expandable slot filled?

Quoted 6 lines
Quoted 1 line

It is not soldered, so you can change the amount of memory

Well, there's something we don't encounter too much in the embedded world. ;-) I'm inclined to think the entry here should be the soldered on amount, and the bootloader would (hypothetically) change the DT to the probed amount. But I haven't seen a precedent set yet...

Hi Jason

We have the same issue with OpenBox AX3. All the devices we have in our hands have 1GB soldered down, plus 2GB on expansion. The DT currently has the full 3GB.

However, there has been discussion of reducing this down to 1GB since both Thomas and Gregory have unstable systems with the full 3GB, but mine box is stable with the full 3GB. So i don't know how strong a precedent that sets....

Andrew

#8 lore raw

PATCH 1/1 arm: mvebu: support for the new Armada XP evaluation board(DB-MV784MP-GP)

Dear Andrew Lunn,

Quoted 8 lines · Andrew Lunn

We have the same issue with OpenBox AX3. All the devices we have in our hands have 1GB soldered down, plus 2GB on expansion. The DT currently has the full 3GB.

However, there has been discussion of reducing this down to 1GB since both Thomas and Gregory have unstable systems with the full 3GB, but mine box is stable with the full 3GB. So i don't know how strong a precedent that sets....

It seems that if we have CONFIG_ARM_ATAG_DTB_COMPAT, then the code in arch/arm/boot/compressed/atags_to_fdt.c will update the DT memory node according to the ATAG_MEM passed by the bootloader.

Best regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#9 lore raw

PATCH 1/1 arm: mvebu: support for the new Armada XP evaluation board(DB-MV784MP-GP)

Quoted 13 lines · Thomas Petazzoni

Dear Andrew Lunn,

Quoted 8 lines · Andrew Lunn

We have the same issue with OpenBox AX3. All the devices we have in our hands have 1GB soldered down, plus 2GB on expansion. The DT currently has the full 3GB.

However, there has been discussion of reducing this down to 1GB since both Thomas and Gregory have unstable systems with the full 3GB, but mine box is stable with the full 3GB. So i don't know how strong a precedent that sets....

Quoted 6 lines

It seems that if we have CONFIG_ARM_ATAG_DTB_COMPAT, then the code in arch/arm/boot/compressed/atags_to_fdt.c will update the DT memory node according to the ATAG_MEM passed by the bootloader.

From my point of view these dts file are just given as reference, and the

bootloader should be able to modify them on the fly according the hardware configuration of the board.

And for old bootloader then we can use the CONFIG_ARM_ATAG_DTB_COMPAT as pointed by Thomas.

So I am not sure that the amount of memory is very important.

However I think that having a value by default is useful, so unless there is a strong argument against it, I would like to keep it, maybe with a comment in the dts to emphasize that it is just a default value and the amount of memory can be changed.

Quoted 4 lines

Best regards,

Thomas

Signature · 4 lines
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#10 lore raw

PATCH 1/1 arm: mvebu: support for the new Armada XP evaluation board(DB-MV784MP-GP)

Quoted 26 lines · Gregory CLEMENT
Quoted 8 lines · Thomas Petazzoni

Dear Andrew Lunn,

Quoted 4 lines · Andrew Lunn

We have the same issue with OpenBox AX3. All the devices we have in our hands have 1GB soldered down, plus 2GB on expansion. The DT currently has the full 3GB.

Quoted 9 lines
Quoted 4 lines

However, there has been discussion of reducing this down to 1GB since both Thomas and Gregory have unstable systems with the full 3GB, but mine box is stable with the full 3GB. So i don't know how strong a precedent that sets....

It seems that if we have CONFIG_ARM_ATAG_DTB_COMPAT, then the code in arch/arm/boot/compressed/atags_to_fdt.c will update the DT memory node according to the ATAG_MEM passed by the bootloader.

From my point of view these dts file are just given as reference, and the bootloader should be able to modify them on the fly according the hardware configuration of the board.

And for old bootloader then we can use the CONFIG_ARM_ATAG_DTB_COMPAT as pointed by Thomas.

Quoted 6 lines

So I am not sure that the amount of memory is very important.

However I think that having a value by default is useful, so unless there is a strong argument against it, I would like to keep it, maybe with a comment in the dts to emphasize that it is just a default value and the amount of memory can be changed.

Let's go with the comment. Upgradeable memory is still fairly uncommon in embedded, it won't hurt to let folks know the bootloader will set it (hopefully) correctly.

thx,

Jason.

#11 lore raw

PATCH 1/1 arm: mvebu: support for the new Armada XP evaluation board(DB-MV784MP-GP)

In reply to Jason Cooper
Quoted 4 lines · Jason Cooper

Gregory,

Adding devicetree-discuss.

I should have added it in in CC in my first version

Quoted 29 lines

Guys, how do you prefer to handle plug-in RAM modules? describe the soldered-in amount, or?

Quoted 16 lines · Gregory CLEMENT
Quoted 15 lines · Jason Cooper
Quoted 14 lines · Gregory CLEMENT

This is the new Armada XP evaluation board from Marvell. It comes with a RS232 port over USB, a SATA link, an internal SSD, 4 Ethernet Gigabit links.

Support for USB (Host and device), SDIO, PCIe will be added as drivers when they become available for Armada XP in mainline.

---
 arch/arm/boot/dts/Makefile         |    1 +
 arch/arm/boot/dts/armada-xp-gp.dts |   94 ++++++++++++++++++++++++++++++++++++
 2 files changed, 95 insertions(+)
 create mode 100644 arch/arm/boot/dts/armada-xp-gp.dts

...

Quoted 7 lines
Quoted 6 lines

arch/arm/boot/dts/armada-xp-gp.dts line 29

Quoted 3 lines
arch/arm/boot/dts/armada-xp-gp.dts new file +3 -0
+	memory {
+		device_type = "memory";
+		reg = <0x00000000 0xC0000000>; /* 3 GB */

Is this the soldered on the board amount, or the amount with an expandable slot filled?

Quoted 6 lines
Quoted 1 line

It is not soldered, so you can change the amount of memory

Well, there's something we don't encounter too much in the embedded world. ;-) I'm inclined to think the entry here should be the soldered on amount, and the bootloader would (hypothetically) change the DT to the probed amount. But I haven't seen a precedent set yet...

Well on this board there is no soldered memory at all.

Quoted 10 lines

thx,

Jason.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Signature · 4 lines
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#12 lore raw

PATCH 1/1 arm: mvebu: support for the new Armada XP evaluation board(DB-MV784MP-GP)

Quoted 37 lines · Gregory CLEMENT
Quoted 4 lines · Jason Cooper

Gregory,

Adding devicetree-discuss.

I should have added it in in CC in my first version

Quoted 29 lines

Guys, how do you prefer to handle plug-in RAM modules? describe the soldered-in amount, or?

Quoted 16 lines · Gregory CLEMENT
Quoted 15 lines · Jason Cooper
Quoted 14 lines · Gregory CLEMENT

This is the new Armada XP evaluation board from Marvell. It comes with a RS232 port over USB, a SATA link, an internal SSD, 4 Ethernet Gigabit links.

Support for USB (Host and device), SDIO, PCIe will be added as drivers when they become available for Armada XP in mainline.

---
 arch/arm/boot/dts/Makefile         |    1 +
 arch/arm/boot/dts/armada-xp-gp.dts |   94 ++++++++++++++++++++++++++++++++++++
 2 files changed, 95 insertions(+)
 create mode 100644 arch/arm/boot/dts/armada-xp-gp.dts

...

Quoted 7 lines
Quoted 6 lines

arch/arm/boot/dts/armada-xp-gp.dts line 29

Quoted 3 lines
arch/arm/boot/dts/armada-xp-gp.dts new file +3 -0
+	memory {
+		device_type = "memory";
+		reg = <0x00000000 0xC0000000>; /* 3 GB */

Is this the soldered on the board amount, or the amount with an expandable slot filled?

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

It is not soldered, so you can change the amount of memory

Well, there's something we don't encounter too much in the embedded world. ;-) I'm inclined to think the entry here should be the soldered on amount, and the bootloader would (hypothetically) change the DT to the probed amount. But I haven't seen a precedent set yet...

Well on this board there is no soldered memory at all.

So it has two slots? 1GB and 2GB?

thx,

Jason.

#13 lore raw

PATCH 1/1 arm: mvebu: support for the new Armada XP evaluation board(DB-MV784MP-GP)

Quoted 40 lines · Jason Cooper
Quoted 39 lines · Gregory CLEMENT
Quoted 4 lines · Jason Cooper

Gregory,

Adding devicetree-discuss.

I should have added it in in CC in my first version

Quoted 31 lines

Guys, how do you prefer to handle plug-in RAM modules? describe the soldered-in amount, or?

Quoted 16 lines · Gregory CLEMENT
Quoted 15 lines · Jason Cooper
Quoted 14 lines · Gregory CLEMENT

This is the new Armada XP evaluation board from Marvell. It comes with a RS232 port over USB, a SATA link, an internal SSD, 4 Ethernet Gigabit links.

Support for USB (Host and device), SDIO, PCIe will be added as drivers when they become available for Armada XP in mainline.

---
 arch/arm/boot/dts/Makefile         |    1 +
 arch/arm/boot/dts/armada-xp-gp.dts |   94 ++++++++++++++++++++++++++++++++++++
 2 files changed, 95 insertions(+)
 create mode 100644 arch/arm/boot/dts/armada-xp-gp.dts

...

Quoted 8 lines
Quoted 6 lines

arch/arm/boot/dts/armada-xp-gp.dts line 29

Quoted 3 lines
arch/arm/boot/dts/armada-xp-gp.dts new file +3 -0
+	memory {
+		device_type = "memory";
+		reg = <0x00000000 0xC0000000>; /* 3 GB */

Is this the soldered on the board amount, or the amount with an expandable slot filled?

It is not soldered, so you can change the amount of memory

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

Well, there's something we don't encounter too much in the embedded world. ;-) I'm inclined to think the entry here should be the soldered on amount, and the bootloader would (hypothetically) change the DT to the probed amount. But I haven't seen a precedent set yet...

Well on this board there is no soldered memory at all.

So it has two slots? 1GB and 2GB?

Well in fact it is 4GB RAM but we can only use 3GB (we need the last GB of address space for peripheral, CPU registers and IOmem).

There is only one slot.

Quoted 5 lines

thx,

Jason.

Signature · 4 lines
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#14 lore raw

PATCH 1/1 arm: mvebu: support for the new Armada XP evaluation board(DB-MV784MP-GP)

Quoted 10 lines · Gregory CLEMENT
Quoted 4 lines · Jason Cooper
Quoted 1 line · Gregory CLEMENT

Well on this board there is no soldered memory at all.

So it has two slots? 1GB and 2GB?

Well in fact it is 4GB RAM but we can only use 3GB (we need the last GB of address space for peripheral, CPU registers and IOmem).

There is only one slot.

Ok, thanks.

Jason.

#15 lore raw

PATCH 1/1 arm: mvebu: support for the new Armada XP evaluation board(DB-MV784MP-GP)

In reply to Gregory CLEMENT
Quoted 2 lines

Well in fact it is 4GB RAM but we can only use 3GB (we need the last GB of address space for peripheral, CPU registers and IOmem).

Hi Gregory

Does the CPU support Large Physical Addressing, LPA? Is that on the roadmap for Armada?

Andrew

#16 lore raw

PATCH 1/1 arm: mvebu: support for the new Armada XP evaluation board(DB-MV784MP-GP)

Quoted 7 lines · Andrew Lunn
Quoted 2 lines

Well in fact it is 4GB RAM but we can only use 3GB (we need the last GB of address space for peripheral, CPU registers and IOmem).

Hi Gregory

Does the CPU support Large Physical Addressing, LPA? Is that on the roadmap for Armada?

I did a bit of googling:

http://www.linleygroup.com/newsletters/newsletter_detail.php?num=3982

To address the cloud-computing market, the company added 40-bit physical addressing to Armada XP, using a method similar to what ARM implemented in Cortex-A15. This feature allows the memory controller to support up to one terabyte (1TB) of DRAM.

Also:

http://www.theregister.co.uk/2012/10/24/dell_zinc_arm_server_apache_software/

talks about 40-bit.

So it should be possible to use the full 4GBytes of RAM, in theory.

Andrew

maintainer
#17 lore raw

PATCH 1/1 arm: mvebu: support for the new Armada XP evaluation board(DB-MV784MP-GP)

Quoted 10 lines · Andrew Lunn

I did a bit of googling:

http://www.linleygroup.com/newsletters/newsletter_detail.php?num=3982

To address the cloud-computing market, the company added 40-bit physical addressing to Armada XP, using a method similar to what ARM implemented in Cortex-A15. This feature allows the memory controller to support up to one terabyte (1TB) of DRAM.

Quoted 7 lines

Also:

http://www.theregister.co.uk/2012/10/24/dell_zinc_arm_server_apache_software/

talks about 40-bit.

So it should be possible to use the full 4GBytes of RAM, in theory.

But is it actually using the same page table layout as LPAE or just something "similar"?

Note that there is also 36-bit addressing in certain CPUs, which is far less useful in general, but which could actually help here if you can remap the MMIO registers above 4GB to free up the 32-bit space for RAM.

Arnd

#18 lore raw

PATCH 1/1 arm: mvebu: support for the new Armada XP evaluation board(DB-MV784MP-GP)

In reply to Gregory CLEMENT
Quoted 8 lines · On Wednesday 30 January 2013 18:26:14 Gregory CLEMENT wrote:

This is the new Armada XP evaluation board from Marvell. It comes with a RS232 port over USB, a SATA link, an internal SSD, 4 Ethernet Gigabit links.

Support for USB (Host and device), SDIO, PCIe will be added as drivers when they become available for Armada XP in mainline.

The PHY mapping you have is the right one, besides the minor naming in model and header comment, this is good, thanks a lot!

Signature · 1 line
Florian
#19 lore raw

PATCH 1/1 arm: mvebu: support for the new Armada XP evaluation board(DB-MV784MP-GP)

Quoted 8 lines · Florian Fainelli
Quoted 7 lines · On Wednesday 30 January 2013 18:26:14 Gregory CLEMENT wrote:

This is the new Armada XP evaluation board from Marvell. It comes with a RS232 port over USB, a SATA link, an internal SSD, 4 Ethernet Gigabit links.

Support for USB (Host and device), SDIO, PCIe will be added as drivers when they become available for Armada XP in mainline.

Quoted 7 lines
Quoted 1 line

The PHY mapping you have is the right one, besides the minor naming in model and header comment, this is good, thanks a lot!

Thanks!
So I am waiting for the official Tested-by from Simon, and I will send a V2 patch with the name fixed and with your tested-by.

Signature · 4 lines
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#20 lore raw

PATCH 1/1 arm: mvebu: support for the new Armada XP evaluation board(DB-MV784MP-GP)

In reply to Gregory CLEMENT
Quoted 7 lines · Gregory CLEMENT

This is the new Armada XP evaluation board from Marvell. It comes with a RS232 port over USB, a SATA link, an internal SSD, 4 Ethernet Gigabit links.

Support for USB (Host and device), SDIO, PCIe will be added as drivers when they become available for Armada XP in mainline.

Quoted 6 lines
---
 arch/arm/boot/dts/Makefile         |    1 +
 arch/arm/boot/dts/armada-xp-gp.dts |   94 ++++++++++++++++++++++++++++++++++++
 2 files changed, 95 insertions(+)
 create mode 100644 arch/arm/boot/dts/armada-xp-gp.dts

It works fine for me. Thank you for the patch.

Quoted 121 lines
arch/arm/boot/dts/Makefile +1 -0
index 5ebb44f..51aab4b 100644
@@ -78,6 +78,7 @@ dtb-$(CONFIG_ARCH_MSM) += msm8660-surf.dtb \
 dtb-$(CONFIG_ARCH_MVEBU) += armada-370-db.dtb \
 	armada-370-mirabox.dtb \
 	armada-xp-db.dtb \
+	armada-xp-gp.dtb \
 	armada-xp-openblocks-ax3-4.dtb
 dtb-$(CONFIG_ARCH_MXC) += imx51-babbage.dtb \
 	imx53-ard.dtb \
arch/arm/boot/dts/armada-xp-gp.dts new file +94 -0
new file mode 100644
index 0000000..85ba642
@@ -0,0 +1,94 @@
+/*
+ * Device Tree file for Marvell Armada XP evaluation board
+ * (RD-MV784MP-GP)
+ *
+ * Copyright (C) 2013 Marvell
+ *
+ * Lior Amsalem <[email protected]>
+ * Gregory CLEMENT <[email protected]>
+ * Thomas Petazzoni <[email protected]>
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2.  This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+/dts-v1/;
+/include/ "armada-xp-mv78460.dtsi"
+
+/ {
+	model = "Marvell Armada XP Evaluation Board: RD-MV784MP-GP";
+	compatible = "marvell,axp-db", "marvell,armadaxp-mv78460", "marvell,armadaxp", "marvell,armada-370-xp";
+
+	chosen {
+		bootargs = "console=ttyS0,115200 earlyprintk";
+	};
+
+	memory {
+		device_type = "memory";
+		reg = <0x00000000 0xC0000000>; /* 3 GB */
+	};
+
+	soc {
+		serial at d0012000 {
+			clock-frequency = <250000000>;
+			status = "okay";
+		};
+		serial at d0012100 {
+			clock-frequency = <250000000>;
+			status = "okay";
+		};
+		serial at d0012200 {
+			clock-frequency = <250000000>;
+			status = "okay";
+		};
+		serial at d0012300 {
+			clock-frequency = <250000000>;
+			status = "okay";
+		};
+
+		sata at d00a0000 {
+			nr-ports = <2>;
+			status = "okay";
+		};
+
+		mdio {
+			phy0: ethernet-phy at 0 {
+				reg = <16>;
+			};
+
+			phy1: ethernet-phy at 1 {
+				reg = <17>;
+			};
+
+			phy2: ethernet-phy at 2 {
+				reg = <18>;
+			};
+
+			phy3: ethernet-phy at 3 {
+				reg = <19>;
+			};
+		};
+
+		ethernet at d0070000 {
+			status = "okay";
+			phy = <&phy0>;
+			phy-mode = "rgmii-id";
+		};
+		ethernet at d0074000 {
+			status = "okay";
+			phy = <&phy1>;
+			phy-mode = "rgmii-id";
+		};
+		ethernet at d0030000 {
+			status = "okay";
+			phy = <&phy2>;
+			phy-mode = "rgmii-id";
+		};
+		ethernet at d0034000 {
+			status = "okay";
+			phy = <&phy3>;
+			phy-mode = "rgmii-id";
+		};
+	};
+};
Signature · 7 lines
1.7.9.5


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130131/3ecbb08e/attachment.sig>