USB chipidea i.MX: use framework phy handling

We now have usb_add_phy_dev(), so use it to register with the framework to be able to find the phy from the USB driver.

Signed-off-by Sascha Hauer <[email protected]>

---
  drivers/usb/otg/mxs-phy.c |    9 +++++++++
  1 file changed, 9 insertions(+)

drivers/usb/otg/mxs-phy.c +9 -0

index 5158332..5b39885 100644
@@ -127,6 +127,7 @@ static int mxs_phy_probe(struct platform_device *pdev)
  	void __iomem *base;
  	struct clk *clk;
  	struct mxs_phy *mxs_phy;
+	int ret;
 
  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
  	if (!res) {

@@ -166,11 +167,19 @@ static int mxs_phy_probe(struct platform_device *pdev)
 
  	platform_set_drvdata(pdev, &mxs_phy->phy);
 
+	ret = usb_add_phy_dev(&mxs_phy->phy);
+	if (ret)
+		return ret;
+
  	return 0;
  }
 
  static int mxs_phy_remove(struct platform_device *pdev)
  {
+	struct mxs_phy *mxs_phy = platform_get_drvdata(pdev);
+
+	usb_remove_phy(&mxs_phy->phy);
+
  	platform_set_drvdata(pdev, NULL);
 
  	return 0;

We now have usb_add_phy_dev(), so use it to register with the framework to be able to find the phy from the USB driver.

Signed-off-by Sascha Hauer <[email protected]>

---
 drivers/usb/otg/mxs-phy.c |    9 +++++++++
 1 file changed, 9 insertions(+)

drivers/usb/otg/mxs-phy.c +5 -0

index 5158332..5b39885 100644
@@ -127,6 +127,7 @@ static int mxs_phy_probe(struct platform_device *pdev)
 	void __iomem *base;
 	struct clk *clk;
 	struct mxs_phy *mxs_phy;
+	int ret;
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	if (!res) {

@@ -166,11 +167,19 @@ static int mxs_phy_probe(struct platform_device *pdev)
 
 	platform_set_drvdata(pdev, &mxs_phy->phy);
 
+	ret = usb_add_phy_dev(&mxs_phy->phy);
+	if (ret)
+		return ret;
+
 	return 0;
 }

We now have usb_add_phy_dev(), so use it to register with the framework to be able to find the phy from the USB driver.

Signed-off-by Sascha Hauer <[email protected]>

Hi,

Quoted 4 lines · Sascha Hauer

We now have usb_add_phy_dev(), so use it to register with the framework to be able to find the phy from the USB driver.

Signed-off-by Sascha Hauer <[email protected]>

Sascha, are you taking this through your tree or you want me to queue it up ?

Quoted 10 lines · Felipe Balbi

Hi,

Quoted 4 lines · Sascha Hauer

We now have usb_add_phy_dev(), so use it to register with the framework to be able to find the phy from the USB driver.

Signed-off-by Sascha Hauer <[email protected]>

Sascha, are you taking this through your tree or you want me to queue it up ?

I would prefer if either you could take it or Alexander Shishkin along with the other patches in:

[PATCH v4] USB: add devicetree helpers for determining dr_mode and phy_type

Could you have a look at them? Alexander is asking for an ack for 1/9, 2/9, 3/9, 8/9. I just realized you are not on Cc for these. I could bounce you the patches in case you don't have them in your mailbox.

Hi,

Quoted 17 lines · Sascha Hauer

Quoted 10 lines · Felipe Balbi

Hi,

Quoted 4 lines · Sascha Hauer

We now have usb_add_phy_dev(), so use it to register with the framework to be able to find the phy from the USB driver.

Signed-off-by Sascha Hauer <[email protected]>

Sascha, are you taking this through your tree or you want me to queue it up ?

I would prefer if either you could take it or Alexander Shishkin along with the other patches in:

[PATCH v4] USB: add devicetree helpers for determining dr_mode and phy_type

Quoted 3 lines

Could you have a look at them? Alexander is asking for an ack for 1/9, 2/9, 3/9, 8/9. I just realized you are not on Cc for these. I could bounce you the patches in case you don't have them in your mailbox.

Ok, I'll look at them, no need to bounce. You _do_ realize, however, that Greg has already closed all his trees for v3.9, right ? So anything from now on will be queued for v3.10.

Quoted 24 lines · Felipe Balbi

Hi,

Quoted 20 lines · Sascha Hauer

Quoted 10 lines · Felipe Balbi

Hi,

Quoted 4 lines · Sascha Hauer

We now have usb_add_phy_dev(), so use it to register with the framework to be able to find the phy from the USB driver.

Signed-off-by Sascha Hauer <[email protected]>

Sascha, are you taking this through your tree or you want me to queue it up ?

I would prefer if either you could take it or Alexander Shishkin along with the other patches in:

[PATCH v4] USB: add devicetree helpers for determining dr_mode and phy_type

Could you have a look at them? Alexander is asking for an ack for 1/9, 2/9, 3/9, 8/9. I just realized you are not on Cc for these. I could bounce you the patches in case you don't have them in your mailbox.

Quoted 3 lines

Ok, I'll look at them, no need to bounce. You _do_ realize, however, that Greg has already closed all his trees for v3.9, right ? So anything from now on will be queued for v3.10.

I'm fine with that. I'm just a bit insistent because the chipidea patches are floating around for half a year now. Once I have the warm feeling that the patches are handled I have time ;)

Quoted 29 lines · Sascha Hauer

Quoted 27 lines · Felipe Balbi

Hi,

Quoted 12 lines · Sascha Hauer

Quoted 10 lines · Felipe Balbi

Hi,

Quoted 4 lines · Sascha Hauer

We now have usb_add_phy_dev(), so use it to register with the framework to be able to find the phy from the USB driver.

Signed-off-by Sascha Hauer <[email protected]>

Sascha, are you taking this through your tree or you want me to queue it up ?

Quoted 8 lines

I would prefer if either you could take it or Alexander Shishkin along with the other patches in:

[PATCH v4] USB: add devicetree helpers for determining dr_mode and phy_type

Could you have a look at them? Alexander is asking for an ack for 1/9, 2/9, 3/9, 8/9. I just realized you are not on Cc for these. I could bounce you the patches in case you don't have them in your mailbox.

Ok, I'll look at them, no need to bounce. You _do_ realize, however, that Greg has already closed all his trees for v3.9, right ? So anything from now on will be queued for v3.10.

Quoted 3 lines

I'm fine with that. I'm just a bit insistent because the chipidea patches are floating around for half a year now. Once I have the warm feeling that the patches are handled I have time ;)

I'm getting ready to queue patches but, when looking at this thread, it seems like another version should've been sent. I'll skip this and look at the other chipidea threads,

Signed-off-by Sascha Hauer <[email protected]>

Hi,

Quoted 1 line · Sascha Hauer

Signed-off-by Sascha Hauer <[email protected]>

Some maintainers don't accept patches without a commit message.

Apart from that you can add,

Reviewed-by Kishon Vijay Abraham I <[email protected]>

Thanks
Kishon

This series switches the mxs phy and the i.MX chipidea support from homegrew phy support to use usb_add_phy_dev/devm_usb_get_phy_by_phandle.

Based on

[PATCH v2] Add USB of helpers and use them in the chipidea driver

But I think this could also be applied separately if necessary.

Quoted 5 lines · Sascha Hauer

This series switches the mxs phy and the i.MX chipidea support from homegrew phy support to use usb_add_phy_dev/devm_usb_get_phy_by_phandle.

Based on

Quoted 3 lines

[PATCH v2] Add USB of helpers and use them in the chipidea driver

But I think this could also be applied separately if necessary.

Kishon, Peter,

Thanks for reviewing these, but I'm afraid I must send another iteration for these. These patches do not handle -EPROBE_DEFER correctly.

Sascha

Signature · 4 lines

Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |