Skip to contentSkip to conversation

asmlinkage tag for sys_iopl

PATCH In review Artem Savkov 3 participants 6 messages Feb 3, 2013 – Feb 4, 2013 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 asmlinkage tag for sys_iopl

asmlinkage tag seems to be missing from sys_iopl prototype rendering iopl syscalls unusable, i.e. every call returns -EINVAL. Most likely introduced in 9e0b2428bc6a6c6df90bb701ca843820727cadf0.

---
 arch/x86/include/asm/syscalls.h | 2 +-
 arch/x86/kernel/ioport.c        | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/x86/include/asm/syscalls.h +1 -1
index 13f078c..6cf0a9c 100644
@@ -18,7 +18,7 @@
 /* Common in X86_32 and X86_64 */
 /* kernel/ioport.c */
 asmlinkage long sys_ioperm(unsigned long, unsigned long, int);
-long sys_iopl(unsigned int);
+asmlinkage long sys_iopl(unsigned int);
 
 /* kernel/ldt.c */
 asmlinkage int sys_modify_ldt(int, void __user *, unsigned long);
arch/x86/kernel/ioport.c +1 -1
index 5f98381..b1127a0 100644
@@ -93,7 +93,7 @@ asmlinkage long sys_ioperm(unsigned long from, unsigned long num, int turn_on)
  * on system-call entry - see also fork() and the signal handling
  * code.
  */
-long sys_iopl(unsigned int level)
+asmlinkage long sys_iopl(unsigned int level)
 {
 	struct pt_regs *regs = current_pt_regs();
 	unsigned int old = (regs->flags >> 12) & 3;
Signature · 1 line
1.8.1.1
#1 lore raw
Quoted 3 lines · Artem Savkov

asmlinkage tag seems to be missing from sys_iopl prototype rendering iopl syscalls unusable, i.e. every call returns -EINVAL. Most likely introduced in 9e0b2428bc6a6c6df90bb701ca843820727cadf0.

What commit is 9e0b2428bc6a6c6df90bb701ca843820727cadf0? It's certainly not upstream nor in the x86 tree.

Thanks,

Ingo

#2 lore raw
Quoted 9 lines · Ingo Molnar
Quoted 3 lines · Artem Savkov

asmlinkage tag seems to be missing from sys_iopl prototype rendering iopl syscalls unusable, i.e. every call returns -EINVAL. Most likely introduced in 9e0b2428bc6a6c6df90bb701ca843820727cadf0.

What commit is 9e0b2428bc6a6c6df90bb701ca843820727cadf0? It's certainly not upstream nor in the x86 tree.

It's in signal.git; proper fix is to use SYSCALL_DEFINE1(). I'll push it tonight.

#3 lore raw
Quoted 8 lines · Al Viro
Quoted 7 lines · Ingo Molnar
Quoted 3 lines · Artem Savkov

asmlinkage tag seems to be missing from sys_iopl prototype rendering iopl syscalls unusable, i.e. every call returns -EINVAL. Most likely introduced in 9e0b2428bc6a6c6df90bb701ca843820727cadf0.

Quoted 5 lines
Quoted 2 lines

What commit is 9e0b2428bc6a6c6df90bb701ca843820727cadf0? It's certainly not upstream nor in the x86 tree.

It's in signal.git; proper fix is to use SYSCALL_DEFINE1(). I'll push it tonight.

Thanks!

Ingo

#4 lore raw
In reply to Al Viro
Quoted 8 lines · Al Viro
Quoted 7 lines · Ingo Molnar
Quoted 3 lines · Artem Savkov

asmlinkage tag seems to be missing from sys_iopl prototype rendering iopl syscalls unusable, i.e. every call returns -EINVAL. Most likely introduced in 9e0b2428bc6a6c6df90bb701ca843820727cadf0.

Quoted 5 lines
Quoted 2 lines

What commit is 9e0b2428bc6a6c6df90bb701ca843820727cadf0? It's certainly not upstream nor in the x86 tree.

It's in signal.git; proper fix is to use SYSCALL_DEFINE1(). I'll push it tonight.

It is also in linux-next.git, so it would be nice to have a fix merged there too.
Thanks.

Signature · 2 lines
Kind regards,
Artem
#5 lore raw
Quoted 12 lines · Artem Savkov
Quoted 11 lines · Al Viro
Quoted 9 lines · Ingo Molnar
Quoted 3 lines · Artem Savkov

asmlinkage tag seems to be missing from sys_iopl prototype rendering iopl syscalls unusable, i.e. every call returns -EINVAL. Most likely introduced in 9e0b2428bc6a6c6df90bb701ca843820727cadf0.

What commit is 9e0b2428bc6a6c6df90bb701ca843820727cadf0? It's certainly not upstream nor in the x86 tree.

Quoted 6 lines
Quoted 2 lines

It's in signal.git; proper fix is to use SYSCALL_DEFINE1(). I'll push it tonight.

It is also in linux-next.git, so it would be nice to have a fix merged there too.
Thanks.

linux-next pulls signal.git, which is how that commit has appeared there in the first place...