Skip to contentSkip to conversation

idr: implement idr_alloc() and convert existing users

PATCH In review Tejun Heo 23 participants 129 messages Feb 3, 2013 – Mar 26, 2013 1 message not in the archive

Subsystems (56)
lore
Share & tools
lore

Tejun Heo

author maintainer
#0 lore raw

PATCH 1/1 idr: implement idr_alloc() and convert existing users

Hello,

* Andrew, I think this one is best routed through -mm together with the previous series. Please read on.

* Bruce, I couldn't convert nfsd. Can you please help? More on it later.

* Stanislav, Eric, James, can you please take a look at ipc/util.c conversion? I moved allocation inside ipc_addid(). I *think* it's correct but I'm not too familiar with the code.

* Jens, 0006 is fix for block layer regarding devt allocation. Given how long this has been broken unnoticed and how late we're in the release cycle, I think it would be better to route the fix with the rest and let it get backported through -stable later on.

Currently, idr interface is a pain in the ass to use. It has a mandatory pre-alloc mechanism which doesn't even guarantee the following allocation wouldn't fail from memory shortage requiring its users to loop on -EAGAIN. Also, there's no way to specify upper limit. Combined, a user who wants allocate an ID with upper limit ends up doing something like the following.

	do {
		if (!idr_pre_get(idr, GFP_KERNEL))
			return -ENOMEM;
		spin_lock(lock);
		ret = idr_get_new_above(idr, ptr, lower_limit, &id);
		if (!ret && id < upper_limit) {
			idr_remove(idr, id);
			ret = -ENOSPC;
		}
		spin_unlock(lock);
	} while (ret == -EAGAIN);

	if (ret)
		return ret;

which is just crazy. Preloading is also very inefficient - each idr ends up holding MAX_IDR_FREE idr_layers. Even on a fairly small machine (my x230) w/o anything too heavy going on, it ends up allocating over 1200 idr_layers with three quarters of them unused. This also makes it difficult to make each layer larger to reduce the depth of idr trees.

This patchset implements a new set of allocation interface for idr.

void idr_preload(gfp_t gfp_mask);
void idr_preload_end(void);
int idr_alloc(struct idr *idr, void *ptr, int start, int end, gfp_t gfp_mask);

idr_alloc() can be used w/o preloading if permissive enough @gfp_mask can be used directly. If not, preloading, which uses per-cpu layer buffer, can be used. Note that idr_preload() doesn't fail. It simply guarnatees that the following idr_alloc() would behave as if it were called with @gfp_mask specified at preloading time. The above example with the old interface would become the following using the new interface.

	idr_preload(GFP_KERNEL);
	spin_lock(lock);

	id = idr_alloc(idr, ptr, lower_limit, upper_limit, GFP_NOWAIT);

	spin_unlock(lock);
	idr_preload_end();
	if (id < 0)
		return id;

Which is simpler and less error-prone. Also, there are many cases where preloading isn't necessary (e.g. the section is protected by outer mutex). For those, idr_alloc() can be used by itself.

	id = idr_alloc(idr, ptr, lower_limit, upper_limit, GFP_KERNEL);
	if (id < 0)
		return id;

I converted all in-kernel users except nfsd and staging drivers. nfsd splits preloading and actual id allocation in a way that per-cpu preloading can't be used. I couldn't follow the control flow to verify whether the current code is correct either. I think the best way would be allocating ID upfront without installing the handle and then later using idr_replace() to install the pointer when the ID actually gets used. Bruce, would something like that be possible?

This patchset contains the following 62 patches.

0001-idr-cosmetic-updates-to-struct-initializer-definitio.patch 0002-idr-relocate-idr_for_each_entry-and-reorganize-id-r-.patch 0003-idr-remove-_idr_rc_to_errno-hack.patch 0004-idr-refactor-idr_get_new_above.patch 0005-idr-implement-idr_preload-_end-and-idr_alloc.patch 0006-block-fix-synchronization-and-limit-check-in-blk_all.patch 0007-block-convert-to-idr_alloc.patch 0008-block-loop-convert-to-idr_alloc.patch 0009-atm-nicstar-convert-to-idr_alloc.patch 0010-drbd-convert-to-idr_alloc.patch 0011-dca-convert-to-idr_alloc.patch 0012-dmaengine-convert-to-idr_alloc.patch 0013-firewire-convert-to-idr_alloc.patch 0014-gpio-convert-to-idr_alloc.patch 0015-drm-convert-to-idr_alloc.patch 0016-drm-exynos-convert-to-idr_alloc.patch 0017-drm-i915-convert-to-idr_alloc.patch 0018-drm-sis-convert-to-idr_alloc.patch 0019-drm-via-convert-to-idr_alloc.patch 0020-drm-vmwgfx-convert-to-idr_alloc.patch 0021-i2c-convert-to-idr_alloc.patch 0022-infiniband-core-convert-to-idr_alloc.patch 0023-infiniband-amso1100-convert-to-idr_alloc.patch 0024-infiniband-cxgb3-convert-to-idr_alloc.patch 0025-infiniband-cxgb4-convert-to-idr_alloc.patch 0026-infiniband-ehca-convert-to-idr_alloc.patch 0027-infiniband-ipath-convert-to-idr_alloc.patch 0028-infiniband-mlx4-convert-to-idr_alloc.patch 0029-infiniband-ocrdma-convert-to-idr_alloc.patch 0030-infiniband-qib-convert-to-idr_alloc.patch 0031-dm-convert-to-idr_alloc.patch 0032-memstick-convert-to-idr_alloc.patch 0033-mfd-convert-to-idr_alloc.patch 0034-misc-c2port-convert-to-idr_alloc.patch 0035-misc-tifm_core-convert-to-idr_alloc.patch 0036-mmc-convert-to-idr_alloc.patch 0037-mtd-convert-to-idr_alloc.patch 0038-i2c-convert-to-idr_alloc.patch 0039-ppp-convert-to-idr_alloc.patch 0040-power-convert-to-idr_alloc.patch 0041-pps-convert-to-idr_alloc.patch 0042-remoteproc-convert-to-idr_alloc.patch 0043-rpmsg-convert-to-idr_alloc.patch 0044-scsi-bfa-convert-to-idr_alloc.patch 0045-scsi-convert-to-idr_alloc.patch 0046-target-iscsi-convert-to-idr_alloc.patch 0047-scsi-lpfc-convert-to-idr_alloc.patch 0048-thermal-convert-to-idr_alloc.patch 0049-uio-convert-to-idr_alloc.patch 0050-vfio-convert-to-idr_alloc.patch 0051-dlm-convert-to-idr_alloc.patch 0052-inotify-convert-to-idr_alloc.patch 0053-ocfs2-convert-to-idr_alloc.patch 0054-ipc-convert-to-idr_alloc.patch 0055-cgroup-convert-to-idr_alloc.patch 0056-events-convert-to-idr_alloc.patch 0057-posix-timers-convert-to-idr_alloc.patch 0058-net-9p-convert-to-idr_alloc.patch 0059-mac80211-convert-to-idr_alloc.patch 0060-sctp-convert-to-idr_alloc.patch 0061-nfs4client-convert-to-idr_alloc.patch 0062-idr-deprecate-idr_pre_get-and-idr_get_new-_above.patch

0001-0005 implement the new idr interface. 0006 is idr related block fix. 0007-0061 convert in-kernel users to idr_alloc(). 0062 marks the old interface deprecated (note that this makes nfsd compilation generates warning).

While I tried to be careful and reviewed the whole series a couple times, my test coverage is unavoidably quite limited. I don't think fallouts would be too difficult to spot during testing.

This patchset is on top of

[1] [PATCH] idr: fix a subtle bug in idr_get_next()
+ [2] [PATCHSET] idr: deprecate idr_remove_all()

and available in the following git branch.

git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git convert-to-idr_alloc

Excluding idr.[hc], which should become smaller once we remove the old interface, this conversion sheds 482 lines across the kernel. diffstat follows.

 block/bsg.c                                |   26 --
 block/genhd.c                              |   22 --
 drivers/atm/nicstar.c                      |   27 +-
 drivers/block/drbd/drbd_main.c             |   29 +-
 drivers/block/loop.c                       |   23 --
 drivers/dca/dca-sysfs.c                    |   23 --
 drivers/dma/dmaengine.c                    |   16 -
 drivers/firewire/core-cdev.c               |   16 -
 drivers/firewire/core-device.c             |    5 
 drivers/gpio/gpiolib.c                     |   11 -
 drivers/gpu/drm/drm_context.c              |   17 -
 drivers/gpu/drm/drm_crtc.c                 |   15 -
 drivers/gpu/drm/drm_gem.c                  |   35 +--
 drivers/gpu/drm/drm_stub.c                 |   19 -
 drivers/gpu/drm/exynos/exynos_drm_ipp.c    |   16 -
 drivers/gpu/drm/i915/i915_gem_context.c    |   21 --
 drivers/gpu/drm/sis/sis_mm.c               |   13 -
 drivers/gpu/drm/via/via_mm.c               |   13 -
 drivers/gpu/drm/vmwgfx/vmwgfx_resource.c   |   17 -
 drivers/i2c/i2c-core.c                     |   45 ----
 drivers/infiniband/core/cm.c               |   22 +-
 drivers/infiniband/core/cma.c              |   24 --
 drivers/infiniband/core/sa_query.c         |   15 -
 drivers/infiniband/core/ucm.c              |   16 -
 drivers/infiniband/core/ucma.c             |   32 ---
 drivers/infiniband/core/uverbs_cmd.c       |   17 -
 drivers/infiniband/hw/amso1100/c2_qp.c     |   19 +
 drivers/infiniband/hw/cxgb3/iwch.h         |   24 +-
 drivers/infiniband/hw/cxgb4/iw_cxgb4.h     |   27 +-
 drivers/infiniband/hw/ehca/ehca_cq.c       |   27 --
 drivers/infiniband/hw/ehca/ehca_qp.c       |   34 +--
 drivers/infiniband/hw/ipath/ipath_driver.c |   16 -
 drivers/infiniband/hw/mlx4/cm.c            |   32 +--
 drivers/infiniband/hw/ocrdma/ocrdma_main.c |   14 -
 drivers/infiniband/hw/qib/qib_init.c       |   21 --
 drivers/md/dm.c                            |   54 +----
 drivers/memstick/core/memstick.c           |   21 --
 drivers/memstick/core/mspro_block.c        |   17 -
 drivers/mfd/rtsx_pcr.c                     |   13 -
 drivers/misc/c2port/core.c                 |   22 --
 drivers/misc/tifm_core.c                   |   11 -
 drivers/mmc/core/host.c                    |   11 -
 drivers/mtd/mtdcore.c                      |    9 
 drivers/net/macvtap.c                      |   21 --
 drivers/net/ppp/ppp_generic.c              |   33 ---
 drivers/power/bq2415x_charger.c            |   11 -
 drivers/power/bq27x00_battery.c            |    9 
 drivers/power/ds2782_battery.c             |    9 
 drivers/pps/kapi.c                         |    2 
 drivers/pps/pps.c                          |   36 +--
 drivers/remoteproc/remoteproc_core.c       |   10 
 drivers/rpmsg/virtio_rpmsg_bus.c           |   30 +-
 drivers/scsi/bfa/bfad_im.c                 |   15 -
 drivers/scsi/ch.c                          |   21 --
 drivers/scsi/lpfc/lpfc_init.c              |   12 -
 drivers/scsi/sg.c                          |   43 +---
 drivers/scsi/st.c                          |   27 --
 drivers/target/iscsi/iscsi_target.c        |   15 -
 drivers/target/iscsi/iscsi_target_login.c  |   15 -
 drivers/thermal/cpu_cooling.c              |   17 -
 drivers/thermal/thermal_sys.c              |   17 -
 drivers/uio/uio.c                          |   19 -
 drivers/vfio/vfio.c                        |   18 -
 fs/dlm/lock.c                              |   18 -
 fs/dlm/recover.c                           |   27 +-
 fs/nfs/nfs4client.c                        |   13 -
 fs/notify/inotify/inotify_user.c           |   24 +-
 fs/ocfs2/cluster/tcp.c                     |   32 +--
 include/linux/idr.h                        |  135 +++++++++----
 ipc/util.c                                 |   30 --
 kernel/cgroup.c                            |   27 --
 kernel/events/core.c                       |   10 
 kernel/posix-timers.c                      |   18 -
 lib/idr.c                                  |  291 ++++++++++++++++++-----------
 net/9p/util.c                              |   17 -
 net/mac80211/main.c                        |    2 
 net/mac80211/tx.c                          |   18 -
 net/sctp/associola.c                       |   27 +-
 78 files changed, 816 insertions(+), 1160 deletions(-)

--
tejun

[1] https://lkml.org/lkml/2013/2/2/145
[2] https://lkml.org/lkml/2013/1/25/759

author maintainer
#1 lore raw

PATCH 1/62 idr: cosmetic updates to struct / initializer definitions

* Tab align fields like a normal person.

* Drop the unnecessary 0 inits from IDR_INIT().

This patch is purely cosmetic.

---
 include/linux/idr.h | 28 ++++++++++++----------------
 1 file changed, 12 insertions(+), 16 deletions(-)
include/linux/idr.h +12 -16
index 1b932e7..c78c26d 100644
@@ -49,28 +49,24 @@
 #define MAX_IDR_FREE (MAX_IDR_LEVEL * 2)
 
 struct idr_layer {
-	unsigned long		 bitmap; /* A zero bit means "space here" */
+	unsigned long		bitmap;	/* A zero bit means "space here" */
 	struct idr_layer __rcu	*ary[1<<IDR_BITS];
-	int			 count;	 /* When zero, we can release it */
-	int			 layer;	 /* distance from leaf */
-	struct rcu_head		 rcu_head;
+	int			count;	/* When zero, we can release it */
+	int			layer;	/* distance from leaf */
+	struct rcu_head		rcu_head;
 };
 
 struct idr {
-	struct idr_layer __rcu *top;
-	struct idr_layer *id_free;
-	int		  layers; /* only valid without concurrent changes */
-	int		  id_free_cnt;
-	spinlock_t	  lock;
+	struct idr_layer __rcu	*top;
+	struct idr_layer	*id_free;
+	int			layers;	/* only valid w/o concurrent changes */
+	int			id_free_cnt;
+	spinlock_t		lock;
 };
 
-#define IDR_INIT(name)						\
-{								\
-	.top		= NULL,					\
-	.id_free	= NULL,					\
-	.layers 	= 0,					\
-	.id_free_cnt	= 0,					\
-	.lock		= __SPIN_LOCK_UNLOCKED(name.lock),	\
+#define IDR_INIT(name)							\
+{									\
+	.lock			= __SPIN_LOCK_UNLOCKED(name.lock),	\
 }
 #define DEFINE_IDR(name)	struct idr name = IDR_INIT(name)
 
Signature · 1 line
1.8.1
author maintainer
#2 lore raw

PATCH 2/62 idr: relocate idr_for_each_entry() and reorganize id[r|a]_get_new()

In reply to Tejun Heo

* Move idr_for_each_entry() definition next to other idr related definitions.

* Make id[r|a]_get_new() inline wrappers of id[r|a]_get_new_above().

This changes the implementation of idr_get_new() but the new implementation is trivial. This patch doesn't introduce any functional change.

---
 include/linux/idr.h | 47 +++++++++++++++++++++++++++++++++++------------
 lib/idr.c           | 49 -------------------------------------------------
 2 files changed, 35 insertions(+), 61 deletions(-)
include/linux/idr.h +35 -12
index c78c26d..7c0700c 100644
@@ -99,7 +99,6 @@ struct idr {
 
 void *idr_find(struct idr *idp, int id);
 int idr_pre_get(struct idr *idp, gfp_t gfp_mask);
-int idr_get_new(struct idr *idp, void *ptr, int *id);
 int idr_get_new_above(struct idr *idp, void *ptr, int starting_id, int *id);
 int idr_for_each(struct idr *idp,
 		 int (*fn)(int id, void *p, void *data), void *data);
@@ -109,6 +108,30 @@ void idr_remove(struct idr *idp, int id);
 void idr_destroy(struct idr *idp);
 void idr_init(struct idr *idp);
 
+/**
+ * idr_get_new - allocate new idr entry
+ * @idp: idr handle
+ * @ptr: pointer you want associated with the id
+ * @id: pointer to the allocated handle
+ *
+ * Simple wrapper around idr_get_new_above() w/ @starting_id of zero.
+ */
+static inline int idr_get_new(struct idr *idp, void *ptr, int *id)
+{
+	return idr_get_new_above(idp, ptr, 0, id);
+}
+
+/**
+ * idr_for_each_entry - iterate over an idr's elements of a given type
+ * @idp:     idr handle
+ * @entry:   the type * to use as cursor
+ * @id:      id entry's key
+ */
+#define idr_for_each_entry(idp, entry, id)				\
+	for (id = 0, entry = (typeof(entry))idr_get_next((idp), &(id)); \
+	     entry != NULL;                                             \
+	     ++id, entry = (typeof(entry))idr_get_next((idp), &(id)))
+
 void __idr_remove_all(struct idr *idp);	/* don't use */
 
 /**
@@ -149,7 +172,6 @@ struct ida {
 
 int ida_pre_get(struct ida *ida, gfp_t gfp_mask);
 int ida_get_new_above(struct ida *ida, int starting_id, int *p_id);
-int ida_get_new(struct ida *ida, int *p_id);
 void ida_remove(struct ida *ida, int id);
 void ida_destroy(struct ida *ida);
 void ida_init(struct ida *ida);
@@ -158,17 +180,18 @@ int ida_simple_get(struct ida *ida, unsigned int start, unsigned int end,
 		   gfp_t gfp_mask);
 void ida_simple_remove(struct ida *ida, unsigned int id);
 
-void __init idr_init_cache(void);
-
 /**
- * idr_for_each_entry - iterate over an idr's elements of a given type
- * @idp:     idr handle
- * @entry:   the type * to use as cursor
- * @id:      id entry's key
+ * ida_get_new - allocate new ID
+ * @ida:	idr handle
+ * @p_id:	pointer to the allocated handle
+ *
+ * Simple wrapper around ida_get_new_above() w/ @starting_id of zero.
  */
-#define idr_for_each_entry(idp, entry, id)				\
-	for (id = 0, entry = (typeof(entry))idr_get_next((idp), &(id)); \
-	     entry != NULL;                                             \
-	     ++id, entry = (typeof(entry))idr_get_next((idp), &(id)))
+static inline int ida_get_new(struct ida *ida, int *p_id)
+{
+	return ida_get_new_above(ida, 0, p_id);
+}
+
+void __init idr_init_cache(void);
 
 #endif /* __IDR_H__ */
lib/idr.c +0 -49

61 lines not on this page · raw message

Signature · 1 line
1.8.1
author maintainer
#3 lore raw

PATCH 3/62 idr: remove _idr_rc_to_errno() hack

In reply to Tejun Heo

idr uses -1, IDR_NEED_TO_GROW and IDR_NOMORE_SPACE to communicate exception conditions internally. The return value is later translated to errno values using _idr_rc_to_errno().

This is confusing. Drop the custom ones and consistently use -EAGAIN for "tree needs to grow", -ENOMEM for "need more memory" and -ENOSPC for "ran out of ID space".

Due to the weird memory preloading mechanism, [ra]_get_new*() return -EAGAIN on memory shortage, so we need to substitute -ENOMEM w/ -EAGAIN on those interface functions. They'll eventually be cleaned up and the translations will go away.

This patch doesn't introduce any functional changes.

---
 include/linux/idr.h |  6 ------
 lib/idr.c           | 35 +++++++++++++++++++++++------------
 2 files changed, 23 insertions(+), 18 deletions(-)
include/linux/idr.h +0 -6
index 7c0700c..92e84f7 100644
@@ -70,12 +70,6 @@ struct idr {
 }
 #define DEFINE_IDR(name)	struct idr name = IDR_INIT(name)
 
-/* Actions to be taken after a call to _idr_sub_alloc */
-#define IDR_NEED_TO_GROW -2
-#define IDR_NOMORE_SPACE -3
-
-#define _idr_rc_to_errno(rc) ((rc) == -1 ? -EAGAIN : -ENOSPC)
-
 /**
  * DOC: idr sync
  * idr synchronization (stolen from radix-tree.h)
lib/idr.c +23 -12
index 282841b..bde6eec 100644
@@ -133,6 +133,21 @@ int idr_pre_get(struct idr *idp, gfp_t gfp_mask)
 }
 EXPORT_SYMBOL(idr_pre_get);
 
+/**
+ * sub_alloc - try to allocate an id without growing the tree depth
+ * @idp: idr handle
+ * @starting_id: id to start search at
+ * @id: pointer to the allocated handle
+ * @pa: idr_layer[MAX_IDR_LEVEL] used as backtrack buffer
+ *
+ * Allocate an id in range [@starting_id, INT_MAX] from @idp without
+ * growing its depth.  Returns
+ *
+ *  the allocated id >= 0 if successful,
+ *  -EAGAIN if the tree needs to grow for allocation to succeed,
+ *  -ENOSPC if the id space is exhausted,
+ *  -ENOMEM if more idr_layers need to be allocated.
+ */
 static int sub_alloc(struct idr *idp, int *starting_id, struct idr_layer **pa)
 {
 	int n, m, sh;
@@ -161,7 +176,7 @@ static int sub_alloc(struct idr *idp, int *starting_id, struct idr_layer **pa)
 			/* if already at the top layer, we need to grow */
 			if (id >= 1 << (idp->layers * IDR_BITS)) {
 				*starting_id = id;
-				return IDR_NEED_TO_GROW;
+				return -EAGAIN;
 			}
 			p = pa[l];
 			BUG_ON(!p);
@@ -180,7 +195,7 @@ static int sub_alloc(struct idr *idp, int *starting_id, struct idr_layer **pa)
 			id = ((id >> sh) ^ n ^ m) << sh;
 		}
 		if ((id >= MAX_IDR_BIT) || (id < 0))
-			return IDR_NOMORE_SPACE;
+			return -ENOSPC;
 		if (l == 0)
 			break;
 		/*
@@ -189,7 +204,7 @@ static int sub_alloc(struct idr *idp, int *starting_id, struct idr_layer **pa)
 		if (!p->ary[m]) {
 			new = get_from_free_list(idp);
 			if (!new)
-				return -1;
+				return -ENOMEM;
 			new->layer = l-1;
 			rcu_assign_pointer(p->ary[m], new);
 			p->count++;
@@ -215,7 +230,7 @@ build_up:
 	layers = idp->layers;
 	if (unlikely(!p)) {
 		if (!(p = get_from_free_list(idp)))
-			return -1;
+			return -ENOMEM;
 		p->layer = 0;
 		layers = 1;
 	}
@@ -246,7 +261,7 @@ build_up:
 				__move_to_free_list(idp, new);
 			}
 			spin_unlock_irqrestore(&idp->lock, flags);
-			return -1;
+			return -ENOMEM;
 		}
 		new->ary[0] = p;
 		new->count = 1;
@@ -258,7 +273,7 @@ build_up:
 	rcu_assign_pointer(idp->top, p);
 	idp->layers = layers;
 	v = sub_alloc(idp, &id, pa);
-	if (v == IDR_NEED_TO_GROW)
+	if (v == -EAGAIN)
 		goto build_up;
 	return(v);
 }
@@ -306,12 +321,8 @@ int idr_get_new_above(struct idr *idp, void *ptr, int starting_id, int *id)
 	int rv;
 
 	rv = idr_get_new_above_int(idp, ptr, starting_id);
-	/*
-	 * This is a cheap hack until the IDR code can be fixed to
-	 * return proper error values.
-	 */
 	if (rv < 0)
-		return _idr_rc_to_errno(rv);
+		return rv == -ENOMEM ? -EAGAIN : rv;
 	*id = rv;
 	return 0;
 }
@@ -766,7 +777,7 @@ int ida_get_new_above(struct ida *ida, int starting_id, int *p_id)
 	/* get vacant slot */
 	t = idr_get_empty_slot(&ida->idr, idr_id, pa);
 	if (t < 0)
-		return _idr_rc_to_errno(t);
+		return t == -ENOMEM ? -EAGAIN : t;
 
 	if (t * IDA_BITMAP_BITS >= MAX_IDR_BIT)
 		return -ENOSPC;
Signature · 1 line
1.8.1
author maintainer
#4 lore raw

PATCH 4/62 idr: refactor idr_get_new_above()

In reply to Tejun Heo

Move slot filling to idr_fill_slot() from idr_get_new_above_int() and make idr_get_new_above() directly call it. idr_get_new_above_int() is no longer needed and removed.

This will be used to implement a new ID allocation interface.

---
 lib/idr.c | 30 ++++++++++++------------------
 1 file changed, 12 insertions(+), 18 deletions(-)
lib/idr.c +12 -18
index bde6eec..b13aae5 100644
@@ -278,24 +278,15 @@ build_up:
 	return(v);
 }
 
-static int idr_get_new_above_int(struct idr *idp, void *ptr, int starting_id)
+/*
+ * @id and @pa are from a successful allocation from idr_get_empty_slot().
+ * Install the user pointer @ptr and mark the slot full.
+ */
+static void idr_fill_slot(void *ptr, int id, struct idr_layer **pa)
 {
-	struct idr_layer *pa[MAX_IDR_LEVEL];
-	int id;
-
-	id = idr_get_empty_slot(idp, starting_id, pa);
-	if (id >= 0) {
-		/*
-		 * Successfully found an empty slot.  Install the user
-		 * pointer and mark the slot full.
-		 */
-		rcu_assign_pointer(pa[0]->ary[id & IDR_MASK],
-				(struct idr_layer *)ptr);
-		pa[0]->count++;
-		idr_mark_full(pa, id);
-	}
-
-	return id;
+	rcu_assign_pointer(pa[0]->ary[id & IDR_MASK], (struct idr_layer *)ptr);
+	pa[0]->count++;
+	idr_mark_full(pa, id);
 }
 
 /**
@@ -318,11 +309,14 @@ static int idr_get_new_above_int(struct idr *idp, void *ptr, int starting_id)
  */
 int idr_get_new_above(struct idr *idp, void *ptr, int starting_id, int *id)
 {
+	struct idr_layer *pa[MAX_IDR_LEVEL];
 	int rv;
 
-	rv = idr_get_new_above_int(idp, ptr, starting_id);
+	rv = idr_get_empty_slot(idp, starting_id, pa);
 	if (rv < 0)
 		return rv == -ENOMEM ? -EAGAIN : rv;
+
+	idr_fill_slot(ptr, rv, pa);
 	*id = rv;
 	return 0;
 }
Signature · 1 line
1.8.1
author maintainer
#5 lore raw

PATCH 5/62 idr: implement idr_preload[_end]() and idr_alloc()

In reply to Tejun Heo

The current idr interface is very cumbersome.

* For all allocations, two function calls - idr_pre_get() and idr_get_new*() - should be made.

* idr_pre_get() doesn't guarantee that the following idr_get_new*() will not fail from memory shortage. If idr_get_new*() returns -EAGAIN, the caller is expected to retry pre_get and allocation.

* idr_get_new*() can't enforce upper limit. Upper limit can only be enforced by allocating and then freeing if above limit.

* idr_layer buffer is unnecessarily per-idr. Each idr ends up keeping around MAX_IDR_FREE idr_layers. The memory consumed per idr is under two pages but it makes it difficult to make idr_layer larger.

This patch implements the following new set of allocation functions.

* idr_preload[_end]() - Similar to radix preload but doesn't fail. The first idr_alloc() inside preload section can be treated as if it were called with @gfp_mask used for idr_preload().

* idr_alloc() - Allocate an ID w/ lower and upper limits. Takes @gfp_flags and can be used w/o preloading. When used inside preloaded section, the allocation mask of preloading can be assumed.

If idr_alloc() can be called from a context which allows sufficiently relaxed @gfp_mask, it can be used by itself. If, for example, idr_alloc() is called inside spinlock protected region, preloading can be used like the following.

	idr_preload(GFP_KERNEL);
	spin_lock(lock);

	id = idr_alloc(idr, ptr, start, end, GFP_NOWAIT);

	spin_unlock(lock);
	idr_preload_end();
	if (id < 0)
		error;

which is much simpler and less error-prone than idr_pre_get and idr_get_new*() loop.

The new interface uses per-pcu idr_layer buffer and thus the number of idr's in the system doesn't affect the amount of memory used for preloading.

idr_layer_alloc() is introduced to handle idr_layer allocations for both old and new ID allocation paths. This is a bit hairy now but the new interface is expected to replace the old and the internal implementation eventually will become simpler.

Cc Rusty Russell <[email protected]>
---
 include/linux/idr.h |  14 +++++
 lib/idr.c           | 168 +++++++++++++++++++++++++++++++++++++++++++++++++---
 2 files changed, 174 insertions(+), 8 deletions(-)
include/linux/idr.h +14 -0
index 92e84f7..8d3ffe1 100644
@@ -94,15 +94,29 @@ struct idr {
 void *idr_find(struct idr *idp, int id);
 int idr_pre_get(struct idr *idp, gfp_t gfp_mask);
 int idr_get_new_above(struct idr *idp, void *ptr, int starting_id, int *id);
+void idr_preload(gfp_t gfp_mask);
+int idr_alloc(struct idr *idp, void *ptr, int start, int end, gfp_t gfp_mask);
 int idr_for_each(struct idr *idp,
 		 int (*fn)(int id, void *p, void *data), void *data);
 void *idr_get_next(struct idr *idp, int *nextid);
 void *idr_replace(struct idr *idp, void *ptr, int id);
 void idr_remove(struct idr *idp, int id);
+void idr_free(struct idr *idp, int id);
 void idr_destroy(struct idr *idp);
 void idr_init(struct idr *idp);
 
 /**
+ * idr_preload_end - end preload section started with idr_preload()
+ *
+ * Each idr_preload() should be matched with an invocation of this
+ * function.  See idr_preload() for details.
+ */
+static inline void idr_preload_end(void)
+{
+	preempt_enable();
+}
+
+/**
  * idr_get_new - allocate new idr entry
  * @idp: idr handle
  * @ptr: pointer you want associated with the id
lib/idr.c +160 -8

242 lines not on this page · raw message

Signature · 1 line
1.8.1
author maintainer
#6 lore raw

PATCH v2 5/62 idr: implement idr_preload[_end]() and idr_alloc()

The current idr interface is very cumbersome.

* For all allocations, two function calls - idr_pre_get() and idr_get_new*() - should be made.

* idr_pre_get() doesn't guarantee that the following idr_get_new*() will not fail from memory shortage. If idr_get_new*() returns -EAGAIN, the caller is expected to retry pre_get and allocation.

* idr_get_new*() can't enforce upper limit. Upper limit can only be enforced by allocating and then freeing if above limit.

* idr_layer buffer is unnecessarily per-idr. Each idr ends up keeping around MAX_IDR_FREE idr_layers. The memory consumed per idr is under two pages but it makes it difficult to make idr_layer larger.

This patch implements the following new set of allocation functions.

* idr_preload[_end]() - Similar to radix preload but doesn't fail. The first idr_alloc() inside preload section can be treated as if it were called with @gfp_mask used for idr_preload().

* idr_alloc() - Allocate an ID w/ lower and upper limits. Takes @gfp_flags and can be used w/o preloading. When used inside preloaded section, the allocation mask of preloading can be assumed.

If idr_alloc() can be called from a context which allows sufficiently relaxed @gfp_mask, it can be used by itself. If, for example, idr_alloc() is called inside spinlock protected region, preloading can be used like the following.

	idr_preload(GFP_KERNEL);
	spin_lock(lock);

	id = idr_alloc(idr, ptr, start, end, GFP_NOWAIT);

	spin_unlock(lock);
	idr_preload_end();
	if (id < 0)
		error;

which is much simpler and less error-prone than idr_pre_get and idr_get_new*() loop.

The new interface uses per-pcu idr_layer buffer and thus the number of idr's in the system doesn't affect the amount of memory used for preloading.

idr_layer_alloc() is introduced to handle idr_layer allocations for both old and new ID allocation paths. This is a bit hairy now but the new interface is expected to replace the old and the internal implementation eventually will become simpler.

v2: Improve idr_preload() comment a bit so that it's clear that
preemption is disabled while preloaded. Make idr_layer_alloc() try kmem_cache first and then fall back to per-cpu buffer; otherwise, non-preloading idr_alloc()s empty per-cpu buffers makeing preloaders fill them, which, while not incorrect, still is a bit unfair.

Cc Rusty Russell <[email protected]>
---
 include/linux/idr.h |   14 ++++
 lib/idr.c           |  171 +++++++++++++++++++++++++++++++++++++++++++++++++---
 2 files changed, 177 insertions(+), 8 deletions(-)
include/linux/idr.h +14 -0
@@ -94,15 +94,29 @@ struct idr {
 void *idr_find(struct idr *idp, int id);
 int idr_pre_get(struct idr *idp, gfp_t gfp_mask);
 int idr_get_new_above(struct idr *idp, void *ptr, int starting_id, int *id);
+void idr_preload(gfp_t gfp_mask);
+int idr_alloc(struct idr *idp, void *ptr, int start, int end, gfp_t gfp_mask);
 int idr_for_each(struct idr *idp,
 		 int (*fn)(int id, void *p, void *data), void *data);
 void *idr_get_next(struct idr *idp, int *nextid);
 void *idr_replace(struct idr *idp, void *ptr, int id);
 void idr_remove(struct idr *idp, int id);
+void idr_free(struct idr *idp, int id);
 void idr_destroy(struct idr *idp);
 void idr_init(struct idr *idp);
 
 /**
+ * idr_preload_end - end preload section started with idr_preload()
+ *
+ * Each idr_preload() should be matched with an invocation of this
+ * function.  See idr_preload() for details.
+ */
+static inline void idr_preload_end(void)
+{
+	preempt_enable();
+}
+
+/**
  * idr_get_new - allocate new idr entry
  * @idp: idr handle
  * @ptr: pointer you want associated with the id
lib/idr.c +163 -8

245 lines not on this page · raw message

author maintainer
#7 lore raw

PATCH 6/62 block: fix synchronization and limit check in blk_alloc_devt()

In reply to Tejun Heo

idr allocation in blk_alloc_devt() wasn't synchronized against lookup and removal, and its limit check was off by one - 1 << MINORBITS is the number of minors allowed, not the maximum allowed minor.

Add locking and rename MAX_EXT_DEVT to NR_EXT_DEVT and fix limit checking.

---
 block/genhd.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)
block/genhd.c +7 -6
index 9a289d7..49abda1 100644
@@ -25,7 +25,7 @@ static DEFINE_MUTEX(block_class_lock);
 struct kobject *block_depr;
 
 /* for extended dynamic devt allocation, currently only one major is used */
-#define MAX_EXT_DEVT		(1 << MINORBITS)
+#define NR_EXT_DEVT		(1 << MINORBITS)
 
 /* For extended devt allocation.  ext_devt_mutex prevents look up
  * results from going away underneath its user.
@@ -420,17 +420,18 @@ int blk_alloc_devt(struct hd_struct *part, dev_t *devt)
 	do {
 		if (!idr_pre_get(&ext_devt_idr, GFP_KERNEL))
 			return -ENOMEM;
+		mutex_lock(&ext_devt_mutex);
 		rc = idr_get_new(&ext_devt_idr, part, &idx);
+		if (!rc && idx >= NR_EXT_DEVT) {
+			idr_remove(&ext_devt_idr, idx);
+			rc = -EBUSY;
+		}
+		mutex_unlock(&ext_devt_mutex);
 	} while (rc == -EAGAIN);
 
 	if (rc)
 		return rc;
 
-	if (idx > MAX_EXT_DEVT) {
-		idr_remove(&ext_devt_idr, idx);
-		return -EBUSY;
-	}
-
 	*devt = MKDEV(BLOCK_EXT_MAJOR, blk_mangle_minor(idx));
 	return 0;
 }
Signature · 1 line
1.8.1
maintainer Acked-by on v1 6/62
#8 lore raw

Re: [PATCH 06/62] block: fix synchronization and limit check in blk_alloc_devt()

Quoted 10 lines · Tejun Heo

idr allocation in blk_alloc_devt() wasn't synchronized against lookup and removal, and its limit check was off by one - 1 << MINORBITS is the number of minors allowed, not the maximum allowed minor.

Add locking and rename MAX_EXT_DEVT to NR_EXT_DEVT and fix limit checking.

Signature · 1 line
Jens Axboe
author maintainer
#9 lore raw

PATCH 7/62 block: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface. Both bsg and genhd protect idr w/ mutex making preloading unnecessary.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 block/bsg.c   | 26 +++++++++-----------------
 block/genhd.c | 21 ++++++---------------
 2 files changed, 15 insertions(+), 32 deletions(-)
block/bsg.c +9 -17
index ff64ae3..3ca92eb 100644
@@ -997,7 +997,7 @@ int bsg_register_queue(struct request_queue *q, struct device *parent,
 {
 	struct bsg_class_device *bcd;
 	dev_t dev;
-	int ret, minor;
+	int ret;
 	struct device *class_dev = NULL;
 	const char *devname;
 
@@ -1017,23 +1017,16 @@ int bsg_register_queue(struct request_queue *q, struct device *parent,
 
 	mutex_lock(&bsg_mutex);
 
-	ret = idr_pre_get(&bsg_minor_idr, GFP_KERNEL);
-	if (!ret) {
-		ret = -ENOMEM;
-		goto unlock;
-	}
-
-	ret = idr_get_new(&bsg_minor_idr, bcd, &minor);
-	if (ret < 0)
+	ret = idr_alloc(&bsg_minor_idr, bcd, 0, BSG_MAX_DEVS, GFP_KERNEL);
+	if (ret < 0) {
+		if (ret == -ENOSPC) {
+			printk(KERN_ERR "bsg: too many bsg devices\n");
+			ret = -EINVAL;
+		}
 		goto unlock;
-
-	if (minor >= BSG_MAX_DEVS) {
-		printk(KERN_ERR "bsg: too many bsg devices\n");
-		ret = -EINVAL;
-		goto remove_idr;
 	}
 
-	bcd->minor = minor;
+	bcd->minor = ret;
 	bcd->queue = q;
 	bcd->parent = get_device(parent);
 	bcd->release = release;
@@ -1059,8 +1052,7 @@ unregister_class_dev:
 	device_unregister(class_dev);
 put_dev:
 	put_device(parent);
-remove_idr:
-	idr_remove(&bsg_minor_idr, minor);
+	idr_remove(&bsg_minor_idr, bcd->minor);
 unlock:
 	mutex_unlock(&bsg_mutex);
 	return ret;
block/genhd.c +6 -15
index 49abda1..2e3af9e 100644
@@ -408,7 +408,7 @@ static int blk_mangle_minor(int minor)
 int blk_alloc_devt(struct hd_struct *part, dev_t *devt)
 {
 	struct gendisk *disk = part_to_disk(part);
-	int idx, rc;
+	int idx;
 
 	/* in consecutive minor range? */
 	if (part->partno < disk->minors) {
@@ -417,20 +417,11 @@ int blk_alloc_devt(struct hd_struct *part, dev_t *devt)
 	}
 
 	/* allocate ext devt */
-	do {
-		if (!idr_pre_get(&ext_devt_idr, GFP_KERNEL))
-			return -ENOMEM;
-		mutex_lock(&ext_devt_mutex);
-		rc = idr_get_new(&ext_devt_idr, part, &idx);
-		if (!rc && idx >= NR_EXT_DEVT) {
-			idr_remove(&ext_devt_idr, idx);
-			rc = -EBUSY;
-		}
-		mutex_unlock(&ext_devt_mutex);
-	} while (rc == -EAGAIN);
-
-	if (rc)
-		return rc;
+	mutex_lock(&ext_devt_mutex);
+	idx = idr_alloc(&ext_devt_idr, part, 0, NR_EXT_DEVT, GFP_KERNEL);
+	mutex_unlock(&ext_devt_mutex);
+	if (idx < 0)
+		return idx == -ENOSPC ? -EBUSY : idx;
 
 	*devt = MKDEV(BLOCK_EXT_MAJOR, blk_mangle_minor(idx));
 	return 0;
Signature · 1 line
1.8.1
maintainer Acked-by on v1 7/62
#10 lore raw

Re: [PATCH 07/62] block: convert to idr_alloc()

Quoted 9 lines · Tejun Heo

Convert to the much saner new idr interface. Both bsg and genhd protect idr w/ mutex making preloading unnecessary.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

Signature · 1 line
Jens Axboe
author maintainer
#11 lore raw

PATCH 8/62 block/loop: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/block/loop.c | 23 +++++------------------
 1 file changed, 5 insertions(+), 18 deletions(-)
drivers/block/loop.c +5 -18
index 3b9c32b..dafbfdb 100644
@@ -1624,30 +1624,17 @@ static int loop_add(struct loop_device **l, int i)
 	if (!lo)
 		goto out;
 
-	if (!idr_pre_get(&loop_index_idr, GFP_KERNEL))
-		goto out_free_dev;
-
+	/* allocate id, if @id >= 0, we're requesting that specific id */
 	if (i >= 0) {
-		int m;
-
-		/* create specific i in the index */
-		err = idr_get_new_above(&loop_index_idr, lo, i, &m);
-		if (err >= 0 && i != m) {
-			idr_remove(&loop_index_idr, m);
+		err = idr_alloc(&loop_index_idr, lo, i, i + 1, GFP_KERNEL);
+		if (err == -ENOSPC)
 			err = -EEXIST;
-		}
-	} else if (i == -1) {
-		int m;
-
-		/* get next free nr */
-		err = idr_get_new(&loop_index_idr, lo, &m);
-		if (err >= 0)
-			i = m;
 	} else {
-		err = -EINVAL;
+		err = idr_alloc(&loop_index_idr, lo, 0, 0, GFP_KERNEL);
 	}
 	if (err < 0)
 		goto out_free_dev;
+	i = err;
 
 	lo->lo_queue = blk_alloc_queue(GFP_KERNEL);
 	if (!lo->lo_queue)
Signature · 1 line
1.8.1
maintainer Acked-by on v1 8/62
#12 lore raw

Re: [PATCH 08/62] block/loop: convert to idr_alloc()

Quoted 8 lines · Tejun Heo

Convert to the much saner new idr interface.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

Signature · 1 line
Jens Axboe
author maintainer
#13 lore raw

PATCH 9/62 atm/nicstar: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface. The existing code looks buggy to me - ID 0 is treated as no-ID but allocation specifies 0 as lower limit and there's no error handling after parial success. This conversion keeps the bugs unchanged.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/atm/nicstar.c | 27 ++++++++++++---------------
 1 file changed, 12 insertions(+), 15 deletions(-)
drivers/atm/nicstar.c +12 -15
index 628787e..7fd6834 100644
@@ -1026,24 +1026,21 @@ static void push_rxbufs(ns_dev * card, struct sk_buff *skb)
 				card->lbfqc += 2;
 		}
 
-		do {
-			if (!idr_pre_get(&card->idr, GFP_ATOMIC)) {
-				printk(KERN_ERR
-				       "nicstar%d: no free memory for idr\n",
-				       card->index);
+		if (!id1) {
+			id1 = idr_alloc(&card->idr, handle1, 0, 0, GFP_ATOMIC);
+			if (id1 < 0) {
+				err = id1;
 				goto out;
 			}
+		}
 
-			if (!id1)
-				err = idr_get_new_above(&card->idr, handle1, 0, &id1);
-
-			if (!id2 && err == 0)
-				err = idr_get_new_above(&card->idr, handle2, 0, &id2);
-
-		} while (err == -EAGAIN);
-
-		if (err)
-			goto out;
+		if (!id2) {
+			id2 = idr_alloc(&card->idr, handle2, 0, 0, GFP_ATOMIC);
+			if (id2 < 0) {
+				err = id2;
+				goto out;
+			}
+		}
 
 		spin_lock_irqsave(&card->res_lock, flags);
 		while (CMD_BUSY(card)) ;
Signature · 1 line
1.8.1
#14 lore raw

Re: [PATCH 09/62] atm/nicstar: convert to idr_alloc()

I don't quite understand your comment. idr_pre_get() returns 0 in the case of failure.

Quoted 59 lines · On Sat, 2 Feb 2013 17:20:10 -0800 Tejun Heo <[email protected]> wrote:

Convert to the much saner new idr interface. The existing code looks buggy to me - ID 0 is treated as no-ID but allocation specifies 0 as lower limit and there's no error handling after parial success. This conversion keeps the bugs unchanged.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/atm/nicstar.c | 27 ++++++++++++---------------
 1 file changed, 12 insertions(+), 15 deletions(-)
drivers/atm/nicstar.c +12 -15
index 628787e..7fd6834 100644
@@ -1026,24 +1026,21 @@ static void push_rxbufs(ns_dev * card, struct sk_buff *skb)
 				card->lbfqc += 2;
 		}
 
-		do {
-			if (!idr_pre_get(&card->idr, GFP_ATOMIC)) {
-				printk(KERN_ERR
-				       "nicstar%d: no free memory for idr\n",
-				       card->index);
+		if (!id1) {
+			id1 = idr_alloc(&card->idr, handle1, 0, 0, GFP_ATOMIC);
+			if (id1 < 0) {
+				err = id1;
 				goto out;
 			}
+		}
 
-			if (!id1)
-				err = idr_get_new_above(&card->idr, handle1, 0, &id1);
-
-			if (!id2 && err == 0)
-				err = idr_get_new_above(&card->idr, handle2, 0, &id2);
-
-		} while (err == -EAGAIN);
-
-		if (err)
-			goto out;
+		if (!id2) {
+			id2 = idr_alloc(&card->idr, handle2, 0, 0, GFP_ATOMIC);
+			if (id2 < 0) {
+				err = id2;
+				goto out;
+			}
+		}
 
 		spin_lock_irqsave(&card->res_lock, flags);
 		while (CMD_BUSY(card)) ;
author maintainer
#15 lore raw

Re: [PATCH 09/62] atm/nicstar: convert to idr_alloc()

Hello, Chas.

Quoted 2 lines · chas williams - CONTRACTOR

I don't quite understand your comment. idr_pre_get() returns 0 in the case of failure.

So, if you do the following,

	int id1 = 0, id2 = 0;

	if (!id1)
		err = idr_get_new_above(&card->idr, handle1, 0, &id1);
	if (!id2 && err == 0)
		err = idr_get_new_above(&card->idr, handle2, 0, &id2);
	if (err)
		goto out;

You have no way of telling whether id1/2 are allocated or not. 0 is the special "not allocated" value but it also is a valid ID. The error path should be freeing id1/2 if either of them has been allocated but it doesn't and can't with 0 as the non-allocated value.

Thanks.

Signature · 1 line
tejun
#16 lore raw

Re: [PATCH 09/62] atm/nicstar: convert to idr_alloc()

Quoted 17 lines · On Mon, 4 Feb 2013 09:06:24 -0800 Tejun Heo <[email protected]> wrote:

Hello, Chas.

Quoted 2 lines · chas williams - CONTRACTOR

I don't quite understand your comment. idr_pre_get() returns 0 in the case of failure.

So, if you do the following,

	int id1 = 0, id2 = 0;

	if (!id1)
		err = idr_get_new_above(&card->idr, handle1, 0, &id1);
	if (!id2 && err == 0)
		err = idr_get_new_above(&card->idr, handle2, 0, &id2);
	if (err)
		goto out;
Quoted 4 lines

You have no way of telling whether id1/2 are allocated or not. 0 is the special "not allocated" value but it also is a valid ID. The error path should be freeing id1/2 if either of them has been allocated but it doesn't and can't with 0 as the non-allocated value.

yeah, i see now. it didn't understand what idr_get_new_above() was doing with the start id. i assumed that it would return something greater than the start id. i guess it never did return the starting id (atleast after some initial failure).

additionally, yes, cleaning up if the second allocation failed was never done.

author maintainer
#17 lore raw

PATCH v3 9/62 atm/nicstar: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface. The existing code looks buggy to me - ID 0 is treated as no-ID but allocation specifies 0 as lower limit and there's no error handling after partial success. This conversion keeps the bugs unchanged.

Only compile tested.

v2: id1 and id2 are now directly used for -errno return and thus
should be signed. Make them int instead of u32. This was spotted by kbuild test robot.

v3: Further simplify as suggested by Chas Williams.

---
 drivers/atm/nicstar.c |   24 ++++++------------------
 1 file changed, 6 insertions(+), 18 deletions(-)
drivers/atm/nicstar.c +6 -18
@@ -949,11 +949,10 @@ static void free_scq(ns_dev *card, scq_i
 static void push_rxbufs(ns_dev * card, struct sk_buff *skb)
 {
 	struct sk_buff *handle1, *handle2;
-	u32 id1 = 0, id2 = 0;
+	int id1, id2;
 	u32 addr1, addr2;
 	u32 stat;
 	unsigned long flags;
-	int err;
 
 	/* *BARF* */
 	handle2 = NULL;
@@ -1026,23 +1025,12 @@ static void push_rxbufs(ns_dev * card, s
 				card->lbfqc += 2;
 		}
 
-		do {
-			if (!idr_pre_get(&card->idr, GFP_ATOMIC)) {
-				printk(KERN_ERR
-				       "nicstar%d: no free memory for idr\n",
-				       card->index);
-				goto out;
-			}
-
-			if (!id1)
-				err = idr_get_new_above(&card->idr, handle1, 0, &id1);
-
-			if (!id2 && err == 0)
-				err = idr_get_new_above(&card->idr, handle2, 0, &id2);
-
-		} while (err == -EAGAIN);
+		id1 = idr_alloc(&card->idr, handle1, 0, 0, GFP_ATOMIC);
+		if (id1 < 0)
+			goto out;
 
-		if (err)
+		id2 = idr_alloc(&card->idr, handle2, 0, 0, GFP_ATOMIC);
+		if (id2 < 0)
 			goto out;
 
 		spin_lock_irqsave(&card->res_lock, flags);
author maintainer
#18 lore raw

PATCH 10/62 drbd: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/block/drbd/drbd_main.c | 29 +++++++++++++----------------
 1 file changed, 13 insertions(+), 16 deletions(-)
drivers/block/drbd/drbd_main.c +13 -16
index 8c13eeb..e98da67 100644
@@ -2660,25 +2660,24 @@ enum drbd_ret_code conn_new_minor(struct drbd_tconn *tconn, unsigned int minor,
 	mdev->read_requests = RB_ROOT;
 	mdev->write_requests = RB_ROOT;
 
-	if (!idr_pre_get(&minors, GFP_KERNEL))
-		goto out_no_minor_idr;
-	if (idr_get_new_above(&minors, mdev, minor, &minor_got))
+	minor_got = idr_alloc(&minors, mdev, minor, minor + 1, GFP_KERNEL);
+	if (minor_got < 0) {
+		if (minor_got == -ENOSPC) {
+			err = ERR_MINOR_EXISTS;
+			drbd_msg_put_info("requested minor exists already");
+		}
 		goto out_no_minor_idr;
-	if (minor_got != minor) {
-		err = ERR_MINOR_EXISTS;
-		drbd_msg_put_info("requested minor exists already");
-		goto out_idr_remove_minor;
 	}
 
-	if (!idr_pre_get(&tconn->volumes, GFP_KERNEL))
-		goto out_idr_remove_minor;
-	if (idr_get_new_above(&tconn->volumes, mdev, vnr, &vnr_got))
+	vnr_got = idr_alloc(&tconn->volumes, mdev, vnr, vnr + 1, GFP_KERNEL);
+	if (vnr_got < 0) {
+		if (vnr_got == -ENOSPC) {
+			err = ERR_INVALID_REQUEST;
+			drbd_msg_put_info("requested volume exists already");
+		}
 		goto out_idr_remove_minor;
-	if (vnr_got != vnr) {
-		err = ERR_INVALID_REQUEST;
-		drbd_msg_put_info("requested volume exists already");
-		goto out_idr_remove_vol;
 	}
+
 	add_disk(disk);
 	kref_init(&mdev->kref); /* one ref for both idrs and the the add_disk */
 
@@ -2689,8 +2688,6 @@ enum drbd_ret_code conn_new_minor(struct drbd_tconn *tconn, unsigned int minor,
 
 	return NO_ERROR;
 
-out_idr_remove_vol:
-	idr_remove(&tconn->volumes, vnr_got);
 out_idr_remove_minor:
 	idr_remove(&minors, minor_got);
 	synchronize_rcu();
Signature · 1 line
1.8.1
author maintainer
#19 lore raw

PATCH 11/62 dca: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

Cc Paul Gortmaker <[email protected]>
Cc Maciej Sosnowski <[email protected]>
Cc Shannon Nelson <[email protected]>

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/dca/dca-sysfs.c | 23 ++++++++++-------------
 1 file changed, 10 insertions(+), 13 deletions(-)
drivers/dca/dca-sysfs.c +10 -13
index 591b659..126cf29 100644
@@ -53,22 +53,19 @@ void dca_sysfs_remove_req(struct dca_provider *dca, int slot)
 int dca_sysfs_add_provider(struct dca_provider *dca, struct device *dev)
 {
 	struct device *cd;
-	int err = 0;
+	int ret;
 
-idr_try_again:
-	if (!idr_pre_get(&dca_idr, GFP_KERNEL))
-		return -ENOMEM;
+	idr_preload(GFP_KERNEL);
 	spin_lock(&dca_idr_lock);
-	err = idr_get_new(&dca_idr, dca, &dca->id);
+
+	ret = idr_alloc(&dca_idr, dca, 0, 0, GFP_NOWAIT);
+	if (ret >= 0)
+		dca->id = ret;
+
 	spin_unlock(&dca_idr_lock);
-	switch (err) {
-	case 0:
-		break;
-	case -EAGAIN:
-		goto idr_try_again;
-	default:
-		return err;
-	}
+	idr_preload_end();
+	if (ret < 0)
+		return ret;
 
 	cd = device_create(dca_class, dev, MKDEV(0, 0), NULL, "dca%d", dca->id);
 	if (IS_ERR(cd)) {
Signature · 1 line
1.8.1
author maintainer
#20 lore raw

PATCH 12/62 dmaengine: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

Cc Dan Williams <[email protected]>

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/dma/dmaengine.c | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)
drivers/dma/dmaengine.c +6 -10
index a815d44..381aa2c 100644
@@ -667,18 +667,14 @@ static int get_dma_id(struct dma_device *device)
 {
 	int rc;
 
- idr_retry:
-	if (!idr_pre_get(&dma_idr, GFP_KERNEL))
-		return -ENOMEM;
 	mutex_lock(&dma_list_mutex);
-	rc = idr_get_new(&dma_idr, NULL, &device->dev_id);
-	mutex_unlock(&dma_list_mutex);
-	if (rc == -EAGAIN)
-		goto idr_retry;
-	else if (rc != 0)
-		return rc;
 
-	return 0;
+	rc = idr_alloc(&dma_idr, NULL, 0, 0, GFP_KERNEL);
+	if (rc >= 0)
+		device->dev_id = rc;
+
+	mutex_unlock(&dma_list_mutex);
+	return rc < 0 ? rc : 0;
 }
 
 /**
Signature · 1 line
1.8.1
author maintainer
#21 lore raw

PATCH 13/62 firewire: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/firewire/core-cdev.c   | 16 +++++++---------
 drivers/firewire/core-device.c |  5 ++---
 2 files changed, 9 insertions(+), 12 deletions(-)
drivers/firewire/core-cdev.c +7 -9
index 68c3138..46a1f88 100644
@@ -490,24 +490,22 @@ static int add_client_resource(struct client *client,
 	unsigned long flags;
 	int ret;
 
- retry:
-	if (idr_pre_get(&client->resource_idr, gfp_mask) == 0)
-		return -ENOMEM;
-
+	idr_preload(gfp_mask);
 	spin_lock_irqsave(&client->lock, flags);
+
 	if (client->in_shutdown)
 		ret = -ECANCELED;
 	else
-		ret = idr_get_new(&client->resource_idr, resource,
-				  &resource->handle);
+		ret = idr_alloc(&client->resource_idr, resource, 0, 0,
+				GFP_NOWAIT);
 	if (ret >= 0) {
+		resource->handle = ret;
 		client_get(client);
 		schedule_if_iso_resource(resource);
 	}
-	spin_unlock_irqrestore(&client->lock, flags);
 
-	if (ret == -EAGAIN)
-		goto retry;
+	spin_unlock_irqrestore(&client->lock, flags);
+	idr_preload_end();
 
 	return ret < 0 ? ret : 0;
 }
drivers/firewire/core-device.c +2 -3
index 3873d53..c137de6 100644
@@ -1017,13 +1017,12 @@ static void fw_device_init(struct work_struct *work)
 
 	fw_device_get(device);
 	down_write(&fw_device_rwsem);
-	ret = idr_pre_get(&fw_device_idr, GFP_KERNEL) ?
-	      idr_get_new(&fw_device_idr, device, &minor) :
-	      -ENOMEM;
+	ret = idr_alloc(&fw_device_idr, device, 0, 0, GFP_KERNEL);
 	up_write(&fw_device_rwsem);
 
 	if (ret < 0)
 		goto error;
+	minor = ret;
 
 	device->device.bus = &fw_bus_type;
 	device->device.type = &fw_device_type;
Signature · 1 line
1.8.1
#22 lore raw

Re: [PATCH 13/62] firewire: convert to idr_alloc()

Quoted 42 lines · On Feb 02 Tejun Heo wrote:

Convert to the much saner new idr interface.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/firewire/core-cdev.c   | 16 +++++++---------
 drivers/firewire/core-device.c |  5 ++---
 2 files changed, 9 insertions(+), 12 deletions(-)
drivers/firewire/core-cdev.c +5 -6
index 68c3138..46a1f88 100644
@@ -490,24 +490,22 @@ static int add_client_resource(struct client *client,
 	unsigned long flags;
 	int ret;
 
- retry:
-	if (idr_pre_get(&client->resource_idr, gfp_mask) == 0)
-		return -ENOMEM;
-
+	idr_preload(gfp_mask);
 	spin_lock_irqsave(&client->lock, flags);
+
 	if (client->in_shutdown)
 		ret = -ECANCELED;
 	else
-		ret = idr_get_new(&client->resource_idr, resource,
-				  &resource->handle);
+		ret = idr_alloc(&client->resource_idr, resource, 0, 0,
+				GFP_NOWAIT);
 	if (ret >= 0) {
+		resource->handle = ret;
 		client_get(client);
 		schedule_if_iso_resource(resource);

drivers/firewire/core-cdev.c static int add_client_resource(struct client *client, · line 511

Quoted 10 lines
drivers/firewire/core-cdev.c +2 -3
 	}
-	spin_unlock_irqrestore(&client->lock, flags);
 
-	if (ret == -EAGAIN)
-		goto retry;
+	spin_unlock_irqrestore(&client->lock, flags);
+	idr_preload_end();
 
 	return ret < 0 ? ret : 0;
 }

Most of the add_client_resource() callers are process context (user process doing an ioctl()), and for them this is going to work fine. But one caller is tasklet context (firewire-ohci's asynchronous reception DMA IRQ handler "bottom half").

The kerneldoc comment in 05/62 "idr: implement idr_preload[_end]() and idr_alloc()" tells me that idr_preload and idr_preload_end must be used in process context only. Can it work in tasklet context regardless? I am not entirely sure from looking at the implementation.

Quoted 10 lines
drivers/firewire/core-device.c +0 -2
index 3873d53..c137de6 100644
@@ -1017,13 +1017,12 @@ static void fw_device_init(struct work_struct *work)
 
 	fw_device_get(device);
 	down_write(&fw_device_rwsem);
-	ret = idr_pre_get(&fw_device_idr, GFP_KERNEL) ?
-	      idr_get_new(&fw_device_idr, device, &minor) :

drivers/firewire/core-device.c static void fw_device_init(struct work_struct *work) · line 1028

Quoted 10 lines
drivers/firewire/core-device.c +2 -1
-	      -ENOMEM;
+	ret = idr_alloc(&fw_device_idr, device, 0, 0, GFP_KERNEL);
 	up_write(&fw_device_rwsem);
 
 	if (ret < 0)
 		goto error;
+	minor = ret;
 
 	device->device.bus = &fw_bus_type;
 	device->device.type = &fw_device_type;

This hunk is OK, of course.

Signature · 3 lines
Stefan Richter
-=====-===-= --=- ---==
http://arcgraph.de/sr/
#23 lore raw

Re: [PATCH 13/62] firewire: convert to idr_alloc()

Quoted 13 lines · On Feb 03 Stefan Richter wrote:
Quoted 12 lines · On Feb 02 Tejun Heo wrote:
drivers/firewire/core-device.c +1 -3
@@ -1017,13 +1017,12 @@ static void fw_device_init(struct work_struct *work)
 
 	fw_device_get(device);
 	down_write(&fw_device_rwsem);
-	ret = idr_pre_get(&fw_device_idr, GFP_KERNEL) ?
-	      idr_get_new(&fw_device_idr, device, &minor) :
-	      -ENOMEM;
+	ret = idr_alloc(&fw_device_idr, device, 0, 0, GFP_KERNEL);
 	up_write(&fw_device_rwsem);
 
Quoted 8 lines

drivers/firewire/core-device.c static void fw_device_init(struct work_struct *work) · line 1028

Quoted 6 lines
drivers/firewire/core-device.c +1 -0
 	if (ret < 0)
 		goto error;
+	minor = ret;
 
 	device->device.bus = &fw_bus_type;
 	device->device.type = &fw_device_type;

This hunk is OK, of course.

Could be changed into

	ret = idr_alloc(&fw_device_idr, device, 0, 1 << MINORBITS, GFP_KERNEL);

though, which would be an additional bug fix.

Signature · 3 lines
Stefan Richter
-=====-===-= --=- ---==
http://arcgraph.de/sr/
author maintainer
#24 lore raw

PATCH 1/1 firewire: add minor number range check to fw_device_init()

In reply to Tejun Heo

fw_device_init() didn't check whether the allocated minor number isn't too large. Fail if it goes overflows MINORBITS.

---
 drivers/firewire/core-device.c |    4 ++++
 1 file changed, 4 insertions(+)
drivers/firewire/core-device.c +4 -0
@@ -1020,6 +1020,10 @@ static void fw_device_init(struct work_s
 	ret = idr_pre_get(&fw_device_idr, GFP_KERNEL) ?
 	      idr_get_new(&fw_device_idr, device, &minor) :
 	      -ENOMEM;
+	if (minor >= 1 << MINORBITS) {
+		idr_remove(&fw_device_idr, minor);
+		minor = -ENOSPC;
+	}
 	up_write(&fw_device_rwsem);
 
 	if (ret < 0)
#25 lore raw

Re: [PATCH 12.5/62] firewire: add minor number range check to fw_device_init()

Quoted 13 lines · On Feb 04 Tejun Heo wrote:

fw_device_init() didn't check whether the allocated minor number isn't too large. Fail if it goes overflows MINORBITS.

---
 drivers/firewire/core-device.c |    4 ++++
 1 file changed, 4 insertions(+)

drivers/firewire/core-device.c static void fw_device_init(struct work_s · line 1029

Quoted 10 lines
drivers/firewire/core-device.c +4 -0
@@ -1020,6 +1020,10 @@ static void fw_device_init(struct work_s
 	ret = idr_pre_get(&fw_device_idr, GFP_KERNEL) ?
 	      idr_get_new(&fw_device_idr, device, &minor) :
 	      -ENOMEM;
+	if (minor >= 1 << MINORBITS) {
+		idr_remove(&fw_device_idr, minor);
+		minor = -ENOSPC;
+	}
 	up_write(&fw_device_rwsem);
 
 	if (ret < 0)

Thanks; routing together with the other idr patches through mm Acked-by:
Stefan Richter <[email protected]>

Not totally sure whether to bother -stable with this, as this condition is rather difficult to provoke. But since the fix is small and "obvious", why not.

Signature · 3 lines
Stefan Richter
-=====-===-= --=- --=--
http://arcgraph.de/sr/
author maintainer
#26 lore raw

PATCH v2 13/62 firewire: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

v2: Stefan pointed out that add_client_resource() may be called from
non-process context. Preload iff @gfp_mask contains __GFP_WAIT. Also updated to include minor upper limit check.

---
 drivers/firewire/core-cdev.c   |   19 ++++++++++---------
 drivers/firewire/core-device.c |    8 +-------
 2 files changed, 11 insertions(+), 16 deletions(-)
drivers/firewire/core-cdev.c +10 -9
@@ -487,27 +487,28 @@ static int ioctl_get_info(struct client
 static int add_client_resource(struct client *client,
 			       struct client_resource *resource, gfp_t gfp_mask)
 {
+	bool preload = gfp_mask & __GFP_WAIT;
 	unsigned long flags;
 	int ret;
 
- retry:
-	if (idr_pre_get(&client->resource_idr, gfp_mask) == 0)
-		return -ENOMEM;
-
+	if (preload)
+		idr_preload(gfp_mask);
 	spin_lock_irqsave(&client->lock, flags);
+
 	if (client->in_shutdown)
 		ret = -ECANCELED;
 	else
-		ret = idr_get_new(&client->resource_idr, resource,
-				  &resource->handle);
+		ret = idr_alloc(&client->resource_idr, resource, 0, 0,
+				GFP_NOWAIT);
 	if (ret >= 0) {
+		resource->handle = ret;
 		client_get(client);
 		schedule_if_iso_resource(resource);
 	}
-	spin_unlock_irqrestore(&client->lock, flags);
 
-	if (ret == -EAGAIN)
-		goto retry;
+	spin_unlock_irqrestore(&client->lock, flags);
+	if (preload)
+		idr_preload_end();
 
 	return ret < 0 ? ret : 0;
 }
drivers/firewire/core-device.c +1 -7
@@ -1017,13 +1017,7 @@ static void fw_device_init(struct work_s
 
 	fw_device_get(device);
 	down_write(&fw_device_rwsem);
-	ret = idr_pre_get(&fw_device_idr, GFP_KERNEL) ?
-	      idr_get_new(&fw_device_idr, device, &minor) :
-	      -ENOMEM;
-	if (minor >= 1 << MINORBITS) {
-		idr_remove(&fw_device_idr, minor);
-		minor = -ENOSPC;
-	}
+	ret = idr_alloc(&fw_device_idr, device, 0, 1 << MINORBITS, GFP_KERNEL);
 	up_write(&fw_device_rwsem);
 
 	if (ret < 0)
Acked-by on v2 13/62
#27 lore raw

Re: [PATCH v2 13/62] firewire: convert to idr_alloc()

Quoted 11 lines · On Feb 04 Tejun Heo wrote:

Convert to the much saner new idr interface.

Only compile tested.

v2: Stefan pointed out that add_client_resource() may be called from
non-process context. Preload iff @gfp_mask contains __GFP_WAIT. Also updated to include minor upper limit check.

Quoted 62 lines
---
 drivers/firewire/core-cdev.c   |   19 ++++++++++---------
 drivers/firewire/core-device.c |    8 +-------
 2 files changed, 11 insertions(+), 16 deletions(-)
drivers/firewire/core-cdev.c +10 -9
@@ -487,27 +487,28 @@ static int ioctl_get_info(struct client
 static int add_client_resource(struct client *client,
 			       struct client_resource *resource, gfp_t gfp_mask)
 {
+	bool preload = gfp_mask & __GFP_WAIT;
 	unsigned long flags;
 	int ret;
 
- retry:
-	if (idr_pre_get(&client->resource_idr, gfp_mask) == 0)
-		return -ENOMEM;
-
+	if (preload)
+		idr_preload(gfp_mask);
 	spin_lock_irqsave(&client->lock, flags);
+
 	if (client->in_shutdown)
 		ret = -ECANCELED;
 	else
-		ret = idr_get_new(&client->resource_idr, resource,
-				  &resource->handle);
+		ret = idr_alloc(&client->resource_idr, resource, 0, 0,
+				GFP_NOWAIT);
 	if (ret >= 0) {
+		resource->handle = ret;
 		client_get(client);
 		schedule_if_iso_resource(resource);
 	}
-	spin_unlock_irqrestore(&client->lock, flags);
 
-	if (ret == -EAGAIN)
-		goto retry;
+	spin_unlock_irqrestore(&client->lock, flags);
+	if (preload)
+		idr_preload_end();
 
 	return ret < 0 ? ret : 0;
 }
drivers/firewire/core-device.c +1 -7
@@ -1017,13 +1017,7 @@ static void fw_device_init(struct work_s
 
 	fw_device_get(device);
 	down_write(&fw_device_rwsem);
-	ret = idr_pre_get(&fw_device_idr, GFP_KERNEL) ?
-	      idr_get_new(&fw_device_idr, device, &minor) :
-	      -ENOMEM;
-	if (minor >= 1 << MINORBITS) {
-		idr_remove(&fw_device_idr, minor);
-		minor = -ENOSPC;
-	}
+	ret = idr_alloc(&fw_device_idr, device, 0, 1 << MINORBITS, GFP_KERNEL);
 	up_write(&fw_device_rwsem);
 
 	if (ret < 0)
Signature · 3 lines
Stefan Richter
-=====-===-= --=- --=--
http://arcgraph.de/sr/
author maintainer
#28 lore raw

PATCH 14/62 gpio: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

Cc Grant Likely <[email protected]>
Cc Linus Walleij <[email protected]>

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/gpio/gpiolib.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)
drivers/gpio/gpiolib.c +3 -8
index 199fca1..c32ba9a 100644
@@ -399,15 +399,10 @@ static int gpio_setup_irq(struct gpio_desc *desc, struct device *dev,
 			goto err_out;
 		}
 
-		do {
-			ret = -ENOMEM;
-			if (idr_pre_get(&dirent_idr, GFP_KERNEL))
-				ret = idr_get_new_above(&dirent_idr, value_sd,
-							1, &id);
-		} while (ret == -EAGAIN);
-
-		if (ret)
+		ret = idr_alloc(&dirent_idr, value_sd, 1, 0, GFP_KERNEL);
+		if (ret < 0)
 			goto free_sd;
+		id = ret;
 
 		desc->flags &= GPIO_FLAGS_MASK;
 		desc->flags |= (unsigned long)id << ID_SHIFT;
Signature · 1 line
1.8.1
Acked-by on v1 14/62
#29 lore raw

Re: [PATCH 14/62] gpio: convert to idr_alloc()

Quoted 11 lines · Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

Cc Grant Likely <[email protected]>
Cc Linus Walleij <[email protected]>

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

Yours,
Linus Walleij

author maintainer
#30 lore raw

PATCH 15/62 drm: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

* drm_ctxbitmap_next() error handling in drm_addctx() seems broken. drm_ctxbitmap_next() return -errno on failure not -1.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/gpu/drm/drm_context.c | 17 +++--------------
 drivers/gpu/drm/drm_crtc.c    | 15 +++------------
 drivers/gpu/drm/drm_gem.c     | 35 +++++++++++++----------------------
 drivers/gpu/drm/drm_stub.c    | 19 ++-----------------
 4 files changed, 21 insertions(+), 65 deletions(-)
drivers/gpu/drm/drm_context.c +3 -14
index 75f62c5..725968d 100644
@@ -74,24 +74,13 @@ void drm_ctxbitmap_free(struct drm_device * dev, int ctx_handle)
  */
 static int drm_ctxbitmap_next(struct drm_device * dev)
 {
-	int new_id;
 	int ret;
 
-again:
-	if (idr_pre_get(&dev->ctx_idr, GFP_KERNEL) == 0) {
-		DRM_ERROR("Out of memory expanding drawable idr\n");
-		return -ENOMEM;
-	}
 	mutex_lock(&dev->struct_mutex);
-	ret = idr_get_new_above(&dev->ctx_idr, NULL,
-				DRM_RESERVED_CONTEXTS, &new_id);
+	ret = idr_alloc(&dev->ctx_idr, NULL, DRM_RESERVED_CONTEXTS, 0,
+			GFP_KERNEL);
 	mutex_unlock(&dev->struct_mutex);
-	if (ret == -EAGAIN)
-		goto again;
-	else if (ret)
-		return ret;
-
-	return new_id;
+	return ret;
 }
 
 /**
drivers/gpu/drm/drm_crtc.c +3 -12
index 9b39d1f..9da1f00 100644
@@ -220,24 +220,15 @@ char *drm_get_connector_status_name(enum drm_connector_status status)
 static int drm_mode_object_get(struct drm_device *dev,
 			       struct drm_mode_object *obj, uint32_t obj_type)
 {
-	int new_id = 0;
 	int ret;
 
-again:
-	if (idr_pre_get(&dev->mode_config.crtc_idr, GFP_KERNEL) == 0) {
-		DRM_ERROR("Ran out memory getting a mode number\n");
-		return -ENOMEM;
-	}
-
 	mutex_lock(&dev->mode_config.idr_mutex);
-	ret = idr_get_new_above(&dev->mode_config.crtc_idr, obj, 1, &new_id);
+	ret = idr_alloc(&dev->mode_config.crtc_idr, obj, 1, 0, GFP_KERNEL);
 	mutex_unlock(&dev->mode_config.idr_mutex);
-	if (ret == -EAGAIN)
-		goto again;
-	else if (ret)
+	if (ret < 0)
 		return ret;
 
-	obj->id = new_id;
+	obj->id = ret;
 	obj->type = obj_type;
 	return 0;
 }
drivers/gpu/drm/drm_gem.c +13 -22
index e775859..6577514 100644
@@ -270,21 +270,19 @@ drm_gem_handle_create(struct drm_file *file_priv,
 	int ret;
 
 	/*
-	 * Get the user-visible handle using idr.
+	 * Get the user-visible handle using idr.  Preload and perform
+	 * allocation under our spinlock.
 	 */
-again:
-	/* ensure there is space available to allocate a handle */
-	if (idr_pre_get(&file_priv->object_idr, GFP_KERNEL) == 0)
-		return -ENOMEM;
-
-	/* do the allocation under our spinlock */
+	idr_preload(GFP_KERNEL);
 	spin_lock(&file_priv->table_lock);
-	ret = idr_get_new_above(&file_priv->object_idr, obj, 1, (int *)handlep);
+
+	ret = idr_alloc(&file_priv->object_idr, obj, 1, 0, GFP_NOWAIT);
+
 	spin_unlock(&file_priv->table_lock);
-	if (ret == -EAGAIN)
-		goto again;
-	else if (ret)
+	idr_preload_end();
+	if (ret < 0)
 		return ret;
+	*handlep = ret;
 
 	drm_gem_object_handle_reference(obj);
 
@@ -451,22 +449,15 @@ drm_gem_flink_ioctl(struct drm_device *dev, void *data,
 	if (obj == NULL)
 		return -ENOENT;
 
-again:
-	if (idr_pre_get(&dev->object_name_idr, GFP_KERNEL) == 0) {
-		ret = -ENOMEM;
-		goto err;
-	}
-
+	idr_preload(GFP_KERNEL);
 	spin_lock(&dev->object_name_lock);
 	if (!obj->name) {
-		ret = idr_get_new_above(&dev->object_name_idr, obj, 1,
-					&obj->name);
+		ret = idr_alloc(&dev->object_name_idr, obj, 1, 0, GFP_NOWAIT);
+		obj->name = ret;
 		args->name = (uint64_t) obj->name;
 		spin_unlock(&dev->object_name_lock);
 
-		if (ret == -EAGAIN)
-			goto again;
-		else if (ret)
+		if (ret < 0)
 			goto err;
 
 		/* Allocate a reference for the name table.  */
drivers/gpu/drm/drm_stub.c +2 -17
index 200e104..7d30802 100644
@@ -109,7 +109,6 @@ EXPORT_SYMBOL(drm_ut_debug_printk);
 
 static int drm_minor_get_id(struct drm_device *dev, int type)
 {
-	int new_id;
 	int ret;
 	int base = 0, limit = 63;
 
@@ -121,25 +120,11 @@ static int drm_minor_get_id(struct drm_device *dev, int type)
                 limit = base + 255;
         }
 
-again:
-	if (idr_pre_get(&drm_minors_idr, GFP_KERNEL) == 0) {
-		DRM_ERROR("Out of memory expanding drawable idr\n");
-		return -ENOMEM;
-	}
 	mutex_lock(&dev->struct_mutex);
-	ret = idr_get_new_above(&drm_minors_idr, NULL,
-				base, &new_id);
+	ret = idr_alloc(&drm_minors_idr, NULL, base, limit, GFP_KERNEL);
 	mutex_unlock(&dev->struct_mutex);
-	if (ret == -EAGAIN)
-		goto again;
-	else if (ret)
-		return ret;
 
-	if (new_id >= limit) {
-		idr_remove(&drm_minors_idr, new_id);
-		return -EINVAL;
-	}
-	return new_id;
+	return ret == -ENOSPC ? -EINVAL : ret;
 }
 
 struct drm_master *drm_master_create(struct drm_minor *minor)
Signature · 1 line
1.8.1
author maintainer
#31 lore raw

PATCH 16/62 drm/exynos: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/gpu/drm/exynos/exynos_drm_ipp.c | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)
drivers/gpu/drm/exynos/exynos_drm_ipp.c +5 -11
index 49278f0..62c24fb 100644
@@ -137,21 +137,15 @@ static int ipp_create_id(struct idr *id_idr, struct mutex *lock, void *obj,
 
 	DRM_DEBUG_KMS("%s\n", __func__);
 
-again:
-	/* ensure there is space available to allocate a handle */
-	if (idr_pre_get(id_idr, GFP_KERNEL) == 0) {
-		DRM_ERROR("failed to get idr.\n");
-		return -ENOMEM;
-	}
-
 	/* do the allocation under our mutexlock */
 	mutex_lock(lock);
-	ret = idr_get_new_above(id_idr, obj, 1, (int *)idp);
+	ret = idr_alloc(id_idr, obj, 1, 0, GFP_KERNEL);
 	mutex_unlock(lock);
-	if (ret == -EAGAIN)
-		goto again;
+	if (ret < 0)
+		return ret;
 
-	return ret;
+	*idp = ret;
+	return 0;
 }
 
 static void *ipp_find_obj(struct idr *id_idr, struct mutex *lock, u32 id)
Signature · 1 line
1.8.1
author maintainer
#32 lore raw

PATCH 17/62 drm/i915: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/gpu/drm/i915/i915_gem_context.c | 21 +++++----------------
 1 file changed, 5 insertions(+), 16 deletions(-)
drivers/gpu/drm/i915/i915_gem_context.c +5 -16
index a3f06bc..27e586a 100644
@@ -144,7 +144,7 @@ create_hw_context(struct drm_device *dev,
 {
 	struct drm_i915_private *dev_priv = dev->dev_private;
 	struct i915_hw_context *ctx;
-	int ret, id;
+	int ret;
 
 	ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
 	if (ctx == NULL)
@@ -169,22 +169,11 @@ create_hw_context(struct drm_device *dev,
 
 	ctx->file_priv = file_priv;
 
-again:
-	if (idr_pre_get(&file_priv->context_idr, GFP_KERNEL) == 0) {
-		ret = -ENOMEM;
-		DRM_DEBUG_DRIVER("idr allocation failed\n");
-		goto err_out;
-	}
-
-	ret = idr_get_new_above(&file_priv->context_idr, ctx,
-				DEFAULT_CONTEXT_ID + 1, &id);
-	if (ret == 0)
-		ctx->id = id;
-
-	if (ret == -EAGAIN)
-		goto again;
-	else if (ret)
+	ret = idr_alloc(&file_priv->context_idr, ctx, DEFAULT_CONTEXT_ID + 1, 0,
+			GFP_KERNEL);
+	if (ret < 0)
 		goto err_out;
+	ctx->id = ret;
 
 	return ctx;
 
Signature · 1 line
1.8.1
Acked-by on v1 17/62
#33 lore raw

Re: [PATCH 17/62] drm/i915: convert to idr_alloc()

Quoted 4 lines · Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

Quoted 8 lines

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

Indeed, this looks nice.

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
author maintainer
#34 lore raw

PATCH 18/62 drm/sis: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/gpu/drm/sis/sis_mm.c | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)
drivers/gpu/drm/sis/sis_mm.c +3 -10
index 2b2f78c..9a43d98 100644
@@ -128,17 +128,10 @@ static int sis_drm_alloc(struct drm_device *dev, struct drm_file *file,
 	if (retval)
 		goto fail_alloc;
 
-again:
-	if (idr_pre_get(&dev_priv->object_idr, GFP_KERNEL) == 0) {
-		retval = -ENOMEM;
-		goto fail_idr;
-	}
-
-	retval = idr_get_new_above(&dev_priv->object_idr, item, 1, &user_key);
-	if (retval == -EAGAIN)
-		goto again;
-	if (retval)
+	retval = idr_alloc(&dev_priv->object_idr, item, 1, 0, GFP_KERNEL);
+	if (retval < 0)
 		goto fail_idr;
+	user_key = retval;
 
 	list_add(&item->owner_list, &file_priv->obj_list);
 	mutex_unlock(&dev->struct_mutex);
Signature · 1 line
1.8.1
author maintainer
#35 lore raw

PATCH 19/62 drm/via: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/gpu/drm/via/via_mm.c | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)
drivers/gpu/drm/via/via_mm.c +3 -10
index 0d55432..0ab93ff 100644
@@ -148,17 +148,10 @@ int via_mem_alloc(struct drm_device *dev, void *data,
 	if (retval)
 		goto fail_alloc;
 
-again:
-	if (idr_pre_get(&dev_priv->object_idr, GFP_KERNEL) == 0) {
-		retval = -ENOMEM;
-		goto fail_idr;
-	}
-
-	retval = idr_get_new_above(&dev_priv->object_idr, item, 1, &user_key);
-	if (retval == -EAGAIN)
-		goto again;
-	if (retval)
+	retval = idr_alloc(&dev_priv->object_idr, item, 1, 0, GFP_KERNEL);
+	if (retval < 0)
 		goto fail_idr;
+	user_key = retval;
 
 	list_add(&item->owner_list, &file_priv->obj_list);
 	mutex_unlock(&dev->struct_mutex);
Signature · 1 line
1.8.1
author maintainer
#36 lore raw

PATCH 20/62 drm/vmwgfx: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/gpu/drm/vmwgfx/vmwgfx_resource.c | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)
drivers/gpu/drm/vmwgfx/vmwgfx_resource.c +8 -9
index e01a17b..c9d0676 100644
@@ -177,17 +177,16 @@ int vmw_resource_alloc_id(struct vmw_resource *res)
 
 	BUG_ON(res->id != -1);
 
-	do {
-		if (unlikely(idr_pre_get(idr, GFP_KERNEL) == 0))
-			return -ENOMEM;
-
-		write_lock(&dev_priv->resource_lock);
-		ret = idr_get_new_above(idr, res, 1, &res->id);
-		write_unlock(&dev_priv->resource_lock);
+	idr_preload(GFP_KERNEL);
+	write_lock(&dev_priv->resource_lock);
 
-	} while (ret == -EAGAIN);
+	ret = idr_alloc(idr, res, 1, 0, GFP_NOWAIT);
+	if (ret >= 0)
+		res->id = ret;
 
-	return ret;
+	write_unlock(&dev_priv->resource_lock);
+	idr_preload_end();
+	return ret < 0 ? ret : 0;
 }
 
 /**
Signature · 1 line
1.8.1
author maintainer
#37 lore raw

PATCH 21/62 i2c: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/i2c/i2c-core.c | 45 ++++++++++-----------------------------------
 1 file changed, 10 insertions(+), 35 deletions(-)
drivers/i2c/i2c-core.c +10 -35
index e388590..6868351 100644
@@ -935,25 +935,16 @@ out_list:
  */
 int i2c_add_adapter(struct i2c_adapter *adapter)
 {
-	int	id, res = 0;
-
-retry:
-	if (idr_pre_get(&i2c_adapter_idr, GFP_KERNEL) == 0)
-		return -ENOMEM;
+	int res;
 
 	mutex_lock(&core_lock);
-	/* "above" here means "above or equal to", sigh */
-	res = idr_get_new_above(&i2c_adapter_idr, adapter,
-				__i2c_first_dynamic_bus_num, &id);
+	res = idr_alloc(&i2c_adapter_idr, adapter,
+			__i2c_first_dynamic_bus_num, 0, GFP_KERNEL);
 	mutex_unlock(&core_lock);
-
-	if (res < 0) {
-		if (res == -EAGAIN)
-			goto retry;
+	if (res < 0)
 		return res;
-	}
 
-	adapter->nr = id;
+	adapter->nr = res;
 	return i2c_register_adapter(adapter);
 }
 EXPORT_SYMBOL(i2c_add_adapter);
@@ -984,33 +975,17 @@ EXPORT_SYMBOL(i2c_add_adapter);
 int i2c_add_numbered_adapter(struct i2c_adapter *adap)
 {
 	int	id;
-	int	status;
 
 	if (adap->nr == -1) /* -1 means dynamically assign bus id */
 		return i2c_add_adapter(adap);
-	if (adap->nr & ~MAX_IDR_MASK)
-		return -EINVAL;
-
-retry:
-	if (idr_pre_get(&i2c_adapter_idr, GFP_KERNEL) == 0)
-		return -ENOMEM;
 
 	mutex_lock(&core_lock);
-	/* "above" here means "above or equal to", sigh;
-	 * we need the "equal to" result to force the result
-	 */
-	status = idr_get_new_above(&i2c_adapter_idr, adap, adap->nr, &id);
-	if (status == 0 && id != adap->nr) {
-		status = -EBUSY;
-		idr_remove(&i2c_adapter_idr, id);
-	}
+	id = idr_alloc(&i2c_adapter_idr, adap, adap->nr, adap->nr + 1,
+		       GFP_KERNEL);
 	mutex_unlock(&core_lock);
-	if (status == -EAGAIN)
-		goto retry;
-
-	if (status == 0)
-		status = i2c_register_adapter(adap);
-	return status;
+	if (id < 0)
+		return id == -ENOSPC ? -EBUSY : id;
+	return 0;
 }
 EXPORT_SYMBOL_GPL(i2c_add_numbered_adapter);
 
Signature · 1 line
1.8.1
author maintainer
#38 lore raw

PATCH 22/62 infiniband/core: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

Cc Roland Dreier <[email protected]>
Cc Sean Hefty <[email protected]>
Cc Hal Rosenstock <[email protected]>

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/infiniband/core/cm.c         | 22 +++++++++++-----------
 drivers/infiniband/core/cma.c        | 24 +++++++-----------------
 drivers/infiniband/core/sa_query.c   | 15 +++++++--------
 drivers/infiniband/core/ucm.c        | 16 ++++------------
 drivers/infiniband/core/ucma.c       | 32 ++++++++------------------------
 drivers/infiniband/core/uverbs_cmd.c | 17 ++++++++---------
 6 files changed, 45 insertions(+), 81 deletions(-)
drivers/infiniband/core/cm.c +11 -11
index 394fea2..98281fe 100644
@@ -382,20 +382,21 @@ static int cm_init_av_by_path(struct ib_sa_path_rec *path, struct cm_av *av)
 static int cm_alloc_id(struct cm_id_private *cm_id_priv)
 {
 	unsigned long flags;
-	int ret, id;
+	int id;
 	static int next_id;
 
-	do {
-		spin_lock_irqsave(&cm.lock, flags);
-		ret = idr_get_new_above(&cm.local_id_table, cm_id_priv,
-					next_id, &id);
-		if (!ret)
-			next_id = ((unsigned) id + 1) & MAX_IDR_MASK;
-		spin_unlock_irqrestore(&cm.lock, flags);
-	} while( (ret == -EAGAIN) && idr_pre_get(&cm.local_id_table, GFP_KERNEL) );
+	idr_preload(GFP_KERNEL);
+	spin_lock_irqsave(&cm.lock, flags);
+
+	id = idr_alloc(&cm.local_id_table, cm_id_priv, next_id, 0, GFP_NOWAIT);
+	if (id >= 0)
+		next_id = ((unsigned) id + 1) & MAX_IDR_MASK;
+
+	spin_unlock_irqrestore(&cm.lock, flags);
+	idr_preload_end();
 
 	cm_id_priv->id.local_id = (__force __be32)id ^ cm.random_id_operand;
-	return ret;
+	return id < 0 ? id : 0;
 }
 
 static void cm_free_id(__be32 local_id)
@@ -3844,7 +3845,6 @@ static int __init ib_cm_init(void)
 	cm.remote_sidr_table = RB_ROOT;
 	idr_init(&cm.local_id_table);
 	get_random_bytes(&cm.random_id_operand, sizeof cm.random_id_operand);
-	idr_pre_get(&cm.local_id_table, GFP_KERNEL);
 	INIT_LIST_HEAD(&cm.timewait_list);
 
 	ret = class_register(&cm_class);
drivers/infiniband/core/cma.c +7 -17
index d789eea..c32eeaa 100644
@@ -2143,33 +2143,23 @@ static int cma_alloc_port(struct idr *ps, struct rdma_id_private *id_priv,
 			  unsigned short snum)
 {
 	struct rdma_bind_list *bind_list;
-	int port, ret;
+	int ret;
 
 	bind_list = kzalloc(sizeof *bind_list, GFP_KERNEL);
 	if (!bind_list)
 		return -ENOMEM;
 
-	do {
-		ret = idr_get_new_above(ps, bind_list, snum, &port);
-	} while ((ret == -EAGAIN) && idr_pre_get(ps, GFP_KERNEL));
-
-	if (ret)
-		goto err1;
-
-	if (port != snum) {
-		ret = -EADDRNOTAVAIL;
-		goto err2;
-	}
+	ret = idr_alloc(ps, bind_list, snum, snum + 1, GFP_KERNEL);
+	if (ret < 0)
+		goto err;
 
 	bind_list->ps = ps;
-	bind_list->port = (unsigned short) port;
+	bind_list->port = (unsigned short)ret;
 	cma_bind_port(bind_list, id_priv);
 	return 0;
-err2:
-	idr_remove(ps, port);
-err1:
+err:
 	kfree(bind_list);
-	return ret;
+	return ret == -ENOSPC ? -EADDRNOTAVAIL : ret;
 }
 
 static int cma_alloc_any_port(struct idr *ps, struct rdma_id_private *id_priv)
drivers/infiniband/core/sa_query.c +7 -8
index a8905ab..dc64bae 100644
@@ -614,16 +614,15 @@ static int send_mad(struct ib_sa_query *query, int timeout_ms, gfp_t gfp_mask)
 	unsigned long flags;
 	int ret, id;
 
-retry:
-	if (!idr_pre_get(&query_idr, gfp_mask))
-		return -ENOMEM;
+	idr_preload(gfp_mask);
 	spin_lock_irqsave(&idr_lock, flags);
-	ret = idr_get_new(&query_idr, query, &id);
+
+	id = idr_alloc(&query_idr, query, 0, 0, GFP_NOWAIT);
+
 	spin_unlock_irqrestore(&idr_lock, flags);
-	if (ret == -EAGAIN)
-		goto retry;
-	if (ret)
-		return ret;
+	idr_preload_end();
+	if (id < 0)
+		return id;
 
 	query->mad_buf->timeout_ms  = timeout_ms;
 	query->mad_buf->context[0] = query;
drivers/infiniband/core/ucm.c +4 -12
index 49b15ac..f2f6393 100644
@@ -176,7 +176,6 @@ static void ib_ucm_cleanup_events(struct ib_ucm_context *ctx)
 static struct ib_ucm_context *ib_ucm_ctx_alloc(struct ib_ucm_file *file)
 {
 	struct ib_ucm_context *ctx;
-	int result;
 
 	ctx = kzalloc(sizeof *ctx, GFP_KERNEL);
 	if (!ctx)
@@ -187,17 +186,10 @@ static struct ib_ucm_context *ib_ucm_ctx_alloc(struct ib_ucm_file *file)
 	ctx->file = file;
 	INIT_LIST_HEAD(&ctx->events);
 
-	do {
-		result = idr_pre_get(&ctx_id_table, GFP_KERNEL);
-		if (!result)
-			goto error;
-
-		mutex_lock(&ctx_id_mutex);
-		result = idr_get_new(&ctx_id_table, ctx, &ctx->id);
-		mutex_unlock(&ctx_id_mutex);
-	} while (result == -EAGAIN);
-
-	if (result)
+	mutex_lock(&ctx_id_mutex);
+	ctx->id = idr_alloc(&ctx_id_table, ctx, 0, 0, GFP_KERNEL);
+	mutex_unlock(&ctx_id_mutex);
+	if (ctx->id < 0)
 		goto error;
 
 	list_add_tail(&ctx->file_list, &file->ctxs);
drivers/infiniband/core/ucma.c +8 -24
index 2709ff5..5ca44cd 100644
@@ -145,7 +145,6 @@ static void ucma_put_ctx(struct ucma_context *ctx)
 static struct ucma_context *ucma_alloc_ctx(struct ucma_file *file)
 {
 	struct ucma_context *ctx;
-	int ret;
 
 	ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
 	if (!ctx)
@@ -156,17 +155,10 @@ static struct ucma_context *ucma_alloc_ctx(struct ucma_file *file)
 	INIT_LIST_HEAD(&ctx->mc_list);
 	ctx->file = file;
 
-	do {
-		ret = idr_pre_get(&ctx_idr, GFP_KERNEL);
-		if (!ret)
-			goto error;
-
-		mutex_lock(&mut);
-		ret = idr_get_new(&ctx_idr, ctx, &ctx->id);
-		mutex_unlock(&mut);
-	} while (ret == -EAGAIN);
-
-	if (ret)
+	mutex_lock(&mut);
+	ctx->id = idr_alloc(&ctx_idr, ctx, 0, 0, GFP_KERNEL);
+	mutex_unlock(&mut);
+	if (ctx->id < 0)
 		goto error;
 
 	list_add_tail(&ctx->list, &file->ctx_list);
@@ -180,23 +172,15 @@ error:
 static struct ucma_multicast* ucma_alloc_multicast(struct ucma_context *ctx)
 {
 	struct ucma_multicast *mc;
-	int ret;
 
 	mc = kzalloc(sizeof(*mc), GFP_KERNEL);
 	if (!mc)
 		return NULL;
 
-	do {
-		ret = idr_pre_get(&multicast_idr, GFP_KERNEL);
-		if (!ret)
-			goto error;
-
-		mutex_lock(&mut);
-		ret = idr_get_new(&multicast_idr, mc, &mc->id);
-		mutex_unlock(&mut);
-	} while (ret == -EAGAIN);
-
-	if (ret)
+	mutex_lock(&mut);
+	mc->id = idr_alloc(&multicast_idr, mc, 0, 0, GFP_KERNEL);
+	mutex_unlock(&mut);
+	if (mc->id < 0)
 		goto error;
 
 	mc->ctx = ctx;
drivers/infiniband/core/uverbs_cmd.c +8 -9
index 0cb0007..83bc309 100644
@@ -124,18 +124,17 @@ static int idr_add_uobj(struct idr *idr, struct ib_uobject *uobj)
 {
 	int ret;
 
-retry:
-	if (!idr_pre_get(idr, GFP_KERNEL))
-		return -ENOMEM;
-
+	idr_preload(GFP_KERNEL);
 	spin_lock(&ib_uverbs_idr_lock);
-	ret = idr_get_new(idr, uobj, &uobj->id);
-	spin_unlock(&ib_uverbs_idr_lock);
 
-	if (ret == -EAGAIN)
-		goto retry;
+	ret = idr_alloc(idr, uobj, 0, 0, GFP_NOWAIT);
+	if (ret >= 0)
+		uobj->id = ret;
 
-	return ret;
+	spin_unlock(&ib_uverbs_idr_lock);
+	idr_preload_end();
+
+	return ret < 0 ? ret : 0;
 }
 
 void idr_remove_uobj(struct idr *idr, struct ib_uobject *uobj)
Signature · 1 line
1.8.1
author maintainer
#39 lore raw

PATCH v2 22/62 infiniband/core: convert to idr_alloc()

Convert to the much saner new idr interface.

Only compile tested.

v2: Mike triggered WARN_ON() in idr_preload() because send_mad(),
which may be used from non-process context, was calling idr_preload() unconditionally. Preload iff @gfp_mask has __GFP_WAIT.

---
 drivers/infiniband/core/cm.c         |   22 +++++++++++-----------
 drivers/infiniband/core/cma.c        |   24 +++++++-----------------
 drivers/infiniband/core/sa_query.c   |   18 ++++++++++--------
 drivers/infiniband/core/ucm.c        |   16 ++++------------
 drivers/infiniband/core/ucma.c       |   32 ++++++++------------------------
 drivers/infiniband/core/uverbs_cmd.c |   17 ++++++++---------
 6 files changed, 48 insertions(+), 81 deletions(-)
drivers/infiniband/core/cm.c +11 -11
@@ -382,20 +382,21 @@ static int cm_init_av_by_path(struct ib_
 static int cm_alloc_id(struct cm_id_private *cm_id_priv)
 {
 	unsigned long flags;
-	int ret, id;
+	int id;
 	static int next_id;
 
-	do {
-		spin_lock_irqsave(&cm.lock, flags);
-		ret = idr_get_new_above(&cm.local_id_table, cm_id_priv,
-					next_id, &id);
-		if (!ret)
-			next_id = ((unsigned) id + 1) & MAX_IDR_MASK;
-		spin_unlock_irqrestore(&cm.lock, flags);
-	} while( (ret == -EAGAIN) && idr_pre_get(&cm.local_id_table, GFP_KERNEL) );
+	idr_preload(GFP_KERNEL);
+	spin_lock_irqsave(&cm.lock, flags);
+
+	id = idr_alloc(&cm.local_id_table, cm_id_priv, next_id, 0, GFP_NOWAIT);
+	if (id >= 0)
+		next_id = ((unsigned) id + 1) & MAX_IDR_MASK;
+
+	spin_unlock_irqrestore(&cm.lock, flags);
+	idr_preload_end();
 
 	cm_id_priv->id.local_id = (__force __be32)id ^ cm.random_id_operand;
-	return ret;
+	return id < 0 ? id : 0;
 }
 
 static void cm_free_id(__be32 local_id)
@@ -3844,7 +3845,6 @@ static int __init ib_cm_init(void)
 	cm.remote_sidr_table = RB_ROOT;
 	idr_init(&cm.local_id_table);
 	get_random_bytes(&cm.random_id_operand, sizeof cm.random_id_operand);
-	idr_pre_get(&cm.local_id_table, GFP_KERNEL);
 	INIT_LIST_HEAD(&cm.timewait_list);
 
 	ret = class_register(&cm_class);
drivers/infiniband/core/cma.c +7 -17
@@ -2143,33 +2143,23 @@ static int cma_alloc_port(struct idr *ps
 			  unsigned short snum)
 {
 	struct rdma_bind_list *bind_list;
-	int port, ret;
+	int ret;
 
 	bind_list = kzalloc(sizeof *bind_list, GFP_KERNEL);
 	if (!bind_list)
 		return -ENOMEM;
 
-	do {
-		ret = idr_get_new_above(ps, bind_list, snum, &port);
-	} while ((ret == -EAGAIN) && idr_pre_get(ps, GFP_KERNEL));
-
-	if (ret)
-		goto err1;
-
-	if (port != snum) {
-		ret = -EADDRNOTAVAIL;
-		goto err2;
-	}
+	ret = idr_alloc(ps, bind_list, snum, snum + 1, GFP_KERNEL);
+	if (ret < 0)
+		goto err;
 
 	bind_list->ps = ps;
-	bind_list->port = (unsigned short) port;
+	bind_list->port = (unsigned short)ret;
 	cma_bind_port(bind_list, id_priv);
 	return 0;
-err2:
-	idr_remove(ps, port);
-err1:
+err:
 	kfree(bind_list);
-	return ret;
+	return ret == -ENOSPC ? -EADDRNOTAVAIL : ret;
 }
 
 static int cma_alloc_any_port(struct idr *ps, struct rdma_id_private *id_priv)
drivers/infiniband/core/sa_query.c +10 -8
@@ -611,19 +611,21 @@ static void init_mad(struct ib_sa_mad *m
 
 static int send_mad(struct ib_sa_query *query, int timeout_ms, gfp_t gfp_mask)
 {
+	bool preload = gfp_mask & __GFP_WAIT;
 	unsigned long flags;
 	int ret, id;
 
-retry:
-	if (!idr_pre_get(&query_idr, gfp_mask))
-		return -ENOMEM;
+	if (preload)
+		idr_preload(gfp_mask);
 	spin_lock_irqsave(&idr_lock, flags);
-	ret = idr_get_new(&query_idr, query, &id);
+
+	id = idr_alloc(&query_idr, query, 0, 0, GFP_NOWAIT);
+
 	spin_unlock_irqrestore(&idr_lock, flags);
-	if (ret == -EAGAIN)
-		goto retry;
-	if (ret)
-		return ret;
+	if (preload)
+		idr_preload_end();
+	if (id < 0)
+		return id;
 
 	query->mad_buf->timeout_ms  = timeout_ms;
 	query->mad_buf->context[0] = query;
drivers/infiniband/core/ucm.c +4 -12
@@ -176,7 +176,6 @@ static void ib_ucm_cleanup_events(struct
 static struct ib_ucm_context *ib_ucm_ctx_alloc(struct ib_ucm_file *file)
 {
 	struct ib_ucm_context *ctx;
-	int result;
 
 	ctx = kzalloc(sizeof *ctx, GFP_KERNEL);
 	if (!ctx)
@@ -187,17 +186,10 @@ static struct ib_ucm_context *ib_ucm_ctx
 	ctx->file = file;
 	INIT_LIST_HEAD(&ctx->events);
 
-	do {
-		result = idr_pre_get(&ctx_id_table, GFP_KERNEL);
-		if (!result)
-			goto error;
-
-		mutex_lock(&ctx_id_mutex);
-		result = idr_get_new(&ctx_id_table, ctx, &ctx->id);
-		mutex_unlock(&ctx_id_mutex);
-	} while (result == -EAGAIN);
-
-	if (result)
+	mutex_lock(&ctx_id_mutex);
+	ctx->id = idr_alloc(&ctx_id_table, ctx, 0, 0, GFP_KERNEL);
+	mutex_unlock(&ctx_id_mutex);
+	if (ctx->id < 0)
 		goto error;
 
 	list_add_tail(&ctx->file_list, &file->ctxs);
drivers/infiniband/core/ucma.c +8 -24
@@ -145,7 +145,6 @@ static void ucma_put_ctx(struct ucma_con
 static struct ucma_context *ucma_alloc_ctx(struct ucma_file *file)
 {
 	struct ucma_context *ctx;
-	int ret;
 
 	ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
 	if (!ctx)
@@ -156,17 +155,10 @@ static struct ucma_context *ucma_alloc_c
 	INIT_LIST_HEAD(&ctx->mc_list);
 	ctx->file = file;
 
-	do {
-		ret = idr_pre_get(&ctx_idr, GFP_KERNEL);
-		if (!ret)
-			goto error;
-
-		mutex_lock(&mut);
-		ret = idr_get_new(&ctx_idr, ctx, &ctx->id);
-		mutex_unlock(&mut);
-	} while (ret == -EAGAIN);
-
-	if (ret)
+	mutex_lock(&mut);
+	ctx->id = idr_alloc(&ctx_idr, ctx, 0, 0, GFP_KERNEL);
+	mutex_unlock(&mut);
+	if (ctx->id < 0)
 		goto error;
 
 	list_add_tail(&ctx->list, &file->ctx_list);
@@ -180,23 +172,15 @@ error:
 static struct ucma_multicast* ucma_alloc_multicast(struct ucma_context *ctx)
 {
 	struct ucma_multicast *mc;
-	int ret;
 
 	mc = kzalloc(sizeof(*mc), GFP_KERNEL);
 	if (!mc)
 		return NULL;
 
-	do {
-		ret = idr_pre_get(&multicast_idr, GFP_KERNEL);
-		if (!ret)
-			goto error;
-
-		mutex_lock(&mut);
-		ret = idr_get_new(&multicast_idr, mc, &mc->id);
-		mutex_unlock(&mut);
-	} while (ret == -EAGAIN);
-
-	if (ret)
+	mutex_lock(&mut);
+	mc->id = idr_alloc(&multicast_idr, mc, 0, 0, GFP_KERNEL);
+	mutex_unlock(&mut);
+	if (mc->id < 0)
 		goto error;
 
 	mc->ctx = ctx;
drivers/infiniband/core/uverbs_cmd.c +8 -9
@@ -124,18 +124,17 @@ static int idr_add_uobj(struct idr *idr,
 {
 	int ret;
 
-retry:
-	if (!idr_pre_get(idr, GFP_KERNEL))
-		return -ENOMEM;
-
+	idr_preload(GFP_KERNEL);
 	spin_lock(&ib_uverbs_idr_lock);
-	ret = idr_get_new(idr, uobj, &uobj->id);
-	spin_unlock(&ib_uverbs_idr_lock);
 
-	if (ret == -EAGAIN)
-		goto retry;
+	ret = idr_alloc(idr, uobj, 0, 0, GFP_NOWAIT);
+	if (ret >= 0)
+		uobj->id = ret;
+
+	spin_unlock(&ib_uverbs_idr_lock);
+	idr_preload_end();
 
-	return ret;
+	return ret < 0 ? ret : 0;
 }
 
 void idr_remove_uobj(struct idr *idr, struct ib_uobject *uobj)

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

author maintainer
#41 lore raw

PATCH 23/62 infiniband/amso1100: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/infiniband/hw/amso1100/c2_qp.c | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)
drivers/infiniband/hw/amso1100/c2_qp.c +11 -8
index 28cd5cb..0ab826b 100644
@@ -382,14 +382,17 @@ static int c2_alloc_qpn(struct c2_dev *c2dev, struct c2_qp *qp)
 {
 	int ret;
 
-        do {
-		spin_lock_irq(&c2dev->qp_table.lock);
-		ret = idr_get_new_above(&c2dev->qp_table.idr, qp,
-					c2dev->qp_table.last++, &qp->qpn);
-		spin_unlock_irq(&c2dev->qp_table.lock);
-        } while ((ret == -EAGAIN) &&
-	 	 idr_pre_get(&c2dev->qp_table.idr, GFP_KERNEL));
-	return ret;
+	idr_preload(GFP_KERNEL);
+	spin_lock_irq(&c2dev->qp_table.lock);
+
+	ret = idr_alloc(&c2dev->qp_table.idr, qp, c2dev->qp_table.last++, 0,
+			GFP_NOWAIT);
+	if (ret >= 0)
+		qp->qpn = ret;
+
+	spin_unlock_irq(&c2dev->qp_table.lock);
+	idr_preload_end();
+	return ret < 0 ? ret : 0;
 }
 
 static void c2_free_qpn(struct c2_dev *c2dev, int qpn)
Signature · 1 line
1.8.1
author maintainer
#43 lore raw

PATCH 24/62 infiniband/cxgb3: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/infiniband/hw/cxgb3/iwch.h | 24 +++++++++++-------------
 1 file changed, 11 insertions(+), 13 deletions(-)
drivers/infiniband/hw/cxgb3/iwch.h +11 -13
index a1c4457..8378622 100644
@@ -153,19 +153,17 @@ static inline int insert_handle(struct iwch_dev *rhp, struct idr *idr,
 				void *handle, u32 id)
 {
 	int ret;
-	int newid;
-
-	do {
-		if (!idr_pre_get(idr, GFP_KERNEL)) {
-			return -ENOMEM;
-		}
-		spin_lock_irq(&rhp->lock);
-		ret = idr_get_new_above(idr, handle, id, &newid);
-		BUG_ON(newid != id);
-		spin_unlock_irq(&rhp->lock);
-	} while (ret == -EAGAIN);
-
-	return ret;
+
+	idr_preload(GFP_KERNEL);
+	spin_lock_irq(&rhp->lock);
+
+	ret = idr_alloc(idr, handle, id, id + 1, GFP_NOWAIT);
+
+	spin_unlock_irq(&rhp->lock);
+	idr_preload_end();
+
+	BUG_ON(ret == -ENOSPC);
+	return ret < 0 ? ret : 0;
 }
 
 static inline void remove_handle(struct iwch_dev *rhp, struct idr *idr, u32 id)
Signature · 1 line
1.8.1
author maintainer
#45 lore raw

PATCH 25/62 infiniband/cxgb4: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/infiniband/hw/cxgb4/iw_cxgb4.h | 27 ++++++++++++++-------------
 1 file changed, 14 insertions(+), 13 deletions(-)
drivers/infiniband/hw/cxgb4/iw_cxgb4.h +14 -13
index 9c1644f..7f862da 100644
@@ -260,20 +260,21 @@ static inline int _insert_handle(struct c4iw_dev *rhp, struct idr *idr,
 				 void *handle, u32 id, int lock)
 {
 	int ret;
-	int newid;
 
-	do {
-		if (!idr_pre_get(idr, lock ? GFP_KERNEL : GFP_ATOMIC))
-			return -ENOMEM;
-		if (lock)
-			spin_lock_irq(&rhp->lock);
-		ret = idr_get_new_above(idr, handle, id, &newid);
-		BUG_ON(!ret && newid != id);
-		if (lock)
-			spin_unlock_irq(&rhp->lock);
-	} while (ret == -EAGAIN);
-
-	return ret;
+	if (lock) {
+		idr_preload(GFP_KERNEL);
+		spin_lock_irq(&rhp->lock);
+	}
+
+	ret = idr_alloc(idr, handle, id, id + 1, GFP_ATOMIC);
+
+	if (lock) {
+		spin_unlock_irq(&rhp->lock);
+		idr_preload_end();
+	}
+
+	BUG_ON(ret == -ENOSPC);
+	return ret < 0 ? ret : 0;
 }
 
 static inline int insert_handle(struct c4iw_dev *rhp, struct idr *idr,
Signature · 6 lines
1.8.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#46 lore raw

Re: [PATCH 25/62] infiniband/cxgb4: convert to idr_alloc()

Quoted 11 lines · Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

Is there a git tree somewhere that I can use to test these patches out?

Quoted 19 lines
  drivers/infiniband/hw/cxgb4/iw_cxgb4.h | 27 ++++++++++++++-------------
  1 file changed, 14 insertions(+), 13 deletions(-)
drivers/infiniband/hw/cxgb4/iw_cxgb4.h +0 -7
index 9c1644f..7f862da 100644
@@ -260,20 +260,21 @@ static inline int _insert_handle(struct c4iw_dev *rhp, struct idr *idr,
  				 void *handle, u32 id, int lock)
  {
  	int ret;
-	int newid;
 
-	do {
-		if (!idr_pre_get(idr, lock ? GFP_KERNEL : GFP_ATOMIC))
-			return -ENOMEM;
-		if (lock)
-			spin_lock_irq(&rhp->lock);
-		ret = idr_get_new_above(idr, handle, id, &newid);

drivers/infiniband/hw/cxgb4/iw_cxgb4.h static inline int _insert_handle(struct c4iw_dev *rhp, struct idr *idr, · line 267

Quoted 10 lines
drivers/infiniband/hw/cxgb4/iw_cxgb4.h +4 -6
-		BUG_ON(!ret && newid != id);
-		if (lock)
-			spin_unlock_irq(&rhp->lock);
-	} while (ret == -EAGAIN);
-
-	return ret;
+	if (lock) {
+		idr_preload(GFP_KERNEL);
+		spin_lock_irq(&rhp->lock);
+	}

The idr_preload() needs to be above the 'if (lock)', no?

drivers/infiniband/hw/cxgb4/iw_cxgb4.h static inline int _insert_handle(struct c4iw_dev *rhp, struct idr *idr, · line 274

Quoted 7 lines
drivers/infiniband/hw/cxgb4/iw_cxgb4.h +7 -0
+
+	ret = idr_alloc(idr, handle, id, id + 1, GFP_ATOMIC);
+
+	if (lock) {
+		spin_unlock_irq(&rhp->lock);
+		idr_preload_end();
+	}

And idr_preload_end() should be after the 'if (lock)' block methinks...

drivers/infiniband/hw/cxgb4/iw_cxgb4.h static inline int _insert_handle(struct c4iw_dev *rhp, struct idr *idr, · line 277

Quoted 3 lines
drivers/infiniband/hw/cxgb4/iw_cxgb4.h +3 -0
+
+	BUG_ON(ret == -ENOSPC);
+	return ret < 0 ? ret : 0;

What would cause ret > 0?

drivers/infiniband/hw/cxgb4/iw_cxgb4.h static inline int _insert_handle(struct c4iw_dev *rhp, struct idr *idr, · line 280

Quoted 3 lines
drivers/infiniband/hw/cxgb4/iw_cxgb4.h +0 -0
  }
 
  static inline int insert_handle(struct c4iw_dev *rhp, struct idr *idr,

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

author maintainer
#47 lore raw

Re: [PATCH 25/62] infiniband/cxgb4: convert to idr_alloc()

Hello,

Quoted 1 line · Steve Wise

Is there a git tree somewhere that I can use to test these patches out?

git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git convert-to-idr_alloc

Quoted 7 lines

drivers/infiniband/hw/cxgb4/iw_cxgb4.h static inline int _insert_handle(struct c4iw_dev *rhp, struct idr *idr, · line 267

Quoted 5 lines
drivers/infiniband/hw/cxgb4/iw_cxgb4.h +4 -1
-       return ret;
+       if (lock) {
+               idr_preload(GFP_KERNEL);
+               spin_lock_irq(&rhp->lock);
+       }

The idr_preload() needs to be above the 'if (lock)', no?

No reason to preload for ATOMIC allocation. idr_alloc() can be called by itself.

Quoted 9 lines

drivers/infiniband/hw/cxgb4/iw_cxgb4.h static inline int _insert_handle(struct c4iw_dev *rhp, struct idr *idr, · line 274

Quoted 7 lines
drivers/infiniband/hw/cxgb4/iw_cxgb4.h +7 -0
+
+       ret = idr_alloc(idr, handle, id, id + 1, GFP_ATOMIC);
+
+       if (lock) {
+               spin_unlock_irq(&rhp->lock);
+               idr_preload_end();
+       }

And idr_preload_end() should be after the 'if (lock)' block methinks...

Ditto.

Quoted 5 lines

drivers/infiniband/hw/cxgb4/iw_cxgb4.h static inline int _insert_handle(struct c4iw_dev *rhp, struct idr *idr, · line 277

Quoted 3 lines
drivers/infiniband/hw/cxgb4/iw_cxgb4.h +3 -0
+
+       BUG_ON(ret == -ENOSPC);
+       return ret < 0 ? ret : 0;

What would cause ret > 0?

It's the allocated id. In this case, ret would either be @id or -errno.

Thanks.

Signature · 1 line
tejun
author maintainer
#49 lore raw

PATCH 26/62 infiniband/ehca: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

Cc Hoang-Nam Nguyen <[email protected]>
Cc Christoph Raisch <[email protected]>

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/infiniband/hw/ehca/ehca_cq.c | 27 +++++++--------------------
 drivers/infiniband/hw/ehca/ehca_qp.c | 34 +++++++++++++++-------------------
 2 files changed, 22 insertions(+), 39 deletions(-)
drivers/infiniband/hw/ehca/ehca_cq.c +7 -20
index 8f52901..212150c 100644
@@ -128,7 +128,7 @@ struct ib_cq *ehca_create_cq(struct ib_device *device, int cqe, int comp_vector,
 	void *vpage;
 	u32 counter;
 	u64 rpage, cqx_fec, h_ret;
-	int ipz_rc, ret, i;
+	int ipz_rc, i;
 	unsigned long flags;
 
 	if (cqe >= 0xFFFFFFFF - 64 - additional_cqe)
@@ -163,32 +163,19 @@ struct ib_cq *ehca_create_cq(struct ib_device *device, int cqe, int comp_vector,
 	adapter_handle = shca->ipz_hca_handle;
 	param.eq_handle = shca->eq.ipz_eq_handle;
 
-	do {
-		if (!idr_pre_get(&ehca_cq_idr, GFP_KERNEL)) {
-			cq = ERR_PTR(-ENOMEM);
-			ehca_err(device, "Can't reserve idr nr. device=%p",
-				 device);
-			goto create_cq_exit1;
-		}
-
-		write_lock_irqsave(&ehca_cq_idr_lock, flags);
-		ret = idr_get_new(&ehca_cq_idr, my_cq, &my_cq->token);
-		write_unlock_irqrestore(&ehca_cq_idr_lock, flags);
-	} while (ret == -EAGAIN);
+	idr_preload(GFP_KERNEL);
+	write_lock_irqsave(&ehca_cq_idr_lock, flags);
+	my_cq->token = idr_alloc(&ehca_cq_idr, my_cq, 0, 0x2000000, GFP_NOWAIT);
+	write_unlock_irqrestore(&ehca_cq_idr_lock, flags);
+	idr_preload_end();
 
-	if (ret) {
+	if (my_cq->token < 0) {
 		cq = ERR_PTR(-ENOMEM);
 		ehca_err(device, "Can't allocate new idr entry. device=%p",
 			 device);
 		goto create_cq_exit1;
 	}
 
-	if (my_cq->token > 0x1FFFFFF) {
-		cq = ERR_PTR(-ENOMEM);
-		ehca_err(device, "Invalid number of cq. device=%p", device);
-		goto create_cq_exit2;
-	}
-
 	/*
 	 * CQs maximum depth is 4GB-64, but we need additional 20 as buffer
 	 * for receiving errors CQEs.
drivers/infiniband/hw/ehca/ehca_qp.c +15 -19
index 1493939..00d6861 100644
@@ -636,30 +636,26 @@ static struct ehca_qp *internal_create_qp(
 		my_qp->send_cq =
 			container_of(init_attr->send_cq, struct ehca_cq, ib_cq);
 
-	do {
-		if (!idr_pre_get(&ehca_qp_idr, GFP_KERNEL)) {
-			ret = -ENOMEM;
-			ehca_err(pd->device, "Can't reserve idr resources.");
-			goto create_qp_exit0;
-		}
+	idr_preload(GFP_KERNEL);
+	write_lock_irqsave(&ehca_qp_idr_lock, flags);
 
-		write_lock_irqsave(&ehca_qp_idr_lock, flags);
-		ret = idr_get_new(&ehca_qp_idr, my_qp, &my_qp->token);
-		write_unlock_irqrestore(&ehca_qp_idr_lock, flags);
-	} while (ret == -EAGAIN);
+	ret = idr_alloc(&ehca_qp_idr, my_qp, 0, 0x2000000, GFP_NOWAIT);
+	if (ret >= 0)
+		my_qp->token = ret;
 
-	if (ret) {
-		ret = -ENOMEM;
-		ehca_err(pd->device, "Can't allocate new idr entry.");
+	write_unlock_irqrestore(&ehca_qp_idr_lock, flags);
+	idr_preload_end();
+	if (ret < 0) {
+		if (ret == -ENOSPC) {
+			ret = -EINVAL;
+			ehca_err(pd->device, "Invalid number of qp");
+		} else {
+			ret = -ENOMEM;
+			ehca_err(pd->device, "Can't allocate new idr entry.");
+		}
 		goto create_qp_exit0;
 	}
 
-	if (my_qp->token > 0x1FFFFFF) {
-		ret = -EINVAL;
-		ehca_err(pd->device, "Invalid number of qp");
-		goto create_qp_exit1;
-	}
-
 	if (has_srq)
 		parms.srq_token = my_qp->token;
 
Signature · 6 lines
1.8.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
author maintainer
#50 lore raw

PATCH 27/62 infiniband/ipath: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/infiniband/hw/ipath/ipath_driver.c | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)
drivers/infiniband/hw/ipath/ipath_driver.c +4 -12
index 7b371f5..fcdaeea 100644
@@ -194,11 +194,6 @@ static struct ipath_devdata *ipath_alloc_devdata(struct pci_dev *pdev)
 	struct ipath_devdata *dd;
 	int ret;
 
-	if (!idr_pre_get(&unit_table, GFP_KERNEL)) {
-		dd = ERR_PTR(-ENOMEM);
-		goto bail;
-	}
-
 	dd = vzalloc(sizeof(*dd));
 	if (!dd) {
 		dd = ERR_PTR(-ENOMEM);
@@ -206,9 +201,10 @@ static struct ipath_devdata *ipath_alloc_devdata(struct pci_dev *pdev)
 	}
 	dd->ipath_unit = -1;
 
+	idr_preload(GFP_KERNEL);
 	spin_lock_irqsave(&ipath_devs_lock, flags);
 
-	ret = idr_get_new(&unit_table, dd, &dd->ipath_unit);
+	ret = idr_alloc(&unit_table, dd, 0, 0, GFP_KERNEL);
 	if (ret < 0) {
 		printk(KERN_ERR IPATH_DRV_NAME
 		       ": Could not allocate unit ID: error %d\n", -ret);
@@ -216,6 +212,7 @@ static struct ipath_devdata *ipath_alloc_devdata(struct pci_dev *pdev)
 		dd = ERR_PTR(ret);
 		goto bail_unlock;
 	}
+	dd->ipath_unit = ret;
 
 	dd->pcidev = pdev;
 	pci_set_drvdata(pdev, dd);
@@ -224,7 +221,7 @@ static struct ipath_devdata *ipath_alloc_devdata(struct pci_dev *pdev)
 
 bail_unlock:
 	spin_unlock_irqrestore(&ipath_devs_lock, flags);
-
+	idr_preload_end();
 bail:
 	return dd;
 }
@@ -2503,11 +2500,6 @@ static int __init infinipath_init(void)
 	 * the PCI subsystem.
 	 */
 	idr_init(&unit_table);
-	if (!idr_pre_get(&unit_table, GFP_KERNEL)) {
-		printk(KERN_ERR IPATH_DRV_NAME ": idr_pre_get() failed\n");
-		ret = -ENOMEM;
-		goto bail;
-	}
 
 	ret = pci_register_driver(&ipath_driver);
 	if (ret < 0) {
Signature · 1 line
1.8.1
#51 lore raw

RE: [PATCH 27/62] infiniband/ipath: convert to idr_alloc()

I tried the branch you indicated in the initial patch cover.

When run with a qib driver, and ipoib ping of another system produces:

Feb  4 11:05:39 phemb007 kernel: ------------[ cut here ]------------
Feb  4 11:05:39 phemb007 kernel: WARNING: at lib/idr.c:374 idr_preload+0xa9/0xc0()
Feb  4 11:05:39 phemb007 kernel: Hardware name: Relion 1751
Feb  4 11:05:39 phemb007 kernel: Modules linked in: autofs4 sunrpc ib_ipoib rdma_ucm ib_ucm ib_uverbs ib_umad rdma_cm ib_cm iw_cm ib_addr ipv6 ib_sa dm_mirror dm_region_hash dm_log dm_mod uinput iTCO_wdt iTCO_vendor_support sg coretemp hwmon kvm_intel kvm crc32c_intel microcode pcspkr i2c_i801 i2c_core lpc_ich mfd_core ioatdma i7core_edac edac_core ib_qib ib_mad ib_core igb dca ptp pps_core ext3 jbd mbcache sr_mod cdrom sd_mod crc_t10dif ahci libahci [last unloaded: speedstep_lib]
Feb  4 11:05:39 phemb007 kernel: Pid: 322, comm: kworker/u:5 Not tainted 3.8.0-rc4idr+ #1
Feb  4 11:05:39 phemb007 kernel: Call Trace:
Feb  4 11:05:39 phemb007 kernel: <IRQ>  [<ffffffff810553cf>] warn_slowpath_common+0x7f/0xc0
Feb  4 11:05:39 phemb007 kernel: [<ffffffff8105542a>] warn_slowpath_null+0x1a/0x20
Feb  4 11:05:39 phemb007 kernel: [<ffffffff81263679>] idr_preload+0xa9/0xc0
Feb  4 11:05:39 phemb007 kernel: [<ffffffffa026e25d>] send_mad+0x2d/0xf0 [ib_sa]
Feb  4 11:05:39 phemb007 kernel: [<ffffffffa026ed03>] ib_sa_path_rec_get+0x173/0x1e0 [ib_sa]
Feb  4 11:05:39 phemb007 kernel: [<ffffffffa033edae>] path_rec_start+0x9e/0x110 [ib_ipoib]
Feb  4 11:05:39 phemb007 kernel: [<ffffffffa03401b0>] ? ipoib_set_mode+0xe0/0xe0 [ib_ipoib]
Feb  4 11:05:39 phemb007 kernel: [<ffffffffa033fcb5>] unicast_arp_send+0x185/0x240 [ib_ipoib]
Feb  4 11:05:39 phemb007 kernel: [<ffffffffa0340db6>] ipoib_start_xmit+0x116/0x220 [ib_ipoib]
Feb  4 11:05:39 phemb007 kernel: [<ffffffff814742f2>] dev_hard_start_xmit+0x122/0x570
Feb  4 11:05:39 phemb007 kernel: [<ffffffff8149252a>] sch_direct_xmit+0xfa/0x1d0
Feb  4 11:05:39 phemb007 kernel: [<ffffffff8147488b>] dev_queue_xmit+0x14b/0x3e0
Feb  4 11:05:39 phemb007 kernel: [<ffffffff814db1d8>] arp_xmit+0x58/0x60
Feb  4 11:05:39 phemb007 kernel: [<ffffffff814db223>] arp_send+0x43/0x50
Feb  4 11:05:39 phemb007 kernel: [<ffffffff814dbcfe>] arp_process+0x5ee/0x630
Feb  4 11:05:39 phemb007 kernel: [<ffffffff811298c5>] ? put_page+0x25/0x40
Feb  4 11:05:39 phemb007 kernel: [<ffffffff814670cd>] ? __pskb_pull_tail+0x25d/0x340
Feb  4 11:05:39 phemb007 kernel: [<ffffffff814da9ed>] arp_rcv+0x10d/0x150
Feb  4 11:05:39 phemb007 kernel: [<ffffffff8147595e>] __netif_receive_skb+0x55e/0x770
Feb  4 11:05:39 phemb007 kernel: [<ffffffff81475d8d>] netif_receive_skb+0x2d/0x90
Feb  4 11:05:39 phemb007 kernel: [<ffffffff81476818>] napi_gro_receive+0x118/0x160
Feb  4 11:05:39 phemb007 kernel: [<ffffffffa0342fe4>] ipoib_ib_handle_rx_wc+0x184/0x2f0 [ib_ipoib]
Feb  4 11:05:39 phemb007 kernel: [<ffffffffa03433cb>] ipoib_poll+0x15b/0x190 [ib_ipoib]
Feb  4 11:05:39 phemb007 kernel: [<ffffffff81476473>] net_rx_action+0x103/0x280
Feb  4 11:05:39 phemb007 kernel: [<ffffffff8105dc37>] __do_softirq+0xd7/0x240
Feb  4 11:05:39 phemb007 kernel: [<ffffffff8154585c>] call_softirq+0x1c/0x30
Feb  4 11:05:39 phemb007 kernel: <EOI>  [<ffffffff81016465>] do_softirq+0x65/0xa0
Feb  4 11:05:39 phemb007 kernel: [<ffffffff8105dad4>] local_bh_enable+0x94/0xa0
Feb  4 11:05:39 phemb007 kernel: [<ffffffffa0109267>] send_complete+0x37/0x50 [ib_qib]
Feb  4 11:05:39 phemb007 kernel: [<ffffffff81072487>] process_one_work+0x177/0x430
Feb  4 11:05:39 phemb007 kernel: [<ffffffffa0109230>] ? qib_destroy_cq+0x90/0x90 [ib_qib]
Feb  4 11:05:39 phemb007 kernel: [<ffffffff8107441e>] worker_thread+0x12e/0x380
Feb  4 11:05:39 phemb007 kernel: [<ffffffff810742f0>] ? manage_workers+0x180/0x180
Feb  4 11:05:39 phemb007 kernel: [<ffffffff8107968e>] kthread+0xce/0xe0
Feb  4 11:05:39 phemb007 kernel: [<ffffffff810795c0>] ? kthread_freezable_should_stop+0x70/0x70
Feb  4 11:05:39 phemb007 kernel: [<ffffffff815444ac>] ret_from_fork+0x7c/0xb0
Feb  4 11:05:39 phemb007 kernel: [<ffffffff810795c0>] ? kthread_freezable_should_stop+0x70/0x70
Feb  4 11:05:39 phemb007 kernel: ---[ end trace 440364ae99db88da ]---

Looks like this is tripping during the arp/neighbour path resolution:

void idr_preload(gfp_t gfp_mask)

{
    /*
     * Consuming preload buffer from non-process context breaks preload
     * allocation guarantee.  Disallow usage from those contexts.
     */
    WARN_ON_ONCE(in_interrupt()); <------------------------

Any ideas Roland?

Mike

Quoted 86 lines

-----Original Message-----
From: Tejun Heo [mailto:[email protected]] On Behalf Of Tejun Heo
Sent: Saturday, February 02, 2013 8:20 PM
To: akpm-de/[email protected]
Cc: [email protected]; rusty-8n+1lVoiYb80n/[email protected]; [email protected]; [email protected]; ebiederm-aS9lmoZGLiVWk0Htik3J/[email protected]; jmorris-gx6/[email protected]; axboe-tSWWG44O7X1aa/[email protected]; Tejun Heo; infinipath; [email protected]
Subject: [PATCH 27/62] infiniband/ipath: convert to idr_alloc()

Convert to the much saner new idr interface.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/infiniband/hw/ipath/ipath_driver.c | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)
drivers/infiniband/hw/ipath/ipath_driver.c +0 -5
index 7b371f5..fcdaeea 100644
@@ -194,11 +194,6 @@ static struct ipath_devdata
 *ipath_alloc_devdata(struct pci_dev *pdev)
 	struct ipath_devdata *dd;
 	int ret;
 
-	if (!idr_pre_get(&unit_table, GFP_KERNEL)) {
-		dd = ERR_PTR(-ENOMEM);
-		goto bail;
-	}
-
 	dd = vzalloc(sizeof(*dd));
 	if (!dd) {
drivers/infiniband/hw/ipath/ipath_driver.c +2 -1
 		dd = ERR_PTR(-ENOMEM);
@@ -206,9 +201,10 @@ static struct ipath_devdata
 *ipath_alloc_devdata(struct pci_dev *pdev)
 	}
 	dd->ipath_unit = -1;
 
+	idr_preload(GFP_KERNEL);
 	spin_lock_irqsave(&ipath_devs_lock, flags);
 
-	ret = idr_get_new(&unit_table, dd, &dd->ipath_unit);
+	ret = idr_alloc(&unit_table, dd, 0, 0, GFP_KERNEL);
 	if (ret < 0) {
 		printk(KERN_ERR IPATH_DRV_NAME

": Could not allocate unit ID: error %d\n", -ret); @@ -216,6
+212,7 @@ static struct ipath_devdata *ipath_alloc_devdata(struct pci_dev *pdev)

drivers/infiniband/hw/ipath/ipath_driver.c +2 -1
 		dd = ERR_PTR(ret);
 		goto bail_unlock;
 	}
+	dd->ipath_unit = ret;
 
 	dd->pcidev = pdev;
 	pci_set_drvdata(pdev, dd);
@@ -224,7 +221,7 @@ static struct ipath_devdata *ipath_alloc_devdata(struct
 pci_dev *pdev)
 
 bail_unlock:
 	spin_unlock_irqrestore(&ipath_devs_lock, flags);
-
+	idr_preload_end();
 bail:
 	return dd;

}

drivers/infiniband/hw/ipath/ipath_driver.c +0 -5
@@ -2503,11 +2500,6 @@ static int __init infinipath_init(void)
 	 * the PCI subsystem.
 	 */
 	idr_init(&unit_table);
-	if (!idr_pre_get(&unit_table, GFP_KERNEL)) {
-		printk(KERN_ERR IPATH_DRV_NAME ": idr_pre_get()
 failed\n");
-		ret = -ENOMEM;
-		goto bail;
-	}
 
 	ret = pci_register_driver(&ipath_driver);
Quoted 3 lines

if (ret < 0) {
--
1.8.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

author maintainer
#52 lore raw

Re: [PATCH 27/62] infiniband/ipath: convert to idr_alloc()

Hello,

Quoted 3 lines · Mike

I tried the branch you indicated in the initial patch cover.

When run with a qib driver, and ipoib ping of another system produces:

...

Quoted 11 lines

Looks like this is tripping during the arp/neighbour path resolution:

void idr_preload(gfp_t gfp_mask)

{
    /*
     * Consuming preload buffer from non-process context breaks preload
     * allocation guarantee.  Disallow usage from those contexts.
     */
    WARN_ON_ONCE(in_interrupt()); <------------------------

Any ideas Roland?

Yeah, firewire had the same problem. It needs to conditionalize preload() if !__GFP_WAIT (no point anyway). Will send update patches soon.

Thanks.

Signature · 5 lines
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
author maintainer
#53 lore raw

PATCH 28/62 infiniband/mlx4: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

Cc Jack Morgenstein <[email protected]>
Cc Or Gerlitz <[email protected]>
Cc Roland Dreier <[email protected]>

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/infiniband/hw/mlx4/cm.c | 32 +++++++++++++++-----------------
 1 file changed, 15 insertions(+), 17 deletions(-)
drivers/infiniband/hw/mlx4/cm.c +15 -17
index dbc99d4..80e59ed 100644
@@ -203,7 +203,7 @@ static void sl_id_map_add(struct ib_device *ibdev, struct id_map_entry *new)
 static struct id_map_entry *
 id_map_alloc(struct ib_device *ibdev, int slave_id, u32 sl_cm_id)
 {
-	int ret, id;
+	int ret;
 	static int next_id;
 	struct id_map_entry *ent;
 	struct mlx4_ib_sriov *sriov = &to_mdev(ibdev)->sriov;
@@ -220,25 +220,23 @@ id_map_alloc(struct ib_device *ibdev, int slave_id, u32 sl_cm_id)
 	ent->dev = to_mdev(ibdev);
 	INIT_DELAYED_WORK(&ent->timeout, id_map_ent_timeout);
 
-	do {
-		spin_lock(&to_mdev(ibdev)->sriov.id_map_lock);
-		ret = idr_get_new_above(&sriov->pv_id_table, ent,
-					next_id, &id);
-		if (!ret) {
-			next_id = ((unsigned) id + 1) & MAX_IDR_MASK;
-			ent->pv_cm_id = (u32)id;
-			sl_id_map_add(ibdev, ent);
-		}
+	idr_preload(GFP_KERNEL);
+	spin_lock(&to_mdev(ibdev)->sriov.id_map_lock);
 
-		spin_unlock(&sriov->id_map_lock);
-	} while (ret == -EAGAIN && idr_pre_get(&sriov->pv_id_table, GFP_KERNEL));
-	/*the function idr_get_new_above can return -ENOSPC, so don't insert in that case.*/
-	if (!ret) {
-		spin_lock(&sriov->id_map_lock);
+	ret = idr_alloc(&sriov->pv_id_table, ent, next_id, 0, GFP_NOWAIT);
+	if (ret >= 0) {
+		next_id = ((unsigned)ret + 1) & MAX_IDR_MASK;
+		ent->pv_cm_id = (u32)ret;
+		sl_id_map_add(ibdev, ent);
 		list_add_tail(&ent->list, &sriov->cm_list);
-		spin_unlock(&sriov->id_map_lock);
-		return ent;
 	}
+
+	spin_unlock(&sriov->id_map_lock);
+	idr_preload_end();
+
+	if (ret >= 0)
+		return ent;
+
 	/*error flow*/
 	kfree(ent);
 	mlx4_ib_warn(ibdev, "No more space in the idr (err:0x%x)\n", ret);
Signature · 1 line
1.8.1
author maintainer
#54 lore raw

PATCH 29/62 infiniband/ocrdma: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/infiniband/hw/ocrdma/ocrdma_main.c | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)
drivers/infiniband/hw/ocrdma/ocrdma_main.c +1 -13
index c4e0131..48928c8 100644
@@ -51,18 +51,6 @@ static DEFINE_IDR(ocrdma_dev_id);
 
 static union ib_gid ocrdma_zero_sgid;
 
-static int ocrdma_get_instance(void)
-{
-	int instance = 0;
-
-	/* Assign an unused number */
-	if (!idr_pre_get(&ocrdma_dev_id, GFP_KERNEL))
-		return -1;
-	if (idr_get_new(&ocrdma_dev_id, NULL, &instance))
-		return -1;
-	return instance;
-}
-
 void ocrdma_get_guid(struct ocrdma_dev *dev, u8 *guid)
 {
 	u8 mac_addr[6];
@@ -416,7 +404,7 @@ static struct ocrdma_dev *ocrdma_add(struct be_dev_info *dev_info)
 		goto idr_err;
 
 	memcpy(&dev->nic_info, dev_info, sizeof(*dev_info));
-	dev->id = ocrdma_get_instance();
+	dev->id = idr_alloc(&ocrdma_dev_id, NULL, 0, 0, GFP_KERNEL);
 	if (dev->id < 0)
 		goto idr_err;
 
Signature · 1 line
1.8.1
author maintainer
#55 lore raw

PATCH 30/62 infiniband/qib: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/infiniband/hw/qib/qib_init.c | 21 ++++++++-------------
 1 file changed, 8 insertions(+), 13 deletions(-)
drivers/infiniband/hw/qib/qib_init.c +8 -13
index ddf066d..50e33aa 100644
@@ -1060,22 +1060,23 @@ struct qib_devdata *qib_alloc_devdata(struct pci_dev *pdev, size_t extra)
 	struct qib_devdata *dd;
 	int ret;
 
-	if (!idr_pre_get(&qib_unit_table, GFP_KERNEL)) {
-		dd = ERR_PTR(-ENOMEM);
-		goto bail;
-	}
-
 	dd = (struct qib_devdata *) ib_alloc_device(sizeof(*dd) + extra);
 	if (!dd) {
 		dd = ERR_PTR(-ENOMEM);
 		goto bail;
 	}
 
+	idr_preload(GFP_KERNEL);
 	spin_lock_irqsave(&qib_devs_lock, flags);
-	ret = idr_get_new(&qib_unit_table, dd, &dd->unit);
-	if (ret >= 0)
+
+	ret = idr_alloc(&qib_unit_table, dd, 0, 0, GFP_NOWAIT);
+	if (ret >= 0) {
+		dd->unit = ret;
 		list_add(&dd->list, &qib_dev_list);
+	}
+
 	spin_unlock_irqrestore(&qib_devs_lock, flags);
+	idr_preload_end();
 
 	if (ret < 0) {
 		qib_early_err(&pdev->dev,
@@ -1180,11 +1181,6 @@ static int __init qlogic_ib_init(void)
 	 * the PCI subsystem.
 	 */
 	idr_init(&qib_unit_table);
-	if (!idr_pre_get(&qib_unit_table, GFP_KERNEL)) {
-		pr_err("idr_pre_get() failed\n");
-		ret = -ENOMEM;
-		goto bail_cq_wq;
-	}
 
 	ret = pci_register_driver(&qib_driver);
 	if (ret < 0) {
@@ -1199,7 +1195,6 @@ static int __init qlogic_ib_init(void)
 
 bail_unit:
 	idr_destroy(&qib_unit_table);
-bail_cq_wq:
 	destroy_workqueue(qib_cq_wq);
 bail_dev:
 	qib_dev_cleanup();
Signature · 1 line
1.8.1
author maintainer
#56 lore raw

PATCH 31/62 dm: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/md/dm.c | 54 +++++++++++++++---------------------------------------
 1 file changed, 15 insertions(+), 39 deletions(-)
drivers/md/dm.c +15 -39
index ea1a6ca..29cd4e2 100644
@@ -1753,62 +1753,38 @@ static void free_minor(int minor)
  */
 static int specific_minor(int minor)
 {
-	int r, m;
+	int r;
 
 	if (minor >= (1 << MINORBITS))
 		return -EINVAL;
 
-	r = idr_pre_get(&_minor_idr, GFP_KERNEL);
-	if (!r)
-		return -ENOMEM;
-
+	idr_preload(GFP_KERNEL);
 	spin_lock(&_minor_lock);
 
-	if (idr_find(&_minor_idr, minor)) {
-		r = -EBUSY;
-		goto out;
-	}
-
-	r = idr_get_new_above(&_minor_idr, MINOR_ALLOCED, minor, &m);
-	if (r)
-		goto out;
+	r = idr_alloc(&_minor_idr, MINOR_ALLOCED, minor, minor + 1, GFP_NOWAIT);
 
-	if (m != minor) {
-		idr_remove(&_minor_idr, m);
-		r = -EBUSY;
-		goto out;
-	}
-
-out:
 	spin_unlock(&_minor_lock);
-	return r;
+	idr_preload_end();
+	if (r < 0)
+		return r == -ENOSPC ? -EBUSY : r;
+	return 0;
 }
 
 static int next_free_minor(int *minor)
 {
-	int r, m;
-
-	r = idr_pre_get(&_minor_idr, GFP_KERNEL);
-	if (!r)
-		return -ENOMEM;
+	int r;
 
+	idr_preload(GFP_KERNEL);
 	spin_lock(&_minor_lock);
 
-	r = idr_get_new(&_minor_idr, MINOR_ALLOCED, &m);
-	if (r)
-		goto out;
-
-	if (m >= (1 << MINORBITS)) {
-		idr_remove(&_minor_idr, m);
-		r = -ENOSPC;
-		goto out;
-	}
-
-	*minor = m;
+	r = idr_alloc(&_minor_idr, MINOR_ALLOCED, 0, 1 << MINORBITS, GFP_NOWAIT);
 
-out:
 	spin_unlock(&_minor_lock);
-	return r;
+	idr_preload_end();
+	if (r < 0)
+		return r;
+	*minor = r;
+	return 0;
 }
 
 static const struct block_device_operations dm_blk_dops;
Signature · 1 line
1.8.1
author maintainer
#57 lore raw

PATCH 32/62 memstick: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/memstick/core/memstick.c    | 21 ++++++++++-----------
 drivers/memstick/core/mspro_block.c | 17 +++--------------
 2 files changed, 13 insertions(+), 25 deletions(-)
drivers/memstick/core/memstick.c +10 -11
index 56ff19c..ffcb10a 100644
@@ -512,18 +512,17 @@ int memstick_add_host(struct memstick_host *host)
 {
 	int rc;
 
-	while (1) {
-		if (!idr_pre_get(&memstick_host_idr, GFP_KERNEL))
-			return -ENOMEM;
+	idr_preload(GFP_KERNEL);
+	spin_lock(&memstick_host_lock);
 
-		spin_lock(&memstick_host_lock);
-		rc = idr_get_new(&memstick_host_idr, host, &host->id);
-		spin_unlock(&memstick_host_lock);
-		if (!rc)
-			break;
-		else if (rc != -EAGAIN)
-			return rc;
-	}
+	rc = idr_alloc(&memstick_host_idr, host, 0, 0, GFP_NOWAIT);
+	if (rc >= 0)
+		host->id = rc;
+
+	spin_unlock(&memstick_host_lock);
+	idr_preload_end();
+	if (rc < 0)
+		return rc;
 
 	dev_set_name(&host->dev, "memstick%u", host->id);
 
drivers/memstick/core/mspro_block.c +3 -14
index 9729b92..f12b78d 100644
@@ -1213,21 +1213,10 @@ static int mspro_block_init_disk(struct memstick_dev *card)
 	msb->page_size = be16_to_cpu(sys_info->unit_size);
 
 	mutex_lock(&mspro_block_disk_lock);
-	if (!idr_pre_get(&mspro_block_disk_idr, GFP_KERNEL)) {
-		mutex_unlock(&mspro_block_disk_lock);
-		return -ENOMEM;
-	}
-
-	rc = idr_get_new(&mspro_block_disk_idr, card, &disk_id);
+	disk_id = idr_alloc(&mspro_block_disk_idr, card, 0, 256, GFP_KERNEL);
 	mutex_unlock(&mspro_block_disk_lock);
-
-	if (rc)
-		return rc;
-
-	if ((disk_id << MSPRO_BLOCK_PART_SHIFT) > 255) {
-		rc = -ENOSPC;
-		goto out_release_id;
-	}
+	if (disk_id < 0)
+		return disk_id;
 
 	msb->disk = alloc_disk(1 << MSPRO_BLOCK_PART_SHIFT);
 	if (!msb->disk) {
Signature · 1 line
1.8.1
author maintainer
#58 lore raw

PATCH 33/62 mfd: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

Cc Samuel Ortiz <[email protected]>

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/mfd/rtsx_pcr.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)
drivers/mfd/rtsx_pcr.c +6 -7
index 7a7b0bd..76172d8 100644
@@ -1032,15 +1032,14 @@ static int rtsx_pci_probe(struct pci_dev *pcidev,
 	}
 	handle->pcr = pcr;
 
-	if (!idr_pre_get(&rtsx_pci_idr, GFP_KERNEL)) {
-		ret = -ENOMEM;
-		goto free_handle;
-	}
-
+	idr_preload(GFP_KERNEL);
 	spin_lock(&rtsx_pci_lock);
-	ret = idr_get_new(&rtsx_pci_idr, pcr, &pcr->id);
+	ret = idr_alloc(&rtsx_pci_idr, pcr, 0, 0, GFP_NOWAIT);
+	if (ret >= 0)
+		pcr->id = ret;
 	spin_unlock(&rtsx_pci_lock);
-	if (ret)
+	idr_preload_end();
+	if (ret < 0)
 		goto free_handle;
 
 	pcr->pci = pcidev;
Signature · 1 line
1.8.1
#59 lore raw

Re: [PATCH 33/62] mfd: convert to idr_alloc()

Hi Tejun,

Quoted 10 lines · Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

Cc Samuel Ortiz <[email protected]>

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

I'm fine with it. I already have some rtsx changes queued for the next merge window so that may trigger some conflicts. We'll see.

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/
author maintainer
#60 lore raw

PATCH 34/62 misc/c2port: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

Cc Arnd Bergmann <[email protected]>
Cc Rodolfo Giometti <[email protected]>

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/misc/c2port/core.c | 22 +++++++++-------------
 1 file changed, 9 insertions(+), 13 deletions(-)
drivers/misc/c2port/core.c +9 -13
index f428d86..f32550a 100644
@@ -885,7 +885,7 @@ struct c2port_device *c2port_device_register(char *name,
 					struct c2port_ops *ops, void *devdata)
 {
 	struct c2port_device *c2dev;
-	int id, ret;
+	int ret;
 
 	if (unlikely(!ops) || unlikely(!ops->access) || \
 		unlikely(!ops->c2d_dir) || unlikely(!ops->c2ck_set) || \
@@ -897,22 +897,18 @@ struct c2port_device *c2port_device_register(char *name,
 	if (unlikely(!c2dev))
 		return ERR_PTR(-ENOMEM);
 
-	ret = idr_pre_get(&c2port_idr, GFP_KERNEL);
-	if (!ret) {
-		ret = -ENOMEM;
-		goto error_idr_get_new;
-	}
-
+	idr_preload(GFP_KERNEL);
 	spin_lock_irq(&c2port_idr_lock);
-	ret = idr_get_new(&c2port_idr, c2dev, &id);
+	ret = idr_alloc(&c2port_idr, c2dev, 0, 0, GFP_NOWAIT);
 	spin_unlock_irq(&c2port_idr_lock);
+	idr_preload_end();
 
 	if (ret < 0)
-		goto error_idr_get_new;
-	c2dev->id = id;
+		goto error_idr_alloc;
+	c2dev->id = ret;
 
 	c2dev->dev = device_create(c2port_class, NULL, 0, c2dev,
-					"c2port%d", id);
+				   "c2port%d", c2dev->id);
 	if (unlikely(IS_ERR(c2dev->dev))) {
 		ret = PTR_ERR(c2dev->dev);
 		goto error_device_create;
@@ -946,10 +942,10 @@ error_device_create_bin_file:
 
 error_device_create:
 	spin_lock_irq(&c2port_idr_lock);
-	idr_remove(&c2port_idr, id);
+	idr_remove(&c2port_idr, c2dev->id);
 	spin_unlock_irq(&c2port_idr_lock);
 
-error_idr_get_new:
+error_idr_alloc:
 	kfree(c2dev);
 
 	return ERR_PTR(ret);
Signature · 1 line
1.8.1
author maintainer
#61 lore raw

PATCH 35/62 misc/tifm_core: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

Cc Arnd Bergmann <[email protected]>
Cc Alex Dubov <[email protected]>

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/misc/tifm_core.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
drivers/misc/tifm_core.c +6 -5
index 0bd5349..0ab7c92 100644
@@ -196,13 +196,14 @@ int tifm_add_adapter(struct tifm_adapter *fm)
 {
 	int rc;
 
-	if (!idr_pre_get(&tifm_adapter_idr, GFP_KERNEL))
-		return -ENOMEM;
-
+	idr_preload(GFP_KERNEL);
 	spin_lock(&tifm_adapter_lock);
-	rc = idr_get_new(&tifm_adapter_idr, fm, &fm->id);
+	rc = idr_alloc(&tifm_adapter_idr, fm, 0, 0, GFP_NOWAIT);
+	if (rc >= 0)
+		fm->id = rc;
 	spin_unlock(&tifm_adapter_lock);
-	if (rc)
+	idr_preload_end();
+	if (rc < 0)
 		return rc;
 
 	dev_set_name(&fm->dev, "tifm%u", fm->id);
Signature · 1 line
1.8.1
author maintainer
#62 lore raw

PATCH 36/62 mmc: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/mmc/core/host.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
drivers/mmc/core/host.c +6 -5
index ee2e16b..1117de7 100644
@@ -306,19 +306,20 @@ struct mmc_host *mmc_alloc_host(int extra, struct device *dev)
 	int err;
 	struct mmc_host *host;
 
-	if (!idr_pre_get(&mmc_host_idr, GFP_KERNEL))
-		return NULL;
-
 	host = kzalloc(sizeof(struct mmc_host) + extra, GFP_KERNEL);
 	if (!host)
 		return NULL;
 
 	/* scanning will be enabled when we're ready */
 	host->rescan_disable = 1;
+	idr_preload(GFP_KERNEL);
 	spin_lock(&mmc_host_lock);
-	err = idr_get_new(&mmc_host_idr, host, &host->index);
+	err = idr_alloc(&mmc_host_idr, host, 0, 0, GFP_NOWAIT);
+	if (err >= 0)
+		host->index = err;
 	spin_unlock(&mmc_host_lock);
-	if (err)
+	idr_preload_end();
+	if (err < 0)
 		goto free;
 
 	dev_set_name(&host->class_dev, "mmc%d", host->index);
Signature · 1 line
1.8.1
author maintainer
#63 lore raw

PATCH 37/62 mtd: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/mtd/mtdcore.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)
drivers/mtd/mtdcore.c +2 -7
index ec794a7..61d5f56 100644
@@ -349,13 +349,8 @@ int add_mtd_device(struct mtd_info *mtd)
 	BUG_ON(mtd->writesize == 0);
 	mutex_lock(&mtd_table_mutex);
 
-	do {
-		if (!idr_pre_get(&mtd_idr, GFP_KERNEL))
-			goto fail_locked;
-		error = idr_get_new(&mtd_idr, mtd, &i);
-	} while (error == -EAGAIN);
-
-	if (error)
+	i = idr_alloc(&mtd_idr, mtd, 0, 0, GFP_KERNEL);
+	if (i < 0)
 		goto fail_locked;
 
 	mtd->index = i;
Signature · 1 line
1.8.1
Tested-by on v1 37/62
#64 lore raw

Re: [PATCH 37/62] mtd: convert to idr_alloc()

Quoted 4 lines · Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

Signature · 3 lines
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
author maintainer
#65 lore raw

PATCH 38/62 i2c: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

Cc Jason Wang <[email protected]>
Cc Michael S. Tsirkin <[email protected]>

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/net/macvtap.c | 21 +++++----------------
 1 file changed, 5 insertions(+), 16 deletions(-)
drivers/net/macvtap.c +5 -16
index 0f0f9ce..2497f6f 100644
@@ -279,28 +279,17 @@ static int macvtap_receive(struct sk_buff *skb)
 static int macvtap_get_minor(struct macvlan_dev *vlan)
 {
 	int retval = -ENOMEM;
-	int id;
 
 	mutex_lock(&minor_lock);
-	if (idr_pre_get(&minor_idr, GFP_KERNEL) == 0)
-		goto exit;
-
-	retval = idr_get_new_above(&minor_idr, vlan, 1, &id);
-	if (retval < 0) {
-		if (retval == -EAGAIN)
-			retval = -ENOMEM;
-		goto exit;
-	}
-	if (id < MACVTAP_NUM_DEVS) {
-		vlan->minor = id;
-	} else {
+	retval = idr_alloc(&minor_idr, vlan, 1, MACVTAP_NUM_DEVS, GFP_KERNEL);
+	if (retval >= 0) {
+		vlan->minor = retval;
+	} else if (retval == -ENOSPC) {
 		printk(KERN_ERR "too many macvtap devices\n");
 		retval = -EINVAL;
-		idr_remove(&minor_idr, id);
 	}
-exit:
 	mutex_unlock(&minor_lock);
-	return retval;
+	return retval < 0 ? retval : 0;
 }
 
 static void macvtap_free_minor(struct macvlan_dev *vlan)
Signature · 1 line
1.8.1
author maintainer
#66 lore raw

PATCH 38/62 macvtap: convert to idr_alloc()

Convert to the much saner new idr interface.

Only compile tested.

Cc Jason Wang <[email protected]>
Cc Michael S. Tsirkin <[email protected]>

---
Went out with the wrong subject. This is the same patch with the correct subject.

Thanks.

This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/net/macvtap.c | 21 +++++----------------
 1 file changed, 5 insertions(+), 16 deletions(-)
drivers/net/macvtap.c +5 -16
index 0f0f9ce..2497f6f 100644
@@ -279,28 +279,17 @@ static int macvtap_receive(struct sk_buff *skb)
 static int macvtap_get_minor(struct macvlan_dev *vlan)
 {
 	int retval = -ENOMEM;
-	int id;
 
 	mutex_lock(&minor_lock);
-	if (idr_pre_get(&minor_idr, GFP_KERNEL) == 0)
-		goto exit;
-
-	retval = idr_get_new_above(&minor_idr, vlan, 1, &id);
-	if (retval < 0) {
-		if (retval == -EAGAIN)
-			retval = -ENOMEM;
-		goto exit;
-	}
-	if (id < MACVTAP_NUM_DEVS) {
-		vlan->minor = id;
-	} else {
+	retval = idr_alloc(&minor_idr, vlan, 1, MACVTAP_NUM_DEVS, GFP_KERNEL);
+	if (retval >= 0) {
+		vlan->minor = retval;
+	} else if (retval == -ENOSPC) {
 		printk(KERN_ERR "too many macvtap devices\n");
 		retval = -EINVAL;
-		idr_remove(&minor_idr, id);
 	}
-exit:
 	mutex_unlock(&minor_lock);
-	return retval;
+	return retval < 0 ? retval : 0;
 }
 
 static void macvtap_free_minor(struct macvlan_dev *vlan)
Signature · 1 line
1.8.1
author maintainer
#67 lore raw

PATCH 39/62 ppp: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/net/ppp/ppp_generic.c | 33 ++++-----------------------------
 1 file changed, 4 insertions(+), 29 deletions(-)
drivers/net/ppp/ppp_generic.c +4 -29
index 0b2706a..7efdb91 100644
@@ -2946,46 +2946,21 @@ static void __exit ppp_cleanup(void)
  * by holding all_ppp_mutex
  */
 
-static int __unit_alloc(struct idr *p, void *ptr, int n)
-{
-	int unit, err;
-
-again:
-	if (!idr_pre_get(p, GFP_KERNEL)) {
-		pr_err("PPP: No free memory for idr\n");
-		return -ENOMEM;
-	}
-
-	err = idr_get_new_above(p, ptr, n, &unit);
-	if (err < 0) {
-		if (err = -EAGAIN)
-			goto again;
-		return err;
-	}
-
-	return unit;
-}
-
 /* associate pointer with specified number */
 static int unit_set(struct idr *p, void *ptr, int n)
 {
 	int unit;
 
-	unit = __unit_alloc(p, ptr, n);
-	if (unit < 0)
-		return unit;
-	else if (unit != n) {
-		idr_remove(p, unit);
-		return -EINVAL;
-	}
-
+	unit = idr_alloc(p, ptr, n, n + 1, GFP_KERNEL);
+	if (unit = -ENOSPC)
+		unit = -EINVAL;
 	return unit;
 }
 
 /* get new free unit number and associate pointer with it */
 static int unit_get(struct idr *p, void *ptr)
 {
-	return __unit_alloc(p, ptr, 0);
+	return idr_alloc(p, ptr, 0, 0, GFP_KERNEL);
 }
 
 /* put unit number back to a pool */
Signature · 1 line
1.8.1
author maintainer
#68 lore raw

PATCH 40/62 power: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

Cc Anton Vorontsov <[email protected]>
Cc David Woodhouse <[email protected]>

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/power/bq2415x_charger.c | 11 +++--------
 drivers/power/bq27x00_battery.c |  9 +++------
 drivers/power/ds2782_battery.c  |  9 ++-------
 3 files changed, 8 insertions(+), 21 deletions(-)
drivers/power/bq2415x_charger.c +3 -8
index ee842b3..65baf4e 100644
@@ -1505,16 +1505,11 @@ static int bq2415x_probe(struct i2c_client *client,
 	}
 
 	/* Get new ID for the new device */
-	ret = idr_pre_get(&bq2415x_id, GFP_KERNEL);
-	if (ret == 0)
-		return -ENOMEM;
-
 	mutex_lock(&bq2415x_id_mutex);
-	ret = idr_get_new(&bq2415x_id, client, &num);
+	num = idr_alloc(&bq2415x_id, client, 0, 0, GFP_KERNEL);
 	mutex_unlock(&bq2415x_id_mutex);
-
-	if (ret < 0)
-		return ret;
+	if (num < 0)
+		return num;
 
 	name = kasprintf(GFP_KERNEL, "%s-%d", id->name, num);
 	if (!name) {
drivers/power/bq27x00_battery.c +3 -6
index 36b34ef..75dd6a4 100644
@@ -793,14 +793,11 @@ static int bq27x00_battery_probe(struct i2c_client *client,
 	int retval = 0;
 
 	/* Get new ID for the new battery device */
-	retval = idr_pre_get(&battery_id, GFP_KERNEL);
-	if (retval == 0)
-		return -ENOMEM;
 	mutex_lock(&battery_mutex);
-	retval = idr_get_new(&battery_id, client, &num);
+	num = idr_alloc(&battery_id, client, 0, 0, GFP_KERNEL);
 	mutex_unlock(&battery_mutex);
-	if (retval < 0)
-		return retval;
+	if (num < 0)
+		return num;
 
 	name = kasprintf(GFP_KERNEL, "%s-%d", id->name, num);
 	if (!name) {
drivers/power/ds2782_battery.c +2 -7
index 2fa9b6b..c81f3b4 100644
@@ -335,17 +335,12 @@ static int ds278x_battery_probe(struct i2c_client *client,
 	}
 
 	/* Get an ID for this battery */
-	ret = idr_pre_get(&battery_id, GFP_KERNEL);
-	if (ret == 0) {
-		ret = -ENOMEM;
-		goto fail_id;
-	}
-
 	mutex_lock(&battery_lock);
-	ret = idr_get_new(&battery_id, client, &num);
+	ret = idr_alloc(&battery_id, client, 0, 0, GFP_KERNEL);
 	mutex_unlock(&battery_lock);
 	if (ret < 0)
 		goto fail_id;
+	num = ret;
 
 	info = kzalloc(sizeof(*info), GFP_KERNEL);
 	if (!info) {
Signature · 1 line
1.8.1
#69 lore raw

Re: [PATCH 40/62] power: convert to idr_alloc()

Quoted 11 lines · Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

Cc Anton Vorontsov <[email protected]>
Cc David Woodhouse <[email protected]>

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

Sure thing, Ack for these:

Quoted 4 lines
 drivers/power/bq2415x_charger.c | 11 +++--------
 drivers/power/bq27x00_battery.c |  9 +++------
 drivers/power/ds2782_battery.c  |  9 ++-------
 3 files changed, 8 insertions(+), 21 deletions(-)

Thanks!

Anton

author maintainer
#70 lore raw

PATCH 41/62 pps: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

Cc Rodolfo Giometti <[email protected]>

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/pps/kapi.c |  2 +-
 drivers/pps/pps.c  | 36 ++++++++++++++----------------------
 2 files changed, 15 insertions(+), 23 deletions(-)
drivers/pps/kapi.c +1 -1
index f197e8e..cdad4d9 100644
@@ -102,7 +102,7 @@ struct pps_device *pps_register_source(struct pps_source_info *info,
 		goto pps_register_source_exit;
 	}
 
-	/* These initializations must be done before calling idr_get_new()
+	/* These initializations must be done before calling idr_alloc()
 	 * in order to avoid reces into pps_event().
 	 */
 	pps->params.api_version = PPS_API_VERS;
drivers/pps/pps.c +14 -22
index 2420d5a..de8e663 100644
@@ -290,29 +290,21 @@ int pps_register_cdev(struct pps_device *pps)
 	dev_t devt;
 
 	mutex_lock(&pps_idr_lock);
-	/* Get new ID for the new PPS source */
-	if (idr_pre_get(&pps_idr, GFP_KERNEL) == 0) {
-		mutex_unlock(&pps_idr_lock);
-		return -ENOMEM;
-	}
-
-	/* Now really allocate the PPS source.
-	 * After idr_get_new() calling the new source will be freely available
-	 * into the kernel.
+	/*
+	 * Get new ID for the new PPS source.  After idr_alloc() calling
+	 * the new source will be freely available into the kernel.
 	 */
-	err = idr_get_new(&pps_idr, pps, &pps->id);
-	mutex_unlock(&pps_idr_lock);
-
-	if (err < 0)
-		return err;
-
-	pps->id &= MAX_IDR_MASK;
-	if (pps->id >= PPS_MAX_SOURCES) {
-		pr_err("%s: too many PPS sources in the system\n",
-					pps->info.name);
-		err = -EBUSY;
-		goto free_idr;
+	err = idr_alloc(&pps_idr, pps, 0, PPS_MAX_SOURCES, GFP_KERNEL);
+	if (err < 0) {
+		if (err == -ENOSPC) {
+			pr_err("%s: too many PPS sources in the system\n",
+			       pps->info.name);
+			err = -EBUSY;
+		}
+		goto out_unlock;
 	}
+	pps->id = err;
+	mutex_unlock(&pps_idr_lock);
 
 	devt = MKDEV(MAJOR(pps_devt), pps->id);
 
@@ -345,8 +337,8 @@ del_cdev:
 free_idr:
 	mutex_lock(&pps_idr_lock);
 	idr_remove(&pps_idr, pps->id);
+out_unlock:
 	mutex_unlock(&pps_idr_lock);
-
 	return err;
 }
 
Signature · 1 line
1.8.1
author maintainer
#71 lore raw

PATCH 42/62 remoteproc: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

Cc Ohad Ben-Cohen <[email protected]>

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/remoteproc/remoteproc_core.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)
drivers/remoteproc/remoteproc_core.c +3 -7
index 634d367..29387df 100644
@@ -199,11 +199,6 @@ int rproc_alloc_vring(struct rproc_vdev *rvdev, int i)
 	/* actual size of vring (in bytes) */
 	size = PAGE_ALIGN(vring_size(rvring->len, rvring->align));
 
-	if (!idr_pre_get(&rproc->notifyids, GFP_KERNEL)) {
-		dev_err(dev, "idr_pre_get failed\n");
-		return -ENOMEM;
-	}
-
 	/*
 	 * Allocate non-cacheable memory for the vring. In the future
 	 * this call will also configure the IOMMU for us
@@ -221,12 +216,13 @@ int rproc_alloc_vring(struct rproc_vdev *rvdev, int i)
 	 * TODO: let the rproc know the notifyid of this vring
 	 * TODO: support predefined notifyids (via resource table)
 	 */
-	ret = idr_get_new(&rproc->notifyids, rvring, &notifyid);
+	ret = idr_alloc(&rproc->notifyids, rvring, 0, 0, GFP_KERNEL);
 	if (ret) {
-		dev_err(dev, "idr_get_new failed: %d\n", ret);
+		dev_err(dev, "idr_alloc failed: %d\n", ret);
 		dma_free_coherent(dev->parent, size, va, dma);
 		return ret;
 	}
+	notifyid = ret;
 
 	/* Store largest notifyid */
 	rproc->max_notifyid = max(rproc->max_notifyid, notifyid);
Signature · 1 line
1.8.1
author maintainer
#72 lore raw

PATCH 43/62 rpmsg: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

Cc Ohad Ben-Cohen <[email protected]>

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/rpmsg/virtio_rpmsg_bus.c | 30 ++++++++++++------------------
 1 file changed, 12 insertions(+), 18 deletions(-)
drivers/rpmsg/virtio_rpmsg_bus.c +12 -18
index aa334b6..7ce2802 100644
@@ -213,13 +213,10 @@ static struct rpmsg_endpoint *__rpmsg_create_ept(struct virtproc_info *vrp,
 		struct rpmsg_channel *rpdev, rpmsg_rx_cb_t cb,
 		void *priv, u32 addr)
 {
-	int err, tmpaddr, request;
+	int id_min, id_max, id;
 	struct rpmsg_endpoint *ept;
 	struct device *dev = rpdev ? &rpdev->dev : &vrp->vdev->dev;
 
-	if (!idr_pre_get(&vrp->endpoints, GFP_KERNEL))
-		return NULL;
-
 	ept = kzalloc(sizeof(*ept), GFP_KERNEL);
 	if (!ept) {
 		dev_err(dev, "failed to kzalloc a new ept\n");
@@ -234,31 +231,28 @@ static struct rpmsg_endpoint *__rpmsg_create_ept(struct virtproc_info *vrp,
 	ept->priv = priv;
 
 	/* do we need to allocate a local address ? */
-	request = addr == RPMSG_ADDR_ANY ? RPMSG_RESERVED_ADDRESSES : addr;
+	if (addr == RPMSG_ADDR_ANY) {
+		id_min = RPMSG_RESERVED_ADDRESSES;
+		id_max = 0;
+	} else {
+		id_min = addr;
+		id_max = addr + 1;
+	}
 
 	mutex_lock(&vrp->endpoints_lock);
 
 	/* bind the endpoint to an rpmsg address (and allocate one if needed) */
-	err = idr_get_new_above(&vrp->endpoints, ept, request, &tmpaddr);
-	if (err) {
-		dev_err(dev, "idr_get_new_above failed: %d\n", err);
+	id = idr_alloc(&vrp->endpoints, ept, id_min, id_max, GFP_KERNEL);
+	if (id < 0) {
+		dev_err(dev, "idr_alloc failed: %d\n", id);
 		goto free_ept;
 	}
-
-	/* make sure the user's address request is fulfilled, if relevant */
-	if (addr != RPMSG_ADDR_ANY && tmpaddr != addr) {
-		dev_err(dev, "address 0x%x already in use\n", addr);
-		goto rem_idr;
-	}
-
-	ept->addr = tmpaddr;
+	ept->addr = id;
 
 	mutex_unlock(&vrp->endpoints_lock);
 
 	return ept;
 
-rem_idr:
-	idr_remove(&vrp->endpoints, request);
 free_ept:
 	mutex_unlock(&vrp->endpoints_lock);
 	kref_put(&ept->refcount, __ept_release);
Signature · 1 line
1.8.1
author maintainer
#73 lore raw

PATCH 44/62 scsi/bfa: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/scsi/bfa/bfad_im.c | 15 ++++-----------
 1 file changed, 4 insertions(+), 11 deletions(-)
drivers/scsi/bfa/bfad_im.c +4 -11
index 8f92732..5864f98 100644
@@ -523,20 +523,13 @@ bfad_im_scsi_host_alloc(struct bfad_s *bfad, struct bfad_im_port_s *im_port,
 	int error = 1;
 
 	mutex_lock(&bfad_mutex);
-	if (!idr_pre_get(&bfad_im_port_index, GFP_KERNEL)) {
+	error = idr_alloc(&bfad_im_port_index, im_port, 0, 0, GFP_KERNEL);
+	if (error < 0) {
 		mutex_unlock(&bfad_mutex);
-		printk(KERN_WARNING "idr_pre_get failure\n");
+		printk(KERN_WARNING "idr_alloc failure\n");
 		goto out;
 	}
-
-	error = idr_get_new(&bfad_im_port_index, im_port,
-					 &im_port->idr_id);
-	if (error) {
-		mutex_unlock(&bfad_mutex);
-		printk(KERN_WARNING "idr_get_new failure\n");
-		goto out;
-	}
-
+	im_port->idr_id = error;
 	mutex_unlock(&bfad_mutex);
 
 	im_port->shost = bfad_scsi_host_alloc(im_port, bfad);
Signature · 1 line
1.8.1
author maintainer
#74 lore raw

PATCH 45/62 scsi: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

Cc "James E.J. Bottomley" <[email protected]>

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/scsi/ch.c | 21 +++++++++------------
 drivers/scsi/sg.c | 43 +++++++++++++++++--------------------------
 drivers/scsi/st.c | 27 ++++++++-------------------
 3 files changed, 34 insertions(+), 57 deletions(-)
drivers/scsi/ch.c +9 -12
index a15474e..2a32374 100644
@@ -895,7 +895,7 @@ static int ch_probe(struct device *dev)
 {
 	struct scsi_device *sd = to_scsi_device(dev);
 	struct device *class_dev;
-	int minor, ret = -ENOMEM;
+	int ret;
 	scsi_changer *ch;
 
 	if (sd->type != TYPE_MEDIUM_CHANGER)
@@ -905,22 +905,19 @@ static int ch_probe(struct device *dev)
 	if (NULL == ch)
 		return -ENOMEM;
 
-	if (!idr_pre_get(&ch_index_idr, GFP_KERNEL))
-		goto free_ch;
-
+	idr_preload(GFP_KERNEL);
 	spin_lock(&ch_index_lock);
-	ret = idr_get_new(&ch_index_idr, ch, &minor);
+	ret = idr_alloc(&ch_index_idr, ch, 0, CH_MAX_DEVS + 1, GFP_NOWAIT);
 	spin_unlock(&ch_index_lock);
+	idr_preload_end();
 
-	if (ret)
+	if (ret < 0) {
+		if (ret == -ENOSPC)
+			ret = -ENODEV;
 		goto free_ch;
-
-	if (minor > CH_MAX_DEVS) {
-		ret = -ENODEV;
-		goto remove_idr;
 	}
 
-	ch->minor = minor;
+	ch->minor = ret;
 	sprintf(ch->name,"ch%d",ch->minor);
 
 	class_dev = device_create(ch_sysfs_class, dev,
@@ -944,7 +941,7 @@ static int ch_probe(struct device *dev)
 
 	return 0;
 remove_idr:
-	idr_remove(&ch_index_idr, minor);
+	idr_remove(&ch_index_idr, ch->minor);
 free_ch:
 	kfree(ch);
 	return ret;
drivers/scsi/sg.c +17 -26

66 lines not on this page · raw message

drivers/scsi/st.c +8 -19
index 98156a9..7c6edca 100644
@@ -4076,7 +4076,7 @@ static int st_probe(struct device *dev)
 	struct st_modedef *STm;
 	struct st_partstat *STps;
 	struct st_buffer *buffer;
-	int i, dev_num, error;
+	int i, error;
 	char *stp;
 
 	if (SDp->type != TYPE_TAPE)
@@ -4178,27 +4178,17 @@ static int st_probe(struct device *dev)
 	    tpnt->blksize_changed = 0;
 	mutex_init(&tpnt->lock);
 
-	if (!idr_pre_get(&st_index_idr, GFP_KERNEL)) {
-		pr_warn("st: idr expansion failed\n");
-		error = -ENOMEM;
-		goto out_put_disk;
-	}
-
+	idr_preload(GFP_KERNEL);
 	spin_lock(&st_index_lock);
-	error = idr_get_new(&st_index_idr, tpnt, &dev_num);
+	error = idr_alloc(&st_index_idr, tpnt, 0, ST_MAX_TAPES + 1, GFP_NOWAIT);
 	spin_unlock(&st_index_lock);
-	if (error) {
+	idr_preload_end();
+	if (error < 0) {
 		pr_warn("st: idr allocation failed: %d\n", error);
 		goto out_put_disk;
 	}
-
-	if (dev_num > ST_MAX_TAPES) {
-		pr_err("st: Too many tape devices (max. %d).\n", ST_MAX_TAPES);
-		goto out_put_index;
-	}
-
-	tpnt->index = dev_num;
-	sprintf(disk->disk_name, "st%d", dev_num);
+	tpnt->index = error;
+	sprintf(disk->disk_name, "st%d", tpnt->index);
 
 	dev_set_drvdata(dev, tpnt);
 
@@ -4218,9 +4208,8 @@ static int st_probe(struct device *dev)
 
 out_remove_devs:
 	remove_cdevs(tpnt);
-out_put_index:
 	spin_lock(&st_index_lock);
-	idr_remove(&st_index_idr, dev_num);
+	idr_remove(&st_index_idr, tpnt->index);
 	spin_unlock(&st_index_lock);
 out_put_disk:
 	put_disk(disk);
Signature · 1 line
1.8.1
author maintainer
#75 lore raw

PATCH 46/62 target/iscsi: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/target/iscsi/iscsi_target.c       | 15 ++++++++-------
 drivers/target/iscsi/iscsi_target_login.c | 15 ++++++---------
 2 files changed, 14 insertions(+), 16 deletions(-)
drivers/target/iscsi/iscsi_target.c +8 -7
index 339f97f..f1fdf4f 100644
@@ -144,23 +144,24 @@ struct iscsi_tiqn *iscsit_add_tiqn(unsigned char *buf)
 	spin_lock_init(&tiqn->login_stats.lock);
 	spin_lock_init(&tiqn->logout_stats.lock);
 
-	if (!idr_pre_get(&tiqn_idr, GFP_KERNEL)) {
-		pr_err("idr_pre_get() for tiqn_idr failed\n");
-		kfree(tiqn);
-		return ERR_PTR(-ENOMEM);
-	}
 	tiqn->tiqn_state = TIQN_STATE_ACTIVE;
 
+	idr_preload(GFP_KERNEL);
 	spin_lock(&tiqn_lock);
-	ret = idr_get_new(&tiqn_idr, NULL, &tiqn->tiqn_index);
+
+	ret = idr_alloc(&tiqn_idr, NULL, 0, 0, GFP_NOWAIT);
 	if (ret < 0) {
-		pr_err("idr_get_new() failed for tiqn->tiqn_index\n");
+		pr_err("idr_alloc() failed for tiqn->tiqn_index\n");
 		spin_unlock(&tiqn_lock);
+		idr_preload_end();
 		kfree(tiqn);
 		return ERR_PTR(ret);
 	}
+	tiqn->tiqn_index = ret;
 	list_add_tail(&tiqn->tiqn_list, &g_tiqn_list);
+
 	spin_unlock(&tiqn_lock);
+	idr_preload_end();
 
 	pr_debug("CORE[0] - Added iSCSI Target IQN: %s\n", tiqn->tiqn);
 
drivers/target/iscsi/iscsi_target_login.c +6 -9
index fdb632f..2535d4d 100644
@@ -247,19 +247,16 @@ static int iscsi_login_zero_tsih_s1(
 	spin_lock_init(&sess->session_usage_lock);
 	spin_lock_init(&sess->ttt_lock);
 
-	if (!idr_pre_get(&sess_idr, GFP_KERNEL)) {
-		pr_err("idr_pre_get() for sess_idr failed\n");
-		iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_TARGET_ERR,
-				ISCSI_LOGIN_STATUS_NO_RESOURCES);
-		kfree(sess);
-		return -ENOMEM;
-	}
+	idr_preload(GFP_KERNEL);
 	spin_lock_bh(&sess_idr_lock);
-	ret = idr_get_new(&sess_idr, NULL, &sess->session_index);
+	ret = idr_alloc(&sess_idr, NULL, 0, 0, GFP_NOWAIT);
+	if (ret >= 0)
+		sess->session_index = ret;
 	spin_unlock_bh(&sess_idr_lock);
+	idr_preload_end();
 
 	if (ret < 0) {
-		pr_err("idr_get_new() for sess_idr failed\n");
+		pr_err("idr_alloc() for sess_idr failed\n");
 		iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_TARGET_ERR,
 				ISCSI_LOGIN_STATUS_NO_RESOURCES);
 		kfree(sess);
Signature · 1 line
1.8.1
author maintainer
#76 lore raw

PATCH 47/62 scsi/lpfc: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/scsi/lpfc/lpfc_init.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)
drivers/scsi/lpfc/lpfc_init.c +4 -8
index 89ad558..7de4ef14 100644
@@ -3165,14 +3165,10 @@ destroy_port(struct lpfc_vport *vport)
 int
 lpfc_get_instance(void)
 {
-	int instance = 0;
-
-	/* Assign an unused number */
-	if (!idr_pre_get(&lpfc_hba_index, GFP_KERNEL))
-		return -1;
-	if (idr_get_new(&lpfc_hba_index, NULL, &instance))
-		return -1;
-	return instance;
+	int ret;
+
+	ret = idr_alloc(&lpfc_hba_index, NULL, 0, 0, GFP_KERNEL);
+	return ret < 0 ? -1 : ret;
 }
 
 /**
Signature · 1 line
1.8.1
Acked-by on v1 47/62
#77 lore raw

Re: [PATCH 47/62] scsi/lpfc: convert to idr_alloc()

-- james s

Quoted 38 lines · Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

  drivers/scsi/lpfc/lpfc_init.c | 12 ++++--------
  1 file changed, 4 insertions(+), 8 deletions(-)
drivers/scsi/lpfc/lpfc_init.c +4 -8
index 89ad558..7de4ef14 100644
@@ -3165,14 +3165,10 @@ destroy_port(struct lpfc_vport *vport)
  int
  lpfc_get_instance(void)
  {
-	int instance = 0;
-
-	/* Assign an unused number */
-	if (!idr_pre_get(&lpfc_hba_index, GFP_KERNEL))
-		return -1;
-	if (idr_get_new(&lpfc_hba_index, NULL, &instance))
-		return -1;
-	return instance;
+	int ret;
+
+	ret = idr_alloc(&lpfc_hba_index, NULL, 0, 0, GFP_KERNEL);
+	return ret < 0 ? -1 : ret;
  }
 
  /**
author maintainer
#78 lore raw

PATCH 48/62 thermal: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/thermal/cpu_cooling.c | 17 +++++------------
 drivers/thermal/thermal_sys.c | 17 +++++------------
 2 files changed, 10 insertions(+), 24 deletions(-)
drivers/thermal/cpu_cooling.c +5 -12
index 836828e..c33fa53 100644
@@ -73,21 +73,14 @@ static struct cpufreq_cooling_device *notify_device;
  */
 static int get_idr(struct idr *idr, int *id)
 {
-	int err;
-again:
-	if (unlikely(idr_pre_get(idr, GFP_KERNEL) == 0))
-		return -ENOMEM;
+	int ret;
 
 	mutex_lock(&cooling_cpufreq_lock);
-	err = idr_get_new(idr, NULL, id);
+	ret = idr_alloc(idr, NULL, 0, 0, GFP_KERNEL);
 	mutex_unlock(&cooling_cpufreq_lock);
-
-	if (unlikely(err == -EAGAIN))
-		goto again;
-	else if (unlikely(err))
-		return err;
-
-	*id = *id & MAX_IDR_MASK;
+	if (unlikely(ret < 0))
+		return ret;
+	*id = ret;
 	return 0;
 }
 
drivers/thermal/thermal_sys.c +5 -12
index 8c8ce80..84e95f3 100644
@@ -132,23 +132,16 @@ EXPORT_SYMBOL_GPL(thermal_unregister_governor);
 
 static int get_idr(struct idr *idr, struct mutex *lock, int *id)
 {
-	int err;
-
-again:
-	if (unlikely(idr_pre_get(idr, GFP_KERNEL) == 0))
-		return -ENOMEM;
+	int ret;
 
 	if (lock)
 		mutex_lock(lock);
-	err = idr_get_new(idr, NULL, id);
+	ret = idr_alloc(idr, NULL, 0, 0, GFP_KERNEL);
 	if (lock)
 		mutex_unlock(lock);
-	if (unlikely(err == -EAGAIN))
-		goto again;
-	else if (unlikely(err))
-		return err;
-
-	*id = *id & MAX_IDR_MASK;
+	if (unlikely(ret < 0))
+		return ret;
+	*id = ret;
 	return 0;
 }
 
Signature · 1 line
1.8.1
author maintainer
#79 lore raw

PATCH 49/62 uio: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

Cc "Hans J. Koch" <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/uio/uio.c | 19 ++++---------------
 1 file changed, 4 insertions(+), 15 deletions(-)
drivers/uio/uio.c +4 -15
index 5110f36..c8b9262 100644
@@ -369,26 +369,15 @@ static void uio_dev_del_attributes(struct uio_device *idev)
 static int uio_get_minor(struct uio_device *idev)
 {
 	int retval = -ENOMEM;
-	int id;
 
 	mutex_lock(&minor_lock);
-	if (idr_pre_get(&uio_idr, GFP_KERNEL) == 0)
-		goto exit;
-
-	retval = idr_get_new(&uio_idr, idev, &id);
-	if (retval < 0) {
-		if (retval == -EAGAIN)
-			retval = -ENOMEM;
-		goto exit;
-	}
-	if (id < UIO_MAX_DEVICES) {
-		idev->minor = id;
-	} else {
+	retval = idr_alloc(&uio_idr, idev, 0, UIO_MAX_DEVICES, GFP_KERNEL);
+	if (retval >= 0) {
+		idev->minor = retval;
+	} else if (retval == -ENOSPC) {
 		dev_err(idev->dev, "too many uio devices\n");
 		retval = -EINVAL;
-		idr_remove(&uio_idr, id);
 	}
-exit:
 	mutex_unlock(&minor_lock);
 	return retval;
 }
Signature · 1 line
1.8.1
author maintainer
#81 lore raw

PATCH 50/62 vfio: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/vfio/vfio.c | 18 +-----------------
 1 file changed, 1 insertion(+), 17 deletions(-)
drivers/vfio/vfio.c +1 -17
index 12c264d..0132846 100644
@@ -139,23 +139,7 @@ EXPORT_SYMBOL_GPL(vfio_unregister_iommu_driver);
  */
 static int vfio_alloc_group_minor(struct vfio_group *group)
 {
-	int ret, minor;
-
-again:
-	if (unlikely(idr_pre_get(&vfio.group_idr, GFP_KERNEL) == 0))
-		return -ENOMEM;
-
-	/* index 0 is used by /dev/vfio/vfio */
-	ret = idr_get_new_above(&vfio.group_idr, group, 1, &minor);
-	if (ret == -EAGAIN)
-		goto again;
-	if (ret || minor > MINORMASK) {
-		if (minor > MINORMASK)
-			idr_remove(&vfio.group_idr, minor);
-		return -ENOSPC;
-	}
-
-	return minor;
+	return idr_alloc(&vfio.group_idr, group, 1, MINORMASK + 1, GFP_KERNEL);
 }
 
 static void vfio_free_group_minor(int minor)
Signature · 1 line
1.8.1
Acked-by on v1 50/62
#82 lore raw

Re: [PATCH 50/62] vfio: convert to idr_alloc()

Quoted 20 lines · Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 drivers/vfio/vfio.c | 18 +-----------------
 1 file changed, 1 insertion(+), 17 deletions(-)
drivers/vfio/vfio.c +0 -0
index 12c264d..0132846 100644

drivers/vfio/vfio.c EXPORT_SYMBOL_GPL(vfio_unregister_iommu_driver); · line 148

Quoted 10 lines
drivers/vfio/vfio.c +0 -7
@@ -139,23 +139,7 @@ EXPORT_SYMBOL_GPL(vfio_unregister_iommu_driver);
  */
 static int vfio_alloc_group_minor(struct vfio_group *group)
 {
-	int ret, minor;
-
-again:
-	if (unlikely(idr_pre_get(&vfio.group_idr, GFP_KERNEL) == 0))
-		return -ENOMEM;
-
-	/* index 0 is used by /dev/vfio/vfio */

I'd have preferred to keep this comment. If you do a v2, please keep it, otherwise I'll add it back later.

Quoted 14 lines
drivers/vfio/vfio.c +1 -10
-	ret = idr_get_new_above(&vfio.group_idr, group, 1, &minor);
-	if (ret == -EAGAIN)
-		goto again;
-	if (ret || minor > MINORMASK) {
-		if (minor > MINORMASK)
-			idr_remove(&vfio.group_idr, minor);
-		return -ENOSPC;
-	}
-
-	return minor;
+	return idr_alloc(&vfio.group_idr, group, 1, MINORMASK + 1, GFP_KERNEL);
 }
 
 static void vfio_free_group_minor(int minor)
author maintainer
#83 lore raw

PATCH v2 50/62 vfio: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

v2: Restore accidentally dropped "index 0" comment as suggested by
Alex.

---
 drivers/vfio/vfio.c |   17 +----------------
 1 file changed, 1 insertion(+), 16 deletions(-)
drivers/vfio/vfio.c +1 -16
@@ -139,23 +139,8 @@ EXPORT_SYMBOL_GPL(vfio_unregister_iommu_
  */
 static int vfio_alloc_group_minor(struct vfio_group *group)
 {
-	int ret, minor;
-
-again:
-	if (unlikely(idr_pre_get(&vfio.group_idr, GFP_KERNEL) == 0))
-		return -ENOMEM;
-
 	/* index 0 is used by /dev/vfio/vfio */
-	ret = idr_get_new_above(&vfio.group_idr, group, 1, &minor);
-	if (ret == -EAGAIN)
-		goto again;
-	if (ret || minor > MINORMASK) {
-		if (minor > MINORMASK)
-			idr_remove(&vfio.group_idr, minor);
-		return -ENOSPC;
-	}
-
-	return minor;
+	return idr_alloc(&vfio.group_idr, group, 1, MINORMASK + 1, GFP_KERNEL);
 }
 
 static void vfio_free_group_minor(int minor)
author maintainer
#84 lore raw

PATCH 51/62 dlm: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface. Error return values from recover_idr_add() mix -1 and -errno. The conversion doesn't change that but it looks iffy.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 fs/dlm/lock.c    | 18 ++++++------------
 fs/dlm/recover.c | 27 +++++++++++++--------------
 2 files changed, 19 insertions(+), 26 deletions(-)
fs/dlm/lock.c +6 -12
index a579f30..353942f 100644
@@ -1182,7 +1182,7 @@ static void detach_lkb(struct dlm_lkb *lkb)
 static int create_lkb(struct dlm_ls *ls, struct dlm_lkb **lkb_ret)
 {
 	struct dlm_lkb *lkb;
-	int rv, id;
+	int rv;
 
 	lkb = dlm_allocate_lkb(ls);
 	if (!lkb)
@@ -1198,19 +1198,13 @@ static int create_lkb(struct dlm_ls *ls, struct dlm_lkb **lkb_ret)
 	mutex_init(&lkb->lkb_cb_mutex);
 	INIT_WORK(&lkb->lkb_cb_work, dlm_callback_work);
 
- retry:
-	rv = idr_pre_get(&ls->ls_lkbidr, GFP_NOFS);
-	if (!rv)
-		return -ENOMEM;
-
+	idr_preload(GFP_NOFS);
 	spin_lock(&ls->ls_lkbidr_spin);
-	rv = idr_get_new_above(&ls->ls_lkbidr, lkb, 1, &id);
-	if (!rv)
-		lkb->lkb_id = id;
+	rv = idr_alloc(&ls->ls_lkbidr, lkb, 1, 0, GFP_NOWAIT);
+	if (rv >= 0)
+		lkb->lkb_id = rv;
 	spin_unlock(&ls->ls_lkbidr_spin);
-
-	if (rv == -EAGAIN)
-		goto retry;
+	idr_preload_end();
 
 	if (rv < 0) {
 		log_error(ls, "create_lkb idr error %d", rv);
fs/dlm/recover.c +13 -14
index 236d108..a6bc63f 100644
@@ -305,27 +305,26 @@ static int recover_idr_empty(struct dlm_ls *ls)
 static int recover_idr_add(struct dlm_rsb *r)
 {
 	struct dlm_ls *ls = r->res_ls;
-	int rv, id;
-
-	rv = idr_pre_get(&ls->ls_recover_idr, GFP_NOFS);
-	if (!rv)
-		return -ENOMEM;
+	int rv;
 
+	idr_preload(GFP_NOFS);
 	spin_lock(&ls->ls_recover_idr_lock);
 	if (r->res_id) {
-		spin_unlock(&ls->ls_recover_idr_lock);
-		return -1;
-	}
-	rv = idr_get_new_above(&ls->ls_recover_idr, r, 1, &id);
-	if (rv) {
-		spin_unlock(&ls->ls_recover_idr_lock);
-		return rv;
+		rv = -1;
+		goto out_unlock;
 	}
-	r->res_id = id;
+	rv = idr_alloc(&ls->ls_recover_idr, r, 1, 0, GFP_NOWAIT);
+	if (rv < 0)
+		goto out_unlock;
+
+	r->res_id = rv;
 	ls->ls_recover_list_count++;
 	dlm_hold_rsb(r);
+	rv = 0;
+out_unlock:
 	spin_unlock(&ls->ls_recover_idr_lock);
-	return 0;
+	idr_preload_end();
+	return rv;
 }
 
 static void recover_idr_del(struct dlm_rsb *r)
Signature · 1 line
1.8.1
author maintainer
#85 lore raw

PATCH 52/62 inotify: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Note that the adhoc cyclic id allocation is buggy. If wraparound happens, the previous code with idr_get_new_above() may segfault and the converted code will trigger WARN and return -EINVAL. Even if it's fixed to wrap to zero, the code will be prone to unnecessary -ENOSPC failures after the first wraparound. We probably need to implement proper cyclic support in idr.

Only compile tested.

Cc John McCutchan <[email protected]>
Cc Robert Love <[email protected]>
Cc Eric Paris <[email protected]>

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 fs/notify/inotify/inotify_user.c | 24 +++++++++++-------------
 1 file changed, 11 insertions(+), 13 deletions(-)
fs/notify/inotify/inotify_user.c +11 -13
index 228a2c2..8f8099c 100644
@@ -364,22 +364,20 @@ static int inotify_add_to_idr(struct idr *idr, spinlock_t *idr_lock,
 {
 	int ret;
 
-	do {
-		if (unlikely(!idr_pre_get(idr, GFP_KERNEL)))
-			return -ENOMEM;
+	idr_preload(GFP_KERNEL);
+	spin_lock(idr_lock);
 
-		spin_lock(idr_lock);
-		ret = idr_get_new_above(idr, i_mark, *last_wd + 1,
-					&i_mark->wd);
+	ret = idr_alloc(idr, i_mark, *last_wd + 1, 0, GFP_NOWAIT);
+	if (ret >= 0) {
 		/* we added the mark to the idr, take a reference */
-		if (!ret) {
-			*last_wd = i_mark->wd;
-			fsnotify_get_mark(&i_mark->fsn_mark);
-		}
-		spin_unlock(idr_lock);
-	} while (ret == -EAGAIN);
+		i_mark->wd = ret;
+		*last_wd = i_mark->wd;
+		fsnotify_get_mark(&i_mark->fsn_mark);
+	}
 
-	return ret;
+	spin_unlock(idr_lock);
+	idr_preload_end();
+	return ret < 0 ? ret : 0;
 }
 
 static struct inotify_inode_mark *inotify_idr_find_locked(struct fsnotify_group *group,
Signature · 1 line
1.8.1
author maintainer
#86 lore raw

PATCH 53/62 ocfs2: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

Cc Mark Fasheh <[email protected]>
Cc Joel Becker <[email protected]>

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 fs/ocfs2/cluster/tcp.c | 32 +++++++++++++-------------------
 1 file changed, 13 insertions(+), 19 deletions(-)
fs/ocfs2/cluster/tcp.c +13 -19
index 1bfe880..7c10d75 100644
@@ -304,28 +304,22 @@ static u8 o2net_num_from_nn(struct o2net_node *nn)
 
 static int o2net_prep_nsw(struct o2net_node *nn, struct o2net_status_wait *nsw)
 {
-	int ret = 0;
-
-	do {
-		if (!idr_pre_get(&nn->nn_status_idr, GFP_ATOMIC)) {
-			ret = -EAGAIN;
-			break;
-		}
-		spin_lock(&nn->nn_lock);
-		ret = idr_get_new(&nn->nn_status_idr, nsw, &nsw->ns_id);
-		if (ret == 0)
-			list_add_tail(&nsw->ns_node_item,
-				      &nn->nn_status_list);
-		spin_unlock(&nn->nn_lock);
-	} while (ret == -EAGAIN);
+	int ret;
 
-	if (ret == 0)  {
-		init_waitqueue_head(&nsw->ns_wq);
-		nsw->ns_sys_status = O2NET_ERR_NONE;
-		nsw->ns_status = 0;
+	spin_lock(&nn->nn_lock);
+	ret = idr_alloc(&nn->nn_status_idr, nsw, 0, 0, GFP_ATOMIC);
+	if (ret >= 0) {
+		nsw->ns_id = ret;
+		list_add_tail(&nsw->ns_node_item, &nn->nn_status_list);
 	}
+	spin_unlock(&nn->nn_lock);
+	if (ret < 0)
+		return ret;
 
-	return ret;
+	init_waitqueue_head(&nsw->ns_wq);
+	nsw->ns_sys_status = O2NET_ERR_NONE;
+	nsw->ns_status = 0;
+	return 0;
 }
 
 static void o2net_complete_nsw_locked(struct o2net_node *nn,
Signature · 1 line
1.8.1
author maintainer
#87 lore raw

PATCH 54/62 ipc: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

The new interface doesn't directly translate to the way idr_pre_get() was used around ipc_addid() as preloading disables preemption. From my cursory reading, it seems like we should be able to do all allocation from ipc_addid(), so I moved it there. Can you please check whether this would be okay? If this is wrong and ipc_addid() should be allowed to be called from non-sleepable context, I'd suggest allocating id itself in the outer functions and later install the pointer using idr_replace().

Only compile tested.

Cc Stanislav Kinsbursky <[email protected]>
Cc "Eric W. Biederman" <[email protected]>
Cc James Morris <[email protected]>

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 ipc/util.c | 30 ++++++++++--------------------
 1 file changed, 10 insertions(+), 20 deletions(-)
ipc/util.c +10 -20
index 74e1d9c..91ce0bc 100644
@@ -252,7 +252,7 @@ int ipc_addid(struct ipc_ids* ids, struct kern_ipc_perm* new, int size)
 {
 	kuid_t euid;
 	kgid_t egid;
-	int id, err;
+	int id;
 	int next_id = ids->next_id;
 
 	if (size > IPCMNI)
@@ -261,17 +261,21 @@ int ipc_addid(struct ipc_ids* ids, struct kern_ipc_perm* new, int size)
 	if (ids->in_use >= size)
 		return -ENOSPC;
 
+	idr_preload(GFP_KERNEL);
+
 	spin_lock_init(&new->lock);
 	new->deleted = 0;
 	rcu_read_lock();
 	spin_lock(&new->lock);
 
-	err = idr_get_new_above(&ids->ipcs_idr, new,
-				(next_id < 0) ? 0 : ipcid_to_idx(next_id), &id);
-	if (err) {
+	id = idr_alloc(&ids->ipcs_idr, new,
+		       (next_id < 0) ? 0 : ipcid_to_idx(next_id), 0,
+		       GFP_NOWAIT);
+	idr_preload_end();
+	if (id < 0) {
 		spin_unlock(&new->lock);
 		rcu_read_unlock();
-		return err;
+		return id;
 	}
 
 	ids->in_use++;
@@ -307,19 +311,10 @@ static int ipcget_new(struct ipc_namespace *ns, struct ipc_ids *ids,
 		struct ipc_ops *ops, struct ipc_params *params)
 {
 	int err;
-retry:
-	err = idr_pre_get(&ids->ipcs_idr, GFP_KERNEL);
-
-	if (!err)
-		return -ENOMEM;
 
 	down_write(&ids->rw_mutex);
 	err = ops->getnew(ns, params);
 	up_write(&ids->rw_mutex);
-
-	if (err == -EAGAIN)
-		goto retry;
-
 	return err;
 }
 
@@ -375,9 +370,7 @@ static int ipcget_public(struct ipc_namespace *ns, struct ipc_ids *ids,
 {
 	struct kern_ipc_perm *ipcp;
 	int flg = params->flg;
-	int err;
-retry:
-	err = idr_pre_get(&ids->ipcs_idr, GFP_KERNEL);
+	int err = 0;
 
 	/*
 	 * Take the lock as a writer since we are potentially going to add
@@ -413,9 +406,6 @@ retry:
 	}
 	up_write(&ids->rw_mutex);
 
-	if (err == -EAGAIN)
-		goto retry;
-
 	return err;
 }
 
Signature · 1 line
1.8.1
author maintainer
#88 lore raw

PATCH 55/62 cgroup: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

Cc Li Zefan <[email protected]>
Cc containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 kernel/cgroup.c | 27 ++++++++-------------------
 1 file changed, 8 insertions(+), 19 deletions(-)
kernel/cgroup.c +8 -19
index 6b18c5c..4ee1102 100644
@@ -5272,7 +5272,7 @@ EXPORT_SYMBOL_GPL(free_css_id);
 static struct css_id *get_new_cssid(struct cgroup_subsys *ss, int depth)
 {
 	struct css_id *newid;
-	int myid, error, size;
+	int ret, size;
 
 	BUG_ON(!ss->use_id);
 
@@ -5280,35 +5280,24 @@ static struct css_id *get_new_cssid(struct cgroup_subsys *ss, int depth)
 	newid = kzalloc(size, GFP_KERNEL);
 	if (!newid)
 		return ERR_PTR(-ENOMEM);
-	/* get id */
-	if (unlikely(!idr_pre_get(&ss->idr, GFP_KERNEL))) {
-		error = -ENOMEM;
-		goto err_out;
-	}
+
+	idr_preload(GFP_KERNEL);
 	spin_lock(&ss->id_lock);
 	/* Don't use 0. allocates an ID of 1-65535 */
-	error = idr_get_new_above(&ss->idr, newid, 1, &myid);
+	ret = idr_alloc(&ss->idr, newid, 1, CSS_ID_MAX + 1, GFP_NOWAIT);
 	spin_unlock(&ss->id_lock);
+	idr_preload_end();
 
 	/* Returns error when there are no free spaces for new ID.*/
-	if (error) {
-		error = -ENOSPC;
+	if (ret < 0)
 		goto err_out;
-	}
-	if (myid > CSS_ID_MAX)
-		goto remove_idr;
 
-	newid->id = myid;
+	newid->id = ret;
 	newid->depth = depth;
 	return newid;
-remove_idr:
-	error = -ENOSPC;
-	spin_lock(&ss->id_lock);
-	idr_remove(&ss->idr, myid);
-	spin_unlock(&ss->id_lock);
 err_out:
 	kfree(newid);
-	return ERR_PTR(error);
+	return ERR_PTR(ret);
 
 }
 
Signature · 1 line
1.8.1
Acked-by on v1 55/62
#89 lore raw

Re: [PATCH 55/62] cgroup: convert to idr_alloc()

Quoted 5 lines · Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

Looks good to me.

Quoted 11 lines
Cc Li Zefan <[email protected]>
Cc containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 kernel/cgroup.c | 27 ++++++++-------------------
 1 file changed, 8 insertions(+), 19 deletions(-)

A message that is not in the archive (sent off-list or not yet received): 1359854463-2538-56-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org

Acked-by
#91 lore raw

Re: [PATCH 55/62] cgroup: convert to idr_alloc()

Quoted 5 lines · Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

Looks good to me.

Quoted 11 lines
Cc Li Zefan <[email protected]>
Cc containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 kernel/cgroup.c | 27 ++++++++-------------------
 1 file changed, 8 insertions(+), 19 deletions(-)
author maintainer
#92 lore raw

PATCH 56/62 events: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

Cc Peter Zijlstra <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Arnaldo Carvalho de Melo <[email protected]>

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 kernel/events/core.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)
kernel/events/core.c +3 -7
index 301079d..2ed1e98 100644
@@ -5956,13 +5956,9 @@ int perf_pmu_register(struct pmu *pmu, char *name, int type)
 	pmu->name = name;
 
 	if (type < 0) {
-		int err = idr_pre_get(&pmu_idr, GFP_KERNEL);
-		if (!err)
-			goto free_pdc;
-
-		err = idr_get_new_above(&pmu_idr, pmu, PERF_TYPE_MAX, &type);
-		if (err) {
-			ret = err;
+		type = idr_alloc(&pmu_idr, pmu, PERF_TYPE_MAX, 0, GFP_KERNEL);
+		if (type < 0) {
+			ret = type;
 			goto free_pdc;
 		}
 	}
Signature · 1 line
1.8.1
author maintainer
#93 lore raw

PATCH 57/62 posix-timers: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

Cc Thomas Gleixner <[email protected]>

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 kernel/posix-timers.c | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)
kernel/posix-timers.c +8 -10
index 69185ae..e897f66 100644
@@ -552,24 +552,22 @@ SYSCALL_DEFINE3(timer_create, const clockid_t, which_clock,
 		return -EAGAIN;
 
 	spin_lock_init(&new_timer->it_lock);
- retry:
-	if (unlikely(!idr_pre_get(&posix_timers_id, GFP_KERNEL))) {
-		error = -EAGAIN;
-		goto out;
-	}
+
+	idr_preload(GFP_KERNEL);
 	spin_lock_irq(&idr_lock);
-	error = idr_get_new(&posix_timers_id, new_timer, &new_timer_id);
+	error = idr_alloc(&posix_timers_id, new_timer, 0, 0, GFP_NOWAIT);
 	spin_unlock_irq(&idr_lock);
-	if (error) {
-		if (error == -EAGAIN)
-			goto retry;
+	idr_preload_end();
+	if (error < 0) {
 		/*
 		 * Weird looking, but we return EAGAIN if the IDR is
 		 * full (proper POSIX return value for this)
 		 */
-		error = -EAGAIN;
+		if (error == -ENOSPC)
+			error = -EAGAIN;
 		goto out;
 	}
+	new_timer_id = error;
 
 	it_id_set = IT_ID_SET;
 	new_timer->it_id = (timer_t) new_timer_id;
Signature · 1 line
1.8.1
author maintainer
#94 lore raw

PATCH 58/62 net/9p: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

Cc Eric Van Hensbergen <[email protected]>
Cc Ron Minnich <[email protected]>
Cc Latchesar Ionkov <[email protected]>

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 net/9p/util.c | 17 ++++++-----------
 1 file changed, 6 insertions(+), 11 deletions(-)
net/9p/util.c +6 -11
index 6ceeeb3..59f278e 100644
@@ -87,23 +87,18 @@ EXPORT_SYMBOL(p9_idpool_destroy);
 
 int p9_idpool_get(struct p9_idpool *p)
 {
-	int i = 0;
-	int error;
+	int i;
 	unsigned long flags;
 
-retry:
-	if (idr_pre_get(&p->pool, GFP_NOFS) == 0)
-		return -1;
-
+	idr_preload(GFP_NOFS);
 	spin_lock_irqsave(&p->lock, flags);
 
 	/* no need to store exactly p, we just need something non-null */
-	error = idr_get_new(&p->pool, p, &i);
-	spin_unlock_irqrestore(&p->lock, flags);
+	i = idr_alloc(&p->pool, p, 0, 0, GFP_NOWAIT);
 
-	if (error == -EAGAIN)
-		goto retry;
-	else if (error)
+	spin_unlock_irqrestore(&p->lock, flags);
+	idr_preload_end();
+	if (i < 0)
 		return -1;
 
 	p9_debug(P9_DEBUG_MUX, " id %d pool %p\n", i, p);
Signature · 1 line
1.8.1
author maintainer
#95 lore raw

PATCH 59/62 mac80211: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 net/mac80211/main.c |  2 --
 net/mac80211/tx.c   | 18 ++++--------------
 2 files changed, 4 insertions(+), 16 deletions(-)
net/mac80211/main.c +0 -2
index 1b087ff..7b5bbea 100644
@@ -687,8 +687,6 @@ struct ieee80211_hw *ieee80211_alloc_hw(size_t priv_data_len,
 
 	spin_lock_init(&local->ack_status_lock);
 	idr_init(&local->ack_status_frames);
-	/* preallocate at least one entry */
-	idr_pre_get(&local->ack_status_frames, GFP_KERNEL);
 
 	sta_info_init(local);
 
net/mac80211/tx.c +4 -14
index e9eadc4..73eb6c1 100644
@@ -1996,24 +1996,14 @@ netdev_tx_t ieee80211_subif_start_xmit(struct sk_buff *skb,
 		skb = skb_clone(skb, GFP_ATOMIC);
 		if (skb) {
 			unsigned long flags;
-			int id, r;
+			int id;
 
 			spin_lock_irqsave(&local->ack_status_lock, flags);
-			r = idr_get_new_above(&local->ack_status_frames,
-					      orig_skb, 1, &id);
-			if (r == -EAGAIN) {
-				idr_pre_get(&local->ack_status_frames,
-					    GFP_ATOMIC);
-				r = idr_get_new_above(&local->ack_status_frames,
-						      orig_skb, 1, &id);
-			}
-			if (WARN_ON(!id) || id > 0xffff) {
-				idr_remove(&local->ack_status_frames, id);
-				r = -ERANGE;
-			}
+			id = idr_alloc(&local->ack_status_frames, orig_skb,
+				       1, 0x10000, GFP_ATOMIC);
 			spin_unlock_irqrestore(&local->ack_status_lock, flags);
 
-			if (!r) {
+			if (id >= 0) {
 				info_id = id;
 				info_flags |= IEEE80211_TX_CTL_REQ_TX_STATUS;
 			} else if (skb_shared(skb)) {
Signature · 1 line
1.8.1
maintainer
#96 lore raw

Re: [PATCH 59/62] mac80211: convert to idr_alloc()

Quoted 11 lines · Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

Looks fine to me, thanks.

johannes

author maintainer
#97 lore raw

Re: [PATCH 59/62] mac80211: convert to idr_alloc()

Quoted 13 lines · Johannes Berg
Quoted 11 lines · Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

Quoted 1 line

Looks fine to me, thanks.

Will add Acked-by. Thanks a lot!

Signature · 1 line
tejun
author maintainer
#98 lore raw

PATCH 60/62 sctp: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

Cc Vlad Yasevich <[email protected]>
Cc Sridhar Samudrala <[email protected]>
Cc Neil Horman <[email protected]>

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 net/sctp/associola.c | 27 +++++++++++----------------
 1 file changed, 11 insertions(+), 16 deletions(-)
net/sctp/associola.c +11 -16
index b45ed1f..a9962e4 100644
@@ -1592,32 +1592,27 @@ int sctp_assoc_lookup_laddr(struct sctp_association *asoc,
 /* Set an association id for a given association */
 int sctp_assoc_set_id(struct sctp_association *asoc, gfp_t gfp)
 {
-	int assoc_id;
-	int error = 0;
+	int ret;
 
 	/* If the id is already assigned, keep it. */
 	if (asoc->assoc_id)
-		return error;
-retry:
-	if (unlikely(!idr_pre_get(&sctp_assocs_id, gfp)))
-		return -ENOMEM;
+		return 0;
 
+	idr_preload(gfp);
 	spin_lock_bh(&sctp_assocs_id_lock);
-	error = idr_get_new_above(&sctp_assocs_id, (void *)asoc,
-				    idr_low, &assoc_id);
-	if (!error) {
-		idr_low = assoc_id + 1;
+	ret = idr_alloc(&sctp_assocs_id, asoc, idr_low, 0, GFP_NOWAIT);
+	if (ret >= 0) {
+		idr_low = ret + 1;
 		if (idr_low = INT_MAX)
 			idr_low = 1;
 	}
 	spin_unlock_bh(&sctp_assocs_id_lock);
-	if (error = -EAGAIN)
-		goto retry;
-	else if (error)
-		return error;
+	idr_preload_end();
+	if (ret < 0)
+		return ret;
 
-	asoc->assoc_id = (sctp_assoc_t) assoc_id;
-	return error;
+	asoc->assoc_id = (sctp_assoc_t)ret;
+	return 0;
 }
 
 /* Free the ASCONF queue */
Signature · 1 line
1.8.1
Acked-by on v1 60/62
#99 lore raw

Re: [PATCH 60/62] sctp: convert to idr_alloc()

Quoted 9 lines · Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

Cc Vlad Yasevich <[email protected]>
Cc Sridhar Samudrala <[email protected]>
Cc Neil Horman <[email protected]>
Quoted 5 lines

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

Makes sense to me

Quoted 55 lines
 net/sctp/associola.c | 27 +++++++++++----------------
 1 file changed, 11 insertions(+), 16 deletions(-)
net/sctp/associola.c +11 -16
index b45ed1f..a9962e4 100644
@@ -1592,32 +1592,27 @@ int sctp_assoc_lookup_laddr(struct sctp_association *asoc,
 /* Set an association id for a given association */
 int sctp_assoc_set_id(struct sctp_association *asoc, gfp_t gfp)
 {
-	int assoc_id;
-	int error = 0;
+	int ret;
 
 	/* If the id is already assigned, keep it. */
 	if (asoc->assoc_id)
-		return error;
-retry:
-	if (unlikely(!idr_pre_get(&sctp_assocs_id, gfp)))
-		return -ENOMEM;
+		return 0;
 
+	idr_preload(gfp);
 	spin_lock_bh(&sctp_assocs_id_lock);
-	error = idr_get_new_above(&sctp_assocs_id, (void *)asoc,
-				    idr_low, &assoc_id);
-	if (!error) {
-		idr_low = assoc_id + 1;
+	ret = idr_alloc(&sctp_assocs_id, asoc, idr_low, 0, GFP_NOWAIT);
+	if (ret >= 0) {
+		idr_low = ret + 1;
 		if (idr_low = INT_MAX)
 			idr_low = 1;
 	}
 	spin_unlock_bh(&sctp_assocs_id_lock);
-	if (error = -EAGAIN)
-		goto retry;
-	else if (error)
-		return error;
+	idr_preload_end();
+	if (ret < 0)
+		return ret;
 
-	asoc->assoc_id = (sctp_assoc_t) assoc_id;
-	return error;
+	asoc->assoc_id = (sctp_assoc_t)ret;
+	return 0;
 }
 
 /* Free the ASCONF queue */
Signature · 1 line
1.8.1
#100 lore raw

Re: [PATCH 60/62] sctp: convert to idr_alloc()

In reply to Tejun Heo
Quoted 35 lines · Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

Cc Vlad Yasevich <[email protected]>
Cc Sridhar Samudrala <[email protected]>
Cc Neil Horman <[email protected]>

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

  net/sctp/associola.c | 27 +++++++++++----------------
  1 file changed, 11 insertions(+), 16 deletions(-)
net/sctp/associola.c +1 -6
index b45ed1f..a9962e4 100644
@@ -1592,32 +1592,27 @@ int sctp_assoc_lookup_laddr(struct sctp_association *asoc,
  /* Set an association id for a given association */
  int sctp_assoc_set_id(struct sctp_association *asoc, gfp_t gfp)
  {
-	int assoc_id;
-	int error = 0;
+	int ret;
 
  	/* If the id is already assigned, keep it. */
  	if (asoc->assoc_id)
-		return error;
-retry:
-	if (unlikely(!idr_pre_get(&sctp_assocs_id, gfp)))
-		return -ENOMEM;

net/sctp/associola.c int sctp_assoc_lookup_laddr(struct sctp_association *asoc, · line 1604

Quoted 10 lines
net/sctp/associola.c +4 -4
+		return 0;
 
+	idr_preload(gfp);
  	spin_lock_bh(&sctp_assocs_id_lock);
-	error = idr_get_new_above(&sctp_assocs_id, (void *)asoc,
-				    idr_low, &assoc_id);
-	if (!error) {
-		idr_low = assoc_id + 1;
+	ret = idr_alloc(&sctp_assocs_id, asoc, idr_low, 0, GFP_NOWAIT);
+	if (ret >= 0) {

In SCTP, association id is not allowed to be 0, so we have to treat 0 as an error.

-vlad

Quoted 21 lines
net/sctp/associola.c +6 -6
+		idr_low = ret + 1;
  		if (idr_low = INT_MAX)
  			idr_low = 1;
  	}
  	spin_unlock_bh(&sctp_assocs_id_lock);
-	if (error = -EAGAIN)
-		goto retry;
-	else if (error)
-		return error;
+	idr_preload_end();
+	if (ret < 0)
+		return ret;
 
-	asoc->assoc_id = (sctp_assoc_t) assoc_id;
-	return error;
+	asoc->assoc_id = (sctp_assoc_t)ret;
+	return 0;
  }
 
  /* Free the ASCONF queue */
author maintainer
#101 lore raw

Re: [PATCH 60/62] sctp: convert to idr_alloc()

Quoted 5 lines · Vlad Yasevich

net/sctp/associola.c int sctp_assoc_lookup_laddr(struct sctp_association *asoc, · line 1604

Quoted 2 lines
net/sctp/associola.c +2 -0
+	ret = idr_alloc(&sctp_assocs_id, asoc, idr_low, 0, GFP_NOWAIT);
+	if (ret >= 0) {

In SCTP, association id is not allowed to be 0, so we have to treat 0 as an error.

That condition is specified via @idr_low and 0 won't be returned. If your point is that the condition better be "ret > 0" for clarity, I don't know. At that point, we already requested an ID in the acceptable range and testing whether the allocation succeeded or not where failure will always be indicated by -errno.

We can surely add "if (ret = 0) ret = -EINVAL" but that would be a completely dead path (should we add dead retry loop too?). If we don't add such code, the code would appear as silently ignoring error.

So, I think "ret >= 0" is better there. Maybe we can throw in a comment explaining idr_low never goes to zero.

BTW, this style of cyclic allocation is broken. It's prone to -ENOSPC failure after the first wrap around. I think we need to implement proper cyclic support in idr, but let's worry about that later.

Thanks.

Signature · 1 line
tejun
author maintainer
#102 lore raw

PATCH v2 60/62 sctp: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

v2: Don't preload if @gfp doesn't contain __GFP_WAIT as the function
may be being called from non-process ocntext. Also, add a comment explaining @idr_low never becomes zero.

---
 net/sctp/associola.c |   31 +++++++++++++++----------------
 1 file changed, 15 insertions(+), 16 deletions(-)
net/sctp/associola.c +15 -16
@@ -1592,32 +1592,31 @@ int sctp_assoc_lookup_laddr(struct sctp_
 /* Set an association id for a given association */
 int sctp_assoc_set_id(struct sctp_association *asoc, gfp_t gfp)
 {
-	int assoc_id;
-	int error = 0;
+	bool preload = gfp & __GFP_WAIT;
+	int ret;
 
 	/* If the id is already assigned, keep it. */
 	if (asoc->assoc_id)
-		return error;
-retry:
-	if (unlikely(!idr_pre_get(&sctp_assocs_id, gfp)))
-		return -ENOMEM;
+		return 0;
 
+	if (preload)
+		idr_preload(gfp);
 	spin_lock_bh(&sctp_assocs_id_lock);
-	error = idr_get_new_above(&sctp_assocs_id, (void *)asoc,
-				    idr_low, &assoc_id);
-	if (!error) {
-		idr_low = assoc_id + 1;
+	/* 0 is not a valid id, idr_low is always >= 1 */
+	ret = idr_alloc(&sctp_assocs_id, asoc, idr_low, 0, GFP_NOWAIT);
+	if (ret >= 0) {
+		idr_low = ret + 1;
 		if (idr_low = INT_MAX)
 			idr_low = 1;
 	}
 	spin_unlock_bh(&sctp_assocs_id_lock);
-	if (error = -EAGAIN)
-		goto retry;
-	else if (error)
-		return error;
+	if (preload)
+		idr_preload_end();
+	if (ret < 0)
+		return ret;
 
-	asoc->assoc_id = (sctp_assoc_t) assoc_id;
-	return error;
+	asoc->assoc_id = (sctp_assoc_t)ret;
+	return 0;
 }
 
 /* Free the ASCONF queue */
Acked-by on v2 60/62
#103 lore raw

Re: [PATCH v2 60/62] sctp: convert to idr_alloc()

Quoted 8 lines · Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

v2: Don't preload if @gfp doesn't contain __GFP_WAIT as the function
may be being called from non-process ocntext. Also, add a comment explaining @idr_low never becomes zero.

Quoted 9 lines
---
 net/sctp/associola.c |   31 +++++++++++++++----------------
 1 file changed, 15 insertions(+), 16 deletions(-)

I dont' think the documentation was really needed, but the interrupt context fix was a good catch

author maintainer
#104 lore raw

PATCH 61/62 nfs4client: convert to idr_alloc()

In reply to Tejun Heo

Convert to the much saner new idr interface.

Only compile tested.

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 fs/nfs/nfs4client.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)
fs/nfs/nfs4client.c +6 -7
index acc3472..ff314f6 100644
@@ -29,15 +29,14 @@ static int nfs_get_cb_ident_idr(struct nfs_client *clp, int minorversion)
 
 	if (clp->rpc_ops->version != 4 || minorversion != 0)
 		return ret;
-retry:
-	if (!idr_pre_get(&nn->cb_ident_idr, GFP_KERNEL))
-		return -ENOMEM;
+	idr_preload(GFP_KERNEL);
 	spin_lock(&nn->nfs_client_lock);
-	ret = idr_get_new(&nn->cb_ident_idr, clp, &clp->cl_cb_ident);
+	ret = idr_alloc(&nn->cb_ident_idr, clp, 0, 0, GFP_NOWAIT);
+	if (ret >= 0)
+		clp->cl_cb_ident = ret;
 	spin_unlock(&nn->nfs_client_lock);
-	if (ret == -EAGAIN)
-		goto retry;
-	return ret;
+	idr_preload_end();
+	return ret < 0 ? ret : 0;
 }
 
 #ifdef CONFIG_NFS_V4_1
Signature · 1 line
1.8.1
author maintainer
#105 lore raw

PATCH 62/62 idr: deprecate idr_pre_get() and idr_get_new[_above]()

In reply to Tejun Heo

Now that all in-kernel users are converted to ues the new alloc interface, mark the old interface deprecated. We should be able to remove these in a few releases.

Cc Rusty Russell <[email protected]>

---
This patch depends on an earlier idr changes and I think it would be best to route these together through -mm. Please holler if there's any objection. Thanks.

 include/linux/idr.h | 66 ++++++++++++++++++++++++++++++++++++++++-------------
 lib/idr.c           | 41 ++++-----------------------------
 2 files changed, 55 insertions(+), 52 deletions(-)
include/linux/idr.h +50 -16
index 8d3ffe1..5ee5385 100644
@@ -92,8 +92,6 @@ struct idr {
  */
 
 void *idr_find(struct idr *idp, int id);
-int idr_pre_get(struct idr *idp, gfp_t gfp_mask);
-int idr_get_new_above(struct idr *idp, void *ptr, int starting_id, int *id);
 void idr_preload(gfp_t gfp_mask);
 int idr_alloc(struct idr *idp, void *ptr, int start, int end, gfp_t gfp_mask);
 int idr_for_each(struct idr *idp,
@@ -117,19 +115,6 @@ static inline void idr_preload_end(void)
 }
 
 /**
- * idr_get_new - allocate new idr entry
- * @idp: idr handle
- * @ptr: pointer you want associated with the id
- * @id: pointer to the allocated handle
- *
- * Simple wrapper around idr_get_new_above() w/ @starting_id of zero.
- */
-static inline int idr_get_new(struct idr *idp, void *ptr, int *id)
-{
-	return idr_get_new_above(idp, ptr, 0, id);
-}
-
-/**
  * idr_for_each_entry - iterate over an idr's elements of a given type
  * @idp:     idr handle
  * @entry:   the type * to use as cursor
@@ -140,7 +125,56 @@ static inline int idr_get_new(struct idr *idp, void *ptr, int *id)
 	     entry != NULL;                                             \
 	     ++id, entry = (typeof(entry))idr_get_next((idp), &(id)))
 
-void __idr_remove_all(struct idr *idp);	/* don't use */
+/*
+ * Don't use the following functions.  These exist only to suppress
+ * deprecated warnings on EXPORT_SYMBOL()s.
+ */
+int __idr_pre_get(struct idr *idp, gfp_t gfp_mask);
+int __idr_get_new_above(struct idr *idp, void *ptr, int starting_id, int *id);
+void __idr_remove_all(struct idr *idp);
+
+/**
+ * idr_pre_get - reserve resources for idr allocation
+ * @idp:	idr handle
+ * @gfp_mask:	memory allocation flags
+ *
+ * Part of old alloc interface.  This is going away.  Use
+ * idr_preload[_end]() and idr_alloc() instead.
+ */
+static inline int __deprecated idr_pre_get(struct idr *idp, gfp_t gfp_mask)
+{
+	return __idr_pre_get(idp, gfp_mask);
+}
+
+/**
+ * idr_get_new_above - allocate new idr entry above or equal to a start id
+ * @idp: idr handle
+ * @ptr: pointer you want associated with the id
+ * @starting_id: id to start search at
+ * @id: pointer to the allocated handle
+ *
+ * Part of old alloc interface.  This is going away.  Use
+ * idr_preload[_end]() and idr_alloc() instead.
+ */
+static inline int __deprecated idr_get_new_above(struct idr *idp, void *ptr,
+						 int starting_id, int *id)
+{
+	return __idr_get_new_above(idp, ptr, starting_id, id);
+}
+
+/**
+ * idr_get_new - allocate new idr entry
+ * @idp: idr handle
+ * @ptr: pointer you want associated with the id
+ * @id: pointer to the allocated handle
+ *
+ * Part of old alloc interface.  This is going away.  Use
+ * idr_preload[_end]() and idr_alloc() instead.
+ */
+static inline int __deprecated idr_get_new(struct idr *idp, void *ptr, int *id)
+{
+	return __idr_get_new_above(idp, ptr, 0, id);
+}
 
 /**
  * idr_remove_all - remove all ids from the given idr tree
lib/idr.c +5 -36

71 lines not on this page · raw message

Signature · 1 line
1.8.1
#106 lore raw
In reply to Tejun Heo
Quoted 1 line · Tejun Heo

Hello,

So my first response after looking at the ipc patch is ick.

Why the deep percpu magic?
Why don't associate idr_preload with an idr structure.

When reading code with idr_preload I get this deep down creepy feeling. What is this magic that is going on?

Can't we just put the preload list_head into struct idr make idr_preload and idr_preload_end take an idr argument?

Maybe we can have a special structure we put on the stack that has the list_head and the preload state instead.

The way this works just weirds me out and I really really don't like it.

I would rather continue to use the existing functions as problematic as they are as I don't need a course in deep magic to make sense of them.

Quoted 9 lines
	idr_preload(GFP_KERNEL);
	spin_lock(lock);

	id = idr_alloc(idr, ptr, lower_limit, upper_limit, GFP_NOWAIT);

	spin_unlock(lock);
	idr_preload_end();
	if (id < 0)
		return id;

Eric

author maintainer
#107 lore raw

Hey, Eric.

Quoted 1 line · Eric W. Biederman

Why the deep percpu magic?

Eh? What's magical about it? You preload percpu buffer if you're gonna be allocating an id from context which doesn't allow permissive allocation. This is the same technique used by radix tree preloading.
The only reason idr did its own preloading was probably because it
got implemented before we had proper percpu techniques.

Quoted 1 line

Why don't associate idr_preload with an idr structure.

Because then you end up with a lot more preloaded buffers which are much less useful. You can't guarantee your preload target is the only one who's gonna use the preload buffer so you end up with this ugly -EAGAIN retry loop. It's inefficient & inconvenient.

Quoted 2 lines

When reading code with idr_preload I get this deep down creepy feeling. What is this magic that is going on?

Seriously, if this gives you deep creepy feeling, you need to get on with time. It's a basic percpu technique.

Quoted 2 lines

Can't we just put the preload list_head into struct idr make idr_preload and idr_preload_end take an idr argument?

Inefficient & inconvenient.

Quoted 7 lines

Maybe we can have a special structure we put on the stack that has the list_head and the preload state instead.

The way this works just weirds me out and I really really don't like it.

I would rather continue to use the existing functions as problematic as they are as I don't need a course in deep magic to make sense of them.

Heh, this is the weirdest review I got in quite a while. Please sit down and read it again.

Thanks.

Signature · 1 line
tejun
#108 lore raw
Quoted 10 lines · Tejun Heo

Hey, Eric.

Quoted 1 line · Eric W. Biederman

Why the deep percpu magic?

Eh? What's magical about it? You preload percpu buffer if you're gonna be allocating an id from context which doesn't allow permissive allocation. This is the same technique used by radix tree preloading.
The only reason idr did its own preloading was probably because it
got implemented before we had proper percpu techniques.

Maybe. I haven't been in the parts of the kernel that use the radix tree preloading and I having just look at a bit of it I don't like it either. There is the same strong disconnect between the pieces whose side effects are interacting.

At least with the radix tree the pieces are core kernel pieces that get optimized like mad and you expect to have to think about.

idr is a boring thing you use because don't want to think about the details. Now you are asking people to really think about the details when the touch a piece of code using idr. I think that is the wrong trade off.

Quoted 6 lines
Quoted 1 line

Why don't associate idr_preload with an idr structure.

Because then you end up with a lot more preloaded buffers which are much less useful. You can't guarantee your preload target is the only one who's gonna use the preload buffer so you end up with this ugly -EAGAIN retry loop. It's inefficient & inconvenient.

That argument makes sense.

Quoted 5 lines
Quoted 2 lines

When reading code with idr_preload I get this deep down creepy feeling. What is this magic that is going on?

Seriously, if this gives you deep creepy feeling, you need to get on with time. It's a basic percpu technique.

But this isn't a basic percpu technique. This is a basic percpu technique hidden behind the wall.

Nothing about reading idr_preload() in a line of code says. Hey look at me I am version of preempt disable() that puts things in percpu variables that you don't know about.

Nothing about idr_preload says don't you dair forget to pair me with preload_end().

Quoted 7 lines
Quoted 2 lines

Can't we just put the preload list_head into struct idr make idr_preload and idr_preload_end take an idr argument?

Inefficient & inconvenient.

Quoted 2 lines

Maybe we can have a special structure we put on the stack that has the list_head and the preload state instead.

This suggestion you didn't address at all.

If we can't put state in the structure because of the problem of multiple accesses why can't we take the state out of the structure entirely and put it into a stack local variable?

That would reduce the cognitive load because it becomes clear how the pieces connect together.

That would remove the need for disabling preemption and other behind the scenes magic.

Quoted 7 lines
Quoted 4 lines

The way this works just weirds me out and I really really don't like it.

I would rather continue to use the existing functions as problematic as they are as I don't need a course in deep magic to make sense of them.

Heh, this is the weirdest review I got in quite a while. Please sit down and read it again.

Please sit down and relook at your interface again. People use idr where they need a unique number associatedand they really don't care. Having to think about hidden percpu variables and preemption being disabled in the background brings with it a lot of extra work to use the interface.

For the sake of a saving few lines of code you are desiging an interface that is harder to use correctly, and harder to think about.

I think you are making completely the wrong trade off. I don't want the cognitive burden of having to think about percpu and preemption disabling when using a boring utitlity function like the idr code.

Eric

author maintainer
#109 lore raw

Hey,

Quoted 7 lines · Eric W. Biederman

At least with the radix tree the pieces are core kernel pieces that get optimized like mad and you expect to have to think about.

idr is a boring thing you use because don't want to think about the details. Now you are asking people to really think about the details when the touch a piece of code using idr. I think that is the wrong trade off.

People use it as a generic indexing thing. It gets even used for per storage command or per network command. And really think about what? Preloading disables preemption. That's the only interface detail that affects anything.

Quoted 6 lines
Quoted 2 lines

Seriously, if this gives you deep creepy feeling, you need to get on with time. It's a basic percpu technique.

But this isn't a basic percpu technique. This is a basic percpu technique hidden behind the wall.

Quoted 6 lines

Nothing about reading idr_preload() in a line of code says. Hey look at me I am version of preempt disable() that puts things in percpu variables that you don't know about.

Nothing about idr_preload says don't you dair forget to pair me with preload_end().

So, is it that you are bothered that idr_preload() should be paired with _end()? I mean, it's clearly described so in the interface and you would even get a nice preemption level mismatch warning pretty quickly if you miss one unlike when you forget to handle -EAGAIN.

Quoted 4 lines
Quoted 2 lines
Quoted 2 lines

Maybe we can have a special structure we put on the stack that has the list_head and the preload state instead.

This suggestion you didn't address at all.

And do that for what? It's less convenient and you're gonna have to preload it fully every single time and then destroy it. Why do that?

Quoted 9 lines

If we can't put state in the structure because of the problem of multiple accesses why can't we take the state out of the structure entirely and put it into a stack local variable?

That would reduce the cognitive load because it becomes clear how the pieces connect together.

That would remove the need for disabling preemption and other behind the scenes magic.

Really, *you* need to lower your cognitive overhead on percpu operations. This is fairly basic stuff. I mean, if this is too hard or whatever, how do you even use RCU?

Quoted 2 lines

Please sit down and relook at your interface again. People use idr where they need a unique number associatedand they really don't care.

The above is simply untrue. We already have use cases where idr is heavily depended upon in hot paths.

Quoted 3 lines

Having to think about hidden percpu variables and preemption being disabled in the background brings with it a lot of extra work to use the interface.

I can't think of why but if this is somehow cognitively difficult for someone, just dfon't think about it and use the interface as described. That's the whole thing about having an interface, right?

Quoted 2 lines

For the sake of a saving few lines of code you are desiging an interface that is harder to use correctly, and harder to think about.

How the hell is it harder to use correctly? Before, you could theoretically get silent allocation failure very rarely without any indication. Now, you don't need silly looping and if you forget preload_end(), you wlil get a preemption warning very quickly.

Quoted 3 lines

I think you are making completely the wrong trade off. I don't want the cognitive burden of having to think about percpu and preemption disabling when using a boring utitlity function like the idr code.

Eric, I don't know. To me, you seem way out of touch on the subject. It really is a simple thing and percpu is something widely used in the kernel at this point. You just need to get used to it like we all needed to get used to with the idea of finer grained locking way back and RCU recently.

So, if you can propose an interface which is technically better, please do so; otherwise, I don't really think everyone should end up with a worse interface for the supposed congitive overhead that you have for some reason.

Thanks.

Signature · 1 line
tejun
#110 lore raw
In reply to Tejun Heo
Quoted 2 lines · Tejun Heo

* Bruce, I couldn't convert nfsd. Can you please help? More on it later.

...

Quoted 7 lines

I converted all in-kernel users except nfsd and staging drivers. nfsd splits preloading and actual id allocation in a way that per-cpu preloading can't be used. I couldn't follow the control flow to verify whether the current code is correct either. I think the best way would be allocating ID upfront without installing the handle and then later using idr_replace() to install the pointer when the ID actually gets used. Bruce, would something like that be possible?

Actually, I'm not even sure if that's necessary, we can probably just do it all at the start.

I'll try to have a patch doing that tomorrow.

--b.

#111 lore raw
Quoted 12 lines · J. Bruce Fields
Quoted 2 lines · Tejun Heo

* Bruce, I couldn't convert nfsd. Can you please help? More on it later.

...

Quoted 7 lines

I converted all in-kernel users except nfsd and staging drivers. nfsd splits preloading and actual id allocation in a way that per-cpu preloading can't be used. I couldn't follow the control flow to verify whether the current code is correct either. I think the best way would be allocating ID upfront without installing the handle and then later using idr_replace() to install the pointer when the ID actually gets used. Bruce, would something like that be possible?

Quoted 4 lines

Actually, I'm not even sure if that's necessary, we can probably just do it all at the start.

I'll try to have a patch doing that tomorrow.

So, something like this.

--b.

commit 9847160469b40345e1d78a7cbf9536761bb47d91

Author: J. Bruce Fields <[email protected]>
Date:   Sun Feb 3 12:23:01 2013 -0500

nfsd4: simplify idr allocation

We don't really need to preallocate at all; just allocate and initialize everything at once, but leave the sc_type field initially 0 to prevent finding the stateid till it's fully initialized.

fs/nfsd/nfs4state.c +52 -29
index 4db46aa..485b1f7 100644
@@ -261,33 +261,46 @@ static inline int get_new_stid(struct nfs4_stid *stid)
 	return new_stid;
 }
 
-static void init_stid(struct nfs4_stid *stid, struct nfs4_client *cl, unsigned char type)
+static struct nfs4_stid *nfs4_alloc_stid(struct nfs4_client *cl, struct
+kmem_cache *slab)
 {
-	stateid_t *s = &stid->sc_stateid;
+	struct idr *stateids = &cl->cl_stateids;
+	static int min_stateid = 0;
+	struct nfs4_stid *stid;
 	int new_id;
 
-	stid->sc_type = type;
+	stid = kmem_cache_alloc(slab, GFP_KERNEL);
+	if (!stid)
+		return NULL;
+
+	if (!idr_pre_get(stateids, GFP_KERNEL))
+		goto out_free;
+	if (idr_get_new_above(stateids, stid, min_stateid, &new_id))
+		goto out_free;
 	stid->sc_client = cl;
-	s->si_opaque.so_clid = cl->cl_clientid;
-	new_id = get_new_stid(stid);
-	s->si_opaque.so_id = (u32)new_id;
+	stid->sc_type = 0;
+	stid->sc_stateid.si_opaque.so_id = new_id;
+	stid->sc_stateid.si_opaque.so_clid = cl->cl_clientid;
 	/* Will be incremented before return to client: */
-	s->si_generation = 0;
-}
+	stid->sc_stateid.si_generation = 0;
 
-static struct nfs4_stid *nfs4_alloc_stid(struct nfs4_client *cl, struct kmem_cache *slab)
-{
-	struct idr *stateids = &cl->cl_stateids;
-
-	if (!idr_pre_get(stateids, GFP_KERNEL))
-		return NULL;
 	/*
-	 * Note: if we fail here (or any time between now and the time
-	 * we actually get the new idr), we won't need to undo the idr
-	 * preallocation, since the idr code caps the number of
-	 * preallocated entries.
+	 * It shouldn't be a problem to reuse an opaque stateid value.
+	 * I don't think it is for 4.1.  But with 4.0 I worry that, for
+	 * example, a stray write retransmission could be accepted by
+	 * the server when it should have been rejected.  Therefore,
+	 * adopt a trick from the sctp code to attempt to maximize the
+	 * amount of time until an id is reused, by ensuring they always
+	 * "increase" (mod INT_MAX):
 	 */
-	return kmem_cache_alloc(slab, GFP_KERNEL);
+
+	min_stateid = new_id+1;
+	if (min_stateid == INT_MAX)
+		min_stateid = 0;
+	return stid;
+out_free:
+	kfree(stid);
+	return NULL;
 }
 
 static struct nfs4_ol_stateid * nfs4_alloc_stateid(struct nfs4_client *clp)
@@ -316,7 +329,7 @@ alloc_init_deleg(struct nfs4_client *clp, struct nfs4_ol_stateid *stp, struct sv
 	dp = delegstateid(nfs4_alloc_stid(clp, deleg_slab));
 	if (dp == NULL)
 		return dp;
-	init_stid(&dp->dl_stid, clp, NFS4_DELEG_STID);
+	dp->dl_stid.sc_type = NFS4_DELEG_STID;
 	/*
 	 * delegation seqid's are never incremented.  The 4.1 special
 	 * meaning of seqid 0 isn't meaningful, really, but let's avoid
@@ -337,13 +350,21 @@ alloc_init_deleg(struct nfs4_client *clp, struct nfs4_ol_stateid *stp, struct sv
 	return dp;
 }
 
+void free_stid(struct nfs4_stid *s, struct kmem_cache *slab)
+{
+	struct idr *stateids = &s->sc_client->cl_stateids;
+
+	idr_remove(stateids, s->sc_stateid.si_opaque.so_id);
+	kmem_cache_free(slab, s);
+}
+
 void
 nfs4_put_delegation(struct nfs4_delegation *dp)
 {
 	if (atomic_dec_and_test(&dp->dl_count)) {
 		dprintk("NFSD: freeing dp %p\n",dp);
 		put_nfs4_file(dp->dl_file);
-		kmem_cache_free(deleg_slab, dp);
+		free_stid(&dp->dl_stid, deleg_slab);
 		num_delegations--;
 	}
 }
@@ -360,9 +381,7 @@ static void nfs4_put_deleg_lease(struct nfs4_file *fp)
 
 static void unhash_stid(struct nfs4_stid *s)
 {
-	struct idr *stateids = &s->sc_client->cl_stateids;
-
-	idr_remove(stateids, s->sc_stateid.si_opaque.so_id);
+	s->sc_type = 0;
 }
 
 /* Called under the state lock. */
@@ -519,7 +538,7 @@ static void close_generic_stateid(struct nfs4_ol_stateid *stp)
 
 static void free_generic_stateid(struct nfs4_ol_stateid *stp)
 {
-	kmem_cache_free(stateid_slab, stp);
+	free_stid(&stp->st_stid, stateid_slab);
 }
 
 static void release_lock_stateid(struct nfs4_ol_stateid *stp)
@@ -1258,7 +1277,12 @@ static void gen_confirm(struct nfs4_client *clp)
 
 static struct nfs4_stid *find_stateid(struct nfs4_client *cl, stateid_t *t)
 {
-	return idr_find(&cl->cl_stateids, t->si_opaque.so_id);
+	struct nfs4_stid *ret;
+
+	ret = idr_find(&cl->cl_stateids, t->si_opaque.so_id);
+	if (!ret || !ret->sc_type)
+		return NULL;
+	return ret;
 }
 
 static struct nfs4_stid *find_stateid_by_type(struct nfs4_client *cl, stateid_t *t, char typemask)
@@ -2444,9 +2468,8 @@ alloc_init_open_stateowner(unsigned int strhashval, struct nfs4_client *clp, str
 
 static void init_open_stateid(struct nfs4_ol_stateid *stp, struct nfs4_file *fp, struct nfsd4_open *open) {
 	struct nfs4_openowner *oo = open->op_openowner;
-	struct nfs4_client *clp = oo->oo_owner.so_client;
 
-	init_stid(&stp->st_stid, clp, NFS4_OPEN_STID);
+	stp->st_stid.sc_type = NFS4_OPEN_STID;
 	INIT_LIST_HEAD(&stp->st_lockowners);
 	list_add(&stp->st_perstateowner, &oo->oo_owner.so_stateids);
 	list_add(&stp->st_perfile, &fp->fi_stateids);
@@ -4032,7 +4055,7 @@ alloc_init_lock_stateid(struct nfs4_lockowner *lo, struct nfs4_file *fp, struct
 	stp = nfs4_alloc_stateid(clp);
 	if (stp == NULL)
 		return NULL;
-	init_stid(&stp->st_stid, clp, NFS4_LOCK_STID);
+	stp->st_stid.sc_type = NFS4_LOCK_STID;
 	list_add(&stp->st_perfile, &fp->fi_stateids);
 	list_add(&stp->st_perstateowner, &lo->lo_owner.so_stateids);
 	stp->st_stateowner = &lo->lo_owner;
author maintainer
#112 lore raw

Hey,

Quoted 13 lines · J. Bruce Fields
Quoted 12 lines · J. Bruce Fields
Quoted 2 lines · Tejun Heo

* Bruce, I couldn't convert nfsd. Can you please help? More on it later.

...

Quoted 7 lines

I converted all in-kernel users except nfsd and staging drivers. nfsd splits preloading and actual id allocation in a way that per-cpu preloading can't be used. I couldn't follow the control flow to verify whether the current code is correct either. I think the best way would be allocating ID upfront without installing the handle and then later using idr_replace() to install the pointer when the ID actually gets used. Bruce, would something like that be possible?

Quoted 6 lines
Quoted 4 lines

Actually, I'm not even sure if that's necessary, we can probably just do it all at the start.

I'll try to have a patch doing that tomorrow.

So, something like this.

Yeah, that should be easily convertable to the new interface. How should we route these changes? Your patch can go through the usual nfs channel and the conversion and deprecation patches can be held off until after -rc1. Does that sound okay?

Thanks.

Signature · 1 line
tejun
author maintainer
#113 lore raw
Quoted 4 lines · Tejun Heo

Yeah, that should be easily convertable to the new interface. How should we route these changes? Your patch can go through the usual nfs channel and the conversion and deprecation patches can be held off until after -rc1. Does that sound okay?

Ooh, BTW, the cyclic allocation is broken. It's prone to -ENOSPC after the first wraparound. There are several cyclic users in the kernel and I think it probably would be best to implement cyclic support in idr.

Thanks.

Signature · 1 line
tejun
#114 lore raw
Quoted 10 lines · Tejun Heo
Quoted 4 lines · Tejun Heo

Yeah, that should be easily convertable to the new interface. How should we route these changes? Your patch can go through the usual nfs channel and the conversion and deprecation patches can be held off until after -rc1. Does that sound okay?

Ooh, BTW, the cyclic allocation is broken. It's prone to -ENOSPC after the first wraparound. There are several cyclic users in the kernel and I think it probably would be best to implement cyclic support in idr.

Ugh. OK, well it'll take some work to wrap that around, so it's probably not urgent for nfsd.

--b.

#115 lore raw
In reply to Tejun Heo
Quoted 10 lines · Tejun Heo
Quoted 4 lines · Tejun Heo

Yeah, that should be easily convertable to the new interface. How should we route these changes? Your patch can go through the usual nfs channel and the conversion and deprecation patches can be held off until after -rc1. Does that sound okay?

Ooh, BTW, the cyclic allocation is broken. It's prone to -ENOSPC after the first wraparound. There are several cyclic users in the kernel and I think it probably would be best to implement cyclic support in idr.

Are you looking at this, by the way, or do you have any suggestions?

Wondering if it's something I should try to fix or if I should look into converting to some other data structure here.

--b.

author maintainer
#116 lore raw

Hello,

Quoted 9 lines · J. Bruce Fields
Quoted 4 lines

Ooh, BTW, the cyclic allocation is broken. It's prone to -ENOSPC after the first wraparound. There are several cyclic users in the kernel and I think it probably would be best to implement cyclic support in idr.

Are you looking at this, by the way, or do you have any suggestions?

Wondering if it's something I should try to fix or if I should look into converting to some other data structure here.

I am not working on it at the moment but I think the logical thing to do would be implementing cyclic support in idr and enabling it with, say, a different initializer - IDR_CYCLIC_INIT() or something. If you wanna fix it, please go ahead. :)

Thanks.

Signature · 1 line
tejun
#117 lore raw
Quoted 13 lines · On Thu, 21 Mar 2013 11:35:13 -0700 Tejun Heo <[email protected]> wrote:

Hello,

Quoted 9 lines · J. Bruce Fields
Quoted 4 lines

Ooh, BTW, the cyclic allocation is broken. It's prone to -ENOSPC after the first wraparound. There are several cyclic users in the kernel and I think it probably would be best to implement cyclic support in idr.

Are you looking at this, by the way, or do you have any suggestions?

Wondering if it's something I should try to fix or if I should look into converting to some other data structure here.

Quoted 7 lines

I am not working on it at the moment but I think the logical thing to do would be implementing cyclic support in idr and enabling it with, say, a different initializer - IDR_CYCLIC_INIT() or something. If you wanna fix it, please go ahead. :)

Thanks.

So, here's a first (very rough, completely untested) pass at fixing this for cyclic allocations. This looks like it'll probably fix the ENOSPC errors when the counter wraps.

I'm not sure this is really what's needed though.

Suppose we have a situation where most of the currently allocated IDs are clustered near the top of the range. When the counter wraps and we call idr_alloc with a low start value, won't it prefer to allocate from an existing layer instead of creating a new one?

If so, then means that after the counter wraps, it can skip over all of the low values and reuse a more recently used high value. Is that OK for the existing cyclic users? Or do we need to do something more elaborate to make it prefer IDs at the low ranges after the counter wraps?

-------------------[snip]--------------------

[PATCH] idr: introduce idr_alloc_cyclic

Thus spake Tejun Heo:

Ooh, BTW, the cyclic allocation is broken. It's prone to -ENOSPC after the first wraparound. There are several cyclic users in the kernel and I think it probably would be best to implement cyclic support in idr.

This patch does that by adding new idr_alloc_cyclic function that such users in the kernel can use. The idea here is that the caller will keep a static counter of some sort that we can use to track where the next "start" value should be on the next allocation.

---
 include/linux/idr.h |  1 +
 lib/idr.c           | 27 +++++++++++++++++++++++++++
 2 files changed, 28 insertions(+)
include/linux/idr.h +1 -0
index 2640c7e..c6ac330 100644
@@ -75,6 +75,7 @@ struct idr {
 void *idr_find_slowpath(struct idr *idp, int id);
 void idr_preload(gfp_t gfp_mask);
 int idr_alloc(struct idr *idp, void *ptr, int start, int end, gfp_t gfp_mask);
+int idr_alloc_cyclic(struct idr *idr, void *ptr, int start, int end, int *cur, gfp_t gfp_mask);
 int idr_for_each(struct idr *idp,
 		 int (*fn)(int id, void *p, void *data), void *data);
 void *idr_get_next(struct idr *idp, int *nextid);
lib/idr.c +27 -0
index 322e281..d835dba 100644
@@ -495,6 +495,33 @@ int idr_alloc(struct idr *idr, void *ptr, int start, int end, gfp_t gfp_mask)
 }
 EXPORT_SYMBOL_GPL(idr_alloc);
 
+/**
+ * idr_alloc_cyclic - allocate new idr entry in a cyclical fashion
+ * @idr: the (initialized) idr
+ * @ptr: pointer to be associated with the new id
+ * @start: the minimum id (inclusive)
+ * @end: the maximum id (exclusive, <= 0 for max)
+ * @cur: ptr to current position in the range (typically, last allocated + 1)
+ * @gfp_mask: memory allocation flags
+ *
+ * Essentially the same as idr_alloc, but prefers to allocate progressively
+ * higher ids if it can. If the "cur" counter wraps, then it will start again
+ * at the "start" end of the range and allocate one that has already been used.
+ */
+int idr_alloc_cyclic(struct idr *idr, void *ptr, int start, int end, int *cur,
+			gfp_t gfp_mask)
+{
+	int id;
+
+	id = idr_alloc(idr, ptr, *cur, end, gfp_mask);
+	if (id == -ENOSPC)
+		id = idr_alloc(idr, ptr, start, end, gfp_mask);
+
+	if (likely(id >= 0))
+		*cur = id + 1;
+	return id;
+}
+
 static void idr_remove_warning(int id)
 {
 	printk(KERN_WARNING
Signature · 1 line
1.7.11.7
author maintainer
#118 lore raw

Hello, Jeff.

Quoted 16 lines · Jeff Layton
lib/idr.c +16 -0
+/**
+ * idr_alloc_cyclic - allocate new idr entry in a cyclical fashion
+ * @idr: the (initialized) idr
+ * @ptr: pointer to be associated with the new id
+ * @start: the minimum id (inclusive)
+ * @end: the maximum id (exclusive, <= 0 for max)
+ * @cur: ptr to current position in the range (typically, last allocated + 1)
+ * @gfp_mask: memory allocation flags
+ *
+ * Essentially the same as idr_alloc, but prefers to allocate progressively
+ * higher ids if it can. If the "cur" counter wraps, then it will start again
+ * at the "start" end of the range and allocate one that has already been used.
+ */
+int idr_alloc_cyclic(struct idr *idr, void *ptr, int start, int end, int *cur,
+			gfp_t gfp_mask)
+{

lib/idr.c int idr_alloc(struct idr *idr, void *ptr, int start, int end, gfp_t gfp_mask) · line 523

Quoted 10 lines
lib/idr.c +10 -0
+	int id;
+
+	id = idr_alloc(idr, ptr, *cur, end, gfp_mask);
+	if (id == -ENOSPC)
+		id = idr_alloc(idr, ptr, start, end, gfp_mask);
+
+	if (likely(id >= 0))
+		*cur = id + 1;
+	return id;
+}

Wouldn't it be better if idr itself could remember the last position? Also, @start/@end should always be honored even if, say, @start moves above the last position. Other than that, yeah.

Thanks.

Signature · 1 line
tejun
#119 lore raw
Quoted 25 lines · Tejun Heo

Hello, Jeff.

Quoted 22 lines · Jeff Layton
lib/idr.c +22 -0
+/**
+ * idr_alloc_cyclic - allocate new idr entry in a cyclical fashion
+ * @idr: the (initialized) idr
+ * @ptr: pointer to be associated with the new id
+ * @start: the minimum id (inclusive)
+ * @end: the maximum id (exclusive, <= 0 for max)
+ * @cur: ptr to current position in the range (typically, last allocated + 1)
+ * @gfp_mask: memory allocation flags
+ *
+ * Essentially the same as idr_alloc, but prefers to allocate progressively
+ * higher ids if it can. If the "cur" counter wraps, then it will start again
+ * at the "start" end of the range and allocate one that has already been used.
+ */
+int idr_alloc_cyclic(struct idr *idr, void *ptr, int start, int end, int *cur,
+			gfp_t gfp_mask)
+{
+	int id;
+
+	id = idr_alloc(idr, ptr, *cur, end, gfp_mask);
+	if (id == -ENOSPC)
+		id = idr_alloc(idr, ptr, start, end, gfp_mask);
+
Quoted 8 lines

lib/idr.c int idr_alloc(struct idr *idr, void *ptr, int start, int end, gfp_t gfp_mask) · line 523

Quoted 4 lines
lib/idr.c +4 -0
+	if (likely(id >= 0))
+		*cur = id + 1;
+	return id;
+}

Wouldn't it be better if idr itself could remember the last position? Also, @start/@end should always be honored even if, say, @start moves above the last position. Other than that, yeah.

The old nfsd stateid code just generated stateid's from a counter, something like:

	static u32 counter;
	return counter++;

and then stuck them in a hash table. Which had the obvious bug with (very unlikely, absent malice) collisions on wraparound.

I probably should have ignored idr and just made the obvious fix:

	static u32 counter;

	while (!id_exists_in_hash(counter))
		counter++;
	return counter;

So maybe we should just go back to that. And possibly choose some better data structure.

The only requirements are that at a given moment in time id's should be unique, and that we should make some effort to avoid reusing them immediately.

I don't know what other "cyclic" idr users need.

--b.

author maintainer
#120 lore raw

Hello,

Quoted 5 lines · J. Bruce Fields

The only requirements are that at a given moment in time id's should be unique, and that we should make some effort to avoid reusing them immediately.

I don't know what other "cyclic" idr users need.

We already have other users and idr would at least behave better (ie. fail faster) under extreme conditions, so sticking with idr might not be too bad. The optimal would be bitmap + hashtable, I suppose.

Thanks.

Signature · 1 line
tejun
author maintainer
#121 lore raw
Quoted 1 line · Tejun Heo

not be too bad. The optimal would be bitmap + hashtable, I suppose.

Oops, with more restricted (or at least dynamically adjusted) ID space, that is.

The problem with idr is that it can get pretty wasteful if the IDs become very scattered - the worst case being one ID per each idr_layer (the internal allocation block). That said, even cyclic allocation should yield somewhat clustered IDs, so I don't think it'd be too bad.

Thanks.

Signature · 1 line
tejun
#122 lore raw
Quoted 11 lines · On Tue, 26 Mar 2013 09:36:35 -0700 Tejun Heo <[email protected]> wrote:
Quoted 1 line · Tejun Heo

not be too bad. The optimal would be bitmap + hashtable, I suppose.

Oops, with more restricted (or at least dynamically adjusted) ID space, that is.

The problem with idr is that it can get pretty wasteful if the IDs become very scattered - the worst case being one ID per each idr_layer (the internal allocation block). That said, even cyclic allocation should yield somewhat clustered IDs, so I don't think it'd be too bad.

Right, that's a (minor) concern too...

While we can assume that cyclic allocations will probably give you clustered IDs, we're somewhat at the mercy of the clients when it comes to freeing them.

So, one could imagine a hostile client that attempts to DoS the server by creating new stateids and releasing all but one in each idr_layer as it goes.

Of course there are probably better ways to bring down the NFS server :).

Signature · 1 line
Jeff Layton <[email protected]>
#123 lore raw
In reply to Tejun Heo
Quoted 19 lines · Tejun Heo

Hey,

Quoted 16 lines · J. Bruce Fields
Quoted 15 lines · J. Bruce Fields
Quoted 2 lines · Tejun Heo

* Bruce, I couldn't convert nfsd. Can you please help? More on it later.

...

Quoted 7 lines

I converted all in-kernel users except nfsd and staging drivers. nfsd splits preloading and actual id allocation in a way that per-cpu preloading can't be used. I couldn't follow the control flow to verify whether the current code is correct either. I think the best way would be allocating ID upfront without installing the handle and then later using idr_replace() to install the pointer when the ID actually gets used. Bruce, would something like that be possible?

Actually, I'm not even sure if that's necessary, we can probably just do it all at the start.

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

I'll try to have a patch doing that tomorrow.

So, something like this.

Yeah, that should be easily convertable to the new interface. How should we route these changes? Your patch can go through the usual nfs channel and the conversion and deprecation patches can be held off until after -rc1. Does that sound okay?

Whatever's easiest for you. That sounds fine to me.

--b.

author maintainer
#124 lore raw
In reply to Tejun Heo

Hello,

I rolled up all the updates and rebased it on top of today's linux-next (20130204).

git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git convert-to-idr_alloc

The git branch contains the following.

[1] [PATCH] idr: fix a subtle bug in idr_get_next()
+ [2] [PATCHSET] idr: deprecate idr_remove_all()
+ [3] [PATCHSET] idr: implement idr_alloc() and convert existing users (w/ all updates)

The only conflict from rebasing it on top of -next is in drm_get_connector_status_name() which moved id assignment inside mutex and trivial to resolve.

Given the size of the patchset, I'm waiting a bit more before reposting the whole thing. If anyone wants it reposted now, please let me know.

Thanks.

Signature · 5 lines
tejun

[1] https://lkml.org/lkml/2013/2/2/145
[2] https://lkml.org/lkml/2013/1/25/759
[3] https://lkml.org/lkml/2013/2/2/159
#125 lore raw

It looks like this kernel won't compile with CONFIG_HOTPLUG_MEMORY set to 'y'

Mike

Quoted 37 lines

-----Original Message-----
From: Tejun Heo [mailto:[email protected]] On Behalf Of Tejun Heo
Sent: Monday, February 04, 2013 2:17 PM
To: [email protected]
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Marciniszyn, Mike
Subject: Re: [PATCHSET] idr: implement idr_alloc() and convert existing users

Hello,

I rolled up all the updates and rebased it on top of today's linux-next (20130204).

git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git convert-to-idr_alloc

The git branch contains the following.

[1] [PATCH] idr: fix a subtle bug in idr_get_next()
+ [2] [PATCHSET] idr: deprecate idr_remove_all() [3] [PATCHSET] idr:
+ implement idr_alloc() and convert existing users (w/ all updates)

The only conflict from rebasing it on top of -next is in drm_get_connector_status_name() which moved id assignment inside mutex and trivial to resolve.

Given the size of the patchset, I'm waiting a bit more before reposting the whole thing. If anyone wants it reposted now, please let me know.

Thanks.

--
tejun

[1] https://lkml.org/lkml/2013/2/2/145
[2] https://lkml.org/lkml/2013/1/25/759
[3] https://lkml.org/lkml/2013/2/2/159

author maintainer
#126 lore raw
Quoted 1 line · Mike

It looks like this kernel won't compile with CONFIG_HOTPLUG_MEMORY set to 'y'

Hmm... it build fine here. Can you please attach the .config?

Thanks.

Signature · 1 line
tejun
#127 lore raw
Quoted 2 lines

Hmm... it build fine here. Can you please attach the .config?

See attached. config.txt is renamed from .config. log.txt is a script from make -j 8.

Mike

Script started on Mon 04 Feb 2013 05:13:50 PM EST m]0;mmarciniszyn@phemb007:~/repos/misc[?1034h[mmarciniszyn@phemb007 misc]$ make -j 8;exit scripts/kconfig/conf --silentoldconfig Kconfig
make[1]: Nothing to be done for `all'.

  CHK     include/generated/uapi/linux/version.h
  HOSTCC  scripts/kallsyms
  HOSTCC  scripts/pnmtologo
  HOSTCC  scripts/genksyms/genksyms.o
  CC      scripts/mod/empty.o
  HOSTCC  scripts/selinux/genheaders/genheaders
  HOSTCC  scripts/conmakehash
  HOSTCC  scripts/mod/mk_elfconfig
  HOSTCC  scripts/recordmcount
  CC      scripts/mod/devicetable-offsets.s
  MKELF   scripts/mod/elfconfig.h
  HOSTCC  scripts/genksyms/lex.lex.o
  HOSTCC  scripts/genksyms/parse.tab.o
  HOSTCC  scripts/sortextable
  HOSTCC  scripts/mod/modpost.o
  HOSTCC  scripts/selinux/mdp/mdp
  HOSTCC  scripts/mod/sumversion.o
  HOSTLD  scripts/genksyms/genksyms
  GEN     scripts/mod/devicetable-offsets.h
  HOSTCC  scripts/mod/file2alias.o
  HOSTCC  arch/x86/tools/relocs
  HOSTLD  scripts/mod/modpost
  CHK     include/generated/utsrelease.h
  CC      kernel/bounds.s
  GEN     include/generated/bounds.h
  CC      arch/x86/kernel/asm-offsets.s
  GEN     include/generated/asm-offsets.h
  CALL    scripts/checksyscalls.sh
  CHK     include/generated/compile.h
  CC      init/main.o
  CC      init/do_mounts.o
  CC      init/do_mounts_rd.o
  CC      init/do_mounts_initrd.o
  CC      init/initramfs.o
  CC      init/do_mounts_md.o
  HOSTCC  usr/gen_init_cpio
  CC      init/calibrate.o
  GEN     usr/initramfs_data.cpio
  AS      usr/initramfs_data.o
  LD      usr/built-in.o
  CC      init/init_task.o
  LD      arch/x86/crypto/built-in.o
  CC [M]  arch/x86/crypto/ablk_helper.o
  CC      kernel/fork.o
  CC      init/version.o
  CC      kernel/exec_domain.o
  CC      kernel/panic.o
  CC      kernel/printk.o
  CC      kernel/cpu.o
  AS [M]  arch/x86/crypto/aes-x86_64-asm_64.o
  CC      kernel/exit.o
  CC [M]  arch/x86/crypto/aes_glue.o
  CC      kernel/itimer.o
  AS      arch/x86/ia32/ia32entry.o
  CC      arch/x86/ia32/sys_ia32.o
  AS [M]  arch/x86/crypto/aesni-intel_asm.o
  LD      init/mounts.o
  LD      init/built-in.o
  CC      arch/x86/ia32/ia32_signal.o
  CC [M]  arch/x86/crypto/aesni-intel_glue.o
  CC [M]  arch/x86/crypto/fpu.o
  CC [M]  arch/x86/crypto/crc32c-intel_glue.o
  AS [M]  arch/x86/crypto/crc32c-pcl-intel-asm_64.o
  TIMEC   kernel/timeconst.h
  CC      kernel/softirq.o
  CC      arch/x86/ia32/nosyscall.o
  CC      kernel/resource.o
  CC      kernel/sysctl.o
  CC      arch/x86/kernel/process_64.o
  AS [M]  arch/x86/crypto/ghash-clmulni-intel_asm.o
  CC      arch/x86/ia32/syscall_ia32.o
  CC      kernel/sysctl_binary.o
  CC [M]  arch/x86/crypto/ghash-clmulni-intel_glue.o
  CC      arch/x86/ia32/ipc32.o
  CC      arch/x86/ia32/audit.o
  AS [M]  arch/x86/crypto/salsa20-x86_64-asm_64.o
  CC      kernel/capability.o
  CC [M]  arch/x86/crypto/salsa20_glue.o
  CC      kernel/ptrace.o
  LD      arch/x86/ia32/built-in.o
  CC      kernel/timer.o
  AS [M]  arch/x86/crypto/twofish-x86_64-asm_64.o
  CC      kernel/user.o
  CC [M]  arch/x86/crypto/twofish_glue.o
  CC      kernel/signal.o
  CC      arch/x86/kernel/signal.o
  CC      kernel/sys.o
  CC      mm/filemap.o
  LD [M]  arch/x86/crypto/aes-x86_64.o
  LD [M]  arch/x86/crypto/twofish-x86_64.o
  LD [M]  arch/x86/crypto/salsa20-x86_64.o
  LD [M]  arch/x86/crypto/aesni-intel.o
  LD [M]  arch/x86/crypto/ghash-clmulni-intel.o
  LD [M]  arch/x86/crypto/crc32c-intel.o
  CC      mm/mempool.o
  LD      arch/x86/kvm/built-in.o
  CC [M]  arch/x86/kvm/svm.o
  CC      mm/oom_kill.o
  AS      arch/x86/kernel/entry_64.o
  CC      arch/x86/mm/init.o
  CC      arch/x86/kernel/traps.o
  CC      kernel/kmod.o
  CC      fs/open.o
  CC      fs/read_write.o
  CC      arch/x86/mm/init_64.o
  CC      mm/fadvise.o
  CC      mm/maccess.o
  CC      arch/x86/kernel/irq.o
  CC      kernel/workqueue.o
  CC      kernel/pid.o
arch/x86/mm/init_64.c:1023: warning: ‘kernel_physical_mapping_remove’ defined but not used
  CC      mm/page_alloc.o
  CC      kernel/task_work.o
  CC      arch/x86/kernel/irq_64.o
  CC      fs/file_table.o
arch/x86/mm/init_64.c: In function ‘remove_pagetable.clone.0’:
arch/x86/mm/init_64.c:990: warning: ‘next’ may be used uninitialized in this function
  CC      fs/super.o
  CC [M]  arch/x86/kvm/vmx.o
  CC      arch/x86/kernel/dumpstack_64.o
  CC      arch/x86/mm/fault.o
  CC      arch/x86/mm/ioremap.o
  CC      arch/x86/mm/extable.o
  CC      kernel/rcupdate.o
  CC      arch/x86/kernel/time.o
  CC      fs/char_dev.o
  CC      arch/x86/kernel/ioport.o
  CC      arch/x86/mm/pageattr.o
  CC      kernel/extable.o
  CC      fs/stat.o
  CC      arch/x86/kernel/ldt.o
  CC      arch/x86/kernel/dumpstack.o
  CC      kernel/params.o
  CC      kernel/posix-timers.o
  CC      kernel/kthread.o
  CC      arch/x86/kernel/nmi.o
  CC      fs/exec.o
  CC      mm/page-writeback.o
  CC      arch/x86/mm/mmap.o
  CC      kernel/wait.o
  CC      mm/readahead.o
  CC      ipc/compat.o
  CC      arch/x86/kernel/setup.o
  CC [M]  arch/x86/kvm/../../../virt/kvm/kvm_main.o
  CC      arch/x86/mm/pat.o
  CC      kernel/sys_ni.o
  CC      mm/swap.o
  CC      fs/pipe.o
  CC      kernel/posix-cpu-timers.o
  CC      mm/truncate.o
  CC      ipc/util.o
  CC      arch/x86/mm/pgtable.o
  CC      arch/x86/kernel/x86_init.o
  CC      ipc/msgutil.o
  CC      kernel/mutex.o
  CC      kernel/hrtimer.o
  CC      mm/vmscan.o
  CC      arch/x86/mm/physaddr.o
  CC      fs/namei.o
  CC      ipc/msg.o
  CC      arch/x86/mm/gup.o
  CC      arch/x86/mm/setup_nx.o
  CC      arch/x86/kernel/i8259.o
  CC      arch/x86/kernel/irqinit.o
  CC      arch/x86/mm/pat_rbtree.o
  CC      arch/x86/mm/tlb.o
  CC      ipc/sem.o
  CC      kernel/rwsem.o
  CC [M]  arch/x86/kvm/../../../virt/kvm/ioapic.o
  CC      arch/x86/kernel/jump_label.o
  CC [M]  arch/x86/kvm/../../../virt/kvm/coalesced_mmio.o
  CC      arch/x86/kernel/irq_work.o
  CC      kernel/nsproxy.o
  CC      arch/x86/mm/hugetlbpage.o
  CC      arch/x86/kernel/probe_roms.o
  CC      arch/x86/kernel/sys_x86_64.o
  CC      ipc/shm.o
  CC [M]  arch/x86/kvm/../../../virt/kvm/irq_comm.o
  CC      kernel/srcu.o
  CC      arch/x86/mm/numa.o
  CC      mm/shmem.o
  CC      fs/fcntl.o
  CC      mm/util.o
  CC      arch/x86/kernel/x8664_ksyms_64.o
  CC      kernel/semaphore.o
  CC      ipc/ipcns_notifier.o
  CC      arch/x86/kernel/syscall_64.o
  CC      arch/x86/kernel/vsyscall_64.o
  CC [M]  arch/x86/kvm/../../../virt/kvm/eventfd.o
  CC      ipc/syscall.o
  CC      arch/x86/mm/numa_64.o
  CC      ipc/ipc_sysctl.o
  CC      fs/ioctl.o
  CC      kernel/notifier.o
  CC      arch/x86/mm/amdtopology.o
  CC      ipc/mqueue.o
  CC      kernel/ksysfs.o
  AS      arch/x86/kernel/vsyscall_emu_64.o
  CC      arch/x86/kernel/bootflag.o
  CC [M]  arch/x86/kvm/../../../virt/kvm/assigned-dev.o
  CC [M]  arch/x86/kvm/../../../virt/kvm/iommu.o
  CC      arch/x86/mm/srat.o
  CC      arch/x86/kernel/e820.o
  CC      fs/readdir.o
  CC      kernel/cred.o
  CC      mm/mmzone.o
  LD      arch/x86/mm/built-in.o
  CC      mm/vmstat.o
  CC      ipc/compat_mq.o
  CC [M]  arch/x86/kvm/../../../virt/kvm/async_pf.o
  CC [M]  arch/x86/kvm/x86.o
  CC      fs/select.o
  CC      kernel/async.o
  CC      mm/backing-dev.o
  CC      arch/x86/kernel/pci-dma.o
  CC      arch/x86/kernel/quirks.o
  CC      ipc/namespace.o
  CC      kernel/range.o
  CC      kernel/groups.o
  CC      ipc/mq_sysctl.o
  CC      fs/fifo.o
  CC      kernel/lglock.o
  CC      kernel/smpboot.o
  CC      mm/mm_init.o
  LD      ipc/built-in.o
  CC      mm/mmu_context.o
  CC      arch/x86/kernel/topology.o
  CC      fs/dcache.o
  CC      kernel/debug/debug_core.o
  CC      kernel/debug/gdbstub.o
  LD      arch/x86/net/built-in.o
  CC      security/integrity/iint.o
  CC      security/integrity/ima/ima_fs.o
  CC      arch/x86/kernel/kdebugfs.o
  CC      mm/percpu.o
  CC      mm/slab_common.o
  CC      fs/inode.o
  CC      security/integrity/ima/ima_queue.o
  CC      arch/x86/kernel/alternative.o
  LD      kernel/debug/built-in.o
  CC      kernel/events/core.o
  CC      security/integrity/ima/ima_init.o
  CC      security/integrity/ima/ima_main.o
  CC      security/integrity/ima/ima_crypto.o
  CC      arch/x86/kernel/i8253.o
  CC      arch/x86/kernel/pci-nommu.o
  CC      mm/compaction.o
  CC      mm/balloon_compaction.o
  CC      arch/x86/kernel/hw_breakpoint.o
  CC      security/integrity/ima/ima_api.o
  LD      arch/x86/platform/ce4100/built-in.o
  CC      arch/x86/platform/efi/efi.o
  CC      fs/attr.o
  CC      security/integrity/ima/ima_policy.o
  CC      fs/bad_inode.o
  CC      arch/x86/kernel/tsc.o
  CC      arch/x86/realmode/init.o
  CC      mm/interval_tree.o
  CC      fs/file.o
  CC      arch/x86/platform/efi/efi_64.o
  CC      security/integrity/ima/ima_audit.o
  AS      arch/x86/realmode/rm/header.o
  AS      arch/x86/realmode/rm/trampoline_64.o
  LD      security/integrity/ima/ima.o
  AS      arch/x86/realmode/rm/stack.o
  LD      security/integrity/ima/built-in.o
  AS      arch/x86/realmode/rm/reboot.o
  CC [M]  arch/x86/kvm/mmu.o
  LD      security/integrity/integrity.o
  LD      security/integrity/built-in.o
  AS      arch/x86/realmode/rm/wakeup_asm.o
  AS      arch/x86/platform/efi/efi_stub_64.o
  CC      security/keys/gc.o
  LD      arch/x86/platform/efi/built-in.o
  CC      mm/fremap.o
  CC      arch/x86/realmode/rm/wakemain.o
  LD      arch/x86/platform/geode/built-in.o
  CC      arch/x86/kernel/io_delay.o
  LD      arch/x86/platform/goldfish/built-in.o
  LD      arch/x86/platform/iris/built-in.o
  LD      arch/x86/platform/mrst/built-in.o
  LD      arch/x86/platform/olpc/built-in.o
  LD      arch/x86/platform/scx200/built-in.o
  CC      arch/x86/platform/sfi/sfi.o
  CC      arch/x86/realmode/rm/video-mode.o
  AS      arch/x86/realmode/rm/copy.o
  AS      arch/x86/realmode/rm/bioscall.o
  CC      arch/x86/realmode/rm/regs.o
  CC      arch/x86/realmode/rm/video-vga.o
  CC      arch/x86/kernel/rtc.o
  CC      security/keys/key.o
  CC      arch/x86/realmode/rm/video-vesa.o
  LD      arch/x86/platform/sfi/built-in.o
  CC      fs/filesystems.o
  LD      arch/x86/platform/ts5500/built-in.o
  CC      kernel/events/ring_buffer.o
  LD      arch/x86/platform/uv/built-in.o
  LD      arch/x86/platform/visws/built-in.o
  LD      arch/x86/platform/built-in.o
  CC      fs/namespace.o
  CC      arch/x86/realmode/rm/video-bios.o
  PASYMS  arch/x86/realmode/rm/pasyms.h
  LDS     arch/x86/realmode/rm/realmode.lds
  LD      arch/x86/realmode/rm/realmode.elf
  RELOCS  arch/x86/realmode/rm/realmode.relocs
  OBJCOPY arch/x86/realmode/rm/realmode.bin
  AS      arch/x86/realmode/rmpiggy.o
  LD      arch/x86/realmode/built-in.o
  CC      fs/seq_file.o
  CC      mm/highmem.o
arch/x86/kvm/mmu.c: In function ‘kvm_test_age_rmapp’:
arch/x86/kvm/mmu.c:1386: warning: ‘iter.desc’ may be used uninitialized in this function
  CC      kernel/events/callchain.o
  CC      arch/x86/kernel/pci-iommu_table.o
  CC      security/keys/keyring.o
  CC      fs/xattr.o
  CC      mm/madvise.o
  CC      mm/memory.o
  CC      arch/x86/kernel/resource.o
  CC      kernel/events/hw_breakpoint.o
  CC      arch/x86/kernel/process.o
  CC      security/keys/keyctl.o
  CC      security/keys/permission.o
  CC      crypto/api.o
  LD      kernel/events/built-in.o
  CC      fs/libfs.o
  CC      fs/fs-writeback.o
  CC      kernel/irq/irqdesc.o
  CC      arch/x86/kernel/i387.o
  CC      security/keys/process_keys.o
  CC [M]  arch/x86/kvm/emulate.o
  CC      crypto/cipher.o
  CC      security/keys/request_key.o
  CC      kernel/irq/handle.o
  CC      mm/mincore.o
  CC      mm/mlock.o
  CC      arch/x86/kernel/xsave.o
  CC      kernel/irq/manage.o
  CC      crypto/compress.o
  CC      security/keys/request_key_auth.o
  CC      security/keys/user_defined.o
  CC      arch/x86/kernel/ptrace.o
  CC      crypto/algapi.o
  CC      kernel/irq/spurious.o
  CC      mm/mmap.o
  CC      kernel/power/qos.o
  CC      security/keys/compat.o
  CC      kernel/irq/resend.o
  CC      fs/pnode.o
  CC [M]  arch/x86/kvm/i8259.o
  CC      kernel/irq/chip.o
  CC      security/keys/proc.o
  CC      fs/drop_caches.o
  CC      kernel/power/main.o
  CC      arch/x86/kernel/tls.o
  CC      crypto/scatterwalk.o
  CC [M]  arch/x86/kvm/irq.o
  CC      security/keys/sysctl.o
  CC      fs/splice.o
  CC      arch/x86/kernel/step.o
  CC      kernel/irq/dummychip.o
  LD      security/keys/built-in.o
  GEN     security/selinux/flask.h security/selinux/av_permissions.h
  CC      security/selinux/avc.o
  CC      kernel/power/console.o
  CC      mm/mprotect.o
  CC      arch/x86/kernel/i8237.o
  CC      kernel/irq/devres.o
  CC      crypto/proc.o
  CC [M]  arch/x86/kvm/lapic.o
  CC      arch/x86/kernel/stacktrace.o
  CC      kernel/power/process.o
  CC      kernel/irq/autoprobe.o
  CC      crypto/ablkcipher.o
  CC      mm/mremap.o
  CC      arch/x86/kernel/acpi/boot.o
  CC      security/selinux/hooks.o
  CC      fs/sync.o
  CC      kernel/power/suspend.o
  CC      kernel/irq/irqdomain.o
  CC      mm/msync.o
  CC      fs/utimes.o
  CC      kernel/power/hibernate.o
  CC [M]  arch/x86/kvm/i8254.o
  CC      kernel/irq/proc.o
  CC      crypto/blkcipher.o
  CC      arch/x86/kernel/acpi/sleep.o
  CC      mm/rmap.o
  CC      fs/stack.o
  CC      kernel/irq/migration.o
  CC [M]  arch/x86/kvm/cpuid.o
  CC      kernel/power/snapshot.o
  CC      crypto/ahash.o
  CC      kernel/irq/pm.o
  AS      arch/x86/kernel/acpi/wakeup_64.o
  CC      fs/fs_struct.o
  CC      arch/x86/kernel/acpi/cstate.o
  LD      kernel/irq/built-in.o
  CC      arch/x86/kernel/apic/apic.o
  CC      fs/statfs.o
  CC      mm/vmalloc.o
  CC      security/selinux/selinuxfs.o
  CC [M]  arch/x86/kvm/pmu.o
  CC      kernel/power/swap.o
  CC      crypto/shash.o
  LD      arch/x86/kernel/acpi/built-in.o
  CC      kernel/power/user.o
  CC      fs/buffer.o
  CC      fs/bio.o
  LD [M]  arch/x86/kvm/kvm.o
  LD [M]  arch/x86/kvm/kvm-intel.o
  LD [M]  arch/x86/kvm/kvm-amd.o
  CC      security/commoncap.o
  CC      security/selinux/netlink.o
  CC      crypto/algboss.o
  CC      kernel/power/block_io.o
  CC      arch/x86/kernel/apic/apic_noop.o
  CC      security/selinux/nlmsgtab.o
  CC      arch/x86/kernel/apic/ipi.o
  CC      security/selinux/netif.o
  CC      mm/pagewalk.o
  CC      kernel/power/poweroff.o
  CC      crypto/testmgr.o
  LD      kernel/power/built-in.o
  CC      kernel/sched/core.o
  CC      arch/x86/kernel/apic/hw_nmi.o
  CC      kernel/sched/clock.o
  CC      mm/pgtable-generic.o
  CC      kernel/sched/cputime.o
  CC      security/selinux/netnode.o
  CC      crypto/crypto_wq.o
  CC      arch/x86/kernel/apic/io_apic.o
  CC      mm/process_vm_access.o
  CC      mm/init-mm.o
  CC      mm/nobootmem.o
  LD      crypto/crypto_algapi.o
  CC      crypto/aead.o
  CC      security/selinux/netport.o
  CC      block/elevator.o
  CC      block/blk-core.o
  CC      fs/block_dev.o
  CC      mm/memblock.o
  CC      security/selinux/exports.o
  CC      mm/bounce.o
  LD      crypto/crypto_blkcipher.o
  CC      crypto/chainiv.o
  CC      security/selinux/ss/ebitmap.o
  CC      crypto/eseqiv.o
  CC      security/min_addr.o
  CC      arch/x86/kernel/apic/apic_flat_64.o
  CC      fs/direct-io.o
  LD      crypto/crypto_hash.o
  CC      mm/page_io.o
  CC      crypto/pcompress.o
  LD      crypto/cryptomgr.o
  CC      kernel/sched/idle_task.o
  CC      security/selinux/ss/hashtab.o
  CC      arch/x86/kernel/cpu/intel_cacheinfo.o
  CC      security/selinux/ss/symtab.o
  CC      arch/x86/kernel/apic/probe_64.o
  CC      security/selinux/ss/sidtab.o
  CC      mm/swap_state.o
  CC      crypto/hmac.o
  LD      arch/x86/kernel/apic/built-in.o
  CC      arch/x86/kernel/kprobes/core.o
  CC      block/blk-tag.o
  CC      fs/mpage.o
  CC      mm/swapfile.o
  CC      arch/x86/kernel/cpu/scattered.o
  CC      security/selinux/ss/avtab.o
  CC      kernel/sched/fair.o
  CC      crypto/md5.o
  CC      arch/x86/kernel/cpu/topology.o
  CC      block/blk-sysfs.o
  CC      fs/ioprio.o
  CC      arch/x86/kernel/kprobes/opt.o
  CC      arch/x86/kernel/cpu/proc.o
  CC      security/selinux/ss/policydb.o
  CC      crypto/sha1_generic.o
  CC      block/blk-flush.o
  MKCAP   arch/x86/kernel/cpu/capflags.c
  CC      arch/x86/kernel/kprobes/ftrace.o
  CC      fs/proc_namespace.o
  CC      arch/x86/kernel/cpu/powerflags.o
  CC      arch/x86/kernel/cpu/common.o
  CC      mm/dmapool.o
  LD      arch/x86/kernel/kprobes/built-in.o
  CC      mm/hugetlb.o
  CC      fs/bio-integrity.o
  CC      crypto/aes_generic.o
  CC      block/blk-settings.o
  CC      crypto/crc32c.o
  CC      kernel/sched/rt.o
  CC      kernel/sched/stop_task.o
  CC      arch/x86/kernel/cpu/vmware.o
  CC      security/selinux/ss/services.o
  LD      fs/autofs4/built-in.o
  CC [M]  fs/autofs4/init.o
  CC      security/selinux/ss/conditional.o
  CC      crypto/rng.o
  CC      arch/x86/kernel/cpu/hypervisor.o
  CC      block/blk-ioc.o
  CC [M]  fs/autofs4/inode.o
  CC      kernel/sched/cpupri.o
  CC      arch/x86/kernel/cpu/mshyperv.o
  CC      kernel/sched/auto_group.o
  CC      crypto/krng.o
  CC      mm/mempolicy.o
  CC [M]  fs/autofs4/root.o
  CC [M]  fs/autofs4/symlink.o
  CC      arch/x86/kernel/cpu/rdrand.o
  CC      block/blk-map.o
  CC      arch/x86/kernel/cpu/match.o
  CC [M]  crypto/seqiv.o
  CC [M]  crypto/vmac.o
  CC      kernel/sched/stats.o
  CC      arch/x86/kernel/cpu/bugs_64.o
  CC      security/selinux/ss/mls.o
  CC [M]  fs/autofs4/waitq.o
  CC [M]  fs/autofs4/expire.o
  CC      block/blk-exec.o
  CC      kernel/sched/debug.o
  CC      arch/x86/kernel/cpu/intel.o
  CC      block/blk-merge.o
  CC [M]  crypto/xcbc.o
  CC [M]  fs/autofs4/dev-ioctl.o
  CC      arch/x86/kernel/cpu/amd.o
  CC      block/blk-softirq.o
  CC      security/selinux/ss/status.o
  CC      mm/sparse.o
  LD      kernel/sched/built-in.o
  CC [M]  crypto/crypto_null.o
  CC      kernel/time/timekeeping.o
  LD [M]  fs/autofs4/autofs4.o
  LD      fs/btrfs/built-in.o
  CC [M]  fs/btrfs/super.o
  LD      fs/cachefiles/built-in.o
  CC [M]  fs/cachefiles/bind.o
  CC      arch/x86/kernel/cpu/centaur.o
  CC      security/selinux/xfrm.o
  CC [M]  crypto/md4.o
  CC      block/blk-timeout.o
  CC      mm/sparse-vmemmap.o
  CC      arch/x86/kernel/cpu/perf_event.o
  CC [M]  fs/cachefiles/daemon.o
  CC [M]  crypto/rmd128.o
  CC      kernel/time/ntp.o
  CC      block/blk-iopoll.o
  CC      mm/mmu_notifier.o
  CC [M]  fs/cachefiles/interface.o
  CC      mm/ksm.o
  CC      kernel/time/clocksource.o
  CC      arch/x86/kernel/cpu/perf_event_amd.o
  CC [M]  crypto/rmd160.o
  CC      block/blk-lib.o
  CC [M]  fs/cachefiles/key.o
  CC      mm/slab.o
  CC      security/selinux/netlabel.o
  CC [M]  fs/cachefiles/main.o
  CC      kernel/time/jiffies.o
  CC      arch/x86/kernel/cpu/perf_event_p6.o
  CC [M]  crypto/rmd256.o
  CC      block/ioctl.o
  CC [M]  fs/cachefiles/namei.o
  LD      security/selinux/selinux.o
  LD      security/selinux/built-in.o
  CC      kernel/time/timer_list.o
  CC      security/security.o
  CC      arch/x86/kernel/cpu/perf_event_knc.o
  CC [M]  crypto/rmd320.o
  CC      kernel/time/timeconv.o
  CC [M]  fs/btrfs/ctree.o
  CC [M]  fs/cachefiles/rdwr.o
  CC      block/genhd.o
  CC      arch/x86/kernel/cpu/perf_event_p4.o
  CC      kernel/time/posix-clock.o
  CC [M]  crypto/sha256_generic.o
  CC      security/capability.o
  CC      arch/x86/kernel/cpu/perf_event_intel_lbr.o
  CC [M]  fs/cachefiles/security.o
  CC      mm/memory_hotplug.o
  CC      kernel/time/alarmtimer.o
  CC [M]  fs/cachefiles/xattr.o
  CC      arch/x86/kernel/cpu/perf_event_intel_ds.o
  CC      block/scsi_ioctl.o
mm/memory_hotplug.c:167: warning: ‘register_page_bootmem_info_section’ defined but not used
  CC [M]  crypto/sha512_generic.o
  CC      kernel/time/clockevents.o
  CC      security/inode.o
  LD [M]  fs/cachefiles/cachefiles.o
  CC      kernel/time/tick-common.o
  CC      mm/filemap_xip.o
  CC      arch/x86/kernel/cpu/perf_event_intel.o
  CC [M]  crypto/wp512.o
  CC [M]  crypto/tgr192.o
  CC      kernel/time/tick-broadcast.o
  CC      block/partition-generic.o
  CC      security/lsm_audit.o
  CC      mm/migrate.o
  CC      block/partitions/check.o
  CC      kernel/time/tick-oneshot.o
  CC [M]  crypto/gf128mul.o
  CC      kernel/time/tick-sched.o
  CC      security/device_cgroup.o
  CC [M]  fs/btrfs/extent-tree.o
  CC      arch/x86/kernel/cpu/perf_event_intel_uncore.o
  CC      block/partitions/amiga.o
  CC      kernel/time/timer_stats.o
  CC [M]  crypto/ecb.o
  LD      security/built-in.o
  CC [M]  crypto/cbc.o
  CC      block/partitions/mac.o
  CC      block/partitions/msdos.o
  LD      kernel/time/built-in.o
  CC [M]  crypto/pcbc.o
  CC      kernel/trace/trace_clock.o
  CC      mm/huge_memory.o
  CC      mm/memory-failure.o
  CC [M]  crypto/cts.o
  CC      block/partitions/osf.o
  CC      kernel/trace/ftrace.o
  CC      arch/x86/kernel/cpu/mcheck/mce.o
  CC      arch/x86/kernel/cpu/mcheck/mce-severity.o
  CC [M]  crypto/lrw.o
  CC      block/partitions/sgi.o
  CC      block/partitions/sun.o
  CC      block/partitions/efi.o
  CC      arch/x86/kernel/cpu/mtrr/main.o
  CC [M]  crypto/xts.o
  CC      arch/x86/kernel/cpu/perfctr-watchdog.o
  CC      mm/page_isolation.o
  CC      block/partitions/karma.o
  CC [M]  mm/hwpoison-inject.o
  CC      arch/x86/kernel/cpu/mtrr/if.o
  CC      arch/x86/kernel/cpu/mcheck/mce_intel.o
  CC      arch/x86/kernel/cpu/mcheck/mce_amd.o
  CC [M]  crypto/ctr.o
  LD      block/partitions/built-in.o
  CC      block/bsg.o
  LD      mm/built-in.o
  CC      arch/x86/kernel/cpu/mtrr/generic.o
  CC      drivers/acpi/tables.o
  CC      kernel/trace/ring_buffer.o
  CC [M]  fs/btrfs/print-tree.o
  CC      arch/x86/kernel/cpu/mcheck/threshold.o
  CC [M]  fs/btrfs/root-tree.o
  CC [M]  crypto/gcm.o
  CC      arch/x86/kernel/cpu/mcheck/therm_throt.o
  CC      drivers/acpi/blacklist.o
  CC      arch/x86/kernel/cpu/mcheck/mce-apei.o
  CC      drivers/acpi/osl.o
  CC      arch/x86/kernel/cpu/mtrr/cleanup.o
  CC [M]  fs/btrfs/dir-item.o
  CC [M]  fs/btrfs/file-item.o
  CC      block/bsg-lib.o
  CC [M]  crypto/ccm.o
  CC [M]  arch/x86/kernel/cpu/mcheck/mce-inject.o
  LD      arch/x86/kernel/cpu/mtrr/built-in.o
  CC [M]  crypto/cryptd.o
  CC [M]  crypto/des_generic.o
  CC      block/blk-cgroup.o
  LD      arch/x86/kernel/cpu/mcheck/built-in.o
  CC      drivers/acpi/utils.o
  CC      arch/x86/kernel/cpu/perf_event_amd_ibs.o
  CC      kernel/trace/trace.o
  CC [M]  fs/btrfs/inode-item.o
  CC      kernel/trace/trace_output.o
  CC      drivers/acpi/reboot.o
  CC      kernel/trace/trace_stat.o
  CC [M]  crypto/fcrypt.o
  CC [M]  fs/btrfs/inode-map.o
  CC      block/blk-throttle.o
  CC      arch/x86/kernel/cpu/capflags.o
  LD      arch/x86/kernel/cpu/built-in.o
  CC      drivers/acpi/nvs.o
  CC      arch/x86/kernel/reboot.o
  CC [M]  crypto/blowfish_generic.o
  CC [M]  crypto/blowfish_common.o
  LD      fs/cifs/built-in.o
  CC [M]  fs/cifs/cifsfs.o
  CC      drivers/acpi/wakeup.o
  CC [M]  fs/btrfs/disk-io.o
  CC [M]  fs/btrfs/transaction.o
  CC [M]  crypto/twofish_common.o
  CC      block/noop-iosched.o
  CC      arch/x86/kernel/msr.o
  CC      kernel/trace/trace_printk.o
  CC      drivers/acpi/sleep.o
  CC      arch/x86/kernel/cpuid.o
  CC      block/deadline-iosched.o
  CC [M]  crypto/serpent_generic.o
  CC      arch/x86/kernel/early-quirks.o
  CC      drivers/acpi/device_pm.o
  CC      kernel/trace/trace_sched_switch.o
  CC [M]  fs/btrfs/inode.o
  CC      block/cfq-iosched.o
  CC      arch/x86/kernel/smp.o
  CC      block/compat_ioctl.o
  CC      kernel/trace/trace_functions.o
  CC      drivers/acpi/proc.o
  CC      drivers/acpi/bus.o
  CC      kernel/trace/trace_sched_wakeup.o
  CC      arch/x86/kernel/smpboot.o
  CC      arch/x86/kernel/tsc_sync.o
  CC      kernel/trace/trace_nop.o
  CC [M]  fs/cifs/cifssmb.o
  CC      drivers/acpi/glue.o
  CC      block/blk-integrity.o
  CC      arch/x86/kernel/setup_percpu.o
  CC      arch/x86/kernel/mpparse.o
  CC      kernel/trace/trace_stack.o
  CC [M]  crypto/camellia_generic.o
  CC      drivers/acpi/scan.o
  CC [M]  fs/btrfs/file.o
  LD      block/built-in.o
  CC      kernel/trace/trace_functions_graph.o
  CC      kernel/trace/blktrace.o
  CC [M]  crypto/cast_common.o
  CC      arch/x86/kernel/ftrace.o
  CC      arch/x86/kernel/trace_clock.o
  CC [M]  crypto/cast5_generic.o
  CC      kernel/trace/trace_events.o
  CC      drivers/acpi/resource.o
  CC [M]  fs/cifs/cifs_debug.o
  CC      arch/x86/kernel/machine_kexec_64.o
  CC [M]  crypto/cast6_generic.o
  CC      drivers/acpi/processor_core.o
  CC [M]  crypto/arc4.o
  CC [M]  fs/btrfs/tree-defrag.o
  AS      arch/x86/kernel/relocate_kernel_64.o
  CC      kernel/trace/trace_export.o
  CC      arch/x86/kernel/crash.o
  CC      arch/x86/kernel/crash_dump_64.o
  CC      drivers/acpi/ec.o
  CC      arch/x86/kernel/module.o
  CC      kernel/trace/trace_syscalls.o
  CC [M]  fs/cifs/connect.o
  CC [M]  fs/btrfs/extent_map.o
  CC [M]  fs/cifs/dir.o
  CC      arch/x86/kernel/kgdb.o
  CC [M]  crypto/tea.o
  CC [M]  crypto/khazad.o
  CC [M]  fs/btrfs/sysfs.o
  CC      kernel/trace/trace_event_perf.o
  CC      arch/x86/kernel/early_printk.o
  CC      drivers/acpi/dock.o
  CC [M]  fs/cifs/file.o
  CC [M]  fs/cifs/inode.o
  CC [M]  crypto/anubis.o
  CC      arch/x86/kernel/hpet.o
  CC [M]  fs/btrfs/struct-funcs.o
  CC      kernel/trace/trace_events_filter.o
  CC [M]  crypto/seed.o
  CC      drivers/acpi/pci_root.o
  CC [M]  fs/btrfs/xattr.o
  CC      arch/x86/kernel/amd_nb.o
  CC      arch/x86/kernel/test_rodata.o
  CC [M]  crypto/deflate.o
  CC [M]  crypto/zlib.o
  CC      drivers/acpi/pci_link.o
  CC      drivers/acpi/pci_irq.o
  CC [M]  fs/btrfs/ordered-data.o
  CC [M]  fs/btrfs/extent_io.o
  CC      arch/x86/kernel/kvm.o
  CC      kernel/trace/trace_kprobe.o
  CC [M]  fs/cifs/link.o
  CC [M]  crypto/michael_mic.o
  CC [M]  crypto/authenc.o
  CC      drivers/acpi/csrt.o
arch/x86/kernel/kvm.c: In function ‘kvm_register_steal_time’:
arch/x86/kernel/kvm.c:302: warning: format ‘%lx’ expects type ‘long unsigned int’, but argument 3 has type ‘phys_addr_t’
  CC      drivers/acpi/acpi_platform.o
  CC [M]  fs/btrfs/volumes.o
  CC      arch/x86/kernel/kvmclock.o
  CC      kernel/trace/power-traces.o
  CC      kernel/trace/rpm-traces.o
  CC [M]  fs/cifs/misc.o
  CC      drivers/acpi/power.o
  CC [M]  crypto/authencesn.o
  CC      arch/x86/kernel/paravirt.o
  CC      drivers/acpi/event.o
  CC      drivers/acpi/sysfs.o
  CC      kernel/trace/trace_probe.o
  CC [M]  fs/cifs/netmisc.o
  CC [M]  crypto/lzo.o
  CC      arch/x86/kernel/paravirt_patch_64.o
  CC      arch/x86/kernel/pvclock.o
  CC [M]  crypto/ansi_cprng.o
  CC [M]  fs/btrfs/async-thread.o
  CC      drivers/acpi/debugfs.o
  CC      arch/x86/kernel/pcspeaker.o
  CC [M]  kernel/trace/ring_buffer_benchmark.o
  LD      sound/built-in.o
  CC [M]  sound/sound_core.o
  CC [M]  fs/cifs/smbencrypt.o
  CC      arch/x86/kernel/microcode_core_early.o
  CC [M]  crypto/tcrypt.o
  CC [M]  fs/btrfs/ioctl.o
  CC      arch/x86/kernel/microcode_intel_early.o
  CC      drivers/acpi/numa.o
  LD      kernel/trace/libftrace.o
  LD      kernel/trace/built-in.o
  CC      kernel/freezer.o
  CC [M]  sound/ac97_bus.o
  CC [M]  fs/cifs/transport.o
  CC [M]  fs/cifs/asn1.o
  CC      drivers/acpi/cm_sbs.o
  CC      arch/x86/kernel/microcode_intel_lib.o
  LD      sound/arm/built-in.o
  LD      sound/atmel/built-in.o
  LD      sound/core/oss/built-in.o
  LD      sound/core/seq/built-in.o
  CC [M]  sound/core/seq/seq_device.o
  CC      kernel/profile.o
  CC [M]  crypto/ghash-generic.o
  CC      drivers/acpi/video_detect.o
  CC      arch/x86/kernel/pci-swiotlb.o
  CC      arch/x86/kernel/perf_regs.o
  CC [M]  fs/cifs/cifs_unicode.o
  CC [M]  crypto/xor.o
  CC      drivers/acpi/processor_driver.o
  CC      kernel/stacktrace.o
  CC [M]  fs/btrfs/locking.o
  CC [M]  fs/btrfs/orphan.o
  CC      arch/x86/kernel/audit_64.o
  CC      arch/x86/kernel/amd_gart_64.o
  CC      kernel/futex.o
  CC [M]  sound/core/seq/seq_dummy.o
  CC [M]  fs/cifs/nterr.o
  CC [M]  sound/core/seq/seq_midi_emul.o
  CC [M]  fs/btrfs/export.o
  LD      crypto/async_tx/built-in.o
  CC [M]  crypto/async_tx/async_tx.o
  CC      drivers/acpi/processor_throttling.o
  CC [M]  fs/cifs/xattr.o
  CC [M]  crypto/async_tx/async_memcpy.o
  CC [M]  sound/core/seq/seq_midi_event.o
  CC [M]  fs/btrfs/tree-log.o
  CC [M]  sound/core/seq/seq_midi.o
  CC      arch/x86/kernel/aperture_64.o
  CC      drivers/acpi/processor_idle.o
  CC [M]  fs/cifs/cifsencrypt.o
  CC [M]  crypto/async_tx/async_xor.o
  CC [M]  crypto/async_tx/async_pq.o
  CC      kernel/futex_compat.o
  CC [M]  sound/core/seq/seq_virmidi.o
  CC      arch/x86/kernel/pci-calgary_64.o
  CC      drivers/acpi/processor_thermal.o
  CC      drivers/acpi/processor_perflib.o
  CC      kernel/rtmutex.o
  CC [M]  sound/core/seq/seq.o
  CC [M]  fs/cifs/readdir.o
  CC [M]  fs/cifs/ioctl.o
  CC [M]  crypto/async_tx/async_raid6_recov.o
  CC [M]  sound/core/seq/seq_lock.o
  CC      arch/x86/kernel/tce_64.o
  CC      kernel/dma.o
  CC      drivers/acpi/acpica/dsargs.o
  CC      drivers/acpi/apei/apei-base.o
  CC [M]  sound/core/seq/seq_clientmgr.o
  CC [M]  fs/btrfs/free-space-cache.o
  CC      arch/x86/kernel/mmconf-fam10h_64.o
  CC      kernel/smp.o
  CC      drivers/acpi/acpica/dscontrol.o
  CC [M]  fs/cifs/sess.o
  LD      crypto/crypto.o
  LD      crypto/built-in.o
  CC      kernel/spinlock.o
  CC      arch/x86/kernel/vsmp_64.o
  CC      drivers/acpi/acpica/dsfield.o
  CC [M]  sound/core/seq/seq_memory.o
  CC      kernel/uid16.o
  AS      arch/x86/kernel/head_64.o
  CC      drivers/acpi/apei/hest.o
  CC      arch/x86/kernel/head64.o
  CC      drivers/acpi/acpica/dsinit.o
  CC [M]  fs/cifs/export.o
  CC      drivers/acpi/acpica/dsmethod.o
  CC      arch/x86/kernel/head.o
  CC      kernel/module.o
  LDS     arch/x86/kernel/vmlinux.lds
  CC [M]  sound/core/seq/seq_queue.o
  CC [M]  sound/core/seq/seq_fifo.o
  CC      drivers/acpi/apei/cper.o
  CC [M]  arch/x86/kernel/test_nx.o
  CC      drivers/acpi/acpica/dsmthdat.o
  CC [M]  fs/btrfs/zlib.o
  CC [M]  fs/cifs/smb1ops.o
  CC [M]  arch/x86/kernel/microcode_core.o
  CC [M]  arch/x86/kernel/microcode_intel.o
  CC      drivers/acpi/acpica/dsobject.o
  CC [M]  sound/core/seq/seq_prioq.o
  CC [M]  sound/core/seq/seq_timer.o
  CC [M]  fs/btrfs/lzo.o
  CC      drivers/acpi/apei/erst.o
  CC      drivers/acpi/acpica/dsopcode.o
  CC      drivers/acpi/acpica/dsutils.o
  CC [M]  arch/x86/kernel/microcode_amd.o
  CC [M]  fs/cifs/cifs_spnego.o
  CC [M]  sound/core/seq/seq_system.o
  CC [M]  fs/btrfs/compression.o
  CC      drivers/acpi/acpica/dswexec.o
  LD      arch/x86/kernel/built-in.o
  CC [M]  drivers/acpi/apei/einj.o
  LD [M]  arch/x86/kernel/microcode.o
  CC [M]  fs/btrfs/delayed-ref.o
  CC [M]  sound/core/seq/seq_ports.o
  CC      arch/x86/vdso/vma.o
  CC      drivers/acpi/acpica/dswload.o
  CC      kernel/kallsyms.o
  CC [M]  fs/cifs/dns_resolve.o
  LDS     arch/x86/vdso/vdso.lds
  CC [M]  drivers/acpi/apei/erst-dbg.o
  CC      drivers/acpi/acpica/dswload2.o
  CC [M]  fs/btrfs/relocation.o
  CC [M]  sound/core/seq/seq_info.o
  CC [M]  fs/btrfs/delayed-inode.o
  CC      kernel/acct.o
  AS      arch/x86/vdso/vdso-note.o
  CC      arch/x86/vdso/vclock_gettime.o
  CC      drivers/acpi/acpica/dswscope.o
  LD      sound/core/seq/oss/built-in.o
  LD      drivers/acpi/apei/apei.o
  CC [M]  sound/core/seq/oss/seq_oss.o
  CC [M]  fs/cifs/cifs_dfs_ref.o
  LD      drivers/acpi/apei/built-in.o
  CC [M]  sound/core/seq/oss/seq_oss_init.o
  CC      arch/x86/vdso/vgetcpu.o
  CC      drivers/acpi/acpica/dswstate.o
  LDS     arch/x86/vdso/vdso32/vdso32.lds
  CC      kernel/kexec.o
  AS      arch/x86/vdso/vdso32/note.o
  AS      arch/x86/vdso/vdso32/int80.o
  AS      arch/x86/vdso/vdso32/syscall.o
  AS      arch/x86/vdso/vdso32/sysenter.o
  CC      drivers/acpi/ac.o
  CC      arch/x86/vdso/vdso32-setup.o
  CC [M]  sound/core/seq/oss/seq_oss_timer.o
  CC      drivers/acpi/acpica/evevent.o
  LD [M]  fs/cifs/cifs.o
  CC      drivers/acpi/acpica/evgpe.o
  CC      drivers/acpi/acpica/evgpeblk.o
  CC [M]  sound/core/seq/oss/seq_oss_ioctl.o
  CC [M]  sound/core/hrtimer.o
  CC [M]  sound/core/hwdep.o
  VDSO    arch/x86/vdso/vdso.so.dbg
  VDSO    arch/x86/vdso/vdso32-int80.so.dbg
  CC      drivers/acpi/acpica/evgpeinit.o
  CC      arch/x86/xen/enlighten.o
  VDSO    arch/x86/vdso/vdso32-syscall.so.dbg
  CC      kernel/compat.o
  LD      sound/drivers/built-in.o
  CC [M]  sound/drivers/aloop.o
  CC [M]  sound/core/seq/oss/seq_oss_event.o
  VDSO    arch/x86/vdso/vdso32-sysenter.so.dbg
  VDSOSYM arch/x86/vdso/vdso-syms.lds
  VDSOSYM arch/x86/vdso/vdso32-int80-syms.lds
  VDSOSYM arch/x86/vdso/vdso32-syscall-syms.lds
  VDSOSYM arch/x86/vdso/vdso32-sysenter-syms.lds
  OBJCOPY arch/x86/vdso/vdso.so
  OBJCOPY arch/x86/vdso/vdso32-int80.so
  OBJCOPY arch/x86/vdso/vdso32-syscall.so
  OBJCOPY arch/x86/vdso/vdso32-sysenter.so
  VDSOSYM arch/x86/vdso/vdso32-syms.lds
  AS      arch/x86/vdso/vdso.o
  AS      arch/x86/vdso/vdso32.o
  LD      arch/x86/vdso/built-in.o
  CC [M]  sound/drivers/dummy.o
  CC      drivers/acpi/acpica/evgpeutil.o
  CC [M]  sound/core/seq/oss/seq_oss_rw.o
  CC [M]  sound/core/seq/oss/seq_oss_synth.o
  CC      drivers/acpi/acpica/evglock.o
  CC [M]  fs/btrfs/scrub.o
  CC      drivers/acpi/acpica/evhandler.o
  CC      drivers/acpi/acpica/evmisc.o
  CC [M]  sound/drivers/mtpav.o
  CC [M]  sound/drivers/virmidi.o
  CC [M]  sound/core/seq/oss/seq_oss_midi.o
  CC [M]  sound/core/seq/oss/seq_oss_readq.o
  CC      drivers/acpi/acpica/evregion.o
  CC [M]  sound/core/seq/oss/seq_oss_writeq.o
  CC      kernel/cgroup.o
  LD      sound/drivers/mpu401/built-in.o
  CC [M]  sound/drivers/mpu401/mpu401_uart.o
  CC      arch/x86/xen/setup.o
  CC [M]  sound/drivers/mpu401/mpu401.o
  CC      drivers/acpi/acpica/evrgnini.o
  CC      drivers/acpi/acpica/evsci.o
  LD [M]  sound/core/seq/oss/snd-seq-oss.o
  LD [M]  sound/core/seq/snd-seq.o
  LD [M]  sound/core/seq/snd-seq-device.o
  LD [M]  sound/core/seq/snd-seq-midi-event.o
  LD [M]  sound/core/seq/snd-seq-dummy.o
  LD [M]  sound/core/seq/snd-seq-virmidi.o
  LD [M]  sound/core/seq/snd-seq-midi.o
  LD [M]  sound/core/seq/snd-seq-midi-emul.o
  CC [M]  sound/core/memalloc.o
  CC [M]  sound/core/sgbuf.o
  CC      drivers/acpi/acpica/evxface.o
  CC [M]  sound/core/pcm.o
  LD [M]  sound/drivers/mpu401/snd-mpu401-uart.o
  CC      arch/x86/xen/multicalls.o
  LD [M]  sound/drivers/mpu401/snd-mpu401.o
  LD      sound/drivers/opl3/built-in.o
  LD      sound/drivers/opl4/built-in.o
  LD      sound/drivers/pcsp/built-in.o
  CC [M]  sound/drivers/pcsp/pcsp.o
  CC [M]  sound/drivers/pcsp/pcsp_lib.o
  CC [M]  fs/btrfs/reada.o
  CC      arch/x86/xen/mmu.o
  CC      drivers/acpi/acpica/evxfevnt.o
  CC      drivers/acpi/acpica/evxfgpe.o
  LD      fs/configfs/built-in.o
  CC [M]  fs/configfs/inode.o
  CC [M]  sound/drivers/pcsp/pcsp_mixer.o
  CC [M]  sound/core/pcm_native.o
  CC [M]  sound/core/pcm_lib.o
  CC [M]  fs/configfs/file.o
  CC      drivers/acpi/acpica/evxfregn.o
  CC [M]  sound/drivers/pcsp/pcsp_input.o
  CC [M]  fs/btrfs/backref.o
  LD [M]  sound/drivers/pcsp/snd-pcsp.o
  CC [M]  fs/configfs/dir.o
  LD      sound/drivers/vx/built-in.o
  CC [M]  sound/drivers/vx/vx_core.o
  CC      drivers/acpi/acpica/exconfig.o
  CC      kernel/cgroup_freezer.o
  CC      drivers/acpi/acpica/exconvrt.o
  CC [M]  fs/configfs/symlink.o
  CC      drivers/acpi/acpica/excreate.o
  CC      kernel/cpuset.o
  CC [M]  sound/drivers/vx/vx_hwdep.o
  CC      kernel/utsname.o
  CC [M]  fs/btrfs/ulist.o
  CC      arch/x86/xen/irq.o
  CC [M]  sound/core/pcm_timer.o
  CC      drivers/acpi/acpica/exdebug.o
  CC [M]  fs/configfs/mount.o
  CC [M]  sound/drivers/vx/vx_pcm.o
  CC [M]  sound/drivers/vx/vx_mixer.o
  CC [M]  fs/btrfs/qgroup.o
  CC      arch/x86/xen/time.o
  CC      drivers/acpi/acpica/exdump.o
  CC [M]  sound/core/pcm_misc.o
  CC [M]  fs/configfs/item.o
  CC      drivers/acpi/acpica/exfield.o
  CC      kernel/pid_namespace.o
  AS      arch/x86/xen/xen-asm.o
  CC [M]  sound/core/pcm_memory.o
  AS      arch/x86/xen/xen-asm_64.o
  CC      kernel/res_counter.o
  LD [M]  fs/configfs/configfs.o
  LD      drivers/amba/built-in.o
  CC [M]  sound/drivers/vx/vx_cmd.o
  CC      arch/x86/xen/grant-table.o
  CC      drivers/acpi/acpica/exfldio.o
  CC [M]  fs/btrfs/send.o
  CC [M]  fs/btrfs/dev-replace.o
  CC [M]  sound/core/rawmidi.o
  CC [M]  sound/core/timer.o
  CC      arch/x86/xen/suspend.o
  CC      kernel/stop_machine.o
  CC [M]  sound/drivers/vx/vx_uer.o
  CC      drivers/acpi/acpica/exmutex.o
  CC      arch/x86/xen/platform-pci-unplug.o
  CC      drivers/acpi/acpica/exnames.o
  CC [M]  sound/core/sound.o
  LD [M]  sound/drivers/vx/snd-vx-lib.o
  LD [M]  sound/drivers/snd-dummy.o
  LD [M]  sound/drivers/snd-aloop.o
  LD [M]  sound/drivers/snd-virmidi.o
  LD [M]  sound/drivers/snd-mtpav.o
  CC      arch/x86/xen/p2m.o
  CC [M]  sound/core/init.o
  CC      kernel/audit.o
  CC      drivers/acpi/acpica/exoparg1.o
  CC      kernel/auditfilter.o
  CC      kernel/auditsc.o
  CC      kernel/audit_watch.o
  CC      drivers/acpi/acpica/exoparg2.o
  CC [M]  sound/core/memory.o
  CC [M]  fs/btrfs/acl.o
  CC      drivers/acpi/acpica/exoparg3.o
  CC      arch/x86/xen/trace.o
  CC      drivers/acpi/acpica/exoparg6.o
  CC [M]  sound/core/info.o
  CC      drivers/ata/libata-core.o
  CC      kernel/audit_tree.o
  CC      drivers/acpi/acpica/exprep.o
  LD      firmware/built-in.o
  LD      sound/firewire/built-in.o
  CC      drivers/acpi/button.o
  LD [M]  fs/btrfs/btrfs.o
  LD      fs/cramfs/built-in.o
  CC [M]  fs/cramfs/inode.o
  CC      drivers/acpi/acpica/exmisc.o
  CC      drivers/acpi/acpica/exregion.o
  CC [M]  sound/core/control.o
  CC      kernel/kprobes.o
  CC [M]  sound/core/misc.o
  CC      drivers/acpi/acpica/exresnte.o
  CC      arch/x86/xen/smp.o
  CC [M]  fs/cramfs/uncompress.o
  LD [M]  fs/cramfs/cramfs.o
  CC      drivers/acpi/acpica/exresolv.o
  CC      fs/debugfs/inode.o
  CC      fs/debugfs/file.o
  CC      drivers/acpi/acpica/exresop.o
  LD      sound/i2c/built-in.o
  CC      arch/x86/xen/debugfs.o
  CC [M]  sound/i2c/cs8427.o
  CC      drivers/acpi/acpica/exstore.o
  CC      arch/x86/xen/apic.o
  CC      arch/x86/xen/vga.o
  CC [M]  sound/core/device.o
  LD      fs/debugfs/debugfs.o
  LD      fs/debugfs/built-in.o
  CC      fs/devpts/inode.o
  CC      kernel/hung_task.o
  CC      arch/x86/xen/pci-swiotlb-xen.o
  CC      drivers/acpi/acpica/exstoren.o
  CC      drivers/acpi/acpica/exstorob.o
  CC [M]  sound/i2c/i2c.o
  CC [M]  sound/core/isadma.o
  CC      kernel/watchdog.o
  CC      drivers/ata/libata-scsi.o
  LD      fs/devpts/devpts.o
  LD      fs/devpts/built-in.o
  LD      fs/dlm/built-in.o
  CC [M]  fs/dlm/ast.o
  CC [M]  fs/dlm/config.o
  CC      drivers/acpi/acpica/exsystem.o
  CC [M]  sound/core/sound_oss.o
  LD      sound/i2c/other/built-in.o
  CC [M]  sound/i2c/other/ak4113.o
  LD      arch/x86/xen/built-in.o
  LD      arch/x86/built-in.o
  CC      kernel/rcutree.o

WARNING: arch/x86/built-in.o(.text+0x34a15): Section mismatch in reference from the function acpi_unmap_lsapic() to the variable .cpuinit.data:__apicid_to_node The function acpi_unmap_lsapic() references
the variable __cpuinitdata __apicid_to_node.
This is often because acpi_unmap_lsapic lacks a __cpuinitdata
annotation or the annotation of __apicid_to_node is wrong.

  CC      kernel/relay.o
  CC      drivers/acpi/acpica/exutils.o
  CC      drivers/acpi/acpica/hwacpi.o
  CC [M]  sound/core/info_oss.o
  CC [M]  sound/core/vmaster.o
  CC      drivers/acpi/acpica/hwesleep.o
  CC [M]  sound/i2c/other/ak4114.o
  CC [M]  fs/dlm/dir.o
  CC [M]  fs/dlm/lock.o
  CC      drivers/acpi/acpica/hwgpe.o
  CC      drivers/acpi/acpica/hwpci.o
  CC [M]  sound/core/ctljack.o
  CC      drivers/acpi/acpica/hwregs.o
  CC [M]  sound/core/jack.o
  CC [M]  fs/dlm/lockspace.o
  CC [M]  sound/i2c/other/ak4xxx-adda.o
  CC      kernel/utsname_sysctl.o
  CC [M]  sound/i2c/other/pt2258.o
  CC      drivers/ata/libata-eh.o
  CC      drivers/acpi/acpica/hwsleep.o
  CC      kernel/delayacct.o
  LD      sound/core/built-in.o
  LD [M]  sound/core/snd.o
  LD [M]  sound/core/snd-hwdep.o
  LD [M]  sound/core/snd-timer.o
  LD [M]  sound/core/snd-hrtimer.o
  LD [M]  sound/core/snd-pcm.o
  LD [M]  sound/core/snd-page-alloc.o
  CC      kernel/taskstats.o
  LD [M]  sound/core/snd-rawmidi.o
  CC      kernel/tsacct.o
  CC      drivers/acpi/acpica/hwvalid.o
  CC [M]  fs/dlm/main.o
  LD [M]  sound/i2c/other/snd-ak4xxx-adda.o
  LD [M]  sound/i2c/other/snd-ak4114.o
  LD [M]  sound/i2c/other/snd-ak4113.o
  CC      drivers/acpi/acpica/hwxface.o
  LD [M]  sound/i2c/other/snd-pt2258.o
  CC      drivers/acpi/acpica/hwxfsleep.o
  LD [M]  sound/i2c/snd-cs8427.o
  CC      kernel/tracepoint.o
  LD [M]  sound/i2c/snd-i2c.o
  LD      sound/isa/built-in.o
  LD      sound/isa/ad1816a/built-in.o
  LD      sound/isa/ad1848/built-in.o
  LD      sound/isa/cs423x/built-in.o
  LD      sound/isa/es1688/built-in.o
  LD      sound/isa/galaxy/built-in.o
  LD      sound/isa/gus/built-in.o
  LD      sound/isa/msnd/built-in.o
  LD      sound/isa/opti9xx/built-in.o
  CC      drivers/acpi/acpica/nsaccess.o
  LD      sound/isa/sb/built-in.o
  CC [M]  sound/isa/sb/sb_common.o
  CC      drivers/acpi/acpica/nsalloc.o
  LD      sound/isa/wavefront/built-in.o
  LD      sound/isa/wss/built-in.o
  CC      kernel/elfcore.o
  CC      drivers/acpi/acpica/nsdump.o
  LD      drivers/atm/built-in.o
  CC [M]  drivers/atm/atmtcp.o
  LD      drivers/auxdisplay/built-in.o
  CC [M]  drivers/auxdisplay/ks0108.o
  CC      drivers/base/core.o
  CC      drivers/acpi/acpica/nseval.o
  CC      kernel/irq_work.o
  CC [M]  sound/isa/sb/sb_mixer.o
  CC [M]  fs/dlm/member.o
  CC [M]  drivers/auxdisplay/cfag12864b.o
  CC      drivers/acpi/acpica/nsinit.o
  CC      kernel/user-return-notifier.o
  CC      kernel/crash_dump.o
  CC      drivers/ata/libata-transport.o
  CC [M]  sound/isa/sb/sb16_main.o
  CC      drivers/acpi/acpica/nsload.o
  CC [M]  drivers/auxdisplay/cfag12864bfb.o
  CC      drivers/base/bus.o
  CC [M]  fs/dlm/memory.o
  CC      kernel/time.o
  CC      drivers/acpi/acpica/nsnames.o
  CC [M]  fs/dlm/midcomms.o
  CC      drivers/acpi/acpica/nsobject.o
  CC      drivers/ata/libata-sff.o
  CC      drivers/ata/libata-pmp.o
  CC      drivers/ata/libata-acpi.o
  LD [M]  sound/isa/sb/snd-sb-common.o
  LD [M]  sound/isa/sb/snd-sb16-dsp.o
  LD      sound/mips/built-in.o
  LD      sound/parisc/built-in.o
  LD      sound/pci/built-in.o
  CC [M]  sound/pci/ad1889.o
  CC      drivers/base/dd.o
  CC      drivers/acpi/acpica/nsparse.o
  LD      kernel/built-in.o
  CC [M]  fs/dlm/netlink.o
  CC      drivers/base/syscore.o
  CC      drivers/acpi/acpica/nspredef.o
  CC      drivers/base/driver.o
  CC      drivers/base/class.o
  CC      drivers/base/platform.o
  CC [M]  drivers/ata/ahci.o
  CC [M]  sound/pci/atiixp_modem.o
  CC [M]  drivers/ata/libahci.o
  CC [M]  fs/dlm/lowcomms.o
  CC [M]  fs/dlm/plock.o
  CC [M]  sound/pci/atiixp.o
  CC      drivers/acpi/acpica/nsprepkg.o
  CC [M]  sound/pci/bt87x.o
  CC      drivers/base/cpu.o
  CC      drivers/acpi/acpica/nsrepair.o
  CC      drivers/acpi/acpica/nsrepair2.o
  CC      drivers/acpi/acpica/nssearch.o
  CC      drivers/acpi/acpica/nsutils.o
  CC      drivers/base/firmware.o
  CC      drivers/base/init.o
  CC [M]  sound/pci/cs5530.o
  CC [M]  drivers/ata/sata_inic162x.o
  CC [M]  sound/pci/ens1370.o
  CC      drivers/base/map.o
  CC      drivers/acpi/acpica/nswalk.o
  CC      drivers/acpi/acpica/nsxfeval.o
  CC      drivers/acpi/acpica/nsxfname.o
  CC      drivers/acpi/acpica/nsxfobj.o
  CC      drivers/base/devres.o
  CC      drivers/base/attribute_container.o
  CC [M]  drivers/ata/sata_sil24.o
  CC [M]  fs/dlm/rcom.o
  CC [M]  drivers/ata/pdc_adma.o
  CC [M]  drivers/ata/sata_qstor.o
  CC [M]  sound/pci/ak4531_codec.o
  CC      drivers/acpi/acpica/psargs.o
  CC      drivers/acpi/acpica/psloop.o
  CC      drivers/base/transport_class.o
  CC [M]  fs/dlm/recover.o
  CC [M]  fs/dlm/recoverd.o
  CC [M]  sound/pci/ens1371.o
  CC      drivers/base/topology.o
  CC      drivers/base/devtmpfs.o
  CC      drivers/acpi/acpica/psobject.o
  CC      drivers/block/brd.o
  CC [M]  drivers/ata/sata_sx4.o
  CC [M]  drivers/ata/ata_piix.o
  CC [M]  fs/dlm/requestqueue.o
  CC      drivers/acpi/acpica/psopcode.o
  CC [M]  fs/dlm/user.o
  CC      drivers/base/power/sysfs.o
  CC      drivers/block/loop.o
  CC      drivers/base/power/generic_ops.o
  CC      drivers/acpi/acpica/psopinfo.o
  CC [M]  sound/pci/es1968.o
  CC [M]  fs/dlm/util.o
  CC [M]  fs/dlm/debug_fs.o
  CC      drivers/base/regmap/regmap.o
  CC      drivers/base/power/common.o
  CC [M]  drivers/ata/sata_mv.o
  CC      drivers/acpi/acpica/psparse.o
  CC      drivers/base/power/qos.o
  CC      drivers/acpi/acpica/psscope.o
  LD [M]  fs/dlm/dlm.o
  CC      drivers/acpi/acpica/pstree.o
  CC      drivers/base/power/main.o
  CC [M]  sound/pci/intel8x0.o
  LD      fs/ecryptfs/built-in.o
  CC [M]  fs/ecryptfs/dentry.o
  CC [M]  drivers/block/floppy.o
  CC [M]  drivers/block/cciss.o
  CC      drivers/acpi/acpica/psutils.o
  CC      drivers/base/regmap/regcache.o
  CC      drivers/base/power/wakeup.o
  CC [M]  drivers/ata/sata_nv.o
  CC      drivers/acpi/acpica/pswalk.o
  CC [M]  sound/pci/intel8x0m.o
  CC      drivers/acpi/acpica/psxface.o
  CC      drivers/base/regmap/regcache-rbtree.o
  CC [M]  fs/ecryptfs/file.o
  CC      drivers/base/power/runtime.o
  CC      drivers/acpi/acpica/rsaddr.o
  CC [M]  sound/pci/maestro3.o
  CC [M]  drivers/ata/sata_promise.o
  CC      drivers/acpi/acpica/rscalc.o
  CC      drivers/base/regmap/regcache-lzo.o
  CC [M]  drivers/ata/sata_sil.o
  CC [M]  fs/ecryptfs/inode.o
  CC      drivers/acpi/acpica/rscreate.o
  CC      drivers/base/regmap/regcache-flat.o
  LD      drivers/base/power/built-in.o
  CC      drivers/acpi/acpica/rsinfo.o
  CC [M]  drivers/block/pktcdvd.o
  CC      drivers/acpi/acpica/rsio.o
  CC      drivers/base/regmap/regmap-debugfs.o
  CC [M]  sound/pci/rme32.o
  CC      drivers/acpi/acpica/rsirq.o
  CC [M]  drivers/ata/sata_sis.o
  CC [M]  fs/ecryptfs/main.o
  CC      drivers/acpi/acpica/rslist.o
  CC [M]  sound/pci/rme96.o
  CC [M]  drivers/base/regmap/regmap-i2c.o
  CC      drivers/acpi/acpica/rsmemory.o
  CC [M]  drivers/ata/sata_svw.o
  CC      drivers/acpi/acpica/rsmisc.o
  CC [M]  fs/ecryptfs/super.o
  LD      drivers/base/regmap/built-in.o
  CC      drivers/base/dma-mapping.o
  CC [M]  sound/pci/via82xx_modem.o
  CC      drivers/acpi/acpica/rsserial.o
  CC [M]  fs/ecryptfs/mmap.o
  CC      drivers/acpi/acpica/rsutils.o
  CC [M]  drivers/ata/sata_uli.o
  CC      drivers/base/dma-buf.o
  CC [M]  drivers/ata/sata_via.o
  CC [M]  drivers/ata/sata_vsc.o
  CC      drivers/acpi/acpica/rsxface.o
  CC [M]  drivers/block/osdblk.o
  CC [M]  sound/pci/via82xx.o
  CC [M]  fs/ecryptfs/read_write.o
  LD      sound/pci/ac97/built-in.o
  CC [M]  sound/pci/ac97/ac97_codec.o
  CC      drivers/base/firmware_class.o
  CC      drivers/acpi/acpica/tbfadt.o
  CC [M]  sound/pci/ac97/ac97_pcm.o
  CC [M]  drivers/ata/pata_ali.o
  CC [M]  fs/ecryptfs/crypto.o
  CC [M]  drivers/block/cryptoloop.o
  CC      drivers/acpi/acpica/tbfind.o
  CC [M]  drivers/block/virtio_blk.o
  CC      drivers/base/node.o
  CC      drivers/acpi/acpica/tbinstal.o
  CC [M]  drivers/ata/pata_amd.o
  CC [M]  drivers/ata/pata_artop.o
  LD      fs/exofs/built-in.o
  CC [M]  fs/exofs/ore.o
  CC      drivers/acpi/acpica/tbutils.o
  CC [M]  fs/ecryptfs/keystore.o
  CC [M]  drivers/ata/pata_atiixp.o
  CC      drivers/base/memory.o
  CC      drivers/acpi/acpica/tbxface.o
  CC      drivers/acpi/acpica/tbxfload.o
  CC [M]  drivers/block/sx8.o
  CC [M]  drivers/ata/pata_atp867x.o
  CC      drivers/base/module.o
  CC [M]  drivers/ata/pata_cmd64x.o
  CC      drivers/base/hypervisor.o
  CC      drivers/acpi/acpica/tbxfroot.o
  CC [M]  fs/ecryptfs/messaging.o
  CC [M]  sound/pci/ac97/ac97_proc.o
  CC [M]  fs/ecryptfs/miscdev.o
  LD      drivers/base/built-in.o
  CC      drivers/acpi/fan.o
  CC      drivers/acpi/acpica/utaddress.o
  CC [M]  fs/exofs/ore_raid.o
  CC [M]  drivers/ata/pata_hpt366.o
  CC [M]  drivers/block/xen-blkfront.o
  LD      drivers/block/aoe/built-in.o
  CC [M]  drivers/block/aoe/aoeblk.o
  CC      drivers/acpi/acpica/utalloc.o
  CC      drivers/acpi/pci_slot.o
  LD [M]  sound/pci/ac97/snd-ac97-codec.o
  CC [M]  fs/ecryptfs/kthread.o
  LD      sound/pci/ali5451/built-in.o
  CC [M]  sound/pci/ali5451/ali5451.o
  CC      drivers/acpi/acpica/utcopy.o
  CC [M]  drivers/ata/pata_hpt37x.o
  CC [M]  fs/ecryptfs/debug.o
  LD      drivers/bluetooth/built-in.o
  CC [M]  drivers/bluetooth/hci_vhci.o
  CC [M]  drivers/block/aoe/aoechr.o
  CC      drivers/acpi/acpica/utexcep.o
  LD [M]  fs/exofs/libore.o
  CC [M]  drivers/block/aoe/aoecmd.o
  LD [M]  fs/ecryptfs/ecryptfs.o
  LD      fs/exportfs/built-in.o
  CC [M]  fs/exportfs/expfs.o
  LD      drivers/block/built-in.o
  CC [M]  drivers/block/aoe/aoedev.o
  CC      drivers/acpi/acpica/utdebug.o
  CC [M]  drivers/ata/pata_hpt3x2n.o
  LD [M]  sound/pci/ali5451/snd-ali5451.o
  LD      sound/pci/asihpi/built-in.o
  LD      sound/pci/au88x0/built-in.o
  CC [M]  sound/pci/au88x0/au8810.o
  CC [M]  sound/pci/au88x0/au8820.o
  CC [M]  drivers/bluetooth/btmrvl_main.o
  CC      drivers/acpi/acpica/utdecode.o
  LD [M]  fs/exportfs/exportfs.o
  LD      fs/ext2/built-in.o
  CC [M]  fs/ext2/balloc.o
  CC [M]  fs/ext2/dir.o
  CC      drivers/acpi/acpica/utdelete.o
  CC [M]  drivers/ata/pata_hpt3x3.o
  CC [M]  drivers/block/aoe/aoemain.o
  CC      drivers/acpi/acpica/uteval.o
  CC      drivers/acpi/acpica/utglobal.o
  CC [M]  drivers/ata/pata_it8213.o
  CC [M]  fs/ext2/file.o
  CC [M]  drivers/bluetooth/btmrvl_debugfs.o
  CC [M]  drivers/block/aoe/aoenet.o
  CC      drivers/acpi/acpica/utids.o
  CC [M]  fs/ext2/ialloc.o
  CC      drivers/acpi/acpica/utinit.o
  CC [M]  fs/ext2/inode.o
  CC      arch/x86/pci/i386.o
  CC [M]  drivers/ata/pata_it821x.o
  LD [M]  drivers/block/aoe/aoe.o
  CC      drivers/acpi/acpica/utlock.o
  CC [M]  fs/ext2/ioctl.o
  CC [M]  drivers/bluetooth/hci_ldisc.o
  CC [M]  sound/pci/au88x0/au8830.o
  CC      drivers/acpi/acpica/utmath.o
  LD      sound/pcmcia/built-in.o
  LD      sound/pcmcia/pdaudiocf/built-in.o
  LD      sound/pcmcia/vx/built-in.o
  CC      arch/x86/pci/init.o
  CC      arch/x86/pci/mmconfig_64.o
  CC      arch/x86/pci/direct.o
  CC      drivers/acpi/acpica/utmisc.o
  CC [M]  drivers/ata/pata_jmicron.o
  CC [M]  fs/ext2/namei.o
  CC      arch/x86/pci/mmconfig-shared.o
  CC      arch/x86/pci/xen.o
  CC [M]  drivers/bluetooth/hci_h4.o
  LD      drivers/bus/built-in.o
  LD      drivers/cdrom/built-in.o
  CC [M]  drivers/cdrom/cdrom.o
  CC      drivers/acpi/acpica/utmutex.o
  CC [M]  fs/ext2/super.o
  CC [M]  drivers/ata/pata_marvell.o
  CC      drivers/acpi/acpica/utobject.o
  LD      sound/pci/aw2/built-in.o
  CC [M]  drivers/ata/pata_netcell.o
  CC      arch/x86/pci/fixup.o
  CC [M]  drivers/bluetooth/hci_bcsp.o
  CC [M]  drivers/bluetooth/hci_ll.o
  CC      drivers/acpi/acpica/utosi.o
  CC [M]  fs/ext2/symlink.o
  CC [M]  drivers/ata/pata_ninja32.o
  LD [M]  sound/pci/au88x0/snd-au8810.o
  LD [M]  sound/pci/au88x0/snd-au8820.o
  LD [M]  sound/pci/au88x0/snd-au8830.o
  LD      sound/pci/ca0106/built-in.o
  CC [M]  sound/pci/ca0106/ca0106_main.o
  CC      drivers/char/mem.o
  LD      drivers/char/ipmi/built-in.o
  CC [M]  drivers/char/ipmi/ipmi_msghandler.o
  CC [M]  fs/ext2/xattr.o
  CC      arch/x86/pci/acpi.o
  CC      drivers/acpi/acpica/utownerid.o
  CC [M]  drivers/ata/pata_oldpiix.o
  CC      drivers/acpi/acpica/utresrc.o
  CC      drivers/char/random.o
  CC [M]  drivers/bluetooth/bcm203x.o
  CC      arch/x86/pci/legacy.o
  CC [M]  sound/pci/ca0106/ca0106_proc.o
  CC [M]  fs/ext2/xattr_user.o
  CC      drivers/acpi/acpica/utstate.o
  CC [M]  drivers/ata/pata_pdc2027x.o
  CC [M]  fs/ext2/xattr_trusted.o
  CC      drivers/acpi/acpica/utstring.o
  CC [M]  drivers/bluetooth/bpa10x.o
  CC      arch/x86/pci/irq.o
  CC [M]  sound/pci/ca0106/ca0106_mixer.o
  CC [M]  fs/ext2/acl.o
  CC      drivers/acpi/acpica/utxface.o
  CC [M]  drivers/char/ipmi/ipmi_devintf.o
  CC      drivers/char/misc.o
  CC [M]  drivers/ata/pata_pdc202xx_old.o
  CC [M]  fs/ext2/xattr_security.o
  CC      drivers/acpi/acpica/utxfinit.o
  CC [M]  sound/pci/ca0106/ca_midi.o
  CC [M]  drivers/bluetooth/bfusb.o
  CC      arch/x86/pci/common.o
  CC [M]  fs/ext2/xip.o
  CC      drivers/char/raw.o
  CC [M]  drivers/char/ipmi/ipmi_si_intf.o
  CC [M]  drivers/ata/pata_rdc.o
  LD [M]  sound/pci/ca0106/snd-ca0106.o
  LD      sound/pci/cs46xx/built-in.o
  CC [M]  sound/pci/cs46xx/cs46xx.o
  CC      drivers/acpi/acpica/utxferror.o
  LD [M]  fs/ext2/ext2.o
  CC      arch/x86/pci/early.o
  LD      fs/ext3/built-in.o
  CC [M]  fs/ext3/balloc.o
  CC      drivers/char/hpet.o
  CC [M]  drivers/bluetooth/dtl1_cs.o
  CC      drivers/acpi/acpica/utxfmutex.o
  CC      arch/x86/pci/bus_numa.o
  CC [M]  sound/pci/cs46xx/cs46xx_lib.o
  CC [M]  drivers/ata/pata_sch.o
  LD      drivers/acpi/acpica/acpi.o
  CC      arch/x86/pci/amd_bus.o
  LD      drivers/acpi/acpica/built-in.o
  CC      drivers/char/nvram.o
  LD      drivers/acpi/processor.o
  CC      drivers/acpi/container.o
  CC [M]  drivers/ata/pata_serverworks.o
  CC [M]  drivers/char/ipmi/ipmi_kcs_sm.o
  CC [M]  drivers/bluetooth/bt3c_cs.o
  LD      arch/x86/pci/built-in.o
  CC [M]  drivers/ata/pata_sil680.o
  CC [M]  fs/ext3/bitmap.o
  CC [M]  drivers/char/ipmi/ipmi_smic_sm.o
  CC      drivers/acpi/thermal.o
  CC      drivers/char/agp/backend.o
  CC      drivers/char/agp/frontend.o
  CC [M]  drivers/char/ipmi/ipmi_bt_sm.o
  CC [M]  fs/ext3/dir.o
  CC [M]  sound/pci/cs46xx/dsp_spos.o
  CC [M]  drivers/ata/pata_sis.o
  CC [M]  drivers/bluetooth/bluecard_cs.o
  CC      drivers/acpi/acpi_memhotplug.o
  CC [M]  drivers/char/ipmi/ipmi_watchdog.o
  CC      drivers/acpi/battery.o
  CC      drivers/char/agp/generic.o
  CC [M]  fs/ext3/file.o
  CC [M]  fs/ext3/fsync.o
  CC [M]  drivers/bluetooth/btuart_cs.o
  CC [M]  drivers/ata/pata_via.o
  CC [M]  sound/pci/cs46xx/dsp_spos_scb_lib.o
  CC [M]  fs/ext3/ialloc.o
  CC [M]  drivers/acpi/video.o
  CC [M]  drivers/char/ipmi/ipmi_poweroff.o
  CC      drivers/char/agp/isoch.o
  CC [M]  fs/ext3/inode.o
  CC [M]  drivers/ata/pata_pcmcia.o
  CC [M]  drivers/bluetooth/btusb.o
  LD [M]  sound/pci/cs46xx/snd-cs46xx.o
  LD      sound/pci/cs5535audio/built-in.o
  CC [M]  sound/pci/cs5535audio/cs5535audio.o
  LD [M]  drivers/char/ipmi/ipmi_si.o
  CC [M]  sound/pci/cs5535audio/cs5535audio_pcm.o
  LD      sound/pci/ctxfi/built-in.o
  CC [M]  sound/pci/ctxfi/xfi.o
  CC      drivers/char/agp/compat_ioctl.o
  CC [M]  drivers/ata/pata_acpi.o
  CC [M]  drivers/acpi/sbshc.o
  CC [M]  drivers/bluetooth/btsdio.o
  LD [M]  drivers/bluetooth/btmrvl.o
  CC [M]  sound/pci/cs5535audio/cs5535audio_pm.o
  CC [M]  drivers/ata/ata_generic.o
  CC [M]  sound/pci/ctxfi/ctatc.o
  CC      drivers/char/agp/amd64-agp.o
  CC [M]  fs/ext3/ioctl.o
  CC      drivers/char/agp/intel-agp.o
  LD [M]  sound/pci/cs5535audio/snd-cs5535audio.o
  CC [M]  drivers/bluetooth/btmrvl_sdio.o
  CC [M]  drivers/acpi/sbs.o
  CC [M]  drivers/acpi/hed.o
  LD      drivers/ata/libata.o
  LD      drivers/ata/built-in.o
  LD      sound/pci/echoaudio/built-in.o
  CC [M]  sound/pci/echoaudio/darla20.o
  LD      sound/pci/emu10k1/built-in.o
  CC [M]  sound/pci/emu10k1/emu10k1_synth.o
  CC [M]  fs/ext3/namei.o
  CC [M]  sound/pci/ctxfi/ctvmem.o
  LD      sound/pci/hda/built-in.o
  CC [M]  sound/pci/hda/patch_analog.o
  CC      drivers/char/agp/intel-gtt.o
  CC [M]  sound/pci/emu10k1/emu10k1_callback.o
  CC [M]  drivers/acpi/acpi_i2c.o
  LD [M]  drivers/bluetooth/hci_uart.o
  LD      sound/pci/ice1712/built-in.o
  CC [M]  sound/pci/ice1712/ice1712.o
  CC [M]  sound/pci/ctxfi/ctpcm.o
  CC [M]  sound/pci/emu10k1/emu10k1_patch.o
  CC [M]  drivers/acpi/acpi_pad.o
  CC [M]  sound/pci/echoaudio/darla24.o
  CC [M]  fs/ext3/super.o
  CC [M]  sound/pci/ctxfi/ctmixer.o
  CC      drivers/char/agp/sis-agp.o
  CC [M]  sound/pci/emu10k1/emu10k1.o
  CC [M]  sound/pci/hda/patch_ca0110.o
  LD      drivers/acpi/acpi.o
  LD      drivers/acpi/built-in.o
  CC      drivers/char/agp/via-agp.o
  CC [M]  sound/pci/ctxfi/ctresource.o
  CC [M]  sound/pci/emu10k1/emu10k1_main.o
  CC [M]  sound/pci/hda/patch_ca0132.o
  CC [M]  sound/pci/emu10k1/irq.o
  CC [M]  sound/pci/ice1712/delta.o
  LD      drivers/char/agp/agpgart.o
  CC [M]  sound/pci/ctxfi/ctsrc.o
  CC [M]  sound/pci/echoaudio/echo3g.o
  LD      drivers/char/agp/built-in.o
  CC      drivers/char/hw_random/core.o
  CC      drivers/char/hw_random/tpm-rng.o
  CC [M]  sound/pci/hda/patch_cirrus.o
  LD      sound/pci/korg1212/built-in.o
  CC [M]  sound/pci/korg1212/korg1212.o
  CC [M]  sound/pci/ice1712/hoontech.o
  CC [M]  drivers/char/hw_random/timeriomem-rng.o
  CC [M]  sound/pci/ctxfi/ctamixer.o
  CC [M]  sound/pci/hda/patch_cmedia.o
  CC [M]  sound/pci/emu10k1/memory.o
  CC [M]  sound/pci/ctxfi/ctdaio.o
  CC [M]  sound/pci/ice1712/ews.o
  CC [M]  sound/pci/echoaudio/gina20.o
  CC [M]  fs/ext3/symlink.o
  CC [M]  drivers/char/hw_random/intel-rng.o
  CC [M]  sound/pci/hda/patch_conexant.o
  CC [M]  sound/pci/ctxfi/ctimap.o
  CC [M]  fs/ext3/hash.o
  CC [M]  sound/pci/emu10k1/voice.o
  CC [M]  sound/pci/ice1712/ice1724.o
  LD [M]  sound/pci/korg1212/snd-korg1212.o
  CC [M]  drivers/char/hw_random/amd-rng.o
  CC [M]  drivers/char/hw_random/via-rng.o
  CC [M]  sound/pci/ctxfi/cthardware.o
  CC [M]  fs/ext3/resize.o
  CC [M]  sound/pci/emu10k1/emumpu401.o
  CC [M]  sound/pci/emu10k1/emupcm.o
  CC [M]  drivers/char/hw_random/virtio-rng.o
  CC [M]  sound/pci/hda/patch_hdmi.o
  CC [M]  sound/pci/echoaudio/gina24.o
  CC [M]  sound/pci/ctxfi/cttimer.o
  LD      drivers/char/hw_random/rng-core.o
  LD      drivers/char/hw_random/built-in.o
  CC [M]  sound/pci/ice1712/amp.o
  LD      drivers/char/pcmcia/built-in.o
  CC [M]  drivers/char/pcmcia/cm4000_cs.o
  CC      drivers/char/tpm/tpm.o
  CC [M]  sound/pci/ctxfi/cthw20k2.o
  CC [M]  fs/ext3/ext3_jbd.o
  CC [M]  sound/pci/ice1712/revo.o
  CC [M]  sound/pci/hda/hda_eld.o
  CC [M]  sound/pci/emu10k1/io.o
  CC [M]  fs/ext3/xattr.o
  CC [M]  sound/pci/ice1712/aureon.o
  CC [M]  sound/pci/echoaudio/indigo.o
  CC      drivers/char/tpm/tpm_eventlog.o
  CC [M]  sound/pci/ctxfi/cthw20k1.o
  CC [M]  sound/pci/hda/patch_sigmatel.o
  CC [M]  drivers/char/pcmcia/cm4040_cs.o
  CC [M]  sound/pci/emu10k1/emuproc.o
  CC [M]  fs/ext3/xattr_user.o
  CC      drivers/char/tpm/tpm_acpi.o
  CC [M]  sound/pci/ice1712/vt1720_mobo.o
  CC [M]  sound/pci/emu10k1/emumixer.o
  CC      drivers/char/tpm/tpm_ppi.o
  CC [M]  fs/ext3/xattr_trusted.o
  CC [M]  sound/pci/echoaudio/indigodj.o
  LD [M]  sound/pci/ctxfi/snd-ctxfi.o
  CC [M]  sound/pci/echoaudio/indigodjx.o
  LD      fs/ext4/built-in.o
  CC [M]  fs/ext4/balloc.o
  CC [M]  sound/pci/hda/patch_realtek.o
  CC [M]  sound/pci/ice1712/pontis.o
  CC [M]  fs/ext3/acl.o
  CC      drivers/char/tpm/tpm_tis.o
  CC [M]  sound/pci/emu10k1/emufx.o
  CC [M]  sound/pci/ice1712/prodigy192.o
  CC [M]  fs/ext3/xattr_security.o
  CC [M]  fs/ext4/bitmap.o
  CC [M]  fs/ext4/dir.o
  CC [M]  sound/pci/hda/patch_si3054.o
  CC [M]  sound/pci/echoaudio/indigoio.o
  CC [M]  drivers/char/tpm/tpm_nsc.o
  LD [M]  fs/ext3/ext3.o
  CC [M]  sound/pci/ice1712/prodigy_hifi.o
  LD      fs/fat/built-in.o
  CC [M]  fs/fat/cache.o
  CC [M]  fs/fat/dir.o
  CC [M]  sound/pci/hda/patch_via.o
  CC [M]  drivers/char/tpm/tpm_atmel.o
  CC [M]  fs/ext4/file.o
  CC [M]  sound/pci/ice1712/juli.o
  CC [M]  fs/fat/fatent.o
  CC [M]  sound/pci/echoaudio/indigoiox.o
  CC [M]  drivers/char/tpm/tpm_infineon.o
  CC [M]  sound/pci/hda/hda_codec.o
  CC [M]  sound/pci/emu10k1/timer.o
  CC [M]  fs/ext4/fsync.o
  CC [M]  fs/ext4/ialloc.o
  CC [M]  sound/pci/ice1712/phase.o
  CC [M]  sound/pci/emu10k1/p16v.o
  CC [M]  fs/fat/file.o
  LD      drivers/char/tpm/tpm_bios.o
  LD      drivers/char/tpm/built-in.o
  CC [M]  drivers/char/virtio_console.o
  CC [M]  drivers/char/i8k.o
  CC [M]  sound/pci/echoaudio/layla20.o
  CC [M]  sound/pci/ice1712/wtm.o
  CC [M]  fs/ext4/inode.o
  CC [M]  sound/pci/ice1712/se.o
  CC [M]  fs/ext4/page-io.o
  CC [M]  sound/pci/emu10k1/emu10k1x.o
  CC [M]  fs/fat/inode.o
  CC [M]  sound/pci/ice1712/maya44.o
  CC [M]  drivers/char/ppdev.o
  CC [M]  sound/pci/ice1712/quartet.o
  CC [M]  sound/pci/echoaudio/layla24.o
  LD [M]  sound/pci/emu10k1/snd-emu10k1.o
  LD [M]  sound/pci/emu10k1/snd-emu10k1-synth.o
  LD [M]  sound/pci/emu10k1/snd-emu10k1x.o
  LD      drivers/clk/x86/built-in.o
  LD      drivers/clk/built-in.o
  CC [M]  sound/pci/hda/hda_jack.o
  CC [M]  sound/pci/echoaudio/mia.o
  CC [M]  drivers/char/tlclk.o
  CC [M]  sound/pci/ice1712/psc724.o
  CC [M]  fs/fat/misc.o
  CC [M]  drivers/char/hangcheck-timer.o
  CC [M]  sound/pci/ice1712/wm8766.o
  LD      sound/pci/lola/built-in.o
  CC [M]  sound/pci/hda/hda_auto_parser.o
  LD      fs/fscache/built-in.o
  CC [M]  fs/fscache/cache.o
  CC [M]  fs/fat/nfs.o
  LD      drivers/char/built-in.o
  CC [M]  sound/pci/ice1712/wm8776.o
  CC [M]  sound/pci/ice1712/ak4xxx.o
  CC [M]  fs/ext4/ioctl.o
  CC      drivers/clocksource/acpi_pm.o
  CC [M]  sound/pci/echoaudio/mona.o
  CC [M]  fs/fat/namei_msdos.o
  CC      drivers/clocksource/i8253.o
  LD      sound/pci/lx6464es/built-in.o
  CC [M]  sound/pci/lx6464es/lx6464es.o
  CC [M]  fs/fscache/cookie.o
  CC [M]  sound/pci/hda/hda_generic.o
  CC [M]  fs/ext4/namei.o
  LD [M]  sound/pci/ice1712/snd-ice1712.o
  LD [M]  sound/pci/ice1712/snd-ice17xx-ak4xxx.o
  LD [M]  sound/pci/ice1712/snd-ice1724.o
  CC [M]  fs/ext4/super.o
  LD      drivers/clocksource/built-in.o
  CC      drivers/connector/cn_queue.o
  CC [M]  fs/fat/namei_vfat.o
  CC [M]  sound/pci/lx6464es/lx_core.o
  CC [M]  fs/fscache/fsdef.o
  CC      drivers/connector/connector.o
  LD [M]  sound/pci/echoaudio/snd-darla20.o
  LD [M]  sound/pci/echoaudio/snd-gina20.o
  LD [M]  sound/pci/echoaudio/snd-layla20.o
  LD [M]  sound/pci/echoaudio/snd-darla24.o
  LD [M]  sound/pci/echoaudio/snd-gina24.o
  LD [M]  sound/pci/echoaudio/snd-layla24.o
  LD [M]  sound/pci/echoaudio/snd-mona.o
  LD [M]  sound/pci/echoaudio/snd-mia.o
  LD [M]  sound/pci/echoaudio/snd-echo3g.o
  LD [M]  sound/pci/echoaudio/snd-indigo.o
  LD [M]  sound/pci/echoaudio/snd-indigoio.o
  LD [M]  sound/pci/echoaudio/snd-indigodj.o
  LD [M]  sound/pci/echoaudio/snd-indigoiox.o
  LD [M]  sound/pci/echoaudio/snd-indigodjx.o
  CC [M]  fs/ext4/symlink.o
  LD [M]  fs/fat/fat.o
  LD [M]  fs/fat/vfat.o
  LD [M]  fs/fat/msdos.o
  CC [M]  fs/ext4/hash.o
  CC [M]  fs/fscache/main.o
  LD [M]  sound/pci/lx6464es/snd-lx6464es.o
  CC [M]  fs/ext4/resize.o
  CC      drivers/cpufreq/cpufreq.o
  CC      drivers/cpufreq/cpufreq_performance.o
  CC      drivers/connector/cn_proc.o
  CC      drivers/cpufreq/cpufreq_userspace.o
  CC [M]  fs/fscache/netfs.o
  CC [M]  fs/fscache/object.o
  CC [M]  sound/pci/hda/hda_proc.o
  CC [M]  sound/pci/hda/hda_hwdep.o
  CC      drivers/cpuidle/cpuidle.o
  CC [M]  fs/fscache/operation.o
  CC      drivers/cpufreq/cpufreq_governor.o
  LD      drivers/connector/cn.o
  LD      drivers/connector/built-in.o
  LD      drivers/crypto/built-in.o
  CC [M]  drivers/crypto/padlock-aes.o
  LD      drivers/dca/built-in.o
  CC [M]  drivers/dca/dca-core.o
  CC [M]  sound/pci/hda/hda_beep.o
  CC [M]  drivers/crypto/padlock-sha.o
  CC      drivers/cpuidle/driver.o
  CC [M]  drivers/cpufreq/cpufreq_stats.o
  CC [M]  fs/fscache/page.o
  LD      sound/ppc/built-in.o
  LD      sound/sh/built-in.o
  CC      arch/x86/power/cpu.o
  CC      drivers/cpuidle/governor.o
  CC [M]  drivers/dca/dca-sysfs.o
  CC [M]  drivers/cpufreq/cpufreq_powersave.o
  CC      arch/x86/power/hibernate_64.o
  CC [M]  sound/pci/hda/hda_intel.o
  CC      drivers/cpuidle/sysfs.o
  CC [M]  drivers/cpufreq/cpufreq_ondemand.o
  CC      arch/x86/video/fbdev.o
  LD [M]  drivers/dca/dca.o
  LD      arch/x86/oprofile/built-in.o
  CC [M]  arch/x86/oprofile/../../../drivers/oprofile/oprof.o
  CC [M]  fs/fscache/proc.o
  CC      drivers/cpuidle/governors/ladder.o
  AS      arch/x86/power/hibernate_asm_64.o
  LD      arch/x86/power/built-in.o
  CC [M]  fs/fscache/stats.o
  CC [M]  drivers/cpufreq/cpufreq_conservative.o
  CC [M]  arch/x86/oprofile/../../../drivers/oprofile/cpu_buffer.o
  LD      arch/x86/video/built-in.o
  CC [M]  drivers/cpufreq/freq_table.o
  LD      sound/pci/mixart/built-in.o
  CC [M]  sound/pci/mixart/mixart.o
  CC      drivers/cpuidle/governors/menu.o
  LD [M]  fs/fscache/fscache.o
  CC [M]  sound/pci/mixart/mixart_core.o
  CC [M]  fs/ext4/extents.o
  CC [M]  fs/ext4/ext4_jbd2.o
  CC [M]  arch/x86/oprofile/../../../drivers/oprofile/buffer_sync.o
  CC [M]  drivers/cpufreq/acpi-cpufreq.o
  LD      drivers/cpuidle/governors/built-in.o
  LD      drivers/cpuidle/built-in.o
  CC [M]  sound/pci/mixart/mixart_hwdep.o
  CC [M]  sound/pci/mixart/mixart_mixer.o
  CC [M]  arch/x86/oprofile/../../../drivers/oprofile/event_buffer.o
  CC      drivers/dma/dmaengine.o
  CC      drivers/edac/edac_stub.o
  LD [M]  sound/pci/hda/snd-hda-codec.o
  LD [M]  sound/pci/hda/snd-hda-codec-realtek.o
  LD [M]  sound/pci/hda/snd-hda-codec-cmedia.o
  LD [M]  sound/pci/hda/snd-hda-codec-analog.o
  LD [M]  sound/pci/hda/snd-hda-codec-idt.o
  LD [M]  sound/pci/hda/snd-hda-codec-si3054.o
  LD [M]  sound/pci/hda/snd-hda-codec-cirrus.o
  LD [M]  sound/pci/hda/snd-hda-codec-ca0110.o
  LD [M]  sound/pci/hda/snd-hda-codec-ca0132.o
  LD [M]  sound/pci/hda/snd-hda-codec-conexant.o
  LD [M]  sound/pci/hda/snd-hda-codec-via.o
  LD [M]  sound/pci/hda/snd-hda-codec-hdmi.o
  LD [M]  sound/pci/hda/snd-hda-intel.o
  CC      drivers/firewire/init_ohci1394_dma.o
  CC [M]  drivers/cpufreq/mperf.o
  CC [M]  arch/x86/oprofile/../../../drivers/oprofile/oprofile_files.o
  CC [M]  drivers/cpufreq/powernow-k8.o
  CC [M]  drivers/edac/amd64_edac.o
  LD [M]  sound/pci/mixart/snd-mixart.o
  LD      sound/pci/nm256/built-in.o
  CC [M]  arch/x86/oprofile/../../../drivers/oprofile/oprofilefs.o
  LD      sound/pci/oxygen/built-in.o
  CC [M]  sound/pci/oxygen/oxygen_io.o
  CC [M]  sound/pci/oxygen/oxygen_lib.o
  CC [M]  drivers/firewire/core-card.o
  CC      drivers/dma/iovlock.o
  CC [M]  arch/x86/oprofile/../../../drivers/oprofile/oprofile_stats.o
  CC [M]  drivers/cpufreq/pcc-cpufreq.o
  CC [M]  arch/x86/oprofile/../../../drivers/oprofile/timer_int.o
  CC [M]  fs/ext4/migrate.o
  CC [M]  drivers/firewire/core-cdev.o
  CC [M]  drivers/firewire/core-device.o
  CC [M]  arch/x86/oprofile/../../../drivers/oprofile/nmi_timer_int.o
  CC [M]  sound/pci/oxygen/oxygen_mixer.o
  LD      drivers/dma/ioat/built-in.o
  CC [M]  drivers/dma/ioat/pci.o
  CC [M]  drivers/cpufreq/speedstep-lib.o
  CC [M]  drivers/edac/edac_mc.o
  CC [M]  arch/x86/oprofile/init.o
drivers/firewire/core-device.c: In function ‘fw_device_init’:
drivers/firewire/core-device.c:1029: warning: ‘minor’ may be used uninitialized in this function
  CC [M]  fs/ext4/mballoc.o
  CC [M]  sound/pci/oxygen/oxygen_pcm.o
  CC [M]  arch/x86/oprofile/backtrace.o
  CC [M]  sound/pci/oxygen/oxygen.o
  CC [M]  drivers/cpufreq/p4-clockmod.o
  CC [M]  drivers/firewire/core-iso.o
  CC [M]  arch/x86/oprofile/nmi_int.o
  LD      drivers/cpufreq/built-in.o
  CC [M]  arch/x86/oprofile/op_model_amd.o
  CC [M]  drivers/edac/edac_device.o
  CC [M]  drivers/dma/ioat/dma.o
  CC [M]  drivers/dma/ioat/dma_v2.o
  CC [M]  drivers/firewire/core-topology.o
  CC [M]  drivers/edac/edac_mc_sysfs.o
  CC [M]  drivers/firewire/core-transaction.o
  CC [M]  arch/x86/oprofile/op_model_ppro.o
  CC [M]  sound/pci/oxygen/xonar_dg.o
  CC [M]  fs/ext4/block_validity.o
  CC [M]  fs/ext4/move_extent.o
  CC [M]  drivers/edac/edac_pci_sysfs.o
  CC [M]  arch/x86/oprofile/op_model_p4.o
  CC [M]  drivers/firewire/net.o
  CC [M]  drivers/dma/ioat/dma_v3.o
  CC [M]  drivers/dma/ioat/dca.o
  LD [M]  arch/x86/oprofile/oprofile.o
  CC      net/socket.o
  CC      lib/bcd.o
  CC [M]  sound/pci/oxygen/virtuoso.o
  CC [M]  drivers/edac/edac_module.o
  CC      lib/div64.o
  CC [M]  fs/ext4/mmp.o
  CC      lib/sort.o
  CC      lib/parser.o
  CC [M]  drivers/edac/edac_device_sysfs.o
  CC [M]  drivers/firewire/ohci.o
  CC      lib/halfmd4.o
  CC [M]  sound/pci/oxygen/xonar_lib.o
  CC [M]  drivers/firewire/sbp2.o
  CC [M]  fs/ext4/indirect.o
  LD [M]  drivers/dma/ioat/ioatdma.o
  LD      drivers/dma/built-in.o
  CC      lib/debug_locks.o
  CC [M]  drivers/edac/edac_pci.o
  CC [M]  drivers/edac/mce_amd.o
  CC      lib/random32.o
  CC [M]  sound/pci/oxygen/xonar_pcm179x.o
  CC      lib/bust_spinlocks.o
  CC [M]  fs/ext4/extents_status.o
  CC [M]  fs/ext4/xattr.o
  CC [M]  drivers/edac/i5000_edac.o
  LD      drivers/firewire/built-in.o
  LD [M]  drivers/firewire/firewire-core.o
  LD [M]  drivers/firewire/firewire-ohci.o
  LD [M]  drivers/firewire/firewire-sbp2.o
  LD [M]  drivers/firewire/firewire-net.o
  CC [M]  fs/ext4/xattr_user.o
  CC      lib/hexdump.o
  CC [M]  sound/pci/oxygen/xonar_cs43xx.o
  CC [M]  sound/pci/oxygen/xonar_wm87x6.o
  CC      lib/kasprintf.o
  CC [M]  drivers/edac/i5100_edac.o
  CC      net/802/fc.o
  CC      net/802/fddi.o
  CC [M]  net/802/p8022.o
  CC      lib/bitmap.o
  CC [M]  net/802/psnap.o
  CC [M]  fs/ext4/xattr_trusted.o
  CC [M]  sound/pci/oxygen/xonar_hdmi.o
  CC [M]  drivers/edac/i5400_edac.o
  CC      lib/scatterlist.o
  CC      lib/string_helpers.o
  CC [M]  net/802/stp.o
  CC [M]  fs/ext4/inline.o
  LD [M]  sound/pci/oxygen/snd-oxygen-lib.o
  LD [M]  sound/pci/oxygen/snd-oxygen.o
  LD [M]  sound/pci/oxygen/snd-virtuoso.o
  LD      sound/pci/pcxhr/built-in.o
  CC [M]  sound/pci/pcxhr/pcxhr.o
  CC [M]  sound/pci/pcxhr/pcxhr_hwdep.o
  CC [M]  fs/ext4/acl.o
  CC      lib/gcd.o
  CC [M]  drivers/edac/i7300_edac.o
  CC      lib/lcm.o
  CC      lib/list_sort.o
  LD      sound/pci/riptide/built-in.o
  LD      sound/pci/rme9652/built-in.o
  CC [M]  sound/pci/rme9652/hdsp.o
  CC [M]  sound/pci/rme9652/hdspm.o
  CC [M]  drivers/edac/i7core_edac.o
  CC [M]  fs/ext4/xattr_security.o
  CC      lib/uuid.o
  CC      lib/flex_array.o
  CC [M]  net/802/garp.o
  CC      arch/x86/lib/msr-smp.o
  LD [M]  fs/ext4/ext4.o
  CC [M]  sound/pci/pcxhr/pcxhr_mixer.o
  CC      lib/bsearch.o
  LD      fs/fuse/built-in.o
  CC [M]  fs/fuse/dev.o
  CC      lib/find_last_bit.o
  CC      lib/find_next_bit.o
  CC      arch/x86/lib/cache-smp.o
  CC      lib/llist.o
  CC [M]  drivers/edac/e752x_edac.o
  CC      arch/x86/lib/msr.o
  CC      lib/memweight.o
  CC [M]  sound/pci/pcxhr/pcxhr_core.o
  CC      lib/kfifo.o
  LD      net/802/built-in.o
  CC      net/8021q/vlan_core.o
  AS      arch/x86/lib/msr-reg.o
  CC      arch/x86/lib/msr-reg-export.o
  CC [M]  drivers/edac/i82975x_edac.o
  CC [M]  net/8021q/vlan.o
  CC [M]  sound/pci/rme9652/rme9652.o
  AS      arch/x86/lib/iomap_copy_64.o
  AS      arch/x86/lib/clear_page_64.o
  CC      lib/kstrtox.o
  AS      arch/x86/lib/cmpxchg16b_emu.o
  CC [M]  sound/pci/pcxhr/pcxhr_mix22.o
  AS      arch/x86/lib/copy_page_64.o
  AS      arch/x86/lib/copy_user_64.o
  CC [M]  fs/fuse/dir.o
  AS      arch/x86/lib/copy_user_nocache_64.o
  AS      arch/x86/lib/csum-copy_64.o
  CC      arch/x86/lib/csum-partial_64.o
  CC [M]  drivers/edac/i3000_edac.o
  CC      lib/iomap.o
  CC [M]  drivers/edac/i3200_edac.o
  CC [M]  net/8021q/vlan_dev.o
  CC      arch/x86/lib/csum-wrappers_64.o
  LD [M]  sound/pci/pcxhr/snd-pcxhr.o
  CC      arch/x86/lib/delay.o
  CC      lib/pci_iomap.o
  CC      drivers/firmware/dmi_scan.o
  CC [M]  drivers/edac/x38_edac.o
  CC      drivers/gpio/devres.o
  LD [M]  sound/pci/rme9652/snd-rme9652.o
  LD [M]  sound/pci/rme9652/snd-hdsp.o
  LD [M]  sound/pci/rme9652/snd-hdspm.o
  CC [M]  fs/fuse/file.o
  AS      arch/x86/lib/getuser.o
  LD      sound/pci/trident/built-in.o
  CC [M]  sound/pci/trident/trident.o
  GEN     arch/x86/lib/inat-tables.c
  CC      arch/x86/lib/insn.o
  CC      lib/iomap_copy.o
  CC [M]  net/8021q/vlan_netlink.o
  CC      drivers/gpio/gpiolib.o
  AS      arch/x86/lib/memcpy_64.o
  LD [M]  drivers/edac/amd64_edac_mod.o
  LD      drivers/edac/built-in.o
  CC      lib/devres.o
  LD [M]  drivers/edac/edac_core.o
  AS      arch/x86/lib/memmove_64.o
  LD [M]  drivers/edac/edac_mce_amd.o
  CC      drivers/firmware/efivars.o
  AS      arch/x86/lib/memset_64.o
  CC [M]  net/8021q/vlan_gvrp.o
  AS      arch/x86/lib/putuser.o
  AS      arch/x86/lib/rwlock.o
  AS      arch/x86/lib/rwsem.o
  AS      arch/x86/lib/thunk_64.o
  CC [M]  sound/pci/trident/trident_main.o
  CC      arch/x86/lib/usercopy.o
  CC [M]  sound/pci/trident/trident_memory.o
  CC      lib/check_signature.o
  CC [M]  net/8021q/vlanproc.o
  CC      arch/x86/lib/usercopy_64.o
  CC      lib/hweight.o
  CC      lib/list_debug.o
  CC      drivers/gpio/gpiolib-acpi.o
  LD      drivers/gpu/drm/i2c/built-in.o
  CC [M]  drivers/gpu/drm/i2c/ch7006_drv.o
  LD      arch/x86/lib/built-in.o
  CC      arch/x86/lib/inat.o
  CC      lib/bitrev.o
  CC [M]  fs/fuse/inode.o
  CC      drivers/firmware/dmi-id.o
  AR      arch/x86/lib/lib.a
  LD      net/9p/built-in.o
  CC [M]  net/9p/mod.o
  LD      net/8021q/built-in.o
  LD [M]  net/8021q/8021q.o
  CC [M]  net/9p/client.o
drivers/gpio/gpiolib-acpi.c: In function ‘acpi_gpiochip_request_interrupts’:
drivers/gpio/gpiolib-acpi.c:129: warning: ignoring return value of ‘devm_request_threaded_irq’, declared with attribute warn_unused_result
  CC      lib/crc16.o
  CC      drivers/firmware/iscsi_ibft_find.o
  LD      drivers/gpio/built-in.o
  CC      drivers/firmware/memmap.o
  LD [M]  sound/pci/trident/snd-trident.o
  LD      sound/pci/vx222/built-in.o
  CC [M]  sound/pci/vx222/vx222.o
  CC [M]  fs/fuse/control.o
  HOSTCC  lib/gen_crc32table
  CC [M]  fs/fuse/cuse.o
  CC [M]  sound/pci/vx222/vx222_ops.o
  CC [M]  drivers/firmware/edd.o
  CC [M]  drivers/firmware/dell_rbu.o
  CC      lib/genalloc.o
  CC      lib/lzo/lzo1x_compress.o
  LD [M]  fs/fuse/fuse.o
  LD      fs/gfs2/built-in.o
  CC [M]  fs/gfs2/acl.o
  LD [M]  sound/pci/vx222/snd-vx222.o
  LD      sound/pci/ymfpci/built-in.o
  LD [M]  sound/pci/snd-ad1889.o
  LD [M]  sound/pci/snd-atiixp.o
  LD [M]  sound/pci/snd-atiixp-modem.o
  LD [M]  sound/pci/snd-bt87x.o
  LD [M]  sound/pci/snd-cs5530.o
  CC [M]  drivers/firmware/dcdbas.o
  LD [M]  sound/pci/snd-ens1370.o
  LD [M]  sound/pci/snd-ens1371.o
  LD [M]  sound/pci/snd-es1968.o
  LD [M]  sound/pci/snd-intel8x0.o
  CC [M]  drivers/firmware/iscsi_ibft.o
  LD [M]  sound/pci/snd-intel8x0m.o
  LD [M]  sound/pci/snd-maestro3.o
  LD [M]  sound/pci/snd-rme32.o
  LD [M]  sound/pci/snd-rme96.o
  LD [M]  sound/pci/snd-via82xx.o
  LD [M]  sound/pci/snd-via82xx-modem.o
  LD      lib/raid6/built-in.o
  CC [M]  lib/raid6/algos.o
  LD      sound/soc/built-in.o
  LD      sound/sparc/built-in.o
  LD      sound/spi/built-in.o
  LD      sound/synth/built-in.o
  CC [M]  sound/synth/util_mem.o
  CC [M]  net/9p/error.o
  CC      lib/lzo/lzo1x_decompress_safe.o
  CC [M]  drivers/gpu/drm/i2c/ch7006_mode.o
  CC [M]  net/9p/util.o
  LD      sound/synth/emux/built-in.o
  CC [M]  sound/synth/emux/emux.o
  CC [M]  fs/gfs2/bmap.o
  LD      lib/lzo/lzo_compress.o
  LD      lib/lzo/lzo_decompress.o
  LD      lib/lzo/built-in.o
  CC [M]  sound/synth/emux/emux_synth.o
  CC      fs/hugetlbfs/inode.o
  CC [M]  lib/raid6/recov.o
  LD      drivers/firmware/built-in.o
  CC [M]  sound/synth/emux/emux_seq.o
  CC [M]  net/9p/protocol.o
  CC [M]  drivers/gpu/drm/i2c/sil164_drv.o
  CC [M]  net/9p/trans_fd.o
  HOSTCC  lib/raid6/mktables
  LD      drivers/gpu/drm/i915/built-in.o
  CC [M]  drivers/gpu/drm/i915/i915_drv.o
  UNROLL  lib/raid6/int1.c
  UNROLL  lib/raid6/int2.c
  UNROLL  lib/raid6/int4.c
  UNROLL  lib/raid6/int8.c
  UNROLL  lib/raid6/int16.c
  UNROLL  lib/raid6/int32.c
  CC [M]  lib/raid6/recov_ssse3.o
  CC [M]  sound/synth/emux/emux_nrpn.o
  LD      fs/hugetlbfs/hugetlbfs.o
  LD      fs/hugetlbfs/built-in.o
  CC [M]  lib/raid6/recov_avx2.o
lib/raid6/recov_avx2.c:11:5: warning: "CONFIG_AS_AVX2" is not defined
lib/raid6/recov_avx2.c:322:2: warning: #warning "your version of binutils lacks AVX2 support"
  LD      drivers/gpu/stub/built-in.o
  CC [M]  lib/raid6/mmx.o
  CC      drivers/gpu/vga/vgaarb.o
  CC [M]  net/9p/trans_common.o
  LD [M]  drivers/gpu/drm/i2c/ch7006.o
  CC [M]  fs/gfs2/dir.o
  LD [M]  drivers/gpu/drm/i2c/sil164.o
  LD      drivers/gpu/drm/mga/built-in.o
  CC [M]  drivers/gpu/drm/mga/mga_drv.o
  CC [M]  sound/synth/emux/emux_effect.o
  CC [M]  lib/raid6/sse1.o
  CC [M]  lib/raid6/sse2.o
  CC [M]  net/9p/trans_rdma.o
  CC [M]  net/9p/trans_virtio.o
  CC [M]  sound/synth/emux/emux_proc.o
  CC [M]  drivers/gpu/drm/mga/mga_dma.o
  CC [M]  drivers/gpu/drm/i915/i915_dma.o
  CC [M]  lib/raid6/avx2.o
  TABLE   lib/raid6/tables.c
  CC [M]  lib/raid6/int1.o
  CC [M]  sound/synth/emux/emux_hwdep.o
  LD      drivers/gpu/vga/built-in.o
  CC [M]  sound/synth/emux/soundfont.o
  CC [M]  drivers/gpu/drm/mga/mga_state.o
  CC [M]  lib/raid6/int2.o
  LD [M]  net/9p/9pnet.o
  LD [M]  net/9p/9pnet_virtio.o
  LD      net/atm/built-in.o
  CC [M]  fs/gfs2/xattr.o
  LD [M]  net/9p/9pnet_rdma.o
  CC [M]  net/atm/addr.o
  CC [M]  drivers/gpu/drm/mga/mga_warp.o
  LD      sound/usb/built-in.o
  CC [M]  sound/usb/card.o
  CC [M]  lib/raid6/int4.o
  CC [M]  sound/synth/emux/emux_oss.o
  CC [M]  drivers/gpu/drm/i915/i915_irq.o
  CC [M]  drivers/gpu/drm/i915/i915_debugfs.o
  CC [M]  net/atm/pvc.o
  CC [M]  lib/raid6/int8.o
  CC [M]  drivers/gpu/drm/mga/mga_irq.o
  LD [M]  sound/synth/emux/snd-emux-synth.o
  CC [M]  sound/usb/clock.o
  LD [M]  sound/synth/snd-util-mem.o
  CC [M]  sound/usb/endpoint.o
  CC [M]  fs/gfs2/glock.o
  CC [M]  net/atm/signaling.o
  CC [M]  lib/raid6/int16.o
  CC [M]  lib/raid6/int32.o
  CC [M]  drivers/gpu/drm/mga/mga_ioc32.o
  CC [M]  sound/usb/format.o
  CC [M]  sound/usb/helper.o
  CC [M]  lib/raid6/tables.o
  CC [M]  drivers/gpu/drm/i915/i915_suspend.o
  LD [M]  drivers/gpu/drm/mga/mga.o
  CC [M]  net/atm/svc.o
  LD      drivers/gpu/drm/nouveau/built-in.o
  CC [M]  drivers/gpu/drm/nouveau/core/core/client.o
  CC [M]  drivers/gpu/drm/nouveau/core/core/engctx.o
  CC [M]  sound/usb/mixer.o
  CC [M]  sound/usb/mixer_quirks.o
  LD [M]  lib/raid6/raid6_pq.o
  LD      lib/reed_solomon/built-in.o
  CC [M]  lib/reed_solomon/reed_solomon.o
  CC [M]  fs/gfs2/glops.o
  CC [M]  net/atm/ioctl.o
  CC [M]  drivers/gpu/drm/i915/i915_gem.o
  CC [M]  fs/gfs2/log.o
  CC [M]  drivers/gpu/drm/nouveau/core/core/engine.o
  CC      lib/xz/xz_dec_syms.o
  CC      lib/xz/xz_dec_stream.o
  CC [M]  sound/usb/pcm.o
  CC      lib/xz/xz_dec_lzma2.o
  CC [M]  drivers/gpu/drm/nouveau/core/core/enum.o
  CC [M]  drivers/gpu/drm/nouveau/core/core/falcon.o
  LD      drivers/gpu/drm/r128/built-in.o
  CC [M]  drivers/gpu/drm/r128/r128_drv.o
  CC [M]  net/atm/common.o
  CC [M]  fs/gfs2/lops.o
  CC [M]  drivers/gpu/drm/nouveau/core/core/gpuobj.o
  CC      lib/xz/xz_dec_bcj.o
  CC [M]  drivers/gpu/drm/i915/i915_gem_context.o
  CC [M]  sound/usb/proc.o
  CC [M]  drivers/gpu/drm/nouveau/core/core/handle.o
  CC [M]  drivers/gpu/drm/r128/r128_cce.o
  LD      lib/xz/xz_dec.o
  LD      lib/xz/built-in.o
  LD      lib/zlib_deflate/built-in.o
  CC [M]  lib/zlib_deflate/deflate.o
  CC [M]  lib/zlib_deflate/deftree.o
  CC [M]  sound/usb/quirks.o
  CC [M]  fs/gfs2/main.o
  CC [M]  drivers/gpu/drm/i915/i915_gem_debug.o
  CC [M]  drivers/gpu/drm/nouveau/core/core/mm.o
  CC [M]  drivers/gpu/drm/nouveau/core/core/namedb.o
  CC [M]  net/atm/atm_misc.o
  CC [M]  drivers/gpu/drm/r128/r128_state.o
  CC [M]  lib/zlib_deflate/deflate_syms.o
  CC [M]  fs/gfs2/meta_io.o
  CC [M]  sound/usb/stream.o
  CC [M]  sound/usb/midi.o
  CC [M]  drivers/gpu/drm/i915/i915_gem_evict.o
  LD [M]  lib/zlib_deflate/zlib_deflate.o
  CC      lib/zlib_inflate/inffast.o
  CC [M]  drivers/gpu/drm/nouveau/core/core/object.o
  CC      lib/zlib_inflate/inflate.o
  CC [M]  fs/gfs2/aops.o
  CC [M]  drivers/gpu/drm/nouveau/core/core/option.o
  CC [M]  drivers/gpu/drm/i915/i915_gem_execbuffer.o
  CC [M]  net/atm/raw.o
  CC [M]  net/atm/resources.o
  CC      lib/zlib_inflate/infutil.o
  CC [M]  drivers/gpu/drm/nouveau/core/core/parent.o
  CC      lib/zlib_inflate/inftrees.o
  CC [M]  drivers/gpu/drm/r128/r128_irq.o
  LD      sound/usb/6fire/built-in.o
  LD      sound/usb/caiaq/built-in.o
  CC [M]  sound/usb/caiaq/device.o
  CC [M]  fs/gfs2/dentry.o
  CC      lib/zlib_inflate/inflate_syms.o
  CC      fs/isofs/namei.o
  CC [M]  drivers/gpu/drm/nouveau/core/core/printk.o
  CC [M]  drivers/gpu/drm/i915/i915_gem_gtt.o
  LD      lib/zlib_inflate/zlib_inflate.o
  LD      lib/zlib_inflate/built-in.o
  CC      lib/textsearch.o
  CC [M]  net/atm/atm_sysfs.o
  CC [M]  drivers/gpu/drm/r128/r128_ioc32.o
  CC [M]  fs/gfs2/export.o
  CC [M]  sound/usb/caiaq/audio.o
  CC      fs/isofs/inode.o
  CC [M]  drivers/gpu/drm/nouveau/core/core/ramht.o
  CC      lib/percpu_counter.o
  CC [M]  fs/gfs2/file.o
drivers/gpu/drm/i915/i915_gem_gtt.c: In function ‘gen6_ggtt_bind_object’:
drivers/gpu/drm/i915/i915_gem_gtt.c:439: warning: ‘addr’ may be used uninitialized in this function
  LD [M]  drivers/gpu/drm/r128/r128.o
  CC      lib/swiotlb.o
  CC [M]  net/atm/proc.o
  CC [M]  drivers/gpu/drm/i915/i915_gem_stolen.o
  CC [M]  sound/usb/caiaq/midi.o
  CC      lib/iommu-helper.o
  CC [M]  drivers/gpu/drm/nouveau/core/core/subdev.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/bar/base.o
  CC      fs/isofs/dir.o
  CC [M]  sound/usb/caiaq/control.o
  CC [M]  fs/gfs2/ops_fstype.o
  CC [M]  sound/usb/caiaq/input.o
  CC [M]  drivers/gpu/drm/i915/i915_gem_tiling.o
  CC      lib/syscall.o
  CC [M]  net/atm/clip.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/bar/nv50.o
  CC      fs/isofs/util.o
  CC      fs/isofs/rock.o
  CC      lib/dynamic_debug.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/bar/nvc0.o
  LD [M]  sound/usb/caiaq/snd-usb-caiaq.o
  CC [M]  drivers/gpu/drm/i915/i915_sysfs.o
  LD      sound/usb/misc/built-in.o
  CC [M]  drivers/gpu/drm/i915/i915_trace_points.o
  LD      sound/usb/usx2y/built-in.o
  CC [M]  sound/usb/usx2y/us122l.o
  CC [M]  fs/gfs2/inode.o
  CC      fs/isofs/export.o
  CC [M]  net/atm/br2684.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/bios/base.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/bios/bit.o
  CC      fs/isofs/joliet.o
  CC      lib/nlattr.o
  CC [M]  sound/usb/usx2y/usbusx2y.o
  CC      fs/isofs/compress.o
  CC [M]  sound/usb/usx2y/usX2Yhwdep.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/bios/conn.o
  CC [M]  net/atm/lec.o
  CC [M]  fs/gfs2/quota.o
  CC [M]  drivers/gpu/drm/i915/intel_display.o
  CC [M]  net/atm/pppoatm.o
  LD      fs/isofs/isofs.o
  LD      fs/isofs/built-in.o
  LD [M]  sound/soundcore.o
  CC [M]  sound/usb/usx2y/usx2yhwdeppcm.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/bios/dcb.o
  CC [M]  drivers/gpu/drm/i915/intel_crt.o
  CC      lib/average.o
  CC      lib/cpu_rmap.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/bios/disp.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/bios/dp.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/bios/extdev.o
  CC [M]  fs/gfs2/recovery.o
  CC      lib/dynamic_queue_limits.o
  LD [M]  net/atm/atm.o
  CC      lib/strncpy_from_user.o
  LD      net/bluetooth/built-in.o
  LD [M]  sound/usb/usx2y/snd-usb-usx2y.o
  CC [M]  net/bluetooth/af_bluetooth.o
  LD [M]  sound/usb/usx2y/snd-usb-us122l.o
  LD [M]  sound/usb/snd-usb-audio.o
  LD [M]  sound/usb/snd-usbmidi-lib.o
  LD      net/bridge/built-in.o
  CC [M]  fs/gfs2/rgrp.o
  CC [M]  net/bridge/br.o
  CC [M]  fs/gfs2/super.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/bios/gpio.o
  CC      lib/strnlen_user.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/bios/i2c.o
  CC      lib/argv_split.o
  CC      lib/bug.o
  CC [M]  net/bridge/br_device.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/bios/init.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/bios/mxm.o
  CC      lib/cmdline.o
  CC      lib/cpumask.o
  CC [M]  net/bluetooth/hci_core.o
  CC [M]  net/bridge/br_fdb.o
  CC      lib/ctype.o
  CC [M]  net/bridge/br_forward.o
  CC [M]  fs/gfs2/sys.o
  CC [M]  net/bridge/br_if.o
  CC      lib/dec_and_lock.o
  CC [M]  net/bridge/br_input.o
  CC      lib/decompress.o
  CC [M]  drivers/gpu/drm/i915/intel_lvds.o
  CC      lib/decompress_bunzip2.o
  CC [M]  fs/gfs2/trans.o
  CC [M]  net/bridge/br_ioctl.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/bios/perf.o
  CC [M]  net/bridge/br_notify.o
  CC      lib/decompress_inflate.o
  CC [M]  net/bluetooth/hci_conn.o
  CC [M]  net/bridge/br_stp.o
  CC [M]  fs/gfs2/util.o
  CC [M]  fs/gfs2/lock_dlm.o
  CC [M]  drivers/gpu/drm/i915/intel_bios.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/bios/pll.o
  CC      lib/decompress_unlzma.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/bios/therm.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/clock/nv04.o
  CC      lib/decompress_unlzo.o
  CC [M]  net/bridge/br_stp_bpdu.o
  CC [M]  net/bridge/br_stp_if.o
  LD [M]  fs/gfs2/gfs2.o
  CC [M]  drivers/gpu/drm/i915/intel_ddi.o
  LD      fs/jbd/built-in.o
  CC [M]  fs/jbd/transaction.o
  CC [M]  drivers/gpu/drm/i915/intel_dp.o
  CC      lib/decompress_unxz.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/clock/nv40.o
  CC      lib/dump_stack.o
  CC [M]  net/bluetooth/hci_event.o
  CC      lib/earlycpio.o
  CC      lib/extable.o
  CC      lib/flex_proportions.o
  CC [M]  net/bridge/br_stp_timer.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/clock/nv50.o
  CC [M]  net/bridge/br_netlink.o
  CC [M]  net/bridge/br_sysfs_if.o
  CC      lib/idr.o
  CC [M]  fs/jbd/commit.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/clock/nva3.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/clock/nvc0.o
  CC [M]  drivers/gpu/drm/i915/intel_hdmi.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/clock/pllnv04.o
  CC [M]  net/bridge/br_sysfs_br.o
  CC [M]  net/bridge/br_netfilter.o
  CC      lib/int_sqrt.o
  CC      lib/ioremap.o
  CC [M]  net/bridge/br_multicast.o
  CC [M]  fs/jbd/recovery.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/clock/pllnva3.o
  CC      lib/irq_regs.o
  CC [M]  drivers/gpu/drm/i915/intel_sdvo.o
  CC      lib/is_single_threaded.o
  CC      lib/klist.o
  CC [M]  fs/jbd/checkpoint.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/device/base.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/device/nv04.o
  CC [M]  fs/jbd/revoke.o
  CC      lib/kobject.o
  CC [M]  net/bluetooth/mgmt.o
  CC      lib/kobject_uevent.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/device/nv10.o
  CC      lib/md5.o
  CC [M]  net/bridge/br_mdb.o
  CC [M]  fs/jbd/journal.o
  CC [M]  drivers/gpu/drm/i915/intel_modes.o
  CC      drivers/hid/hid-lg.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/device/nv20.o
  CC [M]  drivers/gpu/drm/i915/intel_panel.o
  LD      net/can/built-in.o
  CC [M]  net/can/bcm.o
  CC      drivers/hid/hid-debug.o
  LD      net/bridge/netfilter/built-in.o
  CC      lib/percpu-refcount.o
  CC [M]  net/bridge/netfilter/ebtables.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/device/nv30.o
  CC [M]  drivers/gpu/drm/i915/intel_pm.o
  LD [M]  fs/jbd/jbd.o
  LD      fs/jbd2/built-in.o
  CC [M]  fs/jbd2/transaction.o
  CC      lib/plist.o
  CC [M]  net/bluetooth/hci_sock.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/device/nv40.o
  CC      lib/prio_heap.o
  CC      drivers/hid/hid-core.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/device/nv50.o
  CC [M]  net/can/raw.o
  CC [M]  fs/jbd2/commit.o
  CC      lib/proportions.o
  CC [M]  net/bluetooth/hci_sysfs.o
  CC      lib/radix-tree.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/device/nvc0.o
  CC [M]  net/can/af_can.o
  CC [M]  drivers/gpu/drm/i915/intel_i2c.o
  CC [M]  net/bridge/netfilter/ebtable_broute.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/device/nve0.o
  CC [M]  fs/jbd2/recovery.o
  CC      drivers/hid/hid-input.o
  CC      lib/ratelimit.o
  CC [M]  net/bluetooth/l2cap_core.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/devinit/base.o
  CC      lib/rbtree.o
  CC [M]  net/bridge/netfilter/ebtable_filter.o
  CC [M]  drivers/gpu/drm/i915/intel_fb.o
  CC      lib/reciprocal_div.o
  CC [M]  fs/jbd2/checkpoint.o
  CC      lib/rwsem.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/devinit/nv04.o
  CC [M]  net/can/proc.o
  CC [M]  net/bridge/netfilter/ebtable_nat.o
  CC      drivers/hid/hidraw.o
  CC [M]  drivers/gpu/drm/i915/intel_tv.o
  CC      lib/sha1.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/devinit/nv05.o
  CC [M]  fs/jbd2/revoke.o
  LD [M]  net/can/can.o
  LD [M]  net/can/can-raw.o
  LD [M]  net/can/can-bcm.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/devinit/nv10.o
  CC      lib/show_mem.o
  CC [M]  net/bridge/netfilter/ebt_802_3.o
  CC [M]  net/bridge/netfilter/ebt_among.o
  CC      drivers/hid/hid-generic.o
  CC [M]  drivers/gpu/drm/i915/intel_dvo.o
  CC [M]  fs/jbd2/journal.o
  CC      lib/string.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/devinit/nv1a.o
  CC      drivers/hid/hid-a4tech.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/devinit/nv20.o
  CC      lib/timerqueue.o
  CC      lib/vsprintf.o
  CC [M]  net/bridge/netfilter/ebt_arp.o
  CC      net/core/sock.o
  CC      drivers/hid/hid-apple.o
  CC [M]  drivers/gpu/drm/i915/intel_ringbuffer.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/devinit/nv50.o
  CC      drivers/hid/hid-belkin.o
  CC [M]  net/bridge/netfilter/ebt_ip.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/fb/base.o
  CC      drivers/hid/hid-cherry.o
  CC [M]  net/bluetooth/l2cap_sock.o
  CC      drivers/hid/hid-chicony.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/fb/nv04.o
  CC [M]  drivers/gpu/drm/i915/intel_overlay.o
  CC [M]  net/bridge/netfilter/ebt_ip6.o
  LD [M]  fs/jbd2/jbd2.o
  CC      drivers/hid/hid-cypress.o
  LD      fs/jffs2/built-in.o
  CC [M]  fs/jffs2/compr.o
  CC [M]  lib/crc-ccitt.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/fb/nv10.o
  CC      drivers/hid/hid-dr.o
  CC [M]  net/bluetooth/smp.o
  CC      net/core/request_sock.o
  CC [M]  lib/crc-t10dif.o
  CC [M]  drivers/gpu/drm/i915/intel_sprite.o
  CC      drivers/hid/hid-ezkey.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/fb/nv1a.o
  CC [M]  net/bridge/netfilter/ebt_limit.o
  CC      drivers/hid/hid-gyration.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/fb/nv20.o
  CC [M]  lib/crc-itu-t.o
  CC      drivers/hid/hid-kensington.o
  CC [M]  drivers/gpu/drm/i915/intel_opregion.o
  CC      net/core/skbuff.o
  CC [M]  net/bluetooth/sco.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/fb/nv25.o
  CC [M]  net/bridge/netfilter/ebt_mark_m.o
  CC [M]  lib/crc7.o
  CC      drivers/hid/hid-kye.o
  CC [M]  fs/jffs2/dir.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/fb/nv30.o
  CC [M]  lib/libcrc32c.o
  CC [M]  drivers/gpu/drm/i915/dvo_ch7xxx.o
  LD      drivers/hid/hid-logitech.o
  CC      drivers/hid/hid-microsoft.o
  CC [M]  net/bridge/netfilter/ebt_pkttype.o
  CC [M]  fs/jffs2/file.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/fb/nv35.o
  CC [M]  net/bluetooth/lib.o
  CC [M]  lib/ts_kmp.o
  CC      drivers/hid/hid-monterey.o
  CC [M]  drivers/gpu/drm/i915/dvo_ch7017.o
  CC [M]  fs/jffs2/ioctl.o
  CC [M]  lib/ts_bm.o
  CC      drivers/hid/hid-ntrig.o
  CC [M]  net/bridge/netfilter/ebt_stp.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/fb/nv36.o
  CC [M]  fs/jffs2/nodelist.o
  CC [M]  lib/ts_fsm.o
  CC [M]  net/bluetooth/a2mp.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/fb/nv40.o
  CC [M]  drivers/gpu/drm/i915/dvo_ivch.o
  CC      drivers/hid/hid-pl.o
  GEN     lib/crc32table.h
  AR      lib/lib.a
  CC      lib/crc32.o
  CC [M]  net/bridge/netfilter/ebt_vlan.o
  CC [M]  fs/jffs2/malloc.o
  CC      drivers/hid/hid-petalynx.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/fb/nv41.o
  CC      net/core/iovec.o
  CC [M]  drivers/gpu/drm/i915/dvo_tfp410.o
  LD      lib/built-in.o
  CC      drivers/hid/hid-samsung.o
  CC [M]  fs/jffs2/read.o
  CC      drivers/hid/hid-sjoy.o
  CC [M]  net/bridge/netfilter/ebt_arpreply.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/fb/nv44.o
  CC [M]  net/bluetooth/amp.o
  CC [M]  drivers/gpu/drm/i915/dvo_sil164.o
  CC [M]  drivers/gpu/drm/i915/dvo_ns2501.o
  CC [M]  fs/jffs2/nodemgmt.o
  CC      drivers/hid/hid-sony.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/fb/nv46.o
  CC      net/core/datagram.o
  CC [M]  net/bridge/netfilter/ebt_mark.o
  CC      drivers/hid/hid-sunplus.o
  CC [M]  fs/jffs2/readinode.o
  LD [M]  net/bluetooth/bluetooth.o
  CC [M]  drivers/gpu/drm/i915/i915_gem_dmabuf.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/fb/nv47.o
  CC [M]  drivers/gpu/drm/i915/i915_ioc32.o
  CC      drivers/hid/hid-gaff.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/fb/nv49.o
  CC [M]  net/bridge/netfilter/ebt_dnat.o
  CC [M]  drivers/gpu/drm/i915/intel_acpi.o
  LD      drivers/hsi/clients/built-in.o
  LD      drivers/hsi/built-in.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/fb/nv4e.o
  CC      drivers/hid/hid-tmff.o
  CC      net/core/stream.o
  CC [M]  fs/jffs2/write.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/fb/nv50.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/fb/nvc0.o
  CC      drivers/hid/hid-topseed.o
  LD [M]  drivers/gpu/drm/i915/i915.o
  LD      drivers/gpu/drm/radeon/built-in.o
  CC [M]  fs/jffs2/scan.o
  CC [M]  drivers/gpu/drm/radeon/radeon_drv.o
  CC [M]  net/bridge/netfilter/ebt_redirect.o
  CC      net/core/scm.o
  CC      drivers/hid/hid-twinhan.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/gpio/base.o
  CC      net/dcb/dcbnl.o
  CC      drivers/hid/hid-zpff.o
  CC [M]  fs/jffs2/gc.o
  CC [M]  fs/jffs2/symlink.o
  CC      net/core/gen_stats.o
  CC [M]  net/bridge/netfilter/ebt_snat.o
  CC [M]  net/bridge/netfilter/ebt_log.o
  CC      drivers/hid/usbhid/hid-core.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/gpio/nv10.o
  CC [M]  drivers/gpu/drm/radeon/radeon_cp.o
  CC      net/core/gen_estimator.o
  CC [M]  fs/jffs2/build.o
  CC      net/core/net_namespace.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/gpio/nv50.o
  CC      net/dcb/dcbevent.o
  CC      net/core/secure_seq.o
  CC      drivers/hid/usbhid/hid-quirks.o
  CC [M]  net/bridge/netfilter/ebt_ulog.o
  CC [M]  fs/jffs2/erase.o
  CC [M]  net/bridge/netfilter/ebt_nflog.o
  CC      drivers/hid/usbhid/hiddev.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/gpio/nvd0.o
  LD      net/dcb/built-in.o
  CC      net/core/flow_dissector.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/i2c/base.o
  CC [M]  fs/jffs2/background.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/i2c/aux.o
  LD      drivers/hwmon/built-in.o
  CC [M]  drivers/gpu/drm/radeon/radeon_state.o
  CC [M]  drivers/hwmon/hwmon.o
  LD [M]  net/bridge/bridge.o
  CC      drivers/i2c/i2c-boardinfo.o
  CC      drivers/hid/usbhid/hid-pidff.o
  CC [M]  fs/jffs2/fs.o
  CC [M]  fs/jffs2/writev.o
  CC [M]  drivers/hwmon/hwmon-vid.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/i2c/bit.o
  LD      drivers/i2c/algos/built-in.o
  CC [M]  drivers/i2c/algos/i2c-algo-bit.o
  CC [M]  drivers/i2c/algos/i2c-algo-pca.o
  CC      net/core/sysctl_net_core.o
  CC [M]  fs/jffs2/super.o
  CC [M]  drivers/hwmon/asus_atk0110.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/ibus/nvc0.o
  LD      drivers/hid/usbhid/usbhid.o
  LD      drivers/hid/usbhid/built-in.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/ibus/nve0.o
  CC [M]  drivers/hid/hid-logitech-dj.o
  LD      drivers/i2c/busses/built-in.o
  CC [M]  drivers/i2c/busses/i2c-scmi.o
  CC      net/core/dev.o
  CC [M]  fs/jffs2/debug.o
  CC [M]  fs/jffs2/wbuf.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/instmem/base.o
  CC [M]  drivers/hwmon/asb100.o
  CC [M]  drivers/i2c/busses/i2c-amd756.o
  LD      drivers/hid/hid.o
  LD      drivers/hid/built-in.o
  CC [M]  drivers/hwmon/w83627hf.o
  LD      fs/lockd/built-in.o
  CC [M]  fs/lockd/clntlock.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/instmem/nv04.o
  CC [M]  fs/jffs2/xattr.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/instmem/nv40.o
  CC [M]  drivers/gpu/drm/radeon/radeon_mem.o
  CC [M]  drivers/i2c/busses/i2c-amd756-s4882.o
  CC [M]  drivers/gpu/drm/radeon/radeon_irq.o
  CC [M]  drivers/hwmon/w83792d.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/instmem/nv50.o
  CC [M]  drivers/i2c/busses/i2c-amd8111.o
  CC [M]  drivers/gpu/drm/radeon/r300_cmdbuf.o
  CC [M]  fs/jffs2/xattr_trusted.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/ltcg/nvc0.o
  CC [M]  drivers/i2c/busses/i2c-i801.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/mc/base.o
  CC [M]  drivers/hwmon/w83793.o
  CC [M]  fs/jffs2/xattr_user.o
  CC [M]  drivers/gpu/drm/radeon/r600_cp.o
  CC      net/core/ethtool.o
  CC [M]  fs/jffs2/security.o
  CC [M]  fs/jffs2/acl.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/mc/nv04.o
  CC [M]  fs/lockd/clntproc.o
  CC [M]  drivers/i2c/busses/i2c-isch.o
  CC [M]  drivers/i2c/busses/i2c-nforce2.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/mc/nv44.o
  CC [M]  fs/jffs2/compr_rtime.o
  CC [M]  drivers/hwmon/w83781d.o
  CC [M]  fs/jffs2/compr_zlib.o
  CC [M]  fs/jffs2/summary.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/mc/nv50.o
  CC      net/core/dev_addr_lists.o
  CC [M]  drivers/gpu/drm/radeon/radeon_device.o
  CC [M]  drivers/i2c/busses/i2c-nforce2-s4985.o
  CC [M]  drivers/gpu/drm/radeon/radeon_asic.o
  CC [M]  fs/lockd/clntxdr.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/mc/nv98.o
  CC [M]  drivers/hwmon/w83791d.o
  CC [M]  drivers/i2c/busses/i2c-piix4.o
  LD [M]  fs/jffs2/jffs2.o
  CC [M]  drivers/i2c/busses/i2c-sis96x.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/mc/nvc0.o
  CC [M]  drivers/i2c/busses/i2c-via.o
  CC [M]  fs/lockd/host.o
  CC      net/core/dst.o
  CC [M]  drivers/hwmon/abituguru.o
  CC      net/core/netevent.o
  CC      net/core/neighbour.o
  CC [M]  drivers/gpu/drm/radeon/radeon_kms.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/mxm/base.o
  CC [M]  drivers/i2c/busses/i2c-viapro.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/mxm/mxms.o
  CC [M]  fs/lockd/svc.o
  CC [M]  drivers/i2c/busses/i2c-pca-platform.o
  CC [M]  drivers/hwmon/abituguru3.o
  CC [M]  drivers/gpu/drm/radeon/radeon_atombios.o
  CC [M]  drivers/gpu/drm/radeon/radeon_agp.o
  CC [M]  drivers/gpu/drm/radeon/atombios_crtc.o
  CC [M]  drivers/i2c/busses/i2c-simtec.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/mxm/nv50.o
  CC [M]  drivers/hwmon/ad7414.o
  CC [M]  drivers/i2c/busses/i2c-parport.o
  LD      fs/nfs/built-in.o
  CC [M]  fs/nfs/client.o
  CC [M]  drivers/hwmon/ad7418.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/therm/base.o
  CC [M]  fs/lockd/svclock.o
  CC [M]  drivers/i2c/busses/i2c-parport-light.o
  CC [M]  drivers/hwmon/adm1021.o
  LD      drivers/i2c/muxes/built-in.o
  CC      drivers/idle/intel_idle.o
  CC [M]  drivers/i2c/busses/i2c-tiny-usb.o
  CC [M]  drivers/hwmon/adm1025.o
  CC [M]  drivers/gpu/drm/radeon/radeon_combios.o
  CC [M]  fs/lockd/svcshare.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/therm/fan.o
  CC [M]  drivers/idle/i7300_idle.o
  CC      net/core/rtnetlink.o
  CC [M]  drivers/i2c/i2c-core.o
  CC [M]  drivers/hwmon/adm1026.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/therm/ic.o
  CC [M]  fs/lockd/svcproc.o
  LD      drivers/idle/built-in.o
  LD      drivers/infiniband/built-in.o
  LD      drivers/infiniband/core/built-in.o
  CC [M]  drivers/infiniband/core/addr.o
  CC [M]  drivers/hwmon/adm1029.o
  CC [M]  drivers/i2c/i2c-smbus.o
  CC [M]  drivers/gpu/drm/radeon/atom.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/therm/nv40.o
  CC [M]  drivers/hwmon/adm1031.o
  CC [M]  drivers/i2c/i2c-dev.o
  CC [M]  fs/lockd/svcsubs.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/therm/nv50.o
  CC [M]  drivers/infiniband/core/cm.o
  CC [M]  fs/nfs/dir.o
  CC [M]  drivers/hwmon/adm9240.o
  CC [M]  drivers/i2c/i2c-stub.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/therm/temp.o
  CC      net/core/utils.o
  CC [M]  drivers/gpu/drm/radeon/radeon_fence.o
  CC [M]  drivers/hwmon/ads7828.o
  LD      drivers/i2c/built-in.o
  CC [M]  drivers/gpu/drm/radeon/radeon_ttm.o
  CC [M]  fs/lockd/mon.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/timer/base.o
  CC [M]  drivers/hwmon/adt7462.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/timer/nv04.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/vm/base.o
  CC      net/core/link_watch.o
  CC [M]  fs/lockd/xdr.o
  CC [M]  drivers/gpu/drm/radeon/radeon_object.o
  CC [M]  drivers/hwmon/adt7470.o
  CC [M]  drivers/gpu/drm/radeon/radeon_gart.o
  CC [M]  fs/nfs/file.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/vm/nv04.o
  CC [M]  fs/lockd/grace.o
  CC [M]  drivers/infiniband/core/packer.o
  CC [M]  drivers/infiniband/core/ud_header.o
  CC      net/core/filter.o
  CC [M]  drivers/hwmon/adt7475.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/vm/nv41.o
  CC [M]  drivers/gpu/drm/radeon/radeon_legacy_crtc.o
  CC [M]  drivers/hwmon/applesmc.o
  CC [M]  drivers/infiniband/core/verbs.o
  CC [M]  fs/lockd/clnt4xdr.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/vm/nv44.o
  CC [M]  fs/nfs/getroot.o
  CC [M]  fs/nfs/inode.o
  CC [M]  drivers/hwmon/atxp1.o
  CC [M]  drivers/gpu/drm/radeon/radeon_legacy_encoders.o
  CC      net/core/sock_diag.o
  CC [M]  drivers/infiniband/core/sysfs.o
  CC [M]  fs/lockd/xdr4.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/vm/nv50.o
  CC [M]  fs/lockd/svc4proc.o
  CC [M]  drivers/hwmon/coretemp.o
  CC [M]  drivers/gpu/drm/nouveau/core/subdev/vm/nvc0.o
  CC [M]  drivers/infiniband/core/device.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/dmaobj/base.o
  CC      net/core/flow.o
  CC [M]  drivers/hwmon/dme1737.o
  LD [M]  fs/lockd/lockd.o
  CC      net/core/net-sysfs.o
  CC [M]  drivers/gpu/drm/radeon/radeon_connectors.o
  CC [M]  fs/nfs/super.o
  CC [M]  fs/nfs/direct.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/dmaobj/nv04.o
  CC      net/core/netpoll.o
  CC [M]  drivers/hwmon/ds1621.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/dmaobj/nv50.o
  CC [M]  drivers/infiniband/core/fmr_pool.o
  CC [M]  drivers/gpu/drm/radeon/radeon_encoders.o
  CC [M]  drivers/gpu/drm/radeon/radeon_display.o
  CC [M]  drivers/hwmon/f71805f.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/dmaobj/nvc0.o
  CC [M]  drivers/hwmon/f71882fg.o
  CC [M]  drivers/infiniband/core/cache.o
  CC [M]  drivers/infiniband/core/netlink.o
  CC      net/core/user_dma.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/dmaobj/nvd0.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/bsp/nv84.o
  CC [M]  drivers/gpu/drm/radeon/radeon_cursor.o
  CC [M]  fs/nfs/pagelist.o
  CC [M]  drivers/gpu/drm/radeon/radeon_i2c.o
  CC [M]  drivers/gpu/drm/radeon/radeon_clocks.o
  CC [M]  drivers/infiniband/core/umem.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/bsp/nvc0.o
  CC [M]  drivers/hwmon/f75375s.o
  CC [M]  drivers/hwmon/fschmd.o
  CC      net/core/fib_rules.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/bsp/nve0.o
  CC      net/core/net-traces.o
  CC [M]  drivers/gpu/drm/radeon/radeon_fb.o
  CC [M]  drivers/gpu/drm/radeon/radeon_gem.o
  CC [M]  fs/nfs/read.o
  CC [M]  drivers/infiniband/core/mad.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/copy/nva3.o
  CC [M]  drivers/hwmon/g760a.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/copy/nvc0.o
  CC [M]  drivers/hwmon/gl518sm.o
  CC [M]  drivers/gpu/drm/radeon/radeon_ring.o
  CC [M]  drivers/gpu/drm/radeon/radeon_irq_kms.o
  LD      fs/nfs_common/built-in.o
  CC [M]  fs/nfs_common/nfsacl.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/copy/nve0.o
  CC      net/core/drop_monitor.o
  CC [M]  drivers/hwmon/gl520sm.o
  LD [M]  fs/nfs_common/nfs_acl.o
  CC [M]  net/core/pktgen.o
  CC [M]  fs/nfs/symlink.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/crypt/nv84.o
  CC [M]  drivers/gpu/drm/radeon/radeon_cs.o
  CC [M]  fs/nfs/unlink.o
  CC [M]  drivers/infiniband/core/smi.o
  CC [M]  drivers/hwmon/i5k_amb.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/crypt/nv98.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/disp/nv04.o
  CC [M]  drivers/infiniband/core/agent.o
  CC [M]  drivers/infiniband/core/mad_rmpp.o
  CC [M]  drivers/gpu/drm/radeon/radeon_bios.o
  CC [M]  drivers/gpu/drm/radeon/radeon_benchmark.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/disp/nv50.o
  LD      net/dccp/built-in.o
  CC [M]  drivers/hwmon/ibmaem.o
  CC [M]  net/dccp/ccid.o
  CC [M]  fs/nfs/write.o
  CC [M]  drivers/infiniband/core/sa_query.o
  CC [M]  drivers/hwmon/ibmpex.o
  CC [M]  fs/nfs/namespace.o
  HOSTCC  drivers/gpu/drm/radeon/mkregtable
  CC [M]  drivers/gpu/drm/nouveau/core/engine/disp/nv84.o
  LD      net/core/built-in.o
  CC [M]  drivers/infiniband/core/multicast.o
  LD      net/dns_resolver/built-in.o
  CC [M]  net/dns_resolver/dns_key.o
  CC [M]  drivers/gpu/drm/radeon/rs400.o
  CC [M]  drivers/hwmon/it87.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/disp/nv94.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/disp/nva0.o
  CC [M]  net/dns_resolver/dns_query.o
  CC [M]  drivers/infiniband/core/ucm.o
  CC [M]  fs/nfs/mount_clnt.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/disp/nva3.o
  CC [M]  net/dccp/feat.o
  CC [M]  drivers/hwmon/k8temp.o
  CC [M]  drivers/hwmon/k10temp.o
  MKREGTABLE drivers/gpu/drm/radeon/rs600_reg_safe.h
  CC [M]  drivers/gpu/drm/radeon/rs690.o
  LD [M]  net/dns_resolver/dns_resolver.o
  CC [M]  drivers/hwmon/lm63.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/disp/nvd0.o
  CC [M]  net/dccp/input.o
  CC [M]  net/dccp/minisocks.o
  CC [M]  fs/nfs/dns_resolve.o
  CC [M]  drivers/infiniband/core/user_mad.o
  CC [M]  drivers/hwmon/lm75.o
  MKREGTABLE drivers/gpu/drm/radeon/rv515_reg_safe.h
  CC [M]  drivers/gpu/drm/radeon/r520.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/disp/nve0.o
  CC [M]  drivers/hwmon/lm77.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/disp/dacnv50.o
  CC [M]  net/dccp/options.o
  LD      fs/nfsd/built-in.o
  CC [M]  fs/nfsd/nfssvc.o
  CC [M]  drivers/infiniband/core/uverbs_main.o
  CC [M]  drivers/gpu/drm/radeon/r600.o
  CC [M]  drivers/gpu/drm/radeon/rv770.o
  CC [M]  fs/nfs/cache_lib.o
  CC [M]  drivers/hwmon/lm78.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/disp/hdanva3.o
  CC [M]  fs/nfs/sysctl.o
  CC [M]  drivers/hwmon/lm80.o
  CC [M]  fs/nfsd/nfsctl.o
  CC [M]  drivers/infiniband/core/uverbs_cmd.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/disp/hdanvd0.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/disp/hdminv84.o
  CC [M]  net/dccp/output.o
  CC [M]  drivers/hwmon/lm83.o
  CC      fs/nls/nls_base.o
  CC [M]  fs/nfs/fscache.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/disp/hdminva3.o
  CC [M]  drivers/hwmon/lm85.o
  CC [M]  fs/nfsd/nfsproc.o
  CC      fs/nls/nls_cp437.o
  CC [M]  drivers/gpu/drm/radeon/radeon_test.o
  CC      fs/nls/nls_ascii.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/disp/hdminvd0.o
  CC [M]  drivers/infiniband/core/uverbs_marshall.o
  CC [M]  fs/nfsd/nfsfh.o
  CC [M]  fs/nls/nls_cp737.o
  CC [M]  drivers/hwmon/lm87.o
  CC [M]  fs/nfs/fscache-index.o
  CC [M]  net/dccp/proto.o
  CC [M]  drivers/infiniband/core/iwcm.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/disp/sornv50.o
  CC [M]  fs/nls/nls_cp775.o
  MKREGTABLE drivers/gpu/drm/radeon/r200_reg_safe.h
  CC [M]  drivers/gpu/drm/radeon/radeon_legacy_tv.o
  CC [M]  fs/nls/nls_cp850.o
  CC [M]  fs/nfsd/vfs.o
  CC [M]  drivers/hwmon/lm90.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/disp/sornv94.o
  CC [M]  fs/nls/nls_cp852.o
  CC [M]  fs/nfs/nfs4filelayout.o
  CC [M]  fs/nls/nls_cp855.o
  MKREGTABLE drivers/gpu/drm/radeon/r600_reg_safe.h
  CC [M]  drivers/gpu/drm/radeon/r600_blit.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/disp/sornvd0.o
  CC [M]  drivers/infiniband/core/cma.o
  CC [M]  drivers/hwmon/lm92.o
  CC [M]  fs/nls/nls_cp857.o
  CC [M]  net/dccp/timer.o
  CC [M]  fs/nfsd/export.o
  CC [M]  drivers/hwmon/lm93.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/disp/vga.o
  CC [M]  fs/nls/nls_cp860.o
  CC [M]  fs/nfs/nfs4filelayoutdev.o
  CC [M]  drivers/gpu/drm/radeon/r600_blit_shaders.o
  CC [M]  fs/nls/nls_cp861.o
  CC [M]  drivers/gpu/drm/radeon/r600_blit_kms.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/fifo/base.o
  CC [M]  fs/nls/nls_cp862.o
  CC [M]  net/dccp/qpolicy.o
  CC [M]  fs/nfsd/auth.o
  CC [M]  drivers/hwmon/lm95241.o
  CC [M]  fs/nfs/nfs2super.o
  CC [M]  fs/nls/nls_cp863.o
  CC [M]  fs/nfsd/lockd.o
  CC [M]  drivers/hwmon/ltc4215.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/fifo/nv04.o
  CC [M]  fs/nls/nls_cp864.o
  CC [M]  drivers/infiniband/core/ucma.o
  CC [M]  drivers/gpu/drm/radeon/radeon_pm.o
  CC [M]  net/dccp/ccids/ccid2.o
  CC [M]  fs/nls/nls_cp865.o
  CC [M]  fs/nfsd/nfscache.o
  CC [M]  drivers/hwmon/ltc4245.o
  CC [M]  fs/nfs/proc.o
  CC [M]  fs/nls/nls_cp866.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/fifo/nv10.o
  CC [M]  fs/nfsd/nfsxdr.o
  CC [M]  drivers/hwmon/max1619.o
  CC [M]  fs/nls/nls_cp869.o
  CC [M]  fs/nls/nls_cp874.o
  CC [M]  drivers/gpu/drm/radeon/atombios_dp.o
  LD [M]  drivers/infiniband/core/ib_core.o
  CC [M]  drivers/hwmon/max6650.o
  CC [M]  net/dccp/ackvec.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/fifo/nv17.o
  LD [M]  drivers/infiniband/core/ib_mad.o
  LD [M]  drivers/infiniband/core/ib_sa.o
  LD [M]  drivers/infiniband/core/ib_cm.o
  LD [M]  drivers/infiniband/core/iw_cm.o
  CC [M]  fs/nfs/nfs2xdr.o
  CC [M]  fs/nls/nls_cp932.o
  LD [M]  drivers/infiniband/core/ib_addr.o
  LD [M]  drivers/infiniband/core/rdma_cm.o
  LD [M]  drivers/infiniband/core/ib_umad.o
  LD [M]  drivers/infiniband/core/ib_uverbs.o
  LD [M]  drivers/infiniband/core/ib_ucm.o
  LD [M]  drivers/infiniband/core/rdma_ucm.o
  CC [M]  fs/nfsd/stats.o
  LD      drivers/infiniband/hw/cxgb3/built-in.o
  CC [M]  drivers/infiniband/hw/cxgb3/iwch_cm.o
  CC [M]  drivers/hwmon/pc87360.o
  CC [M]  fs/nls/nls_euc-jp.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/fifo/nv40.o
  CC [M]  fs/nfsd/nfs2acl.o
  CC [M]  drivers/gpu/drm/radeon/r600_audio.o
  CC [M]  fs/nls/nls_cp936.o
  CC [M]  fs/nfs/nfs3super.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/fifo/nv50.o
  CC [M]  fs/nfsd/nfs3proc.o
  CC [M]  net/dccp/ccids/ccid3.o
  CC [M]  fs/nls/nls_cp949.o
  CC [M]  drivers/gpu/drm/radeon/r600_hdmi.o
  CC [M]  drivers/hwmon/pc87427.o
  CC [M]  fs/nfs/nfs3client.o
  CC [M]  fs/nfsd/nfs3xdr.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/fifo/nv84.o
  CC [M]  fs/nls/nls_cp950.o
  CC [M]  drivers/infiniband/hw/cxgb3/iwch_ev.o
  CC [M]  drivers/gpu/drm/radeon/evergreen.o
  CC [M]  drivers/hwmon/pcf8591.o
  CC [M]  net/dccp/ccids/lib/tfrc.o
  CC [M]  fs/nfs/nfs3proc.o
  CC [M]  fs/nls/nls_cp1250.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/fifo/nvc0.o
  CC [M]  drivers/hwmon/sis5595.o
  CC [M]  fs/nls/nls_cp1251.o
  CC [M]  drivers/infiniband/hw/cxgb3/iwch_cq.o
  CC [M]  fs/nfsd/nfs3acl.o
  CC [M]  fs/nls/nls_iso8859-1.o
  CC [M]  net/dccp/ccids/lib/tfrc_equation.o
  CC [M]  fs/nls/nls_iso8859-2.o
  CC [M]  fs/nfsd/nfs4proc.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/fifo/nve0.o
  CC [M]  drivers/hwmon/smsc47b397.o
  CC [M]  fs/nfs/nfs3xdr.o
  CC [M]  drivers/infiniband/hw/cxgb3/iwch_qp.o
  CC [M]  fs/nls/nls_iso8859-3.o
  CC [M]  net/dccp/ccids/lib/packet_history.o
  CC [M]  drivers/hwmon/smsc47m1.o
  CC [M]  fs/nls/nls_iso8859-4.o
  MKREGTABLE drivers/gpu/drm/radeon/evergreen_reg_safe.h
  CC [M]  drivers/gpu/drm/nouveau/core/engine/graph/ctxnv40.o
  CC [M]  fs/nfsd/nfs4xdr.o
  CC [M]  fs/nls/nls_iso8859-5.o
  MKREGTABLE drivers/gpu/drm/radeon/cayman_reg_safe.h
  CC [M]  fs/nfs/nfs3acl.o
  CC [M]  drivers/hwmon/smsc47m192.o
  CC [M]  net/dccp/ccids/lib/loss_interval.o
  CC [M]  drivers/gpu/drm/radeon/evergreen_blit_shaders.o
  CC [M]  drivers/infiniband/hw/cxgb3/iwch_mem.o
  CC [M]  drivers/gpu/drm/radeon/evergreen_blit_kms.o
  CC [M]  fs/nls/nls_iso8859-6.o
  CC [M]  drivers/hwmon/thmc50.o
  CC [M]  fs/nls/nls_iso8859-7.o
  CC [M]  drivers/infiniband/hw/cxgb3/iwch_provider.o
  CC [M]  net/dccp/sysctl.o
  CC [M]  fs/nfs/nfs4proc.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/graph/ctxnv50.o
  CC [M]  fs/nls/nls_cp1255.o
  CC [M]  drivers/gpu/drm/radeon/evergreen_hdmi.o
  CC [M]  drivers/hwmon/tmp401.o
  CC [M]  fs/nls/nls_iso8859-9.o
  CC [M]  fs/nfsd/nfs4state.o
  CC [M]  net/dccp/diag.o
  CC [M]  fs/nls/nls_iso8859-13.o
  CC [M]  drivers/hwmon/tmp421.o
  CC [M]  drivers/gpu/drm/radeon/radeon_trace_points.o
  CC [M]  fs/nls/nls_iso8859-14.o
  CC [M]  net/dccp/ipv4.o
  CC [M]  drivers/infiniband/hw/cxgb3/iwch.o
  CC [M]  drivers/gpu/drm/radeon/ni.o
  CC [M]  fs/nls/nls_iso8859-15.o
  CC [M]  drivers/hwmon/via-cputemp.o
  CC [M]  fs/nls/nls_koi8-r.o
  CC [M]  drivers/hwmon/via686a.o
  CC [M]  drivers/infiniband/hw/cxgb3/cxio_hal.o
  CC [M]  fs/nls/nls_koi8-u.o
  CC [M]  fs/nls/nls_koi8-ru.o
  CC [M]  drivers/gpu/drm/radeon/cayman_blit_shaders.o
  CC [M]  drivers/hwmon/vt1211.o
  CC [M]  drivers/gpu/drm/radeon/atombios_encoders.o
  CC [M]  net/dccp/ipv6.o
  CC [M]  fs/nfsd/nfs4idmap.o
  CC [M]  fs/nfs/nfs4xdr.o
  CC [M]  fs/nls/nls_utf8.o
  LD      fs/nls/built-in.o
  CC [M]  fs/nfs/nfs4state.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/graph/ctxnvc0.o
  CC [M]  drivers/hwmon/vt8231.o
  CC [M]  fs/nfsd/nfs4acl.o
  CC [M]  drivers/infiniband/hw/cxgb3/cxio_resource.o
  CC [M]  drivers/gpu/drm/radeon/radeon_semaphore.o
  CC [M]  net/dccp/probe.o
  LD [M]  drivers/infiniband/hw/cxgb3/iw_cxgb3.o
  CC [M]  drivers/hwmon/w83627ehf.o
  LD      drivers/infiniband/hw/cxgb4/built-in.o
  CC [M]  drivers/infiniband/hw/cxgb4/device.o
  CC [M]  drivers/gpu/drm/radeon/radeon_sa.o
  CC [M]  fs/nfsd/nfs4callback.o
  LD [M]  net/dccp/dccp.o
  LD [M]  net/dccp/dccp_ipv4.o
  LD [M]  net/dccp/dccp_ipv6.o
  LD [M]  net/dccp/dccp_diag.o
  LD [M]  net/dccp/dccp_probe.o
  CC      net/dsa/dsa.o
  CC [M]  fs/nfsd/nfs4recover.o
  CC [M]  fs/nfs/nfs4renewd.o
  CC [M]  drivers/gpu/drm/radeon/atombios_i2c.o
  CC [M]  drivers/hwmon/w83l785ts.o
  CC [M]  drivers/hwmon/w83l786ng.o
  LD      drivers/gpu/drm/savage/built-in.o
  CC [M]  drivers/gpu/drm/savage/savage_drv.o
  LD      drivers/gpu/drm/sis/built-in.o
  CC [M]  drivers/gpu/drm/radeon/si.o
  CC [M]  drivers/gpu/drm/sis/sis_drv.o
  CC [M]  fs/nfs/nfs4super.o
  CC [M]  drivers/infiniband/hw/cxgb4/cm.o
  CC      net/dsa/slave.o
  CC [M]  drivers/gpu/drm/savage/savage_bci.o
  LD [M]  fs/nfsd/nfsd.o
  CC [M]  drivers/gpu/drm/sis/sis_mm.o
  CC      net/dsa/tag_dsa.o
  CC [M]  fs/nfs/nfs4file.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/graph/ctxnve0.o
  CC      net/dsa/tag_edsa.o
  LD [M]  drivers/gpu/drm/sis/sis.o
  CC      net/dsa/tag_trailer.o
  CC [M]  drivers/gpu/drm/savage/savage_state.o
  CC [M]  fs/nfs/delegation.o
  CC [M]  drivers/gpu/drm/radeon/si_blit_shaders.o
  CC [M]  drivers/gpu/drm/radeon/radeon_prime.o
  LD      net/dsa/dsa_core.o
  CC      net/ethernet/eth.o
  LD      net/dsa/built-in.o
  CC [M]  fs/nfs/idmap.o
  LD [M]  drivers/gpu/drm/savage/savage.o
  LD      net/ieee802154/built-in.o
  CC [M]  net/ieee802154/af_ieee802154.o
  CC [M]  drivers/gpu/drm/radeon/radeon_ioc32.o
  CC [M]  drivers/infiniband/hw/cxgb4/provider.o
  LD      net/ethernet/built-in.o
  CC [M]  drivers/infiniband/hw/cxgb4/mem.o
  CC      drivers/input/input.o
  CC [M]  fs/nfs/callback.o
  CC [M]  net/ieee802154/raw.o
  CC [M]  drivers/gpu/drm/radeon/radeon_acpi.o
  CC      drivers/input/input-compat.o
  CC [M]  fs/nfs/callback_xdr.o
  CC [M]  drivers/infiniband/hw/cxgb4/cq.o
  CC [M]  net/ieee802154/dgram.o
  MKREGTABLE drivers/gpu/drm/radeon/r100_reg_safe.h
  MKREGTABLE drivers/gpu/drm/radeon/rn50_reg_safe.h
  MKREGTABLE drivers/gpu/drm/radeon/r300_reg_safe.h
  MKREGTABLE drivers/gpu/drm/radeon/r420_reg_safe.h
  CC [M]  drivers/gpu/drm/radeon/rs600.o
  CC [M]  drivers/gpu/drm/radeon/rv515.o
  CC      drivers/input/input-mt.o
  CC [M]  net/ieee802154/netlink.o
  CC [M]  fs/nfs/callback_proc.o
  CC      drivers/input/ff-core.o
  CC      drivers/input/ff-memless.o
  CC [M]  drivers/infiniband/hw/cxgb4/qp.o
  CC [M]  drivers/gpu/drm/radeon/r200.o
  CC [M]  net/ieee802154/nl-mac.o
  CC [M]  drivers/gpu/drm/radeon/r600_cs.o
  CC [M]  fs/nfs/nfs4namespace.o
  CC      drivers/input/mousedev.o
  CC      drivers/input/evdev.o
  CC [M]  fs/nfs/nfs4getroot.o
  CC [M]  drivers/infiniband/hw/cxgb4/resource.o
  CC [M]  net/ieee802154/nl-phy.o
  CC [M]  net/ieee802154/nl_policy.o
  CC      drivers/input/serio/serio.o
  CC      drivers/input/keyboard/atkbd.o
  CC [M]  drivers/gpu/drm/radeon/evergreen_cs.o
  CC [M]  drivers/input/keyboard/adp5588-keys.o
  CC [M]  fs/nfs/nfs4client.o
  CC [M]  net/ieee802154/wpan-class.o
  CC [M]  drivers/infiniband/hw/cxgb4/ev.o
  CC      drivers/input/serio/i8042.o
  CC      drivers/input/serio/serport.o
  CC [M]  drivers/input/keyboard/max7359_keypad.o
  CC      fs/notify/fsnotify.o
  CC [M]  drivers/input/keyboard/opencores-kbd.o
  CC [M]  drivers/infiniband/hw/cxgb4/id_table.o
  LD [M]  net/ieee802154/ieee802154.o
  LD [M]  net/ieee802154/af_802154.o
  CC      net/ipv4/route.o
  CC      drivers/input/serio/libps2.o
  LD      drivers/input/keyboard/built-in.o
  CC      drivers/input/misc/xen-kbdfront.o
  CC [M]  fs/nfs/nfs4sysctl.o
  CC      fs/notify/notification.o
  CC [M]  drivers/gpu/drm/radeon/r100.o
  LD [M]  drivers/infiniband/hw/cxgb4/iw_cxgb4.o
  LD      drivers/infiniband/hw/ipath/built-in.o
  CC [M]  drivers/infiniband/hw/ipath/ipath_cq.o
  CC [M]  drivers/input/serio/serio_raw.o
  CC [M]  drivers/input/misc/apanel.o
  CC      fs/notify/group.o
  CC [M]  fs/nfs/nfs4session.o
  CC [M]  drivers/infiniband/hw/ipath/ipath_diag.o
  CC      fs/notify/inode_mark.o
  CC [M]  drivers/input/misc/ati_remote2.o
  LD      drivers/input/serio/built-in.o
  CC [M]  drivers/input/misc/atlas_btns.o
  CC [M]  drivers/infiniband/hw/ipath/ipath_dma.o
  CC      fs/notify/mark.o
  CC [M]  drivers/infiniband/hw/ipath/ipath_driver.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/graph/nv04.o
  CC [M]  drivers/input/misc/cm109.o
  CC      net/ipv4/inetpeer.o
  CC [M]  fs/nfs/pnfs.o
  CC [M]  fs/nfs/pnfs_dev.o
  CC      fs/notify/vfsmount_mark.o
  CC [M]  drivers/gpu/drm/radeon/r300.o
  CC      fs/notify/fdinfo.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/graph/nv10.o
  CC [M]  drivers/input/misc/keyspan_remote.o
  CC      fs/notify/dnotify/dnotify.o
  CC [M]  drivers/input/misc/pcspkr.o
  CC      net/ipv4/protocol.o
  CC      drivers/input/mouse/psmouse-base.o
  CC [M]  drivers/gpu/drm/radeon/r420.o
  LD      fs/notify/dnotify/built-in.o
  LD      fs/notify/fanotify/built-in.o
  CC [M]  drivers/input/misc/powermate.o
  CC      fs/notify/inotify/inotify_fsnotify.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/graph/nv20.o
  CC [M]  drivers/infiniband/hw/ipath/ipath_eeprom.o
  LD      fs/nfs/blocklayout/built-in.o
  CC [M]  fs/nfs/blocklayout/blocklayout.o
  CC      net/ipv4/ip_input.o
  CC [M]  drivers/input/misc/uinput.o
  CC      fs/notify/inotify/inotify_user.o
  LD [M]  drivers/gpu/drm/radeon/radeon.o
  CC [M]  drivers/infiniband/hw/ipath/ipath_file_ops.o
  LD      drivers/gpu/drm/ttm/built-in.o
  CC [M]  drivers/gpu/drm/ttm/ttm_agp_backend.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/graph/nv25.o
  CC [M]  drivers/gpu/drm/ttm/ttm_memory.o
  CC      drivers/input/mouse/synaptics.o
  CC [M]  fs/nfs/blocklayout/extents.o
  LD      fs/notify/inotify/built-in.o
  LD      fs/notify/built-in.o
  CC [M]  fs/nfs/blocklayout/blocklayoutdev.o
  CC      net/ipv4/ip_fragment.o
  CC [M]  drivers/input/misc/yealink.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/graph/nv2a.o
  CC [M]  drivers/gpu/drm/ttm/ttm_tt.o
  CC      drivers/input/mouse/alps.o
  CC [M]  drivers/gpu/drm/ttm/ttm_bo.o
  CC [M]  drivers/infiniband/hw/ipath/ipath_fs.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/graph/nv30.o
  LD      drivers/input/misc/built-in.o
  CC [M]  drivers/infiniband/hw/ipath/ipath_init_chip.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/graph/nv34.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/graph/nv35.o
  CC [M]  fs/nfs/blocklayout/blocklayoutdm.o
  CC      drivers/input/mouse/elantech.o
  CC      drivers/input/mouse/logips2pp.o
  CC      net/ipv4/ip_forward.o
  CC      net/ipv4/ip_options.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/graph/nv40.o
  CC [M]  drivers/gpu/drm/ttm/ttm_bo_util.o
  LD [M]  fs/nfs/blocklayout/blocklayoutdriver.o
  LD      fs/nfs/objlayout/built-in.o
  CC [M]  fs/nfs/objlayout/objio_osd.o
  CC [M]  fs/nfs/objlayout/pnfs_osd_xdr_cli.o
  CC      drivers/input/mouse/lifebook.o
  CC [M]  drivers/infiniband/hw/ipath/ipath_intr.o
  CC      drivers/input/mouse/sentelic.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/graph/nv50.o
  CC      drivers/input/mouse/trackpoint.o
  CC [M]  drivers/gpu/drm/ttm/ttm_bo_vm.o
  CC [M]  drivers/gpu/drm/ttm/ttm_module.o
  CC [M]  drivers/gpu/drm/ttm/ttm_object.o
  CC [M]  fs/nfs/objlayout/objlayout.o
  CC      net/ipv4/ip_output.o
  CC      drivers/input/mouse/cypress_ps2.o
  CC [M]  drivers/infiniband/hw/ipath/ipath_keys.o
  CC [M]  drivers/infiniband/hw/ipath/ipath_mad.o
  CC [M]  drivers/input/mouse/appletouch.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/graph/nvc0.o
  CC [M]  drivers/gpu/drm/ttm/ttm_lock.o
  CC [M]  drivers/gpu/drm/ttm/ttm_execbuf_util.o
  CC [M]  drivers/gpu/drm/ttm/ttm_page_alloc.o
  LD [M]  fs/nfs/objlayout/objlayoutdriver.o
  LD [M]  fs/nfs/nfs.o
  LD [M]  fs/nfs/nfsv2.o
  LD [M]  fs/nfs/nfsv3.o
  CC [M]  drivers/input/mouse/bcm5974.o
  CC [M]  drivers/infiniband/hw/ipath/ipath_mmap.o
  LD [M]  fs/nfs/nfsv4.o
  CC [M]  drivers/infiniband/hw/ipath/ipath_mr.o
  LD [M]  fs/nfs/nfs_layout_nfsv41_files.o
  CC      fs/proc/mmu.o
  CC      fs/proc/task_mmu.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/graph/nve0.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/mpeg/nv31.o
  CC [M]  drivers/gpu/drm/ttm/ttm_bo_manager.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/mpeg/nv40.o
  CC [M]  drivers/input/mouse/sermouse.o
  CC [M]  drivers/infiniband/hw/ipath/ipath_qp.o
  CC      net/ipv4/ip_sockglue.o
  CC [M]  drivers/input/mouse/synaptics_i2c.o
  CC [M]  drivers/gpu/drm/ttm/ttm_page_alloc_dma.o
  CC [M]  drivers/input/mouse/vsxxxaa.o
  CC      fs/proc/inode.o
  LD      net/ipv6/netfilter/built-in.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/mpeg/nv50.o
  CC [M]  net/ipv6/netfilter/ip6_tables.o
  CC [M]  drivers/infiniband/hw/ipath/ipath_rc.o
  CC [M]  net/ipv6/netfilter/ip6table_filter.o
  LD      drivers/input/mouse/psmouse.o
  LD      drivers/input/mouse/built-in.o
  LD      drivers/input/tablet/built-in.o
  CC [M]  drivers/input/tablet/acecad.o
  CC      fs/proc/root.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/mpeg/nv84.o
  LD [M]  drivers/gpu/drm/ttm/ttm.o
  CC [M]  drivers/input/tablet/aiptek.o
  CC [M]  drivers/infiniband/hw/ipath/ipath_ruc.o
  CC      net/ipv4/inet_hashtables.o
  CC      fs/proc/base.o
  CC [M]  drivers/input/tablet/gtco.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/ppp/nv98.o
  CC [M]  net/ipv6/netfilter/ip6table_mangle.o
  CC [M]  net/ipv6/netfilter/ip6table_raw.o
  CC      net/ipv4/inet_timewait_sock.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/ppp/nvc0.o
  CC [M]  drivers/infiniband/hw/ipath/ipath_sdma.o
  CC [M]  drivers/input/tablet/kbtab.o
  CC [M]  drivers/input/tablet/wacom_wac.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/software/nv04.o
  CC [M]  drivers/infiniband/hw/ipath/ipath_srq.o
  CC [M]  net/ipv6/netfilter/ip6table_security.o
  CC      net/ipv4/inet_connection_sock.o
  CC [M]  drivers/infiniband/hw/ipath/ipath_stats.o
  CC      fs/proc/generic.o
  CC      fs/proc/array.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/software/nv10.o
  CC [M]  net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.o
  CC [M]  drivers/infiniband/hw/ipath/ipath_sysfs.o
  CC [M]  drivers/infiniband/hw/ipath/ipath_uc.o
  CC [M]  net/ipv6/netfilter/nf_conntrack_proto_icmpv6.o
  CC      fs/proc/fd.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/software/nv50.o
  CC [M]  drivers/input/tablet/wacom_sys.o
  CC [M]  net/ipv6/netfilter/nf_defrag_ipv6_hooks.o
  CC      fs/proc/proc_tty.o
  LD      net/key/built-in.o
  CC [M]  net/key/af_key.o
  CC [M]  drivers/infiniband/hw/ipath/ipath_ud.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/software/nvc0.o
  CC      net/ipv4/tcp.o
  CC      net/ipv4/tcp_input.o
  CC      fs/proc/cmdline.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/vp/nv84.o
  LD [M]  drivers/input/tablet/wacom.o
  CC      fs/proc/consoles.o
  LD      drivers/input/touchscreen/built-in.o
  CC [M]  drivers/infiniband/hw/ipath/ipath_user_pages.o
  CC [M]  drivers/input/touchscreen/ad7879.o
  CC [M]  net/ipv6/netfilter/nf_conntrack_reasm.o
  CC      fs/proc/cpuinfo.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/vp/nvc0.o
  CC [M]  drivers/infiniband/hw/ipath/ipath_user_sdma.o
  CC      fs/proc/devices.o
  CC [M]  drivers/input/touchscreen/ad7879-i2c.o
  CC [M]  drivers/gpu/drm/nouveau/core/engine/vp/nve0.o
  CC      fs/proc/interrupts.o
  CC [M]  net/ipv6/netfilter/ip6t_ah.o
  CC [M]  drivers/input/touchscreen/gunze.o
  CC      fs/proc/loadavg.o
  CC [M]  drivers/infiniband/hw/ipath/ipath_verbs_mcast.o
  CC      net/ipv6/addrconf_core.o
  CC [M]  drivers/gpu/drm/nouveau/nouveau_drm.o
  CC [M]  drivers/input/touchscreen/eeti_ts.o
  CC      fs/proc/meminfo.o
  CC [M]  drivers/infiniband/hw/ipath/ipath_verbs.o
  CC [M]  net/ipv6/netfilter/ip6t_eui64.o
  CC [M]  net/ipv6/netfilter/ip6t_frag.o
  CC      net/ipv6/exthdrs_core.o
  CC      fs/proc/stat.o
  CC [M]  drivers/input/touchscreen/elo.o
  CC      fs/proc/uptime.o
  CC [M]  net/ipv6/netfilter/ip6t_ipv6header.o
  CC      net/ipv4/tcp_output.o
  CC [M]  drivers/input/touchscreen/fujitsu_ts.o
  CC      net/ipv6/ip6_checksum.o
  CC [M]  drivers/infiniband/hw/ipath/ipath_iba6110.o
  CC      net/ipv6/output_core.o
  CC      fs/proc/version.o
  CC [M]  drivers/input/touchscreen/inexio.o
  CC [M]  drivers/gpu/drm/nouveau/nouveau_chan.o
  CC      fs/proc/softirqs.o
  CC [M]  net/ipv6/netfilter/ip6t_mh.o
  CC [M]  drivers/input/touchscreen/mcs5000_ts.o
  CC [M]  net/ipv6/netfilter/ip6t_hbh.o
  CC [M]  drivers/infiniband/hw/ipath/ipath_wc_x86_64.o
  CC      fs/proc/namespaces.o
  CC      net/ipv6/protocol.o
  CC [M]  drivers/gpu/drm/nouveau/nouveau_dma.o
  CC [M]  drivers/input/touchscreen/mtouch.o
  CC [M]  drivers/gpu/drm/nouveau/nouveau_fence.o
  LD [M]  drivers/infiniband/hw/ipath/ib_ipath.o
  LD      drivers/infiniband/hw/mlx4/built-in.o
  CC [M]  drivers/infiniband/hw/mlx4/ah.o
  CC      fs/proc/self.o
  CC [M]  net/ipv6/netfilter/ip6t_rt.o
  CC [M]  drivers/input/touchscreen/usbtouchscreen.o
  CC [M]  net/ipv6/netfilter/ip6t_REJECT.o
  CC      fs/proc/proc_sysctl.o
  CC [M]  drivers/gpu/drm/nouveau/nouveau_irq.o
  CC      fs/proc/proc_net.o
  CC [M]  drivers/infiniband/hw/mlx4/cq.o
  CC [M]  drivers/infiniband/hw/mlx4/doorbell.o
  CC      net/ipv4/tcp_timer.o
  CC [M]  drivers/input/touchscreen/penmount.o
  CC [M]  drivers/gpu/drm/nouveau/nouveau_vga.o
  LD [M]  net/ipv6/netfilter/nf_conntrack_ipv6.o
  LD [M]  net/ipv6/netfilter/nf_defrag_ipv6.o
  CC      net/ipv6/ip6_offload.o
  CC      net/ipv6/tcpv6_offload.o
  LD      drivers/infiniband/hw/mthca/built-in.o
  CC [M]  drivers/infiniband/hw/mthca/mthca_main.o
  CC [M]  drivers/input/touchscreen/touchit213.o
  CC [M]  drivers/infiniband/hw/mlx4/mad.o
  CC      fs/proc/kcore.o
  CC [M]  drivers/input/touchscreen/touchright.o
  CC [M]  drivers/gpu/drm/nouveau/nouveau_agp.o
  CC      net/ipv6/udp_offload.o
  CC [M]  drivers/infiniband/hw/mlx4/main.o
  CC [M]  drivers/infiniband/hw/mthca/mthca_cmd.o
  CC [M]  drivers/input/touchscreen/touchwin.o
  CC      net/ipv4/tcp_ipv4.o
  CC      fs/proc/vmcore.o
  CC [M]  drivers/gpu/drm/nouveau/nouveau_ttm.o
  CC [M]  drivers/input/touchscreen/tsc2007.o
  CC      net/ipv6/exthdrs_offload.o
  CC      net/ipv6/inet6_hashtables.o
  CC [M]  drivers/input/touchscreen/wacom_w8001.o
  CC      fs/proc/kmsg.o
  CC [M]  drivers/gpu/drm/nouveau/nouveau_sgdma.o
  CC [M]  drivers/infiniband/hw/mthca/mthca_profile.o
  CC [M]  drivers/infiniband/hw/mthca/mthca_reset.o
  CC      fs/proc/page.o
  CC [M]  drivers/infiniband/hw/mlx4/mr.o
  CC [M]  drivers/input/input-polldev.o
  CC [M]  drivers/input/sparse-keymap.o
  CC [M]  drivers/infiniband/hw/mthca/mthca_allocator.o
  CC [M]  drivers/gpu/drm/nouveau/nouveau_bo.o
  LD      fs/proc/proc.o
  LD      fs/proc/built-in.o
  CC [M]  drivers/infiniband/hw/mlx4/qp.o
  CC      fs/pstore/inode.o
  CC      fs/pstore/platform.o
  CC [M]  net/ipv6/af_inet6.o
  CC      net/ipv4/tcp_minisocks.o
  LD      drivers/input/input-core.o
  LD      drivers/input/built-in.o
  CC [M]  drivers/infiniband/hw/mthca/mthca_eq.o
  CC [M]  drivers/infiniband/hw/mlx4/srq.o
  CC [M]  drivers/gpu/drm/nouveau/nouveau_gem.o
  LD      fs/pstore/pstore.o
  LD      fs/pstore/built-in.o
  CC      fs/quota/dquot.o
drivers/infiniband/hw/mlx4/qp.c: In function ‘build_mlx_header’:
drivers/infiniband/hw/mlx4/qp.c:1752: warning: ‘vlan’ may be used uninitialized in this function
  CC      fs/ramfs/inode.o
  CC      fs/ramfs/file-mmu.o
  CC [M]  drivers/gpu/drm/nouveau/nouveau_prime.o
  CC [M]  drivers/infiniband/hw/mthca/mthca_pd.o
  CC [M]  net/ipv6/anycast.o
  CC [M]  drivers/infiniband/hw/mlx4/mcg.o
  LD      fs/ramfs/ramfs.o
  LD      fs/ramfs/built-in.o
  CC [M]  drivers/infiniband/hw/mlx4/cm.o
  CC [M]  drivers/infiniband/hw/mlx4/alias_GUID.o
  CC [M]  drivers/infiniband/hw/mthca/mthca_cq.o
  CC [M]  drivers/gpu/drm/nouveau/nouveau_abi16.o
  CC      net/ipv4/tcp_cong.o
  CC [M]  drivers/infiniband/hw/mthca/mthca_mr.o
  CC [M]  drivers/infiniband/hw/mthca/mthca_qp.o
  CC [M]  net/ipv6/ip6_output.o
  CC [M]  drivers/infiniband/hw/mlx4/sysfs.o
  CC      fs/quota/quota_v2.o
  CC [M]  net/ipv6/ip6_input.o
  CC [M]  drivers/gpu/drm/nouveau/nv04_fence.o
  CC      fs/quota/quota_tree.o
  CC [M]  net/ipv6/addrconf.o
  LD [M]  drivers/infiniband/hw/mlx4/mlx4_ib.o
  LD      drivers/gpu/drm/via/built-in.o
  CC [M]  drivers/gpu/drm/via/via_irq.o
  CC      net/ipv4/tcp_metrics.o
  CC [M]  drivers/gpu/drm/nouveau/nv10_fence.o
  CC      fs/quota/quota.o
  CC [M]  drivers/gpu/drm/nouveau/nv50_fence.o
  CC [M]  drivers/infiniband/hw/mthca/mthca_av.o
  CC [M]  drivers/gpu/drm/via/via_drv.o
  CC [M]  drivers/gpu/drm/via/via_map.o
  CC      fs/quota/kqid.o
  CC [M]  drivers/gpu/drm/nouveau/nv84_fence.o
  CC [M]  drivers/infiniband/hw/mthca/mthca_mcg.o
  CC [M]  drivers/infiniband/hw/mthca/mthca_mad.o
  CC      fs/quota/compat.o
  CC [M]  drivers/gpu/drm/via/via_mm.o
  CC      fs/quota/netlink.o
  CC      net/ipv4/tcp_fastopen.o
  CC [M]  net/ipv6/addrlabel.o
  CC [M]  drivers/infiniband/hw/mthca/mthca_provider.o
  CC [M]  drivers/gpu/drm/nouveau/nvc0_fence.o
  CC [M]  drivers/gpu/drm/nouveau/nouveau_bios.o
  CC [M]  drivers/gpu/drm/via/via_dma.o
  LD      fs/quota/built-in.o
  CC      net/ipv4/datagram.o
  LD      fs/squashfs/built-in.o
  CC [M]  fs/squashfs/block.o
  CC [M]  fs/squashfs/cache.o
  CC [M]  fs/squashfs/dir.o
  CC [M]  net/ipv6/route.o
  CC [M]  drivers/infiniband/hw/mthca/mthca_memfree.o
  CC [M]  drivers/gpu/drm/via/via_verifier.o
  CC [M]  drivers/infiniband/hw/mthca/mthca_uar.o
  CC [M]  drivers/infiniband/hw/mthca/mthca_srq.o
  CC [M]  fs/squashfs/export.o
  CC [M]  fs/squashfs/file.o
  CC [M]  drivers/gpu/drm/nouveau/nouveau_fbcon.o
  CC      net/ipv4/raw.o
  CC      fs/sysfs/inode.o
  CC [M]  drivers/infiniband/hw/mthca/mthca_catas.o
  LD      drivers/infiniband/hw/nes/built-in.o
  CC [M]  drivers/infiniband/hw/nes/nes.o
  CC [M]  drivers/gpu/drm/via/via_video.o
  CC [M]  fs/squashfs/fragment.o
  CC [M]  drivers/gpu/drm/nouveau/nouveau_display.o
  LD [M]  drivers/infiniband/hw/mthca/ib_mthca.o
  CC      fs/sysfs/file.o
  CC [M]  drivers/gpu/drm/nouveau/nouveau_connector.o
  CC [M]  fs/squashfs/id.o
  CC [M]  net/ipv6/ip6_fib.o
  CC      net/ipv4/udp.o
  CC [M]  drivers/gpu/drm/via/via_dmablit.o
  CC [M]  fs/squashfs/inode.o
  CC      fs/sysfs/dir.o
  CC [M]  drivers/gpu/drm/nouveau/nouveau_dp.o
  CC [M]  drivers/gpu/drm/nouveau/nv04_fbcon.o
  CC [M]  fs/squashfs/namei.o
  CC      fs/sysfs/symlink.o
  LD [M]  drivers/gpu/drm/via/via.o
  CC [M]  drivers/gpu/drm/drm_auth.o
  CC [M]  net/ipv6/ipv6_sockglue.o
  CC [M]  fs/squashfs/super.o
  CC      fs/sysfs/mount.o
  CC [M]  drivers/infiniband/hw/nes/nes_hw.o
  CC [M]  drivers/infiniband/hw/nes/nes_nic.o
  CC [M]  drivers/infiniband/hw/nes/nes_utils.o
  CC [M]  drivers/gpu/drm/nouveau/nv50_fbcon.o
  CC [M]  fs/squashfs/symlink.o
  CC      fs/sysfs/bin.o
  CC [M]  fs/squashfs/decompressor.o
  CC [M]  drivers/gpu/drm/nouveau/nvc0_fbcon.o
  CC [M]  net/ipv6/ndisc.o
  CC [M]  fs/squashfs/zlib_wrapper.o
  CC      fs/sysfs/group.o
  CC      net/ipv4/udplite.o
  LD [M]  fs/squashfs/squashfs.o
  LD      net/llc/built-in.o
  CC [M]  net/llc/llc_core.o
  LD      net/mac80211/built-in.o
  CC [M]  net/mac80211/main.o
  CC [M]  drivers/gpu/drm/nouveau/nouveau_hw.o
  LD      fs/sysfs/built-in.o
  LD      fs/ubifs/built-in.o
  CC [M]  fs/ubifs/shrinker.o
  CC [M]  drivers/infiniband/hw/nes/nes_verbs.o
  CC      net/ipv4/arp.o
  CC [M]  net/llc/llc_input.o
  CC [M]  fs/ubifs/journal.o
  CC [M]  fs/ubifs/file.o
  CC [M]  net/ipv6/udp.o
  CC [M]  net/llc/llc_output.o
  LD      fs/udf/built-in.o
  CC [M]  fs/udf/balloc.o
  CC [M]  fs/ubifs/dir.o
  CC [M]  net/mac80211/status.o
  CC [M]  drivers/gpu/drm/nouveau/nouveau_calc.o
  CC      net/ipv4/icmp.o
  LD [M]  net/llc/llc.o
  CC      net/ipv4/devinet.o
  CC [M]  drivers/infiniband/hw/nes/nes_cm.o
  CC [M]  fs/udf/dir.o
  CC [M]  fs/ubifs/super.o
  CC [M]  drivers/gpu/drm/nouveau/nv04_dac.o
  CC [M]  net/ipv6/udplite.o
  CC [M]  net/mac80211/sta_info.o
  CC [M]  fs/udf/file.o
  CC [M]  drivers/gpu/drm/nouveau/nv04_dfp.o
  CC [M]  net/ipv6/raw.o
  CC [M]  net/ipv6/icmp.o
  CC [M]  fs/ubifs/sb.o
  CC      net/ipv4/af_inet.o
  CC [M]  drivers/infiniband/hw/nes/nes_mgt.o
  CC [M]  fs/udf/ialloc.o
  CC [M]  fs/udf/inode.o
  CC [M]  fs/ubifs/io.o
  CC [M]  drivers/gpu/drm/nouveau/nv04_tv.o
  CC [M]  net/mac80211/wep.o
  CC [M]  drivers/gpu/drm/nouveau/nv17_tv.o
  LD [M]  drivers/infiniband/hw/nes/iw_nes.o
  CC [M]  net/ipv6/mcast.o
  LD      drivers/infiniband/hw/qib/built-in.o
  CC [M]  drivers/infiniband/hw/qib/qib_cq.o
  CC [M]  fs/udf/lowlevel.o
  CC      net/ipv4/igmp.o
  CC [M]  fs/ubifs/tnc.o
  CC [M]  fs/udf/namei.o
  CC [M]  net/mac80211/wpa.o
  LD      fs/xfs/built-in.o
  CC [M]  fs/xfs/xfs_trace.o
  CC [M]  drivers/infiniband/hw/qib/qib_diag.o
  CC [M]  drivers/gpu/drm/nouveau/nv17_tv_modes.o
  CC [M]  fs/udf/partition.o
  CC [M]  net/mac80211/scan.o
  CC [M]  drivers/infiniband/hw/qib/qib_dma.o
  CC [M]  fs/udf/super.o
  CC [M]  drivers/infiniband/hw/qib/qib_driver.o
  CC [M]  fs/ubifs/master.o
  CC [M]  drivers/gpu/drm/nouveau/nv04_crtc.o
  CC [M]  net/ipv6/reassembly.o
  CC      net/ipv4/fib_frontend.o
  CC [M]  fs/ubifs/scan.o
  CC [M]  net/mac80211/offchannel.o
  CC [M]  drivers/infiniband/hw/qib/qib_eeprom.o
  CC [M]  fs/udf/truncate.o
  CC [M]  fs/ubifs/replay.o
  CC [M]  drivers/gpu/drm/nouveau/nv04_display.o
  CC [M]  fs/udf/symlink.o
  CC [M]  drivers/infiniband/hw/qib/qib_file_ops.o
  CC [M]  net/ipv6/tcp_ipv6.o
  CC      net/ipv4/fib_semantics.o
  CC [M]  fs/ubifs/log.o
  CC [M]  fs/xfs/xfs_aops.o
  CC [M]  fs/udf/directory.o
  CC [M]  net/mac80211/ht.o
  CC [M]  drivers/gpu/drm/nouveau/nv04_cursor.o
  CC [M]  fs/udf/misc.o
  CC [M]  fs/ubifs/commit.o
  CC [M]  drivers/gpu/drm/nouveau/nv50_display.o
  CC [M]  fs/udf/udftime.o
  CC [M]  drivers/infiniband/hw/qib/qib_fs.o
  CC [M]  net/ipv6/exthdrs.o
  CC      net/ipv4/fib_trie.o
  CC [M]  net/mac80211/agg-tx.o
  CC [M]  fs/udf/unicode.o
  CC [M]  fs/xfs/xfs_bit.o
  CC [M]  fs/ubifs/gc.o
  CC [M]  drivers/infiniband/hw/qib/qib_init.o
  CC [M]  fs/xfs/xfs_buf.o
  LD [M]  fs/udf/udf.o
  CC [M]  drivers/infiniband/hw/qib/qib_intr.o
  CC [M]  fs/ubifs/orphan.o
  CC [M]  drivers/gpu/drm/nouveau/nouveau_pm.o
  CC [M]  net/ipv6/datagram.o
  CC [M]  net/ipv6/ip6_flowlabel.o
  CC [M]  net/mac80211/agg-rx.o
  CC [M]  drivers/infiniband/hw/qib/qib_keys.o
  CC [M]  fs/ubifs/budget.o
  CC      net/ipv4/inet_fragment.o
  CC [M]  drivers/gpu/drm/nouveau/nouveau_volt.o
  CC [M]  fs/xfs/xfs_dfrag.o
  CC [M]  drivers/infiniband/hw/qib/qib_mad.o
  CC [M]  drivers/infiniband/hw/qib/qib_mmap.o
  CC [M]  fs/ubifs/find.o
  CC [M]  net/ipv6/inet6_connection_sock.o
  CC [M]  net/mac80211/vht.o
  CC [M]  drivers/gpu/drm/nouveau/nouveau_perf.o
  CC [M]  fs/xfs/xfs_discard.o
  CC [M]  fs/xfs/xfs_error.o
  CC      net/ipv4/ping.o
  CC [M]  net/mac80211/ibss.o
  CC [M]  fs/ubifs/tnc_commit.o
  CC [M]  fs/ubifs/compress.o
  CC [M]  drivers/gpu/drm/nouveau/nv04_pm.o
  CC [M]  net/ipv6/sysctl_net_ipv6.o
  CC [M]  fs/xfs/xfs_export.o
  CC [M]  fs/xfs/xfs_extent_busy.o
  CC [M]  drivers/infiniband/hw/qib/qib_mr.o
  CC [M]  fs/ubifs/lpt.o
  CC [M]  drivers/gpu/drm/nouveau/nv40_pm.o
  CC [M]  net/ipv6/ip6mr.o
  CC      net/ipv4/sysctl_net_ipv4.o
  CC      net/ipv4/proc.o
  CC [M]  net/mac80211/iface.o
  CC [M]  drivers/infiniband/hw/qib/qib_pcie.o
  CC [M]  fs/xfs/xfs_file.o
  CC [M]  drivers/gpu/drm/nouveau/nv50_pm.o
  CC [M]  drivers/infiniband/hw/qib/qib_pio_copy.o
  CC      net/ipv4/fib_rules.o
  CC [M]  drivers/infiniband/hw/qib/qib_qp.o
  CC [M]  fs/ubifs/lprops.o
  CC [M]  fs/ubifs/recovery.o
  CC [M]  net/ipv6/xfrm6_policy.o
  CC [M]  net/mac80211/rate.o
  CC [M]  fs/xfs/xfs_filestream.o
  CC [M]  drivers/infiniband/hw/qib/qib_qsfp.o
  CC      net/ipv4/ipmr.o
  CC [M]  drivers/gpu/drm/nouveau/nva3_pm.o
  CC [M]  fs/ubifs/ioctl.o
  CC [M]  fs/ubifs/lpt_commit.o
  CC [M]  net/ipv6/xfrm6_state.o
  CC [M]  net/ipv6/xfrm6_input.o
  CC [M]  net/mac80211/michael.o
  CC [M]  drivers/infiniband/hw/qib/qib_rc.o
  CC [M]  net/mac80211/tkip.o
  CC [M]  fs/xfs/xfs_fsops.o
  CC [M]  net/mac80211/aes_ccm.o
  CC [M]  drivers/gpu/drm/nouveau/nvc0_pm.o
  CC [M]  fs/ubifs/tnc_misc.o
  CC [M]  drivers/gpu/drm/nouveau/nouveau_mem.o
  CC [M]  net/ipv6/xfrm6_output.o
  CC      net/ipv4/syncookies.o
  CC [M]  fs/xfs/xfs_globals.o
  CC [M]  drivers/infiniband/hw/qib/qib_ruc.o
  CC [M]  fs/ubifs/xattr.o
  CC [M]  drivers/infiniband/hw/qib/qib_sdma.o
  CC [M]  net/mac80211/aes_cmac.o
  CC [M]  fs/xfs/xfs_icache.o
  CC [M]  drivers/gpu/drm/nouveau/nouveau_ioc32.o
  CC [M]  fs/ubifs/debug.o
  CC [M]  net/ipv6/netfilter.o
  CC [M]  net/ipv6/fib6_rules.o
  CC [M]  net/mac80211/cfg.o
  CC [M]  drivers/infiniband/hw/qib/qib_srq.o
  CC      net/ipv4/inet_lro.o
  CC [M]  drivers/gpu/drm/nouveau/nouveau_acpi.o
  CC [M]  drivers/infiniband/hw/qib/qib_sysfs.o
  CC [M]  drivers/infiniband/hw/qib/qib_twsi.o
  CC [M]  fs/xfs/xfs_ioctl.o
  CC [M]  drivers/gpu/drm/nouveau/nouveau_backlight.o
  CC [M]  net/ipv6/proc.o
  CC [M]  drivers/gpu/drm/drm_buffer.o
  CC [M]  drivers/infiniband/hw/qib/qib_tx.o
  CC      net/ipv4/netfilter.o
  LD [M]  fs/ubifs/ubifs.o
  CC [M]  fs/xfs/xfs_iomap.o
  LD [M]  drivers/gpu/drm/nouveau/nouveau.o
  CC [M]  net/ipv6/syncookies.o
  CC      net/netfilter/core.o
  CC      net/netlabel/netlabel_user.o
  CC [M]  net/mac80211/rx.o
  CC [M]  drivers/infiniband/hw/qib/qib_uc.o
  CC [M]  drivers/gpu/drm/drm_bufs.o
  CC [M]  fs/xfs/xfs_iops.o
  LD      net/ipv4/netfilter/built-in.o
  CC [M]  net/ipv4/netfilter/nf_conntrack_l3proto_ipv4.o
  CC      net/netlabel/netlabel_kapi.o
  CC [M]  drivers/infiniband/hw/qib/qib_ud.o
  CC [M]  net/ipv6/ah6.o
  CC      net/netfilter/nf_log.o
  CC [M]  fs/xfs/xfs_itable.o
  CC [M]  drivers/infiniband/hw/qib/qib_user_pages.o
  CC [M]  drivers/gpu/drm/drm_cache.o
  CC [M]  net/ipv4/netfilter/nf_conntrack_proto_icmp.o
  CC      net/netlabel/netlabel_domainhash.o
  CC [M]  net/ipv6/esp6.o
  CC      net/netfilter/nf_queue.o
  CC [M]  net/mac80211/spectmgmt.o
  CC [M]  drivers/infiniband/hw/qib/qib_user_sdma.o
  CC [M]  net/ipv4/netfilter/nf_defrag_ipv4.o
  CC [M]  drivers/gpu/drm/drm_context.o
  CC [M]  fs/xfs/xfs_message.o
  CC      net/netlabel/netlabel_addrlist.o
  CC [M]  net/mac80211/tx.o
  CC      net/netfilter/nf_sockopt.o
  CC [M]  net/ipv6/ipcomp6.o
  CC [M]  drivers/infiniband/hw/qib/qib_verbs_mcast.o
  CC [M]  fs/xfs/xfs_mru_cache.o
  CC [M]  drivers/gpu/drm/drm_dma.o
  CC      net/netlabel/netlabel_mgmt.o
  CC [M]  net/ipv4/netfilter/ip_tables.o
  CC      net/netfilter/x_tables.o
  CC [M]  drivers/infiniband/hw/qib/qib_iba7220.o
  CC [M]  fs/xfs/xfs_super.o
  CC [M]  drivers/gpu/drm/drm_drv.o
  CC      net/netlabel/netlabel_unlabeled.o
  CC [M]  net/mac80211/key.o
  CC [M]  net/ipv6/xfrm6_tunnel.o
  CC [M]  drivers/gpu/drm/drm_fops.o
  CC      net/netfilter/xt_tcpudp.o
  CC      net/netlabel/netlabel_cipso_v4.o
  CC [M]  fs/xfs/xfs_xattr.o
  CC [M]  net/ipv6/tunnel6.o
  CC [M]  net/mac80211/util.o
  CC [M]  net/ipv4/netfilter/iptable_filter.o
  CC [M]  fs/xfs/xfs_rename.o
  CC [M]  drivers/infiniband/hw/qib/qib_sd7220.o
  CC [M]  drivers/gpu/drm/drm_gem.o
  CC [M]  net/netfilter/nfnetlink.o
  CC [M]  net/ipv4/netfilter/iptable_mangle.o
  LD      net/netlabel/built-in.o
  CC [M]  drivers/gpu/drm/drm_ioctl.o
  CC [M]  net/ipv6/xfrm6_mode_transport.o
  CC [M]  fs/xfs/xfs_utils.o
  CC [M]  net/ipv4/netfilter/iptable_raw.o
  CC [M]  drivers/infiniband/hw/qib/qib_iba7322.o
  CC [M]  net/netfilter/nf_conntrack_core.o
  CC [M]  net/netfilter/nf_conntrack_standalone.o
  CC [M]  net/ipv6/xfrm6_mode_tunnel.o
  CC [M]  drivers/gpu/drm/drm_irq.o
  CC [M]  fs/xfs/xfs_vnodeops.o
  CC [M]  net/ipv4/netfilter/iptable_security.o
  CC [M]  net/mac80211/wme.o
  CC [M]  net/ipv6/xfrm6_mode_ro.o
  CC [M]  net/ipv4/netfilter/ipt_ah.o
  CC [M]  net/mac80211/event.o
  CC [M]  fs/xfs/kmem.o
  CC [M]  drivers/gpu/drm/drm_lock.o
  CC [M]  net/mac80211/chan.o
  CC [M]  net/mac80211/trace.o
  CC [M]  net/ipv6/xfrm6_mode_beet.o
  CC [M]  net/ipv4/netfilter/ipt_CLUSTERIP.o
  CC [M]  fs/xfs/uuid.o
  CC [M]  net/ipv6/mip6.o
  CC [M]  drivers/infiniband/hw/qib/qib_verbs.o
  CC [M]  drivers/gpu/drm/drm_memory.o
  CC [M]  fs/xfs/xfs_alloc.o
  CC [M]  net/ipv4/netfilter/ipt_ECN.o
  CC [M]  net/netfilter/nf_conntrack_expect.o
  CC [M]  net/netfilter/nf_conntrack_helper.o
  CC [M]  net/ipv6/sit.o
  CC [M]  drivers/gpu/drm/drm_proc.o
  CC [M]  net/ipv4/netfilter/ipt_REJECT.o
  CC [M]  drivers/gpu/drm/drm_stub.o
  CC [M]  drivers/infiniband/hw/qib/qib_iba6120.o
  CC [M]  drivers/gpu/drm/drm_vm.o
  CC [M]  net/netfilter/nf_conntrack_proto.o
  CC [M]  fs/xfs/xfs_alloc_btree.o
  CC [M]  net/ipv4/netfilter/ipt_ULOG.o
  CC [M]  net/ipv6/ip6_tunnel.o
  CC      drivers/iommu/iommu.o
  CC [M]  fs/xfs/xfs_attr.o
  CC [M]  drivers/gpu/drm/drm_agpsupport.o
  CC [M]  net/ipv4/netfilter/arp_tables.o
  CC [M]  net/netfilter/nf_conntrack_l3proto_generic.o
  CC      drivers/iommu/amd_iommu.o
  CC [M]  drivers/infiniband/hw/qib/qib_wc_x86_64.o
  CC [M]  drivers/gpu/drm/drm_scatter.o
  LD [M]  drivers/infiniband/hw/qib/ib_qib.o
  CC [M]  net/netfilter/nf_conntrack_proto_generic.o
  CC [M]  net/mac80211/mlme.o
  LD      drivers/infiniband/ulp/ipoib/built-in.o
  CC [M]  drivers/infiniband/ulp/ipoib/ipoib_main.o
  LD      net/ipv6/built-in.o
  CC [M]  fs/xfs/xfs_attr_leaf.o
  LD [M]  net/ipv6/ipv6.o
  CC [M]  fs/xfs/xfs_bmap.o
  CC [M]  drivers/gpu/drm/drm_pci.o
  CC [M]  net/netfilter/nf_conntrack_proto_tcp.o
  CC [M]  net/ipv4/netfilter/arpt_mangle.o
  CC      drivers/iommu/amd_iommu_init.o
  CC [M]  drivers/gpu/drm/drm_platform.o
  CC [M]  net/ipv4/netfilter/arptable_filter.o
  CC [M]  drivers/infiniband/ulp/ipoib/ipoib_ib.o
  CC [M]  net/netfilter/nf_conntrack_proto_udp.o
  CC [M]  net/netfilter/nf_conntrack_extend.o
  LD [M]  net/ipv4/netfilter/nf_conntrack_ipv4.o
  CC      net/ipv4/tcp_cubic.o
  CC [M]  drivers/gpu/drm/drm_sysfs.o
  CC [M]  net/mac80211/led.o
  CC      fs/eventpoll.o
  LD      drivers/iommu/built-in.o

WARNING: drivers/iommu/built-in.o(.text+0x639c): Section mismatch in reference from the function iommu_init_pci() to the function .init.text:amd_iommu_erratum_746_workaround() The function iommu_init_pci() references
the function __init amd_iommu_erratum_746_workaround().
This is often because iommu_init_pci lacks a __init
annotation or the annotation of amd_iommu_erratum_746_workaround is wrong.

  CC      fs/anon_inodes.o
  CC [M]  drivers/infiniband/ulp/ipoib/ipoib_multicast.o
  CC [M]  net/netfilter/nf_conntrack_acct.o
  CC [M]  fs/xfs/xfs_bmap_btree.o
  CC      net/ipv4/cipso_ipv4.o
  CC [M]  net/netfilter/nf_conntrack_ecache.o
  CC [M]  drivers/gpu/drm/drm_hashtab.o
  CC [M]  net/netfilter/nf_conntrack_h323_main.o
  CC [M]  drivers/infiniband/ulp/ipoib/ipoib_verbs.o
  CC [M]  fs/xfs/xfs_btree.o
  CC [M]  net/mac80211/pm.o
  CC [M]  net/mac80211/rc80211_minstrel.o
  CC [M]  net/mac80211/rc80211_minstrel_ht.o
  CC      net/ipv4/xfrm4_policy.o
  CC [M]  drivers/infiniband/ulp/ipoib/ipoib_vlan.o
  CC [M]  drivers/gpu/drm/drm_mm.o
  CC [M]  drivers/gpu/drm/drm_crtc.o
  CC [M]  drivers/gpu/drm/drm_modes.o
  CC      net/ipv4/xfrm4_state.o
  CC [M]  drivers/infiniband/ulp/ipoib/ipoib_ethtool.o
  LD [M]  net/mac80211/mac80211.o
  CC [M]  net/netfilter/nf_conntrack_h323_asn1.o
  CC [M]  drivers/infiniband/ulp/ipoib/ipoib_netlink.o
  CC [M]  drivers/infiniband/ulp/ipoib/ipoib_cm.o
  CC [M]  fs/xfs/xfs_da_btree.o
  CC [M]  fs/xfs/xfs_dir2.o
  CC      net/ipv4/xfrm4_input.o
  CC [M]  fs/xfs/xfs_dir2_block.o
  CC [M]  net/netfilter/nfnetlink_queue_core.o
  CC [M]  net/netfilter/nfnetlink_log.o
  CC      fs/signalfd.o
  CC      net/ipv4/xfrm4_output.o
  CC      fs/timerfd.o
  CC [M]  drivers/gpu/drm/drm_edid.o
  CC      fs/eventfd.o
  CC [M]  drivers/infiniband/ulp/ipoib/ipoib_fs.o
  CC [M]  net/ipv4/ipip.o
  CC [M]  fs/xfs/xfs_dir2_data.o
  CC [M]  net/netfilter/nf_conntrack_proto_dccp.o
  CC [M]  fs/xfs/xfs_dir2_leaf.o
  LD      drivers/infiniband/ulp/iser/built-in.o
  CC [M]  drivers/infiniband/ulp/iser/iser_verbs.o
  LD [M]  drivers/infiniband/ulp/ipoib/ib_ipoib.o
  CC [M]  drivers/infiniband/ulp/iser/iser_initiator.o
  CC [M]  drivers/gpu/drm/drm_info.o
  CC [M]  net/netfilter/nf_conntrack_proto_gre.o
  CC [M]  net/netfilter/nf_conntrack_proto_sctp.o
  CC [M]  net/ipv4/ah4.o
  CC [M]  fs/xfs/xfs_dir2_node.o
  CC [M]  net/ipv4/esp4.o
  CC [M]  drivers/gpu/drm/drm_debugfs.o
  CC [M]  drivers/infiniband/ulp/iser/iser_memory.o
  CC [M]  drivers/infiniband/ulp/iser/iscsi_iser.o
  CC      fs/aio.o
  CC      fs/locks.o
  CC [M]  net/netfilter/nf_conntrack_proto_udplite.o
  CC [M]  drivers/gpu/drm/drm_encoder_slave.o
  CC [M]  net/netfilter/nf_conntrack_netlink.o
  LD [M]  drivers/infiniband/ulp/iser/ib_iser.o
  CC [M]  net/ipv4/ipcomp.o
  LD      drivers/infiniband/ulp/srp/built-in.o
  CC [M]  drivers/infiniband/ulp/srp/ib_srp.o
  CC [M]  fs/xfs/xfs_dir2_sf.o
  CC [M]  fs/xfs/xfs_ialloc.o
  CC [M]  drivers/gpu/drm/drm_trace_points.o
  CC [M]  net/ipv4/xfrm4_tunnel.o
  CC [M]  net/netfilter/nf_conntrack_amanda.o
  CC [M]  net/netfilter/nf_conntrack_ftp.o
  LD [M]  net/netfilter/nf_conntrack_h323.o
  LD      drivers/irqchip/built-in.o
  CC [M]  fs/xfs/xfs_ialloc_btree.o
  CC [M]  drivers/gpu/drm/drm_global.o
  CC [M]  net/netfilter/nf_conntrack_irc.o
  CC [M]  net/ipv4/xfrm4_mode_beet.o
  CC [M]  net/ipv4/tunnel4.o
  CC      net/netlink/af_netlink.o
  CC [M]  drivers/gpu/drm/drm_prime.o
  CC [M]  fs/xfs/xfs_inode.o
  CC [M]  drivers/gpu/drm/drm_ioc32.o
  CC [M]  drivers/gpu/drm/ati_pcigart.o
  CC [M]  drivers/gpu/drm/drm_fb_helper.o
  CC [M]  net/netfilter/nf_conntrack_broadcast.o
  CC [M]  net/netfilter/nf_conntrack_netbios_ns.o
  CC [M]  net/ipv4/xfrm4_mode_transport.o
  CC [M]  net/ipv4/xfrm4_mode_tunnel.o
  CC [M]  net/ipv4/inet_diag.o
  CC      net/netlink/genetlink.o
  CC [M]  fs/xfs/xfs_log_recover.o
  CC [M]  fs/xfs/xfs_mount.o
  CC [M]  net/netfilter/nf_conntrack_snmp.o
  CC [M]  drivers/gpu/drm/drm_crtc_helper.o
  CC [M]  net/netfilter/nf_conntrack_pptp.o
  CC [M]  net/netfilter/nf_conntrack_sane.o
  CC      fs/compat.o
  LD      net/netlink/built-in.o
  CC [M]  net/ipv4/tcp_diag.o
  CC [M]  net/netfilter/nf_conntrack_sip.o
  CC [M]  net/netfilter/nf_conntrack_tftp.o
  CC      net/packet/af_packet.o
  CC [M]  fs/xfs/xfs_trans.o
  CC [M]  net/ipv4/tcp_bic.o
  CC [M]  drivers/gpu/drm/drm_dp_helper.o
  CC [M]  net/ipv4/tcp_westwood.o
  CC [M]  net/ipv4/tcp_highspeed.o
  CC [M]  fs/xfs/xfs_log.o
  CC [M]  fs/xfs/xfs_log_cil.o
  LD      drivers/gpu/drm/built-in.o
  LD [M]  drivers/gpu/drm/drm_kms_helper.o
  LD [M]  drivers/gpu/drm/drm.o
  CC [M]  net/netfilter/nf_tproxy_core.o
  LD      drivers/gpu/built-in.o
  LD      drivers/isdn/capi/built-in.o
  CC [M]  drivers/isdn/capi/kcapi.o
  CC [M]  drivers/isdn/capi/capiutil.o
  CC [M]  net/ipv4/tcp_hybla.o
  CC [M]  net/ipv4/tcp_htcp.o
  CC      drivers/leds/led-core.o
  LD      drivers/lguest/built-in.o
  CC [M]  net/netfilter/xt_mark.o
  LD      drivers/isdn/divert/built-in.o
  CC [M]  drivers/isdn/divert/isdn_divert.o
  LD      net/packet/built-in.o
  LD      drivers/isdn/gigaset/built-in.o
  CC [M]  drivers/isdn/gigaset/bas-gigaset.o
  CC [M]  net/ipv4/tcp_vegas.o
  CC [M]  drivers/isdn/gigaset/isocdata.o
  CC [M]  drivers/isdn/capi/capilib.o
  CC      drivers/leds/led-class.o
  CC [M]  net/netfilter/xt_connmark.o
  CC      drivers/leds/led-triggers.o
  CC [M]  fs/xfs/xfs_buf_item.o
  CC [M]  drivers/isdn/capi/kcapi_proc.o
  CC [M]  drivers/isdn/divert/divert_procfs.o
  CC [M]  fs/xfs/xfs_extfree_item.o
  CC [M]  net/netfilter/xt_AUDIT.o
  CC [M]  net/ipv4/tcp_veno.o
  CC [M]  drivers/isdn/capi/capi.o
  CC [M]  drivers/leds/leds-lp3944.o
  CC [M]  drivers/isdn/gigaset/common.o
  CC [M]  drivers/isdn/divert/divert_init.o
  CC [M]  drivers/isdn/gigaset/interface.o
  CC [M]  fs/xfs/xfs_inode_item.o
  CC [M]  drivers/leds/leds-clevo-mail.o
  LD [M]  drivers/isdn/divert/dss1_divert.o
  CC [M]  fs/xfs/xfs_trans_ail.o
  CC [M]  net/ipv4/tcp_scalable.o
  CC [M]  net/netfilter/xt_CHECKSUM.o
  CC [M]  drivers/leds/ledtrig-timer.o
  CC [M]  drivers/isdn/capi/capidrv.o
  CC [M]  drivers/leds/ledtrig-heartbeat.o
  CC [M]  drivers/leds/ledtrig-backlight.o
  CC      drivers/macintosh/mac_hid.o
  CC [M]  drivers/isdn/gigaset/proc.o
  CC [M]  net/netfilter/xt_CLASSIFY.o
  CC [M]  net/ipv4/tcp_lp.o
  CC [M]  net/ipv4/tcp_yeah.o
  LD      drivers/macintosh/built-in.o
  CC [M]  drivers/isdn/gigaset/ev-layer.o
  CC [M]  drivers/leds/ledtrig-default-on.o
  CC [M]  fs/xfs/xfs_trans_buf.o
  CC [M]  fs/xfs/xfs_trans_extfree.o
  LD      drivers/leds/built-in.o
  CC [M]  fs/xfs/xfs_trans_inode.o
  CC [M]  net/netfilter/xt_CONNSECMARK.o
  CC [M]  net/netfilter/xt_DSCP.o
  CC [M]  net/ipv4/tcp_illinois.o
  CC [M]  net/netfilter/xt_HL.o
  CC [M]  net/netfilter/xt_LED.o
  CC [M]  fs/xfs/xfs_dquot.o
  LD      drivers/isdn/hardware/avm/built-in.o
  CC [M]  drivers/isdn/hardware/avm/b1pci.o
  LD [M]  drivers/isdn/capi/kernelcapi.o
  CC [M]  fs/xfs/xfs_dquot_item.o
  CC [M]  fs/xfs/xfs_trans_dquot.o
  CC [M]  drivers/isdn/gigaset/asyncdata.o
  LD      net/ipv4/built-in.o
  CC [M]  drivers/isdn/gigaset/i4l.o
  CC [M]  net/netfilter/xt_NFLOG.o
  CC      drivers/md/md.o
  CC [M]  drivers/isdn/hardware/avm/b1.o
  CC      drivers/md/bitmap.o
  CC [M]  net/netfilter/xt_NFQUEUE.o
  CC [M]  fs/xfs/xfs_qm_syscalls.o
  CC [M]  fs/xfs/xfs_qm_bhv.o
  CC [M]  drivers/isdn/gigaset/ser-gigaset.o
  CC [M]  drivers/isdn/gigaset/usb-gigaset.o
  CC [M]  fs/xfs/xfs_qm.o
  CC [M]  drivers/isdn/hardware/avm/b1dma.o
  CC [M]  fs/xfs/xfs_quotaops.o
  LD      drivers/media/common/b2c2/built-in.o
  CC [M]  net/netfilter/xt_RATEEST.o
  LD      drivers/media/common/saa7146/built-in.o
  LD      drivers/media/common/siano/built-in.o
  LD      drivers/media/common/built-in.o
  LD      drivers/media/firewire/built-in.o
  LD      drivers/media/i2c/soc_camera/built-in.o
  LD      drivers/media/i2c/built-in.o
  LD      drivers/media/mmc/siano/built-in.o
  LD      drivers/media/mmc/built-in.o
  LD      drivers/media/parport/built-in.o
  LD [M]  drivers/isdn/gigaset/gigaset.o
  LD      drivers/media/pci/b2c2/built-in.o
  LD [M]  drivers/isdn/gigaset/usb_gigaset.o
  LD      drivers/media/pci/ddbridge/built-in.o
  LD [M]  drivers/isdn/gigaset/bas_gigaset.o
  LD      drivers/media/pci/dm1105/built-in.o
  LD [M]  drivers/isdn/gigaset/ser_gigaset.o
  LD      drivers/media/pci/mantis/built-in.o
  LD      drivers/media/pci/ngene/built-in.o
  LD      drivers/media/platform/davinci/built-in.o
  LD      drivers/media/platform/built-in.o
  LD      drivers/media/pci/pluto2/built-in.o
  CC      fs/compat_ioctl.o
  CC      fs/binfmt_misc.o
  LD      drivers/media/pci/pt1/built-in.o
  LD      drivers/media/pci/saa7146/built-in.o
  LD      drivers/media/pci/ttpci/built-in.o
  LD      drivers/media/pci/built-in.o
  LD      drivers/media/rc/keymaps/built-in.o
  LD      drivers/media/rc/built-in.o
  LD      drivers/media/tuners/built-in.o
  LD      drivers/media/usb/b2c2/built-in.o
  LD      drivers/media/usb/dvb-usb/built-in.o
  LD      drivers/media/usb/dvb-usb-v2/built-in.o
  LD      drivers/isdn/hardware/mISDN/built-in.o
  LD      drivers/media/usb/s2255/built-in.o
  CC [M]  drivers/isdn/hardware/mISDN/hfcpci.o
  LD      drivers/media/usb/siano/built-in.o
  LD      drivers/media/usb/stkwebcam/built-in.o
  LD      drivers/media/usb/ttusb-budget/built-in.o
  LD      drivers/media/usb/ttusb-dec/built-in.o
  LD      drivers/media/usb/zr364xx/built-in.o
  LD      drivers/media/usb/built-in.o
  LD      drivers/media/built-in.o
  CC [M]  drivers/isdn/hardware/mISDN/hfcmulti.o
  CC [M]  drivers/isdn/hardware/avm/b1pcmcia.o
  CC [M]  fs/xfs/xfs_acl.o
  CC [M]  net/netfilter/xt_SECMARK.o
drivers/isdn/hardware/mISDN/hfcpci.c: In function ‘hfcpci_softirq’:
drivers/isdn/hardware/mISDN/hfcpci.c:2298: warning: ignoring return value of ‘driver_for_each_device’, declared with attribute warn_unused_result
  CC [M]  net/netfilter/xt_TPROXY.o
  CC [M]  fs/xfs/xfs_stats.o
  CC [M]  drivers/isdn/hardware/avm/avm_cs.o
  CC [M]  drivers/isdn/hardware/avm/t1pci.o
  CC [M]  drivers/isdn/hardware/avm/c4.o
  LD      net/phonet/built-in.o
  CC [M]  net/phonet/pn_dev.o
  CC [M]  net/netfilter/xt_TCPMSS.o
  CC [M]  fs/xfs/xfs_sysctl.o
  LD      net/rds/built-in.o
  CC [M]  net/rds/af_rds.o
  CC [M]  net/rds/bind.o
  CC [M]  drivers/md/linear.o
  CC [M]  fs/xfs/xfs_ioctl32.o
  CC [M]  net/phonet/pn_netlink.o
  CC [M]  drivers/isdn/hardware/mISDN/hfcsusb.o
  CC [M]  net/netfilter/xt_TCPOPTSTRIP.o
  CC [M]  drivers/isdn/hardware/mISDN/avmfritz.o
  CC [M]  drivers/md/raid0.o
  CC [M]  net/rds/cong.o
  CC [M]  net/phonet/socket.o
  LD [M]  fs/xfs/xfs.o
  CC [M]  net/rds/connection.o
  CC [M]  net/netfilter/xt_TRACE.o
  CC      fs/binfmt_script.o
  CC [M]  drivers/md/raid1.o
  CC [M]  drivers/md/raid10.o
  CC      fs/binfmt_elf.o
  CC [M]  net/netfilter/xt_cluster.o
  CC [M]  net/netfilter/xt_comment.o
  CC [M]  drivers/isdn/hardware/mISDN/speedfax.o
  CC [M]  net/phonet/datagram.o
  CC [M]  net/rds/info.o
  CC [M]  net/rds/message.o
  CC [M]  net/netfilter/xt_connbytes.o
  CC [M]  drivers/isdn/hardware/mISDN/mISDNinfineon.o
  CC [M]  net/phonet/sysctl.o
  CC      fs/compat_binfmt_elf.o
  CC [M]  net/phonet/af_phonet.o
  CC [M]  net/rds/recv.o
  CC [M]  net/netfilter/xt_connlimit.o
  LD      drivers/memstick/built-in.o
  LD      drivers/memstick/core/built-in.o
  CC [M]  drivers/memstick/core/memstick.o
  CC [M]  net/phonet/pep.o
  CC [M]  drivers/isdn/hardware/mISDN/w6692.o
  CC [M]  drivers/md/dm-log-userspace-base.o
  CC      fs/posix_acl.o
  CC [M]  net/rds/send.o
  CC [M]  drivers/memstick/core/mspro_block.o
  CC [M]  net/netfilter/xt_conntrack.o
  CC      fs/xattr_acl.o
  CC      fs/generic_acl.o
  CC [M]  net/phonet/pep-gprs.o
  CC [M]  drivers/isdn/hardware/mISDN/netjet.o
  LD      drivers/memstick/host/built-in.o
  CC [M]  drivers/memstick/host/tifm_ms.o
  CC [M]  drivers/md/dm-log-userspace-transfer.o
  CC [M]  drivers/md/dm-raid1.o
  CC      fs/coredump.o
  CC [M]  net/rds/stats.o
  LD [M]  net/phonet/phonet.o
  LD [M]  net/phonet/pn_pep.o
  CC [M]  net/rds/sysctl.o
  CC [M]  net/netfilter/xt_dccp.o
  CC [M]  drivers/memstick/host/jmb38x_ms.o
  CC      fs/dcookies.o
  CC [M]  drivers/isdn/hardware/mISDN/mISDNipac.o
  CC [M]  fs/mbcache.o
  CC [M]  net/netfilter/xt_dscp.o
  CC [M]  net/rds/threads.o
  CC [M]  drivers/md/dm-uevent.o
  LD      net/rfkill/built-in.o
  CC [M]  net/rfkill/core.o
  CC      net/sched/sch_generic.o
  CC      net/sched/sch_mq.o
  LD      fs/built-in.o
  CC [M]  net/netfilter/xt_ecn.o
  CC [M]  drivers/md/dm.o
  CC      net/sched/sch_api.o
  CC [M]  net/rfkill/input.o
  CC [M]  net/rds/transport.o
  CC [M]  net/rds/loop.o
  CC [M]  net/netfilter/xt_esp.o
  LD [M]  net/rfkill/rfkill.o
  CC [M]  drivers/md/dm-table.o
  CC [M]  drivers/isdn/hardware/mISDN/mISDNisar.o
  CC [M]  net/rds/page.o
  CC      net/sched/sch_blackhole.o
  CC      net/sched/cls_api.o
  CC [M]  net/netfilter/xt_hashlimit.o
  CC [M]  drivers/md/dm-target.o
  LD      drivers/isdn/hisax/built-in.o
  CC [M]  drivers/isdn/hisax/config.o
  CC [M]  drivers/isdn/hisax/isdnl1.o
  CC [M]  net/rds/rdma.o
  CC      net/sched/act_api.o
  CC [M]  net/netfilter/xt_helper.o
  CC [M]  drivers/md/dm-linear.o
  LD      drivers/isdn/hardware/built-in.o
  LD      drivers/isdn/hysdn/built-in.o
  CC [M]  drivers/isdn/hysdn/hysdn_procconf.o
  LD      drivers/isdn/i4l/built-in.o
  CC [M]  drivers/isdn/i4l/isdn_net.o
  CC [M]  drivers/isdn/hisax/tei.o
  CC      net/sched/sch_fifo.o
  CC [M]  net/rds/rdma_transport.o
  CC      net/sched/cls_cgroup.o
  CC [M]  drivers/md/dm-stripe.o
  CC [M]  net/netfilter/xt_hl.o
  CC [M]  drivers/isdn/hisax/isdnl2.o
  CC [M]  net/rds/ib.o
  CC [M]  drivers/isdn/hysdn/hysdn_proclog.o
  CC [M]  drivers/isdn/hysdn/boardergo.o
  CC [M]  drivers/md/dm-ioctl.o
  CC      net/sched/ematch.o
  CC [M]  drivers/isdn/hysdn/hysdn_boot.o
  CC [M]  drivers/isdn/i4l/isdn_tty.o
  CC [M]  net/netfilter/xt_iprange.o
  CC [M]  net/netfilter/xt_length.o
  CC [M]  drivers/isdn/hysdn/hysdn_sched.o
  CC [M]  drivers/isdn/hisax/isdnl3.o
  CC [M]  net/rds/ib_cm.o
  CC [M]  net/rds/ib_recv.o
  CC [M]  net/sched/act_police.o
  CC [M]  drivers/isdn/hysdn/hysdn_net.o
  CC [M]  net/netfilter/xt_limit.o
  CC [M]  drivers/md/dm-io.o
  CC [M]  drivers/isdn/hisax/lmgr.o
  CC [M]  drivers/isdn/hysdn/hysdn_init.o
  CC [M]  net/netfilter/xt_mac.o
  CC [M]  drivers/isdn/hysdn/hycapi.o
  CC [M]  net/sched/act_gact.o
  CC [M]  drivers/md/dm-kcopyd.o
  CC [M]  drivers/isdn/i4l/isdn_v110.o
  CC [M]  net/rds/ib_ring.o
  CC [M]  drivers/isdn/hisax/q931.o
  CC [M]  drivers/isdn/hisax/callc.o
  CC [M]  net/netfilter/xt_multiport.o
  CC [M]  net/sched/act_mirred.o
  LD [M]  drivers/isdn/hysdn/hysdn.o
  CC [M]  drivers/isdn/hisax/fsm.o
  CC [M]  drivers/md/dm-sysfs.o
  CC [M]  net/rds/ib_send.o
  CC [M]  drivers/isdn/i4l/isdn_common.o
  CC [M]  net/netfilter/xt_osf.o
  CC [M]  net/sched/act_ipt.o
  CC [M]  drivers/md/dm-path-selector.o
  CC [M]  net/sched/act_nat.o
  LD      net/sctp/built-in.o
  CC [M]  net/sctp/sm_statetable.o
  CC [M]  drivers/isdn/hisax/l3dss1.o
  CC [M]  net/netfilter/xt_owner.o
  CC [M]  net/netfilter/xt_physdev.o
  CC [M]  net/rds/ib_stats.o
  CC [M]  drivers/md/dm-mpath.o
  CC [M]  net/sctp/sm_statefuns.o
  CC [M]  net/sched/act_pedit.o
  CC [M]  drivers/md/dm-snap.o
  CC [M]  net/netfilter/xt_pkttype.o
  CC [M]  net/rds/ib_sysctl.o
  CC [M]  net/sched/act_simple.o
  CC [M]  net/sched/act_skbedit.o
  CC [M]  drivers/isdn/hisax/l3ni1.o
  CC [M]  net/netfilter/xt_policy.o
  CC [M]  net/rds/ib_rdma.o
  CC [M]  drivers/isdn/i4l/isdn_ppp.o
  CC [M]  drivers/md/dm-exception-store.o
  CC [M]  net/sctp/sm_sideeffect.o
  CC [M]  net/rds/iw.o
  CC [M]  drivers/isdn/hisax/l3_1tr6.o
  CC [M]  net/sched/sch_cbq.o
  CC [M]  net/netfilter/xt_quota.o
  CC [M]  net/sched/sch_htb.o
  CC [M]  drivers/md/dm-snap-transient.o
  CC [M]  net/rds/iw_cm.o
  CC [M]  net/netfilter/xt_rateest.o
  CC [M]  drivers/isdn/hisax/teles3.o
  CC [M]  net/sctp/protocol.o
  CC [M]  drivers/isdn/i4l/isdn_audio.o
  CC [M]  drivers/md/dm-snap-persistent.o
  CC [M]  net/netfilter/xt_realm.o
  CC [M]  drivers/md/raid5.o
  CC [M]  net/rds/iw_recv.o
  CC [M]  net/sched/sch_hfsc.o
  CC [M]  net/sched/sch_red.o
  CC [M]  drivers/isdn/i4l/isdn_ttyfax.o
  CC [M]  drivers/isdn/hisax/isac.o
  CC [M]  net/netfilter/xt_recent.o
  CC [M]  net/sctp/endpointola.o
  CC [M]  net/rds/iw_ring.o
  CC [M]  net/rds/iw_send.o
  CC [M]  drivers/isdn/hisax/arcofi.o
  CC [M]  net/sched/sch_gred.o
  CC [M]  net/netfilter/xt_sctp.o
  CC [M]  drivers/isdn/i4l/isdnhdlc.o
  CC [M]  net/sctp/associola.o
  CC [M]  net/sched/sch_ingress.o
  CC [M]  drivers/isdn/hisax/hscx.o
  LD [M]  drivers/isdn/i4l/isdn.o
  LD      net/sunrpc/built-in.o
  CC [M]  net/sunrpc/clnt.o
  CC [M]  net/rds/iw_stats.o
  CC [M]  net/netfilter/xt_socket.o
  CC [M]  net/netfilter/xt_state.o
  CC [M]  net/sched/sch_dsmark.o
  CC [M]  drivers/isdn/hisax/telespci.o
  CC [M]  net/sctp/transport.o
  CC [M]  net/rds/iw_sysctl.o
  CC [M]  net/rds/iw_rdma.o
  CC [M]  net/netfilter/xt_statistic.o
  CC [M]  net/sched/sch_sfq.o
  CC [M]  net/netfilter/xt_string.o
  CC [M]  net/sctp/chunk.o
  CC [M]  drivers/isdn/hisax/s0box.o
  CC [M]  net/sunrpc/xprt.o
  CC [M]  drivers/isdn/hisax/avm_a1p.o
  CC [M]  drivers/md/faulty.o
  CC [M]  net/rds/tcp.o
  CC [M]  net/netfilter/xt_tcpmss.o
  CC [M]  net/sctp/sm_make_chunk.o
  CC [M]  net/sched/sch_tbf.o
  LD [M]  drivers/md/dm-mod.o
  CC [M]  drivers/md/dm-crypt.o
  CC [M]  drivers/isdn/hisax/avm_pci.o
  LD      drivers/message/fusion/built-in.o
  CC [M]  drivers/message/fusion/mptbase.o
  CC [M]  net/netfilter/xt_time.o
  CC [M]  net/rds/tcp_connect.o
  CC [M]  net/sunrpc/socklib.o
  CC [M]  net/sched/sch_teql.o
  CC [M]  drivers/isdn/hisax/elsa.o
  CC [M]  drivers/md/dm-delay.o
  CC [M]  net/rds/tcp_listen.o
  CC [M]  net/sunrpc/xprtsock.o
  CC [M]  net/sctp/ulpevent.o
  CC [M]  net/netfilter/xt_u32.o
  CC [M]  net/rds/tcp_recv.o
  LD [M]  drivers/md/dm-multipath.o
  CC [M]  drivers/md/dm-round-robin.o
  CC [M]  net/sched/sch_prio.o
  LD      net/netfilter/ipvs/built-in.o
  CC [M]  net/netfilter/ipvs/ip_vs_conn.o
  CC [M]  net/sctp/inqueue.o
  CC [M]  drivers/md/dm-queue-length.o
  CC [M]  net/sched/sch_multiq.o
  CC [M]  net/rds/tcp_send.o
  CC [M]  drivers/isdn/hisax/diva.o
  CC [M]  net/sunrpc/sched.o
  CC [M]  drivers/md/dm-service-time.o
  CC [M]  net/sctp/outqueue.o
  CC [M]  net/sched/sch_atm.o
  LD [M]  drivers/md/dm-snapshot.o
  LD [M]  drivers/md/dm-mirror.o
  CC [M]  drivers/md/dm-log.o
  CC [M]  net/rds/tcp_stats.o
  CC [M]  net/netfilter/ipvs/ip_vs_core.o
  CC [M]  drivers/isdn/hisax/ipacx.o
  CC [M]  net/sctp/ulpqueue.o
  LD [M]  net/rds/rds.o
  CC [M]  drivers/message/fusion/mptscsih.o
  LD [M]  net/rds/rds_rdma.o
  CC [M]  net/sunrpc/auth.o
  LD [M]  net/rds/rds_tcp.o
  CC [M]  drivers/md/dm-region-hash.o
  CC [M]  net/sched/sch_netem.o
  CC      net/unix/af_unix.o
  CC [M]  drivers/isdn/hisax/sedlbauer.o
  CC [M]  net/sctp/command.o
net/unix/af_unix.c: In function ‘unix_bind’:
net/unix/af_unix.c:895: warning: ‘path.dentry’ may be used uninitialized in this function
net/unix/af_unix.c:895: warning: ‘path.mnt’ may be used uninitialized in this function
  LD [M]  drivers/md/dm-log-userspace.o
  CC [M]  drivers/md/dm-zero.o
  CC [M]  net/netfilter/ipvs/ip_vs_ctl.o
  CC [M]  net/sched/sch_drr.o
  CC [M]  net/sunrpc/auth_null.o
  LD      drivers/md/md-mod.o
  LD [M]  drivers/md/raid456.o
  LD      drivers/md/built-in.o
  CC [M]  net/netfilter/ipvs/ip_vs_sched.o
  CC [M]  net/sctp/tsnmap.o
  CC [M]  drivers/isdn/hisax/isar.o
  CC [M]  drivers/message/fusion/mptspi.o
  CC [M]  net/sched/cls_u32.o
  CC [M]  net/sunrpc/auth_unix.o
  CC      net/unix/garbage.o
  CC [M]  net/sctp/bind_addr.o
  CC      net/unix/sysctl_net_unix.o
  CC [M]  net/sunrpc/auth_generic.o
  CC [M]  net/sunrpc/svc.o
  CC [M]  drivers/message/fusion/mptfc.o
  CC [M]  net/sched/cls_route.o
  CC [M]  net/netfilter/ipvs/ip_vs_xmit.o
  CC [M]  drivers/isdn/hisax/nj_s.o
  CC [M]  net/sctp/socket.o
  LD      net/unix/unix.o
  LD      net/unix/built-in.o
  CC [M]  net/sctp/primitive.o
  CC [M]  net/sctp/output.o
  CC [M]  net/sched/cls_fw.o
  CC [M]  net/sctp/input.o
  CC [M]  drivers/isdn/hisax/netjet.o
  CC [M]  net/sunrpc/svcsock.o
  CC [M]  net/netfilter/ipvs/ip_vs_app.o
  CC [M]  drivers/message/fusion/mptsas.o
  CC [M]  drivers/message/fusion/mptctl.o
  CC [M]  net/sched/cls_rsvp.o
  CC [M]  drivers/isdn/hisax/nj_u.o
  CC [M]  drivers/message/fusion/mptlan.o
  CC [M]  net/netfilter/ipvs/ip_vs_sync.o
  CC [M]  net/sunrpc/svcauth.o
  CC [M]  net/sched/cls_tcindex.o
  CC [M]  net/sctp/debug.o
  CC [M]  drivers/isdn/hisax/icc.o
  CC [M]  drivers/isdn/hisax/hfc_pci.o
  CC [M]  net/sunrpc/svcauth_unix.o
  CC [M]  net/sunrpc/addr.o
  CC [M]  net/sctp/ssnmap.o
  LD      drivers/message/built-in.o
  CC [M]  net/sctp/auth.o
  CC [M]  net/sched/cls_rsvp6.o
  CC [M]  net/netfilter/ipvs/ip_vs_est.o
  CC [M]  net/netfilter/ipvs/ip_vs_proto.o
  CC [M]  net/sched/cls_basic.o
  CC [M]  net/sched/cls_flow.o
  CC [M]  drivers/isdn/hisax/hfc_sx.o
  LD      drivers/mfd/built-in.o
  CC [M]  drivers/mfd/sm501.o
  CC [M]  net/sctp/proc.o
  CC [M]  net/sctp/sysctl.o
  CC [M]  net/sunrpc/rpcb_clnt.o
  CC [M]  net/netfilter/ipvs/ip_vs_pe.o
  CC [M]  net/sunrpc/timer.o
  CC [M]  net/sched/em_cmp.o
  CC [M]  net/sctp/ipv6.o
  CC [M]  net/sched/em_nbyte.o
  CC [M]  net/sched/em_u32.o
  CC [M]  drivers/mfd/mfd-core.o
  CC [M]  net/netfilter/ipvs/ip_vs_proto_tcp.o
  CC [M]  drivers/isdn/hisax/niccy.o
  CC [M]  drivers/isdn/hisax/bkm_a4t.o
  CC [M]  net/sunrpc/xdr.o
  CC      drivers/misc/kgdbts.o
  CC [M]  net/sched/em_meta.o
  CC [M]  drivers/mfd/lpc_sch.o
  LD [M]  net/sctp/sctp.o
  CC [M]  drivers/mfd/lpc_ich.o
  CC [M]  net/netfilter/ipvs/ip_vs_proto_udp.o
  CC [M]  net/netfilter/ipvs/ip_vs_proto_ah_esp.o
  LD      drivers/misc/carma/built-in.o
  LD      drivers/misc/cb710/built-in.o
  CC [M]  drivers/misc/cb710/core.o
  CC [M]  net/sunrpc/sunrpc_syms.o
  CC [M]  net/sunrpc/cache.o
  LD      drivers/misc/eeprom/built-in.o
  CC [M]  drivers/misc/eeprom/at24.o
  CC [M]  net/netfilter/ipvs/ip_vs_nfct.o
  CC [M]  drivers/isdn/hisax/jade.o
  CC [M]  net/sched/em_text.o
  CC [M]  drivers/isdn/hisax/bkm_a8.o
  CC [M]  drivers/misc/eeprom/eeprom.o
  CC [M]  net/sunrpc/rpc_pipe.o
  CC [M]  drivers/misc/cb710/sgbuf2.o
  CC [M]  net/sunrpc/svc_xprt.o
  CC [M]  net/netfilter/ipvs/ip_vs_rr.o
  CC [M]  net/sunrpc/backchannel_rqst.o
  LD      net/sched/built-in.o
  LD      net/wimax/built-in.o
  CC [M]  net/wimax/id-table.o
  CC [M]  drivers/misc/eeprom/max6875.o
  LD [M]  drivers/misc/cb710/cb710.o
  CC [M]  net/wimax/op-msg.o
  CC [M]  drivers/misc/eeprom/eeprom_93cx6.o
  CC [M]  net/netfilter/ipvs/ip_vs_wrr.o
  CC [M]  drivers/isdn/hisax/gazel.o
  CC [M]  net/wimax/op-reset.o
  LD      drivers/misc/lis3lv02d/built-in.o
  LD      drivers/isdn/mISDN/built-in.o
  CC [M]  drivers/isdn/mISDN/l1oip_core.o
  LD      drivers/misc/ti-st/built-in.o
  CC [M]  drivers/misc/ics932s401.o
  CC [M]  drivers/isdn/mISDN/l1oip_codec.o
  CC [M]  net/sunrpc/bc_svc.o
  CC [M]  net/netfilter/ipvs/ip_vs_lc.o
  CC [M]  drivers/misc/tifm_core.o
  CC [M]  drivers/misc/tifm_7xx1.o
  CC [M]  net/wimax/op-rfkill.o
  CC [M]  net/sunrpc/stats.o
  CC [M]  drivers/isdn/hisax/w6692.o
  CC [M]  net/sunrpc/sysctl.o
  CC [M]  net/netfilter/ipvs/ip_vs_wlc.o
  CC [M]  drivers/isdn/mISDN/core.o
  CC [M]  drivers/isdn/mISDN/fsm.o
  CC [M]  drivers/misc/ioc4.o
  CC [M]  net/wimax/op-state-get.o
  CC [M]  drivers/isdn/mISDN/socket.o
  CC      net/wireless/wext-core.o
  CC [M]  net/netfilter/ipvs/ip_vs_lblc.o
  LD      net/sunrpc/auth_gss/built-in.o
  CC [M]  net/sunrpc/auth_gss/auth_gss.o
  CC [M]  drivers/isdn/hisax/enternow_pci.o
  CC [M]  drivers/misc/enclosure.o
  CC [M]  drivers/misc/hpilo.o
  CC [M]  net/wimax/stack.o
  LD      drivers/mmc/card/built-in.o
  CC [M]  drivers/mmc/card/block.o
  CC [M]  drivers/isdn/hisax/amd7930_fn.o
  CC [M]  drivers/isdn/mISDN/clock.o
  CC [M]  net/netfilter/ipvs/ip_vs_lblcr.o
  CC      net/wireless/wext-proc.o
  CC [M]  drivers/misc/isl29003.o
  CC [M]  net/sunrpc/auth_gss/gss_generic_token.o
  CC [M]  net/wimax/debugfs.o
  CC [M]  drivers/misc/tsl2550.o
  CC [M]  drivers/isdn/hisax/st5481_init.o
  CC [M]  drivers/isdn/mISDN/hwchannel.o
  CC      net/wireless/wext-spy.o
  CC [M]  net/netfilter/ipvs/ip_vs_dh.o
  CC [M]  drivers/mmc/card/queue.o
  CC [M]  net/sunrpc/auth_gss/gss_mech_switch.o
  LD [M]  net/wimax/wimax.o
  CC [M]  net/sunrpc/auth_gss/svcauth_gss.o
  CC [M]  drivers/misc/vmw_balloon.o
  CC [M]  drivers/isdn/hisax/st5481_usb.o
  CC [M]  net/netfilter/ipvs/ip_vs_sh.o
  CC [M]  drivers/mmc/card/sdio_uart.o
  CC      net/wireless/wext-priv.o
  LD      drivers/misc/built-in.o
  CC [M]  net/wireless/core.o
  CC [M]  drivers/isdn/mISDN/stack.o
  CC [M]  net/sunrpc/auth_gss/gss_krb5_mech.o
  CC [M]  net/sunrpc/auth_gss/gss_krb5_seal.o
  CC [M]  net/sunrpc/auth_gss/gss_krb5_unseal.o
  CC [M]  drivers/isdn/hisax/st5481_d.o
  CC [M]  net/wireless/sysfs.o
  CC [M]  net/netfilter/ipvs/ip_vs_sed.o
  CC [M]  net/sunrpc/auth_gss/gss_krb5_seqnum.o
  LD [M]  drivers/mmc/card/mmc_block.o
  LD      drivers/mmc/core/built-in.o
  CC [M]  drivers/mmc/core/core.o
  CC [M]  drivers/isdn/mISDN/layer1.o
  CC [M]  net/netfilter/ipvs/ip_vs_nq.o
  CC [M]  net/sunrpc/auth_gss/gss_krb5_wrap.o
  CC [M]  net/sunrpc/auth_gss/gss_krb5_crypto.o
  CC [M]  drivers/isdn/hisax/st5481_b.o
  CC [M]  drivers/mmc/core/bus.o
  CC [M]  drivers/mmc/core/host.o
  LD [M]  net/netfilter/ipvs/ip_vs.o
  LD      net/netfilter/netfilter.o
  CC [M]  net/wireless/radiotap.o
  LD [M]  net/netfilter/nfnetlink_queue.o
  LD [M]  net/netfilter/nf_conntrack.o
  LD      net/netfilter/built-in.o
  CC [M]  net/wireless/util.o
  CC [M]  drivers/isdn/mISDN/layer2.o
  CC [M]  net/wireless/reg.o
  CC [M]  drivers/isdn/hisax/sedlbauer_cs.o
  CC [M]  net/sunrpc/auth_gss/gss_krb5_keys.o
  CC      drivers/mtd/mtdcore.o
  CC [M]  drivers/isdn/hisax/elsa_cs.o
  CC [M]  drivers/mmc/core/mmc.o
  LD [M]  net/sunrpc/auth_gss/auth_rpcgss.o
  LD [M]  net/sunrpc/auth_gss/rpcsec_gss_krb5.o
  CC [M]  drivers/mmc/core/mmc_ops.o
  LD      net/sunrpc/xprtrdma/built-in.o
  CC [M]  net/sunrpc/xprtrdma/svc_rdma.o
  CC [M]  drivers/isdn/hisax/avma1_cs.o
  CC      drivers/mtd/mtdsuper.o
  CC [M]  drivers/mmc/core/sd.o
  CC [M]  net/sunrpc/xprtrdma/svc_rdma_transport.o
  CC      drivers/net/Space.o
  CC [M]  drivers/isdn/hisax/teles_cs.o
  CC      drivers/net/loopback.o
  CC [M]  drivers/isdn/mISDN/tei.o
  CC [M]  net/wireless/scan.o
  CC      drivers/mtd/mtdconcat.o
  LD [M]  drivers/isdn/hisax/hisax_st5481.o
  CC [M]  drivers/isdn/hisax/hfc4s8s_l1.o
  CC [M]  drivers/isdn/hisax/hisax_isac.o
  CC [M]  drivers/mmc/core/sd_ops.o
  LD      drivers/net/bonding/built-in.o
  CC [M]  drivers/net/bonding/bond_main.o
  CC [M]  net/sunrpc/xprtrdma/svc_rdma_marshal.o
  CC      drivers/mtd/mtdpart.o
  CC [M]  drivers/isdn/mISDN/timerdev.o
  CC [M]  drivers/mmc/core/sdio.o
  CC [M]  drivers/mmc/core/sdio_ops.o
  CC [M]  drivers/isdn/hisax/hisax_fcpcipnp.o
  CC      drivers/mtd/cmdlinepart.o
  CC [M]  net/sunrpc/xprtrdma/svc_rdma_sendto.o
  CC      drivers/mmc/host/sdhci-pci-data.o
  CC [M]  drivers/isdn/mISDN/dsp_core.o
  CC [M]  drivers/mmc/core/sdio_bus.o
  CC [M]  net/wireless/nl80211.o
  CC      drivers/mtd/chips/chipreg.o
  CC [M]  net/sunrpc/xprtrdma/svc_rdma_recvfrom.o
  CC [M]  drivers/mmc/core/sdio_cis.o
  LD [M]  drivers/isdn/hisax/hisax.o
  CC [M]  drivers/mmc/core/sdio_io.o
  CC [M]  drivers/net/bonding/bond_3ad.o
  CC [M]  drivers/mmc/host/sdhci.o
  CC [M]  drivers/mtd/chips/cfi_probe.o
  CC [M]  drivers/isdn/mISDN/dsp_cmx.o
  CC [M]  drivers/mmc/host/sdhci-pci.o
  CC [M]  drivers/mmc/core/sdio_irq.o
  CC [M]  net/sunrpc/xprtrdma/transport.o
  CC [M]  drivers/net/bonding/bond_alb.o
  CC [M]  drivers/mtd/chips/cfi_util.o
  CC [M]  drivers/isdn/mISDN/dsp_tones.o
  CC [M]  drivers/net/bonding/bond_sysfs.o
  CC [M]  drivers/mmc/core/quirks.o
  CC [M]  net/sunrpc/xprtrdma/rpc_rdma.o
  CC [M]  drivers/mmc/core/slot-gpio.o
  CC [M]  drivers/mtd/chips/cfi_cmdset_0020.o
  CC [M]  drivers/isdn/mISDN/dsp_dtmf.o
  CC [M]  drivers/mtd/chips/cfi_cmdset_0002.o
  CC [M]  drivers/mmc/core/debugfs.o
  CC [M]  drivers/net/bonding/bond_debugfs.o

In file included from drivers/mtd/chips/cfi_cmdset_0002.c:36:
include/linux/of_platform.h:107: warning: ‘struct of_device_id’ declared inside parameter list include/linux/of_platform.h:107: warning: its scope is only this definition or declaration, which is probably not what you want include/linux/of_platform.h:107: warning: ‘struct device_node’ declared inside parameter list drivers/mtd/chips/cfi_cmdset_0002.c: In function ‘cfi_cmdset_0002’:
drivers/mtd/chips/cfi_cmdset_0002.c:504: warning: unused variable ‘np’
CC [M] drivers/mmc/host/tifm_sd.o
drivers/mtd/chips/cfi_cmdset_0002.c: At top level:
drivers/mtd/chips/cfi_cmdset_0002.c:2279: warning: ‘cfi_ppb_lock’ defined but not used drivers/mtd/chips/cfi_cmdset_0002.c:2285: warning: ‘cfi_ppb_unlock’ defined but not used drivers/mtd/chips/cfi_cmdset_0002.c:2382: warning: ‘cfi_ppb_is_locked’ defined but not used

  CC [M]  net/sunrpc/xprtrdma/verbs.o
  CC [M]  drivers/isdn/mISDN/dsp_audio.o
  LD [M]  drivers/mmc/core/mmc_core.o
  CC [M]  drivers/isdn/mISDN/dsp_blowfish.o
  CC [M]  drivers/net/bonding/bond_procfs.o
  CC [M]  drivers/mmc/host/sdricoh_cs.o
  CC [M]  drivers/mmc/host/cb710-mmc.o
  LD [M]  drivers/net/bonding/bonding.o
  CC [M]  net/wireless/mlme.o
  LD      drivers/net/can/sja1000/built-in.o
  CC [M]  drivers/net/can/sja1000/sja1000.o
  CC [M]  drivers/isdn/mISDN/dsp_pipeline.o
  CC [M]  drivers/isdn/mISDN/dsp_hwec.o
  LD [M]  net/sunrpc/xprtrdma/xprtrdma.o
  LD      drivers/net/can/softing/built-in.o
  LD [M]  net/sunrpc/xprtrdma/svcrdma.o
  LD      drivers/nfc/built-in.o
  CC [M]  net/wireless/ibss.o
  LD [M]  net/sunrpc/sunrpc.o
  CC [M]  net/wireless/sme.o
  CC [M]  drivers/mtd/chips/cfi_cmdset_0001.o
  CC [M]  drivers/mmc/host/via-sdmmc.o
  CC [M]  drivers/mmc/host/sdhci-pltfm.o
  LD [M]  drivers/isdn/mISDN/mISDN_core.o
  LD [M]  drivers/isdn/mISDN/mISDN_dsp.o
  CC [M]  drivers/net/can/sja1000/sja1000_platform.o
  LD [M]  drivers/isdn/mISDN/l1oip.o
  LD      drivers/isdn/built-in.o
  CC [M]  drivers/net/can/sja1000/ems_pci.o
  LD      drivers/mtd/devices/built-in.o
  CC [M]  drivers/mtd/devices/pmc551.o
  LD      drivers/mtd/lpddr/built-in.o
  LD      drivers/mmc/host/built-in.o
  CC [M]  drivers/mtd/lpddr/qinfo_probe.o
  LD      drivers/mmc/built-in.o
  CC [M]  drivers/mtd/lpddr/lpddr_cmds.o
  CC [M]  drivers/mtd/devices/mtdram.o
  CC [M]  net/wireless/chan.o
  CC [M]  net/wireless/ethtool.o
  LD      drivers/parport/built-in.o
  CC [M]  drivers/parport/share.o
  CC [M]  drivers/parport/ieee1284.o
  CC [M]  drivers/mtd/devices/block2mtd.o
  CC [M]  drivers/net/can/sja1000/kvaser_pci.o
  CC [M]  drivers/mtd/chips/gen_probe.o
  CC [M]  drivers/mtd/chips/jedec_probe.o
  CC [M]  drivers/mtd/chips/map_ram.o
  CC [M]  drivers/mtd/chips/map_rom.o
  CC [M]  net/wireless/mesh.o
  CC [M]  drivers/parport/ieee1284_ops.o
  CC [M]  net/wireless/ap.o
  LD      drivers/net/can/usb/built-in.o
  CC [M]  drivers/net/can/usb/ems_usb.o
  CC [M]  drivers/net/can/vcan.o
  CC [M]  drivers/mtd/chips/map_absent.o
  CC [M]  net/wireless/trace.o
  LD      drivers/mtd/chips/built-in.o
  CC [M]  drivers/parport/procfs.o
  CC      drivers/net/dsa/mv88e6060.o
  CC      drivers/mtd/maps/map_funcs.o
  CC [M]  drivers/mtd/maps/esb2rom.o
  CC      drivers/net/dsa/mv88e6xxx.o
  CC [M]  drivers/parport/daisy.o
  CC [M]  drivers/net/can/dev.o
  CC [M]  net/wireless/wext-compat.o
  CC [M]  drivers/mtd/maps/ck804xrom.o
  CC [M]  drivers/mtd/maps/sc520cdp.o
  CC      drivers/net/dsa/mv88e6123_61_65.o
  CC      drivers/net/dsa/mv88e6131.o
  CC [M]  drivers/parport/probe.o
  CC [M]  drivers/mtd/maps/netsc520.o
  CC [M]  drivers/mtd/maps/ts5500_flash.o
  CC [M]  drivers/mtd/maps/pci.o
  CC [M]  drivers/parport/parport_pc.o
  CC      drivers/pci/access.o
  CC      drivers/pcmcia/ds.o
  LD      drivers/net/dsa/mv88e6xxx_drv.o
  LD      drivers/net/can/built-in.o
  LD [M]  drivers/net/can/can-dev.o
  LD      drivers/net/dsa/built-in.o
  LD      drivers/pinctrl/built-in.o
  LD      drivers/net/fddi/built-in.o
  LD      drivers/net/ethernet/3com/built-in.o
  CC [M]  drivers/net/ethernet/3com/3c589_cs.o
  CC [M]  drivers/parport/parport_serial.o
  CC [M]  drivers/mtd/maps/scb2_flash.o
  LD      drivers/mtd/maps/built-in.o
  LD      drivers/mtd/nand/built-in.o
  LD      drivers/mtd/onenand/built-in.o
  CC [M]  drivers/mtd/nand/nand_base.o
  CC [M]  drivers/net/ethernet/3com/3c574_cs.o
  CC [M]  drivers/net/ethernet/3com/3c59x.o
  CC      drivers/pci/bus.o
  CC      drivers/pci/probe.o
  CC      drivers/pcmcia/pcmcia_resource.o
  CC [M]  drivers/parport/parport_cs.o
  CC      drivers/pcmcia/cistpl.o
  LD [M]  drivers/parport/parport.o
  CC      drivers/pcmcia/pcmcia_cis.o
  CC [M]  net/wireless/wext-sme.o
  CC      drivers/pci/host-bridge.o
  CC      drivers/pci/remove.o
  CC [M]  drivers/mtd/nand/nand_bbt.o
  CC      drivers/pci/pci.o
  CC      drivers/pci/pci-driver.o
  CC      drivers/pcmcia/cs.o
  CC [M]  drivers/net/ethernet/3com/typhoon.o
  LD      drivers/platform/x86/built-in.o
  CC [M]  drivers/platform/x86/asus-laptop.o
  CC      drivers/pnp/core.o
  CC [M]  drivers/mtd/nand/nand_ecc.o
  CC [M]  net/wireless/lib80211.o
  CC      drivers/pnp/card.o
  CC      drivers/pcmcia/socket_sysfs.o
  CC [M]  drivers/platform/x86/msi-laptop.o
  CC [M]  drivers/platform/x86/compal-laptop.o
  CC [M]  drivers/mtd/nand/nand_ids.o
  CC [M]  net/wireless/lib80211_crypt_wep.o
  CC      drivers/pcmcia/cardbus.o
  CC      drivers/pnp/driver.o
  CC      drivers/pci/search.o
  LD      drivers/net/ethernet/8390/built-in.o
  CC [M]  drivers/net/ethernet/8390/ne2k-pci.o
  CC      drivers/pnp/resource.o
  CC [M]  drivers/mtd/nand/diskonchip.o
  CC      drivers/pcmcia/rsrc_mgr.o
  CC [M]  net/wireless/lib80211_crypt_ccmp.o
  CC      drivers/pcmcia/rsrc_nonstatic.o
  CC      drivers/pci/pci-sysfs.o
  CC [M]  drivers/platform/x86/dell-laptop.o
  CC [M]  drivers/platform/x86/dell-wmi.o
  CC [M]  drivers/pcmcia/yenta_socket.o
  CC      drivers/pnp/manager.o
  CC      drivers/pci/rom.o
  CC [M]  net/wireless/lib80211_crypt_tkip.o
  CC [M]  drivers/net/ethernet/8390/8390.o
  CC [M]  drivers/platform/x86/acer-wmi.o
  CC      drivers/pci/setup-res.o
  CC      drivers/pnp/support.o
  CC [M]  drivers/mtd/nand/nandsim.o
  CC [M]  drivers/mtd/nand/alauda.o
  LD      net/wireless/built-in.o
  LD [M]  net/wireless/cfg80211.o
  CC      net/xfrm/xfrm_policy.o
  CC      drivers/pnp/interface.o
  CC      drivers/pci/irq.o
  CC [M]  drivers/platform/x86/hp-wmi.o
  CC [M]  drivers/net/ethernet/8390/axnet_cs.o
  CC      drivers/pnp/quirks.o
  CC [M]  drivers/net/ethernet/8390/pcnet_cs.o
  CC [M]  drivers/pcmcia/pd6729.o
  CC      drivers/pci/vpd.o
  LD [M]  drivers/mtd/nand/nand.o
  LD      drivers/mtd/tests/built-in.o
  LD      drivers/mtd/ubi/built-in.o
  CC [M]  drivers/mtd/ubi/vtbl.o
  CC      drivers/pnp/system.o
  CC [M]  drivers/platform/x86/sony-laptop.o
  CC      drivers/pnp/pnpacpi/core.o
  CC      drivers/pci/setup-bus.o
  LD      drivers/pcmcia/pcmcia_core.o
  LD      drivers/pcmcia/pcmcia.o
  LD      drivers/pcmcia/pcmcia_rsrc.o
  LD      drivers/pcmcia/built-in.o
  CC      drivers/power/power_supply_core.o
  CC [M]  drivers/mtd/ubi/vmt.o
  CC [M]  drivers/mtd/ubi/upd.o
  LD      drivers/net/ethernet/adaptec/built-in.o
  CC [M]  drivers/net/ethernet/adaptec/starfire.o
  CC      drivers/pnp/pnpacpi/rsparser.o
  CC      drivers/power/power_supply_sysfs.o
  CC      drivers/power/power_supply_leds.o
  CC [M]  drivers/mtd/ubi/build.o
  LD      drivers/net/ieee802154/built-in.o
  CC [M]  drivers/power/bq27x00_battery.o
  CC [M]  drivers/net/ieee802154/fakehard.o
  CC      drivers/pci/proc.o
  LD      drivers/pnp/pnpacpi/pnp.o
  LD      drivers/pnp/pnpacpi/built-in.o
  LD      drivers/pnp/pnp.o
  LD      drivers/pnp/built-in.o
  CC      drivers/pci/slot.o
  CC      net/xfrm/xfrm_state.o
  CC [M]  drivers/power/max17040_battery.o
  CC [M]  drivers/platform/x86/thinkpad_acpi.o
  CC [M]  drivers/mtd/ubi/cdev.o
  CC [M]  drivers/platform/x86/hdaps.o
  CC [M]  drivers/mtd/redboot.o
  LD      drivers/net/ethernet/alteon/built-in.o
  CC [M]  drivers/net/ethernet/alteon/acenic.o
  CC      drivers/pci/quirks.o
  LD      drivers/power/power_supply.o
  LD      drivers/power/built-in.o
  CC      net/xfrm/xfrm_hash.o
  CC      net/xfrm/xfrm_input.o
  CC      net/xfrm/xfrm_output.o
  LD      drivers/pps/clients/built-in.o
  LD      drivers/pps/generators/built-in.o
  CC [M]  drivers/pps/pps.o
  CC [M]  drivers/mtd/ubi/kapi.o
  CC [M]  drivers/pps/kapi.o
  CC [M]  drivers/mtd/ubi/eba.o
  CC [M]  drivers/pps/sysfs.o
  CC [M]  drivers/mtd/ubi/io.o
  CC      drivers/pci/hotplug/acpiphp_core.o
  CC      drivers/pci/pcie/aspm.o
  CC      net/xfrm/xfrm_sysctl.o
  LD      drivers/net/ethernet/amd/built-in.o
  CC [M]  drivers/net/ethernet/amd/amd8111e.o
  LD      drivers/pps/built-in.o
  LD [M]  drivers/pps/pps_core.o
  LD      drivers/ptp/built-in.o
  CC [M]  drivers/ptp/ptp_clock.o
  CC [M]  drivers/platform/x86/fujitsu-laptop.o
  CC [M]  drivers/ptp/ptp_chardev.o
  CC      net/xfrm/xfrm_replay.o
  CC      drivers/pci/pcie/portdrv_core.o
  CC [M]  drivers/mtd/ubi/wl.o
  CC      drivers/pci/hotplug/acpiphp_glue.o
  CC [M]  drivers/ptp/ptp_sysfs.o
  LD      drivers/pwm/built-in.o
  CC      drivers/regulator/core.o
  CC [M]  drivers/platform/x86/panasonic-laptop.o
  LD [M]  drivers/ptp/ptp.o
  CC [M]  drivers/platform/x86/wmi.o
  CC      net/xfrm/xfrm_proc.o
  CC      net/xfrm/xfrm_algo.o
  CC      drivers/pci/pcie/portdrv_pci.o
  CC      drivers/rtc/rtc-lib.o
  CC [M]  drivers/platform/x86/topstar-laptop.o
  CC      drivers/pci/hotplug/pci_hotplug_core.o
  CC [M]  drivers/net/ethernet/amd/nmclan_cs.o
  CC [M]  drivers/mtd/ubi/attach.o
  CC      drivers/pci/pcie/portdrv_bus.o
  CC [M]  drivers/platform/x86/toshiba_acpi.o
  CC      drivers/rtc/hctosys.o
  CC      net/xfrm/xfrm_user.o
  CC      drivers/rtc/class.o
  CC      drivers/pci/hotplug/pcihp_slot.o
  CC      drivers/pci/pcie/portdrv_acpi.o
  CC [M]  drivers/net/ethernet/amd/pcnet32.o
  CC [M]  drivers/mtd/ubi/misc.o
  CC [M]  drivers/platform/x86/intel_ips.o
  CC      drivers/pci/pcie/aer/aerdrv_errprint.o
  CC      drivers/rtc/interface.o
  CC      drivers/regulator/dummy.o
  CC [M]  drivers/mtd/ubi/debug.o
  CC      drivers/pci/hotplug/acpi_pcihp.o
  CC      drivers/regulator/fixed-helper.o
  CC      drivers/pci/pcie/aer/aerdrv_core.o
  LD [M]  drivers/mtd/ubi/ubi.o
  CC [M]  drivers/mtd/ar7part.o
  CC      drivers/rtc/rtc-dev.o
  CC [M]  drivers/platform/x86/mxm-wmi.o
  CC [M]  drivers/regulator/fixed.o
  CC      drivers/pci/hotplug/pciehp_core.o
  CC [M]  drivers/mtd/mtdchar.o
  CC [M]  net/xfrm/xfrm_ipcomp.o
  CC      drivers/rtc/rtc-proc.o
  CC [M]  drivers/regulator/userspace-consumer.o
  CC      drivers/pci/pcie/aer/aerdrv.o
  LD      drivers/net/ethernet/atheros/built-in.o
  LD      drivers/platform/built-in.o
  LD      drivers/net/ethernet/atheros/atl1c/built-in.o
  CC      drivers/pci/pcie/aer/aerdrv_acpi.o
  CC [M]  drivers/net/ethernet/atheros/atl1c/atl1c_main.o
  CC      drivers/pci/hotplug/pciehp_ctrl.o
  CC [M]  drivers/mtd/mtd_blkdevs.o
  CC [M]  drivers/regulator/lp3971.o
  CC      drivers/rtc/rtc-sysfs.o
  CC [M]  drivers/regulator/max1586.o
  CC      drivers/pci/hotplug/pciehp_pci.o
  CC      drivers/rtc/rtc-cmos.o
  CC      drivers/pci/pcie/aer/ecrc.o
  CC [M]  drivers/rtc/rtc-bq4802.o
  LD      net/xfrm/built-in.o
  CC      net/compat.o
  CC [M]  drivers/regulator/tps65023-regulator.o
  CC [M]  drivers/mtd/mtdblock.o
  CC [M]  drivers/pci/pcie/aer/aer_inject.o
  CC      drivers/pci/hotplug/pciehp_hpc.o
  LD      drivers/scsi/aacraid/built-in.o
  CC [M]  drivers/scsi/aacraid/linit.o
  CC [M]  drivers/rtc/rtc-ds1286.o
  CC [M]  drivers/regulator/tps6507x-regulator.o
  CC [M]  drivers/mtd/mtdblock_ro.o
  CC [M]  drivers/net/ethernet/atheros/atl1c/atl1c_hw.o
  LD      drivers/pci/pcie/aer/aerdriver.o
  LD      drivers/pci/pcie/aer/built-in.o
  CC      drivers/pci/pcie/pme.o
  CC      drivers/pci/hotplug/pciehp_acpi.o
  CC      net/sysctl_net.o
  CC [M]  drivers/mtd/ftl.o
  CC [M]  drivers/rtc/rtc-ds1307.o
  CC [M]  drivers/pci/hotplug/shpchp_core.o
  CC [M]  drivers/scsi/aacraid/aachba.o
  LD      drivers/regulator/built-in.o
  CC [M]  drivers/pci/hotplug/shpchp_ctrl.o
  LD      drivers/pci/pcie/pcieportdrv.o
  LD      drivers/pci/pcie/built-in.o
  CC      drivers/pci/ioapic.o
  LD      net/built-in.o
  CC [M]  drivers/net/ethernet/atheros/atl1c/atl1c_ethtool.o
  CC      drivers/pci/hotplug-pci.o
  CC      drivers/pci/msi.o
  CC [M]  drivers/rtc/rtc-ds1374.o
  CC [M]  drivers/mtd/inftlcore.o
  CC [M]  drivers/rtc/rtc-ds1511.o
  CC      drivers/pci/htirq.o
  CC [M]  drivers/pci/hotplug/shpchp_pci.o
  CC [M]  drivers/scsi/aacraid/commctrl.o
  CC [M]  drivers/scsi/aacraid/comminit.o
  LD [M]  drivers/net/ethernet/atheros/atl1c/atl1c.o
  LD      drivers/net/ethernet/atheros/atl1e/built-in.o
  CC [M]  drivers/net/ethernet/atheros/atl1e/atl1e_main.o
  CC [M]  drivers/rtc/rtc-ds1553.o
  CC [M]  drivers/pci/hotplug/shpchp_sysfs.o
  CC [M]  drivers/pci/hotplug/shpchp_hpc.o
  CC [M]  drivers/mtd/inftlmount.o
  CC [M]  drivers/scsi/aacraid/commsup.o
  CC      drivers/sfi/sfi_acpi.o
  CC [M]  drivers/rtc/rtc-ds1672.o
  CC      drivers/sfi/sfi_core.o
  LD      drivers/ssb/built-in.o
  CC [M]  drivers/ssb/main.o
  CC [M]  drivers/mtd/nftlcore.o
  CC [M]  drivers/ssb/scan.o
  CC [M]  drivers/rtc/rtc-ds1742.o
  CC [M]  drivers/pci/hotplug/acpiphp_ibm.o
  LD      drivers/sfi/built-in.o
  CC [M]  drivers/rtc/rtc-fm3130.o
  CC [M]  drivers/ssb/sprom.o
  CC [M]  drivers/ssb/pci.o
  CC [M]  drivers/mtd/nftlmount.o
  CC [M]  drivers/scsi/aacraid/dpcsup.o
  LD      drivers/pci/hotplug/pci_hotplug.o
  LD      drivers/pci/hotplug/pciehp.o
  LD      drivers/pci/hotplug/acpiphp.o
  LD [M]  drivers/pci/hotplug/shpchp.o
  LD      drivers/pci/hotplug/built-in.o
  CC [M]  drivers/net/ethernet/atheros/atl1e/atl1e_hw.o
  CC      drivers/pci/ats.o
  CC      drivers/pci/iov.o
  CC      drivers/pci/pci-acpi.o
  CC [M]  drivers/rtc/rtc-isl1208.o
  CC [M]  drivers/ssb/pcihost_wrapper.o
  CC [M]  drivers/mtd/rfd_ftl.o
  CC [M]  drivers/scsi/aacraid/rx.o
  CC [M]  drivers/scsi/aacraid/sa.o
  CC [M]  drivers/net/ethernet/atheros/atl1e/atl1e_ethtool.o
  CC [M]  drivers/rtc/rtc-m41t80.o
  CC [M]  drivers/rtc/rtc-m48t35.o
  CC [M]  drivers/ssb/pcmcia.o
  CC      drivers/pci/pci-label.o
  CC [M]  drivers/mtd/ssfdc.o
  CC [M]  drivers/mtd/mtdoops.o
  CC [M]  drivers/scsi/aacraid/rkt.o
  CC [M]  drivers/scsi/aacraid/nark.o
  CC [M]  drivers/rtc/rtc-m48t59.o
  CC      drivers/pci/pci-stub.o
  CC      drivers/pci/xen-pcifront.o
  CC [M]  drivers/net/ethernet/atheros/atl1e/atl1e_param.o
  LD      drivers/mtd/mtd.o
  LD [M]  drivers/mtd/nftl.o
  LD [M]  drivers/mtd/inftl.o
  CC [M]  drivers/ssb/sdio.o
  LD      drivers/mtd/built-in.o
  LD      drivers/net/ethernet/atheros/atlx/built-in.o
  CC [M]  drivers/net/ethernet/atheros/atlx/atl1.o
  CC [M]  drivers/net/ethernet/atheros/atlx/atl2.o
  CC [M]  drivers/scsi/aacraid/src.o
  CC [M]  drivers/ssb/driver_chipcommon.o
  CC [M]  drivers/rtc/rtc-max6900.o
  LD      drivers/pci/built-in.o
  LD [M]  drivers/net/ethernet/atheros/atl1e/atl1e.o
  LD      drivers/net/ethernet/broadcom/built-in.o
  CC [M]  drivers/net/ethernet/broadcom/b44.o
  CC [M]  drivers/ssb/driver_chipcommon_pmu.o
  LD      drivers/net/ethernet/brocade/built-in.o
  LD      drivers/scsi/aic7xxx/built-in.o
  SHIPPED drivers/scsi/aic7xxx/aic79xx_seq.h
  LD [M]  drivers/scsi/aacraid/aacraid.o
  LD      drivers/scsi/aic94xx/built-in.o
  SHIPPED drivers/scsi/aic7xxx/aic79xx_reg.h
  CC [M]  drivers/scsi/aic94xx/aic94xx_init.o
  CC [M]  drivers/rtc/rtc-pcf8563.o
  SHIPPED drivers/scsi/aic7xxx/aic7xxx_seq.h
  LD      drivers/net/ethernet/brocade/bna/built-in.o
  CC [M]  drivers/net/ethernet/brocade/bna/bnad.o
  CC [M]  drivers/ssb/driver_pcicore.o
  SHIPPED drivers/scsi/aic7xxx/aic7xxx_reg.h
  CC [M]  drivers/rtc/rtc-pcf8583.o
  CC [M]  drivers/ssb/b43_pci_bridge.o
  CC [M]  drivers/scsi/aic7xxx/aic79xx_core.o
  CC [M]  drivers/rtc/rtc-rs5c372.o
  CC [M]  drivers/net/ethernet/broadcom/bnx2.o
  LD      drivers/net/ethernet/cadence/built-in.o
  CC      drivers/net/phy/phy.o
  LD [M]  drivers/ssb/ssb.o
  CC      drivers/staging/staging.o
  CC [M]  drivers/rtc/rtc-rx8025.o
  LD      drivers/staging/media/built-in.o
  LD      drivers/staging/net/built-in.o
  LD      drivers/staging/silicom/built-in.o
  LD      drivers/staging/zram/built-in.o
  CC [M]  drivers/staging/zram/zram_drv.o
  CC [M]  drivers/rtc/rtc-rx8581.o
  CC [M]  drivers/staging/zram/zram_sysfs.o
  CC [M]  drivers/rtc/rtc-stk17ta8.o
  CC [M]  drivers/scsi/aic94xx/aic94xx_hwi.o
  LD [M]  drivers/staging/zram/zram.o
  LD      drivers/staging/zsmalloc/built-in.o
  CC [M]  drivers/staging/zsmalloc/zsmalloc-main.o
  CC [M]  drivers/rtc/rtc-v3020.o
  LD      drivers/net/ppp/built-in.o
  CC [M]  drivers/net/ppp/ppp_generic.o
  CC [M]  drivers/net/ethernet/brocade/bna/bnad_ethtool.o
  CC [M]  drivers/rtc/rtc-x1205.o
  CC      drivers/net/phy/phy_device.o
  CC [M]  drivers/scsi/aic94xx/aic94xx_reg.o
  LD [M]  drivers/staging/zsmalloc/zsmalloc.o
  LD      drivers/staging/built-in.o
  CC      drivers/net/phy/mdio_bus.o
  CC [M]  drivers/net/ethernet/brocade/bna/bnad_debugfs.o
  CC [M]  drivers/scsi/aic7xxx/aic79xx_pci.o
  CC [M]  drivers/scsi/aic94xx/aic94xx_sds.o
  CC [M]  drivers/scsi/aic94xx/aic94xx_seq.o
  CC      drivers/net/phy/fixed.o
  CC [M]  drivers/net/ethernet/broadcom/cnic.o
  CC [M]  drivers/net/ppp/ppp_async.o
  CC [M]  drivers/net/ethernet/brocade/bna/bna_enet.o
drivers/scsi/aic94xx/aic94xx_sds.c: In function ‘asd_process_ctrl_a_user’:
drivers/scsi/aic94xx/aic94xx_sds.c:985: warning: ‘offs’ may be used uninitialized in this function
  CC [M]  drivers/scsi/aic7xxx/aic79xx_osm.o
  CC [M]  drivers/net/phy/marvell.o
  CC [M]  drivers/scsi/aic94xx/aic94xx_dump.o
  CC [M]  drivers/net/ppp/ppp_deflate.o
  CC [M]  drivers/net/ppp/ppp_mppe.o
  LD      drivers/rtc/rtc-core.o
  LD      drivers/rtc/built-in.o
  CC [M]  drivers/net/ppp/ppp_synctty.o
  CC [M]  drivers/scsi/aic94xx/aic94xx_scb.o
  CC      drivers/thermal/thermal_sys.o
  CC      drivers/thermal/step_wise.o
  CC [M]  drivers/net/phy/davicom.o
  CC [M]  drivers/net/phy/cicada.o
  CC [M]  drivers/net/ppp/pppox.o
  CC [M]  drivers/net/ethernet/brocade/bna/bna_tx_rx.o
  CC [M]  drivers/scsi/aic94xx/aic94xx_dev.o
  CC [M]  drivers/scsi/aic94xx/aic94xx_tmf.o
  CC [M]  drivers/scsi/aic7xxx/aic79xx_proc.o
  CC [M]  drivers/net/phy/lxt.o
  LD      drivers/thermal/built-in.o
  CC [M]  drivers/net/ppp/pppoe.o
  CC [M]  drivers/scsi/aic7xxx/aic79xx_osm_pci.o
  CC [M]  drivers/scsi/aic7xxx/aic7xxx_core.o
  CC      drivers/tty/tty_io.o
  CC [M]  drivers/scsi/aic94xx/aic94xx_task.o
  CC [M]  drivers/net/phy/qsemi.o
  CC [M]  drivers/net/phy/smsc.o
  CC [M]  drivers/net/ethernet/broadcom/tg3.o
  CC [M]  drivers/scsi/aic7xxx/aic7xxx_93cx6.o
  CC [M]  drivers/net/ethernet/brocade/bna/bfa_msgq.o
  LD      drivers/uio/built-in.o
  LD [M]  drivers/scsi/aic94xx/aic94xx.o
  CC [M]  drivers/uio/uio.o
  LD      drivers/scsi/arcmsr/built-in.o
  CC [M]  drivers/scsi/arcmsr/arcmsr_attr.o
  CC [M]  drivers/net/phy/vitesse.o
  CC [M]  drivers/scsi/arcmsr/arcmsr_hba.o
  CC [M]  drivers/uio/uio_cif.o
  CC      drivers/tty/n_tty.o
  CC [M]  drivers/net/phy/broadcom.o
  CC [M]  drivers/net/ethernet/brocade/bna/bfa_ioc.o
  CC [M]  drivers/net/phy/icplus.o
  CC [M]  drivers/uio/uio_pdrv.o
  CC [M]  drivers/uio/uio_pdrv_genirq.o
  LD      drivers/net/slip/built-in.o
  CC [M]  drivers/net/slip/slip.o
  CC [M]  drivers/net/phy/realtek.o
  CC [M]  drivers/scsi/aic7xxx/aic7xxx_pci.o
  CC [M]  drivers/uio/uio_aec.o
  CC [M]  drivers/net/phy/et1011c.o
  CC      drivers/tty/tty_ioctl.o
  CC [M]  drivers/net/ethernet/brocade/bna/bfa_ioc_ct.o
  LD [M]  drivers/scsi/arcmsr/arcmsr.o
  CC [M]  drivers/net/ethernet/brocade/bna/bfa_cee.o
  CC [M]  drivers/uio/uio_sercos3.o
  CC [M]  drivers/net/phy/mdio-bitbang.o
  CC [M]  drivers/uio/uio_pci_generic.o
  CC [M]  drivers/scsi/aic7xxx/aic7xxx_osm.o
  CC [M]  drivers/net/ethernet/brocade/bna/cna_fwimg.o
  LD      drivers/scsi/be2iscsi/built-in.o
  CC [M]  drivers/scsi/be2iscsi/be_iscsi.o
  CC      drivers/tty/tty_ldisc.o
  CC [M]  drivers/net/slip/slhc.o
  CC      drivers/tty/tty_buffer.o
  CC [M]  drivers/net/phy/national.o
  LD [M]  drivers/net/ethernet/brocade/bna/bna.o
  CC [M]  drivers/net/phy/ste10Xp.o
  LD      drivers/net/phy/libphy.o
  LD      drivers/net/usb/built-in.o
  CC [M]  drivers/net/usb/catc.o
  CC      drivers/tty/tty_port.o
  CC [M]  drivers/scsi/be2iscsi/be_main.o
  CC      drivers/tty/tty_mutex.o
  CC [M]  drivers/scsi/aic7xxx/aic7xxx_proc.o
  LD      drivers/net/phy/built-in.o
  CC      drivers/tty/pty.o
  CC [M]  drivers/scsi/be2iscsi/be_mgmt.o
  CC      drivers/tty/tty_audit.o
  CC [M]  drivers/scsi/be2iscsi/be_cmds.o
  CC [M]  drivers/net/usb/kaweth.o
  CC [M]  drivers/scsi/aic7xxx/aic7xxx_osm_pci.o
  LD      drivers/net/vmxnet3/built-in.o
  CC [M]  drivers/net/vmxnet3/vmxnet3_drv.o
  CC      drivers/tty/sysrq.o
  CC [M]  drivers/net/vmxnet3/vmxnet3_ethtool.o
  LD [M]  drivers/scsi/aic7xxx/aic7xxx.o
  LD [M]  drivers/scsi/aic7xxx/aic79xx.o
  CC [M]  drivers/net/usb/pegasus.o
  LD      drivers/net/wan/built-in.o
  CC [M]  drivers/net/wan/hdlc.o
  CC [M]  drivers/net/wan/hdlc_raw.o
  CC      drivers/tty/hvc/hvc_console.o
  LD      drivers/net/ethernet/broadcom/bnx2x/built-in.o
  CC [M]  drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.o
  CC [M]  drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.o
  LD      drivers/net/wimax/built-in.o
  LD      drivers/net/wimax/i2400m/built-in.o
  CC [M]  drivers/net/wimax/i2400m/usb-fw.o
  CC [M]  drivers/net/wan/hdlc_cisco.o
  CC [M]  drivers/net/usb/rtl8150.o
  LD [M]  drivers/scsi/be2iscsi/be2iscsi.o
  LD      drivers/scsi/bfa/built-in.o
  CC [M]  drivers/scsi/bfa/bfad.o
  CC      drivers/tty/hvc/hvc_irq.o
  CC      drivers/tty/hvc/hvc_xen.o
  LD [M]  drivers/net/vmxnet3/vmxnet3.o
  CC [M]  drivers/scsi/bfa/bfad_im.o
  CC [M]  drivers/net/wimax/i2400m/usb-notif.o
  CC [M]  drivers/net/wan/hdlc_fr.o
  CC [M]  drivers/net/usb/hso.o
  LD      drivers/tty/hvc/built-in.o
  LD      drivers/tty/ipwireless/built-in.o
  CC [M]  drivers/tty/ipwireless/hardware.o
  CC [M]  drivers/net/wimax/i2400m/usb-tx.o
  CC [M]  drivers/tty/ipwireless/main.o
  CC [M]  drivers/scsi/bfa/bfad_attr.o
  CC [M]  drivers/net/wan/hdlc_ppp.o
  CC [M]  drivers/net/wimax/i2400m/usb-rx.o
  CC [M]  drivers/net/wimax/i2400m/usb.o
  CC [M]  drivers/tty/ipwireless/network.o
  CC [M]  drivers/net/usb/asix_devices.o
  CC [M]  drivers/net/wan/dlci.o
  CC [M]  drivers/scsi/bfa/bfad_debugfs.o
  CC [M]  drivers/net/usb/asix_common.o
  CC [M]  drivers/tty/ipwireless/tty.o
  CC [M]  drivers/net/wimax/i2400m/control.o
  LD      drivers/net/wireless/built-in.o
  CC [M]  drivers/net/wireless/airo.o
  CC [M]  drivers/net/wireless/airo_cs.o
  LD [M]  drivers/tty/ipwireless/ipwireless.o
  CC      drivers/tty/serial/serial_core.o
  CC [M]  drivers/scsi/bfa/bfad_bsg.o
  CC [M]  drivers/net/usb/ax88172a.o
  CC      drivers/tty/serial/8250/8250.o
  CC [M]  drivers/net/wimax/i2400m/driver.o
  CC [M]  drivers/net/wimax/i2400m/fw.o
  CC [M]  drivers/net/usb/cdc_ether.o
  CC [M]  drivers/net/wimax/i2400m/op-rfkill.o
  CC [M]  drivers/net/wimax/i2400m/sysfs.o
  CC [M]  drivers/net/usb/cdc_eem.o
  CC      drivers/tty/serial/8250/8250_pnp.o
  CC [M]  drivers/scsi/bfa/bfa_ioc.o
  CC [M]  drivers/scsi/bfa/bfa_ioc_cb.o
  CC [M]  drivers/scsi/bfa/bfa_ioc_ct.o
  CC [M]  drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.o
  CC [M]  drivers/net/wimax/i2400m/netdev.o
  CC      drivers/tty/serial/8250/8250_dma.o
  CC [M]  drivers/net/usb/dm9601.o
  CC [M]  drivers/net/usb/smsc95xx.o
  CC [M]  drivers/net/wimax/i2400m/tx.o
  CC [M]  drivers/net/wireless/atmel.o
  CC      drivers/tty/serial/8250/8250_pci.o
  CC [M]  drivers/net/wireless/atmel_pci.o
  CC [M]  drivers/net/wireless/atmel_cs.o
  CC [M]  drivers/net/dummy.o
  CC [M]  drivers/net/usb/gl620a.o
  CC [M]  drivers/net/wimax/i2400m/rx.o
  CC [M]  drivers/net/ifb.o
  LD      drivers/net/ethernet/chelsio/built-in.o
  CC      drivers/tty/serial/8250/8250_early.o
  LD      drivers/net/ethernet/chelsio/cxgb/built-in.o
  CC [M]  drivers/net/ethernet/chelsio/cxgb/cxgb2.o
  CC [M]  drivers/net/usb/net1080.o
  CC [M]  drivers/net/usb/plusb.o
  CC [M]  drivers/tty/serial/8250/serial_cs.o
  CC [M]  drivers/net/wimax/i2400m/debugfs.o
  CC [M]  drivers/net/usb/rndis_host.o
  CC [M]  drivers/net/wireless/at76c50x-usb.o
  CC [M]  drivers/net/usb/cdc_subset.o
  CC [M]  drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.o
  CC [M]  drivers/scsi/bfa/bfa_hw_cb.o
  LD      drivers/tty/serial/8250/8250_core.o
  CC [M]  drivers/scsi/bfa/bfa_hw_ct.o
  LD      drivers/tty/serial/8250/built-in.o
  LD      drivers/tty/serial/jsm/built-in.o
  LD [M]  drivers/net/wimax/i2400m/i2400m.o
  CC [M]  drivers/tty/serial/jsm/jsm_driver.o
  LD [M]  drivers/net/wimax/i2400m/i2400m-usb.o
  CC [M]  drivers/tty/serial/jsm/jsm_neo.o
  CC [M]  drivers/tty/serial/jsm/jsm_tty.o
  CC [M]  drivers/net/ethernet/chelsio/cxgb/espi.o
  CC [M]  drivers/net/usb/zaurus.o
  CC [M]  drivers/net/usb/mcs7830.o
  CC [M]  drivers/scsi/bfa/bfa_fcs.o
  CC [M]  drivers/net/wireless/wl3501_cs.o
  CC [M]  drivers/net/ethernet/chelsio/cxgb/tp.o
  CC [M]  drivers/scsi/bfa/bfa_fcs_lport.o
  CC [M]  drivers/scsi/bfa/bfa_fcs_rport.o
  LD [M]  drivers/tty/serial/jsm/jsm.o
  CC      drivers/tty/serial/kgdboc.o
  CC [M]  drivers/net/usb/usbnet.o
drivers/net/wireless/wl3501_cs.c: In function ‘wl3501_receive’:
drivers/net/wireless/wl3501_cs.c:756: warning: ‘next_addr’ may be used uninitialized in this function
drivers/net/wireless/wl3501_cs.c:785: warning: ‘next_addr1’ may be used uninitialized in this function
  CC [M]  drivers/net/ethernet/chelsio/cxgb/pm3393.o
  LD      drivers/tty/serial/built-in.o
  CC      drivers/tty/vt/vt_ioctl.o
  CC [M]  drivers/net/ethernet/broadcom/bnx2x/bnx2x_stats.o
  CC [M]  drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.o
  CC [M]  drivers/net/wireless/rndis_wlan.o
  CC [M]  drivers/net/ethernet/chelsio/cxgb/sge.o
  CC      drivers/tty/vt/vc_screen.o
  CC [M]  drivers/net/usb/int51x1.o
  CC      drivers/tty/vt/selection.o
  CC      drivers/tty/vt/keyboard.o
  CC [M]  drivers/net/usb/cdc-phonet.o
  CC [M]  drivers/net/usb/cdc_ncm.o
  CC [M]  drivers/tty/n_hdlc.o
  CC [M]  drivers/net/ethernet/chelsio/cxgb/subr.o
  CC [M]  drivers/net/wireless/zd1201.o
  CC [M]  drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.o
  CC [M]  drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.o
  CC [M]  drivers/tty/cyclades.o
  CC [M]  drivers/net/ethernet/chelsio/cxgb/mv88x201x.o
  LD [M]  drivers/net/usb/asix.o
  LD      drivers/usb/atm/built-in.o
  CC [M]  drivers/usb/atm/cxacru.o
  CC [M]  drivers/scsi/bfa/bfa_fcs_fcpim.o
  CC      drivers/tty/vt/consolemap.o
  CC [M]  drivers/net/ethernet/chelsio/cxgb/my3126.o
  CC [M]  drivers/net/wireless/adm8211.o
  CONMK   drivers/tty/vt/consolemap_deftbl.c
  CC [M]  drivers/net/macvlan.o
  CC [M]  drivers/net/ethernet/chelsio/cxgb/mv88e1xxx.o
  CC [M]  drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.o
  CC      drivers/tty/vt/vt.o
  CC [M]  drivers/scsi/bfa/bfa_fcbuild.o
  CC [M]  drivers/usb/atm/speedtch.o
  CC [M]  drivers/net/ethernet/chelsio/cxgb/vsc7326.o
  CC [M]  drivers/net/wireless/mwl8k.o
  LD      drivers/net/ethernet/cisco/built-in.o
  LD      drivers/net/ethernet/cisco/enic/built-in.o
  CC [M]  drivers/net/ethernet/cisco/enic/enic_main.o
  CC [M]  drivers/net/ethernet/cisco/enic/vnic_cq.o
  CC [M]  drivers/usb/atm/ueagle-atm.o
  CC [M]  drivers/usb/atm/usbatm.o
  CC [M]  drivers/scsi/bfa/bfa_port.o
  LD [M]  drivers/net/ethernet/chelsio/cxgb/cxgb.o
  LD      drivers/net/ethernet/chelsio/cxgb3/built-in.o
  CC [M]  drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.o
  SHIPPED drivers/tty/vt/defkeymap.c
  CC      drivers/tty/vt/consolemap_deftbl.o
  CC      drivers/tty/vt/defkeymap.o
  CC [M]  drivers/scsi/bfa/bfa_fcpim.o
  LD      drivers/tty/vt/built-in.o
  CC [M]  drivers/tty/nozomi.o
  LD [M]  drivers/net/ethernet/broadcom/bnx2x/bnx2x.o
  LD      drivers/net/ethernet/dec/tulip/built-in.o
  LD      drivers/net/ethernet/dlink/built-in.o
  CC [M]  drivers/net/ethernet/dec/tulip/xircom_cb.o
  CC [M]  drivers/net/ethernet/dlink/dl2k.o
  CC [M]  drivers/net/ethernet/cisco/enic/vnic_intr.o
  CC [M]  drivers/usb/atm/xusbatm.o
  CC [M]  drivers/net/ethernet/cisco/enic/vnic_wq.o
  CC [M]  drivers/net/wireless/mac80211_hwsim.o
  CC [M]  drivers/net/ethernet/cisco/enic/enic_res.o
  CC [M]  drivers/net/ethernet/chelsio/cxgb3/ael1002.o
  CC [M]  drivers/net/ethernet/dec/tulip/dmfe.o
  LD      drivers/usb/class/built-in.o
  CC [M]  drivers/tty/synclink_gt.o
  CC [M]  drivers/usb/class/cdc-acm.o
  CC [M]  drivers/net/ethernet/dlink/sundance.o
  CC [M]  drivers/net/ethernet/cisco/enic/enic_dev.o
  CC [M]  drivers/net/ethernet/chelsio/cxgb3/vsc8211.o
  LD      drivers/net/wireless/b43/built-in.o
  CC [M]  drivers/net/wireless/b43/main.o
  CC [M]  drivers/usb/class/usblp.o
  CC [M]  drivers/net/ethernet/dec/tulip/winbond-840.o
  CC [M]  drivers/net/ethernet/cisco/enic/enic_pp.o
  CC [M]  drivers/net/ethernet/chelsio/cxgb3/t3_hw.o
  CC [M]  drivers/scsi/bfa/bfa_core.o
  CC [M]  drivers/scsi/bfa/bfa_svc.o
  CC [M]  drivers/usb/class/cdc-wdm.o
  CC [M]  drivers/net/ethernet/cisco/enic/vnic_dev.o
  CC [M]  drivers/tty/synclinkmp.o
  CC [M]  drivers/net/ethernet/cisco/enic/vnic_rq.o
  CC [M]  drivers/net/ethernet/dec/tulip/de2104x.o
  LD      drivers/net/wireless/b43legacy/built-in.o
  CC [M]  drivers/net/wireless/b43legacy/main.o
  CC [M]  drivers/net/ethernet/chelsio/cxgb3/mc5.o
  CC [M]  drivers/usb/class/usbtmc.o
  CC [M]  drivers/net/ethernet/cisco/enic/vnic_vic.o
  LD [M]  drivers/net/ethernet/cisco/enic/enic.o
  CC [M]  drivers/net/ethernet/chelsio/cxgb3/xgmac.o
  CC      drivers/usb/core/usb.o
  CC [M]  drivers/net/macvtap.o
  CC [M]  drivers/net/ethernet/dec/tulip/eeprom.o
  CC [M]  drivers/net/ethernet/chelsio/cxgb3/sge.o
  CC      drivers/usb/core/hub.o
  CC [M]  drivers/net/wireless/b43/bus.o
  CC [M]  drivers/net/wireless/b43legacy/ilt.o
  CC [M]  drivers/net/ethernet/dec/tulip/interrupt.o
  CC [M]  drivers/net/wireless/b43legacy/phy.o
  LD [M]  drivers/scsi/bfa/bfa.o
  LD      drivers/scsi/bnx2fc/built-in.o
  CC [M]  drivers/scsi/bnx2fc/bnx2fc_els.o
  CC [M]  drivers/net/wireless/b43/tables.o
  CC [M]  drivers/tty/synclink.o
  CC [M]  drivers/scsi/bnx2fc/bnx2fc_fcoe.o
  CC [M]  drivers/net/ethernet/dec/tulip/media.o
  CC [M]  drivers/net/wireless/b43/phy_common.o
  CC [M]  drivers/net/ethernet/dec/tulip/timer.o
  CC [M]  drivers/net/wireless/b43legacy/radio.o
  CC      drivers/usb/early/ehci-dbgp.o
  CC [M]  drivers/net/ethernet/chelsio/cxgb3/l2t.o
  CC [M]  drivers/net/wireless/b43/phy_g.o
  CC      drivers/usb/core/hcd.o
  CC [M]  drivers/net/ethernet/dec/tulip/tulip_core.o
  CC [M]  drivers/scsi/bnx2fc/bnx2fc_hwi.o
  LD      drivers/usb/early/built-in.o
  CC      drivers/usb/core/urb.o
  CC [M]  drivers/net/ethernet/chelsio/cxgb3/cxgb3_offload.o
  CC [M]  drivers/net/wireless/b43legacy/sysfs.o
  CC [M]  drivers/net/wireless/b43legacy/xmit.o
  CC [M]  drivers/net/ethernet/dec/tulip/21142.o
  CC      drivers/usb/core/message.o
  CC [M]  drivers/net/wireless/b43/phy_a.o
  CC [M]  drivers/net/wireless/b43/phy_lp.o
  CC [M]  drivers/scsi/bnx2fc/bnx2fc_io.o
  CC [M]  drivers/net/ethernet/dec/tulip/pnic.o
  CC [M]  drivers/net/wireless/b43legacy/rfkill.o
  CC [M]  drivers/scsi/bnx2fc/bnx2fc_tgt.o
  CC [M]  drivers/net/ethernet/chelsio/cxgb3/aq100x.o
  CC      drivers/usb/core/driver.o
  LD      drivers/tty/built-in.o
  CC [M]  drivers/scsi/bnx2fc/bnx2fc_debug.o
  CC [M]  drivers/net/wireless/b43/tables_lpphy.o
  CC [M]  drivers/net/ethernet/dec/tulip/pnic2.o
  CC [M]  drivers/net/wireless/b43legacy/leds.o
  LD [M]  drivers/net/ethernet/chelsio/cxgb3/cxgb3.o
  LD      drivers/net/ethernet/chelsio/cxgb4/built-in.o
  CC [M]  drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.o
  CC [M]  drivers/net/wireless/b43legacy/debugfs.o
  CC      drivers/usb/host/pci-quirks.o
  CC      drivers/usb/core/config.o
  LD [M]  drivers/scsi/bnx2fc/bnx2fc.o
  LD      drivers/scsi/bnx2i/built-in.o
  CC [M]  drivers/scsi/bnx2i/bnx2i_init.o
  CC [M]  drivers/net/ethernet/dec/tulip/de4x5.o
  CC [M]  drivers/net/ethernet/dec/tulip/uli526x.o
  CC [M]  drivers/net/wireless/b43/sysfs.o
  CC [M]  drivers/net/wireless/b43legacy/dma.o
  CC      drivers/usb/core/file.o
  CC      drivers/usb/host/ehci-hcd.o
  CC [M]  drivers/scsi/bnx2i/bnx2i_hwi.o
  CC [M]  drivers/net/wireless/b43/xmit.o
  CC      drivers/usb/core/buffer.o
  CC      drivers/usb/core/sysfs.o
  CC [M]  drivers/net/wireless/b43legacy/pio.o
  CC [M]  drivers/net/wireless/b43/lo.o
  CC [M]  drivers/net/wireless/b43/wa.o
  CC      drivers/usb/core/endpoint.o
  CC [M]  drivers/net/ethernet/chelsio/cxgb4/l2t.o
  CC [M]  drivers/scsi/bnx2i/bnx2i_iscsi.o
  LD [M]  drivers/net/ethernet/dec/tulip/tulip.o
  CC      drivers/usb/core/devio.o
  LD      drivers/net/ethernet/dec/built-in.o
  CC      drivers/usb/core/notify.o
  CC      drivers/usb/core/generic.o
  LD [M]  drivers/net/wireless/b43legacy/b43legacy.o
  LD      drivers/net/ethernet/emulex/built-in.o
  LD      drivers/net/ethernet/emulex/benet/built-in.o
  CC [M]  drivers/net/ethernet/emulex/benet/be_main.o
  CC [M]  drivers/net/wireless/b43/dma.o
  LD      drivers/net/ethernet/fujitsu/built-in.o
  CC [M]  drivers/net/ethernet/fujitsu/fmvj18x_cs.o
  CC [M]  drivers/scsi/bnx2i/bnx2i_sysfs.o
  CC [M]  drivers/net/ethernet/chelsio/cxgb4/t4_hw.o
  CC [M]  drivers/net/ethernet/chelsio/cxgb4/sge.o
  LD [M]  drivers/scsi/bnx2i/bnx2i.o
  LD      drivers/scsi/cxgbi/built-in.o
  CC [M]  drivers/scsi/cxgbi/libcxgbi.o
  CC      drivers/usb/host/ehci-pci.o
  CC      drivers/usb/core/quirks.o
  LD      drivers/scsi/cxgbi/cxgb3i/built-in.o
  CC [M]  drivers/scsi/cxgbi/cxgb3i/cxgb3i.o
  CC [M]  drivers/net/wireless/b43/pio.o
  CC      drivers/usb/host/ohci-hcd.o
  CC      drivers/usb/core/devices.o
  LD      drivers/net/ethernet/hp/built-in.o
  CC [M]  drivers/net/mii.o
  CC [M]  drivers/net/wireless/b43/rfkill.o
  CC [M]  drivers/net/ethernet/emulex/benet/be_cmds.o
  CC      drivers/usb/core/port.o
  LD [M]  drivers/net/ethernet/chelsio/cxgb4/cxgb4.o
  CC [M]  drivers/net/ethernet/emulex/benet/be_ethtool.o
  CC [M]  drivers/net/mdio.o
  LD      drivers/scsi/cxgbi/cxgb4i/built-in.o
  CC [M]  drivers/scsi/cxgbi/cxgb4i/cxgb4i.o
  CC [M]  drivers/net/wireless/b43/leds.o
  CC      drivers/usb/core/hcd-pci.o
  CC      drivers/usb/core/usb-acpi.o
  CC      drivers/usb/host/uhci-hcd.o
  CC [M]  drivers/usb/host/isp1362-hcd.o
  CC [M]  drivers/net/wireless/b43/pcmcia.o
  CC [M]  drivers/net/ethernet/emulex/benet/be_roce.o
  LD      drivers/net/ethernet/i825xx/built-in.o
  LD      drivers/usb/core/usbcore.o
  CC [M]  drivers/net/wireless/b43/sdio.o
  LD      drivers/usb/core/built-in.o
  LD      drivers/net/wireless/hostap/built-in.o
  CC [M]  drivers/net/wireless/hostap/hostap_80211_rx.o
  LD      drivers/net/wireless/ipw2x00/built-in.o
  CC [M]  drivers/net/wireless/ipw2x00/ipw2100.o
  LD      drivers/net/wireless/iwlegacy/built-in.o
  CC [M]  drivers/net/wireless/iwlegacy/3945-mac.o
  CC      drivers/scsi/device_handler/scsi_dh.o
  CC [M]  drivers/net/wireless/b43/debugfs.o
  LD [M]  drivers/net/ethernet/emulex/benet/be2net.o
  CC [M]  drivers/scsi/device_handler/scsi_dh_rdac.o
  LD      drivers/net/ethernet/icplus/built-in.o
  CC [M]  drivers/net/ethernet/icplus/ipg.o
  CC [M]  drivers/net/wireless/hostap/hostap_80211_tx.o
  CC [M]  drivers/usb/host/xhci.o
  CC [M]  drivers/net/wireless/hostap/hostap_ap.o
  LD [M]  drivers/net/wireless/b43/b43.o
  CC [M]  drivers/scsi/device_handler/scsi_dh_hp_sw.o
  CC [M]  drivers/net/wireless/hostap/hostap_info.o
  CC [M]  drivers/net/wireless/iwlegacy/3945.o
  CC [M]  drivers/scsi/device_handler/scsi_dh_emc.o
  LD      drivers/net/ethernet/intel/built-in.o
  CC [M]  drivers/net/ethernet/intel/e100.o
  LD      drivers/net/ethernet/intel/e1000/built-in.o
  CC [M]  drivers/net/ethernet/intel/e1000/e1000_main.o
  CC [M]  drivers/net/ethernet/intel/e1000/e1000_hw.o
  CC [M]  drivers/scsi/device_handler/scsi_dh_alua.o
  CC [M]  drivers/net/wireless/ipw2x00/ipw2200.o
  CC [M]  drivers/usb/host/xhci-mem.o
  CC [M]  drivers/net/wireless/hostap/hostap_ioctl.o
  CC [M]  drivers/net/wireless/iwlegacy/3945-rs.o
  LD      drivers/scsi/device_handler/built-in.o
  LD      drivers/scsi/fcoe/built-in.o
  CC [M]  drivers/scsi/fcoe/fcoe.o
  CC [M]  drivers/net/wireless/iwlegacy/4965.o
  CC [M]  drivers/net/wireless/iwlegacy/4965-mac.o
  CC [M]  drivers/usb/host/xhci-ring.o
  CC [M]  drivers/net/wireless/iwlegacy/4965-rs.o
  CC [M]  drivers/net/ethernet/intel/e1000/e1000_ethtool.o
  CC [M]  drivers/net/wireless/hostap/hostap_main.o
  CC [M]  drivers/scsi/fcoe/fcoe_ctlr.o
  CC [M]  drivers/net/wireless/hostap/hostap_proc.o
  LD      drivers/net/ethernet/marvell/built-in.o
  CC [M]  drivers/net/ethernet/marvell/skge.o
  CC [M]  drivers/net/ethernet/marvell/sky2.o
  CC [M]  drivers/usb/host/xhci-hub.o
  CC [M]  drivers/net/ethernet/intel/e1000/e1000_param.o
  CC [M]  drivers/net/wireless/hostap/hostap_cs.o
  CC [M]  drivers/usb/host/xhci-dbg.o
  LD [M]  drivers/net/ethernet/intel/e1000/e1000.o
  LD      drivers/net/ethernet/intel/e1000e/built-in.o
  CC [M]  drivers/net/ethernet/intel/e1000e/82571.o
  CC [M]  drivers/net/wireless/iwlegacy/4965-calib.o
  CC [M]  drivers/usb/host/xhci-pci.o
  CC [M]  drivers/scsi/fcoe/fcoe_transport.o
  CC [M]  drivers/net/wireless/ipw2x00/libipw_module.o
  CC [M]  drivers/usb/host/sl811-hcd.o
  CC [M]  drivers/net/wireless/iwlegacy/common.o
  CC [M]  drivers/scsi/fcoe/fcoe_sysfs.o
  CC [M]  drivers/net/ethernet/intel/e1000e/ich8lan.o
  CC [M]  drivers/net/wireless/hostap/hostap_plx.o
  CC [M]  drivers/net/wireless/hostap/hostap_pci.o
  CC [M]  drivers/net/wireless/ipw2x00/libipw_tx.o
  CC [M]  drivers/usb/host/u132-hcd.o
  CC [M]  drivers/usb/host/hwa-hc.o
  LD [M]  drivers/scsi/fcoe/libfcoe.o
  LD      drivers/scsi/fnic/built-in.o
  CC [M]  drivers/scsi/fnic/fnic_attrs.o
  LD      drivers/uwb/built-in.o
  CC [M]  drivers/uwb/umc-bus.o
  CC [M]  drivers/scsi/fnic/fnic_isr.o
  CC [M]  drivers/net/wireless/ipw2x00/libipw_rx.o
  CC [M]  drivers/net/ethernet/intel/e1000e/80003es2lan.o
  CC [M]  drivers/uwb/umc-dev.o
  LD      drivers/usb/host/whci/built-in.o
  CC [M]  drivers/usb/host/whci/asl.o
  CC [M]  drivers/scsi/fnic/fnic_main.o
  CC [M]  drivers/usb/host/whci/debug.o
  CC [M]  drivers/uwb/umc-drv.o
  LD [M]  drivers/net/wireless/hostap/hostap.o
  CC [M]  drivers/usb/host/whci/hcd.o
  CC [M]  drivers/net/wireless/ipw2x00/libipw_wx.o
  CC [M]  drivers/net/ethernet/intel/e1000e/mac.o
  CC [M]  drivers/uwb/address.o
  LD [M]  drivers/net/wireless/iwlegacy/iwlegacy.o
  LD [M]  drivers/net/wireless/iwlegacy/iwl4965.o
  LD [M]  drivers/net/wireless/iwlegacy/iwl3945.o
  CC [M]  drivers/net/ethernet/intel/e1000e/manage.o
  CC [M]  drivers/net/ethernet/intel/e1000e/nvm.o
  CC [M]  drivers/net/wireless/ipw2x00/libipw_geo.o
  CC [M]  drivers/usb/host/whci/hw.o
  CC [M]  drivers/scsi/fnic/fnic_res.o
  LD      drivers/net/wireless/libertas/built-in.o
  CC [M]  drivers/net/wireless/libertas/cfg.o
  CC [M]  drivers/usb/host/whci/init.o
  CC [M]  drivers/usb/host/whci/int.o
  CC [M]  drivers/uwb/allocator.o
  CC [M]  drivers/uwb/beacon.o
  CC [M]  drivers/net/ethernet/intel/e1000e/phy.o
  CC [M]  drivers/scsi/fnic/fnic_fcs.o
  CC [M]  drivers/net/ethernet/intel/e1000e/param.o
  LD [M]  drivers/net/wireless/ipw2x00/libipw.o
  CC [M]  drivers/net/ethernet/intel/e1000e/ethtool.o
  CC [M]  drivers/uwb/driver.o
  CC [M]  drivers/usb/host/whci/pzl.o
  LD      drivers/usb/image/built-in.o
  CC [M]  drivers/usb/image/mdc800.o
  CC [M]  drivers/uwb/drp.o
  CC [M]  drivers/usb/image/microtek.o
  CC [M]  drivers/net/wireless/libertas/cmd.o
  CC [M]  drivers/usb/host/whci/qset.o
  CC [M]  drivers/usb/host/whci/wusb.o
  CC [M]  drivers/uwb/drp-avail.o
  CC [M]  drivers/scsi/fnic/fnic_scsi.o
  CC [M]  drivers/uwb/drp-ie.o
  CC [M]  drivers/uwb/est.o
  LD      drivers/usb/misc/built-in.o
  CC [M]  drivers/scsi/fnic/fnic_trace.o
  CC [M]  drivers/usb/misc/adutux.o
  CC [M]  drivers/usb/misc/appledisplay.o
  LD [M]  drivers/usb/host/whci/whci-hcd.o
  LD      drivers/usb/host/built-in.o
  LD [M]  drivers/usb/host/xhci-hcd.o
  CC [M]  drivers/usb/misc/emi26.o
  CC [M]  drivers/uwb/ie.o
  CC [M]  drivers/net/ethernet/intel/e1000e/netdev.o
  CC [M]  drivers/net/ethernet/intel/e1000e/ptp.o
  CC [M]  drivers/usb/misc/emi62.o
  LD      drivers/vhost/built-in.o
  CC [M]  drivers/vhost/vhost.o
  CC [M]  drivers/uwb/ie-rcv.o
  CC [M]  drivers/uwb/lc-dev.o
  CC [M]  drivers/net/wireless/libertas/cmdresp.o
  CC [M]  drivers/net/wireless/libertas/debugfs.o
  CC [M]  drivers/usb/misc/ezusb.o
  CC [M]  drivers/uwb/lc-rc.o
  CC [M]  drivers/uwb/neh.o
  CC [M]  drivers/scsi/fnic/fnic_debugfs.o
  CC [M]  drivers/uwb/pal.o
  CC [M]  drivers/usb/misc/ftdi-elan.o
  CC      drivers/video/fb_notify.o
  CC [M]  drivers/vhost/net.o
  CC [M]  drivers/net/wireless/libertas/ethtool.o
  CC [M]  drivers/net/wireless/libertas/main.o
  CC [M]  drivers/scsi/fnic/vnic_cq.o
  CC [M]  drivers/uwb/radio.o
  CC      drivers/video/fbmem.o
  CC [M]  drivers/scsi/fnic/vnic_dev.o
  CC      drivers/video/fbmon.o
  CC [M]  drivers/uwb/reset.o
  LD [M]  drivers/vhost/vhost_net.o
  CC      drivers/video/fbcmap.o
  CC [M]  drivers/uwb/rsv.o
  CC [M]  drivers/scsi/fnic/vnic_intr.o
  CC [M]  drivers/scsi/fnic/vnic_rq.o
  CC [M]  drivers/usb/misc/idmouse.o
  CC [M]  drivers/usb/misc/iowarrior.o
  CC [M]  drivers/net/wireless/libertas/rx.o
  CC [M]  drivers/uwb/scan.o
  CC [M]  drivers/uwb/uwb-debug.o
  CC      drivers/video/fbsysfs.o
  LD [M]  drivers/net/ethernet/intel/e1000e/e1000e.o
  LD      drivers/net/ethernet/intel/igb/built-in.o
  CC [M]  drivers/net/ethernet/intel/igb/igb_main.o
  CC [M]  drivers/scsi/fnic/vnic_wq_copy.o
  CC [M]  drivers/scsi/fnic/vnic_wq.o
  CC [M]  drivers/uwb/uwbd.o
  CC      drivers/video/modedb.o
  LD      drivers/net/ethernet/intel/igbvf/built-in.o
  CC [M]  drivers/net/ethernet/intel/igbvf/vf.o
  LD      drivers/net/ethernet/intel/ixgb/built-in.o
  CC [M]  drivers/usb/misc/isight_firmware.o
  LD [M]  drivers/scsi/fnic/fnic.o
  CC [M]  drivers/net/ethernet/intel/ixgb/ixgb_main.o
  LD      drivers/scsi/isci/built-in.o
  CC [M]  drivers/scsi/isci/init.o
  CC [M]  drivers/uwb/whci.o
  CC [M]  drivers/net/wireless/libertas/tx.o
  CC [M]  drivers/usb/misc/usblcd.o
  CC      drivers/video/fbcvt.o
  CC [M]  drivers/uwb/whc-rc.o
  CC [M]  drivers/net/wireless/libertas/firmware.o
  CC [M]  drivers/net/ethernet/intel/igbvf/mbx.o
  LD      drivers/video/aty/built-in.o
  CC [M]  drivers/video/aty/atyfb_base.o
  CC [M]  drivers/usb/misc/ldusb.o
  CC [M]  drivers/scsi/isci/phy.o
  CC [M]  drivers/uwb/hwa-rc.o
  CC [M]  drivers/net/ethernet/intel/igbvf/ethtool.o
  CC [M]  drivers/net/wireless/libertas/if_cs.o
  CC [M]  drivers/net/ethernet/intel/ixgb/ixgb_hw.o
  CC [M]  drivers/usb/misc/usbled.o
  LD      drivers/uwb/i1480/built-in.o
  CC [M]  drivers/uwb/i1480/i1480-est.o
  CC [M]  drivers/net/ethernet/intel/igbvf/netdev.o
  LD      drivers/uwb/i1480/dfu/built-in.o
  CC [M]  drivers/uwb/i1480/dfu/dfu.o
  CC [M]  drivers/scsi/isci/request.o
  CC [M]  drivers/usb/misc/legousbtower.o
  CC [M]  drivers/video/aty/mach64_accel.o
  CC [M]  drivers/net/ethernet/intel/igb/igb_ethtool.o
  CC [M]  drivers/net/wireless/libertas/if_sdio.o
  CC [M]  drivers/net/ethernet/intel/ixgb/ixgb_ee.o
  CC [M]  drivers/uwb/i1480/dfu/mac.o
  CC [M]  drivers/video/aty/mach64_cursor.o
  CC [M]  drivers/usb/misc/uss720.o
  CC [M]  drivers/uwb/i1480/dfu/phy.o
  CC [M]  drivers/net/ethernet/intel/ixgb/ixgb_ethtool.o
  CC [M]  drivers/video/aty/mach64_gx.o
  CC [M]  drivers/uwb/i1480/dfu/usb.o
  CC [M]  drivers/usb/misc/usbsevseg.o
  CC [M]  drivers/net/wireless/libertas/if_usb.o
  CC [M]  drivers/scsi/isci/remote_device.o
  LD [M]  drivers/net/ethernet/intel/igbvf/igbvf.o
  CC [M]  drivers/scsi/isci/port.o
  LD [M]  drivers/uwb/i1480/dfu/i1480-dfu-usb.o
  LD [M]  drivers/uwb/uwb.o
  CC [M]  drivers/net/ethernet/intel/igb/e1000_82575.o
  LD [M]  drivers/uwb/umc.o
  CC [M]  drivers/net/ethernet/intel/igb/e1000_mac.o
  CC [M]  drivers/video/aty/mach64_ct.o
  CC [M]  drivers/net/ethernet/intel/ixgb/ixgb_param.o
  LD      drivers/usb/misc/sisusbvga/built-in.o
  CC [M]  drivers/usb/misc/sisusbvga/sisusb.o
  CC [M]  drivers/video/aty/radeon_base.o
  LD [M]  drivers/net/wireless/libertas/libertas.o
  LD [M]  drivers/net/wireless/libertas/usb8xxx.o
  LD [M]  drivers/net/wireless/libertas/libertas_cs.o
  LD [M]  drivers/net/wireless/libertas/libertas_sdio.o
  LD      drivers/net/wireless/libertas_tf/built-in.o
  CC [M]  drivers/net/wireless/libertas_tf/main.o
  CC [M]  drivers/net/wireless/libertas_tf/cmd.o
  LD [M]  drivers/net/ethernet/intel/ixgb/ixgb.o
  LD      drivers/net/ethernet/mellanox/built-in.o
  CC [M]  drivers/scsi/isci/host.o
  LD      drivers/net/ethernet/mellanox/mlx4/built-in.o
  CC [M]  drivers/net/ethernet/mellanox/mlx4/alloc.o
  CC [M]  drivers/scsi/isci/task.o
  CC [M]  drivers/net/ethernet/intel/igb/e1000_nvm.o
  CC [M]  drivers/net/ethernet/mellanox/mlx4/catas.o
  CC [M]  drivers/usb/misc/sisusbvga/sisusb_init.o
  CC [M]  drivers/usb/misc/sisusbvga/sisusb_con.o
  LD      drivers/net/wireless/orinoco/built-in.o
  CC [M]  drivers/net/wireless/orinoco/main.o
  CC [M]  drivers/net/wireless/libertas_tf/if_usb.o
  CC [M]  drivers/net/ethernet/intel/igb/e1000_phy.o
  CC [M]  drivers/scsi/isci/probe_roms.o
  CC [M]  drivers/net/ethernet/mellanox/mlx4/cmd.o
  CC [M]  drivers/video/aty/radeon_pm.o
  CC [M]  drivers/net/ethernet/mellanox/mlx4/cq.o
  LD [M]  drivers/usb/misc/sisusbvga/sisusbvga.o
  CC      drivers/usb/mon/mon_main.o
  CC [M]  drivers/scsi/isci/remote_node_context.o
  CC [M]  drivers/net/ethernet/intel/igb/e1000_mbx.o
  LD [M]  drivers/net/wireless/libertas_tf/libertas_tf.o
  LD [M]  drivers/net/wireless/libertas_tf/libertas_tf_usb.o
  LD      drivers/net/wireless/p54/built-in.o
  CC [M]  drivers/net/wireless/p54/eeprom.o
  CC [M]  drivers/net/ethernet/mellanox/mlx4/eq.o
  CC [M]  drivers/net/ethernet/intel/igb/e1000_i210.o
  CC      drivers/usb/mon/mon_stat.o
  CC      drivers/usb/mon/mon_text.o
  CC [M]  drivers/net/ethernet/intel/igb/igb_ptp.o
  CC [M]  drivers/scsi/isci/remote_node_table.o
  CC [M]  drivers/scsi/isci/unsolicited_frame_control.o
  CC [M]  drivers/scsi/isci/port_config.o
  CC [M]  drivers/net/ethernet/mellanox/mlx4/fw.o
  CC      drivers/usb/mon/mon_bin.o
  CC [M]  drivers/net/wireless/p54/fwio.o
  CC [M]  drivers/net/wireless/orinoco/fw.o
  CC [M]  drivers/net/wireless/orinoco/hw.o
  CC [M]  drivers/net/ethernet/intel/igb/igb_hwmon.o
  CC [M]  drivers/video/aty/radeon_monitor.o
  LD [M]  drivers/scsi/isci/isci.o
  CC [M]  drivers/video/aty/radeon_accel.o
  LD      drivers/scsi/libfc/built-in.o
  CC [M]  drivers/scsi/libfc/fc_libfc.o
  LD      drivers/usb/mon/usbmon.o
  LD      drivers/usb/mon/built-in.o
  CC      drivers/usb/otg/otg.o
  LD [M]  drivers/net/ethernet/intel/igb/igb.o
  LD      drivers/net/ethernet/intel/ixgbe/built-in.o
  CC [M]  drivers/net/ethernet/intel/ixgbe/ixgbe_main.o
  CC [M]  drivers/net/wireless/p54/txrx.o
  CC [M]  drivers/net/wireless/orinoco/mic.o
  LD      drivers/net/ethernet/intel/ixgbevf/built-in.o
  CC [M]  drivers/net/ethernet/intel/ixgbevf/vf.o
  CC [M]  drivers/video/aty/radeon_i2c.o
  CC [M]  drivers/usb/otg/nop-usb-xceiv.o
  CC [M]  drivers/scsi/libfc/fc_disc.o
  CC [M]  drivers/net/ethernet/mellanox/mlx4/icm.o
  CC [M]  drivers/net/wireless/orinoco/scan.o
  CC [M]  drivers/video/aty/radeon_backlight.o
  CC [M]  drivers/net/ethernet/intel/ixgbevf/mbx.o
  CC [M]  drivers/net/ethernet/mellanox/mlx4/intf.o
  LD      drivers/usb/otg/built-in.o
  LD      drivers/usb/phy/built-in.o
  CC [M]  drivers/net/wireless/p54/main.o
  LD      drivers/usb/serial/built-in.o
  CC [M]  drivers/usb/serial/usb-serial.o
  CC [M]  drivers/net/wireless/orinoco/wext.o
  CC [M]  drivers/video/aty/aty128fb.o
  CC [M]  drivers/scsi/libfc/fc_exch.o
  CC [M]  drivers/net/ethernet/intel/ixgbevf/ethtool.o
  CC [M]  drivers/net/ethernet/mellanox/mlx4/main.o
  CC [M]  drivers/net/wireless/p54/led.o
  CC [M]  drivers/net/wireless/orinoco/hermes_dld.o
  CC [M]  drivers/usb/serial/generic.o
  CC [M]  drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.o
  LD [M]  drivers/video/aty/radeonfb.o
  LD [M]  drivers/video/aty/atyfb.o
  CC      drivers/video/backlight/backlight.o
  CC [M]  drivers/scsi/libfc/fc_elsct.o
  CC [M]  drivers/net/wireless/p54/p54usb.o
  CC [M]  drivers/net/wireless/orinoco/hermes.o
  CC [M]  drivers/net/ethernet/intel/ixgbe/ixgbe_common.o
  CC [M]  drivers/net/ethernet/mellanox/mlx4/mcg.o
  CC [M]  drivers/video/backlight/lcd.o
  CC [M]  drivers/usb/serial/bus.o
  CC [M]  drivers/net/wireless/orinoco/cfg.o
  CC [M]  drivers/scsi/libfc/fc_frame.o
  CC [M]  drivers/usb/serial/aircable.o
  LD [M]  drivers/net/ethernet/intel/ixgbevf/ixgbevf.o
  CC [M]  drivers/net/wireless/orinoco/orinoco_cs.o
  CC [M]  drivers/net/ethernet/mellanox/mlx4/mr.o
  CC [M]  drivers/video/backlight/platform_lcd.o
  CC [M]  drivers/net/wireless/p54/p54pci.o
  CC [M]  drivers/usb/serial/ark3116.o
  CC [M]  drivers/net/ethernet/mellanox/mlx4/pd.o
  CC [M]  drivers/net/wireless/orinoco/orinoco_plx.o
  CC [M]  drivers/scsi/libfc/fc_lport.o
  LD      drivers/video/backlight/built-in.o
  CC      drivers/video/console/dummycon.o
  CC      drivers/video/console/vgacon.o
  CC [M]  drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.o
  CC [M]  drivers/usb/serial/belkin_sa.o
  LD      drivers/net/ethernet/micrel/built-in.o
  LD      drivers/net/ethernet/myricom/built-in.o
  LD      drivers/net/ethernet/myricom/myri10ge/built-in.o
  CC [M]  drivers/net/ethernet/mellanox/mlx4/port.o
  CC [M]  drivers/net/ethernet/myricom/myri10ge/myri10ge.o
  LD [M]  drivers/net/wireless/p54/p54common.o
  CC [M]  drivers/net/ethernet/mellanox/mlx4/profile.o
  CC [M]  drivers/net/wireless/orinoco/orinoco_tmd.o
  CC [M]  drivers/usb/serial/ch341.o
  CC [M]  drivers/net/wireless/orinoco/orinoco_nortel.o
  CC      drivers/video/console/fbcon.o
  CC [M]  drivers/scsi/libfc/fc_rport.o
  CC [M]  drivers/net/ethernet/mellanox/mlx4/qp.o
  CC [M]  drivers/net/wireless/orinoco/spectrum_cs.o
  CC [M]  drivers/usb/serial/cp210x.o
  CC [M]  drivers/usb/serial/cyberjack.o
  CC [M]  drivers/net/ethernet/intel/ixgbe/ixgbe_82599.o
  LD [M]  drivers/net/wireless/orinoco/orinoco.o
  LD      drivers/net/wireless/rt2x00/built-in.o
  CC [M]  drivers/net/ethernet/mellanox/mlx4/reset.o
  CC [M]  drivers/net/wireless/rt2x00/rt2x00dev.o
  CC [M]  drivers/net/wireless/rt2x00/rt2x00mac.o
  CC [M]  drivers/usb/serial/cypress_m8.o
  CC [M]  drivers/net/ethernet/mellanox/mlx4/sense.o
  CC [M]  drivers/scsi/libfc/fc_fcp.o
  CC [M]  drivers/scsi/libfc/fc_npiv.o
  CC      drivers/video/console/bitblit.o
  CC [M]  drivers/net/ethernet/mellanox/mlx4/srq.o
  CC [M]  drivers/net/ethernet/intel/ixgbe/ixgbe_82598.o
  CC [M]  drivers/usb/serial/usb_debug.o
  CC [M]  drivers/usb/serial/digi_acceleport.o
  CC [M]  drivers/net/wireless/rt2x00/rt2x00config.o
  CC [M]  drivers/net/wireless/rt2x00/rt2x00queue.o
  CC [M]  drivers/net/ethernet/mellanox/mlx4/resource_tracker.o
  CC [M]  drivers/net/ethernet/mellanox/mlx4/en_main.o
  CC      drivers/video/console/fonts.o
  CC [M]  drivers/net/ethernet/intel/ixgbe/ixgbe_phy.o
  CC      drivers/video/console/font_8x8.o
  CC      drivers/video/console/font_8x16.o
  LD [M]  drivers/scsi/libfc/libfc.o
  LD      drivers/scsi/libsas/built-in.o
  CC [M]  drivers/scsi/libsas/sas_init.o
  CC [M]  drivers/usb/serial/io_edgeport.o
  CC      drivers/video/console/softcursor.o
  CC [M]  drivers/net/wireless/rt2x00/rt2x00link.o
  LD      drivers/virtio/built-in.o
  CC [M]  drivers/virtio/virtio.o
  CC [M]  drivers/virtio/virtio_ring.o
  CC [M]  drivers/net/wireless/rt2x00/rt2x00crypto.o
  CC [M]  drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.o
  CC      drivers/video/console/tileblit.o
  CC [M]  drivers/net/ethernet/mellanox/mlx4/en_tx.o
  CC      drivers/video/console/fbcon_rotate.o
  CC [M]  drivers/virtio/virtio_pci.o
  CC [M]  drivers/scsi/libsas/sas_phy.o
  CC      drivers/video/console/fbcon_cw.o
  CC [M]  drivers/net/wireless/rt2x00/rt2x00firmware.o
  CC [M]  drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.o
  CC [M]  drivers/virtio/virtio_balloon.o
  CC [M]  drivers/scsi/libsas/sas_port.o
  CC [M]  drivers/net/wireless/rt2x00/rt2x00leds.o
  CC [M]  drivers/scsi/libsas/sas_event.o
  CC [M]  drivers/net/ethernet/intel/ixgbe/ixgbe_x540.o
  CC      drivers/video/console/fbcon_ud.o
  CC [M]  drivers/net/ethernet/mellanox/mlx4/en_rx.o
  CC [M]  drivers/scsi/libsas/sas_dump.o
  CC [M]  drivers/usb/serial/io_ti.o
  LD      drivers/net/ethernet/natsemi/built-in.o
  CC [M]  drivers/net/wireless/rt2x00/rt2x00pci.o
  CC [M]  drivers/net/ethernet/natsemi/natsemi.o
  CC [M]  drivers/net/wireless/rt2x00/rt2x00usb.o
  CC [M]  drivers/net/ethernet/intel/ixgbe/ixgbe_lib.o
  CC      drivers/video/console/fbcon_ccw.o
  CC [M]  drivers/scsi/libsas/sas_discover.o
  CC [M]  drivers/net/ethernet/mellanox/mlx4/en_ethtool.o
  CC [M]  drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.o
  CC [M]  drivers/net/ethernet/natsemi/ns83820.o
  CC [M]  drivers/scsi/libsas/sas_expander.o
  LD      drivers/video/console/font.o
  CC [M]  drivers/usb/serial/empeg.o
  LD      drivers/video/console/built-in.o
  CC [M]  drivers/net/wireless/rt2x00/rt2400pci.o
  CC      drivers/video/logo/logo.o
  CC [M]  drivers/net/wireless/rt2x00/rt2500pci.o
  LOGO    drivers/video/logo/logo_linux_clut224.c
  LOGO    drivers/video/logo/logo_linux_mono.c
  LOGO    drivers/video/logo/logo_superh_mono.c
  LOGO    drivers/video/logo/clut_vga16.c
  CC [M]  drivers/usb/serial/ftdi_sio.o
  LOGO    drivers/video/logo/logo_blackfin_vga16.c
  CC [M]  drivers/net/ethernet/intel/ixgbe/ixgbe_dcb.o
  LOGO    drivers/video/logo/logo_linux_vga16.c
  LOGO    drivers/video/logo/logo_superh_vga16.c
  LOGO    drivers/video/logo/logo_blackfin_clut224.c
  LOGO    drivers/video/logo/logo_dec_clut224.c
  LOGO    drivers/video/logo/logo_m32r_clut224.c
  LOGO    drivers/video/logo/logo_mac_clut224.c
  LOGO    drivers/video/logo/logo_parisc_clut224.c
  LOGO    drivers/video/logo/logo_sgi_clut224.c
  LOGO    drivers/video/logo/logo_spe_clut224.c
  LOGO    drivers/video/logo/logo_sun_clut224.c
  LOGO    drivers/video/logo/logo_superh_clut224.c
  CC      drivers/video/logo/logo_linux_clut224.o
  LD      drivers/video/logo/built-in.o
  LD      drivers/video/nvidia/built-in.o
  CC [M]  drivers/video/nvidia/nvidia.o
  CC [M]  drivers/net/ethernet/mellanox/mlx4/en_port.o
  CC [M]  drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_82598.o
  CC [M]  drivers/net/ethernet/mellanox/mlx4/en_cq.o
  CC [M]  drivers/usb/serial/funsoft.o
  CC [M]  drivers/scsi/libsas/sas_scsi_host.o
  LD      drivers/net/wireless/rtl818x/built-in.o
  LD      drivers/net/wireless/rtl818x/rtl8180/built-in.o
  CC [M]  drivers/net/wireless/rtl818x/rtl8180/dev.o
  CC [M]  drivers/net/wireless/rtl818x/rtl8180/rtl8225.o
  CC [M]  drivers/video/nvidia/nv_hw.o
  CC [M]  drivers/usb/serial/garmin_gps.o
  CC [M]  drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_82599.o
  CC [M]  drivers/net/ethernet/mellanox/mlx4/en_resources.o
  CC [M]  drivers/net/wireless/rt2x00/rt61pci.o
  CC [M]  drivers/net/ethernet/mellanox/mlx4/en_netdev.o
  CC [M]  drivers/scsi/libsas/sas_task.o
  CC [M]  drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_nl.o
  CC [M]  drivers/video/nvidia/nv_setup.o
  CC [M]  drivers/usb/serial/hp4x.o
  CC [M]  drivers/net/wireless/rtl818x/rtl8180/sa2400.o
  CC [M]  drivers/usb/serial/ipaq.o
  CC [M]  drivers/video/nvidia/nv_accel.o
  CC [M]  drivers/scsi/libsas/sas_ata.o
  CC [M]  drivers/scsi/libsas/sas_host_smp.o
  CC [M]  drivers/net/ethernet/intel/ixgbe/ixgbe_sysfs.o
  CC [M]  drivers/net/wireless/rtl818x/rtl8180/max2820.o
  CC [M]  drivers/net/ethernet/mellanox/mlx4/en_selftest.o
  CC [M]  drivers/usb/serial/ipw.o
  CC [M]  drivers/video/nvidia/nv_i2c.o
  CC [M]  drivers/net/wireless/rt2x00/rt2500usb.o
  CC [M]  drivers/net/ethernet/intel/ixgbe/ixgbe_debugfs.o
  CC [M]  drivers/net/wireless/rtl818x/rtl8180/grf5101.o
  LD      drivers/net/ethernet/neterion/built-in.o
  CC [M]  drivers/net/ethernet/neterion/s2io.o
  CC [M]  drivers/net/ethernet/mellanox/mlx4/en_dcb_nl.o
  CC [M]  drivers/usb/serial/ir-usb.o
  CC [M]  drivers/video/nvidia/nv_backlight.o
  LD [M]  drivers/scsi/libsas/libsas.o
  LD      drivers/scsi/lpfc/built-in.o
  CC [M]  drivers/scsi/lpfc/lpfc_mem.o

478 lines not shown · raw message

4,797 lines not shown · raw message

Part of this message is not shown here. View the raw message.

#128 lore raw
In reply to Tejun Heo
Quoted 2 lines

It looks like this kernel won't compile with CONFIG_HOTPLUG_MEMORY set to 'y'

Turning off the CONFIG_HOTPLUG_MEMORY allowed the build to work.

At least for me, basic IB functionality works with the latest repo.

The ipath and qib patches look ok, but we usually use IB/<module> vs. infiniband/<module>.

Mike

author maintainer
#129 lore raw
Quoted 8 lines · Mike
Quoted 2 lines

It looks like this kernel won't compile with CONFIG_HOTPLUG_MEMORY set to 'y'

Turning off the CONFIG_HOTPLUG_MEMORY allowed the build to work.

At least for me, basic IB functionality works with the latest repo.

The ipath and qib patches look ok, but we usually use IB/<module> vs. infiniband/<module>.

Ok, renaming the patches.

Thanks.

Signature · 1 line
tejun