Skip to contentSkip to conversation

Doc: percpu_counter doc code for better readability

PATCH Superseded Jesper Dangaard Brouer 3 participants 5 messages Jan 29, 2013 – Feb 5, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Doc: percpu_counter doc code for better readability

Help people reading the percpu_counter code, to notice the ifdef else statement that seperates CONFIG_SMP.

---

 include/linux/percpu_counter.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/linux/percpu_counter.h +1 -1
index b9df9ed..eded1aa 100644
@@ -83,7 +83,7 @@ static inline int percpu_counter_initialized(struct percpu_counter *fbc)
 	return (fbc->counters != NULL);
 }
 
-#else
+#else /* No CONFIG_SMP */
 
 struct percpu_counter {
 	s64 count;
maintainer
#1 lore raw
Quoted 14 lines · Jesper Dangaard Brouer

Help people reading the percpu_counter code, to notice the ifdef else statement that seperates CONFIG_SMP.

---

 include/linux/percpu_counter.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/linux/percpu_counter.h +0 -0
index b9df9ed..eded1aa 100644

include/linux/percpu_counter.h static inline int percpu_counter_initialized(struct percpu_counter *fbc) · line 86

Quoted 5 lines
include/linux/percpu_counter.h +1 -1
@@ -83,7 +83,7 @@ static inline int percpu_counter_initialized(struct percpu_counter *fbc)
 	return (fbc->counters != NULL);
 }
 
-#else
+#else /* No CONFIG_SMP */

"#else /* !CONFIG_SMP */" would be more conventional. Can you please change that and repost it w/ my Acked-by and [TRIVIAL] tag added and Jiri Kosina <[email protected]> cc'd?

Thanks.

Signature · 1 line
tejun
#2 lore raw

PATCH v2 1/1 Doc: percpu_counter doc code for better readability

Help people reading the percpu_counter code, to notice the ifdef else statement that seperates CONFIG_SMP.

---

 include/linux/percpu_counter.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/linux/percpu_counter.h +1 -1
index b9df9ed..d5dd465 100644
@@ -83,7 +83,7 @@ static inline int percpu_counter_initialized(struct percpu_counter *fbc)
 	return (fbc->counters != NULL);
 }
 
-#else
+#else /* !CONFIG_SMP */
 
 struct percpu_counter {
 	s64 count;