Skip to contentSkip to conversation

opensm/osm_sm_state_mgr.c: Start sweep immedeately when recieving HANDOVER in DISCOVERING state

PATCH In review Alex Netes 2 participants 2 messages Feb 5, 2013 1 message not in the archive InfiniBand

lore
Share & tools
lore

Alex Netes

author
#0 lore raw

PATCH 1/1 opensm/osm_sm_state_mgr.c: Start sweep immedeately when recieving HANDOVER in DISCOVERING state

Instead of waiting fo sweep_interval to expire, start the sweep imeediately. That can speed-up SM bring up.

---
 opensm/osm_sm_state_mgr.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
opensm/osm_sm_state_mgr.c +6 -4
index 7da8258..c996ea2 100644
@@ -294,11 +294,13 @@ ib_api_status_t osm_sm_state_mgr_process(osm_sm_t * sm,
 			break;
 		case OSM_SM_SIGNAL_HANDOVER:
 			/*
-			 * Do nothing. We will discover it later on. If we already discovered
-			 * this SM, and got the HANDOVER - this means the remote SM is of
-			 * lower priority. In this case we will stop polling it (since it is
-			 * a lower priority SM in STANDBY state).
+			 * Signal for a new sweep. We need to discover the other SM.
+			 * If we already discovered this SM, and got the
+			 * HANDOVER - this means the remote SM is of lower priority.
+			 * In this case we will stop polling it (since it is a lower
+			 * priority SM in STANDBY state).
 			 */
+			osm_sm_signal(sm, OSM_SIGNAL_SWEEP);
 			break;
 		default:
 			sm_state_mgr_signal_error(sm, signal);
Signature · 6 lines
1.7.11.7

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 20130205143017.GE13151-iQai9MGU/dze+A/[email protected]

#2 lore raw

Thanks for the fast response and update. Which opensm & OFED versions will include this fix?

Note that my email has changed to emc.com - please update.
Thanks again,
Eli
________________________________________
From: Alex Netes [[email protected]] On Behalf Of Alex Netes [alexne-VPRAkNaXOzVWk0Htik3J/[email protected]]
Sent: Tuesday, February 05, 2013 4:30 PM
To: [email protected]
Cc: Eli Dorfman
Subject: [PATCH] opensm/osm_sm_state_mgr.c: Start sweep immedeately when recieving HANDOVER in DISCOVERING state

Instead of waiting fo sweep_interval to expire, start the sweep imeediately. That can speed-up SM bring up.

---
 opensm/osm_sm_state_mgr.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
opensm/osm_sm_state_mgr.c +6 -4
index 7da8258..c996ea2 100644
@@ -294,11 +294,13 @@ ib_api_status_t osm_sm_state_mgr_process(osm_sm_t * sm,
                        break;
                case OSM_SM_SIGNAL_HANDOVER:
                        /*
-                        * Do nothing. We will discover it later on. If we already discovered
-                        * this SM, and got the HANDOVER - this means the remote SM is of
-                        * lower priority. In this case we will stop polling it (since it is
-                        * a lower priority SM in STANDBY state).
+                        * Signal for a new sweep. We need to discover the other SM.
+                        * If we already discovered this SM, and got the
+                        * HANDOVER - this means the remote SM is of lower priority.
+                        * In this case we will stop polling it (since it is a lower
+                        * priority SM in STANDBY state).
                         */
+                       osm_sm_signal(sm, OSM_SIGNAL_SWEEP);
                        break;
                default:
                        sm_state_mgr_signal_error(sm, signal);

--
1.7.11.7

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html