Skip to contentSkip to conversation

ARM: Kirkwood: Add missing linux/i2c.h include

PATCH In review Thierry Reding 2 participants 4 messages Feb 5, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: Kirkwood: Add missing linux/i2c.h include

The nsa310 board uses I2C_BOARD_INFO and i2c_register_board_info(), both of which are defined in the linux/i2c.h header file.

---
 arch/arm/mach-kirkwood/board-nsa310.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-kirkwood/board-nsa310.c +1 -0
index 61c4b18..970174a 100644
@@ -11,6 +11,7 @@
 #include <linux/kernel.h>
 #include <linux/init.h>
 #include <linux/gpio.h>
+#include <linux/i2c.h>
 #include <mach/kirkwood.h>
 #include <linux/of.h>
 #include "common.h"
Signature · 1 line
1.8.1.2
#1 lore raw

Thierry,

Quoted 7 lines · Thierry Reding

The nsa310 board uses I2C_BOARD_INFO and i2c_register_board_info(), both of which are defined in the linux/i2c.h header file.

---
 arch/arm/mach-kirkwood/board-nsa310.c | 1 +
 1 file changed, 1 insertion(+)

What is this based against? We're in the process of removing this whole file for v3.9 (pinctrl, mv643xx_eth, and i2c)...

thx,

Jason.

Quoted 16 lines
arch/arm/mach-kirkwood/board-nsa310.c +1 -0
index 61c4b18..970174a 100644
@@ -11,6 +11,7 @@
 #include <linux/kernel.h>
 #include <linux/init.h>
 #include <linux/gpio.h>
+#include <linux/i2c.h>
 #include <mach/kirkwood.h>
 #include <linux/of.h>
 #include "common.h"
Signature · 1 line
1.8.1.2
#2 lore raw
Quoted 6 lines · Jason Cooper

Thierry,

Quoted 3 lines · Thierry Reding

The nsa310 board uses I2C_BOARD_INFO and i2c_register_board_info(), both of which are defined in the linux/i2c.h header file.

Quoted 7 lines
Quoted 4 lines
---
 arch/arm/mach-kirkwood/board-nsa310.c | 1 +
 1 file changed, 1 insertion(+)

What is this based against? We're in the process of removing this whole file for v3.9 (pinctrl, mv643xx_eth, and i2c)...

It's based on today's linux-next, so if you're going to drop that file for 3.9 I guess you can ignore the patch.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130205/fc81f14a/attachment.sig>

#3 lore raw
Quoted 12 lines · Thierry Reding
Quoted 11 lines · Jason Cooper

Thierry,

Quoted 7 lines · Thierry Reding

The nsa310 board uses I2C_BOARD_INFO and i2c_register_board_info(), both of which are defined in the linux/i2c.h header file.

---
 arch/arm/mach-kirkwood/board-nsa310.c | 1 +
 1 file changed, 1 insertion(+)
Quoted 5 lines
Quoted 2 lines

What is this based against? We're in the process of removing this whole file for v3.9 (pinctrl, mv643xx_eth, and i2c)...

It's based on today's linux-next, so if you're going to drop that file for 3.9 I guess you can ignore the patch.

ok, thanks.

Jason.

Quoted 2 lines

Thierry