Skip to contentSkip to conversation

p54usb: corrected USB ID for T-Com Sinus 154 data II

PATCH In review Tomasz Guszkowski 2 participants 2 messages Feb 5, 2013 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 p54usb: corrected USB ID for T-Com Sinus 154 data II

Corrected USB ID for T-Com Sinus 154 data II. ISL3887-based. The device was tested in managed mode with no security, WEP 128 bit and WPA-PSK (TKIP) with firmware 2.13.1.0.lm87.arm (md5sum: 7d676323ac60d6e1a3b6d61e8c528248). It works.

---
Hi!

I have submitted a patch for this device on Dec 22-nd 2012. A couple of days ago I fetched a new kernel, with the December-submitted patch inside, compiled it and noticed to my surprise the device didn't work. A short investigation shown wrong USB ID. I must have done an error while manually modifying p54usb.c in git tree.

My mistake.

lsusb confirms this time the ID is correct:

root@tsg-desktop:/usr/src/git# lsusb -s1:4
Bus 001 Device 004: ID 083a:4531 Accton Technology Corp.

Let's correct this bug.

Tomek

 drivers/net/wireless/p54/p54usb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/wireless/p54/p54usb.c +1 -1
index 800a165..1f78585 100644
@@ -84,8 +84,8 @@ static struct usb_device_id p54u_table[] = {
 	{USB_DEVICE(0x06b9, 0x0121)},	/* Thomson SpeedTouch 121g */
 	{USB_DEVICE(0x0707, 0xee13)},   /* SMC 2862W-G version 2 */
 	{USB_DEVICE(0x0803, 0x4310)},	/* Zoom 4410a */
-	{USB_DEVICE(0x083a, 0x4503)},	/* T-Com Sinus 154 data II */
 	{USB_DEVICE(0x083a, 0x4521)},   /* Siemens Gigaset USB Adapter 54 version 2 */
+	{USB_DEVICE(0x083a, 0x4531)},	/* T-Com Sinus 154 data II */
 	{USB_DEVICE(0x083a, 0xc501)},	/* Zoom Wireless-G 4410 */
 	{USB_DEVICE(0x083a, 0xf503)},	/* Accton FD7050E ver 1010ec  */
 	{USB_DEVICE(0x0846, 0x4240)},	/* Netgear WG111 (v2) */
Signature · 1 line
1.7.5.4
Acked-by on v1 1/1
#1 lore raw

(Added John [He takes all the driver patches ;).

John, do you want/need a line-wrapped commit message of the original patch or is this OK?)

Quoted 6 lines · Tomasz Guszkowski

Corrected USB ID for T-Com Sinus 154 data II. ISL3887-based. The device was tested in managed mode with no security, WEP 128 bit and WPA-PSK (TKIP) with firmware 2.13.1.0.lm87.arm (md5sum: 7d676323ac60d6e1a3b6d61e8c528248). It works.

Quoted 1 line

---

I'll take care of updating the wireless.kernel.org wiki
<http://wireless.kernel.org/en/users/Drivers/p54/devices>
entry later this week.

OT: The latest supported firmware for LM87 is: 2.13.25.0.lm87.arm Did you experience issues with the new version, or do you simply stick with the old 2.13.1.0 because it does work just as well?

Regards

Christian