Skip to contentSkip to conversation

boost: bump version to 1.53.0

PATCH New victor.hiairrassary.ml at gmail.com 3 participants 8 messages Feb 6, 2013 – Feb 7, 2013

lore
Share & tools
lore
#1 lore raw

PATCH 1/1 boost: bump version to 1.53.0

From: Victor Hiairrassary <[email protected]>

---
 package/boost/Config.in | 3 +++
 package/boost/boost.mk  | 5 +++--
 2 files changed, 6 insertions(+), 2 deletions(-)
package/boost/Config.in +3 -0
index 19dcc60..e36e7d3 100644
@@ -21,6 +21,9 @@ if BR2_PACKAGE_BOOST
 config BR2_PACKAGE_BOOST_CHRONO
 	bool "boost-chrono"
 
+config BR2_PACKAGE_BOOST_CONTEXT
+	bool "boost-context"
+
 config BR2_PACKAGE_BOOST_DATE_TIME
 	bool "boost-date_time"
 
package/boost/boost.mk +3 -2
index 5e1bb4e..a056662 100644
@@ -4,7 +4,7 @@
 #
 #############################################################
 
-BOOST_VERSION = 1.52.0
+BOOST_VERSION = 1.53.0
 BOOST_FILE_VERSION = $(subst .,_,$(BOOST_VERSION))
 BOOST_SOURCE = boost_$(BOOST_FILE_VERSION).tar.bz2
 BOOST_SITE = http://downloads.sourceforge.net/project/boost/boost/$(BOOST_VERSION)
@@ -15,9 +15,10 @@ TARGET_CC_VERSION = $(shell $(TARGET_CC) -dumpversion)
 BOOST_DEPENDENCIES = bzip2 zlib
 
 BOOST_FLAGS =
-BOOST_WITHOUT_FLAGS = python context
+BOOST_WITHOUT_FLAGS = python atomic
 
 BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_CHRONO),,chrono)
+BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_CHRONO),,context)
 BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_DATE_TIME),,date_time)
 BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_EXCEPTION),,exception)
 BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_FILESYSTEM),,filesystem)
Signature · 1 line
1.8.1.2
#2 lore raw

PATCH 1/1 boost: bump version to 1.53.0

Dear victor.hiairrassary.ml at gmail.com,

package/boost/boost.mk TARGET_CC_VERSION = $(shell $(TARGET_CC) -dumpversion) · line 18

Quoted 3 lines · victor.hiairrassary.ml at gmail.com

BOOST_FLAGS =

package/boost/boost.mk +1 -1
-BOOST_WITHOUT_FLAGS = python context
+BOOST_WITHOUT_FLAGS = python atomic

Maybe there was a reason why "context" was unconditionally excluded from the build, before your patch. Did you check why?

Also, it would be good to have a comment here that explains why python and atomic are unconditionally excluded for the build.

Thanks,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#3 lore raw

PATCH 1/1 boost: bump version to 1.53.0

On 02/06/2013 10:32 AM, Thomas Petazzoni wrote:

Dear victor.hiairrassary.ml at gmail.com,

On Wed, 6 Feb 2013 10:30:04 +0100, victor.hiairrassary.ml at gmail.com wrote:

BOOST_FLAGS =
-BOOST_WITHOUT_FLAGS = python context
+BOOST_WITHOUT_FLAGS = python atomic

Maybe there was a reason why "context" was unconditionally excluded
from the build, before your patch. Did you check why?

context was excluded because compilation is impossible with boost
1.52.0 and uClibc, there is a problem with uintptr_t and intptr_t. But this is fixed in latest version, 1.53.0.

Also, it would be good to have a comment here that explains why python and atomic are unconditionally excluded for the build.

atomic is a new boost library since boost 1.53.0. It is excluded because
it can not compile with uClibc (uintptr_t missing too), but this is now fixed in
trunk version, see ticket https://svn.boost.org/trac/boost/ticket/7979

In this patch, atomic is simply excluded. So either we wait for boost 1.54.0 releasing orI can add the patch to fix atomic compilation in buildroot and add boost-atomic in menuconfig?

I do not nothing about pyhton exclusion, sorry.

Thanks,

Thomas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130206/f744c1a1/attachment.html>

#4 lore raw

PATCH 1/1 boost: bump version to 1.53.0

Dear Victor Hiairrassary,

Would it be possible to use an e-mail client that complies with the open-source community standards, by sending e-mails as plain text? The plain text version of your e-mail makes no discussion between what you said and what I said, which is very confusing.

Quoted 6 lines · Victor Hiairrassary

Maybe there was a reason why "context" was unconditionally excluded
from the build, before your patch. Did you check why?

context was excluded because compilation is impossible with boost
1.52.0 and uClibc, there is a problem with uintptr_t and intptr_t. But this is fixed in latest version, 1.53.0.

Ok. This should be mentioned in the commit log, then.

Quoted 7 lines

Also, it would be good to have a comment here that explains why python and atomic are unconditionally excluded for the build.

atomic is a new boost library since boost 1.53.0. It is excluded because
it can not compile with uClibc (uintptr_t missing too), but this is now fixed in
trunk version, see ticket https://svn.boost.org/trac/boost/ticket/7979

Ok. This should be mentioned in a comment above the line that disables the atomic module, so that we know in the future why it is disabled.

Quoted 3 lines

In this patch, atomic is simply excluded. So either we wait for boost 1.54.0 releasing orI can add the patch to fix atomic compilation in buildroot and add boost-atomic in menuconfig?

No, it's perfectly fine to have the atomic thing disabled for now, since it wasn't available in Buildroot until now. I just want a comment explaining why it's disabled.

Quoted 1 line

I do not nothing about pyhton exclusion, sorry.

Ok. But since you're not changing this, it's not necessarily your responsibility to justify this, so we can leave this part as is.

Could you resubmit a new version of the patch, with more details in the commit log, and a comment before the line disabling the atomic module?

Thanks a lot!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#5 lore raw

PATCH 1/1 boost: bump version to 1.53.0

Quoted 6 lines · Thomas Petazzoni

Dear Victor Hiairrassary,

Would it be possible to use an e-mail client that complies with the open-source community standards, by sending e-mails as plain text? The plain text version of your e-mail makes no discussion between what you said and what I said, which is very confusing.

Oh, sorry for the mistake!

Quoted 2 lines

Could you resubmit a new version of the patch, with more details in the commit log, and a comment before the line disabling the atomic module?

Done in another mail! I hope that everything is good!

Victor Hiairrassary

Quoted 3 lines

Thanks a lot!

Thomas

#6 lore raw

PATCH 1/1 boost: bump version to 1.53.0

In reply to Thomas Petazzoni
Quoted 8 lines · Thomas Petazzoni

Dear Victor Hiairrassary,

Could you resubmit a new version of the patch, with more details in the commit log, and a comment before the line disabling the atomic module?

Thanks a lot!

Thomas

Yesterday I've sent the new patch through (git send-email) on buildroot at busybox.net. But it is only available on buildroot patchwork at http://patchwork.ozlabs.org/patch/218673/ and not on mailing list (I don't know why).

Regards,

Victor Hiairrassary

#7 lore raw

PATCH 1/1 boost: bump version to 1.53.0

Hi Victor,

Quoted 11 lines · Victor Hiairrassary
Quoted 6 lines · Thomas Petazzoni

Could you resubmit a new version of the patch, with more details in the commit log, and a comment before the line disabling the atomic module?

Thanks a lot!

Thomas

Yesterday I've sent the new patch through (git send-email) on buildroot at busybox.net. But it is only available on buildroot patchwork at http://patchwork.ozlabs.org/patch/218673/ and not on mailing list (I don't know why).

I got it. It is also archived at
http://lists.busybox.net/pipermail/buildroot/2013-February/066841.html.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -