Skip to contentSkip to conversation

boost: Pass staging dir to --with-icu option.

PATCH New Ignacy Gawedzki 4 participants 8 messages Feb 7, 2013 – Feb 9, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 boost: Pass staging dir to --with-icu option.

When using the --with-icu option without specifying the directory, boost's bootstrap.sh script will look at "common" locations (lines 289-294):

COMMON_ICU_PATHS="/usr /usr/local /sw" for p in $COMMON_ICU_PATHS; do
if test -r $p/include/unicode/utypes.h; then
ICU_ROOT=$p
fi
done

With buildroot it may surely become problematic at some point.

---
 package/boost/boost.mk |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/boost/boost.mk +1 -1
index 5e1bb4e..a202848 100644
@@ -39,7 +39,7 @@ BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_TIMER),,timer)
 BOOST_WITHOUT_FLAGS += $(if $(BR2_PACKAGE_BOOST_WAVE),,wave)
 
 ifeq ($(BR2_PACKAGE_ICU),y)
-BOOST_FLAGS += --with-icu
+BOOST_FLAGS += --with-icu=$(STAGING_DIR)/usr
 BOOST_DEPENDENCIES += icu
 else
 BOOST_FLAGS += --without-icu
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 boost: Pass staging dir to --with-icu option.

Dear Ignacy Gawedzki,

Quoted 4 lines · Ignacy Gawedzki

When using the --with-icu option without specifying the directory, boost's bootstrap.sh script will look at "common" locations (lines 289-294):

Quoted 8 lines

COMMON_ICU_PATHS="/usr /usr/local /sw" for p in $COMMON_ICU_PATHS; do
if test -r $p/include/unicode/utypes.h; then
ICU_ROOT=$p
fi
done

With buildroot it may surely become problematic at some point.

This looks sensible. However, it doesn't explain how Boost could have been finding ICU before your patch. Any idea?

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw

PATCH 1/1 boost: Pass staging dir to --with-icu option.

On Thu, Feb 07, 2013 at 03:47:00PM +0100, thus spake Thomas Petazzoni:

Quoted 14 lines

Dear Ignacy Gawedzki,

Quoted 11 lines · Ignacy Gawedzki

When using the --with-icu option without specifying the directory, boost's bootstrap.sh script will look at "common" locations (lines 289-294):

COMMON_ICU_PATHS="/usr /usr/local /sw" for p in $COMMON_ICU_PATHS; do
if test -r $p/include/unicode/utypes.h; then
ICU_ROOT=$p
fi
done

Quoted 4 lines
Quoted 1 line

With buildroot it may surely become problematic at some point.

This looks sensible. However, it doesn't explain how Boost could have been finding ICU before your patch. Any idea?

The answer to this question may be in the following lines of bootstrap.sh. If ICU is not found in any of those "common" locations, then bjam is called without any -sICU_PATH option and it may be that it finds the correct location automatically (by using passed LDFLAGS or something).

I started using Boost with ICU very recently, so I can't tell from my own experience if this is what happens indeed.

Signature · 1 line
Information wants to be beer, or something like that.
#3 lore raw

PATCH 1/1 boost: Pass staging dir to --with-icu option.

Dear Ignacy Gawedzki,

Quoted 5 lines · Ignacy Gawedzki

The answer to this question may be in the following lines of bootstrap.sh. If ICU is not found in any of those "common" locations, then bjam is called without any -sICU_PATH option and it may be that it finds the correct location automatically (by using passed LDFLAGS or something).

Ok, makes sense. Thank you!

Best regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#4 lore raw

PATCH 1/1 boost: Pass staging dir to --with-icu option.

In reply to Ignacy Gawedzki
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Ignacy" == Ignacy Gawedzki <[email protected]> writes:

Ignacy> When using the --with-icu option without specifying the Ignacy> directory, boost's bootstrap.sh script will look at "common" Ignacy> locations (lines 289-294):

Ignacy> COMMON_ICU_PATHS="/usr /usr/local /sw"
Ignacy> for p in $COMMON_ICU_PATHS; do
Ignacy> if test -r $p/include/unicode/utypes.h; then
Ignacy> ICU_ROOT=$p
Ignacy> fi
Ignacy> done

Ignacy> With buildroot it may surely become problematic at some point. Ignacy> ---

Can you please provide your signed-off-by so I can apply this? Thanks.

Signature · 1 line
Bye, Peter Korsgaard
#5 lore raw

PATCH 1/1 boost: Pass staging dir to --with-icu option.

On Fri, Feb 08, 2013 at 10:27:35PM +0100, thus spake Peter Korsgaard:

Quoted 14 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Ignacy" == Ignacy Gawedzki <[email protected]> writes:

Ignacy> When using the --with-icu option without specifying the Ignacy> directory, boost's bootstrap.sh script will look at "common" Ignacy> loscript will look at "common"
Ignacy> locations (lines 289-294):

Ignacy> COMMON_ICU_PATHS="/usr /usr/local /sw"
Ignacy> for p in $COMMON_ICU_PATHS; do
Ignacy> if test -r $p/include/unicode/utypes.h; then
Ignacy> ICU_ROOT=$p
Ignacy> fi
Ignacy> done

Quoted 4 lines

Ignacy> With buildroot it may surely become problematic at some point. Ignacy> ---

Can you please provide your signed-off-by so I can apply t

Do you mean this simple line:

?

Signature · 2 lines
A person is shit's way of making more shit.
		-- S. Barnett, anthropologist.
#6 lore raw

PATCH 1/1 boost: Pass staging dir to --with-icu option.

Ignacy, All,

Quoted 4 lines · On Friday 08 February 2013 Ignacy Gawedzki wrote:

On Fri, Feb 08, 2013 at 10:27:35PM +0100, thus spake Peter Korsgaard:

Quoted 1 line

Can you please provide your signed-off-by so I can apply t

Do you mean this simple line:

Yes, see: http://www.elinux.org/Developer_Certificate_Of_Origin

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#7 lore raw

PATCH 1/1 boost: Pass staging dir to --with-icu option.

In reply to Ignacy Gawedzki
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Ignacy" == Ignacy Gawedzki <[email protected]> writes:

Ignacy> On Fri, Feb 08, 2013 at 10:27:35PM +0100, thus spake Peter Korsgaard:

Quoted 2 lines
Quoted 2 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Ignacy" == Ignacy Gawedzki <[email protected]> writes:

Ignacy> When using the --with-icu option without specifying the Ignacy> directory, boost's bootstrap.sh script will look at "common" Ignacy> loscript will look at "common"
Ignacy> locations (lines 289-294):

Quoted 1 line
Quoted 1 line

Ignacy> COMMON_ICU_PATHS="/usr /usr/local /sw" Ignacy> for p in $COMMON_ICU_PATHS; do Ignacy> if test -r $p/include/unicode/utypes.h; then Ignacy> ICU_ROOT=$p
Ignacy> fi
Ignacy> done

Quoted 1 line
Quoted 1 line

Ignacy> With buildroot it may surely become problematic at some point. Ignacy> ---

Quoted 2 lines
Quoted 2 lines

Can you please provide your signed-off-by so I can apply t

Ignacy> Do you mean this simple line:

Ignacy> Signed-off-by: Ignacy Gaw?dzki <[email protected]>

Yes, committed - Thanks.

Signature · 1 line
Bye, Peter Korsgaard