fc0011: Add some sanity checks and cleanups
Subsystems (2)
Michael Büsch
maintainerPATCH 3/4 fc0011: Add some sanity checks and cleanups
Add some sanity checks to the calculations and make the REG_16 register write consistent with the other ones.
Signed-off-by Michael Buesch <[email protected]>
---
drivers/media/tuners/fc0011.c +5 -1
@@ -220,6 +220,7 @@/* Calc XIN. The PLL reference frequency is 18 MHz. */ xdiv = fvco /18000 ; +WARN_ON (xdiv >0xFF ); frac = fvco - xdiv *18000 ; frac = (frac <<15 ) /18000 ;if (frac >=16384 )
@@ -346,6 +347,8 @@ vco_cal &=FC11_VCOCAL_VALUEMASK ;switch (vco_sel) { +default : +WARN_ON (1 );case 0 :if (vco_cal <8 ) { regs[FC11_REG_VCOSEL ] &= ~(FC11_VCOSEL_1 |FC11_VCOSEL_2 );
@@ -427,7 +430,8 @@ err =fc0011_writereg (priv,FC11_REG_RCCAL , regs[FC11_REG_RCCAL ]);if (err)return err; - err =fc0011_writereg (priv,FC11_REG_16 ,0xB ); + regs[FC11_REG_16 ] =0xB ; + err =fc0011_writereg (priv,FC11_REG_16 , regs[FC11_REG_16 ]);if (err)return err;
Signature · 3 lines
Greetings, Michael. PGP: 908D8B0E