Skip to contentSkip to conversation

ARM: tegra: enable ARCH_REQUIRE_GPIOLIB for Tegra114

PATCH New Stephen Warren 2 participants 3 messages Feb 7, 2013 – Feb 10, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ARM: tegra: enable ARCH_REQUIRE_GPIOLIB for Tegra114

From: Stephen Warren <[email protected]>

CONFIG_ARCH_TEGRA_114_SOC doesn't currently enable gpiolib, which causes numerous build problems building a Tegra kernel with only Tegra114 enabled, and not Tegra20 or Tegra30. Enable ARCH_REQUIRE_GPIOLIB to solve this. However, all Tegra will use gpiolib, so select this option from ARCH_TEGRA rather than each individual ARCH_TEGRA_*_SOC, to prevent this problem for any future chips.

---
Olof, Arnd, These two patches can be applied on top of Tegra's previous tegra-for-3.9-soc-t114 branch.

I think this (coupled with Hiroshi's "ARM: tegra: Fix build error w/ ARCH_TEGRA_114_SOC w/o ARCH_TEGRA_3x_SOC" is it for build failure fixes, although I'm queueing up a number of clock driver patches for which I'll send a pull request in the next few days.

 arch/arm/Kconfig            |    1 +
 arch/arm/mach-tegra/Kconfig |    2 --
 2 files changed, 1 insertion(+), 2 deletions(-)
arch/arm/Kconfig +1 -0
index 4265a26..7ea0866 100644
@@ -643,6 +643,7 @@ config ARCH_LPC32XX
 config ARCH_TEGRA
 	bool "NVIDIA Tegra"
 	select ARCH_HAS_CPUFREQ
+	select ARCH_REQUIRE_GPIOLIB
 	select CLKDEV_LOOKUP
 	select CLKSRC_MMIO
 	select CLKSRC_OF
arch/arm/mach-tegra/Kconfig +0 -2
index bde8197..8654324 100644
@@ -5,7 +5,6 @@ comment "NVIDIA Tegra options"
 config ARCH_TEGRA_2x_SOC
 	bool "Enable support for Tegra20 family"
 	select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP
-	select ARCH_REQUIRE_GPIOLIB
 	select ARM_ERRATA_720789
 	select ARM_ERRATA_742230 if SMP
 	select ARM_ERRATA_751472
@@ -27,7 +26,6 @@ config ARCH_TEGRA_2x_SOC
 
 config ARCH_TEGRA_3x_SOC
 	bool "Enable support for Tegra30 family"
-	select ARCH_REQUIRE_GPIOLIB
 	select ARM_ERRATA_743622
 	select ARM_ERRATA_751472
 	select ARM_ERRATA_754322
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 2/2 ARM: tegra: sort Kconfig selects for Tegra114

From: Stephen Warren <[email protected]>

The Kconfig options selected by ARCH_TEGRA_*_SOC were recently sorted. Update the newly added ARCH_TEGRA_114_SOC's select statements to match.

---
 arch/arm/mach-tegra/Kconfig |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-tegra/Kconfig +2 -2
index 8654324..d1c4893 100644
@@ -45,10 +45,10 @@ config ARCH_TEGRA_3x_SOC
 
 config ARCH_TEGRA_114_SOC
 	bool "Enable support for Tegra114 family"
+	select ARM_ARCH_TIMER
 	select ARM_GIC
-	select CPU_V7
 	select ARM_L1_CACHE_SHIFT_6
-	select ARM_ARCH_TIMER
+	select CPU_V7
 	select PINCTRL
 	select PINCTRL_TEGRA114
 	help
Signature · 1 line
1.7.10.4
#2 lore raw

PATCH 1/2 ARM: tegra: enable ARCH_REQUIRE_GPIOLIB for Tegra114

In reply to Stephen Warren
Quoted 10 lines · Stephen Warren

From: Stephen Warren <[email protected]>

CONFIG_ARCH_TEGRA_114_SOC doesn't currently enable gpiolib, which causes numerous build problems building a Tegra kernel with only Tegra114 enabled, and not Tegra20 or Tegra30. Enable ARCH_REQUIRE_GPIOLIB to solve this. However, all Tegra will use gpiolib, so select this option from ARCH_TEGRA rather than each individual ARCH_TEGRA_*_SOC, to prevent this problem for any future chips.

Quoted 8 lines

---
Olof, Arnd, These two patches can be applied on top of Tegra's previous tegra-for-3.9-soc-t114 branch.

I think this (coupled with Hiroshi's "ARM: tegra: Fix build error w/ ARCH_TEGRA_114_SOC w/o ARCH_TEGRA_3x_SOC" is it for build failure fixes, although I'm queueing up a number of clock driver patches for which I'll send a pull request in the next few days.

Thanks, applied both to the tegra/t114 branch (together with the above mentioned fix).

-Olof