Skip to contentSkip to conversation

ARM: clps711x: Move lowlevel initialization in common CLPS711X location

PATCH In review Alexander Shiyan 3 participants 18 messages Feb 8, 2013 – Feb 11, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/11 ARM: clps711x: Move lowlevel initialization in common CLPS711X location

One lowlevel initialization will be used on any CLPS711X-target, so move it in the common location.

---
 arch/arm/boards/clep7212/Makefile   |    3 +-
 arch/arm/boards/clep7212/lowlevel.c |   57 -----------------------------------
 arch/arm/mach-clps711x/Makefile     |    3 +-
 arch/arm/mach-clps711x/lowlevel.c   |   57 +++++++++++++++++++++++++++++++++++
 4 files changed, 60 insertions(+), 60 deletions(-)
 delete mode 100644 arch/arm/boards/clep7212/lowlevel.c
 create mode 100644 arch/arm/mach-clps711x/lowlevel.c
arch/arm/boards/clep7212/Makefile +1 -2
index a63aeae..676e867 100644
@@ -1,2 +1 @@
-obj-y += lowlevel.o clep7212.o
-pbl-y += lowlevel.o
+obj-y += clep7212.o
arch/arm/boards/clep7212/lowlevel.c deleted +0 -57

57 lines not on this page · raw message

arch/arm/mach-clps711x/Makefile +2 -1
index 41012bc..69a4a3c 100644
@@ -1 +1,2 @@
-obj-y += clock.o devices.o reset.o
+obj-y += clock.o devices.o lowlevel.o reset.o
+pbl-y += lowlevel.o
arch/arm/mach-clps711x/lowlevel.c new file +57 -0

57 lines not on this page · raw message

Signature · 7 lines
1.7.3.4


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#1 lore raw

PATCH 2/11 ARM: clps711x: Fix SDRAM setup comment

We are set up maximum SDRAM size 64MB, so fix comment text.

---
 arch/arm/mach-clps711x/lowlevel.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-clps711x/lowlevel.c +1 -1
index b4d1bf1..0249c60 100644
@@ -49,7 +49,7 @@ void __naked __bare_init barebox_arm_reset_vector(void)
 	/* Setup Refresh Rate (64ms 8K Blocks) */
 	writel(SDRAM_REFRESH_RATE, SDRFPR);
 
-	/* Setup SDRAM (32MB, 16Bit*2, CAS=3) */
+	/* Setup SDRAM params (64MB, 16Bit*2, CAS=3) */
 	writel(SDCONF_CASLAT_3 | SDCONF_SIZE_256 | SDCONF_WIDTH_16 |
 	       SDCONF_CLKCTL | SDCONF_ACTIVE, SDCONF);
 
Signature · 7 lines
1.7.3.4


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#2 lore raw

PATCH 3/11 ARM: clps711x: Adds config option for CPU PLL multiplier

In reply to Alexander Shiyan
---
 arch/arm/mach-clps711x/Kconfig    |   13 +++++++++++++
 arch/arm/mach-clps711x/lowlevel.c |    4 ++--
 2 files changed, 15 insertions(+), 2 deletions(-)
arch/arm/mach-clps711x/Kconfig +13 -0
index f0adeda..d2873b4 100644
@@ -10,6 +10,19 @@ config MACH_CLEP7212
 
 endchoice
 
+menu "CLPS711X specific settings"
+
+config CLPS711X_CPU_PLL_MULT
+	int "CPU PLL multiplier (20-50)"
+	range 20 50
+	default "40"
+	help
+	  Define CPU PLL multiplier. PLL is calculated by formula:
+	    PLL Frequency = (PLL Multiplier / 2) * 3686400 Hz
+	  Default value is 40, for achieve 73 MHz.
+
+endmenu
+
 config BOARDINFO
 	default "Cirrus Logic CLEP7212" if MACH_CLEP7212
 
arch/arm/mach-clps711x/lowlevel.c +2 -2
index 0249c60..245ac93 100644
@@ -18,10 +18,10 @@
 #include <mach/clps711x.h>
 
 #define MAIN_CLOCK		3686400
-#define CPU_SPEED		92160000
+#define CPU_SPEED		((CONFIG_CLPS711X_CPU_PLL_MULT * MAIN_CLOCK) / 2)
 #define BUS_SPEED		(CPU_SPEED / 2)
 
-#define PLL_VALUE		(((CPU_SPEED * 2) / MAIN_CLOCK) << 24)
+#define PLL_VALUE		(CONFIG_CLPS711X_CPU_PLL_MULT << 24)
 #define SDRAM_REFRESH_RATE	(64 * (BUS_SPEED / (8192 * 1000)))
 
 void __naked __bare_init barebox_arm_reset_vector(void)
Signature · 7 lines
1.7.3.4


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#3 lore raw

Re: [PATCH 03/11] ARM: clps711x: Adds config option for CPU PLL multiplier

Quoted 16 lines · Alexander Shiyan
---
 arch/arm/mach-clps711x/Kconfig    |   13 +++++++++++++
 arch/arm/mach-clps711x/lowlevel.c |    4 ++--
 2 files changed, 15 insertions(+), 2 deletions(-)
arch/arm/mach-clps711x/Kconfig +1 -0
index f0adeda..d2873b4 100644
@@ -10,6 +10,19 @@ config MACH_CLEP7212
 
 endchoice
 
+menu "CLPS711X specific settings"

arch/arm/mach-clps711x/Kconfig config MACH_CLEP7212 · line 23

Quoted 10 lines
arch/arm/mach-clps711x/Kconfig +10 -0
+
+config CLPS711X_CPU_PLL_MULT
+	int "CPU PLL multiplier (20-50)"
+	range 20 50
+	default "40"
+	help
+	  Define CPU PLL multiplier. PLL is calculated by formula:
+	    PLL Frequency = (PLL Multiplier / 2) * 3686400 Hz
+	  Default value is 40, for achieve 73 MHz.
+

this board specific put this in c code
kconfig is too easy to break

check how we do on at91

Best Regards,
J.

Quoted 30 lines
arch/arm/mach-clps711x/Kconfig +2 -0
+endmenu
+
 config BOARDINFO
 	default "Cirrus Logic CLEP7212" if MACH_CLEP7212
 
arch/arm/mach-clps711x/lowlevel.c +2 -2
index 0249c60..245ac93 100644
@@ -18,10 +18,10 @@
 #include <mach/clps711x.h>
 
 #define MAIN_CLOCK		3686400
-#define CPU_SPEED		92160000
+#define CPU_SPEED		((CONFIG_CLPS711X_CPU_PLL_MULT * MAIN_CLOCK) / 2)
 #define BUS_SPEED		(CPU_SPEED / 2)
 
-#define PLL_VALUE		(((CPU_SPEED * 2) / MAIN_CLOCK) << 24)
+#define PLL_VALUE		(CONFIG_CLPS711X_CPU_PLL_MULT << 24)
 #define SDRAM_REFRESH_RATE	(64 * (BUS_SPEED / (8192 * 1000)))
 
 void __naked __bare_init barebox_arm_reset_vector(void)
Signature · 7 lines
1.7.3.4


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

#4 lore raw

Re[2]: [PATCH 03/11] ARM: clps711x: Adds config option for CPU PLL multiplier

Hello.

...

Quoted 14 lines

arch/arm/mach-clps711x/Kconfig config MACH_CLEP7212 · line 23

Quoted 11 lines
arch/arm/mach-clps711x/Kconfig +11 -0
+menu "CLPS711X specific settings"
+
+config CLPS711X_CPU_PLL_MULT
+	int "CPU PLL multiplier (20-50)"
+	range 20 50
+	default "40"
+	help
+	  Define CPU PLL multiplier. PLL is calculated by formula:
+	    PLL Frequency = (PLL Multiplier / 2) * 3686400 Hz
+	  Default value is 40, for achieve 73 MHz.
+

this board specific put this in c code
kconfig is too easy to break

Quoted 1 line

check how we do on at91

This is not board-specific, this is CPU-specific. PLL multiplier is set up at the start and we not touch it anymore since all system frequencies is depends on it, including SDRAM refresh.
How to place this configurable parameter in C code i am not understand. For Kconfig, we can add additional compile-time checker into lowlevel unit which uses this symbol:

#if (CLPS711X_CPU_PLL_MULT < 20) || (CLPS711X_CPU_PLL_MULT > 50) #error "CPU PLL multiplier out of range"
#endif

Thanks!

---
_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

#5 lore raw

Re: [SPAM] Re[2]: [PATCH 03/11] ARM: clps711x: Adds config option for CPU PLL multiplier

Quoted 26 lines · Alexander Shiyan

Hello.

...

Quoted 14 lines

arch/arm/mach-clps711x/Kconfig config MACH_CLEP7212 · line 23

Quoted 11 lines
arch/arm/mach-clps711x/Kconfig +11 -0
+menu "CLPS711X specific settings"
+
+config CLPS711X_CPU_PLL_MULT
+	int "CPU PLL multiplier (20-50)"
+	range 20 50
+	default "40"
+	help
+	  Define CPU PLL multiplier. PLL is calculated by formula:
+	    PLL Frequency = (PLL Multiplier / 2) * 3686400 Hz
+	  Default value is 40, for achieve 73 MHz.
+

this board specific put this in c code
kconfig is too easy to break

Quoted 1 line

check how we do on at91

This is not board-specific, this is CPU-specific. PLL multiplier is set up at the start and we not touch it anymore since all system frequencies is depends on it, including SDRAM refresh.
How to place this configurable parameter in C code i am not understand. For Kconfig, we can add additional compile-time checker into lowlevel unit which uses this symbol:

Quoted 3 lines

#if (CLPS711X_CPU_PLL_MULT < 20) || (CLPS711X_CPU_PLL_MULT > 50) #error "CPU PLL multiplier out of range"
#endif

so it's even worse

detect the cpu in c and dorp the Kconfig

Best Regards,
J.

Quoted 4 lines

Thanks!

---

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

#6 lore raw

PATCH 4/11 ARM: clps711x: Decrease initial memory size to 8MB

In reply to Alexander Shiyan

Minimal known SDRAM size for CLPS711X-target is 8MB, so decrease initial memory size to this value.

---
 arch/arm/mach-clps711x/lowlevel.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-clps711x/lowlevel.c +1 -1
index 245ac93..7eed556 100644
@@ -53,5 +53,5 @@ void __naked __bare_init barebox_arm_reset_vector(void)
 	writel(SDCONF_CASLAT_3 | SDCONF_SIZE_256 | SDCONF_WIDTH_16 |
 	       SDCONF_CLKCTL | SDCONF_ACTIVE, SDCONF);
 
-	barebox_arm_entry(SDRAM0_BASE, SZ_32M, 0);
+	barebox_arm_entry(SDRAM0_BASE, SZ_8M, 0);
 }
Signature · 7 lines
1.7.3.4


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#7 lore raw

PATCH 5/11 ARM: clps711x: Remove unused "start" declaration from reset.c

In reply to Alexander Shiyan
---
 arch/arm/mach-clps711x/reset.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
arch/arm/mach-clps711x/reset.c +0 -2
index 4a42ef4..67c9c8b 100644
@@ -9,8 +9,6 @@
 
 #include <common.h>
 
-extern void start(void);
-
 void __noreturn reset_cpu(unsigned long addr)
 {
 	arch_shutdown();
Signature · 7 lines
1.7.3.4


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#8 lore raw

PATCH 6/11 ARM: clps711x: Mark private functions that not will be used outside as static

In reply to Alexander Shiyan
---
 arch/arm/mach-clps711x/clock.c   |    8 +++-----
 arch/arm/mach-clps711x/devices.c |    2 +-
 2 files changed, 4 insertions(+), 6 deletions(-)
arch/arm/mach-clps711x/clock.c +3 -5
index 5cafba9..09cbaf9 100644
@@ -15,13 +15,11 @@
 
 #include <mach/clps711x.h>
 
-struct clk {
+static struct clk {
 	unsigned long	rate;
-};
-
-static struct clk uart_clk, bus_clk;
+} uart_clk, bus_clk;
 
-uint64_t clocksource_read(void)
+static uint64_t clocksource_read(void)
 {
 	return ~readw(TC2D);
 }
arch/arm/mach-clps711x/devices.c +1 -1
index 08f27d2..de5813a 100644
@@ -14,7 +14,7 @@
 
 #include <mach/clps711x.h>
 
-inline void _clps711x_setup_memcfg(int bank, u32 addr, u32 val)
+inline static void _clps711x_setup_memcfg(int bank, u32 addr, u32 val)
 {
 	u32 tmp = readl(addr);
 
Signature · 7 lines
1.7.3.4


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#9 lore raw

PATCH 7/11 ARM: clep7212: Fix NULL pointer exception if MMU is enabled

In reply to Alexander Shiyan

NOR-flash is placed at address 0x0, so if MMU is turned on, initialization will fails. This patch fix this problem.

---
 arch/arm/boards/clep7212/clep7212.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
arch/arm/boards/clep7212/clep7212.c +5 -1
index a32337f..b96e480 100644
@@ -14,6 +14,7 @@
 #include <io.h>
 #include <sizes.h>
 #include <asm/armlinux.h>
+#include <asm/mmu.h>
 #include <generated/mach-types.h>
 
 #include <mach/clps711x.h>
@@ -32,6 +33,7 @@ mem_initcall(clps711x_mem_init);
 static int clps711x_devices_init(void)
 {
 	u32 serial_h = 0, serial_l = readl(UNIQID);
+	void *cfi_io;
 
 	/* Setup Chipselects */
 	clps711x_setup_memcfg(0, MEMCFG_WAITSTATE_6_1 | MEMCFG_BUS_WIDTH_16);
@@ -40,7 +42,9 @@ static int clps711x_devices_init(void)
 			      MEMCFG_CLKENB);
 	clps711x_setup_memcfg(3, MEMCFG_WAITSTATE_6_1 | MEMCFG_BUS_WIDTH_32);
 
-	add_cfi_flash_device(0, CS0_BASE, SZ_32M, 0);
+	cfi_io = map_io_sections(CS0_BASE, (void *)0x90000000, SZ_32M);
+	add_cfi_flash_device(DEVICE_ID_DYNAMIC, (unsigned long)cfi_io, SZ_32M,
+			     IORESOURCE_MEM);
 
 	devfs_add_partition("nor0", 0x00000, SZ_256K, DEVFS_PARTITION_FIXED,
 			    "self0");
Signature · 7 lines
1.7.3.4


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#10 lore raw

PATCH 8/11 ARM: mmu: Clear unpredictable bits for translation table

In reply to Alexander Shiyan
---
 arch/arm/cpu/mmu.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
arch/arm/cpu/mmu.c +3 -0
index 73dd0d3..99f12b5 100644
@@ -279,6 +279,9 @@ static int mmu_init(void)
 	if (get_cr() & CR_M) {
 		asm volatile ("mrc  p15,0,%0,c2,c0,0" : "=r"(ttb));
 
+		/* Clear unpredictable bits [13:0] */
+		ttb = (unsigned long *)((unsigned long)ttb & ~0x3fff);
+
 		if (!request_sdram_region("ttb", (unsigned long)ttb, SZ_16K))
 			pr_err("Error: Can't request SDRAM region for ttb\n");
 	} else {
Signature · 7 lines
1.7.3.4


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#11 lore raw

Re: [PATCH 08/11] ARM: mmu: Clear unpredictable bits for translation table

Quoted 2 lines · Alexander Shiyan

Applied this one for master.

Sascha

Quoted 27 lines
---
 arch/arm/cpu/mmu.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
arch/arm/cpu/mmu.c +3 -0
index 73dd0d3..99f12b5 100644
@@ -279,6 +279,9 @@ static int mmu_init(void)
 	if (get_cr() & CR_M) {
 		asm volatile ("mrc  p15,0,%0,c2,c0,0" : "=r"(ttb));
 
+		/* Clear unpredictable bits [13:0] */
+		ttb = (unsigned long *)((unsigned long)ttb & ~0x3fff);
+
 		if (!request_sdram_region("ttb", (unsigned long)ttb, SZ_16K))
 			pr_err("Error: Can't request SDRAM region for ttb\n");
 	} else {
Signature · 7 lines
1.7.3.4


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Signature · 9 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#12 lore raw

PATCH 9/11 ARM: clps711x: Move memory initialization in common CLPS711X location

In reply to Alexander Shiyan

One memory initialization will be used on any CLPS711X-target, so move it in the common location.

---
 arch/arm/boards/clep7212/clep7212.c |   10 ----------
 arch/arm/mach-clps711x/devices.c    |   12 ++++++++++++
 2 files changed, 12 insertions(+), 10 deletions(-)
arch/arm/boards/clep7212/clep7212.c +0 -10
index b96e480..ec9a9cb 100644
@@ -20,16 +20,6 @@
 #include <mach/clps711x.h>
 #include <mach/devices.h>
 
-static int clps711x_mem_init(void)
-{
-	ulong memsize = get_ram_size((ulong *)SDRAM0_BASE, SZ_32M);
-
-	arm_add_mem_device("ram0", SDRAM0_BASE, memsize);
-
-	return 0;
-}
-mem_initcall(clps711x_mem_init);
-
 static int clps711x_devices_init(void)
 {
 	u32 serial_h = 0, serial_l = readl(UNIQID);
arch/arm/mach-clps711x/devices.c +12 -0
index de5813a..6c760db 100644
@@ -9,11 +9,23 @@
 
 #include <common.h>
 #include <init.h>
+#include <sizes.h>
 
 #include <asm/io.h>
+#include <asm/memory.h>
 
 #include <mach/clps711x.h>
 
+static int clps711x_mem_init(void)
+{
+	ulong memsize = get_ram_size((ulong *)SDRAM0_BASE, SZ_64M);
+
+	arm_add_mem_device("ram0", SDRAM0_BASE, memsize);
+
+	return 0;
+}
+mem_initcall(clps711x_mem_init);
+
 inline static void _clps711x_setup_memcfg(int bank, u32 addr, u32 val)
 {
 	u32 tmp = readl(addr);
Signature · 7 lines
1.7.3.4


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#13 lore raw

PATCH 10/11 ARM: clps711x: Turn off all peripherals on startup

In reply to Alexander Shiyan
---
 arch/arm/mach-clps711x/lowlevel.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
arch/arm/mach-clps711x/lowlevel.c +7 -0
index 7eed556..752619b 100644
@@ -53,5 +53,12 @@ void __naked __bare_init barebox_arm_reset_vector(void)
 	writel(SDCONF_CASLAT_3 | SDCONF_SIZE_256 | SDCONF_WIDTH_16 |
 	       SDCONF_CLKCTL | SDCONF_ACTIVE, SDCONF);
 
+	/* Disable UART1, IrDa, LCD */
+	writel(0, SYSCON1);
+	/* Disable PWM */
+	writew(0, PMPCON);
+	/* Disable LED flasher */
+	writew(0, LEDFLSH);
+
 	barebox_arm_entry(SDRAM0_BASE, SZ_8M, 0);
 }
Signature · 7 lines
1.7.3.4


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#14 lore raw

PATCH 11/11 ARM: clps711x: Update defconfig

In reply to Alexander Shiyan
---
 arch/arm/configs/clps711x_defconfig |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
arch/arm/configs/clps711x_defconfig +4 -2
index cf2b3b6..3cc939e 100644
@@ -1,13 +1,14 @@
 CONFIG_ARCH_CLPS711X=y
+CONFIG_CLPS711X_CPU_PLL_MULT=50
 CONFIG_AEABI=y
 CONFIG_ARM_OPTIMZED_STRING_FUNCTIONS=y
 # CONFIG_MEMINFO is not set
-CONFIG_TEXT_BASE=0xc0780000
+CONFIG_PBL_IMAGE=y
+CONFIG_MMU=y
 CONFIG_EXPERIMENTAL=y
 CONFIG_BAUDRATE=57600
 CONFIG_CMDLINE_EDITING=y
 CONFIG_AUTO_COMPLETE=y
-CONFIG_DEFAULT_ENVIRONMENT_COMPRESSED_LZO=y
 CONFIG_DEFAULT_ENVIRONMENT_GENERIC_NEW=y
 CONFIG_DEFAULT_ENVIRONMENT_PATH="arch/arm/boards/clep7212/env"
 CONFIG_CMD_EDIT=y
@@ -32,6 +33,7 @@ CONFIG_CMD_MAGICVAR_HELP=y
 CONFIG_DRIVER_CFI=y
 # CONFIG_DRIVER_CFI_BANK_WIDTH_1 is not set
 # CONFIG_DRIVER_CFI_BANK_WIDTH_4 is not set
+CONFIG_CFI_BUFFER_WRITE=y
 CONFIG_MTD=y
 CONFIG_DISK=y
 CONFIG_DISK_WRITE=y
Signature · 7 lines
1.7.3.4


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#15 lore raw
In reply to Alexander Shiyan

arch/arm/boards/clep7212/lowlevel.c

Quoted 22 lines · Alexander Shiyan

One lowlevel initialization will be used on any CLPS711X-target, so move it in the common location.

---
 arch/arm/boards/clep7212/Makefile   |    3 +-
 arch/arm/boards/clep7212/lowlevel.c |   57 -----------------------------------
 arch/arm/mach-clps711x/Makefile     |    3 +-
 arch/arm/mach-clps711x/lowlevel.c   |   57 +++++++++++++++++++++++++++++++++++
 4 files changed, 60 insertions(+), 60 deletions(-)
 delete mode 100644 arch/arm/boards/clep7212/lowlevel.c
 create mode 100644 arch/arm/mach-clps711x/lowlevel.c
arch/arm/boards/clep7212/Makefile +1 -2
index a63aeae..676e867 100644
@@ -1,2 +1 @@
-obj-y += lowlevel.o clep7212.o
-pbl-y += lowlevel.o
+obj-y += clep7212.o
arch/arm/boards/clep7212/lowlevel.c +0 -0

I think it's better to keep the reset vector in board specific code. Then you can have a board specific reset vector, which simply calls a SoC specific one. This also solves the Kconfig problem with the PLL setup. So you would have this in your board:

void __naked __bare_init barebox_arm_reset_vector(void)

{
	arm_cpu_lowlevel_init();

	clps711x_barebox_entry();
}

You could add different more specific clps711x_* functions which will result in different CPU speeds, or you could pass a PLL value to the entry function, if that better fits your needs.

The rest of this series looks fine.

Sascha

Signature · 9 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#16 lore raw

Hello.

...

Quoted 22 lines

arch/arm/boards/clep7212/lowlevel.c

Quoted 9 lines
arch/arm/boards/clep7212/Makefile +1 -2
index a63aeae..676e867 100644
@@ -1,2 +1 @@
-obj-y += lowlevel.o clep7212.o
-pbl-y += lowlevel.o
+obj-y += clep7212.o
arch/arm/boards/clep7212/lowlevel.c +0 -0

I think it's better to keep the reset vector in board specific code. Then you can have a board specific reset vector, which simply calls a SoC specific one. This also solves the Kconfig problem with the PLL setup. So you would have this in your board:

void __naked __bare_init barebox_arm_reset_vector(void)

{
	arm_cpu_lowlevel_init();

	clps711x_barebox_entry();
}
Quoted 5 lines

You could add different more specific clps711x_* functions which will result in different CPU speeds, or you could pass a PLL value to the entry function, if that better fits your needs.

The rest of this series looks fine.

Can we leave this basic clps711x_barebox_entry in mach-clps711x/lowlevel.c and just additionally mark it as "__weak" for ability to override?

---
_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

#17 lore raw
Quoted 25 lines · Alexander Shiyan

Hello.

...

Quoted 22 lines

arch/arm/boards/clep7212/lowlevel.c

Quoted 9 lines
arch/arm/boards/clep7212/Makefile +1 -2
index a63aeae..676e867 100644
@@ -1,2 +1 @@
-obj-y += lowlevel.o clep7212.o
-pbl-y += lowlevel.o
+obj-y += clep7212.o
arch/arm/boards/clep7212/lowlevel.c +0 -0

I think it's better to keep the reset vector in board specific code. Then you can have a board specific reset vector, which simply calls a SoC specific one. This also solves the Kconfig problem with the PLL setup. So you would have this in your board:

void __naked __bare_init barebox_arm_reset_vector(void)

{
	arm_cpu_lowlevel_init();

	clps711x_barebox_entry();
}
Quoted 8 lines
Quoted 5 lines

You could add different more specific clps711x_* functions which will result in different CPU speeds, or you could pass a PLL value to the entry function, if that better fits your needs.

The rest of this series looks fine.

Can we leave this basic clps711x_barebox_entry in mach-clps711x/lowlevel.c and just additionally mark it as "__weak" for ability to override?

I'm not a big fan of __weak functions. Also, if you mark it as weak this would mean that you would have to duplicate the other setup the original weak function does.

Sascha

Signature · 9 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox