Skip to contentSkip to conversation

s390: Add missing PAGE_SHARED as an alias for PAGE_RW

PATCH In review Geert Uytterhoeven 2 participants 4 messages Feb 9, 2013 – Feb 12, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 s390: Add missing PAGE_SHARED as an alias for PAGE_RW

s390 allmodconfig:

drivers/gpu/drm/udl/udl_fb.c:237:52: error: 'PAGE_SHARED' undeclared (first use in this function) drivers/media/pci/zoran/zoran_driver.c:2955:14: error: 'PAGE_SHARED' undeclared (first use in this function) drivers/media/usb/cpia2/cpia2_core.c:2405:66: error: 'PAGE_SHARED' undeclared (first use in this function) drivers/video/udlfb.c:337:52: error: 'PAGE_SHARED' undeclared (first use in this function) drivers/video/smscufx.c:795:52: error: 'PAGE_SHARED' undeclared (first use in this function) drivers/video/vfb.c:431:52: error: 'PAGE_SHARED' undeclared (first use in this function)

According to an email from Martin a few years ago, the equivalent define for s390 is PAGE_RW, so make PAGE_SHARED an alias for PAGE_RW.

---
 arch/s390/include/asm/pgtable.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/s390/include/asm/pgtable.h +1 -0
index 098adbb..0ca3e62 100644
@@ -386,6 +386,7 @@ extern unsigned long MODULES_END;
 
 #define PAGE_KERNEL	PAGE_RW
 #define PAGE_COPY	PAGE_RO
+#define PAGE_SHARED	PAGE_RW
 
 /*
  * On s390 the page table entry has an invalid bit and a read-only bit.
Signature · 1 line
1.7.0.4
#1 lore raw
Quoted 22 lines · Geert Uytterhoeven

s390 allmodconfig:

drivers/gpu/drm/udl/udl_fb.c:237:52: error: 'PAGE_SHARED' undeclared (first use in this function) drivers/media/pci/zoran/zoran_driver.c:2955:14: error: 'PAGE_SHARED' undeclared (first use in this function) drivers/media/usb/cpia2/cpia2_core.c:2405:66: error: 'PAGE_SHARED' undeclared (first use in this function) drivers/video/udlfb.c:337:52: error: 'PAGE_SHARED' undeclared (first use in this function) drivers/video/smscufx.c:795:52: error: 'PAGE_SHARED' undeclared (first use in this function) drivers/video/vfb.c:431:52: error: 'PAGE_SHARED' undeclared (first use in this function)

According to an email from Martin a few years ago, the equivalent define for s390 is PAGE_RW, so make PAGE_SHARED an alias for PAGE_RW.

---
 arch/s390/include/asm/pgtable.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/s390/include/asm/pgtable.h +0 -0
index 098adbb..0ca3e62 100644

arch/s390/include/asm/pgtable.h extern unsigned long MODULES_END; · line 389

Quoted 4 lines
arch/s390/include/asm/pgtable.h +1 -0
@@ -386,6 +386,7 @@ extern unsigned long MODULES_END;
 
 #define PAGE_KERNEL	PAGE_RW
 #define PAGE_COPY	PAGE_RO
+#define PAGE_SHARED	PAGE_RW

Thanks Geert. A similar patch however is already in linux-next, together with a whole bunch of other patches which try to make s390's allmodconfig compile again after PCI, HAS_DMA and HAS_IOMEM got enabled by our new PCI code.

#2 lore raw

Hi Heiko,

Quoted 4 lines · Heiko Carstens

Thanks Geert. A similar patch however is already in linux-next, together with a whole bunch of other patches which try to make s390's allmodconfig compile again after PCI, HAS_DMA and HAS_IOMEM got enabled by our new PCI code.

Cool!

Will you select HAVE_GENERIC_HARDIRQS soon, too?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#3 lore raw
Quoted 4 lines · Geert Uytterhoeven

Hi Heiko,

On Mon, Feb 11, 2013 at 10:11 AM, Heiko Carstens
<[email protected]> wrote:

Quoted 8 lines
Quoted 4 lines

Thanks Geert. A similar patch however is already in linux-next, together with a whole bunch of other patches which try to make s390's allmodconfig compile again after PCI, HAS_DMA and HAS_IOMEM got enabled by our new PCI code.

Cool!

Will you select HAVE_GENERIC_HARDIRQS soon, too?

I discussed that just with Martin, and looking at the code it doesn't look like we want to have GENERIC_HARDIRQS.
If we would select that option it looks like we need to special case the common generic hardirqs code quite a lot, which is something we certainly do not want.
However that's our result after looking 5 minutes into the code ;) So, if at all, it's not going to happen soon.