phy: fix phy_device_free memory leak
Subsystems (3)
PATCH 1/1 phy: fix phy_device_free memory leak
From: Petr Malat <[email protected]>
Fix memory leak in phy_device_free() for the case when phy_device* returned by phy_device_create() is not registered in the system.
---
Bug description:phy_device_create() sets name of kobject using dev_set_name(), which allocates memory using kvasprintf(), but this memory isn't freed if the underlying device isn't registered properly, because kobject_cleanup() is not called in that case. This can happen (and actually is happening on our machines) if phy_device_register(), called by mdiobus_scan(), fails.
Patch description:
Name is freed by phy_device_free(). In the case a device is released trough kobject_cleanup()->device_release()->phy_device_release(), the name is set to NULL and it is not freed by phy_device_free(), because it will be freed later by kobject_cleanup().
Please put me on CC, I'm not signed into the mailing list.
drivers/net/phy/phy_device.c +4 -0
@@ -41,12 +41,16 @@ MODULE_LICENSE("GPL");void phy_device_free (struct phy_device *phydev) { +kfree (phydev->dev.kobj.name);kfree (phydev); }EXPORT_SYMBOL (phy_device_free);static void phy_device_release (struct device *dev) { +/* Name will be freed by kobject_cleanup() */ + dev->kobj.name =NULL ; +phy_device_free (to_phy_device (dev)); }
David Miller
maintainerFrom: Petr Malat <[email protected]>
Date: Mon, 11 Feb 2013 12:28:27 +0100
Quoted 13 lines
From: Petr Malat <[email protected]>
Fix memory leak in
phy_device_free()for the case when phy_device* returned byphy_device_create()is not registered in the system.Signed-off-by Petr Malat <[email protected]>---
Bug description:phy_device_create()sets name of kobject usingdev_set_name(), which allocates memory usingkvasprintf(), but this memory isn't freed if the underlying device isn't registered properly, becausekobject_cleanup()is not called in that case. This can happen (and actually is happening on our machines) ifphy_device_register(), called bymdiobus_scan(), fails.
Quoted 5 lines
Patch description:
Name is freed byphy_device_free(). In the case a device is released trough kobject_cleanup()->device_release()->phy_device_release(), the name is set to NULL and it is not freed byphy_device_free(), because it will be freed later bykobject_cleanup().
All of this descriptive information belongs in the commit message proper.