Skip to contentSkip to conversation

omap1_defconfig build broken in linux next

PATCH Tony Lindgren 1 participant 2 messages Feb 11, 2013

Subsystems (4)
Arm (32-bit) Arm sub-architectures Framebuffer layer OMAP1 support
lore
Share & tools
lore

Tony Lindgren

author reviewer
#0 lore raw

FYI, looks like something broke compile recently, have not yet figured out the breaking commit. Might be the same issue with some other defconfigs too.

Probably something was indirectly included earlier?

This fixes it, still need to dig the breaking commit for the description.

Regards,

Tony

arch/arm/mach-omap1/common.h +2 -0
@@ -31,6 +31,8 @@
 
 #include <plat/i2c.h>
 
+#include <mach/irqs.h>
+
 #if defined(CONFIG_ARCH_OMAP730) || defined(CONFIG_ARCH_OMAP850)
 void omap7xx_map_io(void);
 #else
drivers/video/omap/lcd_ams_delta.c +1 -0
@@ -27,6 +27,7 @@
 #include <linux/lcd.h>
 #include <linux/gpio.h>
 
+#include <mach/hardware.h>
 #include <mach/board-ams-delta.h>
 
 #include "omapfb.h"
drivers/video/omap/lcd_osk.c +3 -0
@@ -24,7 +24,10 @@
 #include <linux/platform_device.h>
 
 #include <asm/gpio.h>
+
+#include <mach/hardware.h>
 #include <mach/mux.h>
+
 #include "omapfb.h"
 
 static int osk_panel_init(struct lcd_panel *panel, struct omapfb_device *fbdev)
author reviewer
#1 lore raw
Quoted 8 lines · Tony Lindgren

FYI, looks like something broke compile recently, have not yet figured out the breaking commit. Might be the same issue with some other defconfigs too.

Probably something was indirectly included earlier?

This fixes it, still need to dig the breaking commit for the description.

Seems to be caused by 16559ae4 (kgdb: remove #include <linux/serial_8250.h> from kgdb.h), will post a proper patch.

Quoted 43 lines

Regards,

Tony

arch/arm/mach-omap1/common.h +2 -0
@@ -31,6 +31,8 @@
 
 #include <plat/i2c.h>
 
+#include <mach/irqs.h>
+
 #if defined(CONFIG_ARCH_OMAP730) || defined(CONFIG_ARCH_OMAP850)
 void omap7xx_map_io(void);
 #else
drivers/video/omap/lcd_ams_delta.c +1 -0
@@ -27,6 +27,7 @@
 #include <linux/lcd.h>
 #include <linux/gpio.h>
 
+#include <mach/hardware.h>
 #include <mach/board-ams-delta.h>
 
 #include "omapfb.h"
drivers/video/omap/lcd_osk.c +3 -1
@@ -24,7 +24,10 @@
 #include <linux/platform_device.h>
 
 #include <asm/gpio.h>
+
+#include <mach/hardware.h>
 #include <mach/mux.h>
+
 #include "omapfb.h"
 
 static int osk_panel_init(struct lcd_panel *panel, struct omapfb_device *fbdev)
--

To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html