vim: Add option to remove documentation from target
PATCH 1/1 vim: Add option to remove documentation from target
From: Markos Chandras <[email protected]>
--- package/vim/Config.in | 8 ++++++++ package/vim/vim.mk | 8 ++++++++ 2 files changed, 16 insertions(+), 0 deletions(-)
package/vim/Config.in +8 -0
@@ -14,3 +14,11 @@ config BR2_PACKAGE_VIM_RUNTIME help Install VIM runtime (syntax highlighing + macros). This option adds about 15MB of data to /usr/share/ + +config BR2_PACKAGE_VIM_REMOVE_DOCS + bool "remove documentation" + default y + depends on BR2_PACKAGE_VIM + help + Remove documentation files from the target. + This option removes about 5.6MB of data from /usr/share/
package/vim/vim.mk +8 -0
@@ -36,8 +36,16 @@ define VIM_INSTALL_RUNTIME_CMDS $(MAKE) DESTDIR=$(TARGET_DIR) installmacros endef +define VIM_REMOVE_DOCS + find $(TARGET_DIR)/usr/share/vim -type f -name "*.txt" -delete +endef + ifeq ($(BR2_PACKAGE_VIM_RUNTIME),y) VIM_POST_INSTALL_TARGET_HOOKS += VIM_INSTALL_RUNTIME_CMDS endif +ifeq ($(BR2_PACKAGE_VIM_REMOVE_DOCS),y) +VIM_POST_INSTALL_TARGET_HOOKS += VIM_REMOVE_DOCS +endif + $(eval $(autotools-package))
Signature · 1 line
1.7.1
PATCH 1/1 vim: Add option to remove documentation from target
Dear Markos Chandras,
package/vim/Config.in config BR2_PACKAGE_VIM_RUNTIME · line 24
Quoted 7 lines · Markos Chandras
package/vim/Config.in +7
-0+config BR2_PACKAGE_VIM_REMOVE_DOCS + bool "remove documentation" + default y + depends on BR2_PACKAGE_VIM + help + Remove documentation files from the target. + This option removes about 5.6MB of data from /usr/share/
Please don't add a special option for this: use BR2_HAVE_DOCUMENTATION instead.
Thanks!
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 1/1 vim: Add option to remove documentation from target
Quoted 15 lines · Thomas Petazzoni
Dear Markos Chandras,
package/vim/Config.in config BR2_PACKAGE_VIM_RUNTIME · line 24
Quoted 7 lines · Markos Chandras
package/vim/Config.in +7
-0+config BR2_PACKAGE_VIM_REMOVE_DOCS + bool "remove documentation" + default y + depends on BR2_PACKAGE_VIM + help + Remove documentation files from the target. + This option removes about 5.6MB of data from /usr/share/Please don't add a special option for this: use
BR2_HAVE_DOCUMENTATIONinstead.
Quoted 8 lines
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
Hi Thomas,
Thanks for the reply. This BR2_HAVE_DOCUMENTATION option is marked as "deprecated" so I was not sure if we should use it anymore or not. I will prepare a new patch.
Signature · 2 lines
Regards, Markos Chandras
PATCH 1/1 vim: Add option to remove documentation from target
Dear Markos Chandras,
Quoted 3 lines · Markos Chandras
Thanks for the reply. This
BR2_HAVE_DOCUMENTATIONoption is marked as "deprecated" so I was not sure if we should use it anymore or not. I will prepare a new patch.
Right, it's deprecated, because we believe that installing the documentation on the target is useless in Buildroot's context. So we don't want BR2_HAVE_DOCUMENTATION to be replaced by new, package specific options that do the same thing :-)
For now, I'd say: use BR2_HAVE_DOCUMENTATION, so that the day we decide to finally remove it, we can easily grep in the source code to find the things we can remove or simplify.
Thanks!
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com