checksum: remove duplicated line of code in csum_fold
Subsystems (3)
PATCH 1/1 checksum: remove duplicated line of code in csum_fold
From: Pablo Neira Ayuso <[email protected]>
Signed-off-by Pablo Neira Ayuso <[email protected]>
--- include/asm-generic/checksum.h | 1 - 1 file changed, 1 deletion(-)
include/asm-generic/checksum.h +0 -1
@@ -51,7 +51,6 @@ static inline __sum16 csum_fold(__wsum csum) {u32 sum = (__force u32 )csum; sum = (sum &0xffff ) + (sum >>16 ); - sum = (sum &0xffff ) + (sum >>16 );return (__force __sum16 )~sum; }
Signature · 1 line
1.7.10.4
David Miller
maintainerFrom: [email protected]
Date: Tue, 12 Feb 2013 18:10:03 +0100
Quoted 3 lines
From: Pablo Neira Ayuso <[email protected]>
Signed-off-by Pablo Neira Ayuso <[email protected]>
I am very sure that those two lines are there intentionally. The first addition one can overflow, therefore we need to fold again (which cannot overflow).
Quoted 10 lines · David Miller
From: [email protected]
Date: Tue, 12 Feb 2013 18:10:03 +0100Quoted 3 lines
From: Pablo Neira Ayuso <[email protected]>
Signed-off-by Pablo Neira Ayuso <[email protected]>I am very sure that those two lines are there intentionally. The first addition one can overflow, therefore we need to fold again (which cannot overflow).
I was missing that, make sense indeed, thanks.