Skip to contentSkip to conversation

ARM: OMAP2+: SmartReflex: soc.h is needed for omap initcalls

PATCH New Kevin Hilman 2 participants 2 messages Feb 12, 2013 – Feb 13, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: OMAP2+: SmartReflex: soc.h is needed for omap initcalls

commit aa4f99638b (ARM: OMAP2+: Use omap initcalls) converted the initcalls here, but did not #include "soc.h" where the omap inicalls are defined.

To fix, #include <soc.h>

---
Tony, the patch that broke this was introduced in your omap-for-v3.9/multiplatform-enable-signed branch, and this problem was found only when compiling with PM (specifically, SmartReflex) enabled.

 arch/arm/mach-omap2/smartreflex-class3.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-omap2/smartreflex-class3.c +1 -0
index 80f3acb..b2dcbd3 100644
@@ -13,6 +13,7 @@
 
 #include <linux/power/smartreflex.h>
 #include "voltage.h"
+#include "soc.h"
 
 static int sr_class3_enable(struct omap_sr *sr)
 {
Signature · 1 line
1.8.1.2
maintainer
#1 lore raw

PATCH 1/1 ARM: OMAP2+: SmartReflex: soc.h is needed for omap initcalls

Quoted 5 lines · Kevin Hilman

commit aa4f99638b (ARM: OMAP2+: Use omap initcalls) converted the initcalls here, but did not #include "soc.h" where the omap inicalls are defined.

To fix, #include <soc.h>

Thanks, this should be already fixed in arm-soc/for-next. I might have forgotten to merge these into omap-for-v3.9/tmp-merge though.

Regards,

Tony

Quoted 24 lines

---
Tony, the patch that broke this was introduced in your omap-for-v3.9/multiplatform-enable-signed branch, and this problem was found only when compiling with PM (specifically, SmartReflex) enabled.

 arch/arm/mach-omap2/smartreflex-class3.c | 1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-omap2/smartreflex-class3.c +1 -0
index 80f3acb..b2dcbd3 100644
@@ -13,6 +13,7 @@
 
 #include <linux/power/smartreflex.h>
 #include "voltage.h"
+#include "soc.h"
 
 static int sr_class3_enable(struct omap_sr *sr)
 {
Signature · 1 line
1.8.1.2