Skip to contentSkip to conversation

ARM: mach-shmobile: armadillo800eva: enable REGULATOR in defconfig

PATCH New Simon Horman 3 participants 3 messages Feb 13, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: mach-shmobile: armadillo800eva: enable REGULATOR in defconfig

As well as being a generally sane thing to do this
is required for MMCIF to function in conjunction with "ARM: shmobile: switch SDHI0 to GPIO regulator on armadillo800eva".

Cc Guennadi Liakhovetski <[email protected]>
---
 arch/arm/configs/armadillo800eva_defconfig |    2 ++
 1 file changed, 2 insertions(+)
arch/arm/configs/armadillo800eva_defconfig +2 -0
index 0b98100..6ceb79f 100644
@@ -88,6 +88,8 @@ CONFIG_I2C=y
 CONFIG_I2C_GPIO=y
 CONFIG_I2C_SH_MOBILE=y
 # CONFIG_HWMON is not set
+CONFIG_REGULATOR=y
+CONFIG_REGULATOR_DUMMY=y
 CONFIG_MEDIA_SUPPORT=y
 CONFIG_VIDEO_DEV=y
 CONFIG_MEDIA_CAMERA_SUPPORT=y
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 ARM: mach-shmobile: armadillo800eva: enable REGULATOR in defconfig

Hi Simon

Quoted 15 lines · Simon Horman

As well as being a generally sane thing to do this
is required for MMCIF to function in conjunction with "ARM: shmobile: switch SDHI0 to GPIO regulator on armadillo800eva".

Cc Guennadi Liakhovetski <[email protected]>
---
 arch/arm/configs/armadillo800eva_defconfig |    2 ++
 1 file changed, 2 insertions(+)
arch/arm/configs/armadillo800eva_defconfig +0 -0
index 0b98100..6ceb79f 100644

arch/arm/configs/armadillo800eva_defconfig CONFIG_I2C=y · line 92

Quoted 5 lines
arch/arm/configs/armadillo800eva_defconfig +2 -0
@@ -88,6 +88,8 @@ CONFIG_I2C=y
 CONFIG_I2C_GPIO=y
 CONFIG_I2C_SH_MOBILE=y
 # CONFIG_HWMON is not set
+CONFIG_REGULATOR=y
+CONFIG_REGULATOR_DUMMY=y

I don't think it's a good idea to enable the dummy regulator by default in defconfig. It has been explained to me, that that regulator is only meant for development / testing. For production you really should have the _correct_ regulators in place. So, encouraging it by default is probably not a very good idea.

Thanks
Guennadi

Quoted 6 lines
arch/arm/configs/armadillo800eva_defconfig +0 -0
 CONFIG_MEDIA_SUPPORT=y
 CONFIG_VIDEO_DEV=y
 CONFIG_MEDIA_CAMERA_SUPPORT=y
Signature · 1 line
1.7.10.4

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

#2 lore raw

PATCH 1/1 ARM: mach-shmobile: armadillo800eva: enable REGULATOR in defconfig

Quoted 14 lines · Guennadi Liakhovetski

Hi Simon

Quoted 10 lines · Simon Horman

As well as being a generally sane thing to do this
is required for MMCIF to function in conjunction with "ARM: shmobile: switch SDHI0 to GPIO regulator on armadillo800eva".

Cc Guennadi Liakhovetski <[email protected]>
---
 arch/arm/configs/armadillo800eva_defconfig |    2 ++
 1 file changed, 2 insertions(+)
Quoted 16 lines

arch/arm/configs/armadillo800eva_defconfig CONFIG_I2C=y · line 92

Quoted 10 lines
arch/arm/configs/armadillo800eva_defconfig +2 -0
index 0b98100..6ceb79f 100644
@@ -88,6 +88,8 @@ CONFIG_I2C=y
 CONFIG_I2C_GPIO=y
 CONFIG_I2C_SH_MOBILE=y
 # CONFIG_HWMON is not set
+CONFIG_REGULATOR=y
+CONFIG_REGULATOR_DUMMY=y

I don't think it's a good idea to enable the dummy regulator by default in defconfig. It has been explained to me, that that regulator is only meant for development / testing. For production you really should have the _correct_ regulators in place. So, encouraging it by default is probably not a very good idea.

Thanks, I will fix up this and the other defconfigs accordingly.