Skip to contentSkip to conversation

ARM: mach-shmobile: defconfig REGULATOR settings

PATCH New Simon Horman 3 participants 14 messages Feb 13, 2013 – Feb 15, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v2 cover ARM: mach-shmobile: defconfig REGULATOR settings

* Enable REGULATOR for mackerel and armadillo800eva as it will be needed for MMCIF to function.
* Do not enable REGULATOR_DUMMY for kzm9g,
it is only intended to be used for development and testing.

#1 lore raw

PATCH v2 1/3 ARM: mach-shmobile: mackerel: enable REGULATOR in defconfig

As well as being a generally sane thing to do this is required for MMCIF to function in conjunction with " ARM: shmobile: streamline mackerel SD and MMC devices".

Cc Guennadi Liakhovetski <[email protected]>

---

v2
* Don't enable REGULATOR_DUMMY, it is only intended for development / testing.

---
 arch/arm/configs/mackerel_defconfig |    1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/mackerel_defconfig +1 -0
index ec8e605..9fb1189 100644
@@ -75,6 +75,7 @@ CONFIG_I2C=y
 CONFIG_I2C_SH_MOBILE=y
 # CONFIG_HWMON is not set
 # CONFIG_MFD_SUPPORT is not set
+CONFIG_REGULATOR=y
 CONFIG_FB=y
 CONFIG_FB_MODE_HELPERS=y
 CONFIG_FB_SH_MOBILE_LCDC=y
Signature · 1 line
1.7.10.4
#2 lore raw

PATCH 1/3 ARM: mach-shmobile: mackerel: enable REGULATOR in defconfig

Hi Simon

Quoted 20 lines · Simon Horman

As well as being a generally sane thing to do this is required for MMCIF to function in conjunction with " ARM: shmobile: streamline mackerel SD and MMC devices".

Cc Guennadi Liakhovetski <[email protected]>

---

v2
* Don't enable REGULATOR_DUMMY, it is only intended for development / testing.

---
 arch/arm/configs/mackerel_defconfig |    1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/mackerel_defconfig +0 -0
index ec8e605..9fb1189 100644

arch/arm/configs/mackerel_defconfig CONFIG_I2C=y · line 78

Quoted 4 lines
arch/arm/configs/mackerel_defconfig +1 -0
@@ -75,6 +75,7 @@ CONFIG_I2C=y
 CONFIG_I2C_SH_MOBILE=y
 # CONFIG_HWMON is not set
 # CONFIG_MFD_SUPPORT is not set
+CONFIG_REGULATOR=y

We really don't have to enable CONFIG_REGULATOR_GPIO and CONFIG_REGULATOR_FIXED_VOLTAGE? IIRC, CONFIG_REGULATOR_GPIO is so far only used on armadillo800eva, but the fixed regulator is required for other boards too?

Thanks
Guennadi

Quoted 5 lines
arch/arm/configs/mackerel_defconfig +0 -0
 CONFIG_FB=y
 CONFIG_FB_MODE_HELPERS=y
 CONFIG_FB_SH_MOBILE_LCDC=y
Signature · 1 line
1.7.10.4

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

#3 lore raw

PATCH 1/3 ARM: mach-shmobile: mackerel: enable REGULATOR in defconfig

Quoted 19 lines · Guennadi Liakhovetski

Hi Simon

Quoted 15 lines · Simon Horman

As well as being a generally sane thing to do this is required for MMCIF to function in conjunction with " ARM: shmobile: streamline mackerel SD and MMC devices".

Cc Guennadi Liakhovetski <[email protected]>

---

v2
* Don't enable REGULATOR_DUMMY, it is only intended for development / testing.

---
 arch/arm/configs/mackerel_defconfig |    1 +
 1 file changed, 1 insertion(+)
Quoted 14 lines

arch/arm/configs/mackerel_defconfig CONFIG_I2C=y · line 78

Quoted 9 lines
arch/arm/configs/mackerel_defconfig +1 -0
index ec8e605..9fb1189 100644
@@ -75,6 +75,7 @@ CONFIG_I2C=y
 CONFIG_I2C_SH_MOBILE=y
 # CONFIG_HWMON is not set
 # CONFIG_MFD_SUPPORT is not set
+CONFIG_REGULATOR=y

We really don't have to enable CONFIG_REGULATOR_GPIO and CONFIG_REGULATOR_FIXED_VOLTAGE? IIRC, CONFIG_REGULATOR_GPIO is so far only used on armadillo800eva, but the fixed regulator is required for other boards too?

The Kconfig for MACH_ARMADILLO800EVA selects REGULATOR_FIXED_VOLTAGE is REGULATOR is enabled.

Likewise for kzm9g, mackerel and a bunch of other boards.

#4 lore raw

PATCH v2 2/3 ARM: mach-shmobile: armadillo800eva: enable REGULATOR in defconfig

In reply to Simon Horman

As well as being a generally sane thing to do this
is required for MMCIF to function in conjunction with "ARM: shmobile: switch SDHI0 to GPIO regulator on armadillo800eva".

Cc Guennadi Liakhovetski <[email protected]>

---

v2
* Don't enable REGULATOR_DUMMY, it is only intended for development / testing.

---
 arch/arm/configs/armadillo800eva_defconfig |    1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/armadillo800eva_defconfig +1 -0
index 0b98100..0cc8014 100644
@@ -88,6 +88,7 @@ CONFIG_I2C=y
 CONFIG_I2C_GPIO=y
 CONFIG_I2C_SH_MOBILE=y
 # CONFIG_HWMON is not set
+CONFIG_REGULATOR=y
 CONFIG_MEDIA_SUPPORT=y
 CONFIG_VIDEO_DEV=y
 CONFIG_MEDIA_CAMERA_SUPPORT=y
Signature · 1 line
1.7.10.4
#5 lore raw

PATCH 2/3 ARM: mach-shmobile: armadillo800eva: enable REGULATOR in defconfig

Quoted 20 lines · Simon Horman

As well as being a generally sane thing to do this
is required for MMCIF to function in conjunction with "ARM: shmobile: switch SDHI0 to GPIO regulator on armadillo800eva".

Cc Guennadi Liakhovetski <[email protected]>

---

v2
* Don't enable REGULATOR_DUMMY, it is only intended for development / testing.

---
 arch/arm/configs/armadillo800eva_defconfig |    1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/armadillo800eva_defconfig +0 -0
index 0b98100..0cc8014 100644

arch/arm/configs/armadillo800eva_defconfig CONFIG_I2C=y · line 94

Quoted 7 lines
arch/arm/configs/armadillo800eva_defconfig +1 -0
@@ -88,6 +88,7 @@ CONFIG_I2C=y
 CONFIG_I2C_GPIO=y
 CONFIG_I2C_SH_MOBILE=y
 # CONFIG_HWMON is not set
+CONFIG_REGULATOR=y
 CONFIG_MEDIA_SUPPORT=y
 CONFIG_VIDEO_DEV=y
 CONFIG_MEDIA_CAMERA_SUPPORT=y

This patch seems to break NIC initialisation.

smsc911x: Driver version 2008-10-21
smsc911x smsc911x.0: Failed to get supply 'vdd33a': -517 smsc911x smsc911x.0 (unregistered net_device): couldn't get regulators -517 platform smsc911x.0: Driver smsc911x requests probe deferral

#6 lore raw

PATCH 2/3 ARM: mach-shmobile: armadillo800eva: enable REGULATOR in defconfig

Hi Simon

Quoted 31 lines · Simon Horman
Quoted 20 lines · Simon Horman

As well as being a generally sane thing to do this
is required for MMCIF to function in conjunction with "ARM: shmobile: switch SDHI0 to GPIO regulator on armadillo800eva".

Cc Guennadi Liakhovetski <[email protected]>

---

v2
* Don't enable REGULATOR_DUMMY, it is only intended for development / testing.

---
 arch/arm/configs/armadillo800eva_defconfig |    1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/armadillo800eva_defconfig +0 -0
index 0b98100..0cc8014 100644

arch/arm/configs/armadillo800eva_defconfig CONFIG_I2C=y · line 94

Quoted 7 lines
arch/arm/configs/armadillo800eva_defconfig +1 -0
@@ -88,6 +88,7 @@ CONFIG_I2C=y
 CONFIG_I2C_GPIO=y
 CONFIG_I2C_SH_MOBILE=y
 # CONFIG_HWMON is not set
+CONFIG_REGULATOR=y
 CONFIG_MEDIA_SUPPORT=y
 CONFIG_VIDEO_DEV=y
 CONFIG_MEDIA_CAMERA_SUPPORT=y

This patch seems to break NIC initialisation.

Quoted 4 lines

smsc911x: Driver version 2008-10-21
smsc911x smsc911x.0: Failed to get supply 'vdd33a': -517 smsc911x smsc911x.0 (unregistered net_device): couldn't get regulators -517 platform smsc911x.0: Driver smsc911x requests probe deferral

Hm? Why is smsc911x even probing on armadillo800eva for you? Only sh-eth should be probing.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

#7 lore raw

PATCH 2/3 ARM: mach-shmobile: armadillo800eva: enable REGULATOR in defconfig

Quoted 39 lines · Guennadi Liakhovetski

Hi Simon

Quoted 35 lines · Simon Horman
Quoted 20 lines · Simon Horman

As well as being a generally sane thing to do this
is required for MMCIF to function in conjunction with "ARM: shmobile: switch SDHI0 to GPIO regulator on armadillo800eva".

Cc Guennadi Liakhovetski <[email protected]>

---

v2
* Don't enable REGULATOR_DUMMY, it is only intended for development / testing.

---
 arch/arm/configs/armadillo800eva_defconfig |    1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/armadillo800eva_defconfig +0 -0
index 0b98100..0cc8014 100644

arch/arm/configs/armadillo800eva_defconfig CONFIG_I2C=y · line 94

Quoted 7 lines
arch/arm/configs/armadillo800eva_defconfig +1 -0
@@ -88,6 +88,7 @@ CONFIG_I2C=y
 CONFIG_I2C_GPIO=y
 CONFIG_I2C_SH_MOBILE=y
 # CONFIG_HWMON is not set
+CONFIG_REGULATOR=y
 CONFIG_MEDIA_SUPPORT=y
 CONFIG_VIDEO_DEV=y
 CONFIG_MEDIA_CAMERA_SUPPORT=y

This patch seems to break NIC initialisation.

smsc911x: Driver version 2008-10-21
smsc911x smsc911x.0: Failed to get supply 'vdd33a': -517 smsc911x smsc911x.0 (unregistered net_device): couldn't get regulators -517 platform smsc911x.0: Driver smsc911x requests probe deferral

Sorry, I replied to the wrong patch.
It was on KZM9G that I observed this.
It seems to need REGULATOR_DUMMY.

#8 lore raw

PATCH v2 3/3 ARM: mach-shmobile: kzm9g: do not enable REGULATOR_DUMMY in defconfig

In reply to Simon Horman

Don't enable REGULATOR_DUMMY, it is only intended for development / testing. There doesn't seem to be any value in setting it here and doing so was an error on my part.

Cc Guennadi Liakhovetski <[email protected]>
---
 arch/arm/configs/kzm9g_defconfig |    1 -
 1 file changed, 1 deletion(-)
arch/arm/configs/kzm9g_defconfig +0 -1
index 670c3b6..6751c02 100644
@@ -86,7 +86,6 @@ CONFIG_I2C_SH_MOBILE=y
 CONFIG_GPIO_PCF857X=y
 # CONFIG_HWMON is not set
 CONFIG_REGULATOR=y
-CONFIG_REGULATOR_DUMMY=y
 CONFIG_FB=y
 CONFIG_FB_SH_MOBILE_LCDC=y
 CONFIG_FRAMEBUFFER_CONSOLE=y
Signature · 1 line
1.7.10.4
#9 lore raw

PATCH 3/3 ARM: mach-shmobile: kzm9g: do not enable REGULATOR_DUMMY in defconfig

Quoted 15 lines · Simon Horman

Don't enable REGULATOR_DUMMY, it is only intended for development / testing. There doesn't seem to be any value in setting it here and doing so was an error on my part.

Cc Guennadi Liakhovetski <[email protected]>
---
 arch/arm/configs/kzm9g_defconfig |    1 -
 1 file changed, 1 deletion(-)
arch/arm/configs/kzm9g_defconfig +0 -0
index 670c3b6..6751c02 100644

arch/arm/configs/kzm9g_defconfig CONFIG_I2C_SH_MOBILE=y · line 91

Quoted 7 lines
arch/arm/configs/kzm9g_defconfig +0 -1
@@ -86,7 +86,6 @@ CONFIG_I2C_SH_MOBILE=y
 CONFIG_GPIO_PCF857X=y
 # CONFIG_HWMON is not set
 CONFIG_REGULATOR=y
-CONFIG_REGULATOR_DUMMY=y
 CONFIG_FB=y
 CONFIG_FB_SH_MOBILE_LCDC=y
 CONFIG_FRAMEBUFFER_CONSOLE=y

This patch seems to break NIC initialisation.

smsc911x: Driver version 2008-10-21
smsc911x smsc911x.0: Failed to get supply 'vdd33a': -517 smsc911x smsc911x.0 (unregistered net_device): couldn't get regulators -517 platform smsc911x.0: Driver smsc911x requests probe deferral

#10 lore raw

PATCH 3/3 ARM: mach-shmobile: kzm9g: do not enable REGULATOR_DUMMY in defconfig

Quoted 26 lines · Simon Horman
Quoted 15 lines · Simon Horman

Don't enable REGULATOR_DUMMY, it is only intended for development / testing. There doesn't seem to be any value in setting it here and doing so was an error on my part.

Cc Guennadi Liakhovetski <[email protected]>
---
 arch/arm/configs/kzm9g_defconfig |    1 -
 1 file changed, 1 deletion(-)
arch/arm/configs/kzm9g_defconfig +0 -0
index 670c3b6..6751c02 100644

arch/arm/configs/kzm9g_defconfig CONFIG_I2C_SH_MOBILE=y · line 91

Quoted 7 lines
arch/arm/configs/kzm9g_defconfig +0 -1
@@ -86,7 +86,6 @@ CONFIG_I2C_SH_MOBILE=y
 CONFIG_GPIO_PCF857X=y
 # CONFIG_HWMON is not set
 CONFIG_REGULATOR=y
-CONFIG_REGULATOR_DUMMY=y
 CONFIG_FB=y
 CONFIG_FB_SH_MOBILE_LCDC=y
 CONFIG_FRAMEBUFFER_CONSOLE=y

This patch seems to break NIC initialisation.

Quoted 4 lines

smsc911x: Driver version 2008-10-21
smsc911x smsc911x.0: Failed to get supply 'vdd33a': -517 smsc911x smsc911x.0 (unregistered net_device): couldn't get regulators -517 platform smsc911x.0: Driver smsc911x requests probe deferral

Right, you need a fixed regulator similar to how I adde it here

http://www.spinics.net/lists/linux-sh/msg15713.html

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

#11 lore raw

PATCH 3/3 ARM: mach-shmobile: kzm9g: do not enable REGULATOR_DUMMY in defconfig

Quoted 28 lines · Guennadi Liakhovetski
Quoted 26 lines · Simon Horman
Quoted 15 lines · Simon Horman

Don't enable REGULATOR_DUMMY, it is only intended for development / testing. There doesn't seem to be any value in setting it here and doing so was an error on my part.

Cc Guennadi Liakhovetski <[email protected]>
---
 arch/arm/configs/kzm9g_defconfig |    1 -
 1 file changed, 1 deletion(-)
arch/arm/configs/kzm9g_defconfig +0 -0
index 670c3b6..6751c02 100644

arch/arm/configs/kzm9g_defconfig CONFIG_I2C_SH_MOBILE=y · line 91

Quoted 7 lines
arch/arm/configs/kzm9g_defconfig +0 -1
@@ -86,7 +86,6 @@ CONFIG_I2C_SH_MOBILE=y
 CONFIG_GPIO_PCF857X=y
 # CONFIG_HWMON is not set
 CONFIG_REGULATOR=y
-CONFIG_REGULATOR_DUMMY=y
 CONFIG_FB=y
 CONFIG_FB_SH_MOBILE_LCDC=y
 CONFIG_FRAMEBUFFER_CONSOLE=y

This patch seems to break NIC initialisation.

Quoted 8 lines
Quoted 4 lines

smsc911x: Driver version 2008-10-21
smsc911x smsc911x.0: Failed to get supply 'vdd33a': -517 smsc911x smsc911x.0 (unregistered net_device): couldn't get regulators -517 platform smsc911x.0: Driver smsc911x requests probe deferral

Right, you need a fixed regulator similar to how I adde it here

http://www.spinics.net/lists/linux-sh/msg15713.html

Perhaps that is the wrong link?
The code in the link seems to be the same as what is preseng in boards-kzm9g.c already and with it in place I see the error above if CONFIG_REGULATOR_DUMMY is not enabled.

I am testing against with next branch in the renesas tree with the kzm9g_defconfig, less CONFIG_REGULATOR_DUMMY.

#12 lore raw

PATCH 3/3 ARM: mach-shmobile: kzm9g: do not enable REGULATOR_DUMMY in defconfig

Hi Simon

Quoted 34 lines · Simon Horman
Quoted 33 lines · Guennadi Liakhovetski
Quoted 30 lines · Simon Horman
Quoted 15 lines · Simon Horman

Don't enable REGULATOR_DUMMY, it is only intended for development / testing. There doesn't seem to be any value in setting it here and doing so was an error on my part.

Cc Guennadi Liakhovetski <[email protected]>
---
 arch/arm/configs/kzm9g_defconfig |    1 -
 1 file changed, 1 deletion(-)
arch/arm/configs/kzm9g_defconfig +0 -0
index 670c3b6..6751c02 100644

arch/arm/configs/kzm9g_defconfig CONFIG_I2C_SH_MOBILE=y · line 91

Quoted 7 lines
arch/arm/configs/kzm9g_defconfig +0 -1
@@ -86,7 +86,6 @@ CONFIG_I2C_SH_MOBILE=y
 CONFIG_GPIO_PCF857X=y
 # CONFIG_HWMON is not set
 CONFIG_REGULATOR=y
-CONFIG_REGULATOR_DUMMY=y
 CONFIG_FB=y
 CONFIG_FB_SH_MOBILE_LCDC=y
 CONFIG_FRAMEBUFFER_CONSOLE=y

This patch seems to break NIC initialisation.

smsc911x: Driver version 2008-10-21
smsc911x smsc911x.0: Failed to get supply 'vdd33a': -517 smsc911x smsc911x.0 (unregistered net_device): couldn't get regulators -517 platform smsc911x.0: Driver smsc911x requests probe deferral

Quoted 5 lines
Quoted 3 lines

Right, you need a fixed regulator similar to how I adde it here

http://www.spinics.net/lists/linux-sh/msg15713.html

Perhaps that is the wrong link?

No, the link is right

Quoted 2 lines

The code in the link seems to be the same as what is preseng in boards-kzm9g.c already

Indeed, that should be fine. Ah, wait, what if you add ".0" to device names in regulators like

	REGULATOR_SUPPLY("vddvario", "smsc911x.0"),
	REGULATOR_SUPPLY("vdd33a", "smsc911x.0"),

?

Thanks
Guennadi

Quoted 6 lines

and with it in place I see the error
above if CONFIG_REGULATOR_DUMMY is not enabled.

I am testing against with next branch in the renesas tree with the kzm9g_defconfig, less CONFIG_REGULATOR_DUMMY.

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

#13 lore raw

PATCH 3/3 ARM: mach-shmobile: kzm9g: do not enable REGULATOR_DUMMY in defconfig

Quoted 46 lines · Guennadi Liakhovetski

Hi Simon

Quoted 34 lines · Simon Horman
Quoted 33 lines · Guennadi Liakhovetski
Quoted 30 lines · Simon Horman
Quoted 15 lines · Simon Horman

Don't enable REGULATOR_DUMMY, it is only intended for development / testing. There doesn't seem to be any value in setting it here and doing so was an error on my part.

Cc Guennadi Liakhovetski <[email protected]>
---
 arch/arm/configs/kzm9g_defconfig |    1 -
 1 file changed, 1 deletion(-)
arch/arm/configs/kzm9g_defconfig +0 -0
index 670c3b6..6751c02 100644

arch/arm/configs/kzm9g_defconfig CONFIG_I2C_SH_MOBILE=y · line 91

Quoted 7 lines
arch/arm/configs/kzm9g_defconfig +0 -1
@@ -86,7 +86,6 @@ CONFIG_I2C_SH_MOBILE=y
 CONFIG_GPIO_PCF857X=y
 # CONFIG_HWMON is not set
 CONFIG_REGULATOR=y
-CONFIG_REGULATOR_DUMMY=y
 CONFIG_FB=y
 CONFIG_FB_SH_MOBILE_LCDC=y
 CONFIG_FRAMEBUFFER_CONSOLE=y

This patch seems to break NIC initialisation.

smsc911x: Driver version 2008-10-21
smsc911x smsc911x.0: Failed to get supply 'vdd33a': -517 smsc911x smsc911x.0 (unregistered net_device): couldn't get regulators -517 platform smsc911x.0: Driver smsc911x requests probe deferral

Quoted 5 lines
Quoted 3 lines

Right, you need a fixed regulator similar to how I adde it here

http://www.spinics.net/lists/linux-sh/msg15713.html

Perhaps that is the wrong link?

No, the link is right

Quoted 8 lines
Quoted 2 lines

The code in the link seems to be the same as what is preseng in boards-kzm9g.c already

Indeed, that should be fine. Ah, wait, what if you add ".0" to device names in regulators like

	REGULATOR_SUPPLY("vddvario", "smsc911x.0"),
	REGULATOR_SUPPLY("vdd33a", "smsc911x.0"),

Bingo!

Thanks, I'll send a patch.