Skip to contentSkip to conversation

policycoreutils dependency issues

PATCH In review Amy Fong 3 participants 3 messages Feb 13, 2013 – Mar 7, 2013

lore
Share & tools
lore

Amy Fong

author
#0 lore raw

PATCH 1/1 policycoreutils dependency issues

policyutilutils: needs some dependencies unconditionally

policycoreutils will fail to compile if selinux isn't in the DISTROFEATURES. We move these packages out of @target_selinux.

--

 policycoreutils.inc |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
recipes-security/selinux/policycoreutils.inc +3 -2
index cc54b36..9869a83 100644
@@ -1,4 +1,4 @@
-PRINC = "2"
+PRINC = "3"
 
 SUMMARY = "SELinux policy core utilities"
 DESCRIPTION = "policycoreutils contains the policy core utilities that are required \
@@ -16,9 +16,10 @@ PAM_SRC_URI = "file://pam.d/newrole \
               "
 
 DEPENDS += "libsepol libselinux libsemanage"
+DEPENDS += "libcap-ng libcgroup libpam"
 
 inherit selinux
-DEPENDS += "${@target_selinux(d, 'libcap-ng libcgroup libpam audit')}"
+DEPENDS += "${@target_selinux(d, 'audit')}"
 
 RDEPENDS_${BPN} += "\
 	libselinux-python \
#1 lore raw
Quoted 6 lines · Amy Fong

policyutilutils: needs some dependencies unconditionally

policycoreutils will fail to compile if selinux isn't in the DISTROFEATURES. We move these packages out of @target_selinux.

Where is this meta-selinux layer?

I don't see it on
http://www.openembedded.org/wiki/LayerIndex

or policycoreutils.inc file in meta-oe repo or any layer I've checkouted here.

Was this meant for [email protected]?

And BTW: use better syntax for PRINC to allow multiple .bbappends.. hmm well you're having PRINC in .inc.. interesting.

Quoted 32 lines

--

 policycoreutils.inc |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
recipes-security/selinux/policycoreutils.inc +3 -2
index cc54b36..9869a83 100644
@@ -1,4 +1,4 @@
-PRINC = "2"
+PRINC = "3"
 
 SUMMARY = "SELinux policy core utilities"
 DESCRIPTION = "policycoreutils contains the policy core utilities that are required \
@@ -16,9 +16,10 @@ PAM_SRC_URI = "file://pam.d/newrole \
               "
 
 DEPENDS += "libsepol libselinux libsemanage"
+DEPENDS += "libcap-ng libcgroup libpam"
 
 inherit selinux
-DEPENDS += "${@target_selinux(d, 'libcap-ng libcgroup libpam audit')}"
+DEPENDS += "${@target_selinux(d, 'audit')}"
 
 RDEPENDS_${BPN} += "\
 	libselinux-python \

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#2 lore raw
Quoted 6 lines · On Thursday 07 March 2013 17:05:42 Martin Jansa wrote:
Quoted 5 lines · Amy Fong

policyutilutils: needs some dependencies unconditionally

policycoreutils will fail to compile if selinux isn't in the DISTROFEATURES. We move these packages out of @target_selinux.

Quoted 6 lines
Quoted 1 line

Where is this meta-selinux layer?

I don't see it on
http://www.openembedded.org/wiki/LayerIndex

I think this was an oversight. I've just added it in any case.

Quoted 1 line

Was this meant for [email protected]?

According to the MAINTAINERS file in the layer, patches should be sent to [email protected]. Amy, could you please re-send your patch there?

Quoted 2 lines

And BTW: use better syntax for PRINC to allow multiple .bbappends.. hmm well you're having PRINC in .inc.. interesting.

Yes that's probably not best practice.

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre