regulator: Fix memory garbage dev_err printout.
PATCH 1/1 regulator: Fix memory garbage dev_err printout.
commit dd8004af: 'regulator: core: Log when a device causes a voltage constraint fail', tried to print out some information about the check consumer min/max uV fixup, however, it uses a garbage pointer left over from list_for_each_entry leading to boot messages in the form:
'[ 2.079890] <RANDOM ASCII>: Restricting voltage, 3735899821-4294967295uV'
Because it references regulator->dev, it could potentially read memory from anywhere causing a panic.
This patch instead uses rdev and the updated min/max uV values.
--- drivers/regulator/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/regulator/core.c +2 -2
@@ -200,8 +200,8 @@ static int regulator_check_consumers(struct regulator_dev *rdev, }if (*min_uV > *max_uV) { -dev_err (regulator->dev,"Restricting voltage, %u-%uuV\n" , - regulator->min_uV, regulator->max_uV); +rdev_err (rdev,"Restricting voltage, %u-%uuV\n" , + *min_uV, *max_uV);return -EINVAL ; }
Signature · 1 line
1.8.1.2
Mark Brown
AppliedQuoted 5 lines · Russ Dill
commit
dd8004af: 'regulator: core: Log when a device causes a voltage constraint fail', tried to print out some information about the check consumer min/max uV fixup, however, it uses a garbage pointer left over fromlist_for_each_entryleading to boot messages in the form:
Applied, thanks.