Skip to contentSkip to conversation

Added ti-multiproc manager recipe for KeyStone2 devices

PATCH In review Sajesh Kumar Saran 2 participants 4 messages Feb 14, 2013 – Feb 15, 2013 Broadcom iproc Arm architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Added ti-multiproc manager recipe for KeyStone2 devices

---
 .../multiprocmgr/ti-multiprocmgr_git.bb            |   19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_git.bb
meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_git.bb new file +19 -0
new file mode 100644
index 0000000..c72bc7d
@@ -0,0 +1,19 @@
+DESCRIPTION = "TI Multiproc Manager for KeyStone II"
+HOMEPAGE = "http://gtgit01.gt.design.ti.com/git/?p=projects/multiprocmgr.git;a=summary"
+LICENSE = "BSD & MIT"
+LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=fce208c498eb9669223724dc9c1d8fe4"
+SECTION = "console"
+
+PR = "r2"
+
+BRANCH ?= "master"
+SRCREV = "${AUTOREV}"
+
+SRC_URI = "git://gtgit01.gt.design.ti.com/git/projects/multiprocmgr.git;protocol=git;branch=${BRANCH}"
+
+S = "${WORKDIR}/git"
+
+do_install() {
+	install -d ${D}${bindir}/
+	install -c -m 755 ${S}/mpmsrv ${D}${bindir}/mpmsrv
+}
Signature · 1 line
1.7.9.5
#1 lore raw

Sajesh,

Thanks for submitting your patch to the list. It mostly looks good, but here are few comments:

[PATCH] Added ti-multiproc manager recipe for KeyStone2 devices

Please follow the OpenEmbedded Patch Message Guidelines:
http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

Basically, it means the commit/patch subject should look like this:

[PATCH] multiprocmgr: add initial version

meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_git.bb

Quoted 12 lines · Sajesh Kumar Saran
---
 .../multiprocmgr/ti-multiprocmgr_git.bb            |   19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_git.bb
meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_git.bb new file +0 -0
new file mode 100644
index 0000000..c72bc7d

I don't mind it too much, but do we still need to abuse ti-* prefix for our own software? Can it be simply multiprocmgr?

meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_git.bb line 5

Quoted 6 lines
meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_git.bb new file +5 -0
@@ -0,0 +1,19 @@
+DESCRIPTION = "TI Multiproc Manager for KeyStone II"
+HOMEPAGE = "http://gtgit01.gt.design.ti.com/git/?p=projects/multiprocmgr.git;a=summary"
+LICENSE = "BSD & MIT"
+LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=fce208c498eb9669223724dc9c1d8fe4"
+SECTION = "console"

If you really want this to be available to Keystone machines, you'd want:

COMPATIBLE_MACHINE = "keystone"

meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_git.bb line 7

Quoted 1 line
meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_git.bb new file +1 -0
+PR = "r2"

I don't usually complain about PR being out of sequence, or starting with 1 vs. 0, but other people may find this a problem. Just FYI...

meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_git.bb line 12

Quoted 4 lines
meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_git.bb new file +3 -0
+BRANCH ?= "master"
 
+SRCREV = "${AUTOREV}"
+SRC_URI = "git://gtgit01.gt.design.ti.com/git/projects/multiprocmgr.git;protocol=git;branch=${BRANCH}"

The use of AUTOREV and non-public internal git repository would break parsing for anyone doing builds outside of TI network.

Using non-public internal git repository temporarily until you get your project published externally is somewhat acceptable. And AUTOREV in rare cases is also acceptable, although it's quite unstable. But definitely don't use them both.

Quoted 8 lines
meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_git.bb new file +6 -0
+S = "${WORKDIR}/git"
+
+do_install() {
+	install -d ${D}${bindir}/
+	install -c -m 755 ${S}/mpmsrv ${D}${bindir}/mpmsrv
+}
Signature · 1 line
1.7.9.5
#2 lore raw

The internal git repo is temporary. It will be moved to external soon.

What do you want me to put in instead of AUTOREV?

Regards,
Sajesh

-----Original Message-----
From: Dmytriyenko, Denys
Sent: Thursday, February 14, 2013 8:21 PM
To: Saran, Sajesh Kumar
Cc: [email protected]
Subject: Re: [meta-arago] [PATCH] Added ti-multiproc manager recipe for KeyStone2 devices

Sajesh,

Thanks for submitting your patch to the list. It mostly looks good, but here are few comments:

[PATCH] Added ti-multiproc manager recipe for KeyStone2 devices

Please follow the OpenEmbedded Patch Message Guidelines:
http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

Basically, it means the commit/patch subject should look like this:

[PATCH] multiprocmgr: add initial version

Quoted 17 lines · Sajesh Kumar Saran
---
 .../multiprocmgr/ti-multiprocmgr_git.bb            |   19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 

meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_git.bb

(quoted diff) +0 -0

a/meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_git. bb b/meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_git. bb
new file mode 100644
index 0000000..c72bc7d

meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_

Quoted 1 line
meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_ new file +1 -0
+++ git.bb

I don't mind it too much, but do we still need to abuse ti-* prefix for our own software? Can it be simply multiprocmgr?

meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_ line 5

Quoted 6 lines
meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_ new file +5 -0
@@ -0,0 +1,19 @@
+DESCRIPTION = "TI Multiproc Manager for KeyStone II"
+HOMEPAGE = "http://gtgit01.gt.design.ti.com/git/?p=projects/multiprocmgr.git;a=summary"
+LICENSE = "BSD & MIT"
+LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=fce208c498eb9669223724dc9c1d8fe4"
+SECTION = "console"

If you really want this to be available to Keystone machines, you'd want:

COMPATIBLE_MACHINE = "keystone"

meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_ line 6

Quoted 1 line
meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_ new file +1 -0
+PR = "r2"

I don't usually complain about PR being out of sequence, or starting with 1 vs. 0, but other people may find this a problem. Just FYI...

meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_

Quoted 4 lines
meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_ new file +3 -0
+BRANCH ?= "master"
 
+SRCREV = "${AUTOREV}"
+SRC_URI = "git://gtgit01.gt.design.ti.com/git/projects/multiprocmgr.git;protocol=git;branch=${BRANCH}"

The use of AUTOREV and non-public internal git repository would break parsing for anyone doing builds outside of TI network.

Using non-public internal git repository temporarily until you get your project published externally is somewhat acceptable. And AUTOREV in rare cases is also acceptable, although it's quite unstable. But definitely don't use them both.

Quoted 8 lines
meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_ new file +6 -0
+S = "${WORKDIR}/git"
+
+do_install() {
+	install -d ${D}${bindir}/
+	install -c -m 755 ${S}/mpmsrv ${D}${bindir}/mpmsrv
+}
Signature · 1 line
1.7.9.5
#3 lore raw
Quoted 1 line · Sajesh Kumar

The internal git repo is temporary. It will be moved to external soon.

Yes, I know, as I was part of the discussion deciding where to host it - git.ti.com or arago-project.org...

Quoted 1 line

What do you want me to put in instead of AUTOREV?

Latest commit for now would be fine. Once your code matures, you can point it to the latest stable release.

Signature · 1 line
Denys
Quoted 84 lines

-----Original Message-----
From: Dmytriyenko, Denys
Sent: Thursday, February 14, 2013 8:21 PM
To: Saran, Sajesh Kumar
Cc: [email protected]
Subject: Re: [meta-arago] [PATCH] Added ti-multiproc manager recipe for KeyStone2 devices

Sajesh,

Thanks for submitting your patch to the list. It mostly looks good, but here are few comments:

[PATCH] Added ti-multiproc manager recipe for KeyStone2 devices

Please follow the OpenEmbedded Patch Message Guidelines:
http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

Basically, it means the commit/patch subject should look like this:

[PATCH] multiprocmgr: add initial version

Quoted 17 lines · Sajesh Kumar Saran
---
 .../multiprocmgr/ti-multiprocmgr_git.bb            |   19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 

meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_git.bb

(quoted diff) +0 -0

a/meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_git. bb b/meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_git. bb
new file mode 100644
index 0000000..c72bc7d

meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_

Quoted 1 line
meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_ new file +1 -0
+++ git.bb

I don't mind it too much, but do we still need to abuse ti-* prefix for our own software? Can it be simply multiprocmgr?

meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_ line 5

Quoted 6 lines
meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_ new file +5 -0
@@ -0,0 +1,19 @@
+DESCRIPTION = "TI Multiproc Manager for KeyStone II"
+HOMEPAGE = "http://gtgit01.gt.design.ti.com/git/?p=projects/multiprocmgr.git;a=summary"
+LICENSE = "BSD & MIT"
+LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=fce208c498eb9669223724dc9c1d8fe4"
+SECTION = "console"

If you really want this to be available to Keystone machines, you'd want:

COMPATIBLE_MACHINE = "keystone"

meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_ line 6

Quoted 1 line
meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_ new file +1 -0
+PR = "r2"

I don't usually complain about PR being out of sequence, or starting with 1 vs. 0, but other people may find this a problem. Just FYI...

meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_

Quoted 4 lines
meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_ new file +3 -0
+BRANCH ?= "master"
 
+SRCREV = "${AUTOREV}"
+SRC_URI = "git://gtgit01.gt.design.ti.com/git/projects/multiprocmgr.git;protocol=git;branch=${BRANCH}"

The use of AUTOREV and non-public internal git repository would break parsing for anyone doing builds outside of TI network.

Using non-public internal git repository temporarily until you get your project published externally is somewhat acceptable. And AUTOREV in rare cases is also acceptable, although it's quite unstable. But definitely don't use them both.

Quoted 8 lines
meta-arago-distro/recipes-devtools/multiprocmgr/ti-multiprocmgr_ new file +6 -0
+S = "${WORKDIR}/git"
+
+do_install() {
+	install -d ${D}${bindir}/
+	install -c -m 755 ${S}/mpmsrv ${D}${bindir}/mpmsrv
+}
Signature · 1 line
1.7.9.5