Skip to contentSkip to conversation

comments removed

test Hemanth Kumar 2 participants 3 messages Feb 15, 2013 Btrfs file system

lore
Share & tools
lore
#0 lore raw
---
 0001-heirarchical-quotas-test-case.patch | 44 ++++++++++++++++++++++++++++++++
 hquotas.sh                               |  2 --
 2 files changed, 44 insertions(+), 2 deletions(-)
 create mode 100644 0001-heirarchical-quotas-test-case.patch
0001-heirarchical-quotas-test-case.patch new file +44 -0
new file mode 100644
index 0000000..c6577e0
@@ -0,0 +1,44 @@
+From 9f49a870eab70ae37028f937331f9ec1b67dadb1 Mon Sep 17 00:00:00 2001
+From: Hemanth Kumar <[email protected]>
+Date: Fri, 15 Feb 2013 11:21:03 +0530
+Subject: [test] heirarchical quotas test case
+
+
+Signed-off-by: Hemanth Kumar <[email protected]>
+---
+ hquotas.sh | 8 ++++----
+ 1 file changed, 4 insertions(+), 4 deletions(-)
+
+diff --git a/hquotas.sh b/hquotas.sh
+index 2eaae01..a870d4a 100644
+--- a/hquotas.sh
++++ b/hquotas.sh
+@@ -1,7 +1,5 @@
+ #! /bin/bash
+-# btrfs quotas test case
+-#[email protected] [email protected]
+-
++# btrfs hierarchical quotas test case
+ #here=`pwd`
+ #tmp=/sample
+ status=1
+@@ -11,6 +9,8 @@ cleanup()
+ 	btrfs subvolume delete $TEST_DIR/vol1/vol2/vol3
+ 	btrfs subvolume delete $TEST_DIR/vol1/vol2
+ 	btrfs subvolume delete $TEST_DIR/vol1
++	btrfs quota disable $TEST_DIR
++	echo"quota disabled"
+ }
+ 
+ #trap "_cleanup ; exit \$status" 0 1 2 3 15
+@@ -25,6 +25,6 @@ btrfs qgroup limit 3m $TEST_DIR/vol1/vol2
+ btrfs qgroup limit 1m $TEST_DIR/vol1/vol2/vol3
+ dd if=$TEST_DEV of=$TEST_DIR/vol1/vol2/vol3/file3 bs=2M count=1
+ dd if=$TEST_DEV of=$TEST_DIR/vol1/vol2/file2 bs=1M count=1
+-dd if=$TEST_DEV of=$TEST_DIR/vol1/file1 bs=5M count=1
++dd if=$TEST_DEV of=$TEST_DIR/vol1/file1 bs=4M count=1
+ cleanup
+ exit
+-- 
+1.8.1.2
+
hquotas.sh +0 -2
index a870d4a..672b6d1 100644
@@ -1,7 +1,5 @@
 #! /bin/bash
 # btrfs hierarchical quotas test case
-#here=`pwd`
-#tmp=/sample
 status=1
 
 cleanup()
Signature · 1 line
1.8.1.2
#1 lore raw

On Fri, Feb 15, 2013 at 11:59:15AM +0530, Hemanth Kumar wrote:

No description of what the patch does. You should probably also put
[btrfs-progs] in the subject line, if you're patching against btrfs-progs (and in that case, you probably don't need to cc the xfs people).

More comments below.

Hugo.

Quoted 3 lines
---
 0001-heirarchical-quotas-test-case.patch | 44 ++++++++++++++++++++++++++++++++

hierarchical

0001-heirarchical-quotas-test-case.patch

Quoted 5 lines
 hquotas.sh                               |  2 --
 2 files changed, 44 insertions(+), 2 deletions(-)
 create mode 100644 0001-heirarchical-quotas-test-case.patch
0001-heirarchical-quotas-test-case.patch +0 -0

And here

0001-heirarchical-quotas-test-case.patch

Quoted 4 lines

new file mode 100644
index 0000000..c6577e0

0001-heirarchical-quotas-test-case.patch new file +0 -0

And here

0001-heirarchical-quotas-test-case.patch line 7

Quoted 8 lines
0001-heirarchical-quotas-test-case.patch new file +7 -0
@@ -0,0 +1,44 @@
+From 9f49a870eab70ae37028f937331f9ec1b67dadb1 Mon Sep 17 00:00:00 2001
+From: Hemanth Kumar <[email protected]>
+Date: Fri, 15 Feb 2013 11:21:03 +0530
+Subject: [test] heirarchical quotas test case
+
+
+Signed-off-by: Hemanth Kumar <[email protected]>

You're sending a patch file that creates a patch file? This is wrong.

Quoted 49 lines
0001-heirarchical-quotas-test-case.patch new file +37 -0
+---
+ hquotas.sh | 8 ++++----
+ 1 file changed, 4 insertions(+), 4 deletions(-)
+
+diff --git a/hquotas.sh b/hquotas.sh
+index 2eaae01..a870d4a 100644
+--- a/hquotas.sh
++++ b/hquotas.sh
+@@ -1,7 +1,5 @@
+ #! /bin/bash
+-# btrfs quotas test case
+-#[email protected] [email protected]
+-
++# btrfs hierarchical quotas test case
+ #here=`pwd`
+ #tmp=/sample
+ status=1
+@@ -11,6 +9,8 @@ cleanup()
+ 	btrfs subvolume delete $TEST_DIR/vol1/vol2/vol3
+ 	btrfs subvolume delete $TEST_DIR/vol1/vol2
+ 	btrfs subvolume delete $TEST_DIR/vol1
++	btrfs quota disable $TEST_DIR
++	echo"quota disabled"
+ }
+ 
+ #trap "_cleanup ; exit \$status" 0 1 2 3 15
+@@ -25,6 +25,6 @@ btrfs qgroup limit 3m $TEST_DIR/vol1/vol2
+ btrfs qgroup limit 1m $TEST_DIR/vol1/vol2/vol3
+ dd if=$TEST_DEV of=$TEST_DIR/vol1/vol2/vol3/file3 bs=2M count=1
+ dd if=$TEST_DEV of=$TEST_DIR/vol1/vol2/file2 bs=1M count=1
+-dd if=$TEST_DEV of=$TEST_DIR/vol1/file1 bs=5M count=1
++dd if=$TEST_DEV of=$TEST_DIR/vol1/file1 bs=4M count=1
+ cleanup
+ exit
+-- 
+1.8.1.2
+
hquotas.sh +0 -2
index a870d4a..672b6d1 100644
@@ -1,7 +1,5 @@
 #! /bin/bash
 # btrfs hierarchical quotas test case
-#here=`pwd`
-#tmp=/sample
 status=1
 
 cleanup()
Signature · 3 lines
=== Hugo Mills: hugo@... carfax.org.uk | darksatanic.net | lug.org.uk ===
  PGP key: 515C238D from wwwkeys.eu.pgp.net or http://www.carfax.org.uk
                    --- Beware geeks bearing GIFs ---                    
#2 lore raw

Thanks for the instructions will follow it without fail.

Quoted 91 lines · Hugo Mills

On Fri, Feb 15, 2013 at 11:59:15AM +0530, Hemanth Kumar wrote:

No description of what the patch does. You should probably also put
[btrfs-progs] in the subject line, if you're patching against btrfs-progs (and in that case, you probably don't need to cc the xfs people).

More comments below.

Hugo.

Quoted 3 lines
---
 0001-heirarchical-quotas-test-case.patch | 44 ++++++++++++++++++++++++++++++++

hierarchical

0001-heirarchical-quotas-test-case.patch

Quoted 5 lines
 hquotas.sh                               |  2 --
 2 files changed, 44 insertions(+), 2 deletions(-)
 create mode 100644 0001-heirarchical-quotas-test-case.patch
0001-heirarchical-quotas-test-case.patch +0 -0

And here

0001-heirarchical-quotas-test-case.patch

Quoted 4 lines

new file mode 100644
index 0000000..c6577e0

0001-heirarchical-quotas-test-case.patch new file +0 -0

And here

0001-heirarchical-quotas-test-case.patch line 7

Quoted 8 lines
0001-heirarchical-quotas-test-case.patch new file +7 -0
@@ -0,0 +1,44 @@
+From 9f49a870eab70ae37028f937331f9ec1b67dadb1 Mon Sep 17 00:00:00 2001
+From: Hemanth Kumar <[email protected]>
+Date: Fri, 15 Feb 2013 11:21:03 +0530
+Subject: [test] heirarchical quotas test case
+
+
+Signed-off-by: Hemanth Kumar <[email protected]>

You're sending a patch file that creates a patch file? This is wrong.

Quoted 48 lines
0001-heirarchical-quotas-test-case.patch new file +37 -0
+---
+ hquotas.sh | 8 ++++----
+ 1 file changed, 4 insertions(+), 4 deletions(-)
+
+diff --git a/hquotas.sh b/hquotas.sh
+index 2eaae01..a870d4a 100644
+--- a/hquotas.sh
++++ b/hquotas.sh
+@@ -1,7 +1,5 @@
+ #! /bin/bash
+-# btrfs quotas test case
+-#[email protected] [email protected]
+-
++# btrfs hierarchical quotas test case
+ #here=`pwd`
+ #tmp=/sample
+ status=1
+@@ -11,6 +9,8 @@ cleanup()
+     btrfs subvolume delete $TEST_DIR/vol1/vol2/vol3
+     btrfs subvolume delete $TEST_DIR/vol1/vol2
+     btrfs subvolume delete $TEST_DIR/vol1
++    btrfs quota disable $TEST_DIR
++    echo"quota disabled"
+ }
+
+ #trap "_cleanup ; exit \$status" 0 1 2 3 15
+@@ -25,6 +25,6 @@ btrfs qgroup limit 3m $TEST_DIR/vol1/vol2
+ btrfs qgroup limit 1m $TEST_DIR/vol1/vol2/vol3
+ dd if=$TEST_DEV of=$TEST_DIR/vol1/vol2/vol3/file3 bs=2M count=1
+ dd if=$TEST_DEV of=$TEST_DIR/vol1/vol2/file2 bs=1M count=1
+-dd if=$TEST_DEV of=$TEST_DIR/vol1/file1 bs=5M count=1
++dd if=$TEST_DEV of=$TEST_DIR/vol1/file1 bs=4M count=1
+ cleanup
+ exit
+--
+1.8.1.2
+
hquotas.sh +0 -2
index a870d4a..672b6d1 100644
@@ -1,7 +1,5 @@
 #! /bin/bash
 # btrfs hierarchical quotas test case
-#here=`pwd`
-#tmp=/sample
 status=1
 
Quoted 6 lines

hquotas.sh line 5

Quoted 1 line
hquotas.sh +0 -0
 cleanup()

--
=== Hugo Mills: hugo@... carfax.org.uk | darksatanic.net | lug.org.uk ===
PGP key: 515C238D from wwwkeys.eu.pgp.net or http://www.carfax.org.uk
--- Beware geeks bearing GIFs ---

--
Thanks,
Hemanth Kumar H C