Skip to contentSkip to conversation

clk-fixed-factor: Using parent flags

PATCH In review Alexander Shiyan 2 participants 2 messages Feb 15, 2013 Common clk

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk-fixed-factor: Using parent flags

This patch allow using parent flags for newly created clocks, so if parent clock, for example, have flag CLK_ALWAYS_ENABLED, we will use it.

---
 drivers/clk/clk-fixed-factor.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
drivers/clk/clk-fixed-factor.c +5 -0
index 52e7c16..56aa63e 100644
@@ -43,6 +43,7 @@ struct clk *clk_fixed_factor(const char *name,
 		const char *parent, unsigned int mult, unsigned int div)
 {
 	struct clk_fixed_factor *f = xzalloc(sizeof(*f));
+	struct clk *parent_clk;
 	int ret;
 
 	f->mult = mult;
@@ -53,6 +54,10 @@ struct clk *clk_fixed_factor(const char *name,
 	f->clk.parent_names = &f->parent;
 	f->clk.num_parents = 1;
 
+	parent_clk = clk_lookup(parent);
+	if (!IS_ERR(parent_clk))
+		f->clk.flags = parent_clk->flags;
+
 	ret = clk_register(&f->clk);
 	if (ret) {
 		free(f);
Signature · 7 lines
1.7.3.4


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#1 lore raw
Quoted 21 lines · Alexander Shiyan

This patch allow using parent flags for newly created clocks, so if parent clock, for example, have flag CLK_ALWAYS_ENABLED, we will use it.

---
 drivers/clk/clk-fixed-factor.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
drivers/clk/clk-fixed-factor.c +1 -0
index 52e7c16..56aa63e 100644
@@ -43,6 +43,7 @@ struct clk *clk_fixed_factor(const char *name,
 		const char *parent, unsigned int mult, unsigned int div)
 {
 	struct clk_fixed_factor *f = xzalloc(sizeof(*f));
+	struct clk *parent_clk;
 	int ret;
 
 	f->mult = mult;

drivers/clk/clk-fixed-factor.c struct clk *clk_fixed_factor(const char *name, · line 60

Quoted 7 lines
drivers/clk/clk-fixed-factor.c +4 -0
@@ -53,6 +54,10 @@ struct clk *clk_fixed_factor(const char *name,
 	f->clk.parent_names = &f->parent;
 	f->clk.num_parents = 1;
 
+	parent_clk = clk_lookup(parent);
+	if (!IS_ERR(parent_clk))
+		f->clk.flags = parent_clk->flags;
+

So we unconditionally overwrite the fixed factor clock flags. As long as CLK_ALWAYS_ENABLED is the only flag we have this might be ok, but this will lead to strange behaviour when we get other flags.

There should rather be some mechanism which detects that a clock must be enabled because all parents have no disable callback or have the CLK_ALWAYS_ENABLED flag set.

I have no idea currently though how to implement this.

Sascha

Signature · 9 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox