Skip to contentSkip to conversation

mfd: Make AB8500_CORE select POWER_SUPPLY to fix build error

PATCH Applied Axel Lin 3 participants 3 messages Feb 19, 2013 – Mar 13, 2013 Multifunction devices (MFD)

lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 mfd: Make AB8500_CORE select POWER_SUPPLY to fix build error

This patch fixes below build error when CONFIG_POWER_SUPPLY is not set.

drivers/built-in.o: In function `ab8500_power_off':
drivers/mfd/ab8500-sysctrl.c:37: undefined reference to power_supply_get_by_name' drivers/mfd/ab8500-sysctrl.c:53: undefined reference to power_supply_get_by_name'
make: *** [vmlinux] Error 1

---
 drivers/mfd/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/mfd/Kconfig +1 -0
index 671f5b1..c346941 100644
@@ -858,6 +858,7 @@ config EZX_PCAP
 config AB8500_CORE
 	bool "ST-Ericsson AB8500 Mixed Signal Power Management chip"
 	depends on GENERIC_HARDIRQS && ABX500_CORE && MFD_DB8500_PRCMU
+	select POWER_SUPPLY
 	select MFD_CORE
 	select IRQ_DOMAIN
 	help
Signature · 1 line
1.7.9.5
Acked-by on v1 1/1
#1 lore raw
Quoted 17 lines · Axel Lin

This patch fixes below build error when CONFIG_POWER_SUPPLY is not set.

drivers/built-in.o: In function `ab8500_power_off':
drivers/mfd/ab8500-sysctrl.c:37: undefined reference to power_supply_get_by_name' drivers/mfd/ab8500-sysctrl.c:53: undefined reference to power_supply_get_by_name'
make: *** [vmlinux] Error 1

---
 drivers/mfd/Kconfig |    1 +
 1 file changed, 1 insertion(+)
drivers/mfd/Kconfig +0 -0
index 671f5b1..c346941 100644

drivers/mfd/Kconfig config EZX_PCAP · line 864

Quoted 7 lines
drivers/mfd/Kconfig +1 -0
@@ -858,6 +858,7 @@ config EZX_PCAP
 config AB8500_CORE
 	bool "ST-Ericsson AB8500 Mixed Signal Power Management chip"
 	depends on GENERIC_HARDIRQS && ABX500_CORE && MFD_DB8500_PRCMU
+	select POWER_SUPPLY
 	select MFD_CORE
 	select IRQ_DOMAIN
 	help

I noticed and was going to fix this up myself - it's the right thing to do.

Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Applied
#2 lore raw
In reply to Axel Lin

Hi Axel,

Quoted 11 lines · Axel Lin

This patch fixes below build error when CONFIG_POWER_SUPPLY is not set.

drivers/built-in.o: In function `ab8500_power_off':
drivers/mfd/ab8500-sysctrl.c:37: undefined reference to power_supply_get_by_name' drivers/mfd/ab8500-sysctrl.c:53: undefined reference to power_supply_get_by_name'
make: *** [vmlinux] Error 1

---
 drivers/mfd/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Applied to my mfd-fixes tree.

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/