Skip to contentSkip to conversation

workqueue [delayed_]work_pending() cleanups for 3.9-rc1

GIT PULL Tejun Heo 1 participant 1 message Feb 19, 2013

lore
Share & tools
lore

Tejun Heo

author
#0 lore raw

Hello, Linus.

This is part of on-going cleanups to remove / minimize usages of workqueue interfaces which are deprecated and/or misleading. This round drops a number of usages of [delayed_]work_pending(), which are dangerous as they lack any form of synchronization and thus often lead to buggy / unnecessary code. There are a couple legitimate use cases in kernel. Hopefully, they can be converted and [delayed_]work_pending() can be removed completely. Even if not, removing most of misuses should make it more difficult to find examples of misuses and thus slow down growth of them.

These changes are independent from other workqueue changes.

The changes are available in the following git branch

git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git for-3.9-cleanups

for you to fetch changes up to 23663c873154f01220ef679558e1ca110c4c4ca4:

wimax/i2400m: fix i2400m->wake_tx_skb handling (2013-02-09 11:34:19 -0800)

----------------------------------------------------------------
Tejun Heo (11):
sja1000: don't use [delayed_]work_pending()
mwifiex: don't use [delayed_]work_pending()
thinkpad_acpi: don't use [delayed_]work_pending()
wl1251: don't use [delayed_]work_pending()
rfkill: don't use [delayed_]work_pending() x86/mce: don't use [delayed_]work_pending() tty/max3100: don't use [delayed_]work_pending() video/exynos: don't use [delayed_]work_pending()
ipw2x00: simplify scan_event handling
kprobes: fix wait_for_kprobe_optimizer() wimax/i2400m: fix i2400m->wake_tx_skb handling

 arch/x86/kernel/cpu/mcheck/mce.c       | 14 +++-----------
 drivers/net/can/sja1000/peak_pci.c     |  3 +--
 drivers/net/wimax/i2400m/netdev.c      | 31 +++++++++++++++++--------------
 drivers/net/wireless/ipw2x00/ipw2100.c | 31 ++++++++-----------------------
 drivers/net/wireless/ipw2x00/ipw2100.h |  3 +--
 drivers/net/wireless/ipw2x00/ipw2200.c | 13 +++----------
 drivers/net/wireless/mwifiex/sdio.c    |  9 ++++-----
 drivers/net/wireless/ti/wl1251/ps.c    |  3 +--
 drivers/platform/x86/thinkpad_acpi.c   |  3 +--
 drivers/tty/serial/max3100.c           |  3 +--
 drivers/video/exynos/exynos_dp_core.c  |  6 ++----
 kernel/kprobes.c                       | 23 +++++++++++++++--------
 net/rfkill/input.c                     |  8 +++-----
 13 files changed, 60 insertions(+), 90 deletions(-)

Thanks.

--
tejun